Matěj Suchánek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348233 )
Change subject: Do not exceed limit of 50 pageids ...................................................................... Do not exceed limit of 50 pageids AllpagesGenerator (and possibly others) returns pages with their ids. When reused in PreloadingGenerator, this generates a warning and truncates the series of pages to 50 at most. Bug: T78333 Bug: T161783 Change-Id: I240b0f998d5ef9c6438338da9572bdde265a3699 --- M pywikibot/site.py M scripts/category_redirect.py 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core refs/changes/33/348233/2 diff --git a/pywikibot/site.py b/pywikibot/site.py index a16bdea..7178613 100644 --- a/pywikibot/site.py +++ b/pywikibot/site.py @@ -3257,7 +3257,8 @@ next_prio = 0 rvgen = api.PropertyGenerator(props, site=self) rvgen.set_maximum_items(-1) # suppress use of "rvlimit" parameter - if len(pageids) == len(sublist): + if (len(pageids) == len(sublist) + and len(pageids) <= 50): # xxx: T78333, T161783 # only use pageids if all pages have them rvgen.request['pageids'] = set(pageids) else: diff --git a/scripts/category_redirect.py b/scripts/category_redirect.py index 65aae8d..d616d4f 100755 --- a/scripts/category_redirect.py +++ b/scripts/category_redirect.py @@ -223,9 +223,8 @@ comment = i18n.twtranslate(self.site, self.redir_comment) # generator yields all hard redirect pages in namespace 14 - for page in pagegenerators.PreloadingGenerator( - self.site.allpages(namespace=14, filterredir=True), - groupsize=250): + for page in self.site.allpages(namespace=14, filterredir=True, + content=True): if page.isCategoryRedirect(): # this is already a soft-redirect, so skip it (for now) continue -- To view, visit https://gerrit.wikimedia.org/r/348233 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I240b0f998d5ef9c6438338da9572bdde265a3699 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Matěj Suchánek <matejsuchane...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits