jenkins-bot has submitted this change and it was merged.
Change subject: registration: Add --config-prefix to
convertExtensionToRegistration.php
......................................................................
registration: Add --config-prefix to convertExtensionToRegistration.php
For converting extensions that use custom prefixes.
Change-Id: I4fcf7ff2af04e9a0367de368503f2c70d8fed959
---
M maintenance/convertExtensionToRegistration.php
1 file changed, 12 insertions(+), 2 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/convertExtensionToRegistration.php
b/maintenance/convertExtensionToRegistration.php
index aab2087..7c87e10 100644
--- a/maintenance/convertExtensionToRegistration.php
+++ b/maintenance/convertExtensionToRegistration.php
@@ -59,6 +59,7 @@
$this->addArg( 'path', 'Location to the PHP entry point you
wish to convert',
/* $required = */ true );
$this->addOption( 'skin', 'Whether to write to skin.json',
false, false );
+ $this->addOption( 'config-prefix', 'Custom prefix for
configuration settings', false, true );
}
protected function getAllGlobals() {
@@ -92,6 +93,10 @@
$this->dir = dirname( realpath( $this->getArg( 0 ) ) );
$this->json = [];
$globalSettings = $this->getAllGlobals();
+ $configPrefix = $this->getOption( 'config-prefix', 'wg' );
+ if ( $configPrefix !== 'wg' ) {
+ $this->json['config']['_prefix'] = $configPrefix;
+ }
foreach ( $vars as $name => $value ) {
$realName = substr( $name, 2 ); // Strip 'wg'
if ( $realName === false ) {
@@ -113,9 +118,14 @@
$this->noLongerSupportedGlobals[$realName] . '). ' .
"Please update the entry point before
convert to registration.\n" );
$this->hasWarning = true;
- } elseif ( strpos( $name, 'wg' ) === 0 ) {
+ } elseif ( strpos( $name, $configPrefix ) === 0 ) {
// Most likely a config setting
- $this->json['config'][$realName] = $value;
+ $this->json['config'][substr( $name, strlen(
$configPrefix ) )] = $value;
+ } elseif ( $configPrefix !== 'wg' && strpos( $name,
'wg' ) === 0 ) {
+ // Warn about this
+ $this->output( 'Warning: Skipped global "' .
$name . '" (' .
+ 'config prefix is "' . $configPrefix .
'"). ' .
+ "Please check that this setting isn't
needed.\n" );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/290713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fcf7ff2af04e9a0367de368503f2c70d8fed959
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Parent5446 <tylerro...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
