Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/215382
Change subject: resourceloader: Remove redundant getModifiedTime implementation ...................................................................... resourceloader: Remove redundant getModifiedTime implementation Follows-up f37cee996e which replaced the getHashMtime() and getDefinitionMtime() methods with dummies that always return 1. These getModifiedTime() implementation was only tracking the hash, which is already tracked by getVersionHash(). Change-Id: I6e37c3c2f85ef4599a8643b0efabc18de2f51ec4 --- M includes/CNBannerChoiceDataResourceLoaderModule.php 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice refs/changes/82/215382/1 diff --git a/includes/CNBannerChoiceDataResourceLoaderModule.php b/includes/CNBannerChoiceDataResourceLoaderModule.php index 6cb8a70..b9ce987 100644 --- a/includes/CNBannerChoiceDataResourceLoaderModule.php +++ b/includes/CNBannerChoiceDataResourceLoaderModule.php @@ -126,13 +126,6 @@ } /** - * @see ResourceLoaderModule::getModifiedTime() - */ - public function getModifiedTime( ResourceLoaderContext $context ) { - return max( 1, $this->getHashMtime( $context ) ); - } - - /** * @see ResourceLoaderModule::getModifiedHash() */ public function getModifiedHash( ResourceLoaderContext $context ) { -- To view, visit https://gerrit.wikimedia.org/r/215382 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6e37c3c2f85ef4599a8643b0efabc18de2f51ec4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits