jenkins-bot has submitted this change and it was merged.
Change subject: test: Disable phpunit "strictCoverage" option
......................................................................
test: Disable phpunit "strictCoverage" option
Replace "strict" (deprecated in PHPUnit 4.5, though we're not
using that yet) with separate options so that we can exclude
strictCoverage, which is currently preventing phpunit-coverage
from being able to collect any data for wikimedia/cdb (everything
ends up marked as "risky" and ignored).
The @covers annotation still make it strict about what to
include in the coverage report.
The behaviour of strictCoverage has never been conventional at
Wikimedia. The reason it is included now is because we upgraded
from PHPUnit 3.7 to 4.4, and the strictCoverage option was not
previously part of "strict".
Change-Id: If893df6cd5e1007b8856942b8b64a43234d6e314
---
M phpunit.xml.dist
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index abbbb58..85058ed 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -1,4 +1,7 @@
-<phpunit colors="true" strict="true">
+<phpunit
+ colors="true"
+ beStrictAboutTestsThatDoNotTestAnything="true"
+ beStrictAboutOutputDuringTests="true">
<testsuites>
<testsuite name="CDB Tests">
<directory>./test</directory>
--
To view, visit https://gerrit.wikimedia.org/r/201972
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If893df6cd5e1007b8856942b8b64a43234d6e314
Gerrit-PatchSet: 2
Gerrit-Project: cdb
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
