Jonas Kress (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/360840 )
Change subject: [WIP] Show query helper in tabs
......................................................................
[WIP] Show query helper in tabs
Change-Id: I5da005489c3f4e532887d73303f6986588d76c21
---
M i18n/en.json
M index.html
M style.css
3 files changed, 31 insertions(+), 22 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui
refs/changes/40/360840/1
diff --git a/i18n/en.json b/i18n/en.json
index 75d8180..0c400e9 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -21,6 +21,8 @@
"wdqs-app-button-download-title": "Download result",
"wdqs-app-button-link": "Link",
"wdqs-app-button-link-title": "Get link to query",
+ "wdqs-app-tab-editor": "Editor",
+ "wdqs-app-tab-helper": "Helper",
"wdqs-app-help-feedback": "Give Feedback!",
"wdqs-app-help-request-query": "Request a query",
"wdqs-app-help-portal": "Help Portal",
diff --git a/index.html b/index.html
index bb222ff..9326bb2 100644
--- a/index.html
+++ b/index.html
@@ -105,8 +105,35 @@
<div id="query-box">
<form id="query-form">
- <textarea class="queryEditor"
name="query" data-i18n="[placeholder]wdqs-app-editor-placeholder"
placeholder="(Input a SPARQL query or choose a query example)"></textarea>
- <div class="status navbar navbar-default">
+ <div>
+ <!-- Nav tabs -->
+ <ul class="nav nav-tabs"
role="tablist">
+ <li role="presentation"
class="active"><a href="#editor" aria-controls="editor" role="tab"
data-toggle="tab" data-i18n="wdqs-app-tab-editor">Editor</a></li>
+ <li
role="presentation"><a href="#helper" aria-controls="profile" role="tab"
data-toggle="tab" data-i18n="wdqs-app-tab-helper">Helper</a></li>
+ </ul>
+ <!-- Tab panes -->
+ <div class="tab-content">
+ <div role="tabpanel"
class="tab-pane active" id="editor">
+ <textarea
class="queryEditor" name="query"
data-i18n="[placeholder]wdqs-app-editor-placeholder" placeholder="(Input a
SPARQL query or choose a query example)"></textarea>
+ </div>
+ <div role="tabpanel"
class="tab-pane" id="helper">
+ <div
class="query-helper">
+ <div
class="panel panel-info">
+
<div class="panel-heading">
+
<strong data-i18n="wdqs-app-help-queryhelper"></strong> <a
target="_blank" rel="noopener"
href="https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/Query_Helper";><span
+
class="glyphicon glyphicon-question-sign"
+
></span></a>
+
<button type="button" class="close" aria-label="Close">
+
<span aria-hidden="true">×</span>
+
</button>
+
</div>
+
<div class="panel-body"></div>
+ </div>
+ </div>
+ </div>
+ </div>
+ </div>
+ <div class="status navbar
navbar-default">
<div class="navbar-left">
<span data-i18n="[html]wdqs-app-footer-help"></span>
</div>
@@ -161,19 +188,6 @@
</ul>
</nav>
</form>
-
- <a href="#" class="query-helper-trigger"
target="_blank" title="Show query explanation"> <span class="glyphicon
glyphicon-question-sign" aria-hidden="true"></span></a>
- <div class="query-helper">
- <div class="panel panel-info">
- <div class="panel-heading">
- <strong
data-i18n="wdqs-app-help-queryhelper"></strong> <a target="_blank"
rel="noopener"
href="https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/Query_Helper";><span
class="glyphicon glyphicon-question-sign"></span></a>
- <button type="button"
class="close" aria-label="Close">
- <span
aria-hidden="true">×</span>
- </button>
- </div>
- <div class="panel-body"></div>
- </div>
- </div>
<a href="#" class="shareQuery shortUrlTrigger
query" target="_blank" data-i18n="[title]wdqs-app-shorturl-page-title"
data-toggle="popover"> <span class="glyphicon glyphicon-link"
aria-hidden="true"></span></a>
</div>
</div>
diff --git a/style.css b/style.css
index 05f478a..ea9e090 100644
--- a/style.css
+++ b/style.css
@@ -412,14 +412,7 @@
}
.query-helper {
- display: none;
min-width: 400px;
- z-index: 100;
- position: absolute;
- top: 5px;
- right: 45px;
- font-size: 15px;
- padding-left: 35px;
}
.query-helper .panel-info {
--
To view, visit https://gerrit.wikimedia.org/r/360840
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5da005489c3f4e532887d73303f6986588d76c21
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
