jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/366165 )
Change subject: Browser fullscreen toggle
......................................................................
Browser fullscreen toggle
Change-Id: I06d8f723df09611be73d13caeace2fcdf45271fe
---
M style.css
M wikibase/queryService/ui/App.js
2 files changed, 42 insertions(+), 6 deletions(-)
Approvals:
Lucas Werkmeister (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/style.css b/style.css
index 5f8f4ce..eabf3d8 100644
--- a/style.css
+++ b/style.css
@@ -1,5 +1,15 @@
+html {
+ background-color: white;
+}
+
body {
overflow-y: scroll;
+ width: 100%;
+ height: 100%;
+}
+
+.wikibase-queryservice {
+ background-color: white;
}
.error {
margin: 20px;
diff --git a/wikibase/queryService/ui/App.js b/wikibase/queryService/ui/App.js
index 5592514..64127a2 100644
--- a/wikibase/queryService/ui/App.js
+++ b/wikibase/queryService/ui/App.js
@@ -375,12 +375,7 @@
$( '.fullscreen' ).click( function( e ) {
e.preventDefault();
- self._editor.toggleFullscreen();
- self._editor.focus();
-
- var $help = $( '<a target="_blank" rel="noopener"
href="https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/Wikidata_Query_Help/SPARQL_Editor#Editor_Toolbar";>'
)
- .append( $.i18n(
'wdqs-app-toast-leave-fullscreen' ) );
- self._toast( $help, 'wdqs-app-toast-leave-fullscreen' );
+ self._toggleFullscreen();
} );
$( window ).on( 'popstate', $.proxy( this._initQuery, this ) );
@@ -392,6 +387,37 @@
/**
* @private
*/
+ SELF.prototype._toggleFullscreen = function () {
+ if ( document.fullscreenElement ||
document.mozFullScreenElement ||
+ document.webkitIsFullScreen ||
document.msFullscreenElement ) {
+ if ( document.exitFullscreen ) {
+ document.exitFullscreen();
+ } else if ( document.msExitFullscreen ) {
+ document.msExitFullscreen();
+ } else if ( document.mozCancelFullScreen ) {
+ document.mozCancelFullScreen();
+ } else if ( document.webkitExitFullscreen ) {
+ document.webkitExitFullscreen();
+ }
+ } else {
+ var el = document.documentElement;
+
+ if ( el.requestFullscreen ) {
+ el.requestFullscreen();
+ } else if ( el.msRequestFullscreen ) {
+ el = document.body; // overwrite the element
(for IE)
+ el.msRequestFullscreen();
+ } else if ( el.mozRequestFullScreen ) {
+ el.mozRequestFullScreen();
+ } else if ( el.webkitRequestFullscreen ) {
+ el.webkitRequestFullScreen();
+ }
+ }
+ };
+
+ /**
+ * @private
+ */
SELF.prototype._initPopovers = function() {
var self = this;
--
To view, visit https://gerrit.wikimedia.org/r/366165
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06d8f723df09611be73d13caeace2fcdf45271fe
Gerrit-PatchSet: 6
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de>
Gerrit-Reviewer: Smalyshev <smalys...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
