[MediaWiki-commits] [Gerrit] operations/puppet[production]: prometheus-mysqld-exporter: Add s5 to the dbstore2001 monito...

[Jcrespo (Code Review)]

Jcrespo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371494 )

Change subject: prometheus-mysqld-exporter: Add s5 to the dbstore2001 monitored 
hosts
..

prometheus-mysqld-exporter: Add s5 to the dbstore2001 monitored hosts

This is still managed manually (for now). S5 has just beein imported into
dbstore2001.

Bug: T168409
Change-Id: I22de04fddf52cc3e2470a14bfcc991eedbd78268
---
M modules/role/files/prometheus/mysql-dbstore_codfw.yaml
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/94/371494/1

diff --git a/modules/role/files/prometheus/mysql-dbstore_codfw.yaml 
b/modules/role/files/prometheus/mysql-dbstore_codfw.yaml
index 80a85fd..1f35478 100644
--- a/modules/role/files/prometheus/mysql-dbstore_codfw.yaml
+++ b/modules/role/files/prometheus/mysql-dbstore_codfw.yaml
@@ -27,6 +27,12 @@
   - dbstore2002:13314
 
 - labels:
+shard: s5
+role: slave
+  targets:
+  - dbstore2001:13315
+
+- labels:
 shard: x1
 role: slave
   targets:

-- 
To view, visit https://gerrit.wikimedia.org/r/371494
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I22de04fddf52cc3e2470a14bfcc991eedbd78268
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jcrespo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: Fix JQMIGRATE warnings in jQuery Mobile

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371511 )

Change subject: Fix JQMIGRATE warnings in jQuery Mobile
..

Fix JQMIGRATE warnings in jQuery Mobile

jQuery Mobile 1.5 is supposed to be compatible with jQuery 3, but it isn't...

* Replace .bind() calls with .on()
* Replace .unbind() calls with .off()

Bug: T165816
Change-Id: I79639fd9ae8e6e785f93191273147866e52c4ed1
---
M resources/libraries/jquery.mobile.custom.js
1 file changed, 30 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Timeless 
refs/changes/11/371511/1

diff --git a/resources/libraries/jquery.mobile.custom.js 
b/resources/libraries/jquery.mobile.custom.js
index 376d183..bb1353f 100644
--- a/resources/libraries/jquery.mobile.custom.js
+++ b/resources/libraries/jquery.mobile.custom.js
@@ -1,3 +1,7 @@
+// Custom hacks:
+// * Replaced .bind() calls with .on() for compatibility with jQuery 3
+// * Replaced .unbind() calls with .off() for compatibility with jQuery 3
+
 /*
 * jQuery Mobile v1.4.5
 * http://jquerymobile.com
@@ -366,14 +370,14 @@
activeDocHandlers[ eventType ] = ( activeDocHandlers[ 
eventType ] || 0 ) + 1;
 
if ( activeDocHandlers[ eventType ] === 1 ) {
-   $document.bind( realType, mouseEventCallback );
+   $document.on( realType, mouseEventCallback );
}
 
// Some browsers, like Opera Mini, won't dispatch 
mouse/click events
// for elements unless they actually have handlers 
registered on them.
// To get around this, we register dummy handlers on 
the elements.
 
-   $( this ).bind( realType, dummyMouseHandler );
+   $( this ).on( realType, dummyMouseHandler );
 
// For now, if event capture is not supported, we rely 
on mouse handlers.
if ( eventCaptureSupported ) {
@@ -383,8 +387,8 @@
activeDocHandlers[ "touchstart" ] = ( 
activeDocHandlers[ "touchstart" ] || 0) + 1;
 
if ( activeDocHandlers[ "touchstart" ] === 1 ) {
-   $document.bind( "touchstart", 
handleTouchStart )
-   .bind( "touchend", 
handleTouchEnd )
+   $document.on( "touchstart", 
handleTouchStart )
+   .on( "touchend", handleTouchEnd 
)
 
// On touch platforms, touching 
the screen and then dragging your finger
// causes the window content to 
scroll after some distance threshold is
@@ -396,8 +400,8 @@
// we need to watch both scroll 
and touchmove events to figure out whether
// or not a scroll happenens 
before the touchend event is fired.
 
-   .bind( "touchmove", 
handleTouchMove )
-   .bind( "scroll", handleScroll );
+   .on( "touchmove", 
handleTouchMove )
+   .on( "scroll", handleScroll );
}
}
},
@@ -409,7 +413,7 @@
--activeDocHandlers[ eventType ];
 
if ( !activeDocHandlers[ eventType ] ) {
-   $document.unbind( realType, mouseEventCallback 
);
+   $document.off( realType, mouseEventCallback );
}
 
if ( eventCaptureSupported ) {
@@ -419,10 +423,10 @@
--activeDocHandlers[ "touchstart" ];
 
if ( !activeDocHandlers[ "touchstart" ] ) {
-   $document.unbind( "touchstart", 
handleTouchStart )
-   .unbind( "touchmove", 
handleTouchMove )
-   .unbind( "touchend", 
handleTouchEnd )
-   .unbind( "scroll", handleScroll 
);
+   $document.off( "touchstart", 
handleTouchStart )
+   .off( "touchmove", 
handleTouchMove )
+   .off( "touchend", 
handleTouchEnd )
+   .off( "scroll", handleScroll );
}
}
 
@@ -440,7 +444,7 @@
 
// Unregister the dummy event 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add missing & to @param documentation to match functon call

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371215 )

Change subject: Add missing & to @param documentation to match functon call
..


Add missing & to @param documentation to match functon call

Change-Id: I81e68310abcbc59964b22e0e74842d509f6b1fb9
---
M includes/AuthPlugin.php
M includes/EditPage.php
M includes/FileDeleteForm.php
M includes/GlobalFunctions.php
M includes/Licenses.php
M includes/Linker.php
M includes/MagicWord.php
M includes/MagicWordArray.php
M includes/OutputPage.php
M includes/Preferences.php
M includes/ProtectionForm.php
M includes/Revision.php
M includes/SiteConfiguration.php
M includes/StubObject.php
M includes/Title.php
M includes/api/ApiBase.php
M includes/api/ApiDelete.php
M includes/api/ApiParamInfo.php
M includes/api/ApiQueryBase.php
M includes/api/ApiQueryLogEvents.php
M includes/cache/LinkBatch.php
M includes/cache/MessageCache.php
M includes/cache/localisation/LocalisationCache.php
M includes/changes/ChangesFeed.php
M includes/changes/ChangesList.php
M includes/changes/EnhancedChangesList.php
M includes/changes/OldChangesList.php
M includes/changes/RecentChange.php
M includes/changetags/ChangeTags.php
M includes/compat/normal/UtfNormal.php
M includes/content/ContentHandler.php
M includes/content/JsonContent.php
M includes/content/TextContent.php
M includes/db/ORAResult.php
M includes/deferred/SiteStatsUpdate.php
M includes/diff/DiffFormatter.php
M includes/export/DumpFilter.php
M includes/export/DumpNamespaceFilter.php
M includes/export/WikiExporter.php
M includes/gallery/TraditionalImageGallery.php
M includes/htmlform/HTMLForm.php
M includes/import/UploadSourceAdapter.php
M includes/import/WikiImporter.php
M includes/installer/DatabaseUpdater.php
M includes/installer/SqliteInstaller.php
M includes/jobqueue/JobQueueFederated.php
M includes/libs/ArrayUtils.php
M includes/libs/MultiHttpClient.php
M includes/libs/filebackend/SwiftFileBackend.php
M includes/libs/filebackend/fileop/FileOp.php
M includes/libs/lockmanager/ScopedLock.php
M includes/libs/objectcache/BagOStuff.php
M includes/libs/objectcache/WANObjectCache.php
M includes/libs/rdbms/database/DatabaseMysqlBase.php
M includes/logging/LogEventsList.php
M includes/logging/LogPage.php
M includes/media/Bitmap.php
M includes/media/Bitmap_ClientOnly.php
M includes/media/FormatMetadata.php
M includes/media/ImageHandler.php
M includes/media/MediaHandler.php
M includes/media/SVG.php
M includes/media/TransformationalImageHandler.php
M includes/objectcache/SqlBagOStuff.php
M includes/page/Article.php
M includes/page/WikiPage.php
M includes/parser/LinkHolderArray.php
M includes/parser/Parser.php
M includes/profiler/Profiler.php
M includes/profiler/SectionProfiler.php
M includes/revisiondelete/RevisionDeleter.php
M includes/search/SearchHighlighter.php
M includes/search/SearchMySQL.php
M includes/skins/QuickTemplate.php
M includes/skins/Skin.php
M includes/specialpage/AuthManagerSpecialPage.php
M includes/specialpage/LoginSignupSpecialPage.php
M includes/specialpage/SpecialPageFactory.php
M includes/specials/SpecialBlock.php
M includes/specials/SpecialRecentchanges.php
M includes/specials/SpecialSearch.php
M includes/upload/UploadBase.php
M includes/upload/UploadFromFile.php
M includes/upload/UploadFromStash.php
M includes/upload/UploadFromUrl.php
M includes/user/User.php
86 files changed, 190 insertions(+), 190 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/AuthPlugin.php b/includes/AuthPlugin.php
index b85e1d6..24ae856 100644
--- a/includes/AuthPlugin.php
+++ b/includes/AuthPlugin.php
@@ -73,8 +73,8 @@
/**
 * Modify options in the login template.
 *
-* @param BaseTemplate $template
-* @param string $type 'signup' or 'login'. Added in 1.16.
+* @param BaseTemplate &$template
+* @param string &$type 'signup' or 'login'. Added in 1.16.
 */
public function modifyUITemplate( &$template, &$type ) {
# Override this!
@@ -124,7 +124,7 @@
 *
 * @deprecated since 1.26, use the UserLoggedIn hook instead. And 
assigning
 *  a different User object to $user is no longer supported.
-* @param User $user
+* @param User &$user
 * @return bool
 */
public function updateUser( &$user ) {
@@ -286,7 +286,7 @@
 *
 * @deprecated since 1.26, use the UserLoggedIn hook instead. And 
assigning
 *  a different User object to $user is no longer supported.
-* @param User $user
+* @param User &$user
 * @param bool $autocreate True if user is being autocreated on login
 */
public function initUser( &$user, $autocreate = false ) {
@@ -306,7 +306,7 @@
/**
 * Get an instance of a User object
 *
-* @param User $user
+* @param User &$user
 

[MediaWiki-commits] [Gerrit] analytics/refinery[master]: Add simple shell script to check if a yarn app is running

[Ottomata (Code Review)]

Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371496 )

Change subject: Add simple shell script to check if a yarn app is running
..

Add simple shell script to check if a yarn app is running

THis allows use in cron to not start a job if the app is currently running

Change-Id: I94d093c45b61fd288fbcd05dbb4579629ce16cf4
---
A bin/is-yarn-app-running
1 file changed, 35 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/refinery 
refs/changes/96/371496/1

diff --git a/bin/is-yarn-app-running b/bin/is-yarn-app-running
new file mode 100755
index 000..2c35d6b
--- /dev/null
+++ b/bin/is-yarn-app-running
@@ -0,0 +1,35 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""
+Exit 0 if a YARN app is running with the given job name, exit 1 otheriwise.
+
+Usage: is-yarn-app-running 
+"""
+__author__ = 'Andrew Otto '
+
+import sys
+from docopt import docopt
+from refinery.util import is_yarn_application_running
+
+# parse arguments
+arguments = docopt(__doc__)
+job_name = arguments['']
+
+if is_yarn_application_running(job_name):
+sys.exit(0)
+else:
+sys.exit(1)
+

-- 
To view, visit https://gerrit.wikimedia.org/r/371496
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94d093c45b61fd288fbcd05dbb4579629ce16cf4
Gerrit-PatchSet: 1
Gerrit-Project: analytics/refinery
Gerrit-Branch: master
Gerrit-Owner: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add cross reference to k8s admin guide in wikitech

[Jprorama (Code Review)]

Jprorama has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371501 )

Change subject: Add cross reference to k8s admin guide in wikitech
..

Add cross reference to k8s admin guide in wikitech

Provide additional context for tool operational intent with
URL to the wikitech admin guide

Change-Id: Ib684277c67646a373b7f5e585bc1cb785a8c
---
M modules/toollabs/files/maintain-kubeusers
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/01/371501/1

diff --git a/modules/toollabs/files/maintain-kubeusers 
b/modules/toollabs/files/maintain-kubeusers
index acb86ec..e4240d3 100755
--- a/modules/toollabs/files/maintain-kubeusers
+++ b/modules/toollabs/files/maintain-kubeusers
@@ -10,6 +10,9 @@
- .kube/config on the user's homedir
- abac.json for access config
- create the namespace with appropriate annotation
+
+Additional context available in the k8s admin guide:
+https://wikitech.wikimedia.org/wiki/Portal:Toolforge/Admin/Kubernetes#Authentication_.26_Authorization
 """
 import logging
 import argparse

-- 
To view, visit https://gerrit.wikimedia.org/r/371501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib684277c67646a373b7f5e585bc1cb785a8c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jprorama 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] labs/striker[master]: Fix author tracking for toolinfo create/edit

[BryanDavis (Code Review)]

BryanDavis has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371504 )

Change subject: Fix author tracking for toolinfo create/edit
..

Fix author tracking for toolinfo create/edit

Somewhere in the refactoring that was done around use of the reversion
library the attribution of the editor was lost.

Bug: T149458
Change-Id: Ibe86448114546ea031f6cc09444b67c86b4e2b0c
---
M striker/tools/views/toolinfo.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/striker 
refs/changes/04/371504/1

diff --git a/striker/tools/views/toolinfo.py b/striker/tools/views/toolinfo.py
index def005a..1aecbf6 100644
--- a/striker/tools/views/toolinfo.py
+++ b/striker/tools/views/toolinfo.py
@@ -70,6 +70,7 @@
 if form.is_valid():
 try:
 with reversion.create_revision():
+reversion.set_user(req.user)
 reversion.set_comment(form.cleaned_data['comment'])
 toolinfo = form.save(commit=False)
 toolinfo.tool = tool.name
@@ -122,6 +123,7 @@
 if form.is_valid():
 try:
 with reversion.create_revision():
+reversion.set_user(req.user)
 reversion.set_comment(form.cleaned_data['comment'])
 toolinfo = form.save()
 reversion.add_to_revision(toolinfo)

-- 
To view, visit https://gerrit.wikimedia.org/r/371504
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe86448114546ea031f6cc09444b67c86b4e2b0c
Gerrit-PatchSet: 1
Gerrit-Project: labs/striker
Gerrit-Branch: master
Gerrit-Owner: BryanDavis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: VisualDiff: Merge old internal list into new document

[Tchanders (Code Review)]

Tchanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371515 )

Change subject: VisualDiff: Merge old internal list into new document
..

VisualDiff: Merge old internal list into new document

The new document needs to know about removed references.

Bug: T173100
Change-Id: I8a11d2d558236939fcb2e7c9fc018e3b93c8240e
---
M src/dm/ve.dm.Document.js
M src/dm/ve.dm.VisualDiff.js
M src/ui/elements/ve.ui.DiffElement.js
3 files changed, 14 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/15/371515/1

diff --git a/src/dm/ve.dm.Document.js b/src/dm/ve.dm.Document.js
index 7c38cf4..6087c9b 100644
--- a/src/dm/ve.dm.Document.js
+++ b/src/dm/ve.dm.Document.js
@@ -656,16 +656,17 @@
  * will be clones of the ones in this document.
  *
  * @param {ve.Range} [range] Range of data to clone, clones the whole document 
if ommitted.
+ * @param {boolean} [detachedCopy] The copy is not intended to be merged into 
the original
  * @return {ve.dm.Document} New document
  */
-ve.dm.Document.prototype.cloneFromRange = function ( range ) {
+ve.dm.Document.prototype.cloneFromRange = function ( range, detachedCopy ) {
var listRange = this.getInternalList().getListNode().getOuterRange(),
data = ve.copy( this.getFullData( range, true ) );
if ( range && ( range.start > listRange.start || range.end < 
listRange.end ) ) {
// The range does not include the entire internal list, so add 
it
data = data.concat( this.getFullData( listRange ) );
}
-   return this.cloneWithData( data, true );
+   return this.cloneWithData( data, true, detachedCopy );
 };
 
 /**
@@ -675,9 +676,10 @@
  * @param {Array|ve.dm.ElementLinearData|ve.dm.FlatLinearData} data Raw linear 
model data,
  *  ElementLinearData or FlatLinearData
  * @param {boolean} [copyInternalList] Copy the internal list
+ * @param {boolean} [detachedCopy] The copy is not intended to be merged into 
the original
  * @return {ve.dm.Document} New document
  */
-ve.dm.Document.prototype.cloneWithData = function ( data, copyInternalList ) {
+ve.dm.Document.prototype.cloneWithData = function ( data, copyInternalList, 
detachedCopy ) {
var newDoc;
 
if ( Array.isArray( data ) ) {
@@ -697,7 +699,7 @@
// lang+dir
this.getLang(), this.getDir()
);
-   if ( copyInternalList ) {
+   if ( copyInternalList && !detachedCopy ) {
// Record the length of the internal list at the time the slice 
was created so we can
// reconcile additions properly
newDoc.origDoc = this;
diff --git a/src/dm/ve.dm.VisualDiff.js b/src/dm/ve.dm.VisualDiff.js
index a2c006e..5248160 100644
--- a/src/dm/ve.dm.VisualDiff.js
+++ b/src/dm/ve.dm.VisualDiff.js
@@ -18,8 +18,8 @@
  * @param {Number} [timeout=1000] Timeout after which to stop performing 
linear diffs (in ms)
  */
 ve.dm.VisualDiff = function VeDmVisualDiff( oldDoc, newDoc, timeout ) {
-   this.oldDoc = oldDoc.cloneFromRange();
-   this.newDoc = newDoc.cloneFromRange();
+   this.oldDoc = oldDoc.cloneFromRange( undefined, true );
+   this.newDoc = newDoc.cloneFromRange( undefined, true );
this.oldDocNode = this.oldDoc.getDocumentNode();
this.newDocNode = this.newDoc.getDocumentNode();
this.oldDocChildren = this.getDocChildren( this.oldDocNode );
diff --git a/src/ui/elements/ve.ui.DiffElement.js 
b/src/ui/elements/ve.ui.DiffElement.js
index e52a4c1..3a877e7 100644
--- a/src/ui/elements/ve.ui.DiffElement.js
+++ b/src/ui/elements/ve.ui.DiffElement.js
@@ -16,7 +16,7 @@
  * @param {Object} [config]
  */
 ve.ui.DiffElement = function VeUiDiffElement( visualDiff, config ) {
-   var diff = visualDiff.diff;
+   var tx, diff = visualDiff.diff;
 
// Parent constructor
ve.ui.DiffElement.super.call( this, config );
@@ -29,6 +29,11 @@
this.oldDocChildren = visualDiff.oldDocChildren;
this.newDocChildren = visualDiff.newDocChildren;
 
+   // Merge the old internal list into the new document, so that it knows
+   // about removed references
+   tx = ve.dm.TransactionBuilder.static.newFromDocumentInsertion( 
this.newDoc, 0, this.oldDoc, new ve.Range( 0 ) );
+   this.newDoc.commit( tx );
+
// Internal list
this.newDocInternalListNode = visualDiff.newDocInternalListNode;
this.oldDocInternalListNode = visualDiff.oldDocInternalListNode;

-- 
To view, visit https://gerrit.wikimedia.org/r/371515
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a11d2d558236939fcb2e7c9fc018e3b93c8240e
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Tchanders 

___

[MediaWiki-commits] [Gerrit] wikidata...gui-deploy[production]: Merging from 9d3b52bafa3c8d06730dd2800e4e4356bd45b42e:

[Smalyshev (Code Review)]

Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371503 )

Change subject: Merging from 9d3b52bafa3c8d06730dd2800e4e4356bd45b42e:
..

Merging from 9d3b52bafa3c8d06730dd2800e4e4356bd45b42e:

Merge "Temporarily disable query box hiding"

Change-Id: If1f27e612d7ac9fc95e07796c2aad24beff26729
---
M embed.html
M i18n/ar.json
M i18n/be.json
M i18n/bn.json
M i18n/csb.json
M i18n/eo.json
M i18n/gl.json
M i18n/ko.json
M i18n/nb.json
M i18n/ru.json
M i18n/sv.json
M i18n/tara.json
M index.html
R js/embed.wdqs.min.d4385ebc518ec474423d.js
A js/wdqs.min.4723a47da5083329d7ae.js
D js/wdqs.min.f0adef6d44ac55138c74.js
16 files changed, 15 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui-deploy 
refs/changes/03/371503/1


-- 
To view, visit https://gerrit.wikimedia.org/r/371503
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If1f27e612d7ac9fc95e07796c2aad24beff26729
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui-deploy
Gerrit-Branch: production
Gerrit-Owner: Smalyshev 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui-deploy[production]: Merging from 9d3b52bafa3c8d06730dd2800e4e4356bd45b42e:

[Smalyshev (Code Review)]

Smalyshev has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371503 )

Change subject: Merging from 9d3b52bafa3c8d06730dd2800e4e4356bd45b42e:
..


Merging from 9d3b52bafa3c8d06730dd2800e4e4356bd45b42e:

Merge "Temporarily disable query box hiding"

Change-Id: If1f27e612d7ac9fc95e07796c2aad24beff26729
---
M embed.html
M i18n/ar.json
M i18n/be.json
M i18n/bn.json
M i18n/csb.json
M i18n/eo.json
M i18n/gl.json
M i18n/ko.json
M i18n/nb.json
M i18n/ru.json
M i18n/sv.json
M i18n/tara.json
M index.html
R js/embed.wdqs.min.d4385ebc518ec474423d.js
A js/wdqs.min.4723a47da5083329d7ae.js
D js/wdqs.min.f0adef6d44ac55138c74.js
16 files changed, 15 insertions(+), 15 deletions(-)

Approvals:
  Smalyshev: Verified; Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/371503
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1f27e612d7ac9fc95e07796c2aad24beff26729
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui-deploy
Gerrit-Branch: production
Gerrit-Owner: Smalyshev 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: Smalyshev 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: Print full URL on server start

[Niedzielski (Code Review)]

Niedzielski has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371510 )

Change subject: Chore: Print full URL on server start
..


Chore: Print full URL on server start

Small detail so that you can click the url on the terminal to open
a browser.

Change-Id: I41689ec9f70deee2850cbbc3f5e7cb2624be3ba6
---
M src/server/index.ts
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Niedzielski: Verified; Looks good to me, approved



diff --git a/src/server/index.ts b/src/server/index.ts
index ca50a61..7452a0f 100644
--- a/src/server/index.ts
+++ b/src/server/index.ts
@@ -27,5 +27,5 @@
 });
 
 server.listen(PORT, () => {
-  console.log(`Server started on port ${PORT}`); // eslint-disable-line 
no-console
+  console.log(`Server started on port http://localhost:${PORT}/`); // 
eslint-disable-line no-console
 });

-- 
To view, visit https://gerrit.wikimedia.org/r/371510
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41689ec9f70deee2850cbbc3f5e7cb2624be3ba6
Gerrit-PatchSet: 2
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez 
Gerrit-Reviewer: Niedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Switch to git from jessie-backports

[BryanDavis (Code Review)]

BryanDavis has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371502 )

Change subject: Switch to git from jessie-backports
..

Switch to git from jessie-backports

We have been using an Ubuntu PPA to get less ancient git binaries since
we were on the Trusty base image. This was most recently installing
a 2.13.0 version of git. The hacks to use a PPA on Jessie are fragile
and the more robust jessie-backports apt repo has version 2.11.0 which
is new enough.

This change will not alter the installed git version on any existing VM.

Change-Id: I476928e95bd808072208144d1284995bda6906b2
---
M puppet/modules/git/manifests/init.pp
1 file changed, 12 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/02/371502/1

diff --git a/puppet/modules/git/manifests/init.pp 
b/puppet/modules/git/manifests/init.pp
index 7163aa3..acc39e5 100644
--- a/puppet/modules/git/manifests/init.pp
+++ b/puppet/modules/git/manifests/init.pp
@@ -28,11 +28,19 @@
 ) {
 include ::git::gerrit
 
-apt::ppa { 'git-core/ppa': }
+$packages = [
+'git',
+'git-man',
+]
+apt::pin { 'git':
+package  => join(sort($packages), ' '),
+pin  => 'release a=jessie-backports',
+priority => '1001',
+}
 
-package { 'git':
-ensure  => latest,
-require => Apt::Ppa['git-core/ppa'],
+package { $packages:
+ensure  => 'present',
+require => Apt::Pin['git'],
 }
 
 package { 'git-review':

-- 
To view, visit https://gerrit.wikimedia.org/r/371502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I476928e95bd808072208144d1284995bda6906b2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: BryanDavis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: Compile server side code

[Niedzielski (Code Review)]

Niedzielski has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371012 )

Change subject: Chore: Compile server side code
..


Chore: Compile server side code

Using typescript and as much of the config of the client code shared in
the root tsconfig.json, compile sources to our node target, ES2015.

* Installed node.js typings for node, mocha & express
* Compile server side code to dist/
* Add an example of common code (src/common/components/app) used on the
  server and the client.
* Add specific formatting & linting for typescript files given
  typescript-eslint-parser has problems and is experimental

Bug: T172439
Change-Id: Ia489def195b6aa8f7279f692d2fb2e2c9351dbd4
---
M .eslintrc.json
M package-lock.json
M package.json
M src/client/index.ts
A src/common/components/app/index.ts
D src/server/index.js
A src/server/index.ts
D src/server/templates/page.js
A src/server/templates/page.ts
A src/server/tsconfig.json
A test/mocha.opts
D test/server/templates/page.test.js
A test/server/templates/page.test.ts
13 files changed, 253 insertions(+), 68 deletions(-)

Approvals:
  Niedzielski: Verified; Looks good to me, approved



diff --git a/.eslintrc.json b/.eslintrc.json
index e4630e8..086e06c 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -7,9 +7,8 @@
 "prettier"
   ],
   "rules": {
-"prettier/prettier": ["error", {"parser": "typescript"}]
+"prettier/prettier": "error"
   },
-  "parser": "typescript-eslint-parser",
   "parserOptions": {
 "ecmaVersion": 2016,
 "sourceType": "module",
diff --git a/package-lock.json b/package-lock.json
index 2ecb354..363b7c8 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -4,6 +4,53 @@
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
+"@types/express": {
+  "version": "4.0.36",
+  "resolved": 
"https://registry.npmjs.org/@types/express/-/express-4.0.36.tgz;,
+  "integrity": 
"sha512-bT9q2eqH/E72AGBQKT50dh6AXzheTqigGZ1GwDiwmx7vfHff0bZOrvUWjvGpNWPNkRmX1vDF6wonG6rlpBHb1A==",
+  "dev": true,
+  "requires": {
+"@types/express-serve-static-core": "4.0.49",
+"@types/serve-static": "1.7.31"
+  }
+},
+"@types/express-serve-static-core": {
+  "version": "4.0.49",
+  "resolved": 
"https://registry.npmjs.org/@types/express-serve-static-core/-/express-serve-static-core-4.0.49.tgz;,
+  "integrity": 
"sha512-b7mVHoURu1xaP/V6xw1sYwyv9V0EZ7euyi+sdnbnTZxEkAh4/hzPsI6Eflq+ZzHQ/Tgl7l16Jz+0oz8F46MLnA==",
+  "dev": true,
+  "requires": {
+"@types/node": "8.0.20"
+  }
+},
+"@types/mime": {
+  "version": "1.3.1",
+  "resolved": "https://registry.npmjs.org/@types/mime/-/mime-1.3.1.tgz;,
+  "integrity": 
"sha512-rek8twk9C58gHYqIrUlJsx8NQMhlxqHzln9Z9ODqiNgv3/s+ZwIrfr+djqzsnVM12xe9hL98iJ20lj2RvCBv6A==",
+  "dev": true
+},
+"@types/mocha": {
+  "version": "2.2.41",
+  "resolved": "https://registry.npmjs.org/@types/mocha/-/mocha-2.2.41.tgz;,
+  "integrity": "sha1-4nzwgXFT658nE7LT9saPHhw8pgg=",
+  "dev": true
+},
+"@types/node": {
+  "version": "8.0.20",
+  "resolved": "https://registry.npmjs.org/@types/node/-/node-8.0.20.tgz;,
+  "integrity": 
"sha512-MnB7YEpmLUyEWRVRhKpRs4swwqITnY8BcVFPoTuCl99SCplI/lLUiU5vcJ/OANDqwkpdIg0pDEM38K22KQT2RA==",
+  "dev": true
+},
+"@types/serve-static": {
+  "version": "1.7.31",
+  "resolved": 
"https://registry.npmjs.org/@types/serve-static/-/serve-static-1.7.31.tgz;,
+  "integrity": "sha1-FUVt6NmNa0z/Mb5savdJKuY/Uho=",
+  "dev": true,
+  "requires": {
+"@types/express-serve-static-core": "4.0.49",
+"@types/mime": "1.3.1"
+  }
+},
 "abbrev": {
   "version": "1.1.0",
   "resolved": "https://registry.npmjs.org/abbrev/-/abbrev-1.1.0.tgz;,
@@ -3490,6 +3537,12 @@
 "yallist": "2.1.2"
   }
 },
+"make-error": {
+  "version": "1.3.0",
+  "resolved": 
"https://registry.npmjs.org/make-error/-/make-error-1.3.0.tgz;,
+  "integrity": "sha1-Uq06M5zPEM5itAQLcI/nByRLi5Y=",
+  "dev": true
+},
 "map-stream": {
   "version": "0.1.0",
   "resolved": 
"https://registry.npmjs.org/map-stream/-/map-stream-0.1.0.tgz;,
@@ -4759,6 +4812,15 @@
   "integrity": "sha1-dc449SvwczxafwwRjYEzSiu19BI=",
   "dev": true
 },
+"source-map-support": {
+  "version": "0.4.15",
+  "resolved": 
"https://registry.npmjs.org/source-map-support/-/source-map-support-0.4.15.tgz;,
+  "integrity": "sha1-AyAt9lwG0r2MfsI2KhkwVv7407E=",
+  "dev": true,
+  "requires": {
+"source-map": "0.5.6"
+  }
+},
 "spdx-correct": {
   "version": "1.0.2",
   "resolved": 
"https://registry.npmjs.org/spdx-correct/-/spdx-correct-1.0.2.tgz;,
@@ -5075,6 +5137,71 @@
 }
   }
 },
+"ts-node": {
+  "version": "3.3.0",
+  "resolved": 

[MediaWiki-commits] [Gerrit] mediawiki...WoOgLeShades[master]: Some css junk - lose excess formatting, make up some colours

[Isarra (Code Review)]

Isarra has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371506 )

Change subject: Some css junk - lose excess formatting, make up some colours
..

Some css junk - lose excess formatting, make up some colours

bug: T165516
Change-Id: Icc3af6cf932e6aa8ed0e841f14a37ff9995fbc18
---
M resources/screen-common.less
M resources/screen-desktop.less
M resources/variables.less
3 files changed, 28 insertions(+), 49 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/WoOgLeShades 
refs/changes/06/371506/1

diff --git a/resources/screen-common.less b/resources/screen-common.less
index 781c896..05a9863 100644
--- a/resources/screen-common.less
+++ b/resources/screen-common.less
@@ -9,11 +9,11 @@
margin: 0 auto;
position: relative;
padding: 1em;
+   font-family: @fonts;
 }
 #p-logo {
text-align: center;
width: 10em;
-   float: right;
 
// Make logo image visible
// The class sets the background image from $wgLogo, but we still need 
to give it a size in order to show up
@@ -52,45 +52,11 @@
text-align: center;
 }
 
-// Splatter the menus and tools at the bottom
-#mw-footer,
-#page-tools,
-#p-personal {
-   margin: 1em 0;
-
-   ul {
-   list-style-type: none;
-   margin: 0;
-   }
-   li {
-   padding-right: 1em;
-   display: inline-block;
-   }
-}
-#page-tools .mw-portlet {
-   display: inline-block;
-}
-#mw-navigation {
-   margin: 1em 0;
-}
-
-// Footer
-#mw-footer {
-   clear: both;
-   border-top: 1px solid @border;
-
-   ul {
-   margin-top: 1em;
-   }
-}
-#footer-icons {
-   float: right;
-   margin: 0 0 1em 1em;
-}
-
 // hidden stuff
+/*
 #page-tools h3,
 #p-search h3,
 #p-personal h3 {
.hidden;
 }
+*/
diff --git a/resources/screen-desktop.less b/resources/screen-desktop.less
index c677d3b..48a0487 100644
--- a/resources/screen-desktop.less
+++ b/resources/screen-desktop.less
@@ -2,13 +2,3 @@
 
 @import "variables.less";
 
-#site-navigation {
-   ul {
-   list-style-type: none;
-   margin: 0;
-   }
-   li {
-   padding-right: 1em;
-   display: inline-block;
-   }
-}
diff --git a/resources/variables.less b/resources/variables.less
index caa158d..764d6c3 100644
--- a/resources/variables.less
+++ b/resources/variables.less
@@ -1,7 +1,30 @@
 // @import "mediawiki.mixins"; Not used yet
 
-@width: 66em;
-@border: #ccc;
+@width: 76em;
+
+// Colours - theme one: blue & cyan; red secondary, greys
+   // TODO: theme two: probably red & black, blue secondary, greys
+@primarybold: #029; // blue
+@primarybright: #094; // cyan
+@primarybold-light: #05d; // light blue
+@primarybright-light: #7df; // light cyan
+
+@secondarybold: #900; // red
+@secondarybold-light: #d33; // light red
+
+@grey0: #000; // black
+@grey1: #666;
+@grey2: #ccc;
+@grey3: #ddd;
+@grey4: #eee;
+@grey5: #f0f0f0;
+@grey6: #fff; // white
+
+@content-text: @grey0;
+@content-background: @grey6;
+
+@fonts: 'sans serif';
+@fonts-mono: 'monospace';
 
 // To hide objects, but keep them accessible for screen-readers
 .hidden() {

-- 
To view, visit https://gerrit.wikimedia.org/r/371506
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc3af6cf932e6aa8ed0e841f14a37ff9995fbc18
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/WoOgLeShades
Gerrit-Branch: master
Gerrit-Owner: Isarra 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Reintroduce hover and bar clicking

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371493 )

Change subject: Reintroduce hover and bar clicking
..


Reintroduce hover and bar clicking

Bug: T172092
Change-Id: I496143f2425eccd0028cc1980fc7189a457c70a2
---
M modules/ext.RevisionSlider.RevisionListView.js
M modules/ext.RevisionSlider.SliderView.js
M modules/ext.RevisionSlider.css
3 files changed, 182 insertions(+), 18 deletions(-)

Approvals:
  jenkins-bot: Verified
  Andrew-WMDE: Looks good to me, approved



diff --git a/modules/ext.RevisionSlider.RevisionListView.js 
b/modules/ext.RevisionSlider.RevisionListView.js
index 7f00e92..2389c8f 100644
--- a/modules/ext.RevisionSlider.RevisionListView.js
+++ b/modules/ext.RevisionSlider.RevisionListView.js
@@ -87,6 +87,22 @@
.addClass( diffSize > 0 
? 'mw-revslider-revision-up' : 'mw-revslider-revision-down' )
.append( $( '' 
).addClass( 'mw-revslider-revision-border-box' ) )
)
+   .append( $( '' )
+   .addClass( 
'mw-revslider-revision-wrapper-up' )
+   .width( 
this.revisionWidth )
+   .append(
+   $( '' )
+   
.addClass( 'mw-revslider-pointer mw-revslider-pointer-ghost' )
+   )
+   )
+   .append( $( '' )
+   .addClass( 
'mw-revslider-revision-wrapper-down' )
+   .width( 
this.revisionWidth )
+   .append(
+   $( '' )
+   
.addClass( 'mw-revslider-pointer mw-revslider-pointer-ghost' )
+   )
+   )
.mouseenter( showTooltip )
.mouseleave( hideTooltip )
);
diff --git a/modules/ext.RevisionSlider.SliderView.js 
b/modules/ext.RevisionSlider.SliderView.js
index 4957afb..75a5691 100644
--- a/modules/ext.RevisionSlider.SliderView.js
+++ b/modules/ext.RevisionSlider.SliderView.js
@@ -124,6 +124,7 @@
 
this.initializePointers( this.getOldRevElement( 
$revisions ), this.getNewRevElement( $revisions ) );
this.resetRevisionStylesBasedOnPointerPosition( 
$revisions );
+   this.addClickHandlerToRevisions( $revisions );
 
$container.html( this.$element );
 
@@ -175,6 +176,20 @@
.addClass( 'mw-revslider-pointer-container' )
.css( pointerContainerStyle )
.append( this.renderPointerContainers() )
+   .mouseout( function () {
+   if ( !self.isDragged ) {
+   $( 
'.mw-revslider-revision-wrapper-up, .mw-revslider-revision-wrapper-down' )
+   .removeClass( 
'mw-revslider-revision-hovered' );
+   }
+   } )
+   .mouseover( function ( event ) {
+   if ( !self.isDragged ) {
+   lastMouseMoveRevisionPos = 
self.showTooltipsOnMouseMoveHandler(
+   event,
+   null
+   );
+   }
+   } )
.mousemove( function ( event ) {
if ( !self.isDragged ) {
lastMouseMoveRevisionPos = 
self.showTooltipsOnMouseMoveHandler(
@@ -262,13 +277,25 @@
 
showTooltipsOnMouseMoveHandler: function ( event, 
lastValidPosition ) {
var pos = this.getRevisionPositionFromLeftOffset( 
event.pageX ),
-   $hoveredRevisionWrapper;
+   $hoveredRevisionWrapper, hasMovedTop;
 
if ( 

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "mariadb: Depool db2075 for cloning to dbstore2001"

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371497 )

Change subject: Revert "mariadb: Depool db2075 for cloning to dbstore2001"
..


Revert "mariadb: Depool db2075 for cloning to dbstore2001"

This reverts commit 52d8abc482c3641f7d536839d40f86500212327c.

Change-Id: Ifd5dd7cd280b82086299e50a47ddc4a5a9acb4b3
---
M wmf-config/db-codfw.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jcrespo: Looks good to me, approved



diff --git a/wmf-config/db-codfw.php b/wmf-config/db-codfw.php
index fae7626..cb00a85 100644
--- a/wmf-config/db-codfw.php
+++ b/wmf-config/db-codfw.php
@@ -137,7 +137,7 @@
'db2052' => 50,  # D6 2.9TB 160GB, dump (inactive), vslow
'db2059' => 100, # D6 3.3TB 160GB, api
'db2066' => 400, # D6 3.3TB 160GB
-   # 'db2075' => 400, # A1 3.3TB 512GB # Compressed InnoDB
+   'db2075' => 400, # A1 3.3TB 512GB # Compressed InnoDB
],
's6' => [
'db2028' => 0,   # B6  2.9TB  96GB, master

-- 
To view, visit https://gerrit.wikimedia.org/r/371497
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd5dd7cd280b82086299e50a47ddc4a5a9acb4b3
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jcrespo 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: Marostegui 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: Fix directionality of ULS CLL and languageselect callouts wh...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/354739 )

Change subject: Fix directionality of ULS CLL and languageselect callouts when 
appearing on right side of screen
..


Fix directionality of ULS CLL and languageselect callouts
when appearing on right side of screen

Languageselect was mostly fixed in 354378, but I forgot the
settings ones, so the triangle just disappears when
switching dialogs currently. This follows up on that and
properly fixes it.

Sidebar callouts now appear toward content regardless of
where they're appearing from, or the language
directionality. Triangles are now consistently alligned to
the top of the callout (same position in languageselect and
compact language links) to avoid issues with it appearing
over a scrollbar.

Sideways callout triangles (carets) are consolidated into a
single rendering approach and mixin across compact language
links and toolbox language selector.

Bug: T161586
Change-Id: I7717e26525ac527ede486796f49083ed40ee7d4f
---
M resources/css/ext.uls.compactlinks.less
M resources/css/ext.uls.less
A resources/css/ext.uls.mixins.less
M resources/js/ext.uls.compactlinks.js
M resources/js/ext.uls.displaysettings.js
M resources/js/ext.uls.inputsettings.js
M resources/js/ext.uls.interface.js
7 files changed, 73 insertions(+), 120 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  TheDJ: Looks good to me, approved



diff --git a/resources/css/ext.uls.compactlinks.less 
b/resources/css/ext.uls.compactlinks.less
index 8223c9f..70ded66 100644
--- a/resources/css/ext.uls.compactlinks.less
+++ b/resources/css/ext.uls.compactlinks.less
@@ -1,4 +1,5 @@
 @import 'mediawiki.mixins';
+@import 'ext.uls.mixins.less';
 
 /* stylelint-disable selector-no-id */
 
@@ -30,34 +31,6 @@
background-color: #ccc;
 }
 
-.interlanguage-uls-menu:before {
-   background: none repeat scroll 0 0 #fcfcfc;
-   border-left: 1px solid rgba( 0, 0, 0, 0.2 );
-   border-top: 1px solid rgba( 0, 0, 0, 0.2 );
-   box-shadow: -2px -2px 2px rgba( 0, 0, 0, 0.1 );
-   content: '';
-   height: 16px;
-   width: 16px;
-   left: -9px;
-   position: absolute;
-   /* The dialog middle is positioned 250px away from the center of the 
trigger. Substract 8 for
-* half of the box height to center middle of the box rather than the 
top.  The remaining 2 are
-* either for top-margin of the menu and border of this box, or because 
we use do not account
-* for the margin of the trigger when we use $.fn.outerWidth without 
true as a parameter.
-*/
-   top: 240px;
-   transform: rotate( -45deg );
-   -webkit-transform: rotate( -45deg );
-   -moz-transform: rotate( -45deg );
-   -o-transform: rotate( -45deg );
-   -ms-transform: rotate( -45deg );
-   background-clip: padding-box;
-}
-
-body.rtl .interlanguage-uls-menu:before {
-   transform: rotate( 45deg );
-   -webkit-transform: rotate( 45deg );
-   -moz-transform: rotate( 45deg );
-   -o-transform: rotate( 45deg );
-   -ms-transform: rotate( 45deg );
+.interlanguage-uls-menu {
+   .caret();
 }
diff --git a/resources/css/ext.uls.less b/resources/css/ext.uls.less
index d09263a..940d713 100644
--- a/resources/css/ext.uls.less
+++ b/resources/css/ext.uls.less
@@ -1,3 +1,5 @@
+@import 'ext.uls.mixins.less';
+
 /* Overrides to follow MediaWiki style */
 .uls-menu {
border-radius: 4px;
@@ -16,63 +18,8 @@
border-bottom-left-radius: 4px;
 }
 
-/* Caret */
-.uls-menu.callout .caret-before,
-.uls-menu.callout .caret-after {
-   border-top: 10px solid transparent;
-   border-bottom: 10px solid transparent;
-   display: inline-block;
-   /* 17px aligns nicely with the size of the search row in language 
selection */
-   top: 17px;
-   position: absolute;
-}
-.uls-menu.callout .caret-after {
-   display: inline-block;
-}
-
-// How do you do switch for flipping in less? These are very redundant.
-.uls-menu.callout .caret-right {
-   .caret-before,
-   .caret-after {
-   /* @noflip */
-   border-left: 10px solid #c9c9c9;
-   /* @noflip */
-   right: -11px;
-   }
-
-   .caret-after {
-   /* @noflip */
-   border-left: 10px solid #fcfcfc;
-   /* @noflip */
-   right: -10px;
-   }
-
-}
-.uls-menu.callout--languageselection .caret-right .caret-after {
-   /* @noflip */
-   border-left: 10px solid #fff;
-}
-
-.uls-menu.callout .caret-left {
-   .caret-before,
-   .caret-after {
-   /* @noflip */
-   border-right: 10px solid #c9c9c9;
-   /* @noflip */
-   left: -11px;
-   }
-
-   .caret-after {
-   /* @noflip */
-   border-right: 

[MediaWiki-commits] [Gerrit] marvin[master]: Server: Don't crash when unable to load the asset-manifest.json

[Niedzielski (Code Review)]

Niedzielski has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371509 )

Change subject: Server: Don't crash when unable to load the asset-manifest.json
..


Server: Don't crash when unable to load the asset-manifest.json

Some times in development when starting the processes the server starts
and the asset-manifest.json in dist/public still hasn't been generated.

Don't crash when not found, just initialize with no assets. In
production, let the server crash, since it would be an invalid artifact
(no frontend assets).

Change-Id: I6b954e6403787387c982b02c944171feeb28d72d
---
M src/server/index.ts
M src/server/templates/page.ts
2 files changed, 14 insertions(+), 2 deletions(-)

Approvals:
  Niedzielski: Verified; Looks good to me, approved



diff --git a/src/server/index.ts b/src/server/index.ts
index 76673c0..ca50a61 100644
--- a/src/server/index.ts
+++ b/src/server/index.ts
@@ -2,7 +2,16 @@
 import page, { AssetsManifest } from "./templates/page";
 import app from "../common/components/app";
 
-const assets: AssetsManifest = 
require("../../dist/public/assets-manifest.json");
+let assets: AssetsManifest = {};
+try {
+  assets = require("../../dist/public/assets-manifest.json");
+} catch (e) {
+  if (process.env.NODE_ENV === "production") {
+throw e;
+  } else {
+console.error("Unable to load the static assets manifest file");
+  }
+}
 
 const { PORT = 3000 } = process.env;
 const server = express();
diff --git a/src/server/templates/page.ts b/src/server/templates/page.ts
index 4929a35..9465595 100644
--- a/src/server/templates/page.ts
+++ b/src/server/templates/page.ts
@@ -14,6 +14,9 @@
 }
 
 export default function page({ title, body = "", assets }: PageParams): string 
{
+  const scripts = [];
+  assets.index && assets.index.js && scripts.push(assets.index.js);
+
   return `
 
 
@@ -25,7 +28,7 @@
   
   
 ${body}
-
+${scripts.map(s => ``)}
   
 `;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/371509
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b954e6403787387c982b02c944171feeb28d72d
Gerrit-PatchSet: 2
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez 
Gerrit-Reviewer: Jhernandez 
Gerrit-Reviewer: Niedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use correct variable name in @param documentation

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371495 )

Change subject: Use correct variable name in @param documentation
..

Use correct variable name in @param documentation

For some varargs a variable name is added with suffix ,... as seen for
many other varargs

Some @param are swapped, because there are in the wrong order

Change-Id: I60fec6025bce824d5c67563ab7b65ad6cd628ad8
---
M includes/FauxRequest.php
M includes/GlobalFunctions.php
M includes/Message.php
M includes/OutputPage.php
M includes/api/ApiAuthManagerHelper.php
M includes/api/ApiBase.php
M includes/collation/CustomUppercaseCollation.php
M includes/context/ContextSource.php
M includes/context/RequestContext.php
M includes/htmlform/HTMLForm.php
M includes/libs/MemoizedCallable.php
M includes/libs/MultiHttpClient.php
M includes/libs/filebackend/FileBackend.php
M includes/libs/objectcache/BagOStuff.php
M includes/libs/objectcache/MultiWriteBagOStuff.php
M includes/libs/objectcache/WANObjectCache.php
M includes/libs/rdbms/database/Database.php
M includes/libs/rdbms/lbfactory/ILBFactory.php
M includes/logging/LogEventsList.php
M includes/mail/UserMailer.php
M includes/media/MediaHandler.php
M includes/media/WebP.php
M includes/resourceloader/ResourceLoaderContext.php
M includes/revisiondelete/RevDelList.php
M includes/search/SearchExactMatchRescorer.php
M includes/search/SearchSuggestion.php
M includes/session/PHPSessionHandler.php
M includes/session/SessionProvider.php
M includes/skins/BaseTemplate.php
M includes/specialpage/LoginSignupSpecialPage.php
M includes/specials/SpecialFilepath.php
M includes/specials/SpecialMediaStatistics.php
M includes/user/User.php
33 files changed, 40 insertions(+), 38 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/95/371495/1

diff --git a/includes/FauxRequest.php b/includes/FauxRequest.php
index 3b2283b..9147240 100644
--- a/includes/FauxRequest.php
+++ b/includes/FauxRequest.php
@@ -126,7 +126,7 @@
 
/**
 * @since 1.26
-* @param string $name Unprefixed name of the cookie to set
+* @param string $key Unprefixed name of the cookie to set
 * @param string|null $value Value of the cookie to set
 * @param string|null $prefix Cookie prefix. Defaults to $wgCookiePrefix
 */
diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index 70784ba..be70e5b 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -2234,7 +2234,8 @@
  * (https://bugs.php.net/bug.php?id=26285) and the locale problems on Linux in
  * PHP 5.2.6+ (bug backported to earlier distro releases of PHP).
  *
- * @param string ... strings to escape and glue together, or a single array of 
strings parameter
+ * @param string $args,... strings to escape and glue together,
+ *  or a single array of strings parameter
  * @return string
  */
 function wfEscapeShellArg( /*...*/ ) {
diff --git a/includes/Message.php b/includes/Message.php
index be6b0af..8777c6f 100644
--- a/includes/Message.php
+++ b/includes/Message.php
@@ -488,7 +488,7 @@
 *
 * @since 1.17
 *
-* @param mixed ... Parameters as strings or arrays from
+* @param mixed $args,... Parameters as strings or arrays from
 *  Message::numParam() and the like, or a single array of parameters.
 *
 * @return Message $this
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 6aa11f6..03784d4 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -688,7 +688,7 @@
 * Add one or more head items to the output
 *
 * @since 1.28
-* @param string|string[] $value Raw HTML
+* @param string|string[] $values Raw HTML
 */
public function addHeadItems( $values ) {
$this->mHeadItems = array_merge( $this->mHeadItems, 
(array)$values );
@@ -3797,7 +3797,7 @@
 * Caller is responsible for ensuring the file exists. Emits a PHP 
warning otherwise.
 *
 * @since 1.27
-* @param string $remotePath URL path prefix that points to $localPath
+* @param string $remotePathPrefix URL path prefix that points to 
$localPath
 * @param string $localPath File directory exposed at $remotePath
 * @param string $file Path to target file relative to $localPath
 * @return string URL
diff --git a/includes/api/ApiAuthManagerHelper.php 
b/includes/api/ApiAuthManagerHelper.php
index 3a9fb73..d6b9f76 100644
--- a/includes/api/ApiAuthManagerHelper.php
+++ b/includes/api/ApiAuthManagerHelper.php
@@ -229,8 +229,8 @@
 
/**
 * Logs successful or failed authentication.
-* @param string|AuthenticationResponse $result Response or error 
message
 * @param string $event Event type (e.g. 'accountcreation')
+* @param string|AuthenticationResponse $result 

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: Add ES5 transpilation for client files

[Niedzielski (Code Review)]

Niedzielski has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371010 )

Change subject: Chore: Add ES5 transpilation for client files
..


Chore: Add ES5 transpilation for client files

Using typescript as the compiler, add ts-loader so that webpack
transpiles files to ES5.

* Base tsconfig.json in the root of the project
  * Specific client details extending the root config in
src/client/tsconfig.json
* Use the typescript parser for eslint and prettier
  * Tested by creating some lint and style errors on src/client/index.js
and it seems to lint well
  * impliedStrict needed to supress strict mode rules. ES modules are
implied strict.
  * Modify npm run lint to read ts and tsx files
* Add ts-loader for webpack support

Bug: T172437
Change-Id: If76bd06a768e75a82e1d54e45be8177e2decf20b
---
M .eslintrc.json
M package-lock.json
M package.json
R src/client/index.ts
A src/client/tsconfig.json
A tsconfig.json
M webpack.config.js
7 files changed, 138 insertions(+), 4 deletions(-)

Approvals:
  Niedzielski: Verified; Looks good to me, approved



diff --git a/.eslintrc.json b/.eslintrc.json
index bf986ec..e4630e8 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -7,11 +7,16 @@
 "prettier"
   ],
   "rules": {
-"prettier/prettier": "error"
+"prettier/prettier": ["error", {"parser": "typescript"}]
   },
+  "parser": "typescript-eslint-parser",
   "parserOptions": {
 "ecmaVersion": 2016,
-"sourceType": "module"
+"sourceType": "module",
+"ecmaFeatures": {
+  "jsx": true,
+  "impliedStrict": true
+}
   },
   "env": {
 "es6": true,
diff --git a/package-lock.json b/package-lock.json
index 2d71c41..2ecb354 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -550,6 +550,21 @@
   "integrity": "sha1-DQcLTQQ6W+ozovGkDi7bPZpMz3c=",
   "dev": true
 },
+"color-convert": {
+  "version": "1.9.0",
+  "resolved": 
"https://registry.npmjs.org/color-convert/-/color-convert-1.9.0.tgz;,
+  "integrity": "sha1-Gsz5fdc5uYO/mU1W/sj5WFNkG3o=",
+  "dev": true,
+  "requires": {
+"color-name": "1.1.3"
+  }
+},
+"color-name": {
+  "version": "1.1.3",
+  "resolved": 
"https://registry.npmjs.org/color-name/-/color-name-1.1.3.tgz;,
+  "integrity": "sha1-p9BVi9icQveV3UIyj3QIMcpTvCU=",
+  "dev": true
+},
 "comment-parser": {
   "version": "0.4.0",
   "resolved": 
"https://registry.npmjs.org/comment-parser/-/comment-parser-0.4.0.tgz;,
@@ -3441,6 +3456,12 @@
 "lodash.keysin": "3.0.8"
   }
 },
+"lodash.unescape": {
+  "version": "4.0.1",
+  "resolved": 
"https://registry.npmjs.org/lodash.unescape/-/lodash.unescape-4.0.1.tgz;,
+  "integrity": "sha1-vyJJiGzlFM2hEvrpIYzcBlIR/Jw=",
+  "dev": true
+},
 "lolex": {
   "version": "2.1.2",
   "resolved": "https://registry.npmjs.org/lolex/-/lolex-2.1.2.tgz;,
@@ -5011,6 +5032,49 @@
   "integrity": "sha1-OTvnMKlEb9Hq1tpZoBQwjzbCics=",
   "dev": true
 },
+"ts-loader": {
+  "version": "2.3.2",
+  "resolved": "https://registry.npmjs.org/ts-loader/-/ts-loader-2.3.2.tgz;,
+  "integrity": 
"sha512-KcQvWwla5nviCMX1511iKVsLfrx97Hbah6l5awE1HNL6eiyAzb3gSO8b5yasB6fK/qGukLpu9czWcd/AGGFy/g==",
+  "dev": true,
+  "requires": {
+"chalk": "2.1.0",
+"enhanced-resolve": "3.4.1",
+"loader-utils": "1.1.0",
+"semver": "5.4.1"
+  },
+  "dependencies": {
+"ansi-styles": {
+  "version": "3.2.0",
+  "resolved": 
"https://registry.npmjs.org/ansi-styles/-/ansi-styles-3.2.0.tgz;,
+  "integrity": 
"sha512-NnSOmMEYtVR2JVMIGTzynRkkaxtiq1xnFBcdQD/DnNCYPoEPsVJhM98BDyaoNOQIi7p4okdi3E27eN7GQbsUug==",
+  "dev": true,
+  "requires": {
+"color-convert": "1.9.0"
+  }
+},
+"chalk": {
+  "version": "2.1.0",
+  "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.1.0.tgz;,
+  "integrity": 
"sha512-LUHGS/dge4ujbXMJrnihYMcL4AoOweGnw9Tp3kQuqy1Kx5c1qKjqvMJZ6nVJPMWJtKCTN72ZogH3oeSO9g9rXQ==",
+  "dev": true,
+  "requires": {
+"ansi-styles": "3.2.0",
+"escape-string-regexp": "1.0.5",
+"supports-color": "4.2.1"
+  }
+},
+"supports-color": {
+  "version": "4.2.1",
+  "resolved": 
"https://registry.npmjs.org/supports-color/-/supports-color-4.2.1.tgz;,
+  "integrity": 
"sha512-qxzYsob3yv6U+xMzPrv170y8AwGP7i74g+pbixCfD6rgso8BscLT2qXIuz6TpOaiJZ3mFgT5O9lyT9nMU4LfaA==",
+  "dev": true,
+  "requires": {
+"has-flag": "2.0.0"
+  }
+}
+  }
+},
 "tty-browserify": {
   "version": "0.0.0",
   "resolved": 
"https://registry.npmjs.org/tty-browserify/-/tty-browserify-0.0.0.tgz;,
@@ -5047,6 +5111,30 @@
   "integrity": 

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiChat[master]: Register MediaWiki:Chat.css/.js as ResourceLoaderWikiModules

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/355991 )

Change subject: Register MediaWiki:Chat.css/.js as ResourceLoaderWikiModules
..


Register MediaWiki:Chat.css/.js as ResourceLoaderWikiModules

Change-Id: I43274239a735327b8f3331a5bb0d5f58bc711f65
---
M SpecialChat.php
M extension.json
M i18n/en.json
M i18n/qqq.json
4 files changed, 25 insertions(+), 8 deletions(-)

Approvals:
  Jack Phoenix: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SpecialChat.php b/SpecialChat.php
index 9876e4c..eb2ac0a 100644
--- a/SpecialChat.php
+++ b/SpecialChat.php
@@ -37,12 +37,16 @@
$template = new SpecialChatTemplate;
 
// Load modules via ResourceLoader
-   $modules = array(
-   'ext.mediawikichat.css',
+   $out->addModules( [
'ext.mediawikichat.js',
-   'mediawiki.feedback' // for the loading gif
-   );
-   $out->addModules( $modules );
+   'ext.mediawikichat.site',
+   'mediawiki.feedback'
+   ] );
+
+   $out->addModuleStyles( [
+   'ext.mediawikichat.css',
+   'ext.mediawikichat.site.styles'
+   ] );
 
$out->addJsConfigVars(
array(
diff --git a/extension.json b/extension.json
index 9457e5c..8d74929 100644
--- a/extension.json
+++ b/extension.json
@@ -1,6 +1,6 @@
 {
"name": "MediaWikiChat",
-   "version": "2.20.4",
+   "version": "2.20.5",
"author": [
"Adam Carter/UltrasonicNXT"
],
@@ -103,6 +103,14 @@
],
"dependencies": [ "mediawiki.jqueryMsg", 
"mediawiki.user", "mediawiki.util" ],
"position": "bottom"
+   },
+   "ext.mediawikichat.site": {
+   "class": "ResourceLoaderWikiModule",
+   "scripts": ["MediaWiki:Chat.js"]
+   },
+   "ext.mediawikichat.site.styles": {
+   "class": "ResourceLoaderWikiModule",
+   "styles": ["MediaWiki:Chat.css"]
}
},
"AvailableRights": [
diff --git a/i18n/en.json b/i18n/en.json
index c30f7cc..805d25b 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -99,5 +99,8 @@
 
"chat-message-from": "Message {{GENDER:$2|from}} $1",
"chat-private-message-from": "Private message {{GENDER:$2|from}} $1",
-   "chat-mentioned-by": "Mentioned {{GENDER:$2|by}} $1"
+   "chat-mentioned-by": "Mentioned {{GENDER:$2|by}} $1",
+
+   "chat.css": "/* CSS loaded here will affect Special:Chat only */",
+   "chat.js": "/* Any JavaScript here will be loaded for users using 
Special:Chat */"
 }
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 4f790c1..8751dda 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -97,5 +97,7 @@
"apihelp-chatsendpm-example-1": "{{doc-apihelp-example|chatsendpm}}",
"chat-message-from": "Notification for receiving message\n* $1 sending 
user\n* $2 sending users gender",
"chat-private-message-from": "Notification for receiving private 
message\n* $1 sending user\n* $2 sending users gender",
-   "chat-mentioned-by": "Notification for being mentioned\n* $1 mentioning 
user\n* $2 mentioning users gender"
+   "chat-mentioned-by": "Notification for being mentioned\n* $1 mentioning 
user\n* $2 mentioning users gender",
+   "chat.css": "{{optional}}\nSee also:\n* {{msg-mw|Chat.js}}",
+   "chat.js": "{{optional}}\nSee also:\n* {{msg-mw|Chat.css}}"
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/355991
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43274239a735327b8f3331a5bb0d5f58bc711f65
Gerrit-PatchSet: 9
Gerrit-Project: mediawiki/extensions/MediaWikiChat
Gerrit-Branch: master
Gerrit-Owner: SamanthaNguyen 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: UltrasonicNXT 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Duplicate new table from core, patch 349457

[MusikAnimal (Code Review)]

MusikAnimal has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371507 )

Change subject: Duplicate new table from core, patch 349457
..

Duplicate new table from core, patch 349457

https://gerrit.wikimedia.org/r/#/c/349457/

Change-Id: I48f0b64f19f9582b40540fa1b42a39d281979625
---
M tests/phpunit/DiscussionParserTest.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/07/371507/1

diff --git a/tests/phpunit/DiscussionParserTest.php 
b/tests/phpunit/DiscussionParserTest.php
index aaf51db..07122a5 100644
--- a/tests/phpunit/DiscussionParserTest.php
+++ b/tests/phpunit/DiscussionParserTest.php
@@ -11,7 +11,7 @@
/**
 * @var array
 */
-   protected $tablesUsed = [ 'user', 'revision', 'text', 'page' ];
+   protected $tablesUsed = [ 'user', 'revision', 'ip_changes', 'text', 
'page' ];
 
/**
 * Convenience users for use in these tests.
@@ -819,7 +819,7 @@
'content' =>
 <

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: Print full URL on server start

[Jhernandez (Code Review)]

Jhernandez has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371510 )

Change subject: Chore: Print full URL on server start
..

Chore: Print full URL on server start

Small detail so that you can click the url on the terminal to open
a browser.

Change-Id: I41689ec9f70deee2850cbbc3f5e7cb2624be3ba6
---
M src/server/index.ts
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/10/371510/1

diff --git a/src/server/index.ts b/src/server/index.ts
index 1be1942..f6f5821 100644
--- a/src/server/index.ts
+++ b/src/server/index.ts
@@ -23,5 +23,5 @@
 });
 
 server.listen(PORT, () => {
-  console.log(`Server started on port ${PORT}`); // eslint-disable-line 
no-console
+  console.log(`Server started on port http://localhost:${PORT}/`); // 
eslint-disable-line no-console
 });

-- 
To view, visit https://gerrit.wikimedia.org/r/371510
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41689ec9f70deee2850cbbc3f5e7cb2624be3ba6
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] marvin[master]: Server: Don't crash when unable to load the asset-manifest.json

[Jhernandez (Code Review)]

Jhernandez has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371509 )

Change subject: Server: Don't crash when unable to load the asset-manifest.json
..

Server: Don't crash when unable to load the asset-manifest.json

Some times in development when starting the processes the server starts
and the asset-manifest.json in dist/public still hasn't been generated.

Don't crash when not found, just initialize with no assets.

Change-Id: I6b954e6403787387c982b02c944171feeb28d72d
---
M src/server/index.ts
M src/server/templates/page.ts
2 files changed, 10 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/09/371509/1

diff --git a/src/server/index.ts b/src/server/index.ts
index 76673c0..1be1942 100644
--- a/src/server/index.ts
+++ b/src/server/index.ts
@@ -2,7 +2,12 @@
 import page, { AssetsManifest } from "./templates/page";
 import app from "../common/components/app";
 
-const assets: AssetsManifest = 
require("../../dist/public/assets-manifest.json");
+let assets: AssetsManifest = {};
+try {
+  assets = require("../../dist/public/assets-manifest.json");
+} catch (e) {
+  console.error("Unable to load the static assets manifest file");
+}
 
 const { PORT = 3000 } = process.env;
 const server = express();
diff --git a/src/server/templates/page.ts b/src/server/templates/page.ts
index 4929a35..9465595 100644
--- a/src/server/templates/page.ts
+++ b/src/server/templates/page.ts
@@ -14,6 +14,9 @@
 }
 
 export default function page({ title, body = "", assets }: PageParams): string 
{
+  const scripts = [];
+  assets.index && assets.index.js && scripts.push(assets.index.js);
+
   return `
 
 
@@ -25,7 +28,7 @@
   
   
 ${body}
-
+${scripts.map(s => ``)}
   
 `;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/371509
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b954e6403787387c982b02c944171feeb28d72d
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Jhernandez 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] marvin[master]: POC: Change the structure of npm scripts

[Jhernandez (Code Review)]

Jhernandez has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371513 )

Change subject: POC: Change the structure of npm scripts
..

POC: Change the structure of npm scripts

* Organize them by sections
  * Main scripts for development
  * Git hooks
  * Helpers & tools
* Reduce number of scripts from 21 to 15
  * There may be some loss of flexibility because of some hardcoded
paths
* Switch many scripts to run parallel for better speedups
* Clean up dist/ before 'npm run build'

Groups the main development scripts under this use cases:

* Want to develop:
  * npm start # Run the program and compilers
  * npm test  # Run linting & tests
* Other main actions:
  * npm run build  # Build production artifacts in dist/
  * npm run format # Auto-fix my code style and linting problems
  * npm run lint   # Find problems with my code
  * npm run test:watch # Run linting and tests in watch mode

The rest of the scripts are considered secondary.

TODO:
- Discuss this patch
- Document the main scripts in the readme or in docs/ in the development
  guide
- Removed 'build' from 'test' because in dev you would have 2 build
  scripts running in parallel by 'start' and 'test', which could lead
  to weird conditions.
  - Need to figure out how to run a build in CI, without running it in
development in 'test'

Example npm run output:

Lifecycle scripts included in marvin:
  start
run-p -sn 'client:build -- -w' 'server:build -- -w' server:watch
  test
run-p -sn lint mocha

available via `npm run-script`:
  //
MAIN SCRIPTS
  build
NODE_ENV=production npm-run-all --silent clean --parallel server:build 
'client:build -- -p'
  format
run-p -s 'eslint -- --fix .' 'prettier -- --write'
  lint
run-p -sn 'eslint -- .' 'prettier -- -l'
  test:watch
nodemon -e js,json,ts,tsx -q -x 'npm test'
  //-
HOOKS
  precommit
npm test -s
  //--
HELPERS
  server:watch
nodemon -e js,json,ts,tsx -q -x 'npm run server:run'
  server:build
tsc -p src/server/tsconfig.json
  server:run
node dist/server/index.js
  client:build
webpack --display minimal
  //---
TOOLS
  prettier
prettier --parser typescript '{src,test}/**/*.{ts,tsx}'
  eslint
eslint --cache --max-warnings 0 --ext js,json
  mocha
mocha '{src,test}/**/*.test.{ts,js}'
  clean
rm -rf dist/

Change-Id: Ifa7adc79d3a1cda82fee0c3bd5534ddff403f6ff
---
M package.json
1 file changed, 21 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/13/371513/1

diff --git a/package.json b/package.json
index f52ba40..dbacfe5 100644
--- a/package.json
+++ b/package.json
@@ -3,27 +3,28 @@
   "version": "0.0.0",
   "description": "An API driven skin for MediaWiki",
   "scripts": {
-"start": "run-p -sn dev:\\*",
-"dev:client": "webpack -w",
-"dev:server": "run-p -sn dev:server:\\*",
-"dev:server:build": "npm run -s server:build -- -w",
-"dev:server:watch": "nodemon -e js,json,ts,tsx -q dist/server/index.js",
-"server:build": "tsc -p src/server/tsconfig.json",
-"client:build": "webpack -p",
-"prod:build": "NODE_ENV=production run-s -s server:build client:build",
-"format:ts": "prettier --write --parser typescript",
-"format:ts:all": "npm run -s format:ts -- '{src,test}/**/*.{ts,tsx}'",
-"format:js": "npm run -s lint -- --fix",
-"format:js:all": "npm run -s format:js -- .",
-"format:all": "run-s -s format:js:all format:ts:all",
-"lint": "eslint --cache --max-warnings 0 --ext js,json",
-"lint:ts": "prettier --parser typescript -l",
-"lint:ts:all": "npm run -s lint:ts -- '{src,test}/**/*.{ts,tsx}'",
-"lint:all": "npm run -s lint -- . && npm run -s lint:ts:all",
-"pretest": "run-s -s lint:all prod:build",
-"test": "mocha '{src,test}/**/*.test.{ts,js}'",
+"//": "MAIN SCRIPTS",
+"start": "run-p -sn 'client:build -- -w' 'server:build -- -w' 
server:watch",
+"build": "NODE_ENV=production npm-run-all --silent clean --parallel 
server:build 'client:build -- -p'",
+"format": "run-p -s 'eslint -- --fix .' 'prettier -- --write'",
+"lint": "run-p -sn 'eslint -- .' 'prettier -- -l'",
+"test": "run-p -sn lint mocha",
 "test:watch": "nodemon -e js,json,ts,tsx -q -x 'npm test'",
-"precommit": "npm run -s test"
+
+"//-": "HOOKS",
+"precommit": "npm test -s",
+
+"//--": "HELPERS",
+"server:watch": "nodemon -e js,json,ts,tsx -q -x 'npm run server:run'",
+"server:build": "tsc -p src/server/tsconfig.json",
+"server:run": "node dist/server/index.js",
+"client:build": "webpack --display minimal",
+
+"//---": "TOOLS",
+"prettier": "prettier --parser typescript '{src,test}/**/*.{ts,tsx}'",
+"eslint": "eslint --cache 

[MediaWiki-commits] [Gerrit] oojs/ui[master]: update mediawiki-codesniffer to 0.11.0 and fix issues

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371472 )

Change subject: update mediawiki-codesniffer to 0.11.0 and fix issues
..


update mediawiki-codesniffer to 0.11.0 and fix issues

It seems, that the bool auto fixes also mess with
line breakes in comments in some cases.

- fixes by auto checks
- long line fixes

Change-Id: Id25d518ff733f5d6db58cedbb4d88a64684919ae
---
M composer.json
M php/Tag.php
M php/Widget.php
M php/layouts/PanelLayout.php
M php/mixins/ButtonElement.php
M php/widgets/ButtonInputWidget.php
M php/widgets/ButtonWidget.php
M php/widgets/CheckboxInputWidget.php
M php/widgets/ProgressBarWidget.php
M php/widgets/RadioInputWidget.php
M php/widgets/TextInputWidget.php
11 files changed, 29 insertions(+), 29 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/composer.json b/composer.json
index 0270fe6..a2df46e 100644
--- a/composer.json
+++ b/composer.json
@@ -51,7 +51,7 @@
],
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"phpunit/phpunit": "4.8.21"
},
"autoload": {
diff --git a/php/Tag.php b/php/Tag.php
index 44d35a8..1c308bd 100644
--- a/php/Tag.php
+++ b/php/Tag.php
@@ -95,7 +95,7 @@
 * Toggle CSS classes.
 *
 * @param array $classes List of classes to add
-* @param boolean $toggle Add classes
+* @param bool $toggle Add classes
 * @return $this
 */
public function toggleClasses( array $classes, $toggle = null ) {
@@ -253,7 +253,7 @@
/**
 * Enable widget for client-side infusion.
 *
-* @param boolean $infusable True to allow tag/element/widget to be 
referenced client-side.
+* @param bool $infusable True to allow tag/element/widget to be 
referenced client-side.
 * @return $this
 */
public function setInfusable( $infusable ) {
diff --git a/php/Widget.php b/php/Widget.php
index 2f4573f..1936414 100644
--- a/php/Widget.php
+++ b/php/Widget.php
@@ -22,7 +22,7 @@
 
/**
 * @param array $config Configuration options
-* @param boolean $config['disabled'] Disable (default: false)
+* @param bool $config['disabled'] Disable (default: false)
 */
public function __construct( array $config = [] ) {
// Initialize config
@@ -50,7 +50,7 @@
 *
 * This should probably change the widgets' appearance and prevent it 
from being used.
 *
-* @param boolean $disabled Disable widget
+* @param bool $disabled Disable widget
 * @return $this
 */
public function setDisabled( $disabled ) {
diff --git a/php/layouts/PanelLayout.php b/php/layouts/PanelLayout.php
index 00a4cb5..83ad87c 100644
--- a/php/layouts/PanelLayout.php
+++ b/php/layouts/PanelLayout.php
@@ -8,11 +8,11 @@
 class PanelLayout extends Layout {
/**
 * @param array $config Configuration options
-* @param boolean $config['scrollable'] Allow vertical scrolling 
(default: false)
-* @param boolean $config['padded'] Pad the content from the edges 
(default: false)
-* @param boolean $config['expanded'] Expand size to fill the entire 
parent element
+* @param bool $config['scrollable'] Allow vertical scrolling (default: 
false)
+* @param bool $config['padded'] Pad the content from the edges 
(default: false)
+* @param bool $config['expanded'] Expand size to fill the entire 
parent element
 *   (default: true)
-* @param boolean $config['framed'] Wrap in a frame to visually 
separate from outside content
+* @param bool $config['framed'] Wrap in a frame to visually separate 
from outside content
 *   (default: false)
 */
public function __construct( array $config = [] ) {
diff --git a/php/mixins/ButtonElement.php b/php/mixins/ButtonElement.php
index c91a158..eaf0651 100644
--- a/php/mixins/ButtonElement.php
+++ b/php/mixins/ButtonElement.php
@@ -26,7 +26,7 @@
 
/**
 * @param array $config Configuration options
-* @param boolean $config['framed'] Render button with a frame 
(default: true)
+* @param bool $config['framed'] Render button with a frame (default: 
true)
 */
public function initializeButtonElement( array $config = [] ) {
// Properties
@@ -58,7 +58,7 @@
/**
 * Toggle frame.
 *
-* @param boolean $framed Make button framed, omit to toggle
+* @param bool $framed Make button framed, omit to toggle
 * @return $this
 */
public function toggleFramed( $framed = null ) {
diff --git a/php/widgets/ButtonInputWidget.php 

[MediaWiki-commits] [Gerrit] mediawiki...Comments[master]: Fix E_NOTICE in CommentsOfTheDay.class.php

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370596 )

Change subject: Fix E_NOTICE in CommentsOfTheDay.class.php
..


Fix E_NOTICE in CommentsOfTheDay.class.php

Notice: Undefined index: nocache in
../extensions/Comments/includes/CommentsOfTheDay.class.php on line 30

Change-Id: Ib4c52ce62b9c824bae2be7df78c5315fe7bf05a6
---
M includes/CommentsOfTheDay.class.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/CommentsOfTheDay.class.php 
b/includes/CommentsOfTheDay.class.php
index 4f89d34..eeb86b1 100644
--- a/includes/CommentsOfTheDay.class.php
+++ b/includes/CommentsOfTheDay.class.php
@@ -5,7 +5,6 @@
  *
  * @file
  * @ingroup Extensions
- * @date 27 November 2015
  */
 
 class CommentsOfTheDay {
@@ -27,7 +26,8 @@
 * @return string HTML
 */
public static function getHTML( $input, $args, $parser ) {
-   $comments = self::get( (bool)$args['nocache'] );
+   $skipCache = isset( $args['nocache'] ) && $args['nocache'];
+   $comments = self::get( $skipCache );
$commentOutput = '';
 
foreach ( $comments as $comment ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/370596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4c52ce62b9c824bae2be7df78c5315fe7bf05a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Comments
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: UltrasonicNXT 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: MobileFrontend should be responsible for adding mobile.site ...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371498 )

Change subject: MobileFrontend should be responsible for adding mobile.site 
module
..


MobileFrontend should be responsible for adding mobile.site module

Change-Id: I4508762629333c96dc6b11f6c0f63b675b367209
Depends-On: I094a57532a4e7dac47d06f25c56dbd4935ec707c
Bug: T171062
---
M includes/skins/SkinMinerva.php
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 31cedd0..558b560 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -1306,8 +1306,7 @@
$this->getContextSpecificModules(),
[
'skins.minerva.scripts.top',
-   'skins.minerva.scripts',
-   'mobile.site',
+   'skins.minerva.scripts'
]
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371498
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4508762629333c96dc6b11f6c0f63b675b367209
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Duplicate new table from core, patch 349457

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371207 )

Change subject: Duplicate new table from core, patch 349457
..


Duplicate new table from core, patch 349457

https://gerrit.wikimedia.org/r/#/c/349457/

Change-Id: I20962bea66b3560bbfa013cc72e250115d26d929
---
M lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  WMDE-leszek: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php 
b/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php
index 03cdba7..344c11f 100644
--- a/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php
+++ b/lib/tests/phpunit/Store/Sql/SqlEntityInfoBuilderTest.php
@@ -46,6 +46,7 @@
$this->tablesUsed[] = 'page';
$this->tablesUsed[] = 'redirect';
$this->tablesUsed[] = 'revision';
+   $this->tablesUsed[] = 'ip_changes';
 
$termRows = [];
$infoRows = [];

-- 
To view, visit https://gerrit.wikimedia.org/r/371207
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I20962bea66b3560bbfa013cc72e250115d26d929
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: MusikAnimal 
Gerrit-Reviewer: WMDE-leszek 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Load mobile.site on all mobile skins

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371499 )

Change subject: Load mobile.site on all mobile skins
..


Load mobile.site on all mobile skins

Bug: T171062
Change-Id: I094a57532a4e7dac47d06f25c56dbd4935ec707c
---
M includes/MobileFrontend.hooks.php
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/MobileFrontend.hooks.php 
b/includes/MobileFrontend.hooks.php
index 70eec12..40f2379 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -780,6 +780,10 @@
);
}
 
+   // In mobile mode 
MediaWiki:Common.css/MediaWiki:Common.js is not loaded.
+   // We load MediaWiki:Mobile.css/js instead
+   $out->addModules( [ 'mobile.site' ] );
+
// Allow modifications in mobile only mode
Hooks::run( 'BeforePageDisplayMobile', [ &$out, &$sk ] 
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371499
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I094a57532a4e7dac47d06f25c56dbd4935ec707c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fixing styling of interwiki results header

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370851 )

Change subject: Fixing styling of interwiki results header
..


Fixing styling of interwiki results header

Bug: T172345
Change-Id: Id95e5b5176e98dd6e4c2dd2c127974aaae7d69ce
---
M 
resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Tjones: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less
 
b/resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less
index 992ce99..59464bd 100644
--- 
a/resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less
+++ 
b/resources/src/mediawiki.special/mediawiki.special.search.interwikiwidget.styles.less
@@ -111,7 +111,8 @@
}
.mw-search-createlink,
.mw-search-nonefound,
-   .mw-search-results {
+   .mw-search-results,
+   .mw-search-interwiki-header {
float: left;
width: 60%;
clear: left;

-- 
To view, visit https://gerrit.wikimedia.org/r/370851
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id95e5b5176e98dd6e4c2dd2c127974aaae7d69ce
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jdrewniak 
Gerrit-Reviewer: Bearloga 
Gerrit-Reviewer: DCausse 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: TTO 
Gerrit-Reviewer: Tjones 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Shorten the rationale

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370643 )

Change subject: Shorten the rationale
..


Shorten the rationale

The rationale shown when storage permission is revoked seems a bit
too long and makes the assumption that the user would see the dialog
to grant permission each time he does the concerned action. It's not
always the fact as the user has the choice of "Don't show again" and
may have used it to avoid the dialog from popping up.

Shorten the message thus making no assumptions about the dialog being
shown.

Change-Id: Icd554217c9cf3cf955e4ddfe7c3ce2ba24d9a1a8
---
M app/src/main/res/values/strings.xml
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/app/src/main/res/values/strings.xml 
b/app/src/main/res/values/strings.xml
index c412281..a9ac051 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -218,7 +218,7 @@
 Downloading file…
 File saved successfully.
 Could not play the 
video.
-Permission to 
write to storage on your device is required for saving images. Please try 
again, and grant the requested permission.
+Permission to 
write to storage on your device is required for saving images.
 Cannot save file
 \"%1$s\" on @Wikipedia: %2$s
 Tap to expand
@@ -459,7 +459,7 @@
 
 
 
-Permission to access 
storage on your device is required for offline browsing. Please try again, and 
grant the requested permission.
+Permission to access 
storage on your device is required for offline browsing.
 Permission not granted to 
read from device storage.
 You are now browsing Wikipedia in offline 
mode. Please note that offline articles may not be fully up to date with the 
online version.
 My compilations

-- 
To view, visit https://gerrit.wikimedia.org/r/370643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd554217c9cf3cf955e4ddfe7c3ce2ba24d9a1a8
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Kaartic 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...UIFeedback[master]: Add grunt-jsonlint and grunt-banana-checker

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371137 )

Change subject: Add grunt-jsonlint and grunt-banana-checker
..


Add grunt-jsonlint and grunt-banana-checker

jsonlint and banana-checker will test for valid i18n files

Bug: T94547
Change-Id: I1a89adf2c0fe07f1a55295084c071dc2a13aa8d6
---
A .gitignore
A Gruntfile.js
A package.json
3 files changed, 32 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..07e6e47
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+/node_modules
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 000..f6f1804
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,20 @@
+module.exports = function ( grunt ) {
+   grunt.loadNpmTasks( 'grunt-jsonlint' );
+   grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+   grunt.initConfig( {
+   banana: {
+   all: 'i18n/'
+   },
+   jsonlint: {
+   all: [
+   '**/*.json',
+   '!node_modules/**',
+   '!vendor/**'
+   ]
+   }
+   } );
+
+   grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+   grunt.registerTask( 'default', 'test' );
+};
diff --git a/package.json b/package.json
new file mode 100644
index 000..10fa9bc
--- /dev/null
+++ b/package.json
@@ -0,0 +1,11 @@
+{
+   "private": true,
+   "scripts": {
+   "test": "grunt test"
+   },
+   "devDependencies": {
+   "grunt": "1.0.1",
+   "grunt-banana-checker": "0.6.0",
+   "grunt-jsonlint": "1.1.0"
+   }
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/371137
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a89adf2c0fe07f1a55295084c071dc2a13aa8d6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/UIFeedback
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "mariadb: Depool db2075 for cloning to dbstore2001"

[Jcrespo (Code Review)]

Hello Marostegui, Florianschmidtwelzow, jenkins-bot,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/371497

to review the following change.


Change subject: Revert "mariadb: Depool db2075 for cloning to dbstore2001"
..

Revert "mariadb: Depool db2075 for cloning to dbstore2001"

This reverts commit 52d8abc482c3641f7d536839d40f86500212327c.

Change-Id: Ifd5dd7cd280b82086299e50a47ddc4a5a9acb4b3
---
M wmf-config/db-codfw.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/97/371497/1

diff --git a/wmf-config/db-codfw.php b/wmf-config/db-codfw.php
index fae7626..cb00a85 100644
--- a/wmf-config/db-codfw.php
+++ b/wmf-config/db-codfw.php
@@ -137,7 +137,7 @@
'db2052' => 50,  # D6 2.9TB 160GB, dump (inactive), vslow
'db2059' => 100, # D6 3.3TB 160GB, api
'db2066' => 400, # D6 3.3TB 160GB
-   # 'db2075' => 400, # A1 3.3TB 512GB # Compressed InnoDB
+   'db2075' => 400, # A1 3.3TB 512GB # Compressed InnoDB
],
's6' => [
'db2028' => 0,   # B6  2.9TB  96GB, master

-- 
To view, visit https://gerrit.wikimedia.org/r/371497
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd5dd7cd280b82086299e50a47ddc4a5a9acb4b3
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jcrespo 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Marostegui 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: MobileFrontend should be responsible for adding mobile.site ...

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371498 )

Change subject: MobileFrontend should be responsible for adding mobile.site 
module
..

MobileFrontend should be responsible for adding mobile.site module

Change-Id: I4508762629333c96dc6b11f6c0f63b675b367209
Depends-On: I094a57532a4e7dac47d06f25c56dbd4935ec707c
Bug: T171062
---
M includes/skins/SkinMinerva.php
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/98/371498/1

diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 31cedd0..558b560 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -1306,8 +1306,7 @@
$this->getContextSpecificModules(),
[
'skins.minerva.scripts.top',
-   'skins.minerva.scripts',
-   'mobile.site',
+   'skins.minerva.scripts'
]
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371498
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4508762629333c96dc6b11f6c0f63b675b367209
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Load mobile.site on all mobile skins

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371499 )

Change subject: Load mobile.site on all mobile skins
..

Load mobile.site on all mobile skins

Bug: T171062
Change-Id: I094a57532a4e7dac47d06f25c56dbd4935ec707c
---
M includes/MobileFrontend.hooks.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/99/371499/1

diff --git a/includes/MobileFrontend.hooks.php 
b/includes/MobileFrontend.hooks.php
index 70eec12..f9a07c1 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -780,6 +780,10 @@
);
}
 
+   // In mobile mode 
MediaWiki:Common.css/MediaWiki:Common.js is not loaded.
+   // We load MediaWiki:Mobile.css/js instead
+   $out->addModules(['mobile.site']);
+
// Allow modifications in mobile only mode
Hooks::run( 'BeforePageDisplayMobile', [ &$out, &$sk ] 
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371499
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I094a57532a4e7dac47d06f25c56dbd4935ec707c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Design tweak: Update offline library screen background color

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371500 )

Change subject: Design tweak: Update offline library screen background color
..

Design tweak: Update offline library screen background color

Bug: T163587
Change-Id: I39117afb02653f5d31e3a56c22c42097fb300603
---
M app/src/main/res/layout/fragment_local_compilations.xml
M app/src/main/res/values/attrs.xml
M app/src/main/res/values/colors.xml
M app/src/main/res/values/styles_dark.xml
M app/src/main/res/values/styles_light.xml
5 files changed, 9 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/00/371500/1

diff --git a/app/src/main/res/layout/fragment_local_compilations.xml 
b/app/src/main/res/layout/fragment_local_compilations.xml
index 58e076e..2abbf17 100644
--- a/app/src/main/res/layout/fragment_local_compilations.xml
+++ b/app/src/main/res/layout/fragment_local_compilations.xml
@@ -7,7 +7,7 @@
 android:layout_height="match_parent"
 android:orientation="vertical"
 android:layout_marginTop="?attr/actionBarSize"
-android:background="?attr/window_background_color">
+android:background="?attr/offline_library_background_color">
 
 
 
 
+
 
 
 
diff --git a/app/src/main/res/values/colors.xml 
b/app/src/main/res/values/colors.xml
index 0ecf2bd..fd9bef6 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -124,6 +124,9 @@
 @color/base70
 @color/base70
 
+@color/base80
+@color/base20
+
 @android:color/white
 @color/base30
 
diff --git a/app/src/main/res/values/styles_dark.xml 
b/app/src/main/res/values/styles_dark.xml
index 5e04149..c519670 100644
--- a/app/src/main/res/values/styles_dark.xml
+++ b/app/src/main/res/values/styles_dark.xml
@@ -58,6 +58,8 @@
 @color/list_item_text_primary_dark
 @color/list_item_text_secondary_dark
 
+@color/offline_library_background_color_dark
+
 @color/base18
 @color/color_state_nav_tab_dark
 
diff --git a/app/src/main/res/values/styles_light.xml 
b/app/src/main/res/values/styles_light.xml
index f04171a..a219cd4 100644
--- a/app/src/main/res/values/styles_light.xml
+++ b/app/src/main/res/values/styles_light.xml
@@ -58,6 +58,8 @@
 @color/list_item_text_primary_light
 @color/list_item_text_secondary_light
 
+@color/offline_library_background_color_light
+
 @android:color/white
 @color/color_state_nav_tab_light
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371500
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39117afb02653f5d31e3a56c22c42097fb300603
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: prometheus-mysqld-exporter: Add s5 to the dbstore2001 monito...

[Jcrespo (Code Review)]

Jcrespo has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371494 )

Change subject: prometheus-mysqld-exporter: Add s5 to the dbstore2001 monitored 
hosts
..


prometheus-mysqld-exporter: Add s5 to the dbstore2001 monitored hosts

This is still managed manually (for now). S5 has just beein imported into
dbstore2001.

Bug: T168409
Change-Id: I22de04fddf52cc3e2470a14bfcc991eedbd78268
---
M modules/role/files/prometheus/mysql-dbstore_codfw.yaml
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jcrespo: Looks good to me, approved



diff --git a/modules/role/files/prometheus/mysql-dbstore_codfw.yaml 
b/modules/role/files/prometheus/mysql-dbstore_codfw.yaml
index 80a85fd..1f35478 100644
--- a/modules/role/files/prometheus/mysql-dbstore_codfw.yaml
+++ b/modules/role/files/prometheus/mysql-dbstore_codfw.yaml
@@ -27,6 +27,12 @@
   - dbstore2002:13314
 
 - labels:
+shard: s5
+role: slave
+  targets:
+  - dbstore2001:13315
+
+- labels:
 shard: x1
 role: slave
   targets:

-- 
To view, visit https://gerrit.wikimedia.org/r/371494
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I22de04fddf52cc3e2470a14bfcc991eedbd78268
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jcrespo 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Switch to git from jessie-backports

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371502 )

Change subject: Switch to git from jessie-backports
..


Switch to git from jessie-backports

We have been using an Ubuntu PPA to get less ancient git binaries since
we were on the Trusty base image. This was most recently installing
a 2.13.0 version of git. The hacks to use a PPA on Jessie are fragile
and the more robust jessie-backports apt repo has version 2.11.0 which
is new enough.

This change will not alter the installed git version on any existing VM.

Change-Id: I476928e95bd808072208144d1284995bda6906b2
---
M puppet/modules/git/manifests/init.pp
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  BryanDavis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/puppet/modules/git/manifests/init.pp 
b/puppet/modules/git/manifests/init.pp
index 7163aa3..acc39e5 100644
--- a/puppet/modules/git/manifests/init.pp
+++ b/puppet/modules/git/manifests/init.pp
@@ -28,11 +28,19 @@
 ) {
 include ::git::gerrit
 
-apt::ppa { 'git-core/ppa': }
+$packages = [
+'git',
+'git-man',
+]
+apt::pin { 'git':
+package  => join(sort($packages), ' '),
+pin  => 'release a=jessie-backports',
+priority => '1001',
+}
 
-package { 'git':
-ensure  => latest,
-require => Apt::Ppa['git-core/ppa'],
+package { $packages:
+ensure  => 'present',
+require => Apt::Pin['git'],
 }
 
 package { 'git-review':

-- 
To view, visit https://gerrit.wikimedia.org/r/371502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I476928e95bd808072208144d1284995bda6906b2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: BryanDavis 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Dduvall 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Design tweak: Update offline library screen background color

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371500 )

Change subject: Design tweak: Update offline library screen background color
..


Design tweak: Update offline library screen background color

Bug: T163587
Change-Id: I39117afb02653f5d31e3a56c22c42097fb300603
---
M app/src/main/res/layout/fragment_local_compilations.xml
M app/src/main/res/values/attrs.xml
M app/src/main/res/values/colors.xml
M app/src/main/res/values/styles_dark.xml
M app/src/main/res/values/styles_light.xml
5 files changed, 9 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/app/src/main/res/layout/fragment_local_compilations.xml 
b/app/src/main/res/layout/fragment_local_compilations.xml
index 58e076e..2abbf17 100644
--- a/app/src/main/res/layout/fragment_local_compilations.xml
+++ b/app/src/main/res/layout/fragment_local_compilations.xml
@@ -7,7 +7,7 @@
 android:layout_height="match_parent"
 android:orientation="vertical"
 android:layout_marginTop="?attr/actionBarSize"
-android:background="?attr/window_background_color">
+android:background="?attr/offline_library_background_color">
 
 
 
 
+
 
 
 
diff --git a/app/src/main/res/values/colors.xml 
b/app/src/main/res/values/colors.xml
index 0ecf2bd..fd9bef6 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -124,6 +124,9 @@
 @color/base70
 @color/base70
 
+@color/base80
+@color/base20
+
 @android:color/white
 @color/base30
 
diff --git a/app/src/main/res/values/styles_dark.xml 
b/app/src/main/res/values/styles_dark.xml
index 5e04149..c519670 100644
--- a/app/src/main/res/values/styles_dark.xml
+++ b/app/src/main/res/values/styles_dark.xml
@@ -58,6 +58,8 @@
 @color/list_item_text_primary_dark
 @color/list_item_text_secondary_dark
 
+@color/offline_library_background_color_dark
+
 @color/base18
 @color/color_state_nav_tab_dark
 
diff --git a/app/src/main/res/values/styles_light.xml 
b/app/src/main/res/values/styles_light.xml
index f04171a..a219cd4 100644
--- a/app/src/main/res/values/styles_light.xml
+++ b/app/src/main/res/values/styles_light.xml
@@ -58,6 +58,8 @@
 @color/list_item_text_primary_light
 @color/list_item_text_secondary_light
 
+@color/offline_library_background_color_light
+
 @android:color/white
 @color/color_state_nav_tab_light
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371500
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39117afb02653f5d31e3a56c22c42097fb300603
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Approve and Cancel payment

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366565 )

Change subject: Approve and Cancel payment
..


Approve and Cancel payment

Bug: T163952
Change-Id: I17545aeb79eef027b046dfab62b3df40763677d0
---
M PaymentProviders/Ingenico/IngenicoPaymentProvider.php
A PaymentProviders/Ingenico/Tests/Data/paymentApproved.response
A PaymentProviders/Ingenico/Tests/Data/paymentCanceled.response
M PaymentProviders/Ingenico/Tests/phpunit/IngenicoPaymentProviderTest.php
4 files changed, 128 insertions(+), 0 deletions(-)

Approvals:
  XenoRyet: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/PaymentProviders/Ingenico/IngenicoPaymentProvider.php 
b/PaymentProviders/Ingenico/IngenicoPaymentProvider.php
index e30a10e..93bf06f 100644
--- a/PaymentProviders/Ingenico/IngenicoPaymentProvider.php
+++ b/PaymentProviders/Ingenico/IngenicoPaymentProvider.php
@@ -24,4 +24,16 @@
$response = $this->api->makeApiCall($path, 'GET');
return $response;
}
+
+   public function approvePayment($paymentId, $params){
+   $path = "payments/$paymentId/approve";
+   $response = $this->api->makeApiCall($path, 'POST', $params);
+   return $response;
+   }
+
+   public function cancelPayment($paymentId){
+   $path = "payments/$paymentId/cancel";
+   $response = $this->api->makeApiCall($path, 'POST');
+   return $response;
+   }
 }
diff --git a/PaymentProviders/Ingenico/Tests/Data/paymentApproved.response 
b/PaymentProviders/Ingenico/Tests/Data/paymentApproved.response
new file mode 100644
index 000..ac311f9
--- /dev/null
+++ b/PaymentProviders/Ingenico/Tests/Data/paymentApproved.response
@@ -0,0 +1,42 @@
+HTTP/1.1 200 OK
+Date: Mon, 30 Jan 2017 17:58:02 GMT
+Server: Apache/2.4.16 (Unix) OpenSSL/1.0.1t
+X-Powered-By: Servlet/3.0 JSP/2.2
+Transfer-Encoding: chunked
+Content-Type: application/json
+
+{
+  "payment": {
+"id": "00850011881821",
+"paymentOutput": {
+  "amountOfMoney": {
+"amount": 2890,
+"currencyCode": "EUR"
+  },
+  "references": {
+"paymentReference": "0"
+  },
+  "paymentMethod": "card",
+  "cardPaymentMethodSpecificOutput": {
+"paymentProductId": 1,
+"authorisationCode": "123456",
+"card": {
+  "cardNumber": "7977",
+  "expiryDate": "1220"
+},
+"fraudResults": {
+  "avsResult": "0",
+  "cvvResult": "M",
+  "fraudServiceResult": "no-advice"
+}
+  }
+},
+"status": "CAPTURE_REQUESTED",
+"statusOutput": {
+  "isCancellable": false,
+  "statusCode": 800,
+  "statusCodeChangeDateTime": "20140627140735",
+  "isAuthorized": true
+}
+  }
+}
\ No newline at end of file
diff --git a/PaymentProviders/Ingenico/Tests/Data/paymentCanceled.response 
b/PaymentProviders/Ingenico/Tests/Data/paymentCanceled.response
new file mode 100644
index 000..b64fe66
--- /dev/null
+++ b/PaymentProviders/Ingenico/Tests/Data/paymentCanceled.response
@@ -0,0 +1,45 @@
+HTTP/1.1 200 OK
+Date: Mon, 30 Jan 2017 17:58:02 GMT
+Server: Apache/2.4.16 (Unix) OpenSSL/1.0.1t
+X-Powered-By: Servlet/3.0 JSP/2.2
+Transfer-Encoding: chunked
+Content-Type: application/json
+
+{
+  "payment": {
+"id": "00850011881821",
+"paymentOutput": {
+  "amountOfMoney": {
+"amount": 2890,
+"currencyCode": "EUR"
+  },
+  "references": {
+"merchantReference": "merchantReference",
+"paymentReference": "0"
+  },
+  "paymentMethod": "card",
+  "cardPaymentMethodSpecificOutput": {
+"paymentProductId": 1,
+"authorisationCode": "726747",
+"card": {
+  "cardNumber": "7977",
+  "expiryDate": "1220"
+},
+"fraudResults": {
+  "avsResult": "0",
+  "cvvResult": "0",
+  "fraudServiceResult": "no-advice"
+}
+  }
+},
+"status": "CANCELLED",
+"statusOutput": {
+  "isCancellable": false,
+  "statusCode": 9,
+  "statusCodeChangeDateTime": "20150223153431"
+}
+  },
+"cardPaymentMethodSpecificOutput": {
+  "voidResponseId": "0"
+  }
+}
diff --git 
a/PaymentProviders/Ingenico/Tests/phpunit/IngenicoPaymentProviderTest.php 
b/PaymentProviders/Ingenico/Tests/phpunit/IngenicoPaymentProviderTest.php
index eaa54a6..19fb291 100644
--- a/PaymentProviders/Ingenico/Tests/phpunit/IngenicoPaymentProviderTest.php
+++ b/PaymentProviders/Ingenico/Tests/phpunit/IngenicoPaymentProviderTest.php
@@ -32,4 +32,33 @@
$response = $this->provider->getPaymentStatus($paymentId);
$this->assertEquals($paymentId, $response['id']);
}
+
+   public function testApprovePayment(){
+   $paymentId = 

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceFoundation[master]: New hook handler base classes

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/349924 )

Change subject: New hook handler base classes
..


New hook handler base classes

* Added Hook base classes
** Added reference implementations for hooks
* Added new Config factory

Change-Id: I6b75430ee4bdd5aa9b225dafa7dd46bedef61f40
---
M extension.json
M includes/CoreHooks.php
A src/Config.php
A src/Hooks/BeforePageDisplay.php
A src/Hooks/Hook.php
A src/Hooks/LinkEnd.php
A src/Hooks/LinkEnd/AddDataTitle.php
A src/Hooks/LinkEnd/AddDataUserName.php
A src/Hooks/LoadExtensionSchemaUpdates.php
A src/Hooks/MakeGlobalVariablesScript.php
A src/Hooks/PageContentSaveComplete.php
A src/Hooks/ParserFirstCallInit.php
A src/Hooks/SkinTemplateNavigation.php
A src/Hooks/SoftwareInfo.php
A src/Hooks/SoftwareInfo/AddBlueSpice.php
A src/Hooks/UserCan.php
A src/Hooks/UserGetRights.php
A tests/phpunit/Hooks/LinkEnd/AddDataTitleTest.php
A tests/phpunit/Hooks/LinkEnd/AddDataUserNameTest.php
A tests/phpunit/Hooks/SoftwareInfo/AddBlueSpiceTest.php
20 files changed, 994 insertions(+), 47 deletions(-)

Approvals:
  Pwirth: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index 4149638..6b6a86c 100644
--- a/extension.json
+++ b/extension.json
@@ -396,9 +396,12 @@
},
"Hooks": {
"SetupAfterCache": "BsCoreHooks::onSetupAfterCache",
-   "SoftwareInfo": "BsCoreHooks::onSoftwareInfo",
+   "SoftwareInfo": 
"BlueSpice\\Hooks\\SoftwareInfo\\AddBlueSpice::callback",
"BeforePageDisplay": "BsCoreHooks::onBeforePageDisplay",
-   "LinkEnd": "BsCoreHooks::onLinkEnd",
+   "LinkEnd": [
+   "BlueSpice\\Hooks\\LinkEnd\\AddDataTitle::callback",
+   "BlueSpice\\Hooks\\LinkEnd\\AddDataUserName::callback"
+   ],
"LinkerMakeMediaLinkFile": 
"BsCoreHooks::onLinkerMakeMediaLinkFile",
"ThumbnailBeforeProduceHTML": 
"BsCoreHooks::onThumbnailBeforeProduceHTML",
"MakeGlobalVariablesScript": 
"BsCoreHooks::onMakeGlobalVariablesScript",
@@ -431,6 +434,9 @@
},
"ConfigFiles": []
},
+   "ConfigRegistry": {
+   "bsg": "BlueSpice\\Config::newInstance"
+   },
"AutoloadClasses": {
"BsCore": "includes/Core.class.php",
"BsCoreHooks": "includes/CoreHooks.php",
diff --git a/includes/CoreHooks.php b/includes/CoreHooks.php
index 7f15b3d..e53c7ac 100755
--- a/includes/CoreHooks.php
+++ b/includes/CoreHooks.php
@@ -53,16 +53,6 @@
return true;
}
 
-   /**
-* Called by Special:Version for returning information about the 
software
-* @param Array $aSoftware: The array of software in format 'name' => 
'version'.
-*/
-   public static function onSoftwareInfo( &$aSoftware ) {
-   global $bsgBlueSpiceExtInfo;
-   $aSoftware['[http://bluespice.com/ ' . 
$bsgBlueSpiceExtInfo['name'] . '] ([' . SpecialPage::getTitleFor( 
'SpecialCredits' )->getFullURL() . ' Credits])'] = 
$bsgBlueSpiceExtInfo['version'];
-   return true;
-   }
-
public static function setup() {
HTMLForm::$typeMappings['staticimage'] = 
'HTMLStaticImageFieldOverride';
HTMLForm::$typeMappings['link'] = 'HTMLInfoFieldOverride';
@@ -314,41 +304,6 @@
}
return true;
}
-
-   /**
-* Adds additional data to links generated by the framework. This 
allows us
-* to add more functionality to the UI.
-* @param SkinTemplate $skin
-* @param Title $target
-* @param array $options
-* @param string $html
-* @param array $attribs
-* @param string $ret
-* @return boolean Always true to keep hook running
-*/
-   public static function onLinkEnd( $skin, $target, $options, &$html, 
&$attribs, &$ret ) {
-   //We add the original title to a link. This may be the same 
content as
-   //"title" attribute, but it doesn't have to. I.e. in red links
-   $attribs['data-bs-title'] = $target->getPrefixedText();
-
-   if( $target->getNamespace() == NS_USER && $target->isSubpage() 
=== false ) {
-   //Linker::userLink adds class "mw-userlink" by default
-   /*if( !isset($attribs['class']) ) {
-   $attribs['class'] = '';
-   }
-   $attribs['class'] .= ' user';*/
-   if( $target->getText() == $html ) {
-   $html = htmlspecialchars(
-   BsUserHelper::getUserDisplayName(
-   User::newFromName( 
$target->getText() )
- 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use correct variable name in @param documentation

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371495 )

Change subject: Use correct variable name in @param documentation
..


Use correct variable name in @param documentation

For some varargs a variable name is added with suffix ,... as seen for
many other varargs

Some @param are swapped, because there are in the wrong order

Enable Sniff MediaWiki.Commenting.FunctionComment.ParamNameNoMatch

Change-Id: I60fec6025bce824d5c67563ab7b65ad6cd628ad8
---
M includes/FauxRequest.php
M includes/GlobalFunctions.php
M includes/Message.php
M includes/OutputPage.php
M includes/api/ApiAuthManagerHelper.php
M includes/api/ApiBase.php
M includes/api/ApiMain.php
M includes/api/SearchApi.php
M includes/collation/CustomUppercaseCollation.php
M includes/context/ContextSource.php
M includes/context/RequestContext.php
M includes/htmlform/HTMLForm.php
M includes/libs/MemoizedCallable.php
M includes/libs/MultiHttpClient.php
M includes/libs/filebackend/FileBackend.php
M includes/libs/objectcache/BagOStuff.php
M includes/libs/objectcache/MultiWriteBagOStuff.php
M includes/libs/objectcache/WANObjectCache.php
M includes/libs/rdbms/database/Database.php
M includes/libs/rdbms/lbfactory/ILBFactory.php
M includes/logging/LogEventsList.php
M includes/mail/UserMailer.php
M includes/media/WebP.php
M includes/parser/ParserOptions.php
M includes/resourceloader/ResourceLoader.php
M includes/resourceloader/ResourceLoaderContext.php
M includes/revisiondelete/RevDelList.php
M includes/search/SearchExactMatchRescorer.php
M includes/search/SearchSuggestion.php
M includes/session/PHPSessionHandler.php
M includes/session/SessionProvider.php
M includes/skins/BaseTemplate.php
M includes/specials/SpecialFilepath.php
M includes/specials/SpecialMediaStatistics.php
M includes/user/User.php
M includes/utils/AutoloadGenerator.php
M phpcs.xml
M tests/parser/ParserTestRunner.php
M tests/phpunit/includes/auth/LegacyHookPreAuthenticationProviderTest.php
39 files changed, 45 insertions(+), 45 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, but someone else must approve



diff --git a/includes/FauxRequest.php b/includes/FauxRequest.php
index 3b2283b..9147240 100644
--- a/includes/FauxRequest.php
+++ b/includes/FauxRequest.php
@@ -126,7 +126,7 @@
 
/**
 * @since 1.26
-* @param string $name Unprefixed name of the cookie to set
+* @param string $key Unprefixed name of the cookie to set
 * @param string|null $value Value of the cookie to set
 * @param string|null $prefix Cookie prefix. Defaults to $wgCookiePrefix
 */
diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index b35a1f0..49159ed 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -2234,7 +2234,8 @@
  * (https://bugs.php.net/bug.php?id=26285) and the locale problems on Linux in
  * PHP 5.2.6+ (bug backported to earlier distro releases of PHP).
  *
- * @param string ... strings to escape and glue together, or a single array of 
strings parameter
+ * @param string $args,... strings to escape and glue together,
+ *  or a single array of strings parameter
  * @return string
  */
 function wfEscapeShellArg( /*...*/ ) {
diff --git a/includes/Message.php b/includes/Message.php
index be6b0af..8777c6f 100644
--- a/includes/Message.php
+++ b/includes/Message.php
@@ -488,7 +488,7 @@
 *
 * @since 1.17
 *
-* @param mixed ... Parameters as strings or arrays from
+* @param mixed $args,... Parameters as strings or arrays from
 *  Message::numParam() and the like, or a single array of parameters.
 *
 * @return Message $this
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 57cb194..8f62a85 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -688,7 +688,7 @@
 * Add one or more head items to the output
 *
 * @since 1.28
-* @param string|string[] $value Raw HTML
+* @param string|string[] $values Raw HTML
 */
public function addHeadItems( $values ) {
$this->mHeadItems = array_merge( $this->mHeadItems, 
(array)$values );
@@ -3797,7 +3797,7 @@
 * Caller is responsible for ensuring the file exists. Emits a PHP 
warning otherwise.
 *
 * @since 1.27
-* @param string $remotePath URL path prefix that points to $localPath
+* @param string $remotePathPrefix URL path prefix that points to 
$localPath
 * @param string $localPath File directory exposed at $remotePath
 * @param string $file Path to target file relative to $localPath
 * @return string URL
diff --git a/includes/api/ApiAuthManagerHelper.php 
b/includes/api/ApiAuthManagerHelper.php
index 3a9fb73..d6b9f76 100644
--- 

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: Fix JQMIGRATE warnings in jQuery Mobile

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371511 )

Change subject: Fix JQMIGRATE warnings in jQuery Mobile
..


Fix JQMIGRATE warnings in jQuery Mobile

jQuery Mobile 1.5 is supposed to be compatible with jQuery 3, but it isn't...

* Replace .bind() calls with .on()
* Replace .unbind() calls with .off()

Bug: T165816
Change-Id: I79639fd9ae8e6e785f93191273147866e52c4ed1
---
M resources/libraries/jquery.mobile.custom.js
1 file changed, 30 insertions(+), 26 deletions(-)

Approvals:
  jenkins-bot: Verified
  Isarra: Looks good to me, approved



diff --git a/resources/libraries/jquery.mobile.custom.js 
b/resources/libraries/jquery.mobile.custom.js
index 376d183..bb1353f 100644
--- a/resources/libraries/jquery.mobile.custom.js
+++ b/resources/libraries/jquery.mobile.custom.js
@@ -1,3 +1,7 @@
+// Custom hacks:
+// * Replaced .bind() calls with .on() for compatibility with jQuery 3
+// * Replaced .unbind() calls with .off() for compatibility with jQuery 3
+
 /*
 * jQuery Mobile v1.4.5
 * http://jquerymobile.com
@@ -366,14 +370,14 @@
activeDocHandlers[ eventType ] = ( activeDocHandlers[ 
eventType ] || 0 ) + 1;
 
if ( activeDocHandlers[ eventType ] === 1 ) {
-   $document.bind( realType, mouseEventCallback );
+   $document.on( realType, mouseEventCallback );
}
 
// Some browsers, like Opera Mini, won't dispatch 
mouse/click events
// for elements unless they actually have handlers 
registered on them.
// To get around this, we register dummy handlers on 
the elements.
 
-   $( this ).bind( realType, dummyMouseHandler );
+   $( this ).on( realType, dummyMouseHandler );
 
// For now, if event capture is not supported, we rely 
on mouse handlers.
if ( eventCaptureSupported ) {
@@ -383,8 +387,8 @@
activeDocHandlers[ "touchstart" ] = ( 
activeDocHandlers[ "touchstart" ] || 0) + 1;
 
if ( activeDocHandlers[ "touchstart" ] === 1 ) {
-   $document.bind( "touchstart", 
handleTouchStart )
-   .bind( "touchend", 
handleTouchEnd )
+   $document.on( "touchstart", 
handleTouchStart )
+   .on( "touchend", handleTouchEnd 
)
 
// On touch platforms, touching 
the screen and then dragging your finger
// causes the window content to 
scroll after some distance threshold is
@@ -396,8 +400,8 @@
// we need to watch both scroll 
and touchmove events to figure out whether
// or not a scroll happenens 
before the touchend event is fired.
 
-   .bind( "touchmove", 
handleTouchMove )
-   .bind( "scroll", handleScroll );
+   .on( "touchmove", 
handleTouchMove )
+   .on( "scroll", handleScroll );
}
}
},
@@ -409,7 +413,7 @@
--activeDocHandlers[ eventType ];
 
if ( !activeDocHandlers[ eventType ] ) {
-   $document.unbind( realType, mouseEventCallback 
);
+   $document.off( realType, mouseEventCallback );
}
 
if ( eventCaptureSupported ) {
@@ -419,10 +423,10 @@
--activeDocHandlers[ "touchstart" ];
 
if ( !activeDocHandlers[ "touchstart" ] ) {
-   $document.unbind( "touchstart", 
handleTouchStart )
-   .unbind( "touchmove", 
handleTouchMove )
-   .unbind( "touchend", 
handleTouchEnd )
-   .unbind( "scroll", handleScroll 
);
+   $document.off( "touchstart", 
handleTouchStart )
+   .off( "touchmove", 
handleTouchMove )
+   .off( "touchend", 
handleTouchEnd )
+   .off( "scroll", handleScroll );
}
}
 
@@ -440,7 +444,7 @@
 
// Unregister the dummy event handler.
 
- 

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Fix : No comma escaping for hierarchy structure

[Fz-29 (Code Review)]

Fz-29 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371512 )

Change subject: Fix : No comma escaping for hierarchy structure
..

Fix : No comma escaping for hierarchy structure

Change-Id: I94210eddb59de4a4da80fae5a2e8eaad3fb889eb
---
M CargoFieldDescription.php
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/12/371512/1

diff --git a/CargoFieldDescription.php b/CargoFieldDescription.php
index 8c22c58..6c78859 100644
--- a/CargoFieldDescription.php
+++ b/CargoFieldDescription.php
@@ -80,11 +80,11 @@
// Remove 
prefix of multiple "*"

$allowedValuesArray[] = preg_replace( '/^[*]*/', '', $node );
}
-   $paramValue = implode( 
',', $allowedValuesArray );
+   } else {
+   $delimiter = ',';
+   $allowedValuesStr = 
str_replace( "\\$delimiter", "\a", $paramValue );
+   $allowedValuesArray = 
explode( $delimiter, $allowedValuesStr );
}
-   $delimiter = ',';
-   $allowedValuesStr = 
str_replace( "\\$delimiter", "\a", $paramValue );
-   $allowedValuesArray = explode( 
$delimiter, $allowedValuesStr );
foreach ( $allowedValuesArray 
as $i => $value ) {
if ( $value == '' ) 
continue;
// Replace beep back 
with delimiter, trim.

-- 
To view, visit https://gerrit.wikimedia.org/r/371512
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94210eddb59de4a4da80fae5a2e8eaad3fb889eb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Fz-29 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics...web[master]: Load Open Sans from fontcdn

[Ricordisamoa (Code Review)]

Ricordisamoa has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371514 )

Change subject: Load Open Sans from fontcdn
..

Load Open Sans from fontcdn

As a side effect, browsers that support unicode-range will automatically
download and use font files for additional subsets (e.g. cyrillic, greek)
if needed.

Change-Id: I28d78a1d5a4525b6a3e433d278a7c51c37338b08
---
D quarry/web/static/css/fonts.css
D quarry/web/static/fonts/open-sans-bold-italic.woff
D quarry/web/static/fonts/open-sans-bold.woff
D quarry/web/static/fonts/open-sans-italic.woff
D quarry/web/static/fonts/open-sans-light-italic.woff
D quarry/web/static/fonts/open-sans-light.woff
D quarry/web/static/fonts/open-sans.woff
M quarry/web/templates/base.html
8 files changed, 1 insertion(+), 38 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/quarry/web 
refs/changes/14/371514/1

diff --git a/quarry/web/static/css/fonts.css b/quarry/web/static/css/fonts.css
deleted file mode 100644
index 93351db..000
--- a/quarry/web/static/css/fonts.css
+++ /dev/null
@@ -1,37 +0,0 @@
-@font-face {
-  font-family: 'Open Sans';
-  font-style: normal;
-  font-weight: 300;
-  src: local('Open Sans Light'), local('OpenSans-Light'), 
url(/static/fonts/open-sans-light.woff) format('woff');
-}
-@font-face {
-  font-family: 'Open Sans';
-  font-style: normal;
-  font-weight: 400;
-  src: local('Open Sans'), local('OpenSans'), 
url(/static/fonts/open-sans.woff) format('woff');
-}
-@font-face {
-  font-family: 'Open Sans';
-  font-style: normal;
-  font-weight: 700;
-  src: local('Open Sans Bold'), local('OpenSans-Bold'), 
url(/static/fonts/open-sans-bold.woff) format('woff');
-}
-@font-face {
-  font-family: 'Open Sans';
-  font-style: italic;
-  font-weight: 300;
-  src: local('Open Sans Light Italic'), local('OpenSansLight-Italic'), 
url(/static/fonts/open-sans-light-italic.woff) format('woff');
-}
-@font-face {
-  font-family: 'Open Sans';
-  font-style: italic;
-  font-weight: 400;
-  src: local('Open Sans Italic'), local('OpenSans-Italic'), 
url(/static/fonts/open-sans-italic.woff) format('woff');
-}
-@font-face {
-  font-family: 'Open Sans';
-  font-style: italic;
-  font-weight: 700;
-  src: local('Open Sans Bold Italic'), local('OpenSans-BoldItalic'), 
url(/static/fonts/open-sans-bold-italic.woff) format('woff');
-}
-
diff --git a/quarry/web/static/fonts/open-sans-bold-italic.woff 
b/quarry/web/static/fonts/open-sans-bold-italic.woff
deleted file mode 100644
index a4e29c0..000
--- a/quarry/web/static/fonts/open-sans-bold-italic.woff
+++ /dev/null
Binary files differ
diff --git a/quarry/web/static/fonts/open-sans-bold.woff 
b/quarry/web/static/fonts/open-sans-bold.woff
deleted file mode 100644
index dacf3c9..000
--- a/quarry/web/static/fonts/open-sans-bold.woff
+++ /dev/null
Binary files differ
diff --git a/quarry/web/static/fonts/open-sans-italic.woff 
b/quarry/web/static/fonts/open-sans-italic.woff
deleted file mode 100644
index c5f6bac..000
--- a/quarry/web/static/fonts/open-sans-italic.woff
+++ /dev/null
Binary files differ
diff --git a/quarry/web/static/fonts/open-sans-light-italic.woff 
b/quarry/web/static/fonts/open-sans-light-italic.woff
deleted file mode 100644
index 3f9f088..000
--- a/quarry/web/static/fonts/open-sans-light-italic.woff
+++ /dev/null
Binary files differ
diff --git a/quarry/web/static/fonts/open-sans-light.woff 
b/quarry/web/static/fonts/open-sans-light.woff
deleted file mode 100644
index eb601d7..000
--- a/quarry/web/static/fonts/open-sans-light.woff
+++ /dev/null
Binary files differ
diff --git a/quarry/web/static/fonts/open-sans.woff 
b/quarry/web/static/fonts/open-sans.woff
deleted file mode 100644
index 77706fa..000
--- a/quarry/web/static/fonts/open-sans.woff
+++ /dev/null
Binary files differ
diff --git a/quarry/web/templates/base.html b/quarry/web/templates/base.html
index b60ad60..718c561 100644
--- a/quarry/web/templates/base.html
+++ b/quarry/web/templates/base.html
@@ -17,7 +17,7 @@
 
 {% endif %}
 
-
+
 
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371514
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28d78a1d5a4525b6a3e433d278a7c51c37338b08
Gerrit-PatchSet: 1
Gerrit-Project: analytics/quarry/web
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...OATHAuth[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371354 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I9cb1df1c9c56bbcb26c9606f33949185ba0235a4
---
M composer.json
M maintenance/disableOATHAuthForUser.php
M maintenance/update_scratch_token_format.php
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 30b3fcf..2b9d0e3 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/maintenance/disableOATHAuthForUser.php 
b/maintenance/disableOATHAuthForUser.php
index e44b578..612f07d 100644
--- a/maintenance/disableOATHAuthForUser.php
+++ b/maintenance/disableOATHAuthForUser.php
@@ -3,7 +3,7 @@
 if ( getenv( 'MW_INSTALL_PATH' ) ) {
$IP = getenv( 'MW_INSTALL_PATH' );
 } else {
-   $IP =  __DIR__ . '/../../..';
+   $IP = __DIR__ . '/../../..';
 }
 require_once "$IP/maintenance/Maintenance.php";
 
diff --git a/maintenance/update_scratch_token_format.php 
b/maintenance/update_scratch_token_format.php
index 1f887b9..22e64f1 100644
--- a/maintenance/update_scratch_token_format.php
+++ b/maintenance/update_scratch_token_format.php
@@ -27,7 +27,7 @@
 if ( getenv( 'MW_INSTALL_PATH' ) ) {
$IP = getenv( 'MW_INSTALL_PATH' );
 } else {
-   $IP =  __DIR__ . '/../../..';
+   $IP = __DIR__ . '/../../..';
 }
 require_once "$IP/maintenance/Maintenance.php";
 

-- 
To view, visit https://gerrit.wikimedia.org/r/371354
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9cb1df1c9c56bbcb26c9606f33949185ba0235a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OATHAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: mariadb: Adding rack allocations, some formatting fixes

[Jcrespo (Code Review)]

Jcrespo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371444 )

Change subject: mariadb: Adding rack allocations, some formatting fixes
..

mariadb: Adding rack allocations, some formatting fixes

Bug: T172459
Change-Id: I9eee9a9cebbeb94072361dff73c72e7c8759ab27
---
M wmf-config/db-eqiad.php
1 file changed, 60 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/44/371444/1

diff --git a/wmf-config/db-eqiad.php b/wmf-config/db-eqiad.php
index 902b5d4..8205c66 100644
--- a/wmf-config/db-eqiad.php
+++ b/wmf-config/db-eqiad.php
@@ -8,15 +8,15 @@
 # $wgReadOnly = "Wikimedia Sites are currently read-only during maintenance, 
please try again soon.";
 
 $wmgParserCacheDBs = [
-   '10.64.0.12'   => '10.64.0.12',   # pc1004
-   '10.64.32.72'  => '10.64.32.72',  # pc1005
-   '10.64.48.128' => '10.64.48.128', # pc1006
+   '10.64.0.12'   => '10.64.0.12',   # pc1004, A3 2.4TB 256GB
+   '10.64.32.72'  => '10.64.32.72',  # pc1005, C7 2.4TB 256GB
+   '10.64.48.128' => '10.64.48.128', # pc1006, D3 2.4TB 256GB
 ];
 
 $wmgOldExtTemplate = [
-   '10.64.0.7'=> 1, # es1012
-   '10.64.32.185' => 1, # es1016
-   '10.64.48.115' => 1, # es1018
+   '10.64.0.7'=> 1, # es1012, A2 11TB 128GB
+   '10.64.32.185' => 1, # es1016, C2 11TB 128GB
+   '10.64.48.115' => 1, # es1018, D1 11TB 128GB
 ];
 
 $wgLBFactoryConf = [
@@ -24,52 +24,60 @@
 'class' => 'LBFactoryMulti',
 
 'sectionsByDB' => [
-   'enwiki' => 's1',
+   # s1: enwiki
+   'enwiki'   => 's1',
 
-   # New master
-   'bgwiki' => 's2',
+   # s2: large wikis
+   'bgwiki'   => 's2',
'bgwiktionary' => 's2',
-   'cswiki' => 's2',
-   'enwikiquote' => 's2',
+   'cswiki'   => 's2',
+   'enwikiquote'  => 's2',
'enwiktionary' => 's2',
-   'eowiki' => 's2',
-   'fiwiki' => 's2',
-   'idwiki' => 's2',
-   'itwiki' => 's2',
-   'nlwiki' => 's2',
-   'nowiki' => 's2',
-   'plwiki' => 's2',
-   'ptwiki' => 's2',
-   'svwiki' => 's2',
-   'thwiki' => 's2',
-   'trwiki' => 's2',
-   'zhwiki' => 's2',
+   'eowiki'   => 's2',
+   'fiwiki'   => 's2',
+   'idwiki'   => 's2',
+   'itwiki'   => 's2',
+   'nlwiki'   => 's2',
+   'nowiki'   => 's2',
+   'plwiki'   => 's2',
+   'ptwiki'   => 's2',
+   'svwiki'   => 's2',
+   'thwiki'   => 's2',
+   'trwiki'   => 's2',
+   'zhwiki'   => 's2',
 
-   'commonswiki' => 's4',
+   # s3 (default)
 
-   'dewiki' => 's5',
+   # s4: commons
+   'commonswiki'  => 's4',
+
+   # s5: dewiki and wikidata
+   'dewiki'   => 's5',
'wikidatawiki' => 's5',
 
-   'frwiki' => 's6',
-   'jawiki' => 's6',
-   'ruwiki' => 's6',
+   # s6: large wikis
+   'frwiki'   => 's6',
+   'jawiki'   => 's6',
+   'ruwiki'   => 's6',
 
-   'eswiki' => 's7',
-   'huwiki' => 's7',
-   'hewiki' => 's7',
-   'ukwiki' => 's7',
+   # s7: large wikis, centralauth
+   'eswiki'   => 's7',
+   'huwiki'   => 's7',
+   'hewiki'   => 's7',
+   'ukwiki'   => 's7',
'frwiktionary' => 's7',
-   'metawiki' => 's7',
-   'arwiki' => 's7',
-   'centralauth' => 's7',
-   'cawiki' => 's7',
-   'viwiki' => 's7',
-   'fawiki' => 's7',
-   'rowiki' => 's7',
-   'kowiki' => 's7',
+   'metawiki' => 's7',
+   'arwiki'   => 's7',
+   'centralauth'  => 's7',
+   'cawiki'   => 's7',
+   'viwiki'   => 's7',
+   'fawiki'   => 's7',
+   'rowiki'   => 's7',
+   'kowiki'   => 's7',
 
-   'labswiki' => 'silver',
-   'labtestwiki' => 'labtestweb2001',
+   # labs-related wikis
+   'labswiki' => 'silver',
+   'labtestwiki'  => 'labtestweb2001',
 ],
 
 # Load lists
@@ -168,10 +176,10 @@
'db1094' => 500, # D2 3.6TB 512GB
],
'silver' => [
-   'silver' => 100,   # I have no idea if this is right
+   'silver' => 1,
],
'labtestweb2001' => [
-   'labtestweb2001' => 100,   # I have no idea if this is right
+   'labtestweb2001' => 1,
],
 ],
 
@@ -628,20 +636,20 @@
 
# es2
'cluster24' => [
-   '10.64.0.6'=> 0, # es1011, master
-   '10.64.16.186' => 1, # es1013
-   '10.64.32.184' => 1, # es1015
+   '10.64.0.6'=> 0, # es1011, A2 11TB 128GB, master
+   '10.64.16.186' => 1, # es1013, B1 11TB 128GB
+   '10.64.32.184' => 1, # es1015, C2 11TB 128GB
],
# es3
'cluster25' => [
-   '10.64.16.187' => 0, # es1014, master
-   

[MediaWiki-commits] [Gerrit] mediawiki...Petition[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371373 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I30b78b287a6279134c11ec32d9426cacc827bba3
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371373
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I30b78b287a6279134c11ec32d9426cacc827bba3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Petition
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Poem[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371374 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I6b362dea6f212e12201687356efedcc615b23079
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 1c2721a..bb054d0 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371374
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b362dea6f212e12201687356efedcc615b23079
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Poem
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PerformanceInspector[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371372 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Iefc7833cbb940cc9ec7b7cb61baa547291d7b67f
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 9d51547..72f03ac 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"license": "GPL-2+",

-- 
To view, visit https://gerrit.wikimedia.org/r/371372
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iefc7833cbb940cc9ec7b7cb61baa547291d7b67f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PerformanceInspector
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ReplaceText[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371385 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ide9ed648b36b752fe9290ba20fad4d0932da6eff
---
M SpecialReplaceText.php
M composer.json
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SpecialReplaceText.php b/SpecialReplaceText.php
index 5714ada..8e2a497 100644
--- a/SpecialReplaceText.php
+++ b/SpecialReplaceText.php
@@ -363,7 +363,7 @@
Xml::element(
'input',
[
-   'type'=>'button',
+   'type' => 'button',
'id' => 
'mw-search-toggleall',
// 'onclick' value 
needed for MW 1.16
'onclick' => 
'mwToggleSearchCheckboxes("all");',
@@ -373,7 +373,7 @@
Xml::element(
'input',
[
-   'type'=>'button',
+   'type' => 'button',
'id' => 
'mw-search-togglenone',
// 'onclick' value 
needed for MW 1.16
'onclick' => 
'mwToggleSearchCheckboxes("none");',
diff --git a/composer.json b/composer.json
index d368985..a4c40a7 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371385
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide9ed648b36b752fe9290ba20fad4d0932da6eff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReplaceText
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SandboxLink[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371387 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I862e7be28dda89cdfcc51bdc465b42bf96329b62
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 55507be..d1e3215 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I862e7be28dda89cdfcc51bdc465b42bf96329b62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SandboxLink
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TemplateStyles[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371403 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I59ba41e53abae528f5a62ae172b0db0c0f60b35f
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index cd16d40..39967c6 100644
--- a/composer.json
+++ b/composer.json
@@ -6,7 +6,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371403
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I59ba41e53abae528f5a62ae172b0db0c0f60b35f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TemplateStyles
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PronunciationRecording[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371377 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I3014d4b656c05fed47cabd1421b775ba13513dc5
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 55507be..d1e3215 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371377
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3014d4b656c05fed47cabd1421b775ba13513dc5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PronunciationRecording
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SubpageSortkey[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371399 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ibce602f660d387bbf6792b767a0e664e2eb89163
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371399
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibce602f660d387bbf6792b767a0e664e2eb89163
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SubpageSortkey
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Thanks[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371406 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ib52c07af6c0a03031b71ed95b287e7ea68309c1c
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 76e0f9d..57ecddd 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371406
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib52c07af6c0a03031b71ed95b287e7ea68309c1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Thanks
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371408 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected
* MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.MissingReturn
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.Commenting.FunctionComment.WrongStyle

The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment

Change-Id: I39f584dceb8564e60148064855179fe8a6bc3be8
---
M ApiTranscodeStatus.php
M SpecialTimedMediaHandler.php
M TimedMediaHandler.hooks.php
M TimedMediaHandler.i18n.magic.php
M TimedMediaHandler_body.php
M TimedMediaThumbnail.php
M TimedMediaTransformOutput.php
M TimedTextPage.php
M TranscodeStatusTable.php
M WebVideoTranscode/WebVideoTranscode.php
M WebVideoTranscode/WebVideoTranscodeJob.php
M composer.json
M handlers/FLACHandler/FLACHandler.php
M handlers/Mp3Handler/Mp3Handler.php
M handlers/Mp4Handler/Mp4Handler.php
M handlers/OggHandler/OggHandler.php
M handlers/TextHandler/TextHandler.php
M handlers/WAVHandler/WAVHandler.php
M handlers/WebMHandler/WebMHandler.php
M phpcs.xml
20 files changed, 92 insertions(+), 85 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ApiTranscodeStatus.php b/ApiTranscodeStatus.php
index a2e4d45..59a352a 100644
--- a/ApiTranscodeStatus.php
+++ b/ApiTranscodeStatus.php
@@ -25,7 +25,7 @@
if ( 
TimedMediaHandlerHooks::isTranscodableTitle( $img->getTitle() ) ) {
$transcodeStatus = 
WebVideoTranscode::getTranscodeState( $img );
// remove useless properties
-   foreach ( $transcodeStatus as 
$key=>&$val ) {
+   foreach ( $transcodeStatus as $key => 
&$val ) {
unset( $val['id'] );
unset( $val['image_name'] );
unset( $val['key'] );
diff --git a/SpecialTimedMediaHandler.php b/SpecialTimedMediaHandler.php
index 36f5929..1622090 100644
--- a/SpecialTimedMediaHandler.php
+++ b/SpecialTimedMediaHandler.php
@@ -149,7 +149,7 @@
. ''
. "\n";
}
-   $table .=  '';
+   $table .= '';
return $table;
}
 
@@ -157,7 +157,7 @@
global $wgEnabledTranscodeSet, $wgEnabledAudioTranscodeSet, 
$wgMemc;
$allTranscodes = array_merge( $wgEnabledTranscodeSet, 
$wgEnabledAudioTranscodeSet );
 
-   $memcKey= wfMemcKey( 'TimedMediaHandler', 'stats', '1' /* 
version */ );
+   $memcKey = wfMemcKey( 'TimedMediaHandler', 'stats', '1' /* 
version */ );
$stats = $wgMemc->get( $memcKey );
if ( !$stats ) {
$dbr = wfGetDB( DB_SLAVE );
diff --git a/TimedMediaHandler.hooks.php b/TimedMediaHandler.hooks.php
index eae75c6..ded4ee2 100644
--- a/TimedMediaHandler.hooks.php
+++ b/TimedMediaHandler.hooks.php
@@ -22,7 +22,7 @@
if ( $wgEnableLocalTimedText ) {
if ( !defined( 'NS_TIMEDTEXT' ) ) {
define( 'NS_TIMEDTEXT', $wgTimedTextNS );
-   define( 'NS_TIMEDTEXT_TALK', $wgTimedTextNS +1 
);
+   define( 'NS_TIMEDTEXT_TALK', $wgTimedTextNS + 1 
);
}
 
$list[NS_TIMEDTEXT] = 'TimedText';
@@ -73,9 +73,9 @@
'mw.MwEmbedSupport',
],
],
-   "mw.MediaWikiPlayerSupport" =>  $baseExtensionResource 
+ [
+   "mw.MediaWikiPlayerSupport" => $baseExtensionResource + 
[
'scripts' => 
'resources/mw.MediaWikiPlayerSupport.js',
-   'dependencies'=> [
+   'dependencies' => [
'mw.Api',
'mw.MwEmbedSupport',
],
@@ -212,7 +212,7 @@
$wgTmhTheoraTwoPassEncoding, $wgWikimediaJenkinsCI;
 
// set config for parser tests
-   if ( isset( $wgWikimediaJenkinsCI ) && $wgWikimediaJenkinsCI  
=== true ) {
+  

[MediaWiki-commits] [Gerrit] mediawiki...TopTenPages[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371411 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ie00d624a2611181ac3a3a3e95c4627a28c31ad86
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 55507be..d1e3215 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371411
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie00d624a2611181ac3a3a3e95c4627a28c31ad86
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TopTenPages
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TrustedXFF[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371414 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Iccefb337f06da662cab5e4abdee4cdb683ae1e07
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371414
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iccefb337f06da662cab5e4abdee4cdb683ae1e07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TrustedXFF
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] purtle[master]: Add JSON-LD support.

[C. Scott Ananian (Code Review)]

C. Scott Ananian has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371446 )

Change subject: Add JSON-LD support.
..

Add JSON-LD support.

Change-Id: I77d6a771abfef5b00b1b151c48aa950be30896cf
---
M README.md
M composer.json
A src/JsonLdRdfWriter.php
M src/RdfWriterFactory.php
A tests/data/EricMiller.json
A tests/data/LabeledBlankNode.json
A tests/data/NumberedBlankNode.json
A tests/data/Numbers.json
A tests/data/Predicates.json
A tests/data/Resources.json
A tests/data/TextWithSpecialChars.json
A tests/data/Texts.json
A tests/data/Triples.json
A tests/data/Values.json
A tests/phpunit/JsonLdRdfWriterTest.php
M tests/phpunit/NTriplesRdfWriterTest.php
M tests/phpunit/RdfWriterFactoryTest.php
M tests/phpunit/RdfWriterTestBase.php
M tests/phpunit/TurtleRdfWriterTest.php
M tests/phpunit/XmlRdfWriterTest.php
20 files changed, 583 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/purtle refs/changes/46/371446/1

diff --git a/README.md b/README.md
index 95321b5..1d4e39c 100644
--- a/README.md
+++ b/README.md
@@ -1,14 +1,15 @@
 # Purtle
 
 **Purtle** is a fast, lightweight RDF generator. It provides a "fluent" 
interface for
-generating RDF output in Turtle, XML/RDF or N-Triples. The fluent interface 
allows the
+generating RDF output in Turtle, JSON-LD, XML/RDF or N-Triples. The fluent 
interface allows the
 resulting PHP code to be structured just like Turtle notation for RDF, hence 
the name: "Purtle"
 is a contraction of "PHP Turtle".
 
-The three concrete classes implementing the common `RdfWriter` interface are:
+The four concrete classes implementing the common `RdfWriter` interface are:
 * `TurtleRdfWriter` outputs Turtle
 * `XmlRdfWriter` outputs XML/RDF
 * `NTriplesRdfWriter` outputs N-Triples
+* `JsonLdRdfWriter` outputs JSON-LD
 
 The PHP code would look something like this:
 
diff --git a/composer.json b/composer.json
index 1243c49..1c8f823 100644
--- a/composer.json
+++ b/composer.json
@@ -5,7 +5,8 @@
"keywords": [
"RDF",
"Serializer",
-   "Turtle"
+   "Turtle",
+   "JSON-LD"
],
"homepage": "https://mediawiki.org/wiki/Purtle;,
"license": "GPL-2.0+",
@@ -18,6 +19,9 @@
},
{
"name": "Thiemo Mättig"
+   },
+   {
+   "name": "C. Scott Ananian"
}
],
"support": {
diff --git a/src/JsonLdRdfWriter.php b/src/JsonLdRdfWriter.php
new file mode 100644
index 000..184b826
--- /dev/null
+++ b/src/JsonLdRdfWriter.php
@@ -0,0 +1,262 @@
+transitionTable[self::STATE_START][self::STATE_DOCUMENT] 
= function () {
+   $this->beginJson();
+   };
+   
$this->transitionTable[self::STATE_DOCUMENT][self::STATE_FINISH] = function () {
+   $this->finishJson();
+   };
+   
$this->transitionTable[self::STATE_OBJECT][self::STATE_PREDICATE] = function () 
{
+   $this->finishPredicate();
+   };
+   $this->transitionTable[self::STATE_OBJECT][self::STATE_SUBJECT] 
= function () {
+   $this->finishPredicate();
+   $this->finishSubject();
+   };
+   
$this->transitionTable[self::STATE_OBJECT][self::STATE_DOCUMENT] = function () {
+   $this->finishPredicate();
+   $this->finishSubject();
+   $this->finishDocument();
+   };
+   }
+
+   private function isTopLevel() {
+   return $this->role === self::DOCUMENT_ROLE;
+   }
+
+   private function contextify( $base, $local = null ) {
+   $this->expandShorthand( $base, $local );
+
+   if ( $base === 'rdf' && $local === 'type' ) {
+   return '@type';
+   } elseif ( $local === null ) {
+   return $base;
+   } else {
+   if ( $base !== '_' && $this->isPrefix( $base ) ) {
+   $prefixes = $this->getPrefixes();
+   if ( $base === '' ) {
+   // Empty prefix not supported; use full 
IRI
+   return $prefixes[ $base ] . $local;
+   }
+   $this->context[ $base ] = $prefixes[ $base ];
+   }
+   return $base . ':' . $local;
+   }
+   }
+
+   /**
+* Write document header
+*/
+   private function beginJson() {
+   if ( $this->isTopLevel() ) {
+   $this->write( "{\n" );
+   $this->write( function () {
+   // If this buffer is drained 

[MediaWiki-commits] [Gerrit] mediawiki...ShortUrl[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371393 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I806832d80c623851d522dc1ae982b7aee4da6ff3
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371393
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I806832d80c623851d522dc1ae982b7aee4da6ff3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ShortUrl
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...UnicodeConverter[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371418 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Id2e338c14a6061de716cded00d205510a84a652e
---
M UnicodeConverter_body.php
M composer.json
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/UnicodeConverter_body.php b/UnicodeConverter_body.php
index f9c2c57..c90b586 100644
--- a/UnicodeConverter_body.php
+++ b/UnicodeConverter_body.php
@@ -73,7 +73,7 @@
$z >>= $length;
 
// Add in the free bits from subsequent bytes
-   for ( $i=1; $i<$length; $i++ ) {
+   for ( $i = 1; $i < $length; $i++ ) {
$z <<= 6;
$z |= ord( $char{$i} ) & 0x3f;
}
diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371418
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2e338c14a6061de716cded00d205510a84a652e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UnicodeConverter
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TranslationNotifications[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371413 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I8fc924e01744afd3d0b40bdfb6b1e4519382e678
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index b8c8516..92e8b80 100644
--- a/composer.json
+++ b/composer.json
@@ -10,7 +10,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371413
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8fc924e01744afd3d0b40bdfb6b1e4519382e678
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TranslationNotifications
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TorBlock[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371412 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I152022dfb1ca6e97e44f5f976a2f92fb7761ee31
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371412
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I152022dfb1ca6e97e44f5f976a2f92fb7761ee31
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TorBlock
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Score[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371388 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ida33f9ca648d51d3b6e9dc330a5f547c600716e2
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371388
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida33f9ca648d51d3b6e9dc330a5f547c600716e2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Score
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371416 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I63371bb431ced7f6ea27d4523a3880266107cc63
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 55fa447..d59673a 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371416
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63371bb431ced7f6ea27d4523a3880266107cc63
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TwoColConflict
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ThrottleOverride[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371407 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Iaf6154652c01c4ecb3f195717af255ac19801139
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 9ad8dd9..fd4ee70 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371407
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf6154652c01c4ecb3f195717af255ac19801139
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ThrottleOverride
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TestLanguageNameGrammar[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371404 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ie0aea61fd896def35629d462b7bec5f9e99f0932
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 8496754..b8893ba 100644
--- a/composer.json
+++ b/composer.json
@@ -20,7 +20,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371404
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0aea61fd896def35629d462b7bec5f9e99f0932
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TestLanguageNameGrammar
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SmiteSpam[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371396 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I5e14829994100fd74c5a65a7e328148731af43f4
---
M composer.json
M includes/SmiteSpamAnalyzer.php
M includes/checkers/SmiteSpamExternalLinksChecker.php
3 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index d42bf58..219b4d4 100644
--- a/composer.json
+++ b/composer.json
@@ -9,7 +9,7 @@
"license": "GPL-2.0",
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/SmiteSpamAnalyzer.php b/includes/SmiteSpamAnalyzer.php
index de07335..5c12717 100644
--- a/includes/SmiteSpamAnalyzer.php
+++ b/includes/SmiteSpamAnalyzer.php
@@ -106,7 +106,7 @@
}
}
 
-   $page->spamProbability = $value/$checkersUsed;
+   $page->spamProbability = $value / $checkersUsed;
if ( $page->spamProbability >= 
$this->config['threshold'] ) {
$spamPages[] = $page;
}
diff --git a/includes/checkers/SmiteSpamExternalLinksChecker.php 
b/includes/checkers/SmiteSpamExternalLinksChecker.php
index 8eb7ee6..17fab1a 100644
--- a/includes/checkers/SmiteSpamExternalLinksChecker.php
+++ b/includes/checkers/SmiteSpamExternalLinksChecker.php
@@ -15,7 +15,7 @@
if ( $numWords == 0 ) {
return false;
}
-   $ratio = $numLinks/$numWords;
+   $ratio = $numLinks / $numWords;
 
if ( $ratio < 0.02 ) {
return 0;
@@ -24,7 +24,7 @@
} elseif ( $ratio < 0.04 ) {
return 0.5 + 0.5 * ( $ratio * 100 - 3 );
} elseif ( $ratio < 0.1 ) {
-   return 1 + 2 * ( $ratio * 100 - 4 )/6;
+   return 1 + 2 * ( $ratio * 100 - 4 ) / 6;
} else {
return 3;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/371396
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e14829994100fd74c5a65a7e328148731af43f4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SmiteSpam
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SecurePoll[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371391 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ie69def65186446d7dd8d456375731630664afac2
---
M cli/purgePrivateVoteData.php
M composer.json
M includes/ballots/PreferentialBallot.php
M includes/pages/VoterEligibilityPage.php
M includes/talliers/PluralityTallier.php
M includes/talliers/Tallier.php
M includes/user/Voter.php
7 files changed, 10 insertions(+), 10 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/cli/purgePrivateVoteData.php b/cli/purgePrivateVoteData.php
index 96d5432..1db436c 100644
--- a/cli/purgePrivateVoteData.php
+++ b/cli/purgePrivateVoteData.php
@@ -103,7 +103,7 @@
$dbw = wfGetDB( DB_MASTER );
 
foreach ( $deleteSets as $deleteSet ) {
-   list ( $minId, $maxId ) = $deleteSet;
+   list( $minId, $maxId ) = $deleteSet;
$dbw->update(
'securepoll_votes',
[ 'vote_ip' => '', 'vote_xff' => '', 
'vote_ua' => '' ],
diff --git a/composer.json b/composer.json
index fd295f4..96a1043 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",
diff --git a/includes/ballots/PreferentialBallot.php 
b/includes/ballots/PreferentialBallot.php
index 2c62b08..7222b0b 100644
--- a/includes/ballots/PreferentialBallot.php
+++ b/includes/ballots/PreferentialBallot.php
@@ -100,7 +100,7 @@
 
function unpackRecord( $record ) {
$ranks = [];
-   $itemLength = 3*8 + 7;
+   $itemLength = 3 * 8 + 7;
for ( $offset = 0, $len = strlen( $record ); $offset < $len; 
$offset += $itemLength ) {
if ( !preg_match( 
'/Q([0-9A-F]{8})-A([0-9A-F]{8})-R([0-9A-F]{8})--/A',
$record, $m, 0, $offset )
diff --git a/includes/pages/VoterEligibilityPage.php 
b/includes/pages/VoterEligibilityPage.php
index 322552e..3b6c0e7 100644
--- a/includes/pages/VoterEligibilityPage.php
+++ b/includes/pages/VoterEligibilityPage.php
@@ -227,7 +227,7 @@
if ( $i === false ) {
$wiki = '*';
} else {
-   $wiki = trim( substr( $name, $i+1 ) );
+   $wiki = trim( substr( $name, $i + 1 ) );
$name = trim( substr( $name, 0, $i ) );
}
if ( $wiki !== '' && $name !== '' ) {
diff --git a/includes/talliers/PluralityTallier.php 
b/includes/talliers/PluralityTallier.php
index 131ed88..e90bfe6 100644
--- a/includes/talliers/PluralityTallier.php
+++ b/includes/talliers/PluralityTallier.php
@@ -85,7 +85,7 @@
$oids = array_keys( $this->tally );
$scores = array_values( $this->tally );
foreach ( $oids as $i => $oid ) {
-   if ( $i > 0 && $scores[$i-1] !== $scores[$i] ) {
+   if ( $i > 0 && $scores[$i - 1] !== $scores[$i] ) {
$currentRank = $i + 1;
}
$ranks[$oid] = $currentRank;
diff --git a/includes/talliers/Tallier.php b/includes/talliers/Tallier.php
index 4503597..e046896 100644
--- a/includes/talliers/Tallier.php
+++ b/includes/talliers/Tallier.php
@@ -80,8 +80,8 @@
$ids = array_keys( $ranks );
foreach ( $ids as $i => $oid ) {
$rank = $ranks[$oid];
-   $prevRank = isset( $ids[$i-1] ) ? $ranks[$ids[$i-1]] : 
false;
-   $nextRank = isset( $ids[$i+1] ) ? $ranks[$ids[$i+1]] : 
false;
+   $prevRank = isset( $ids[$i - 1] ) ? $ranks[$ids[$i - 
1]] : false;
+   $nextRank = isset( $ids[$i + 1] ) ? $ranks[$ids[$i + 
1]] : false;
if ( $rank === $prevRank || $rank === $nextRank ) {
$rank .= '*';
}
@@ -112,8 +112,8 @@
 
foreach ( $ids as $i => $oid ) {
$rank = $ranks[$oid];
-   $prevRank = isset( $ids[$i-1] ) ? $ranks[$ids[$i-1]] : 
false;
-   $nextRank = isset( $ids[$i+1] ) ? $ranks[$ids[$i+1]] : 
false;
+   $prevRank = 

[MediaWiki-commits] [Gerrit] mediawiki...UnCaptcha[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371417 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I250cece3d350acbc5ae06551326f47457f1ca2da
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index a331a20..3c4a3d4 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371417
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I250cece3d350acbc5ae06551326f47457f1ca2da
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UnCaptcha
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TwnMainPage[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371415 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I59544b8e0aeacdf65c6839babda4a751a5b3dfdb
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 55fa447..d59673a 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371415
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I59544b8e0aeacdf65c6839babda4a751a5b3dfdb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TwnMainPage
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371389 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected
* MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.MissingReturn
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.Commenting.FunctionComment.WrongStyle

The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment
* MediaWiki.Usage.ReferenceThis.Found

Change-Id: I1074884ab6810dd082b1baebb25d02b997424818
---
M common/Common.php
M composer.json
M engines/LuaCommon/LuaCommon.php
M engines/LuaCommon/SiteLibrary.php
M engines/LuaCommon/UstringLibrary.php
M phpcs.xml
6 files changed, 16 insertions(+), 10 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/common/Common.php b/common/Common.php
index c6f089e..5a2a6dc 100644
--- a/common/Common.php
+++ b/common/Common.php
@@ -85,7 +85,7 @@
 *
 * @param Title $title
 * @param Title &$forModule Module for which this is a doc page
-* @return boolean
+* @return bool
 */
public static function isDocPage( Title $title, Title &$forModule = 
null ) {
$docPage = wfMessage( 'scribunto-doc-page-name' 
)->inContentLanguage();
diff --git a/composer.json b/composer.json
index 3550b4b..88f5db9 100644
--- a/composer.json
+++ b/composer.json
@@ -19,7 +19,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/engines/LuaCommon/LuaCommon.php b/engines/LuaCommon/LuaCommon.php
index 56605bb..33f8b37 100644
--- a/engines/LuaCommon/LuaCommon.php
+++ b/engines/LuaCommon/LuaCommon.php
@@ -310,7 +310,7 @@
/**
 * Format the logged data for HTML output
 * @param string $logs Logged data
-* @param boolean $localize Whether to localize the message key
+* @param bool $localize Whether to localize the message key
 * @return string HTML
 */
protected function formatHtmlLogs( $logs, $localize ) {
diff --git a/engines/LuaCommon/SiteLibrary.php 
b/engines/LuaCommon/SiteLibrary.php
index 9941aa5..68e8bae 100644
--- a/engines/LuaCommon/SiteLibrary.php
+++ b/engines/LuaCommon/SiteLibrary.php
@@ -65,7 +65,7 @@
foreach ( $aliases as $title => $ns ) {
if ( !isset( $namespacesByName[$title] ) && 
isset( $namespaces[$ns] ) ) {
$ct = count( 
$namespaces[$ns]['aliases'] );
-   $namespaces[$ns]['aliases'][$ct+1] = 
$title;
+   $namespaces[$ns]['aliases'][$ct + 1] = 
$title;
$namespacesByName[$title] = $ns;
}
}
diff --git a/engines/LuaCommon/UstringLibrary.php 
b/engines/LuaCommon/UstringLibrary.php
index ee3a431..d651672 100644
--- a/engines/LuaCommon/UstringLibrary.php
+++ b/engines/LuaCommon/UstringLibrary.php
@@ -210,9 +210,9 @@
if ( count( $args ) > $this->stringLengthLimit ) {
throw new Scribunto_LuaError( "too many arguments to 
'$name'" );
}
-   foreach ( $args as $k=>&$v ) {
+   foreach ( $args as $k => &$v ) {
if ( !is_numeric( $v ) ) {
-   $this->checkType( 'char', $k+1, $v, 'number' );
+   $this->checkType( 'char', $k + 1, $v, 'number' 
);
}
$v = (int)floor( $v );
if ( $v < 0 || $v > 0x10 ) {
@@ -492,8 +492,8 @@
} elseif ( $i + 2 < $len &&
$pat[$i + 1] === '-' && $pat[$i + 2] !== ']' && 
$pat[$i + 2] !== '%'
) {
-   if ( $pat[$i] <= $pat[$i+2] ) {
-   $re .= preg_quote( $pat[$i], '/' ) . 
'-' . preg_quote( $pat[$i+2], '/' );
+   if ( $pat[$i] <= $pat[$i + 2] ) {
+   $re .= preg_quote( $pat[$i], '/' ) . 
'-' . preg_quote( $pat[$i + 2], '/' );

[MediaWiki-commits] [Gerrit] mediawiki...StopForumSpam[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371397 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment

Change-Id: I5fddeb6f81d97d37927e4493adbad41ea0babea2
---
M composer.json
M phpcs.xml
2 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index c76fa27..d7b8d90 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.7.2"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"test": [
diff --git a/phpcs.xml b/phpcs.xml
index b859699..545dc16 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,6 +1,12 @@
 
 
-   
+   
+   
+   
+   
+   
+   
+   
.



-- 
To view, visit https://gerrit.wikimedia.org/r/371397
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5fddeb6f81d97d37927e4493adbad41ea0babea2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/StopForumSpam
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SubPageList3[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371398 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I177ca40d64efcd06105c4b0ebb8789dacc13b716
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371398
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I177ca40d64efcd06105c4b0ebb8789dacc13b716
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SubPageList3
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] purtle[master]: Minor bug fixes in test suite.

[C. Scott Ananian (Code Review)]

C. Scott Ananian has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371445 )

Change subject: Minor bug fixes in test suite.
..

Minor bug fixes in test suite.

Change-Id: I05e4b25c775357414c519374574486a9977d59da
---
M tests/data/TextWithSpecialChars.rdf
M tests/phpunit/RdfWriterTestBase.php
2 files changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/purtle refs/changes/45/371445/1

diff --git a/tests/data/TextWithSpecialChars.rdf 
b/tests/data/TextWithSpecialChars.rdf
index 7952698..b8d7364 100644
--- a/tests/data/TextWithSpecialChars.rdf
+++ b/tests/data/TextWithSpecialChars.rdf
@@ -10,3 +10,4 @@
http://www.example.org/terms/Bear;>
Bear says: Превед!

+
diff --git a/tests/phpunit/RdfWriterTestBase.php 
b/tests/phpunit/RdfWriterTestBase.php
index 7f7c527..39aaa61 100644
--- a/tests/phpunit/RdfWriterTestBase.php
+++ b/tests/phpunit/RdfWriterTestBase.php
@@ -243,7 +243,7 @@
}
 
public function testEricMiller() {
-   // exampel taken from http://www.w3.org/2007/02/turtle/primer/
+   // example taken from http://www.w3.org/2007/02/turtle/primer/
 
$writer = $this->newWriter();
 
@@ -262,7 +262,7 @@
}
 
public function testLabeledBlankNode() {
-   // exampel taken from http://www.w3.org/2007/02/turtle/primer/
+   // example taken from http://www.w3.org/2007/02/turtle/primer/
 
$writer = $this->newWriter();
 
@@ -284,7 +284,7 @@
}
 
public function testNumberedBlankNodes() {
-   // exampel taken from http://www.w3.org/2007/02/turtle/primer/
+   // example taken from http://www.w3.org/2007/02/turtle/primer/
 
$writer = $this->newWriter();
 
@@ -319,6 +319,7 @@
->text( "Cow says:\n\r 'Moo! \\Moo!'" );
$writer->about( 'exterms', 'Bear' )->say( 'exterms', 'says' )
->text( 'Bear says: Превед!' );
+   $writer->finish();
 
$rdf = $writer->drain();
$this->assertOutputLines( 'TextWithSpecialChars', $rdf );

-- 
To view, visit https://gerrit.wikimedia.org/r/371445
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05e4b25c775357414c519374574486a9977d59da
Gerrit-PatchSet: 1
Gerrit-Project: purtle
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371386 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I3ab19cdd1e7f43404af62985f38c0a78ac997efd
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 9f6680d..f0045b5 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371386
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ab19cdd1e7f43404af62985f38c0a78ac997efd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMaintenance[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371432 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ib1e48b319d170c95f75ff719d4c16584780f8857
---
M cleanupBug41615.php
M composer.json
M createHumanReadableProjectNameFiles.php
3 files changed, 6 insertions(+), 7 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/cleanupBug41615.php b/cleanupBug41615.php
index f6df60c..2d5bcac 100644
--- a/cleanupBug41615.php
+++ b/cleanupBug41615.php
@@ -34,7 +34,7 @@
$binraw = trim( file_get_contents( $this->getOption( 
'binlogdump' ) ) );
for ( $i = 0; $i < strlen( $binraw ); ++$i ) {
$ch = $binraw[$i];
-   if ( $ch === "'" && ( $i <= 0 || $binraw[$i -1] !== 
"\\" ) ) {
+   if ( $ch === "'" && ( $i <= 0 || $binraw[$i - 1] !== 
"\\" ) ) {
$inQuote = !$inQuote; // unescaped quote
}
if ( $ch === "\n" && !$inQuote ) {
diff --git a/composer.json b/composer.json
index f677d3a..d355432 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"lint": "parallel-lint --exclude vendor --exclude node_modules 
--ignore-fails .",
@@ -18,4 +18,3 @@
"prepend-autoloader": false
}
 }
-
diff --git a/createHumanReadableProjectNameFiles.php 
b/createHumanReadableProjectNameFiles.php
index 34f69a2..ae7f378 100644
--- a/createHumanReadableProjectNameFiles.php
+++ b/createHumanReadableProjectNameFiles.php
@@ -163,8 +163,8 @@
}
 
// Output the line
-   $outEn[ "project-localized-name-" . $dbname ] = 
 $name;
-   $outQqq[ "project-localized-name-" . $dbname ] 
=  $this->createQQQ( $name, $url );
+   $outEn[ "project-localized-name-" . $dbname ] = 
$name;
+   $outQqq[ "project-localized-name-" . $dbname ] 
= $this->createQQQ( $name, $url );
$table[$dbname] = [ 'name' => $name, 'url' => 
$url ];
 
$counter++;
@@ -186,8 +186,8 @@
}
 
// Output the line
-   $outEn[ "project-localized-name-" . $dbname ] =  
$sitename;
-   $outQqq[ "project-localized-name-" . $dbname ] =  
$this->createQQQ( $sitename, $url );
+   $outEn[ "project-localized-name-" . $dbname ] = 
$sitename;
+   $outQqq[ "project-localized-name-" . $dbname ] = 
$this->createQQQ( $sitename, $url );
$table[$dbname] = [ 'name' => $sitename, 'url' => $url 
];
 
$counter++;

-- 
To view, visit https://gerrit.wikimedia.org/r/371432
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1e48b319d170c95f75ff719d4c16584780f8857
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMaintenance
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikidataPageBanner[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371429 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I80922b66ffb756fb34ecdfbf6fc9f6292f67ea0d
---
M composer.json
M includes/WikidataPageBanner.functions.php
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 1d0d678..2ea7f35 100644
--- a/composer.json
+++ b/composer.json
@@ -12,7 +12,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/WikidataPageBanner.functions.php 
b/includes/WikidataPageBanner.functions.php
index 9413179..af686f5 100755
--- a/includes/WikidataPageBanner.functions.php
+++ b/includes/WikidataPageBanner.functions.php
@@ -58,7 +58,7 @@
$iconTitleText = $iconUrl->getText();
}
$finalIcon['icon'] = $iconName;
-   $finalIcon['title'] =  $iconTitleText;
+   $finalIcon['title'] = $iconTitleText;
$iconsToAdd[] = $finalIcon;
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/371429
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80922b66ffb756fb34ecdfbf6fc9f6292f67ea0d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaIncubator[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371431 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I03916f693d934429bf7451c2ddd31bd010e9494f
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I03916f693d934429bf7451c2ddd31bd010e9494f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaIncubator
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageImages[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371363 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I121ac2e4b2bc165ca6aaa8a7b6f8f973faaf0f9d
---
M composer.json
M tests/phpunit/LinksUpdateHookHandlerTest.php
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",
diff --git a/tests/phpunit/LinksUpdateHookHandlerTest.php 
b/tests/phpunit/LinksUpdateHookHandlerTest.php
index 3d8247a..8397750 100644
--- a/tests/phpunit/LinksUpdateHookHandlerTest.php
+++ b/tests/phpunit/LinksUpdateHookHandlerTest.php
@@ -280,7 +280,7 @@
50,
3,
// blacklist score
-   -1000
+   - 1000
],
];
}

-- 
To view, visit https://gerrit.wikimedia.org/r/371363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I121ac2e4b2bc165ca6aaa8a7b6f8f973faaf0f9d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageImages
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageAssessments[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371362 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ie508bd6a707fa7a9f51c7952ab037afd569033c3
---
M api/ApiQueryPageAssessments.php
M composer.json
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/api/ApiQueryPageAssessments.php b/api/ApiQueryPageAssessments.php
index a61452c..0b0f912 100644
--- a/api/ApiQueryPageAssessments.php
+++ b/api/ApiQueryPageAssessments.php
@@ -34,7 +34,7 @@
 
$projectValues = [
'class' => $row->class,
-   'importance'=> $row->importance,
+   'importance' => $row->importance,
];
 
$projectName = $row->project_name;
diff --git a/composer.json b/composer.json
index f175d8d..80be361 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,7 @@
"description": "This extension adds a parser function which can be used 
for storing article assessments in a database table.",
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.*",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371362
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie508bd6a707fa7a9f51c7952ab037afd569033c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageAssessments
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PagePopups[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371364 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Idc668411c0528b125f3ab8a48261f9b956cbcc14
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index d368985..a4c40a7 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371364
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc668411c0528b125f3ab8a48261f9b956cbcc14
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PagePopups
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...OpenStackManager[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371361 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.ExtraParamComment
* MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected
* MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.MissingReturn
* MediaWiki.Commenting.FunctionComment.MissingReturnType
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.Commenting.FunctionComment.WrongStyle

The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment

Change-Id: Id02948f1792ba89982fee6af7721e25aa1163a21
---
M composer.json
M nova/OpenStackNovaController.php
M nova/OpenStackNovaSudoer.php
M phpcs.xml
M special/SpecialNovaProxy.php
M special/SpecialNovaServiceGroup.php
6 files changed, 19 insertions(+), 10 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index ea7fb13..279f59a 100644
--- a/composer.json
+++ b/composer.json
@@ -5,7 +5,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",
diff --git a/nova/OpenStackNovaController.php b/nova/OpenStackNovaController.php
index f81e007..0e7aebe 100644
--- a/nova/OpenStackNovaController.php
+++ b/nova/OpenStackNovaController.php
@@ -944,7 +944,7 @@
 * Delete a Nova volume
 *
 * @param  $volumeid
-* @return boolean
+* @return bool
 */
function deleteVolume( $volumeid ) {
# unimplemented
@@ -957,7 +957,7 @@
 * @param volumeid
 * @param instanceid
 * @param device
-* @return boolean
+* @return bool
 */
function attachVolume( $volumeid, $instanceid, $device ) {
# unimplemented
@@ -969,7 +969,7 @@
 *
 * @param volumeid
 * @param force
-* @return boolean
+* @return bool
 */
function detachVolume( $volumeid, $force ) {
# unimplemented
@@ -981,7 +981,7 @@
 *
 * @param type
 * @param string $type
-* @return boolean
+* @return bool
 */
function rebootInstance( $instanceid, $type='SOFT' ) {
$instanceid = urlencode( $instanceid );
diff --git a/nova/OpenStackNovaSudoer.php b/nova/OpenStackNovaSudoer.php
index 08a4b7f..812481e 100644
--- a/nova/OpenStackNovaSudoer.php
+++ b/nova/OpenStackNovaSudoer.php
@@ -133,7 +133,7 @@
 * @param  $users
 * @param  $commands
 * @param  $options
-* @return boolean
+* @return bool
 */
function modifySudoer( $users, $runasuser, $commands, $options ) {
global $wgMemc;
diff --git a/phpcs.xml b/phpcs.xml
index 6ff27fb..17713f8 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,10 +1,19 @@
 
 

+   
+   
+   
+   
+   
+   
+   
+   
+   
+   



-   

.

diff --git a/special/SpecialNovaProxy.php b/special/SpecialNovaProxy.php
index d150f8d..47c58b3 100644
--- a/special/SpecialNovaProxy.php
+++ b/special/SpecialNovaProxy.php
@@ -357,7 +357,7 @@
$this->msg( 'openstackmanager-backproxylist' 
)->escaped()
);
 
-   $success =  $this->userNova->deleteProxy( $fqdn );
+   $success = $this->userNova->deleteProxy( $fqdn );
if ( $success ) {
$success = $this->deleteHost( $fqdn, 
$wgOpenStackManagerProxyGateways[$region] );
if ( !$success ) {
@@ -416,7 +416,7 @@
}
 
# DNS looks good, now we can set up the proxy.
-   $newProxy =  $this->userNova->createProxy( $fqdn, $backendHost, 
$backendPort );
+   $newProxy = $this->userNova->createProxy( $fqdn, $backendHost, 
$backendPort );
 
if ( $newProxy ) {
$outputPage->addWikiMsg(
diff --git a/special/SpecialNovaServiceGroup.php 
b/special/SpecialNovaServiceGroup.php
index fcafc0f..5b2dd67 100644
--- 

[MediaWiki-commits] [Gerrit] mediawiki...OpenLayers[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371360 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I2b9033b7dd500aa024d0ce45b429b86704c3b401
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index fe7ea64..4179d3c 100644
--- a/composer.json
+++ b/composer.json
@@ -20,7 +20,7 @@
],
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371360
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b9033b7dd500aa024d0ce45b429b86704c3b401
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenLayers
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PoolCounter[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371375 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I7758516f3a290eee4effa45e81be1b50191b9a42
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371375
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7758516f3a290eee4effa45e81be1b50191b9a42
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PoolCounter
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371420 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I8444d8a0ad772ac6c05148311a023ca4cedcc6c2
---
M UploadWizard.config.php
M composer.json
M includes/CampaignSchema.php
M includes/UploadWizardConfig.php
4 files changed, 16 insertions(+), 16 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/UploadWizard.config.php b/UploadWizard.config.php
index 09cda85..5199a4c 100644
--- a/UploadWizard.config.php
+++ b/UploadWizard.config.php
@@ -574,7 +574,7 @@
// exceptions used at Wikimedia Commons: the language template for 
Tagalog (ISO 646 code 'tl') is not named 'tl'
// but 'tgl' for historical reasons.
// @codingStandardsIgnoreEnd
-   'languageTemplateFixups' =>  $uwDefaultLanguageFixups,
+   'languageTemplateFixups' => $uwDefaultLanguageFixups,
 
// @codingStandardsIgnoreStart
// XXX this is horribly confusing -- some file restrictions are 
client side, others are server side
diff --git a/composer.json b/composer.json
index 55507be..d1e3215 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/CampaignSchema.php b/includes/CampaignSchema.php
index 47182f9..2618be9 100644
--- a/includes/CampaignSchema.php
+++ b/includes/CampaignSchema.php
@@ -71,7 +71,7 @@
],
"defaults" => [
"type" => "object",
-   "properties" =>[
+   "properties" => [
"alt" => [
"type" => "number"
],
@@ -96,7 +96,7 @@
],
"display" => [
"type" => "object",
-   "properties" =>[
+   "properties" => [
"headerLabel" => [
"type" => "string"
],
@@ -138,7 +138,7 @@
],
"licensing" => [
"type" => "object",
-   "properties" =>[
+   "properties" => [
"defaultType" => [
"type" => "string"
],
@@ -147,14 +147,14 @@
],
"ownWork" => [
"type" => "object",
-   "properties" =>[
+   "properties" => [
"default" => [
"type" => "string",
"enum" => array_keys( 
UploadWizardConfig::getSetting( 'licenses' ) )
],
"licenses" => [
"type" => "array",
-   "items" =>[
+   "items" => [
[
"type" 
=> "string",
"enum" 
=> array_keys( UploadWizardConfig::getSetting( 'licenses' ) )
@@ -172,23 +172,23 @@
],
"thirdParty" => [
"type" => "object",
-   "properties" =>[
+   "properties" => [
"defaults" => [
"type" => "string",
"enum" => array_keys( 
UploadWizardConfig::getSetting( 'licenses' ) )
],
"licenseGroups" => [
"type" => "array",
-   "items" =>[
+   "items" => [
   

[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371419 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I802d9f809a3115dbeb0420e7c6f6f1167d7cc27d
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index b27e988..3fc97e9 100644
--- a/composer.json
+++ b/composer.json
@@ -26,7 +26,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371419
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I802d9f809a3115dbeb0420e7c6f6f1167d7cc27d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TocTree[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371410 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I5cc6982077df66fe517182795e51c86441f2c422
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5cc6982077df66fe517182795e51c86441f2c422
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TocTree
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...OOJsUIAjaxLogin[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371357 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I0d4cd90fcad6c2daf85507c03ddac9f0a992aca6
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 55507be..d1e3215 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371357
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d4cd90fcad6c2daf85507c03ddac9f0a992aca6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OOJsUIAjaxLogin
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...OAuth[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371355 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I5c4516eb2f34e235bb62b101b2df1324c3cae404
---
M composer.json
M frontend/specialpages/SpecialMWOAuthManageConsumers.php
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 1a6879a..b3eb5e3 100644
--- a/composer.json
+++ b/composer.json
@@ -10,7 +10,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/frontend/specialpages/SpecialMWOAuthManageConsumers.php 
b/frontend/specialpages/SpecialMWOAuthManageConsumers.php
index c7507e2..3ebd911 100755
--- a/frontend/specialpages/SpecialMWOAuthManageConsumers.php
+++ b/frontend/specialpages/SpecialMWOAuthManageConsumers.php
@@ -276,7 +276,7 @@

'mwoauth-consumer-callbackisprefix' => $ownerOnly ?
null : ( $cmr->get( 
'callbackIsPrefix' ) ?
$this->msg( 
'htmlform-yes' ) : $this->msg( 'htmlform-no' ) ),
-   'mwoauth-consumer-grantsneeded' 
=>  $cmr->get( 'grants',
+   'mwoauth-consumer-grantsneeded' 
=> $cmr->get( 'grants',
function ( $grants ) 
use ( $lang ) {
return 
$lang->semicolonList( \MWGrants::grantNames( $grants, $lang ) );
} ),

-- 
To view, visit https://gerrit.wikimedia.org/r/371355
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5c4516eb2f34e235bb62b101b2df1324c3cae404
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...OAuthAuthentication[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371356 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ife3394303d9ddba61ae18baef05871533273ffb3
---
M composer.json
M utils/Hooks.php
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 3c8225d..05b8a51 100644
--- a/composer.json
+++ b/composer.json
@@ -24,7 +24,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"test": [
diff --git a/utils/Hooks.php b/utils/Hooks.php
index 8c4d8d6..51cfb1b 100644
--- a/utils/Hooks.php
+++ b/utils/Hooks.php
@@ -13,8 +13,8 @@
if ( $wgUser->getID() == 0 ) {
$query = [];
if ( $title->isSpecial( 'Userlogout' ) ) {
-   $query['returnto'] =  $wgRequest->getVal( 
'returnto', 'Main_Page' );
-   $query['returntoquery'] =  $wgRequest->getVal( 
'returntoquery' );
+   $query['returnto'] = $wgRequest->getVal( 
'returnto', 'Main_Page' );
+   $query['returntoquery'] = $wgRequest->getVal( 
'returntoquery' );
} else {
$query['returnto'] = $title->getPrefixedText();
$returntoquery = $wgRequest->getValues();

-- 
To view, visit https://gerrit.wikimedia.org/r/371356
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife3394303d9ddba61ae18baef05871533273ffb3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuthAuthentication
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371358 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ic9a96ee431a9de6d23874a8da22f521ee6c6e107
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 9800bda..5aa1cb9 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371358
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9a96ee431a9de6d23874a8da22f521ee6c6e107
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Awight 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/software[master]: Set OOM_adj to -500 for mariadb- WMF package is normally ded...

[Jcrespo (Code Review)]

Jcrespo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371448 )

Change subject: Set OOM_adj to -500 for mariadb- WMF package is normally 
dedicated
..

Set OOM_adj to -500 for mariadb- WMF package is normally dedicated

Because how much memory mariadb can consume, this will probably
have little effect overally. We should reduce the priority
(increase the OOM value) of other services such as prometheus, and
other auxiliary, but non-critical services.

Bug: T172494
Change-Id: I113d7aee219f2265ce034a914234e29fc67420a3
---
M dbtools/mariadb.service
M dbtools/mariadb@.service
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/software 
refs/changes/48/371448/1

diff --git a/dbtools/mariadb.service b/dbtools/mariadb.service
index f574de4..a24ffc7 100644
--- a/dbtools/mariadb.service
+++ b/dbtools/mariadb.service
@@ -115,7 +115,7 @@
 
 # Kernels like killing mysqld when out of memory because its big.
 # Lets temper that preference a little.
-# OOMScoreAdjust=-600
+OOMScoreAdjust=-600
 
 # Explicitly start with high IO priority
 # BlockIOWeight=1000
diff --git a/dbtools/mariadb@.service b/dbtools/mariadb@.service
index 5002f04..f3427f6 100644
--- a/dbtools/mariadb@.service
+++ b/dbtools/mariadb@.service
@@ -139,7 +139,7 @@
 
 # Kernels like killing mysqld when out of memory because its big.
 # Lets temper that preference a little.
-# OOMScoreAdjust=-600
+OOMScoreAdjust=-600
 
 # Explicitly start with high IO priority
 # BlockIOWeight=1000

-- 
To view, visit https://gerrit.wikimedia.org/r/371448
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I113d7aee219f2265ce034a914234e29fc67420a3
Gerrit-PatchSet: 1
Gerrit-Project: operations/software
Gerrit-Branch: master
Gerrit-Owner: Jcrespo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ZeroPortal[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371439 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I3ec5b8d22721d5edd4dcdd159fead637678d81ae
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371439
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ec5b8d22721d5edd4dcdd159fead637678d81ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroPortal
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ZeroBanner[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371438 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I92680762b3b67745121376a4c6097d3bed744dd5
---
M composer.json
M includes/PageRendering.php
M includes/ZeroSpecialPage.php
3 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 4c64298..20afe32 100644
--- a/composer.json
+++ b/composer.json
@@ -5,7 +5,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",
diff --git a/includes/PageRendering.php b/includes/PageRendering.php
index a02913f..454929a 100644
--- a/includes/PageRendering.php
+++ b/includes/PageRendering.php
@@ -756,7 +756,7 @@
$info[1] = 'm';
}
$page = ( $flags & self::GET_LANDING )
-   ? self::getSpecial( false )->getPrefixedDBkey(): 
'Main_Page';
+   ? self::getSpecial( false )->getPrefixedDBkey() : 
'Main_Page';
return sprintf( '//%s/wiki/%s', implode( '.', $info ), $page );
}
 
diff --git a/includes/ZeroSpecialPage.php b/includes/ZeroSpecialPage.php
index 2a75bf0..8d194a9 100644
--- a/includes/ZeroSpecialPage.php
+++ b/includes/ZeroSpecialPage.php
@@ -189,9 +189,9 @@
$lang = $skin->getLanguage()->getCode();
$output = Html::htmlHeader( [ 'lang' => $lang, 'dir' => $dir ] 
);
$output .= Html::openElement( 'head' );
-   $output .= Html::element( 'meta', [ 'charset' =>'UTF-8' ] );
+   $output .= Html::element( 'meta', [ 'charset' => 'UTF-8' ] );
$output .= Html::element( 'meta', [ 'name' => 'viewport',
-   'content' =>'width=device-width' ] );
+   'content' => 'width=device-width' ] );
$output .= Html::element( 'title', null, $wgSitename );
// @codingStandardsIgnoreStart
$style = <<<'EOM'

-- 
To view, visit https://gerrit.wikimedia.org/r/371438
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92680762b3b67745121376a4c6097d3bed744dd5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroBanner
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SyntaxHighlight_GeSHi[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371400 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I9df860b01a9e99174e4f0f6fe65670dffa548988
---
M SyntaxHighlight.GeSHi.compat.php
M composer.json
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SyntaxHighlight.GeSHi.compat.php b/SyntaxHighlight.GeSHi.compat.php
index f960219..a6f3832 100644
--- a/SyntaxHighlight.GeSHi.compat.php
+++ b/SyntaxHighlight.GeSHi.compat.php
@@ -22,8 +22,8 @@
'arm'   => 'asm',
'6502acme'  => 'asm',
'6502tasm'  => 'asm',
-   '6502kickass'=> 'asm',
-   '68000devpac'=> 'asm',
+   '6502kickass' => 'asm',
+   '68000devpac' => 'asm',
'dcpu16'=> 'asm',
'm68k'  => 'asm',
'mmix'  => 'nasm',
diff --git a/composer.json b/composer.json
index c3ad1e1..a846977 100644
--- a/composer.json
+++ b/composer.json
@@ -6,7 +6,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"license": "GPL-2.0+",

-- 
To view, visit https://gerrit.wikimedia.org/r/371400
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9df860b01a9e99174e4f0f6fe65670dffa548988
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SyntaxHighlight_GeSHi
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TemplateSandbox[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371402 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I3d5c2fa07892aff388a87519dd09e0cc14e341cd
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 2e49b8a..91330ec 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/371402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d5c2fa07892aff388a87519dd09e0cc14e341cd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TemplateSandbox
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371376 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: I7b00bf0beb47f54c4543de0d605c80ebdd6cdb4d
---
M composer.json
M includes/PopupsGadgetsIntegration.php
M phpcs.xml
3 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 91c6304..eff2a81 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1",
+   "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/PopupsGadgetsIntegration.php 
b/includes/PopupsGadgetsIntegration.php
index 259931e..3d2b441 100644
--- a/includes/PopupsGadgetsIntegration.php
+++ b/includes/PopupsGadgetsIntegration.php
@@ -49,7 +49,7 @@
 * @param ExtensionRegistry $extensionRegistry MediaWiki extension 
registry
 */
public function __construct( Config $config, ExtensionRegistry 
$extensionRegistry ) {
-   $this->extensionRegistry =  $extensionRegistry;
+   $this->extensionRegistry = $extensionRegistry;
$this->navPopupsGadgetName = $this->sanitizeGadgetName(
$config->get( self::CONFIG_NAVIGATION_POPUPS_NAME ) );
}
diff --git a/phpcs.xml b/phpcs.xml
index 1a3c9e9..3fa604a 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,6 +1,7 @@
 
 
-   
+   
+   
.



-- 
To view, visit https://gerrit.wikimedia.org/r/371376
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b00bf0beb47f54c4543de0d605c80ebdd6cdb4d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RelatedSites[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371383 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.11.0

Change-Id: Ia1759bbe5f38ceba64ac4febd91068b5a839
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index bf202bf..770de83 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "0.10.1"
+   "mediawiki/mediawiki-codesniffer": "0.11.0"
},
"scripts": {
"fix": "phpcbf",

-- 
To view, visit https://gerrit.wikimedia.org/r/371383
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1759bbe5f38ceba64ac4febd91068b5a839
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RelatedSites
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits