[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Allow enabling of tls/ssl (keep default of none for ...

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406145 ) Change subject: Gerrit: Allow enabling of tls/ssl (keep default of none for now) .. Gerrit: Allow enabling of tls/ssl (keep default of none

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Strip everything before the first pf token

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406057 ) Change subject: Strip everything before the first pf token .. Strip everything before the first pf token In this isolate case,

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Remove hardcoding of the smtp port

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406144 ) Change subject: Gerrit: Remove hardcoding of the smtp port .. Gerrit: Remove hardcoding of the smtp port Gerrit uses sane defaults: 25 if not

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Add ldap.connectTimeout

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406143 ) Change subject: Gerrit: Add ldap.connectTimeout .. Gerrit: Add ldap.connectTimeout No timeout is kinda insane. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Mock CommentStore in RevisionTest

2018-01-24 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406142 ) Change subject: Mock CommentStore in RevisionTest .. Mock CommentStore in RevisionTest Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use array_merge in RevisionStore::getArchiveQueryInfo

2018-01-24 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406141 ) Change subject: Use array_merge in RevisionStore::getArchiveQueryInfo .. Use array_merge in RevisionStore::getArchiveQueryInfo [ 'foo' ]

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Set groups.newGroupsVisibleToAll = true

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406140 ) Change subject: Gerrit: Set groups.newGroupsVisibleToAll = true .. Gerrit: Set groups.newGroupsVisibleToAll = true Why shouldn't they be? Can

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Set gc.aggressive = true

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406139 ) Change subject: Gerrit: Set gc.aggressive = true .. Gerrit: Set gc.aggressive = true We're not re-enabling auto-gc just yet, but I want to so

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Set changeCleanup.startTime

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406138 ) Change subject: Gerrit: Set changeCleanup.startTime .. Gerrit: Set changeCleanup.startTime We don't have changeCleanup.abandonChanges set to

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Shut up completely useless WARN-level spam from Even...

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406137 ) Change subject: Gerrit: Shut up completely useless WARN-level spam from EventUtil .. Gerrit: Shut up completely useless WARN-level spam from

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "mariadb: Depool es2011 for reimage"

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406132 ) Change subject: Revert "mariadb: Depool es2011 for reimage" .. Revert "mariadb: Depool es2011 for reimage" This reverts commit

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Reenable notifications on es2011 after reimage

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406135 ) Change subject: mariadb: Reenable notifications on es2011 after reimage .. mariadb: Reenable notifications on es2011 after reimage

[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: Unify SVG markup

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/388833 ) Change subject: Unify SVG markup .. Unify SVG markup Align SVG markup across Foundation products by: - unifying XML

[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[master]: Fix multiple PHP class declarations in one file

2018-01-24 Thread Phantom42 (Code Review)
Phantom42 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406136 ) Change subject: Fix multiple PHP class declarations in one file .. Fix multiple PHP class declarations in one file All files containing

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Reenable notifications on es2011 after reimage

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406135 ) Change subject: mariadb: Reenable notifications on es2011 after reimage .. mariadb: Reenable notifications on es2011 after reimage

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: OptInController catch both errors and exception

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406051 ) Change subject: OptInController catch both errors and exception .. OptInController catch both errors and exception The problem

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "Revert "mariadb: Reimage es2011 into stretch/MariaDB...

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406133 ) Change subject: Revert "Revert "mariadb: Reimage es2011 into stretch/MariaDB 10.1"" .. Revert "Revert "mariadb: Reimage es2011

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "mariadb-partman: Modify recipe, to test with es2011"

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406134 ) Change subject: Revert "mariadb-partman: Modify recipe, to test with es2011" .. Revert "mariadb-partman: Modify recipe, to test

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "mariadb-partman: Modify recipe, to test with es2011"

2018-01-24 Thread Jcrespo (Code Review)
Hello jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/406134 to review the following change. Change subject: Revert "mariadb-partman: Modify recipe, to test with es2011" ..

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "Revert "mariadb: Reimage es2011 into stretch/MariaDB...

2018-01-24 Thread Jcrespo (Code Review)
Hello Marostegui, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/406133 to review the following change. Change subject: Revert "Revert "mariadb: Reimage es2011 into stretch/MariaDB 10.1""

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "mariadb: Depool es2011 for reimage"

2018-01-24 Thread Jcrespo (Code Review)
Hello Urbanecm, jenkins-bot, Zoranzoki21, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/406132 to review the following change. Change subject: Revert "mariadb: Depool es2011 for reimage"

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Introduce and use CommentStoreFactory

2018-01-24 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406131 ) Change subject: Introduce and use CommentStoreFactory .. Introduce and use CommentStoreFactory Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Move socket location, disable notifications of es2011

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406130 ) Change subject: mariadb: Move socket location, disable notifications of es2011 .. mariadb: Move socket location, disable

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Move socket location, disable notifications of es2011

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406130 ) Change subject: mariadb: Move socket location, disable notifications of es2011 .. mariadb: Move socket location, disable notifications of

[MediaWiki-commits] [Gerrit] operations/puppet[production]: eventlog1002 install params

2018-01-24 Thread RobH (Code Review)
RobH has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406129 ) Change subject: eventlog1002 install params .. eventlog1002 install params setting install params for new eventlog1002 system Bug:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: eventlog1002 install params

2018-01-24 Thread RobH (Code Review)
RobH has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406129 ) Change subject: eventlog1002 install params .. eventlog1002 install params setting install params for new eventlog1002 system Bug: T185667

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMaintenance[master]: Error if wiktionary creation attempted without using aawikti...

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/391271 ) Change subject: Error if wiktionary creation attempted without using aawiktionary .. Error if wiktionary creation attempted

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Load preferences js/css in mobile

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406125 ) Change subject: Load preferences js/css in mobile .. Load preferences js/css in mobile Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use RevisionLookup and RevisionFactory interfaces in Revision

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/403117 ) Change subject: Use RevisionLookup and RevisionFactory interfaces in Revision .. Use RevisionLookup and RevisionFactory

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add 'RevisionStore' to wmgMonologChannels

2018-01-24 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406128 ) Change subject: Add 'RevisionStore' to wmgMonologChannels .. Add 'RevisionStore' to wmgMonologChannels Logging for this channel is

[MediaWiki-commits] [Gerrit] operations/dns[master]: setting dns entries for eventlog1002

2018-01-24 Thread RobH (Code Review)
RobH has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406127 ) Change subject: setting dns entries for eventlog1002 .. setting dns entries for eventlog1002 setting the production and mgmt hostname

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Extra tests for SqlBlobStore with 'windows-1252' legacy enco...

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/403754 ) Change subject: Extra tests for SqlBlobStore with 'windows-1252' legacy encoding .. Extra tests for SqlBlobStore with

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Consolidate bailing out from ext/wiki links

2018-01-24 Thread Arlolra (Code Review)
Arlolra has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406126 ) Change subject: Consolidate bailing out from ext/wiki links .. Consolidate bailing out from ext/wiki links So that extlinks get the same

[MediaWiki-commits] [Gerrit] operations/dns[master]: setting dns entries for eventlog1002

2018-01-24 Thread RobH (Code Review)
RobH has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406127 ) Change subject: setting dns entries for eventlog1002 .. setting dns entries for eventlog1002 setting the production and mgmt hostname entries

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Preferences tabs should be horizontally scrollable

2018-01-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406124 ) Change subject: Preferences tabs should be horizontally scrollable .. Preferences tabs should be horizontally scrollable Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove MobilePreferences in favor of core

2018-01-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406123 ) Change subject: Remove MobilePreferences in favor of core .. Remove MobilePreferences in favor of core Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Load preferences js/css in mobile

2018-01-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406125 ) Change subject: Load preferences js/css in mobile .. Load preferences js/css in mobile Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: D'oh: fix creation/import of Default list.

2018-01-24 Thread Dbrant (Code Review)
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406122 ) Change subject: D'oh: fix creation/import of Default list. .. D'oh: fix creation/import of Default list. Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: partman: Add temporary hack to test es2011 partitioning

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406121 ) Change subject: partman: Add temporary hack to test es2011 partitioning .. partman: Add temporary hack to test es2011 partitioning

[MediaWiki-commits] [Gerrit] operations/puppet[production]: partman: Add temporary hack to test es2011 partitioning

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406121 ) Change subject: partman: Add temporary hack to test es2011 partitioning .. partman: Add temporary hack to test es2011 partitioning

[MediaWiki-commits] [Gerrit] mediawiki...PageViewInfo[master]: Add @covers tags

2018-01-24 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406120 ) Change subject: Add @covers tags .. Add @covers tags Change-Id: Iff08056bf98a4d59315d34cd853e1d37ccb0e0f6 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "mariadb: Reimage es2011 into stretch/MariaDB 10.1"

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406117 ) Change subject: Revert "mariadb: Reimage es2011 into stretch/MariaDB 10.1" .. Revert "mariadb: Reimage es2011 into stretch/MariaDB

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: Remove some backwards-compatibility in tests

2018-01-24 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406119 ) Change subject: Remove some backwards-compatibility in tests .. Remove some backwards-compatibility in tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: Add @covers tags

2018-01-24 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406118 ) Change subject: Add @covers tags .. Add @covers tags Change-Id: Ib82168281bdf80522bbadef9fd2a3fcd4731074b --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "mariadb: Reimage es2011 into stretch/MariaDB 10.1"

2018-01-24 Thread Jcrespo (Code Review)
Hello Marostegui, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/406117 to review the following change. Change subject: Revert "mariadb: Reimage es2011 into stretch/MariaDB 10.1"

[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[master]: Add @covers tag

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406116 ) Change subject: Add @covers tag .. Add @covers tag Change-Id: Ifb241ba3f2ec6c25eee812b5c36cc354e3164765 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Add @covers tags

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406115 ) Change subject: Add @covers tags .. Add @covers tags Change-Id: I0633c93c9b9c9d048ad318e1c3ccaddf812d605e --- M

[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[master]: Add @covers tag

2018-01-24 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406116 ) Change subject: Add @covers tag .. Add @covers tag Change-Id: Ifb241ba3f2ec6c25eee812b5c36cc354e3164765 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Rearrange UsageDeduplicator implementation

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405896 ) Change subject: Rearrange UsageDeduplicator implementation .. Rearrange UsageDeduplicator implementation This is basically the

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Add @covers tags

2018-01-24 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406115 ) Change subject: Add @covers tags .. Add @covers tags Change-Id: I0633c93c9b9c9d048ad318e1c3ccaddf812d605e --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb-partman: Modify recipe, to test with es2011

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406114 ) Change subject: mariadb-partman: Modify recipe, to test with es2011 .. mariadb-partman: Modify recipe, to test with es2011 es2011

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb-partman: Modify recipe, to test with es2011

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406114 ) Change subject: mariadb-partman: Modify recipe, to test with es2011 .. mariadb-partman: Modify recipe, to test with es2011 es2011 fails

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Stop clearing tplInfo if don't find a table for fostered con...

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406049 ) Change subject: Stop clearing tplInfo if don't find a table for fostered content .. Stop clearing tplInfo if don't find a table

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Scap: Bring back all target nodes

2018-01-24 Thread Mobrovac (Code Review)
Mobrovac has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406113 ) Change subject: Scap: Bring back all target nodes .. Scap: Bring back all target nodes Bug: T184100 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Scap: Bring back all target nodes

2018-01-24 Thread Mobrovac (Code Review)
Mobrovac has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406113 ) Change subject: Scap: Bring back all target nodes .. Scap: Bring back all target nodes Bug: T184100 Change-Id:

[MediaWiki-commits] [Gerrit] translatewiki[master]: [Delete Batch] Ignore some messages

2018-01-24 Thread MarcoAurelio (Code Review)
MarcoAurelio has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406078 ) Change subject: [Delete Batch] Ignore some messages .. [Delete Batch] Ignore some messages Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Gadgets[master]: Fix PHPDocs of GadgetDefinitionContent::getDeletionUpdates

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406031 ) Change subject: Fix PHPDocs of GadgetDefinitionContent::getDeletionUpdates .. Fix PHPDocs of

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Reimage es2011 into stretch/MariaDB 10.1

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406062 ) Change subject: mariadb: Reimage es2011 into stretch/MariaDB 10.1 .. mariadb: Reimage es2011 into stretch/MariaDB 10.1 We will

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: don't exclude ESLint config from linting

2018-01-24 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406076 ) Change subject: Chore: don't exclude ESLint config from linting .. Chore: don't exclude ESLint config from linting Specify that the

[MediaWiki-commits] [Gerrit] marvin[master]: WIP: Update: add search box UI

2018-01-24 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406077 ) Change subject: WIP: Update: add search box UI .. WIP: Update: add search box UI Refactor the Header component to use the Grid and add

[MediaWiki-commits] [Gerrit] translatewiki[master]: [Cite] Message is empty

2018-01-24 Thread Raimond Spekking (Code Review)
Raimond Spekking has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406075 ) Change subject: [Cite] Message is empty .. [Cite] Message is empty Change-Id: I927649c94822368a88c0384524dd3bc1952f5288

[MediaWiki-commits] [Gerrit] translatewiki[master]: [Cite] Message is empty

2018-01-24 Thread Raimond Spekking (Code Review)
Raimond Spekking has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406075 ) Change subject: [Cite] Message is empty .. [Cite] Message is empty Change-Id: I927649c94822368a88c0384524dd3bc1952f5288 --- M

[MediaWiki-commits] [Gerrit] wikidata...rdf[master]: Add timeout to Wikibase requests

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405825 ) Change subject: Add timeout to Wikibase requests .. Add timeout to Wikibase requests Bug: T179239 Change-Id:

[MediaWiki-commits] [Gerrit] search/MjoLniR[master]: Fixup xgboost training

2018-01-24 Thread EBernhardson (Code Review)
EBernhardson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406068 ) Change subject: Fixup xgboost training .. Fixup xgboost training * Use tree_method = hist when training on a single worker. This is

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [IMPR] Make preloading generators work with arbitrary entity...

2018-01-24 Thread Code Review
Matěj Suchánek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342588 ) Change subject: [IMPR] Make preloading generators work with arbitrary entity types .. [IMPR] Make preloading generators work with

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [Bugfix] Fix invalid exception argument

2018-01-24 Thread Code Review
Matěj Suchánek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406072 ) Change subject: [Bugfix] Fix invalid exception argument .. [Bugfix] Fix invalid exception argument Change-Id:

[MediaWiki-commits] [Gerrit] search/MjoLniR[master]: Pull make_cv_objective outside tuner

2018-01-24 Thread EBernhardson (Code Review)
EBernhardson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406067 ) Change subject: Pull make_cv_objective outside tuner .. Pull make_cv_objective outside tuner This really had no business in tuner,

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: widget: Fix accidental change of copyright year

2018-01-24 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406066 ) Change subject: widget: Fix accidental change of copyright year .. widget: Fix accidental change of copyright year Fixes up

[MediaWiki-commits] [Gerrit] search/MjoLniR[master]: add python interface to scala dbn

2018-01-24 Thread EBernhardson (Code Review)
EBernhardson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406069 ) Change subject: add python interface to scala dbn .. add python interface to scala dbn It turns out only the driver has a py4j

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [bugfix] pwb.py: bad 'user-config.py' was not found

2018-01-24 Thread Framawiki (Code Review)
Framawiki has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406065 ) Change subject: [bugfix] pwb.py: bad 'user-config.py' was not found .. [bugfix] pwb.py: bad 'user-config.py' was not found Bug: T185647

[MediaWiki-commits] [Gerrit] mediawiki...cookiecutter-library[master]: Add ockcyp/covers-validator

2018-01-24 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406071 ) Change subject: Add ockcyp/covers-validator .. Add ockcyp/covers-validator This validates @covers tags without needing to run coverage

[MediaWiki-commits] [Gerrit] search/MjoLniR[master]: Add end-to-end integration test

2018-01-24 Thread EBernhardson (Code Review)
EBernhardson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406070 ) Change subject: Add end-to-end integration test .. Add end-to-end integration test A basic end to end run through of the training

[MediaWiki-commits] [Gerrit] integration/config[master]: Move Internet Explorer tests in WebPageTest to own test files

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404925 ) Change subject: Move Internet Explorer tests in WebPageTest to own test files .. Move Internet Explorer tests in WebPageTest to

[MediaWiki-commits] [Gerrit] performance/WebPageTest[master]: Move Internet Explorer tests to own test files.

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404918 ) Change subject: Move Internet Explorer tests to own test files. .. Move Internet Explorer tests to own test files. By moving

[MediaWiki-commits] [Gerrit] analytics/refinery[master]: Add Persian Wikipedia to clickstream dataset

2018-01-24 Thread Ladsgroup (Code Review)
Ladsgroup has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406064 ) Change subject: Add Persian Wikipedia to clickstream dataset .. Add Persian Wikipedia to clickstream dataset I really need it and this

[MediaWiki-commits] [Gerrit] integration/docroot[master]: cover: Convert coverage sub-nav from breadcrumbs to nav-tabs

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405995 ) Change subject: cover: Convert coverage sub-nav from breadcrumbs to nav-tabs .. cover: Convert coverage sub-nav from

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: rdbms: Simplify Database::factory()

2018-01-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406063 ) Change subject: rdbms: Simplify Database::factory() .. rdbms: Simplify Database::factory() Follows-up 0ff2b7a776 (T120333) which removed

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: mariadb: Depool es2011 for reimage

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406060 ) Change subject: mariadb: Depool es2011 for reimage .. mariadb: Depool es2011 for reimage We are going to test es2011 as the

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Reimage es2011 into stretch/MariaDB 10.1

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406062 ) Change subject: mariadb: Reimage es2011 into stretch/MariaDB 10.1 .. mariadb: Reimage es2011 into stretch/MariaDB 10.1 We will test

[MediaWiki-commits] [Gerrit] operations/puppet[production]: rename piwik::server to just piwik

2018-01-24 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406061 ) Change subject: rename piwik::server to just piwik .. rename piwik::server to just piwik There were historic reasons why it was organized in

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: mariadb: Depool es2011 for reimage

2018-01-24 Thread Jcrespo (Code Review)
Jcrespo has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406060 ) Change subject: mariadb: Depool es2011 for reimage .. mariadb: Depool es2011 for reimage We are going to test es2011 as the first ES

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Simplify documentation headers of includes/widgets/…Widget.p...

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400584 ) Change subject: Simplify documentation headers of includes/widgets/…Widget.php files .. Simplify documentation headers of

[MediaWiki-commits] [Gerrit] CLDRPluralRuleParser[master]: tests: Update phpunit and enable coverage for all classes

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406055 ) Change subject: tests: Update phpunit and enable coverage for all classes .. tests: Update phpunit and enable coverage for all

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add tests for two uncovered CheckResult methods

2018-01-24 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406059 ) Change subject: Add tests for two uncovered CheckResult methods .. Add tests for two uncovered CheckResult methods

[MediaWiki-commits] [Gerrit] mediawiki...GoogleDocTag[master]: Convert GoogleDocTag to use extension registration

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406016 ) Change subject: Convert GoogleDocTag to use extension registration .. Convert GoogleDocTag to use extension registration Bug:

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Only rerender summary after mobile-sections were rerendered.

2018-01-24 Thread Ppchelko (Code Review)
Ppchelko has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406058 ) Change subject: Only rerender summary after mobile-sections were rerendered. .. Only rerender summary after mobile-sections were

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Strip everything before the first pf token

2018-01-24 Thread Arlolra (Code Review)
Arlolra has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406057 ) Change subject: Strip everything before the first pf token .. Strip everything before the first pf token In this isolate case,

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: poolcounter: Fix type hint for PoolWorkArticleView::getParse...

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406038 ) Change subject: poolcounter: Fix type hint for PoolWorkArticleView::getParserOutput .. poolcounter: Fix type hint for

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Move path array prepending logic to ClaimDifferenceVisualizer

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/403963 ) Change subject: Move path array prepending logic to ClaimDifferenceVisualizer .. Move path array prepending logic to

[MediaWiki-commits] [Gerrit] mediawiki...ArticlePlaceholder[master]: Type hint against IDatabase instead of Database

2018-01-24 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406056 ) Change subject: Type hint against IDatabase instead of Database .. Type hint against IDatabase instead of Database The

[MediaWiki-commits] [Gerrit] CLDRPluralRuleParser[master]: tests: Update phpunit and enable coverage for all classes

2018-01-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406055 ) Change subject: tests: Update phpunit and enable coverage for all classes .. tests: Update phpunit and enable coverage for all classes The

[MediaWiki-commits] [Gerrit] mediawiki...ArticlePlaceholder[master]: Add more test cases to improve overall test coverage

2018-01-24 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406054 ) Change subject: Add more test cases to improve overall test coverage .. Add more test cases to improve overall test coverage

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Remove arbitrary SSH thread settings

2018-01-24 Thread RobH (Code Review)
RobH has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/406052 ) Change subject: Gerrit: Remove arbitrary SSH thread settings .. Gerrit: Remove arbitrary SSH thread settings They're from a long long

[MediaWiki-commits] [Gerrit] mediawiki...LanguageTag[master]: Convert LanguageTag to use extension resistration

2018-01-24 Thread Jayprakash12345 (Code Review)
Jayprakash12345 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406053 ) Change subject: Convert LanguageTag to use extension resistration .. Convert LanguageTag to use extension resistration Bug:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Gerrit: Remove arbitrary SSH thread settings

2018-01-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406052 ) Change subject: Gerrit: Remove arbitrary SSH thread settings .. Gerrit: Remove arbitrary SSH thread settings They're from a long long time

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: OptInController catch both errors and exception

2018-01-24 Thread Sbisson (Code Review)
Sbisson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406051 ) Change subject: OptInController catch both errors and exception .. OptInController catch both errors and exception The problem that is

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Split up and test CheckConstraints::newFromGlobalState

2018-01-24 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406050 ) Change subject: Split up and test CheckConstraints::newFromGlobalState .. Split up and test

[MediaWiki-commits] [Gerrit] generator-wikimedia-php-library[master]: Archive repository

2018-01-24 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405929 ) Change subject: Archive repository .. Archive repository Bug: T174416 Change-Id: I0a4a291607da3acf6ba4de7da140c3d8fd4117af --- D

[MediaWiki-commits] [Gerrit] integration/docroot[master]: cover: Fix cover-extension breadcrumbs to work on different ...

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405986 ) Change subject: cover: Fix cover-extension breadcrumbs to work on different mount paths .. cover: Fix cover-extension

[MediaWiki-commits] [Gerrit] integration/docroot[master]: cover: Add sort=cover parameter to coverage report

2018-01-24 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405996 ) Change subject: cover: Add sort=cover parameter to coverage report .. cover: Add sort=cover parameter to coverage report When

  1   2   >