[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Harden zerowiki config (no raw html, no transclude NS_ZERO)

2017-05-17 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354113 ) Change subject: Harden zerowiki config (no raw html, no transclude NS_ZERO) .. Harden zerowiki config (no raw html, no transclude NS_ZER

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add collation for Bashkir (ba)

2017-04-27 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350792 ) Change subject: Add collation for Bashkir (ba) .. Add collation for Bashkir (ba) This is based on a numeric uppercase collation. Bashki

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Hack around icu breakage for fa sorting

2017-05-19 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354598 ) Change subject: Hack around icu breakage for fa sorting .. Hack around icu breakage for fa sorting Bug: T139110 Change-Id: I35bcdaf309f

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix EnhancedChangesList::getDiffHistLinks null exception

2017-05-19 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354602 ) Change subject: Fix EnhancedChangesList::getDiffHistLinks null exception .. Fix EnhancedChangesList::getDiffHistLinks null exception If

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Fix edit conflict handling in lists.

2017-05-20 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354745 ) Change subject: Fix edit conflict handling in lists. .. Fix edit conflict handling in lists. We assume the current DOM is latest, (sinc

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Improve DB query on Special:Newsletters

2017-05-20 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/354636 ) Change subject: Improve DB query on Special:Newsletters .. Improve DB query on Special:Newsletters Bug: T159083 Change-Id: I626

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Use params and getName instead of rawParams and getEscapedName

2017-05-21 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/354901 ) Change subject: Use params and getName instead of rawParams and getEscapedName .. Use params and getName instead of rawParams an

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Add newsletter-restore as an action and right

2017-05-21 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/354898 ) Change subject: Add newsletter-restore as an action and right .. Add newsletter-restore as an action and right Before, there is

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Check if makeTitleSafe returns null in getNewsletterUrl()

2017-05-21 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/354907 ) Change subject: Check if makeTitleSafe returns null in getNewsletterUrl() .. Check if makeTitleSafe returns null in getNewslette

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Make nl_subscriber_count negative.

2017-05-21 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354945 ) Change subject: Make nl_subscriber_count negative. .. Make nl_subscriber_count negative. We want to do queries ordered by nl_subscriber

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMaintenance[master]: Make sure only WMF/Chapter interwikis are internal

2016-09-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/310207 Change subject: Make sure only WMF/Chapter interwikis are internal .. Make sure only WMF/Chapter interwikis are internal This prevents ce

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Disallow css attr() with url type

2016-09-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/310257 Change subject: Disallow css attr() with url type .. Disallow css attr() with url type CSS3 seems like it will extend the attr() function

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Fix error handling and abuse filter integration during edit

2017-08-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371743 ) Change subject: Fix error handling and abuse filter integration during edit .. Fix error handling and abuse filter integration during ed

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Only retain private securepoll data for 60 days after election

2017-08-16 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372180 ) Change subject: Only retain private securepoll data for 60 days after election .. Only retain private securepoll data for 60 days after

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Allow crats to add people to accountcreator group on mw.org

2017-08-23 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373317 ) Change subject: Allow crats to add people to accountcreator group on mw.org .. Allow crats to add people to accountcreator group on mw.o

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Follow-up 6d62e9ea8a. Also allow crats to remove accountcreator

2017-08-23 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/37 ) Change subject: Follow-up 6d62e9ea8a. Also allow crats to remove accountcreator .. Follow-up 6d62e9ea8a. Also allow crats to remove acco

[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[master]: Use global stash instance instead of local cluster intance.

2017-08-23 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373342 ) Change subject: Use global stash instance instead of local cluster intance. .. Use global stash instance instead of local cluster intanc

[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[master]: Fix typo where IP wasn't retrieved from job

2017-08-23 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373359 ) Change subject: Fix typo where IP wasn't retrieved from job .. Fix typo where IP wasn't retrieved from job I think this might be causin

[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[master]: Do not record failures for non-existent accounts

2017-08-23 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373374 ) Change subject: Do not record failures for non-existent accounts .. Do not record failures for non-existent accounts Change-Id: I2229f7

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Redact ep_courses.course_token

2017-07-04 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/363230 ) Change subject: Redact ep_courses.course_token .. Redact ep_courses.course_token Its a shared password used to allow people to register

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Allow SVGs using an older proposed recommendation DTD

2017-06-27 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361668 ) Change subject: Allow SVGs using an older proposed recommendation DTD .. Allow SVGs using an older proposed recommendation DTD

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[REL1_29]: Play things safe when stripping HTML

2017-06-30 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362390 ) Change subject: Play things safe when stripping HTML .. Play things safe when stripping HTML Script and input tags if outputted by othe

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[REL1_28]: Play things safe when stripping HTML

2017-06-30 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362391 ) Change subject: Play things safe when stripping HTML .. Play things safe when stripping HTML Script and input tags if outputted by othe

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[REL1_27]: Play things safe when stripping HTML

2017-06-30 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362392 ) Change subject: Play things safe when stripping HTML .. Play things safe when stripping HTML Script and input tags if outputted by othe

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use the XML definition for what's a valid attribute name

2017-07-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/364818 ) Change subject: Use the XML definition for what's a valid attribute name .. Use the XML definition for what's a valid attribute name Th

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: Allow SVGs using an older proposed recommendation DTD

2017-07-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365077 ) Change subject: Allow SVGs using an older proposed recommendation DTD .. Allow SVGs using an older proposed recommendation DTD Dia soft

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_28]: Allow SVGs using an older proposed recommendation DTD

2017-07-16 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365552 ) Change subject: Allow SVGs using an older proposed recommendation DTD .. Allow SVGs using an older proposed recommendation DTD Dia soft

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Allow SVGs using an older proposed recommendation DTD

2017-07-16 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/365553 ) Change subject: Allow SVGs using an older proposed recommendation DTD .. Allow SVGs using an older proposed recommendation DTD Dia soft

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: SECURITY: Use getFullUrlForRedirect() in Special:CentralAuth...

2017-07-18 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366187 ) Change subject: SECURITY: Use getFullUrlForRedirect() in Special:CentralAuthAutoLogin/setCookies .. SECURITY: Use getFullUrlForRedirect

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[REL1_29]: SECURITY: Use getFullUrlForRedirect() in Special:CentralAuth...

2017-07-18 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366188 ) Change subject: SECURITY: Use getFullUrlForRedirect() in Special:CentralAuthAutoLogin/setCookies .. SECURITY: Use getFullUrlForRedirect

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[REL1_28]: SECURITY: Use getFullUrlForRedirect() in Special:CentralAuth...

2017-07-18 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366189 ) Change subject: SECURITY: Use getFullUrlForRedirect() in Special:CentralAuthAutoLogin/setCookies .. SECURITY: Use getFullUrlForRedirect

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[REL1_27]: SECURITY: Use getFullUrlForRedirect() in Special:CentralAuth...

2017-07-18 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366191 ) Change subject: SECURITY: Use getFullUrlForRedirect() in Special:CentralAuthAutoLogin/setCookies .. SECURITY: Use getFullUrlForRedirect

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[REL1_28]: SECURITY XSS in Special:GlobalGroupPermissions

2017-07-18 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366195 ) Change subject: SECURITY XSS in Special:GlobalGroupPermissions .. SECURITY XSS in Special:GlobalGroupPermissions The group name was not

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[REL1_27]: SECURITY XSS in Special:GlobalGroupPermissions

2017-07-18 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366196 ) Change subject: SECURITY XSS in Special:GlobalGroupPermissions .. SECURITY XSS in Special:GlobalGroupPermissions The group name was not

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update FIRST_LETTER_VERSION for rowiki changes

2017-07-19 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366290 ) Change subject: Update FIRST_LETTER_VERSION for rowiki changes .. Update FIRST_LETTER_VERSION for rowiki changes Can't just clear cache

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Fix js list editing in the single column case

2016-11-10 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/320834 Change subject: Fix js list editing in the single column case .. Fix js list editing in the single column case Change-Id: If5da95c161123f

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Allow 2FA for the abusefilter group if enabled on wiki

2016-11-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/321162 Change subject: Allow 2FA for the abusefilter group if enabled on wiki .. Allow 2FA for the abusefilter group if enabled on wiki This has

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add better logging to password reset

2016-11-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/321166 Change subject: Add better logging to password reset .. Add better logging to password reset In particular we definitely want to log capt

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add extra logging for when user logs in with a temp password

2016-11-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/321170 Change subject: Add extra logging for when user logs in with a temp password .. Add extra logging for when user logs in with a temp passwo

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix message name for passwordreset-invalidemail

2016-11-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/321596 Change subject: Fix message name for passwordreset-invalidemail .. Fix message name for passwordreset-invalidemail This adjust the qqq.js

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use different varname for upgraded hash from origin hash

2016-11-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/321597 Change subject: Use different varname for upgraded hash from origin hash .. Use different varname for upgraded hash from origin hash I fo

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Throw an exception if password hash would be truncated by DB

2016-11-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/321606 Change subject: Throw an exception if password hash would be truncated by DB .. Throw an exception if password hash would be truncated by

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Rewrite runBatchedQuery.php

2016-11-15 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: Rewrite runBatchedQuery.php .. Rewrite runBatchedQuery.php This maintenance script was previously introduced as a way to do large UPDATE queries in a repl

[MediaWiki-commits] [Gerrit] mediawiki...EmailAuth[master]: First version of the extension

2016-11-16 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. Change subject: First version of the extension .. First version of the extension Change-Id: Ia6ed8f1952fd727af352646433b5f90f7083a8c2 --- A .gitignore A .jscsrc A .jshint

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Ban 100 most common passwords from ordinary accounts.

2016-11-16 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/321991 Change subject: Ban 100 most common passwords from ordinary accounts. .. Ban 100 most common passwords from ordinary accounts. Per discus

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Sort member list between active/inactive.

2016-11-17 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/322153 Change subject: Sort member list between active/inactive. .. Sort member list between active/inactive. Probably needs to tweak how transc

[MediaWiki-commits] [Gerrit] Follow-up e33d6f45a. Fix some mistakes w/ limit on QueryPage - change (mediawiki/core)

2015-12-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/261325 Change subject: Follow-up e33d6f45a. Fix some mistakes w/ limit on QueryPage .. Follow-up e33d6f45a. Fix some mistakes w/ limit on QueryPa

[MediaWiki-commits] [Gerrit] Allow maintenance/cdb.php to look up keys with spaces in them. - change (mediawiki/core)

2015-11-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/254698 Change subject: Allow maintenance/cdb.php to look up keys with spaces in them. .. Allow maintenance/cdb.php to look up keys with spaces in

[MediaWiki-commits] [Gerrit] Increae $wgCopyUploadTimeout to 90 seconds (from default 25) - change (operations/mediawiki-config)

2015-11-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/254700 Change subject: Increae $wgCopyUploadTimeout to 90 seconds (from default 25) .. Increae $wgCopyUploadTimeout to 90 seconds (from default 2

[MediaWiki-commits] [Gerrit] Add support for blacklisting common passwords - change (mediawiki/core)

2015-11-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/254754 Change subject: Add support for blacklisting common passwords .. Add support for blacklisting common passwords This changes the default c

[MediaWiki-commits] [Gerrit] Fix typo in doc comment on MWSaltedPassword.php - change (mediawiki/core)

2015-11-23 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/255022 Change subject: Fix typo in doc comment on MWSaltedPassword.php .. Fix typo in doc comment on MWSaltedPassword.php Change-Id: I4d08846f66

[MediaWiki-commits] [Gerrit] Remove inline event handler js from charinsert - change (mediawiki...CharInsert)

2015-12-01 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/256344 Change subject: Remove inline event handler js from charinsert .. Remove inline event handler js from charinsert The primary goal is comp

[MediaWiki-commits] [Gerrit] Fix upload rewrite rules for beta - change (operations/puppet)

2015-12-02 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/256589 Change subject: Fix upload rewrite rules for beta .. Fix upload rewrite rules for beta This was not working for thumbnails with parameter

[MediaWiki-commits] [Gerrit] Use global cache keys login/create account rate limitting - change (mediawiki/core)

2016-02-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/270662 Change subject: Use global cache keys login/create account rate limitting .. Use global cache keys login/create account rate limitting If

[MediaWiki-commits] [Gerrit] Use global cache keys bad login rate limitting captcha trigger - change (mediawiki...ConfirmEdit)

2016-02-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/270663 Change subject: Use global cache keys bad login rate limitting captcha trigger .. Use global cache keys bad login rate limitting captcha t

[MediaWiki-commits] [Gerrit] Allow more fine-grained throttling of login attempts - change (mediawiki/core)

2016-02-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/270669 Change subject: Allow more fine-grained throttling of login attempts .. Allow more fine-grained throttling of login attempts In addition

[MediaWiki-commits] [Gerrit] Add option for a post parse

2016-01-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/264050 Change subject: Add option for a post parse

[MediaWiki-commits] [Gerrit] Don't rely on user lang globals for tags. - change (mediawiki...Translate)

2015-12-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/258730 Change subject: Don't rely on user lang globals for tags. .. Don't rely on user lang globals for tags. During a parse with "canonical"

[MediaWiki-commits] [Gerrit] Make redlink tooltip be content language to stop cache pollu... - change (mediawiki/core)

2015-12-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/258736 Change subject: Make redlink tooltip be content language to stop cache pollution. .. Make redlink tooltip be content language to stop cac

[MediaWiki-commits] [Gerrit] Fix missing semi-colon:   ->   - change (mediawiki/core)

2015-12-13 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/258924 Change subject: Fix missing semi-colon:   ->   .. Fix missing semi-colon:   ->   The error is most noticable when transcluding {{Special:

[MediaWiki-commits] [Gerrit] Require strip marker names to not have & ' " < or > ... - change (mediawiki/core)

2016-01-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/267224 Change subject: Require strip marker names to not have & ' " < or > in them .. Require strip marker names to not have & ' " < or > in t

[MediaWiki-commits] [Gerrit] mediawiki...Wikispeech[master]: Follow MW coding convention for class loading

2016-12-19 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328218 ) Change subject: Follow MW coding convention for class loading .. Follow MW coding convention for class loading Change-Id: Id9dc1b4696fb

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Attempt to optimize api prop=contributors

2016-12-21 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328623 ) Change subject: Attempt to optimize api prop=contributors .. Attempt to optimize api prop=contributors * Use special "contributors" for

mediawiki-commits@lists.wikimedia.org

2016-12-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328875 ) Change subject: Optimize api list=recentchanges&rcnamespace=0&rctype=new .. Optimize api list=recentchanges&rcnamespace=0&rctype=new It

[MediaWiki-commits] [Gerrit] mediawiki...Comments[master]: Remove inline styling

2016-12-23 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/328920 ) Change subject: Remove inline styling .. Remove inline styling Bug:T147253 Bug:T87148 Change-Id: I287b2616215a2ea4679553452cc6f

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Fix function documentation

2016-12-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329631 ) Change subject: Fix function documentation .. Fix function documentation Change-Id: I5ca915815901cb18201ee624f8eb25cd0126561f --- M Col

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Fix CodeEditor JS error on CollaborationHub edit page

2016-12-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329632 ) Change subject: Fix CodeEditor JS error on CollaborationHub edit page .. Fix CodeEditor JS error on CollaborationHub edit page We were

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Fix edit and delete js on multicolumn

2016-12-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329636 ) Change subject: Fix edit and delete js on multicolumn .. Fix edit and delete js on multicolumn The drag and drop still has to be done.

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Use class to set theme for CollaborationHub edit page.

2016-12-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329645 ) Change subject: Use class to set theme for CollaborationHub edit page. .. Use class to set theme for CollaborationHub edit page. Poss

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Make drag and drop work for multi-lists

2017-01-05 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330732 ) Change subject: Make drag and drop work for multi-lists .. Make drag and drop work for multi-lists Bug: T149042 Change-Id: I4e39545e34d

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add another entry to Content-security-policy logging blacklist

2017-02-02 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335757 ) Change subject: Add another entry to Content-security-policy logging blacklist .. Add another entry to Content-security-policy logging b

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Kill unused variable $context

2017-02-28 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340418 ) Change subject: Kill unused variable $context .. Kill unused variable $context Change-Id: I37e712ccaaf4aee6244863c1463a2eba5e398520 ---

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Kill unused cur variable

2017-02-28 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340419 ) Change subject: Kill unused cur variable .. Kill unused cur variable Change-Id: I65cb4dfc126f32b001803fb0f470ac487596a13b --- M modules

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Fix setting column option in transclude hook.

2017-03-01 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340549 ) Change subject: Fix setting column option in transclude hook. .. Fix setting column option in transclude hook. Stuff like {{#transclude

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: rm dead code $itemTags

2017-03-01 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340550 ) Change subject: rm dead code $itemTags .. rm dead code $itemTags Change-Id: I0536aba8b3b0755cd419321a1d501576b5670e3b --- M includes/co

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Fix matchesTag logic + add test.

2017-03-01 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340556 ) Change subject: Fix matchesTag logic + add test. .. Fix matchesTag logic + add test. Previously the logic was the inverse of what was d

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Fix jsduck

2017-03-03 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341054 ) Change subject: Fix jsduck .. Fix jsduck Change-Id: I9c42000761cd9414cf44355fe63910f77cab --- A jsduck.external.js M modules/ext.Co

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Add Doxyfile to generate php docs

2017-03-03 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341077 ) Change subject: Add Doxyfile to generate php docs .. Add Doxyfile to generate php docs Change-Id: I933480d6694577699d16f3b554d03f3ba98c

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Attempt to fix doxygen

2017-03-03 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341093 ) Change subject: Attempt to fix doxygen .. Attempt to fix doxygen Change-Id: I03518a7fa1752361396a1d6c035cae77efd6a366 --- M Collaborati

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Fix doxygen (Third time is the charm)

2017-03-03 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341094 ) Change subject: Fix doxygen (Third time is the charm) .. Fix doxygen (Third time is the charm) Change-Id: Ie9e21e3fc8461d6bc8c2d7843424

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Extend the upload Content-Security-Policy test to other larg...

2017-03-05 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341207 ) Change subject: Extend the upload Content-Security-Policy test to other large wikis .. Extend the upload Content-Security-Policy test t

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add a CSP policy to foundationwiki to prevent privacy breach

2017-03-05 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341259 ) Change subject: Add a CSP policy to foundationwiki to prevent privacy breach .. Add a CSP policy to foundationwiki to prevent privacy br

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Change account creation throttle for idwiki to default (6)

2017-03-05 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341263 ) Change subject: Change account creation throttle for idwiki to default (6) .. Change account creation throttle for idwiki to default (6)

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add other WMF domains to foundationwiki CSP policy for Speci...

2017-03-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341331 ) Change subject: Add other WMF domains to foundationwiki CSP policy for Special:HideBanners .. Add other WMF domains to foundationwiki C

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: Fix MWException about passing an array named data to Html::e...

2017-03-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341340 ) Change subject: Fix MWException about passing an array named data to Html::element .. Fix MWException about passing an array named data

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: In CSP policy for foundationwiki, wikidata.org -> www.wikida...

2017-03-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341472 ) Change subject: In CSP policy for foundationwiki, wikidata.org -> www.wikidata.org .. In CSP policy for foundationwiki, wikidata.org ->

[MediaWiki-commits] [Gerrit] mediawiki...DownloadCounter[master]: SECURITY: Avoid path traversal, follow best practises for es...

2017-03-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342330 ) Change subject: SECURITY: Avoid path traversal, follow best practises for escaping .. SECURITY: Avoid path traversal, follow best pract

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make selectRowCount() (hopefully) work in MSSQL.

2017-03-12 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342411 ) Change subject: Make selectRowCount() (hopefully) work in MSSQL. .. Make selectRowCount() (hopefully) work in MSSQL. This makes the ide

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SECURITY: Disable tag on system messages despite $wgR...

2017-02-07 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336389 ) Change subject: SECURITY: Disable tag on system messages despite $wgRawHtml = true; .. SECURITY: Disable tag on system messages despi

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Do not allow bot right to be applied to NS_MEDIAWIKI or user...

2017-02-07 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336390 ) Change subject: Do not allow bot right to be applied to NS_MEDIAWIKI or user JS/CSS .. Do not allow bot right to be applied to NS_MEDIA

[MediaWiki-commits] [Gerrit] mediawiki...NamespacePopups[master]: Now it works thanks to ParserAfterTidy hook

2017-01-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331086 ) Change subject: Now it works thanks to ParserAfterTidy hook .. Now it works thanks to ParserAfterTidy hook Change-Id: I6fb708f9

[MediaWiki-commits] [Gerrit] mediawiki...NamespacePopups[master]: logging removed

2017-01-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331088 ) Change subject: logging removed .. logging removed Change-Id: I7ba052219dfce752994078be9dd946f1708ce4cd --- M NamespacePopups.h

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: SECURITY: Fix XSS with evil username

2017-01-09 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331404 ) Change subject: SECURITY: Fix XSS with evil username .. SECURITY: Fix XSS with evil username Change-Id: I74f60d09a8c304c7a2e1b772a73f8e

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_28]: Escape return path extra params to php mail()

2017-01-11 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331663 ) Change subject: Escape return path extra params to php mail() .. Escape return path extra params to php mail() PHP only escapes some da

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Escape return path extra params to php mail()

2017-01-11 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331670 ) Change subject: Escape return path extra params to php mail() .. Escape return path extra params to php mail() PHP only escapes some da

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Move title validation for Special:CreateCollaborationHub to ...

2017-01-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332114 ) Change subject: Move title validation for Special:CreateCollaborationHub to that field .. Move title validation for Special:CreateColla

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Add period to end of error messages.

2017-01-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332115 ) Change subject: Add period to end of error messages. .. Add period to end of error messages. Change-Id: I1e9994364356b8bd475fba3304a053

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Fix warning about static.name and fix for widget name change

2017-01-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332116 ) Change subject: Fix warning about static.name and fix for widget name change .. Fix warning about static.name and fix for widget name ch

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Give early error message in Special:CreateCollaborationHub i...

2017-01-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332117 ) Change subject: Give early error message in Special:CreateCollaborationHub if not allowed .. Give early error message in Special:Create

[MediaWiki-commits] [Gerrit] mediawiki...CollaborationKit[master]: Clarify the rendering option code, and fix a wfMessage call.

2017-01-14 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332122 ) Change subject: Clarify the rendering option code, and fix a wfMessage call. .. Clarify the rendering option code, and fix a wfMessage c

<    2   3   4   5   6   7   8   9   >