[MediaWiki-commits] [Gerrit] Add autocomplete support for EditSummaries with a ContentPro... - change (apps...wikipedia)

2014-03-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add autocomplete support for EditSummaries with a ContentProvider .. Add autocomplete support for EditSummaries with a ContentProvider - Also adds

[MediaWiki-commits] [Gerrit] Show Edit Summary field only after preview is fetched - change (apps...wikipedia)

2014-03-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Show Edit Summary field only after preview is fetched .. Show Edit Summary field only after preview is fetched Change-Id:

[MediaWiki-commits] [Gerrit] Update version to prep for Google Play alpha releases - change (apps...wikipedia)

2014-03-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Update version to prep for Google Play alpha releases .. Update version to prep for Google Play alpha releases Change-Id:

[MediaWiki-commits] [Gerrit] Display version string prominently in the app - change (apps...wikipedia)

2014-03-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Display version string prominently in the app .. Display version string prominently in the app Will be taken out for final release Change-Id:

[MediaWiki-commits] [Gerrit] Add section-0 edit button - change (apps...wikipedia)

2014-03-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/118363 Change subject: Add section-0 edit button .. Add section-0 edit button Bug: 61513 Change-Id: I2497c725c5915ff6404760b62c7dc56c16b5639d

[MediaWiki-commits] [Gerrit] Set 'lang' and 'dir' attribs on HTML body; fixes basic RTL a... - change (apps...wikipedia)

2014-03-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/118377 Change subject: Set 'lang' and 'dir' attribs on HTML body; fixes basic RTL articles .. Set 'lang' and 'dir' attribs on HTML body; fixes

[MediaWiki-commits] [Gerrit] Return captcha information via createaccount API only if no ... - change (mediawiki...ConfirmEdit)

2014-03-13 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Return captcha information via createaccount API only if no other errors .. Return captcha information via createaccount API only if no other errors

[MediaWiki-commits] [Gerrit] Interacting with edit summary interface causes nav bar text ... - change (apps...wikipedia)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Interacting with edit summary interface causes nav bar text to change. .. Interacting with edit summary interface causes nav bar text to change. Made

[MediaWiki-commits] [Gerrit] Alerts now can be shown by UITableViewController too. - change (apps...wikipedia)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Alerts now can be shown by UITableViewController too. .. Alerts now can be shown by UITableViewController too. Also top alerts now can show over html

[MediaWiki-commits] [Gerrit] Random articles. - change (apps...wikipedia)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Random articles. .. Random articles. * mhurd asked to make Random tappable in W menu (as opposed to shake). * See PS3 for the version using shake and

[MediaWiki-commits] [Gerrit] Add User-Agent to make traffic distinguishable in logs. - change (apps...wikipedia)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add User-Agent to make traffic distinguishable in logs. .. Add User-Agent to make traffic distinguishable in logs. Change-Id:

[MediaWiki-commits] [Gerrit] Add 'Send app feedback' to iOS app. - change (apps...wikipedia)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add 'Send app feedback' to iOS app. .. Add 'Send app feedback' to iOS app. * For now, just emails mhurd and subject contains version. Change-Id:

[MediaWiki-commits] [Gerrit] Design tweaks for nav drawer - change (apps...wikipedia)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Design tweaks for nav drawer .. Design tweaks for nav drawer - Designers are experimenting with the color - Search bar is hidden as well - Zero

[MediaWiki-commits] [Gerrit] ToC design tweaks - change (apps...wikipedia)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: ToC design tweaks .. ToC design tweaks Can see ToC by swiping left-to-right. Edge-dragging shows Drawer Change-Id:

[MediaWiki-commits] [Gerrit] Fix for crashes when nav items tapped while views are transi... - change (apps...wikipedia)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix for crashes when nav items tapped while views are transitioning. .. Fix for crashes when nav items tapped while views are transitioning. There had

[MediaWiki-commits] [Gerrit] For the Android Share feature, do not show Always option. - change (apps...wikipedia)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: For the Android Share feature, do not show Always option. .. For the Android Share feature, do not show Always option. * Users are likely to use

[MediaWiki-commits] [Gerrit] Support custom User-Agent. - change (apps...java-mwapi)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Support custom User-Agent. .. Support custom User-Agent. * This allows for API consumers to identify themselves. Change-Id:

[MediaWiki-commits] [Gerrit] Set custom User-Agent for rebooted Android app. - change (apps...wikipedia)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Set custom User-Agent for rebooted Android app. .. Set custom User-Agent for rebooted Android app. * Allows app to identify itself. * Dependency:

[MediaWiki-commits] [Gerrit] Indicate currently selected section in ToC - change (apps...wikipedia)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Indicate currently selected section in ToC .. Indicate currently selected section in ToC Change-Id: I430ac436aa15efca359d595041baf40f4f59b353 --- M

[MediaWiki-commits] [Gerrit] If drawer is open when back is pressed, hide it - change (apps...wikipedia)

2014-03-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: If drawer is open when back is pressed, hide it .. If drawer is open when back is pressed, hide it Change-Id: Ib7d405c0152bfce629f247e60b75231abc1e01e3

[MediaWiki-commits] [Gerrit] If search is visible, hide it rather than go 'back' - change (apps...wikipedia)

2014-03-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: If search is visible, hide it rather than go 'back' .. If search is visible, hide it rather than go 'back' Change-Id:

[MediaWiki-commits] [Gerrit] Move code that hides search results into own method - change (apps...wikipedia)

2014-03-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Move code that hides search results into own method .. Move code that hides search results into own method Change-Id:

[MediaWiki-commits] [Gerrit] Display previous search results when search bar with text is... - change (apps...wikipedia)

2014-03-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Display previous search results when search bar with text is tapped .. Display previous search results when search bar with text is tapped Change-Id:

[MediaWiki-commits] [Gerrit] Fix back not working when cached search results are displayed - change (apps...wikipedia)

2014-03-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix back not working when cached search results are displayed .. Fix back not working when cached search results are displayed Change-Id:

[MediaWiki-commits] [Gerrit] Get rid of old values-iw and symlink it to values-he - change (apps...wikipedia)

2014-03-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Get rid of old values-iw and symlink it to values-he .. Get rid of old values-iw and symlink it to values-he Change-Id:

[MediaWiki-commits] [Gerrit] Add python script that generates pngs from svgs - change (apps...wikipedia)

2014-03-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add python script that generates pngs from svgs .. Add python script that generates pngs from svgs - Requires rsvg-convert and the python sh module -

[MediaWiki-commits] [Gerrit] Add icons to left nav - change (apps...wikipedia)

2014-03-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add icons to left nav .. Add icons to left nav Icon for saved pages not used. Needs to be redone Change-Id: I91adac774c41d841b32d59e541ff4dc8d562fd08

[MediaWiki-commits] [Gerrit] Fix back button not working - change (apps...wikipedia)

2014-03-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix back button not working .. Fix back button not working Change-Id: I4f34e27e784f18222981a09a8249246faff5afe0 --- M

[MediaWiki-commits] [Gerrit] Send feedback to i...@wikimedia.org. - change (apps...wikipedia)

2014-03-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Send feedback to i...@wikimedia.org. .. Send feedback to i...@wikimedia.org. Change-Id: I3a019b731c388c850299bc904b579b7b97b767fe --- M

[MediaWiki-commits] [Gerrit] Set 'lang' and 'dir' attribs on HTML body; fixes basic RTL a... - change (apps...wikipedia)

2014-03-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Set 'lang' and 'dir' attribs on HTML body; fixes basic RTL articles .. Set 'lang' and 'dir' attribs on HTML body; fixes basic RTL articles Bug: 61867

[MediaWiki-commits] [Gerrit] Workarounds for deprecated language codes for yi and id - change (apps...wikipedia)

2014-03-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Workarounds for deprecated language codes for yi and id .. Workarounds for deprecated language codes for yi and id Bug: 62720 Change-Id:

[MediaWiki-commits] [Gerrit] Get rid of share lead text - change (apps...wikipedia)

2014-03-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Get rid of share lead text .. Get rid of share lead text We shouldn't add random extra boilerplate to what someone is sharing. Besides, we don't need

[MediaWiki-commits] [Gerrit] Stop processing if user taps 'x' before page loads. - change (apps...wikipedia)

2014-03-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Stop processing if user taps 'x' before page loads. .. Stop processing if user taps 'x' before page loads. * Fixes

[MediaWiki-commits] [Gerrit] Shorten text in option for preferred language. - change (apps...wikipedia)

2014-03-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Shorten text in option for preferred language. .. Shorten text in option for preferred language. * Fixes

[MediaWiki-commits] [Gerrit] Workaround for app crashing on low memory. Retain last page ... - change (apps...wikipedia)

2014-03-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Workaround for app crashing on low memory. Retain last page location. .. Workaround for app crashing on low memory. Retain last page location.

[MediaWiki-commits] [Gerrit] Bring user to last page viewed on browser restart. - change (apps...wikipedia)

2014-03-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Bring user to last page viewed on browser restart. .. Bring user to last page viewed on browser restart. * Workaround for low memory issue in

[MediaWiki-commits] [Gerrit] Update appcache and version. - change (apps...wikipedia)

2014-03-19 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Update appcache and version. .. Update appcache and version. Change-Id: Icb7b3e13e2e439b9db429163911f855a02b3ad06 --- M app.appcache M manifest.webapp 2

[MediaWiki-commits] [Gerrit] add a bunch of new strings files to the project so they get ... - change (apps...wikipedia)

2014-03-19 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/119681 Change subject: add a bunch of new strings files to the project so they get included in the build .. add a bunch of new strings files

[MediaWiki-commits] [Gerrit] add a bunch of new strings files to the project so they get ... - change (apps...wikipedia)

2014-03-19 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: add a bunch of new strings files to the project so they get included in the build .. add a bunch of new strings files to the project so they get

[MediaWiki-commits] [Gerrit] Fix position of logged in icon on navbar - change (apps...wikipedia)

2014-03-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix position of logged in icon on navbar .. Fix position of logged in icon on navbar Change-Id: Iedf592a5e61a4536b3a827a665cf084c1802c5a2 --- M

[MediaWiki-commits] [Gerrit] Added new bookmark icon for saved pages - change (apps...wikipedia)

2014-03-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Added new bookmark icon for saved pages .. Added new bookmark icon for saved pages Change-Id: Id703df21d4271216c1031bf9a52409c0114de46d --- M

[MediaWiki-commits] [Gerrit] Simplified new flow for Logging in after creating account - change (apps...wikipedia)

2014-03-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Simplified new flow for Logging in after creating account .. Simplified new flow for Logging in after creating account - This shows create account

[MediaWiki-commits] [Gerrit] Simplify SaneAsyncTask constructor boilerplate. - change (apps...wikipedia)

2014-03-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Simplify SaneAsyncTask constructor boilerplate. .. Simplify SaneAsyncTask constructor boilerplate. Added a constructor that just takes the number of

[MediaWiki-commits] [Gerrit] Add User Contributions page - change (apps...wikipedia)

2014-03-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add User Contributions page .. Add User Contributions page Activated by tapping on user name when logged in. - Need to find alternate location for

[MediaWiki-commits] [Gerrit] Add My Contributions Logout to left nav menu - change (apps...wikipedia)

2014-03-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add My Contributions Logout to left nav menu .. Add My Contributions Logout to left nav menu Change-Id: I1a33caa64bd8689af93a07cb502c1a48a70a078f ---

[MediaWiki-commits] [Gerrit] Add base class for EventLogging - change (apps...wikipedia)

2014-03-27 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add base class for EventLogging .. Add base class for EventLogging Change-Id: I3548d6b22696a3097e976daff1e1c9711790e8e6 --- A

[MediaWiki-commits] [Gerrit] Handle page redirects properly - change (apps...wikipedia)

2014-03-27 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Handle page redirects properly .. Handle page redirects properly Bug: 63179 Change-Id: I2547de1b7139266b95bb267e4b7b9ac9d8dba8dc --- M

[MediaWiki-commits] [Gerrit] Make 'Go' button go to exact page title user typed - change (apps...wikipedia)

2014-03-27 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Make 'Go' button go to exact page title user typed .. Make 'Go' button go to exact page title user typed Note that this crashes the app if there is no

[MediaWiki-commits] [Gerrit] Handle titles that need normalization - change (apps...wikipedia)

2014-03-27 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Handle titles that need normalization .. Handle titles that need normalization Change-Id: I9c04176f1d830ceb7ea40a856bf578e5d82601e6 --- M

[MediaWiki-commits] [Gerrit] Custom pull-to-refresh for articles. - change (apps...wikipedia)

2014-03-27 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Custom pull-to-refresh for articles. .. Custom pull-to-refresh for articles. Change-Id: Id76ad6518cf0cdc2f2b1a05a59e09c93e7146b7a --- M

[MediaWiki-commits] [Gerrit] Remove devmode. Make Wikipedia Zero a regular fixture. - change (apps...wikipedia)

2014-03-27 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Remove devmode. Make Wikipedia Zero a regular fixture. .. Remove devmode. Make Wikipedia Zero a regular fixture. Change-Id:

[MediaWiki-commits] [Gerrit] [Gingerbread] Partial fixes for 'saved pages' view - change (apps...wikipedia)

2014-04-03 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/123785 Change subject: [Gingerbread] Partial fixes for 'saved pages' view .. [Gingerbread] Partial fixes for 'saved pages' view Doesn't quite

[MediaWiki-commits] [Gerrit] [Gingerbread] Fix extra action bar on 2.3 - change (apps...wikipedia)

2014-04-03 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/123787 Change subject: [Gingerbread] Fix extra action bar on 2.3 .. [Gingerbread] Fix extra action bar on 2.3 Change-Id:

[MediaWiki-commits] [Gerrit] Make license footer display with UI lang directionality - change (apps...wikipedia)

2014-04-04 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Make license footer display with UI lang directionality .. Make license footer display with UI lang directionality Adds ways to access the

[MediaWiki-commits] [Gerrit] Set text direction of edit summary field for RTL languages p... - change (apps...wikipedia)

2014-04-04 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Set text direction of edit summary field for RTL languages properly .. Set text direction of edit summary field for RTL languages properly Bug: 63266

[MediaWiki-commits] [Gerrit] Set edit text box's directionality - change (apps...wikipedia)

2014-04-04 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Set edit text box's directionality .. Set edit text box's directionality Bug: 63264 Change-Id: I2e3907156ced1850f0e2f729bbd044cdd4485f38 --- M

[MediaWiki-commits] [Gerrit] Position edit icon appropriately in RTL pages - change (apps...wikipedia)

2014-04-04 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Position edit icon appropriately in RTL pages .. Position edit icon appropriately in RTL pages Change-Id: I6054252ed7107ee53aa64d3deeac05b33240adb3 ---

[MediaWiki-commits] [Gerrit] Add classList polyfill - change (apps...wikipedia)

2014-04-04 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add classList polyfill .. Add classList polyfill Is unconditionally loaded for now, should be only 2.3 later on. Change-Id:

[MediaWiki-commits] [Gerrit] Make convert-icons produce flipped versions of images too - change (apps...wikipedia)

2014-04-04 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Make convert-icons produce flipped versions of images too .. Make convert-icons produce flipped versions of images too Change-Id:

[MediaWiki-commits] [Gerrit] List layout for settings language selector is v11 again, hav... - change (apps...wikipedia)

2014-04-07 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/124364 Change subject: List layout for settings language selector is v11 again, have to duplicate it .. List layout for settings language

[MediaWiki-commits] [Gerrit] [Gingerbread] Attempting to get edit summary memory working - change (apps...wikipedia)

2014-04-07 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/124369 Change subject: [Gingerbread] Attempting to get edit summary memory working .. [Gingerbread] Attempting to get edit summary memory

[MediaWiki-commits] [Gerrit] Added jshintrc and fixed warning - change (apps...wikipedia)

2014-04-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Added jshintrc and fixed warning .. Added jshintrc and fixed warning Change-Id: I8615914bc5cb292db2a1c7ffa6f22d87c303f158 --- A .jshintignore A

[MediaWiki-commits] [Gerrit] Don't put page title in Share Text - change (apps...wikipedia)

2014-04-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Don't put page title in Share Text .. Don't put page title in Share Text Bug: 63525 Change-Id: I3a8796600b5bfec9c0db50cd87d703d6dd971d97 --- M

[MediaWiki-commits] [Gerrit] Fix margin for saved pages / history icons in RTL languages - change (apps...wikipedia)

2014-04-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix margin for saved pages / history icons in RTL languages .. Fix margin for saved pages / history icons in RTL languages Change-Id:

[MediaWiki-commits] [Gerrit] Fix RTL issues with username display in drawer - change (apps...wikipedia)

2014-04-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix RTL issues with username display in drawer .. Fix RTL issues with username display in drawer Change-Id: I07a866421f57dfa0c80d20ff57bf016772af721e

[MediaWiki-commits] [Gerrit] Add apk files to gitignore - change (apps...wikipedia)

2014-04-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add apk files to gitignore .. Add apk files to gitignore Change-Id: I02003d48230cd452c7baab9d5efa01c8680e8d79 --- M .gitignore 1 file changed, 3

[MediaWiki-commits] [Gerrit] Add proper flipped drawer indicator icon - change (apps...wikipedia)

2014-04-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add proper flipped drawer indicator icon .. Add proper flipped drawer indicator icon Change-Id: Ie5b68f5fe835021638e721eed92aa57e03b946db --- A

[MediaWiki-commits] [Gerrit] Don't restart activities on rotation - change (apps...wikipedia)

2014-04-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Don't restart activities on rotation .. Don't restart activities on rotation We should still be careful to make sure that activity restart does not lose

[MediaWiki-commits] [Gerrit] Make python files almost PEP8 compliant - change (apps...wikipedia)

2014-04-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Make python files almost PEP8 compliant .. Make python files almost PEP8 compliant Except the 80 char line length limit. Boo to that! Also add flake8

[MediaWiki-commits] [Gerrit] Added checkstyle.xml config for Java coding style - change (apps...wikipedia)

2014-04-09 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Added checkstyle.xml config for Java coding style .. Added checkstyle.xml config for Java coding style - Living style guide, will be subject to changes

[MediaWiki-commits] [Gerrit] Fixed account creation. Now works with updated api. - change (apps...wikipedia)

2014-04-09 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fixed account creation. Now works with updated api. .. Fixed account creation. Now works with updated api. Previously captcha solution was required

[MediaWiki-commits] [Gerrit] Turn Wikipedia Zero toasts to croutons. - change (apps...wikipedia)

2014-04-09 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Turn Wikipedia Zero toasts to croutons. .. Turn Wikipedia Zero toasts to croutons. Change-Id: I459b8dd9bcbd3f0fbf1bbb498845061aa7422031 --- M

[MediaWiki-commits] [Gerrit] bump version number for alpha update - change (apps...wikipedia)

2014-04-09 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/124913 Change subject: bump version number for alpha update .. bump version number for alpha update Change-Id:

[MediaWiki-commits] [Gerrit] [Gingerbread] Disable crashy AutoCompleteTextView in edit su... - change (apps...wikipedia)

2014-04-10 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/125271 Change subject: [Gingerbread] Disable crashy AutoCompleteTextView in edit summary .. [Gingerbread] Disable crashy AutoCompleteTextView

[MediaWiki-commits] [Gerrit] Work in progress: fallback-friendly MWLocalizedString to rep... - change (apps...wikipedia)

2014-04-10 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/125326 Change subject: Work in progress: fallback-friendly MWLocalizedString to replcae NSLocalizedString .. Work in progress:

[MediaWiki-commits] [Gerrit] Add ability to read config parameters from a URL - change (apps...wikipedia)

2014-04-11 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add ability to read config parameters from a URL .. Add ability to read config parameters from a URL - Is refreshed once a day - Exposed as a JSON

[MediaWiki-commits] [Gerrit] Support hiding edit button for anon users - change (apps...wikipedia)

2014-04-11 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Support hiding edit button for anon users .. Support hiding edit button for anon users Based on remoteConfig - if it is tweaked to be 'true' then anon

[MediaWiki-commits] [Gerrit] Renamed Wikipedia-iOS folder to wikipedia. - change (apps...wikipedia)

2014-04-11 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Renamed Wikipedia-iOS folder to wikipedia. .. Renamed Wikipedia-iOS folder to wikipedia. For better sync with gruntjs config. Change-Id:

[MediaWiki-commits] [Gerrit] Update paths in Wikipedia-iOS; a directory got renamed - change (translatewiki)

2014-04-11 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/125451 Change subject: Update paths in Wikipedia-iOS; a directory got renamed .. Update paths in Wikipedia-iOS; a directory got renamed

[MediaWiki-commits] [Gerrit] Exclude gruntJS www files from build. - change (apps...wikipedia)

2014-04-11 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Exclude gruntJS www files from build. .. Exclude gruntJS www files from build. Only the output of gruntJS is needed. These are in the assets folder.

[MediaWiki-commits] [Gerrit] Edit preview html is now styled correctly. - change (apps...wikipedia)

2014-04-11 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Edit preview html is now styled correctly. .. Edit preview html is now styled correctly. Change-Id: Ibf1c50e231b8f2d134fe3257edd371bc1e800afd --- M

[MediaWiki-commits] [Gerrit] First pass at event logging infrastructure. - change (apps...wikipedia)

2014-04-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: First pass at event logging infrastructure. .. First pass at event logging infrastructure. In this commit the only event being logged is the edit start.

[MediaWiki-commits] [Gerrit] Set text writing direction on section editor according to co... - change (apps...wikipedia)

2014-04-14 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/125879 Change subject: Set text writing direction on section editor according to content language .. Set text writing direction on section

[MediaWiki-commits] [Gerrit] Set text writing direction on section editor according to co... - change (apps...wikipedia)

2014-04-15 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Set text writing direction on section editor according to content language .. Set text writing direction on section editor according to content language

[MediaWiki-commits] [Gerrit] Nav bar label can shrink text a bit for long l10n strings. - change (apps...wikipedia)

2014-04-15 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Nav bar label can shrink text a bit for long l10n strings. .. Nav bar label can shrink text a bit for long l10n strings. Change-Id:

[MediaWiki-commits] [Gerrit] Added more logging events. - change (apps...wikipedia)

2014-04-15 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Added more logging events. .. Added more logging events. Fixed bug where edit right arrow tap after captcha or abuse filter messages were shown would

[MediaWiki-commits] [Gerrit] Fix keyboard not hiding when it should - change (apps...wikipedia)

2014-04-15 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix keyboard not hiding when it should .. Fix keyboard not hiding when it should Bug: 63493 Change-Id: I8e9c59bc4d37092a4035c661e559700e64e48d82 --- M

[MediaWiki-commits] [Gerrit] Fix Account Creation not working - change (apps...wikipedia)

2014-04-15 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix Account Creation not working .. Fix Account Creation not working Change-Id: I8a9bbf3e63086fb016121552b57e1210ac6d821c --- M

[MediaWiki-commits] [Gerrit] Add spaces where required to match checkstyle. - change (apps...wikipedia)

2014-04-15 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add spaces where required to match checkstyle. .. Add spaces where required to match checkstyle. Nowhere as spaced out as mediawiki is, maaan. Bug:

[MediaWiki-commits] [Gerrit] Fix ordering of class definition modifier - change (apps...wikipedia)

2014-04-15 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix ordering of class definition modifier .. Fix ordering of class definition modifier Bug: 63742 Change-Id: I1a4cad03a3007633cc2dca516ee3a4044216e4d2

[MediaWiki-commits] [Gerrit] Ignore setter and constructors for HiddenFieldCheck - change (apps...wikipedia)

2014-04-15 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Ignore setter and constructors for HiddenFieldCheck .. Ignore setter and constructors for HiddenFieldCheck Was generating a lot of noise. Bug: 63742

[MediaWiki-commits] [Gerrit] Don't count blocks as empty if they have comments in them - change (apps...wikipedia)

2014-04-15 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Don't count blocks as empty if they have comments in them .. Don't count blocks as empty if they have comments in them Bug: 63742 Change-Id:

[MediaWiki-commits] [Gerrit] Mark some uninheritable classes as final - change (apps...wikipedia)

2014-04-15 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Mark some uninheritable classes as final .. Mark some uninheritable classes as final Bug: 63742 Change-Id: I467f04b9a08386fff8e5522ccc4e7ee62f32c4c8 ---

[MediaWiki-commits] [Gerrit] Refine Magic Number detection to ignore common numbers - change (apps...wikipedia)

2014-04-15 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Refine Magic Number detection to ignore common numbers .. Refine Magic Number detection to ignore common numbers Bug: 63742 Change-Id:

[MediaWiki-commits] [Gerrit] Fix FieldHidden warnings turn off warnings for params - change (apps...wikipedia)

2014-04-16 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix FieldHidden warnings turn off warnings for params .. Fix FieldHidden warnings turn off warnings for params Bug: 63742 Change-Id:

[MediaWiki-commits] [Gerrit] Make magic numbers unmagical - change (apps...wikipedia)

2014-04-16 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Make magic numbers unmagical .. Make magic numbers unmagical Still some left. Need more careful handling. Bug: 63742 Change-Id:

[MediaWiki-commits] [Gerrit] Fix broken tests for Page properties - change (apps...wikipedia)

2014-04-16 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix broken tests for Page properties .. Fix broken tests for Page properties Change-Id: I2ac7f3e3c6912cbf4e89f90289755a473b09bf44 --- M

[MediaWiki-commits] [Gerrit] Fix UA to provide phone/tablet info - change (apps...wikipedia)

2014-04-16 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix UA to provide phone/tablet info .. Fix UA to provide phone/tablet info Also change OS name to let UAParser parse it. Change-Id:

[MediaWiki-commits] [Gerrit] Changing Wikipedia Zero On/Off. - change (apps...wikipedia)

2014-04-16 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Changing Wikipedia Zero On/Off. .. Changing Wikipedia Zero On/Off. * Now a fixed box at bottom of screen when On, temporary when Off. Change-Id:

[MediaWiki-commits] [Gerrit] Fix for alert sometimes now wrapping precisely. - change (apps...wikipedia)

2014-04-16 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix for alert sometimes now wrapping precisely. .. Fix for alert sometimes now wrapping precisely. Change-Id: I93708117b8b27a86b9e56dd4645dd6436791

<    5   6   7   8   9   10   11   12   13   14   >