[MediaWiki-commits] [Gerrit] Rename UpdatePagesJob -> MassIndexJob - change (mediawiki...CirrusSearch)

2014-01-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107987 Change subject: Rename UpdatePagesJob -> MassIndexJob .. Rename UpdatePagesJob -> MassIndexJob The name is misleading for what it actually does

[MediaWiki-commits] [Gerrit] WIP: Move purge-checkuser script off hume and to terbium - change (operations/puppet)

2014-01-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108165 Change subject: WIP: Move purge-checkuser script off hume and to terbium .. WIP: Move purge-checkuser script off hume and to terbium Todo: - F

[MediaWiki-commits] [Gerrit] Remove unused variable - change (mediawiki...CirrusSearch)

2014-01-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108183 Change subject: Remove unused variable .. Remove unused variable Change-Id: I95c360f9adabfe2caa48cc0b88dae5642ca863ad --- M includes/Searcher.p

[MediaWiki-commits] [Gerrit] Begin abstracting more of the database-specific search backe... - change (mediawiki/core)

2014-01-17 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108187 Change subject: Begin abstracting more of the database-specific search backend out .. Begin abstracting more of the database-specific search ba

[MediaWiki-commits] [Gerrit] Handle missing revisions a bit better - change (mediawiki...FlaggedRevs)

2014-01-21 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Handle missing revisions a bit better .. Handle missing revisions a bit better Change-Id: I0f23833cc19fd377aa173808c4fe4658f3d6ad80 --- M backend/FlaggedRevs.cla

[MediaWiki-commits] [Gerrit] Lower account-related caches from infinity to 1 week - change (operations/puppet)

2014-01-21 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108715 Change subject: Lower account-related caches from infinity to 1 week .. Lower account-related caches from infinity to 1 week Change-Id: Ic2cd42

[MediaWiki-commits] [Gerrit] Don't construct an object we aren't using - change (mediawiki...CirrusSearch)

2014-01-21 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108743 Change subject: Don't construct an object we aren't using .. Don't construct an object we aren't using Change-Id: Ib4c42171feabf34261434795c1b5

[MediaWiki-commits] [Gerrit] Updating Cirrus to master (a310e9f9) - change (mediawiki/core)

2014-01-21 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108829 Change subject: Updating Cirrus to master (a310e9f9) .. Updating Cirrus to master (a310e9f9) Change-Id: I061e55ff1ccb1163d259f104bfc3b31571052d

[MediaWiki-commits] [Gerrit] Updating Cirrus to master (a310e9f9) - change (mediawiki/core)

2014-01-21 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108828 Change subject: Updating Cirrus to master (a310e9f9) .. Updating Cirrus to master (a310e9f9) Change-Id: I619e5db179d6bb44966e16c9877ccc3f0c4656

[MediaWiki-commits] [Gerrit] Don't use when SkinTemplate can provide - change (mediawiki...QuizGame)

2014-01-21 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108834 Change subject: Don't use when SkinTemplate can provide .. Don't use when SkinTemplate can provide Change-Id: I97ac906bf2d17af86d0710da52d4a5

[MediaWiki-commits] [Gerrit] Don't use $wgTitle when the Parser can provide - change (mediawiki...YotpoReviews)

2014-01-21 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108842 Change subject: Don't use $wgTitle when the Parser can provide .. Don't use $wgTitle when the Parser can provide Change-Id: I785f01abfa73296a22

[MediaWiki-commits] [Gerrit] Don't use $wgTitle when there's valid ones on hand - change (mediawiki...WikiArticleFeeds)

2014-01-21 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108846 Change subject: Don't use $wgTitle when there's valid ones on hand .. Don't use $wgTitle when there's valid ones on hand Change-Id: Ia35329fb9d

[MediaWiki-commits] [Gerrit] Updating Elastica to master - change (mediawiki/core)

2014-01-21 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108860 Change subject: Updating Elastica to master .. Updating Elastica to master Change-Id: I71a20b6df6d7c551b705d47aab42326553b4e745 --- M extension

[MediaWiki-commits] [Gerrit] Updating Elastica to master - change (mediawiki/core)

2014-01-21 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Updating Elastica to master .. Updating Elastica to master Change-Id: I71a20b6df6d7c551b705d47aab42326553b4e745 --- M extensions/Elastica 1 file changed, 0 inser

[MediaWiki-commits] [Gerrit] Remove UpdatePages jobs - change (mediawiki...CirrusSearch)

2014-01-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108925 Change subject: Remove UpdatePages jobs .. Remove UpdatePages jobs They've all been moved over to MassIndex jobs and there's none left in any o

[MediaWiki-commits] [Gerrit] Remove outdated todo. Never gonna happen. - change (mediawiki...CirrusSearch)

2014-01-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108928 Change subject: Remove outdated todo. Never gonna happen. .. Remove outdated todo. Never gonna happen. Change-Id: Ib308931f92cab8484c7c7641d9a1

[MediaWiki-commits] [Gerrit] Remove WikibaseQueryEngine submodule, repo to be deleted - change (mediawiki/extensions)

2014-01-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/108942 Change subject: Remove WikibaseQueryEngine submodule, repo to be deleted .. Remove WikibaseQueryEngine submodule, repo to be deleted Change-Id:

[MediaWiki-commits] [Gerrit] Remove WikibaseQueryEngine submodule, repo to be deleted - change (mediawiki/extensions)

2014-01-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Remove WikibaseQueryEngine submodule, repo to be deleted .. Remove WikibaseQueryEngine submodule, repo to be deleted Change-Id: I89fc9c48b3fe502a4fe5e95a33017389

[MediaWiki-commits] [Gerrit] Replace usage of deprecated Title::escapeLocalURL() - change (mediawiki...ScanSet)

2014-01-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Replace usage of deprecated Title::escapeLocalURL() .. Replace usage of deprecated Title::escapeLocalURL() Change-Id: Ib58af87bebbbe5a5a8b7979e26ea2bc97ee2d342 -

[MediaWiki-commits] [Gerrit] Replace usage of deprecated Title::escapeLocalURL() - change (mediawiki...Video)

2014-01-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Replace usage of deprecated Title::escapeLocalURL() .. Replace usage of deprecated Title::escapeLocalURL() Change-Id: Ic812ddb2eff66a4e9bf633a7b930dff4a2340cfe -

[MediaWiki-commits] [Gerrit] Call Linker::formatSize statically - change (mediawiki...MediaFunctions)

2014-01-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Call Linker::formatSize statically .. Call Linker::formatSize statically The bumps the required MediaWiki version to 1.18. Change-Id: I1914b369049b96354187b16ef

[MediaWiki-commits] [Gerrit] Replace deprecated Block::infinity (1.18) - change (mediawiki...AuthorProtect)

2014-01-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Replace deprecated Block::infinity (1.18) .. Replace deprecated Block::infinity (1.18) Change-Id: I371b7fd2c3f1485d0aadca92670d6009456beeea --- M AuthorProtect.p

[MediaWiki-commits] [Gerrit] WIP: Track versions of the index for easier maintenance - change (mediawiki...CirrusSearch)

2014-01-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/109007 Change subject: WIP: Track versions of the index for easier maintenance .. WIP: Track versions of the index for easier maintenance Change-Id: I

[MediaWiki-commits] [Gerrit] Call Linker methods statically - change (mediawiki...Contributors)

2014-01-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Call Linker methods statically .. Call Linker methods statically Change-Id: Ibc3bd81b5a9d714a605b3e0c7f14ee6631d90c07 --- M Contributors.page.php 1 file changed,

[MediaWiki-commits] [Gerrit] Remove UpdatePages jobs - change (mediawiki...CirrusSearch)

2014-01-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Remove UpdatePages jobs .. Remove UpdatePages jobs They've all been moved over to MassIndex jobs and there's none left in any of the queues. Change-Id: I389d6d1

[MediaWiki-commits] [Gerrit] Call Linker methods statically - change (mediawiki...RefreshSpecial)

2014-01-22 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Call Linker methods statically .. Call Linker methods statically Change-Id: Ia7b4725f59f335bb8aa90640e44c4795a072e236 --- M RefreshSpecial.body.php 1 file change

[MediaWiki-commits] [Gerrit] This has been optimized for over 2 years now - change (mediawiki...BlogPage)

2014-01-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/109044 Change subject: This has been optimized for over 2 years now .. This has been optimized for over 2 years now Time to make the optimization perm

[MediaWiki-commits] [Gerrit] Tidy up Title/RevId handling in trackRequest() - change (mediawiki...ClickTracking)

2014-01-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/109045 Change subject: Tidy up Title/RevId handling in trackRequest() .. Tidy up Title/RevId handling in trackRequest() - Pass title that we already k

[MediaWiki-commits] [Gerrit] Remove all uses of $wgTitle from FanBox extension - change (mediawiki...FanBoxes)

2014-01-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/109046 Change subject: Remove all uses of $wgTitle from FanBox extension .. Remove all uses of $wgTitle from FanBox extension All of them are easily a

[MediaWiki-commits] [Gerrit] Don't even mention $wgTitle in comments - change (mediawiki...AbuseFilter)

2014-01-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/109047 Change subject: Don't even mention $wgTitle in comments .. Don't even mention $wgTitle in comments Change-Id: I28c8c4cb31e7beafcc3bca2620c3e65d

[MediaWiki-commits] [Gerrit] Fix logic error that caused dual logging - change (mediawiki...CirrusSearch)

2014-01-22 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/109052 Change subject: Fix logic error that caused dual logging .. Fix logic error that caused dual logging DocumentMissingExceptions aren't really fa

[MediaWiki-commits] [Gerrit] Call Linker methods statically - change (mediawiki...Video)

2014-01-23 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Call Linker methods statically .. Call Linker methods statically Change-Id: Id333dc147b232380d28c3df10c9b1d7a639f4d0c --- M SpecialNewVideos.php M VideoGallery.p

[MediaWiki-commits] [Gerrit] Call Linker methods statically - change (mediawiki...GoogleMaps)

2014-01-23 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Call Linker methods statically .. Call Linker methods statically Change-Id: Ia37ffa514bb305fecb79376ffc55aab480a66b77 --- M GoogleMaps.body.php 1 file changed, 1

[MediaWiki-commits] [Gerrit] Replace usage of deprecated Title::escapeLocalURL() - change (mediawiki...PrivateDomains)

2014-01-24 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Replace usage of deprecated Title::escapeLocalURL() .. Replace usage of deprecated Title::escapeLocalURL() Change-Id: I01df26d70ca06b834a7f328c1dd16a1831bfb1b1 -

[MediaWiki-commits] [Gerrit] Replace usage of deprecated Title::escapeLocalURL() - change (mediawiki...SocialProfile)

2014-01-24 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Replace usage of deprecated Title::escapeLocalURL() .. Replace usage of deprecated Title::escapeLocalURL() Change-Id: I82e7cfd168373f0ab9ba28abe84865ad69c1b799 -

[MediaWiki-commits] [Gerrit] Replace deprecated SpecialPage::resolveAliasWithSubpage() - change (mediawiki...SkinPerNamespace)

2014-01-24 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Replace deprecated SpecialPage::resolveAliasWithSubpage() .. Replace deprecated SpecialPage::resolveAliasWithSubpage() Change-Id: Ief831cb53978064fce1847c31d91f6

[MediaWiki-commits] [Gerrit] Replace usage of deprecated Title::escapeLocalURL() - change (mediawiki...SportsTeams)

2014-01-24 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Replace usage of deprecated Title::escapeLocalURL() .. Replace usage of deprecated Title::escapeLocalURL() Change-Id: I13d932a36f3e9057a114bad67aa38319b1ef089c -

[MediaWiki-commits] [Gerrit] Replace deprecated SpecialPage::getPage() - change (mediawiki...SemanticComments)

2014-01-24 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Replace deprecated SpecialPage::getPage() .. Replace deprecated SpecialPage::getPage() Change-Id: I7d2371afce1642feecfa6fa9a424a8cf8a9ae4da --- M includes/CE_Glo

[MediaWiki-commits] [Gerrit] Call Linker methods statically - change (mediawiki...Maintenance)

2014-01-24 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Call Linker methods statically .. Call Linker methods statically Change-Id: I3b4e3043de13b2f102c1451a75538d41d74a5520 --- M Maintenance_body.php 1 file changed,

[MediaWiki-commits] [Gerrit] Call Linker methods statically - change (mediawiki...MassEditRegex)

2014-01-24 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Call Linker methods statically .. Call Linker methods statically Change-Id: Ib66bee38af2164669f2414f3bfa4d7c26eebe694 --- M MassEditRegex.class.php 1 file change

[MediaWiki-commits] [Gerrit] schol.js: pass jshint - change (wikimedia/wikimania-scholarships)

2013-11-26 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: schol.js: pass jshint .. schol.js: pass jshint public/js/schols.js: line 10, col 9, Bad line breaking before '+'. public/js/schols.js: line 11, col 5, Bad line b

[MediaWiki-commits] [Gerrit] Split NS_FILE into its own index type - change (mediawiki...CirrusSearch)

2013-11-26 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/97767 Change subject: Split NS_FILE into its own index type .. Split NS_FILE into its own index type Change-Id: I79e134d18e2c43557558e7001945d30ab233c

[MediaWiki-commits] [Gerrit] Improved CdbException handling - change (mediawiki...Babel)

2013-11-26 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/97844 Change subject: Improved CdbException handling .. Improved CdbException handling Change-Id: I1d3de72238ee788834abaa2d517c7975dc4986ac --- M Babe

[MediaWiki-commits] [Gerrit] Proper CdbException handling - change (mediawiki...WikimediaMaintenance)

2013-11-26 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/97846 Change subject: Proper CdbException handling .. Proper CdbException handling Also fix up usage of print while we're here Change-Id: Ib7af23f2dc

[MediaWiki-commits] [Gerrit] Improved CdbException handling in Interwiki - change (mediawiki/core)

2013-11-26 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/97847 Change subject: Improved CdbException handling in Interwiki .. Improved CdbException handling in Interwiki Change-Id: I6461b64dc77b3ecc641db39da

[MediaWiki-commits] [Gerrit] Fix notices on undefined $fileHandle and $res - change (mediawiki/core)

2013-11-27 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/97930 Change subject: Fix notices on undefined $fileHandle and $res .. Fix notices on undefined $fileHandle and $res Change-Id: If9f37549af85df0a418db

[MediaWiki-commits] [Gerrit] Updating CirrusSearch to master (ffef180) - change (mediawiki/core)

2013-12-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/98534 Change subject: Updating CirrusSearch to master (ffef180) .. Updating CirrusSearch to master (ffef180) Change-Id: I6adb09166ba6994aa050b56964d10

[MediaWiki-commits] [Gerrit] Updating Cirrus to master (ffef180) - change (mediawiki/core)

2013-12-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/98535 Change subject: Updating Cirrus to master (ffef180) .. Updating Cirrus to master (ffef180) Change-Id: I8db75d283981ed844904f97397d61796411f9a44

[MediaWiki-commits] [Gerrit] Turn Cirrus back on secondary for all wikis that had it before - change (operations/mediawiki-config)

2013-12-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/98543 Change subject: Turn Cirrus back on secondary for all wikis that had it before .. Turn Cirrus back on secondary for all wikis that had it before

[MediaWiki-commits] [Gerrit] Fix submodule reference change that snuck into If5b3a27a - change (operations/mediawiki-config)

2013-12-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/98545 Change subject: Fix submodule reference change that snuck into If5b3a27a .. Fix submodule reference change that snuck into If5b3a27a Change-Id:

[MediaWiki-commits] [Gerrit] Fix submodule reference change that snuck into If5b3a27a - change (operations/mediawiki-config)

2013-12-02 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Fix submodule reference change that snuck into If5b3a27a .. Fix submodule reference change that snuck into If5b3a27a Change-Id: I507a72cca8db84c93954b46fbdb8ba86

[MediaWiki-commits] [Gerrit] Disable search updates for Cirrus wikis for the time being - change (operations/mediawiki-config)

2013-12-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/98571 Change subject: Disable search updates for Cirrus wikis for the time being .. Disable search updates for Cirrus wikis for the time being Change-

[MediaWiki-commits] [Gerrit] Disable search updates for Cirrus wikis for the time being - change (operations/mediawiki-config)

2013-12-02 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Disable search updates for Cirrus wikis for the time being .. Disable search updates for Cirrus wikis for the time being Change-Id: If7140f8f9ff620e371d94a9f46cb

[MediaWiki-commits] [Gerrit] Elastica to master - change (mediawiki/core)

2013-12-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/98574 Change subject: Elastica to master .. Elastica to master Change-Id: Iaefc481e61dd46808066d8d0dcf06fa1c2634871 --- M extensions/Elastica 1 file c

[MediaWiki-commits] [Gerrit] Elastica to master - change (mediawiki/core)

2013-12-02 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Elastica to master .. Elastica to master Change-Id: Iaefc481e61dd46808066d8d0dcf06fa1c2634871 --- M extensions/Elastica 1 file changed, 0 insertions(+), 0 deleti

[MediaWiki-commits] [Gerrit] Update documentation - change (mediawiki...SwiftCloudFiles)

2013-12-03 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Update documentation .. Update documentation Change-Id: Idf4af357983d9376ae8692cecf992a4aa1c768a4 --- M php-cloudfiles-wmf/cloudfiles.php 1 file changed, 3 inser

[MediaWiki-commits] [Gerrit] Implement multi-index support on a per-namespace basis - change (mediawiki...CirrusSearch)

2013-12-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/98986 Change subject: Implement multi-index support on a per-namespace basis .. Implement multi-index support on a per-namespace basis Bug: 53531 Chan

[MediaWiki-commits] [Gerrit] Fix test2wiki to only have Cirrus as primary, not both - change (operations/mediawiki-config)

2013-12-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/99007 Change subject: Fix test2wiki to only have Cirrus as primary, not both .. Fix test2wiki to only have Cirrus as primary, not both When we move th

[MediaWiki-commits] [Gerrit] Fix test2wiki to only have Cirrus as primary, not both - change (operations/mediawiki-config)

2013-12-03 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Fix test2wiki to only have Cirrus as primary, not both .. Fix test2wiki to only have Cirrus as primary, not both When we move the 'cirrus' group back to default,

[MediaWiki-commits] [Gerrit] Update Cirrus to master - change (mediawiki/core)

2013-12-04 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Update Cirrus to master .. Update Cirrus to master Change-Id: I713f2f159b7b4314b1e8b11cec465cce01fdc768 --- M extensions/CirrusSearch 1 file changed, 0 insertion

[MediaWiki-commits] [Gerrit] Modify access rules - change (operations/software)

2013-12-04 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Modify access rules .. Modify access rules --- M project.config 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Chad: Verified; Looks good to me, app

[MediaWiki-commits] [Gerrit] Fix fetching ParserOutput - change (mediawiki...CirrusSearch)

2013-12-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/99274 Change subject: Fix fetching ParserOutput .. Fix fetching ParserOutput WikiPage::getParserOutput() can return false when we don't hit the parser

[MediaWiki-commits] [Gerrit] Clean up where conditions in sql query - change (mediawiki...CirrusSearch)

2013-12-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/99277 Change subject: Clean up where conditions in sql query .. Clean up where conditions in sql query Less raw SQL, more arrays. Also remove an array

[MediaWiki-commits] [Gerrit] Move decode results portion of findUpdates() to its own method - change (mediawiki...CirrusSearch)

2014-02-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/113468 Change subject: Move decode results portion of findUpdates() to its own method .. Move decode results portion of findUpdates() to its own method

[MediaWiki-commits] [Gerrit] Make failure messages less spammy - change (mediawiki...CirrusSearch)

2014-02-14 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/113469 Change subject: Make failure messages less spammy .. Make failure messages less spammy Batch them in one message per failure event, rather than

[MediaWiki-commits] [Gerrit] RequestContext is better than $wgLang. Slightly - change (mediawiki...CirrusSearch)

2014-02-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/113975 Change subject: RequestContext is better than $wgLang. Slightly .. RequestContext is better than $wgLang. Slightly Change-Id: I7c0bae67560fc20ec

[MediaWiki-commits] [Gerrit] The parser is never null - change (mediawiki...BiblioPlus)

2014-02-18 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: The parser is never null .. The parser is never null Change-Id: Id57e8859858e57d906ea6ccbc860ef852c452590 --- M BiblioPlus.body.php 1 file changed, 7 insertions(

[MediaWiki-commits] [Gerrit] Use parser's title rather than $wgTitle - change (mediawiki...GoogleMaps)

2014-02-18 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Use parser's title rather than $wgTitle .. Use parser's title rather than $wgTitle Change-Id: I5bfe42c857ac2e6c8f8ea68f90aa6eff51a97955 --- M GoogleMaps.body.php

[MediaWiki-commits] [Gerrit] The parser is never null :) - change (mediawiki...GraphViz)

2014-02-18 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: The parser is never null :) .. The parser is never null :) Change-Id: I043896949e44966b5493e5d05a9ca08dfa268bf7 --- M GraphViz.php 1 file changed, 4 insertions(+

[MediaWiki-commits] [Gerrit] Don't need $wgTitle or $wgParser here - change (mediawiki...ExtTab)

2014-02-18 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Don't need $wgTitle or $wgParser here .. Don't need $wgTitle or $wgParser here Change-Id: I8e16a11a75f0a86c4c1459b2b136d30f3c0a12f1 --- M includes/ET_ParserFunct

[MediaWiki-commits] [Gerrit] Remove easily removed $wgTitles, SpecialPages and Articles h... - change (mediawiki...Wikilog)

2014-02-18 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Remove easily removed $wgTitles, SpecialPages and Articles have titles on hand .. Remove easily removed $wgTitles, SpecialPages and Articles have titles on hand

[MediaWiki-commits] [Gerrit] Get title from article rather than $wgTitle - change (mediawiki...Video)

2014-02-18 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Get title from article rather than $wgTitle .. Get title from article rather than $wgTitle Change-Id: Ic12f34adf8f289dbaa7b450eb3e5b4bbc3da4165 --- M VideoPage.p

[MediaWiki-commits] [Gerrit] Remove most $wgTitles and $wgArticles - change (mediawiki...SemanticPageMaker)

2014-02-18 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Remove most $wgTitles and $wgArticles .. Remove most $wgTitles and $wgArticles Change-Id: I44d2d00aac0c81aacb599b213438ee1913deb83e --- M includes/SPM_InlineEdit

[MediaWiki-commits] [Gerrit] Remove final usage of $wgArticle anywhere in git - change (mediawiki...BlueSpiceFoundation)

2014-02-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114125 Change subject: Remove final usage of $wgArticle anywhere in git .. Remove final usage of $wgArticle anywhere in git Change-Id: I19402dc814c8e9a

[MediaWiki-commits] [Gerrit] Remove $wgTitles from all over the place - change (mediawiki...MassEditRegex)

2014-02-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114126 Change subject: Remove $wgTitles from all over the place .. Remove $wgTitles from all over the place Change-Id: I7c88729308ced602144f90bf0951aad

[MediaWiki-commits] [Gerrit] Give wikiversities Cirrus - change (operations/mediawiki-config)

2014-02-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114156 Change subject: Give wikiversities Cirrus .. Give wikiversities Cirrus Change-Id: I93c492c7f0cdae4331462afbbfe2918a202ac695 --- M wmf-config/Ini

[MediaWiki-commits] [Gerrit] Update CirrusSearch and Elastica to master - change (mediawiki/core)

2014-02-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114157 Change subject: Update CirrusSearch and Elastica to master .. Update CirrusSearch and Elastica to master Change-Id: I28d7c8256bad177a64de17bdb82

[MediaWiki-commits] [Gerrit] Update CirrusSearch and Elastica to master - change (mediawiki/core)

2014-02-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114159 Change subject: Update CirrusSearch and Elastica to master .. Update CirrusSearch and Elastica to master Change-Id: Id17fcfb07c295a9103aeccd899a

[MediaWiki-commits] [Gerrit] Remove final usage of $wgArticle anywhere in git - change (mediawiki...BlueSpiceFoundation)

2014-02-19 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Remove final usage of $wgArticle anywhere in git .. Remove final usage of $wgArticle anywhere in git Change-Id: I19402dc814c8e9ac5187925cb142368d9acbeb5c --- M m

[MediaWiki-commits] [Gerrit] Give wikiversities and itwikiquote Cirrus - change (operations/mediawiki-config)

2014-02-19 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Give wikiversities and itwikiquote Cirrus .. Give wikiversities and itwikiquote Cirrus Change-Id: I93c492c7f0cdae4331462afbbfe2918a202ac695 --- M wmf-config/Init

[MediaWiki-commits] [Gerrit] Wikiversities and itwikiquote are done building - change (operations/mediawiki-config)

2014-02-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114169 Change subject: Wikiversities and itwikiquote are done building .. Wikiversities and itwikiquote are done building Change-Id: I3d7be346d3707ec63

[MediaWiki-commits] [Gerrit] Remove Calendar and Quiz extensions -- unused on cluster - change (mediawiki...release)

2014-02-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114330 Change subject: Remove Calendar and Quiz extensions -- unused on cluster .. Remove Calendar and Quiz extensions -- unused on cluster Change-Id:

[MediaWiki-commits] [Gerrit] Use ssh for submodules, makes it easier to manage from - change (mediawiki...release)

2014-02-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114331 Change subject: Use ssh for submodules, makes it easier to manage from .. Use ssh for submodules, makes it easier to manage from Change-Id: I896

[MediaWiki-commits] [Gerrit] Revert "Use ssh for submodules, makes it easier to manage from" - change (mediawiki...release)

2014-02-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114380 Change subject: Revert "Use ssh for submodules, makes it easier to manage from" .. Revert "Use ssh for submodules, makes it easier to manage from

[MediaWiki-commits] [Gerrit] Create global /etc/gitconfig for deployment hosts - change (operations/puppet)

2014-02-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114385 Change subject: Create global /etc/gitconfig for deployment hosts .. Create global /etc/gitconfig for deployment hosts Right now, swaps out http

[MediaWiki-commits] [Gerrit] WIP: Improve LVS check for Elasticsearch - change (operations/puppet)

2014-02-19 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114399 Change subject: WIP: Improve LVS check for Elasticsearch .. WIP: Improve LVS check for Elasticsearch Try to check the _node API to see if we can

[MediaWiki-commits] [Gerrit] Revert "Improve LVS check for Elasticsearch" - change (operations/puppet)

2014-02-20 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114504 Change subject: Revert "Improve LVS check for Elasticsearch" .. Revert "Improve LVS check for Elasticsearch" This isn't quite what I wanted. Thi

[MediaWiki-commits] [Gerrit] I am not sure why this is suddenly necessary - change (mediawiki...CirrusSearch)

2014-02-20 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/114512 Change subject: I am not sure why this is suddenly necessary .. I am not sure why this is suddenly necessary Elasticsearch 1.0? Change-Id: I9b7

[MediaWiki-commits] [Gerrit] Remove content index segregation - change (mediawiki...CirrusSearch)

2014-02-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/115210 Change subject: Remove content index segregation .. Remove content index segregation This isn't useful for most wikis and actually cases a huge

[MediaWiki-commits] [Gerrit] Don't use parsed wikitext when dealing with CSS/JS pages - change (mediawiki...CirrusSearch)

2014-02-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/115214 Change subject: Don't use parsed wikitext when dealing with CSS/JS pages .. Don't use parsed wikitext when dealing with CSS/JS pages They're bog

[MediaWiki-commits] [Gerrit] Fix path in UnitTestsList hook - change (mediawiki...CirrusSearch)

2014-02-24 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Fix path in UnitTestsList hook .. Fix path in UnitTestsList hook The function registered the unit test files has probably be moved from the root path down to inc

[MediaWiki-commits] [Gerrit] Multiply by 100 for percentages, not 200 - change (mediawiki...CirrusSearch)

2014-02-24 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/115319 Change subject: Multiply by 100 for percentages, not 200 .. Multiply by 100 for percentages, not 200 Change-Id: I9516dca27b4a36335b5a8810618dd79

[MediaWiki-commits] [Gerrit] Be explicit about function calls - change (mediawiki...CirrusSearch)

2014-02-25 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/115417 Change subject: Be explicit about function calls .. Be explicit about function calls It doesn't save us anything, confuses static analysis and b

[MediaWiki-commits] [Gerrit] Fix messy variable usage in debug & remove unused global - change (mediawiki...CirrusSearch)

2014-02-25 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/115420 Change subject: Fix messy variable usage in debug & remove unused global .. Fix messy variable usage in debug & remove unused global Change-Id:

[MediaWiki-commits] [Gerrit] Don't even mention $wgTitle - change (mediawiki/core)

2013-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/95736 Change subject: Don't even mention $wgTitle .. Don't even mention $wgTitle Change-Id: Icdef53a498505945d03fb60fe53251b3bea2bee0 --- M includes/S

[MediaWiki-commits] [Gerrit] Deprecate calling Parser::transformMsg() without a Title - change (mediawiki/core)

2013-11-15 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/95743 Change subject: Deprecate calling Parser::transformMsg() without a Title .. Deprecate calling Parser::transformMsg() without a Title Change-Id:

[MediaWiki-commits] [Gerrit] EditFilterMerged is always called - change (mediawiki...AkismetKlik)

2013-11-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/95838 Change subject: EditFilterMerged is always called .. EditFilterMerged is always called - Removes some older back-compat code - Removes call to d

[MediaWiki-commits] [Gerrit] Remove deprecated EditPage::spamPage() - change (mediawiki/core)

2013-11-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/95839 Change subject: Remove deprecated EditPage::spamPage() .. Remove deprecated EditPage::spamPage() Has been deprecated since 1.17, no callers anyw

[MediaWiki-commits] [Gerrit] Remove ugly $wgTitle usage from edit.php maintenance script - change (mediawiki/core)

2013-11-16 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/95840 Change subject: Remove ugly $wgTitle usage from edit.php maintenance script .. Remove ugly $wgTitle usage from edit.php maintenance script Chang

[MediaWiki-commits] [Gerrit] Clean up replica configuration for all wikis - change (operations/mediawiki-config)

2013-11-18 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/96056 Change subject: Clean up replica configuration for all wikis .. Clean up replica configuration for all wikis This should be 2 for all setups in

<    1   2   3   4   5   6   7   8   9   10   >