[MediaWiki-commits] [Gerrit] Don't use $wgTitle - change (mediawiki...AdManager)

2014-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105004 Change subject: Don't use $wgTitle .. Don't use $wgTitle Change-Id: I9a67452a06e6512d30606ea9b99e48e153ba701d --- M AdManager.hooks.php 1 file

[MediaWiki-commits] [Gerrit] Remove deprecated convertLinkToAllVariants() - change (mediawiki/core)

2014-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105010 Change subject: Remove deprecated convertLinkToAllVariants() .. Remove deprecated convertLinkToAllVariants() Deprecated since 1.17, not used an

[MediaWiki-commits] [Gerrit] MWException doesn't care about $wgTitle anymore - change (mediawiki/core)

2014-01-02 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105017 Change subject: MWException doesn't care about $wgTitle anymore .. MWException doesn't care about $wgTitle anymore Change-Id: I59a54280496cc5bb

[MediaWiki-commits] [Gerrit] Shrink the LinksUpdateJob a bit - change (mediawiki...CirrusSearch)

2014-01-02 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Shrink the LinksUpdateJob a bit .. Shrink the LinksUpdateJob a bit This'll protect from updates that add or remove a _ton_ of links. This moves the link selecti

[MediaWiki-commits] [Gerrit] Build fixed size chunks when indexing - change (mediawiki...CirrusSearch)

2014-01-02 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Build fixed size chunks when indexing .. Build fixed size chunks when indexing Because indexing leaks memory even while queueing we need a way to build fixed siz

[MediaWiki-commits] [Gerrit] Replace usage of deprecated Title::escapeLocalURL() - change (mediawiki...ProtectSite)

2014-01-03 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Replace usage of deprecated Title::escapeLocalURL() .. Replace usage of deprecated Title::escapeLocalURL() Change-Id: I9c51f6d112b476390d5033eae4912c700fd45663 -

[MediaWiki-commits] [Gerrit] Remove commented calls to transformMsg() - change (mediawiki...DynamicPageList)

2014-01-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105201 Change subject: Remove commented calls to transformMsg() .. Remove commented calls to transformMsg() They were removed on purpose in 0fb8eed5,

[MediaWiki-commits] [Gerrit] Move $titleForParse setting up earlier and use it in remaini... - change (mediawiki...FeaturedFeeds)

2014-01-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105205 Change subject: Move $titleForParse setting up earlier and use it in remaining transformMsg() call .. Move $titleForParse setting up earlier an

[MediaWiki-commits] [Gerrit] Expand CirrusSearchMappingConfig hook a bit to make it useful - change (mediawiki...CirrusSearch)

2014-01-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105219 Change subject: Expand CirrusSearchMappingConfig hook a bit to make it useful .. Expand CirrusSearchMappingConfig hook a bit to make it useful

[MediaWiki-commits] [Gerrit] Begin extending CirrusSearch schema - change (mediawiki...LiquidThreads)

2014-01-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105220 Change subject: Begin extending CirrusSearch schema .. Begin extending CirrusSearch schema Change-Id: Ic85061bb611648b4fa4d41031bc0713f8e7f4b01

[MediaWiki-commits] [Gerrit] Allow other extensions to modify documents to be updated - change (mediawiki...CirrusSearch)

2014-01-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105224 Change subject: Allow other extensions to modify documents to be updated .. Allow other extensions to modify documents to be updated Change-Id:

[MediaWiki-commits] [Gerrit] Index necessary data in CirrusSearch - change (mediawiki...LiquidThreads)

2014-01-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105227 Change subject: Index necessary data in CirrusSearch .. Index necessary data in CirrusSearch Change-Id: I018e2725cc7ddf038ccb34caf9ff26915e7619

[MediaWiki-commits] [Gerrit] Allow SearchResults to specify that they matched file content - change (mediawiki/core)

2014-01-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105234 Change subject: Allow SearchResults to specify that they matched file content .. Allow SearchResults to specify that they matched file content

[MediaWiki-commits] [Gerrit] Use I21440625's indication of file content matches - change (mediawiki...CirrusSearch)

2014-01-03 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105235 Change subject: Use I21440625's indication of file content matches .. Use I21440625's indication of file content matches Change-Id: I421f4775fc

[MediaWiki-commits] [Gerrit] Finalize commons config for Cirrus - change (operations/mediawiki-config)

2014-01-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105479 Change subject: Finalize commons config for Cirrus .. Finalize commons config for Cirrus Change-Id: I1a970fd4fc0e0d30e22ee437da0c45ef98e33a5e -

[MediaWiki-commits] [Gerrit] Update cirrus to master again - change (mediawiki/core)

2014-01-06 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Update cirrus to master again .. Update cirrus to master again Change-Id: I8383c23f46e51c3310ae8f057ac9925faea9f0f7 --- M extensions/CirrusSearch 1 file changed,

[MediaWiki-commits] [Gerrit] One more update to cirrussearch's master - change (mediawiki/core)

2014-01-06 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: One more update to cirrussearch's master .. One more update to cirrussearch's master Change-Id: I97f4e3317ab50afd6544792eff6951d03f250e51 --- M extensions/Cirrus

[MediaWiki-commits] [Gerrit] Add maintenance script to autoloader - change (mediawiki...CirrusSearch)

2014-01-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105717 Change subject: Add maintenance script to autoloader .. Add maintenance script to autoloader Change-Id: I975b19a542072b9f8d26bc92bb6fe27a02536b

[MediaWiki-commits] [Gerrit] Allow underscores as well as spaces in incategory: - change (mediawiki...CirrusSearch)

2014-01-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105828 Change subject: Allow underscores as well as spaces in incategory: .. Allow underscores as well as spaces in incategory: Bug: 58579 Change-Id:

[MediaWiki-commits] [Gerrit] Doesn't need to be static - change (mediawiki...CirrusSearch)

2014-01-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105861 Change subject: Doesn't need to be static .. Doesn't need to be static Change-Id: Id820ad0431ab8baff7eebfa658b46bb60190686f --- M includes/Link

[MediaWiki-commits] [Gerrit] Doesn't need to be static - change (mediawiki...CirrusSearch)

2014-01-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105863 Change subject: Doesn't need to be static .. Doesn't need to be static Change-Id: I51f867d63a19757bdab4832e0bbcc29a32ab02ca --- M maintenance/f

[MediaWiki-commits] [Gerrit] Remove searchlimit preference - change (mediawiki/core)

2014-01-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105871 Change subject: Remove searchlimit preference .. Remove searchlimit preference Change-Id: Ib3dd2ba54261514b827d12a21536392530c7e02e --- M inclu

[MediaWiki-commits] [Gerrit] Clean up AnalysisConfigBuilder/MappingConfigBuilder - change (mediawiki...CirrusSearch)

2014-01-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105888 Change subject: Clean up AnalysisConfigBuilder/MappingConfigBuilder .. Clean up AnalysisConfigBuilder/MappingConfigBuilder * Remove global $wgL

[MediaWiki-commits] [Gerrit] No need to be static here - change (mediawiki...CirrusSearch)

2014-01-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105892 Change subject: No need to be static here .. No need to be static here Change-Id: I5f89fe0862ddb5a732e9ed16fc185747d1631b73 --- M maintenance/u

[MediaWiki-commits] [Gerrit] Refactor Connection::getPageType() - change (mediawiki...CirrusSearch)

2014-01-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105971 Change subject: Refactor Connection::getPageType() .. Refactor Connection::getPageType() Make callers specify the name at all times, swap param

[MediaWiki-commits] [Gerrit] WIP: Implement interwiki searches - change (mediawiki...CirrusSearch)

2014-01-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/105986 Change subject: WIP: Implement interwiki searches .. WIP: Implement interwiki searches Change-Id: I15c8f53184b3383c24fa8c513fd952eb22b05923 ---

[MediaWiki-commits] [Gerrit] Delete submodule Elastica/adding Elastic library - change (mediawiki...Elastica)

2014-01-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/106118 Change subject: Delete submodule Elastica/adding Elastic library .. Delete submodule Elastica/adding Elastic library Sub-submodules are a pain

[MediaWiki-commits] [Gerrit] Delete submodule Elastica/adding Elastic library - change (mediawiki...Elastica)

2014-01-07 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Delete submodule Elastica/adding Elastic library .. Delete submodule Elastica/adding Elastic library Sub-submodules are a pain in the butt for deployment purpose

[MediaWiki-commits] [Gerrit] Updating Elastica to master - change (mediawiki/core)

2014-01-07 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Updating Elastica to master .. Updating Elastica to master Change-Id: I1e015c4048bcdfe7142052c41c15fafa2914e06e --- M extensions/Elastica 1 file changed, 0 inser

[MediaWiki-commits] [Gerrit] Updating Elastica to master - change (mediawiki/core)

2014-01-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/106121 Change subject: Updating Elastica to master .. Updating Elastica to master Change-Id: I1e015c4048bcdfe7142052c41c15fafa2914e06e --- M extension

[MediaWiki-commits] [Gerrit] Make WikiPage::$mPreparedEdit public - change (mediawiki/core)

2014-01-07 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Make WikiPage::$mPreparedEdit public .. Make WikiPage::$mPreparedEdit public Partial revert of I2c34baaf8b64b20efa1bfa6ea356e0124c54 Change-Id: Id4e90c61294

[MediaWiki-commits] [Gerrit] Make WikiPage::$mPreparedEdit public - change (mediawiki/core)

2014-01-07 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Make WikiPage::$mPreparedEdit public .. Make WikiPage::$mPreparedEdit public Partial revert of I2c34baaf8b64b20efa1bfa6ea356e0124c54 Change-Id: Id4e90c61294

[MediaWiki-commits] [Gerrit] Update CirrusSearch to master - change (mediawiki/core)

2014-01-08 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Update CirrusSearch to master .. Update CirrusSearch to master Change-Id: I255f1b4fce57afd60d536e18cda33577bcfb56e0 --- M extensions/CirrusSearch 1 file changed,

[MediaWiki-commits] [Gerrit] Update CirrusSearch to master - change (mediawiki/core)

2014-01-08 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Update CirrusSearch to master .. Update CirrusSearch to master Change-Id: I193405f6ffafe8fd8be4648735b0c2c5d26406af --- M extensions/CirrusSearch 1 file changed,

[MediaWiki-commits] [Gerrit] Give dewiki and all wikibooks Cirrus BetaFeature - change (operations/mediawiki-config)

2014-01-08 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Give dewiki and all wikibooks Cirrus BetaFeature .. Give dewiki and all wikibooks Cirrus BetaFeature Change-Id: I378f218b800745af1ac090c409632988d374e21b --- M w

[MediaWiki-commits] [Gerrit] Declare visibility on all properties in ForkController - change (mediawiki/core)

2014-01-08 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/106442 Change subject: Declare visibility on all properties in ForkController .. Declare visibility on all properties in ForkController Grepped all of

[MediaWiki-commits] [Gerrit] Make it easy to get the number of the currently running child - change (mediawiki/core)

2014-01-08 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/106443 Change subject: Make it easy to get the number of the currently running child .. Make it easy to get the number of the currently running child

[MediaWiki-commits] [Gerrit] Remove ugly code duplication in ReindexForkController - change (mediawiki...CirrusSearch)

2014-01-08 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/106445 Change subject: Remove ugly code duplication in ReindexForkController .. Remove ugly code duplication in ReindexForkController Requires I2071f0

[MediaWiki-commits] [Gerrit] Limit searches at 500 per page - change (mediawiki/core)

2014-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/106553 Change subject: Limit searches at 500 per page .. Limit searches at 500 per page * 5000 search results in a single page is too many to be usefu

[MediaWiki-commits] [Gerrit] Remove searchidx2 from dsh groups - change (operations/puppet)

2014-01-09 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/106622 Change subject: Remove searchidx2 from dsh groups .. Remove searchidx2 from dsh groups Search in Tampa's been decomissioned already Change-Id:

[MediaWiki-commits] [Gerrit] Support setting timeout on bulk requests - change (mediawiki...Elastica)

2014-01-10 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Support setting timeout on bulk requests .. Support setting timeout on bulk requests Sent this upstream but we'd like this now rather than later. Change-Id: Ic3

[MediaWiki-commits] [Gerrit] Deletion jobs are also high priority - change (operations/puppet)

2014-01-13 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107184 Change subject: Deletion jobs are also high priority .. Deletion jobs are also high priority Change-Id: Ibc45f8e656f7ae91778a4f3ca48b5b53e471c8

[MediaWiki-commits] [Gerrit] Raise number of job runners by 1 per server - change (operations/puppet)

2014-01-13 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107189 Change subject: Raise number of job runners by 1 per server .. Raise number of job runners by 1 per server Change-Id: I8e3faeab10e48feee20ae3b0

[MediaWiki-commits] [Gerrit] Fix variable name - change (operations/mediawiki-config)

2014-01-13 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/107234 Change subject: Fix variable name .. Fix variable name Change-Id: Icf5d92820262279ee317c966994826899e4bf07b --- M wmf-config/CirrusSearch-commo

[MediaWiki-commits] [Gerrit] Remove duplicate submodule definitions - change (mediawiki/extensions)

2014-02-04 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111410 Change subject: Remove duplicate submodule definitions .. Remove duplicate submodule definitions Causes git submodule updates to fail with a cry

[MediaWiki-commits] [Gerrit] Remove duplicate submodule definitions - change (mediawiki/extensions)

2014-02-04 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Remove duplicate submodule definitions .. Remove duplicate submodule definitions Causes git submodule updates to fail with a cryptic: error: invalid key (newli

[MediaWiki-commits] [Gerrit] Get title from EditPage rather than $wgTitle - change (mediawiki...BayesianFilter)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111478 Change subject: Get title from EditPage rather than $wgTitle .. Get title from EditPage rather than $wgTitle Change-Id: I743e4f8e35ffea244c12a8c

[MediaWiki-commits] [Gerrit] The parser is never null - change (mediawiki...BiblioPlus)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111481 Change subject: The parser is never null .. The parser is never null Change-Id: Id57e8859858e57d906ea6ccbc860ef852c452590 --- M BiblioPlus.body.

[MediaWiki-commits] [Gerrit] $wgTitle is not needed here - change (mediawiki...BibManager)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111480 Change subject: $wgTitle is not needed here .. $wgTitle is not needed here Change-Id: I0af37c99a729a8bf4a0d3caba4046c61b0331bbc --- M includes/B

[MediaWiki-commits] [Gerrit] Once again, no need for $wgTitle - change (mediawiki...BreadCrumbs2)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111483 Change subject: Once again, no need for $wgTitle .. Once again, no need for $wgTitle Change-Id: I7b936c06791c3fa24dfd97073838148f0ea3dacd --- M

[MediaWiki-commits] [Gerrit] $wgTitle and $wgOut weren't needed here - change (mediawiki...CodeEditor)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111486 Change subject: $wgTitle and $wgOut weren't needed here .. $wgTitle and $wgOut weren't needed here EditPage::showForm::initial was wrong about i

[MediaWiki-commits] [Gerrit] Don't need $wgTitle or $wgParser here - change (mediawiki...ExtTab)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111488 Change subject: Don't need $wgTitle or $wgParser here .. Don't need $wgTitle or $wgParser here Change-Id: I8e16a11a75f0a86c4c1459b2b136d30f3c0a1

[MediaWiki-commits] [Gerrit] Use parser's title rather than $wgTitle - change (mediawiki...GoogleMaps)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111491 Change subject: Use parser's title rather than $wgTitle .. Use parser's title rather than $wgTitle Change-Id: I5bfe42c857ac2e6c8f8ea68f90aa6eff5

[MediaWiki-commits] [Gerrit] Remove unused $wgTitles - change (mediawiki...News)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111492 Change subject: Remove unused $wgTitles .. Remove unused $wgTitles Change-Id: I4aff44723473a89a18feda14fbce93ac25c7d19e --- M News.php M NewsRen

[MediaWiki-commits] [Gerrit] Remove some easily removed $wgTitles - change (mediawiki...LiquidThreads)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111496 Change subject: Remove some easily removed $wgTitles .. Remove some easily removed $wgTitles Change-Id: Ic4e5596a8551207d6d3d54f7447bcd9c4eb0154

[MediaWiki-commits] [Gerrit] Removed $wgTitle usages that were marked as todo - change (mediawiki...LinkFilter)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111497 Change subject: Removed $wgTitle usages that were marked as todo .. Removed $wgTitle usages that were marked as todo Change-Id: I0cb5d2515e267cb

[MediaWiki-commits] [Gerrit] The parser is never null :) - change (mediawiki...GraphViz)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111499 Change subject: The parser is never null :) .. The parser is never null :) Change-Id: I043896949e44966b5493e5d05a9ca08dfa268bf7 --- M GraphViz.p

[MediaWiki-commits] [Gerrit] Use titles already easily on hand - change (mediawiki...PollNY)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111500 Change subject: Use titles already easily on hand .. Use titles already easily on hand Change-Id: I31d3c7359021d27ad4e149411c91adde61db87e0 ---

[MediaWiki-commits] [Gerrit] Remove easily removed $wgTitles, SpecialPages and Articles h... - change (mediawiki...Wikilog)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111504 Change subject: Remove easily removed $wgTitles, SpecialPages and Articles have titles on hand .. Remove easily removed $wgTitles, SpecialPages

[MediaWiki-commits] [Gerrit] Remove some easily removed $wgTitles from BlueSpiceExtensions - change (mediawiki...BlueSpiceExtensions)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111506 Change subject: Remove some easily removed $wgTitles from BlueSpiceExtensions .. Remove some easily removed $wgTitles from BlueSpiceExtensions C

[MediaWiki-commits] [Gerrit] Remove most $wgTitles and $wgArticles - change (mediawiki...SemanticPageMaker)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111512 Change subject: Remove most $wgTitles and $wgArticles .. Remove most $wgTitles and $wgArticles Change-Id: I44d2d00aac0c81aacb599b213438ee1913deb

[MediaWiki-commits] [Gerrit] Remove a bunch of the $wgTitles in SemanticForms - change (mediawiki...SemanticForms)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111521 Change subject: Remove a bunch of the $wgTitles in SemanticForms .. Remove a bunch of the $wgTitles in SemanticForms This extension is one of th

[MediaWiki-commits] [Gerrit] Get title from article rather than $wgTitle - change (mediawiki...Video)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111529 Change subject: Get title from article rather than $wgTitle .. Get title from article rather than $wgTitle Change-Id: Ic12f34adf8f289dbaa7b450eb

[MediaWiki-commits] [Gerrit] Actually make Parser::pstPass2() private - change (mediawiki/core)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111535 Change subject: Actually make Parser::pstPass2() private .. Actually make Parser::pstPass2() private Nothing else uses this anywhere in SVN or G

[MediaWiki-commits] [Gerrit] Move blame for $wgTitle up one level to getUserSig() - change (mediawiki/core)

2014-02-05 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111567 Change subject: Move blame for $wgTitle up one level to getUserSig() .. Move blame for $wgTitle up one level to getUserSig() cleanSig() doesn't

[MediaWiki-commits] [Gerrit] Turn mediawiki/skins into a meta repo of skins - change (mediawiki/skins)

2014-02-06 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Turn mediawiki/skins into a meta repo of skins .. Turn mediawiki/skins into a meta repo of skins Bug: 60926 Change-Id: I520a6db575b1c66c663491ce3102a4c18b953cf3

[MediaWiki-commits] [Gerrit] Add .gitreview - change (mediawiki/skins)

2014-02-06 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Add .gitreview .. Add .gitreview Change-Id: I77097440aebd8f16d7e4f37939338303a99600f9 --- A .gitreview 1 file changed, 5 insertions(+), 0 deletions(-) Approvals

[MediaWiki-commits] [Gerrit] Experimentally enable interwiki searches for beta enwiki - change (operations/mediawiki-config)

2014-02-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111829 Change subject: Experimentally enable interwiki searches for beta enwiki .. Experimentally enable interwiki searches for beta enwiki Change-Id:

[MediaWiki-commits] [Gerrit] Obvious oversight: make interwiki cache time configurable - change (mediawiki...CirrusSearch)

2014-02-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111897 Change subject: Obvious oversight: make interwiki cache time configurable .. Obvious oversight: make interwiki cache time configurable Change-Id

[MediaWiki-commits] [Gerrit] Followup. Pressed save + merge too fast - change (mediawiki...CirrusSearch)

2014-02-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111898 Change subject: Followup. Pressed save + merge too fast .. Followup. Pressed save + merge too fast Change-Id: Iffd7b52f15779f730a7ffea83f96e82b4

[MediaWiki-commits] [Gerrit] Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79... - change (mediawiki/core)

2014-02-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111900 Change subject: Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 .. Reverting Math to known-good 2b8534793fad9db18fcdb9621d

[MediaWiki-commits] [Gerrit] Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79... - change (mediawiki/core)

2014-02-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111901 Change subject: Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 .. Reverting Math to known-good 2b8534793fad9db18fcdb9621d

[MediaWiki-commits] [Gerrit] Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79... - change (mediawiki/core)

2014-02-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111903 Change subject: Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 .. Reverting Math to known-good 2b8534793fad9db18fcdb9621d

[MediaWiki-commits] [Gerrit] Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79... - change (mediawiki/core)

2014-02-06 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 .. Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 Change-Id: I5ba48

[MediaWiki-commits] [Gerrit] Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79... - change (mediawiki/core)

2014-02-06 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 .. Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1 Change-Id: I5ba48

[MediaWiki-commits] [Gerrit] Revert "Reverting Math to known-good 2b8534793fad9db18fcdb96... - change (mediawiki/core)

2014-02-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111911 Change subject: Revert "Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1" .. Revert "Reverting Math to known-good 2b8534793

[MediaWiki-commits] [Gerrit] Revert "Reverting Math to known-good 2b8534793fad9db18fcdb96... - change (mediawiki/core)

2014-02-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111910 Change subject: Revert "Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1" .. Revert "Reverting Math to known-good 2b8534793

[MediaWiki-commits] [Gerrit] Revert "Reverting Math to known-good 2b8534793fad9db18fcdb96... - change (mediawiki/core)

2014-02-06 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Revert "Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1" .. Revert "Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1"

[MediaWiki-commits] [Gerrit] Revert "Reverting Math to known-good 2b8534793fad9db18fcdb96... - change (mediawiki/core)

2014-02-06 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Revert "Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1" .. Revert "Reverting Math to known-good 2b8534793fad9db18fcdb9621dc8d79ff36fdeb1"

[MediaWiki-commits] [Gerrit] WIP: Wrap texvc call in PoolCounter - change (mediawiki...Math)

2014-02-06 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/111916 Change subject: WIP: Wrap texvc call in PoolCounter .. WIP: Wrap texvc call in PoolCounter Change-Id: Iae9693d1948bec6dd08473bce3cb704f24338ff8

[MediaWiki-commits] [Gerrit] Make InterwikiResultsType implement instead of inherit - change (mediawiki...CirrusSearch)

2014-02-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112037 Change subject: Make InterwikiResultsType implement instead of inherit .. Make InterwikiResultsType implement instead of inherit Follows up ff4f

[MediaWiki-commits] [Gerrit] Document that via gitblit this repository is publicly access... - change (labs/private)

2014-02-07 Thread Chad (Code Review)
Chad has submitted this change and it was merged. Change subject: Document that via gitblit this repository is publicly accessible. .. Document that via gitblit this repository is publicly accessible. See: https://git.wikimedi

[MediaWiki-commits] [Gerrit] WIP: Remove LQT search - change (mediawiki...LiquidThreads)

2014-02-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112062 Change subject: WIP: Remove LQT search .. WIP: Remove LQT search It's bad and confusing and I don't want to support it in new search. Change-Id

[MediaWiki-commits] [Gerrit] Don't dump globals to stdout during a unit test - change (mediawiki/core)

2014-02-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112147 Change subject: Don't dump globals to stdout during a unit test .. Don't dump globals to stdout during a unit test Change-Id: I6060f92b4c97def9a

[MediaWiki-commits] [Gerrit] Fix profiling error - change (mediawiki...CirrusSearch)

2014-02-07 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112185 Change subject: Fix profiling error .. Fix profiling error Start profiling where it actually matters Change-Id: I85fff08f937abb3f8a42949fb97e29

[MediaWiki-commits] [Gerrit] Revert "Only pass strings to mysqli::real_escape_string" - change (mediawiki/core)

2014-02-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112501 Change subject: Revert "Only pass strings to mysqli::real_escape_string" .. Revert "Only pass strings to mysqli::real_escape_string" hhvm alread

[MediaWiki-commits] [Gerrit] Lower search cache expiry to 12 hours on all wikis - change (operations/mediawiki-config)

2014-02-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112577 Change subject: Lower search cache expiry to 12 hours on all wikis .. Lower search cache expiry to 12 hours on all wikis Ideally in Cirrus we co

[MediaWiki-commits] [Gerrit] Revoke key per request - change (operations/puppet)

2014-02-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112594 Change subject: Revoke key per request .. Revoke key per request Change-Id: Ib2429d9721e26ef569655a52a58a97aa0c925e41 --- M manifests/admins.pp

[MediaWiki-commits] [Gerrit] Revert "Limit searches at 500 per page" - change (mediawiki/core)

2014-02-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112615 Change subject: Revert "Limit searches at 500 per page" .. Revert "Limit searches at 500 per page" People seem to like large slow search pages.

[MediaWiki-commits] [Gerrit] Remove $wgMaintenanceScripts and friends - change (mediawiki/core)

2014-02-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112627 Change subject: Remove $wgMaintenanceScripts and friends .. Remove $wgMaintenanceScripts and friends Nothing ever used it--and rightly so--as it

[MediaWiki-commits] [Gerrit] Remove undocumented and unused searchx parameter - change (mediawiki/core)

2014-02-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112630 Change subject: Remove undocumented and unused searchx parameter .. Remove undocumented and unused searchx parameter Change-Id: Ib6ed378242558aa

[MediaWiki-commits] [Gerrit] Remove $wgMaintenanceScripts - change (mediawiki...Maintenance)

2014-02-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112634 Change subject: Remove $wgMaintenanceScripts .. Remove $wgMaintenanceScripts Nothing ever actually used it and core removes it in I2746500c Cha

[MediaWiki-commits] [Gerrit] Return early when page id is less than 1 - change (mediawiki/core)

2014-02-10 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112641 Change subject: Return early when page id is less than 1 .. Return early when page id is less than 1 Wasteful DB query when we know the page won

[MediaWiki-commits] [Gerrit] Revert "Non wikipedias to 1.23wmf12" - change (operations/mediawiki-config)

2014-02-11 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112755 Change subject: Revert "Non wikipedias to 1.23wmf12" .. Revert "Non wikipedias to 1.23wmf12" This actually turned all wikipedias to wmf11. This

[MediaWiki-commits] [Gerrit] Follow-up 94c3984: not all ResultTypes request text.word_count - change (mediawiki...CirrusSearch)

2014-02-11 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112819 Change subject: Follow-up 94c3984: not all ResultTypes request text.word_count .. Follow-up 94c3984: not all ResultTypes request text.word_count

[MediaWiki-commits] [Gerrit] WIP: Support interwiki searches in API - change (mediawiki/core)

2014-02-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112913 Change subject: WIP: Support interwiki searches in API .. WIP: Support interwiki searches in API Bug: 60975 Change-Id: I381c8681cabfa9ff7a73cbe0

[MediaWiki-commits] [Gerrit] Begin indexing namespace text forms in the database - change (mediawiki...CirrusSearch)

2014-02-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112914 Change subject: Begin indexing namespace text forms in the database .. Begin indexing namespace text forms in the database Will need this for in

[MediaWiki-commits] [Gerrit] Minor updates for settings with Elasticsearch 1.0 - change (mediawiki...CirrusSearch)

2014-02-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112940 Change subject: Minor updates for settings with Elasticsearch 1.0 .. Minor updates for settings with Elasticsearch 1.0 Change-Id: Ia6c9acbf1

[MediaWiki-commits] [Gerrit] WIP: Remove unused third parameter for wikiversions - change (operations/mediawiki-config)

2014-02-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/112955 Change subject: WIP: Remove unused third parameter for wikiversions .. WIP: Remove unused third parameter for wikiversions This doesn't seem to

[MediaWiki-commits] [Gerrit] Error message haiku++ - change (operations/mediawiki-config)

2014-02-12 Thread Chad (Code Review)
Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/113029 Change subject: Error message haiku++ .. Error message haiku++ Change-Id: I9620c7df2d7633dc2b321450e943835a10abdfd7 --- M docroot/noc/conf/highl

<    1   2   3   4   5   6   7   8   9   10   >