[MediaWiki-commits] [Gerrit] Deprecated Title::userIsWatching(); use User::isWatched() in... - change (mediawiki/core[master])

2012-06-29 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Deprecated Title::userIsWatching(); use User::isWatched() instead. .. Deprecated Title::userIsWatching(); use User::isWatched() instead. * The problem is that

[MediaWiki-commits] [Gerrit] Use ManualLogEntry instead of LogPage to add a new log entry... - change (mediawiki/core[master])

2012-07-01 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Use ManualLogEntry instead of LogPage to add a new log entry of old file version deletion. .. Use ManualLogEntry instead of LogPage to add a new log entry of old file

[MediaWiki-commits] [Gerrit] Use Linker::getInvalidTitleDescription() to display invalid ... - change (mediawiki/core[master])

2012-07-03 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Use Linker::getInvalidTitleDescription() to display invalid title entries in Special:Undelete. .. Use Linker::getInvalidTitleDescription() to display invalid title

[MediaWiki-commits] [Gerrit] (bug 38148) Fix E_WARNING in ChangesList.php line 1218 - change (mediawiki/core[master])

2012-07-03 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: (bug 38148) Fix E_WARNING in ChangesList.php line 1218 .. (bug 38148) Fix E_WARNING in ChangesList.php line 1218 The error is PHP Warning: explode() expects parameter

[MediaWiki-commits] [Gerrit] Pass objects to methods accepting them instead of relying on... - change (mediawiki/core[master])

2012-07-04 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Pass objects to methods accepting them instead of relying on global objects. .. Pass objects to methods accepting them instead of relying on global objects. * Pass

[MediaWiki-commits] [Gerrit] Pass the full context to the ApiMain instance from api.php. - change (mediawiki/core[master])

2012-07-06 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Pass the full context to the ApiMain instance from api.php. .. Pass the full context to the ApiMain instance from api.php. Passing only the WebRequest instance is not

[MediaWiki-commits] [Gerrit] Update messages.inc and rebuild MessagesEn.php. - change (mediawiki/core[master])

2012-07-07 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Update messages.inc and rebuild MessagesEn.php. .. Update messages.inc and rebuild MessagesEn.php. It allways annoys me to have lot of unwanted changes when changing

[MediaWiki-commits] [Gerrit] Pass the Language object to the wfMessage calls in LogPage::... - change (mediawiki/core[master])

2012-07-07 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Pass the Language object to the wfMessage calls in LogPage::getTitleLink() and LogPage::formatBlockFlags(). .. Pass the Language object to the wfMessage calls in

[MediaWiki-commits] [Gerrit] Fix for Ic74c7ba7 (c8c50eb): there's no reason to pass $this... - change (mediawiki/core[master])

2012-07-07 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Fix for Ic74c7ba7 (c8c50eb): there's no reason to pass $this by reference. .. Fix for Ic74c7ba7 (c8c50eb): there's no reason to pass $this by reference. Change-Id:

[MediaWiki-commits] [Gerrit] Improve documentation of maintenance scripts. - change (mediawiki/core[master])

2012-07-08 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Improve documentation of maintenance scripts. .. Improve documentation of maintenance scripts. Change-Id: I2433d23544e808e16f28805f93183b1af2409c94 --- M

[MediaWiki-commits] [Gerrit] Improve documentation of maintenance scripts. - change (mediawiki/core[master])

2012-07-10 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Improve documentation of maintenance scripts. .. Improve documentation of maintenance scripts. Change-Id: I0e2869970c46f4fd14b792f2978cc1ba9d8550be --- M

[MediaWiki-commits] [Gerrit] Use local context to get messages and time formatting method... - change (mediawiki/core[master])

2012-07-11 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Use local context to get messages and time formatting methods of Language class. .. Use local context to get messages and time formatting methods of Language class.

[MediaWiki-commits] [Gerrit] Documentation improvements in Exception.php. - change (mediawiki/core[master])

2012-07-12 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Documentation improvements in Exception.php. .. Documentation improvements in Exception.php. Change-Id: I645025c9acbb91df48bb0f1ee3859840195c5e56 --- M

[MediaWiki-commits] [Gerrit] Store the Title and User objects passed RecentChange::notify... - change (mediawiki/core[master])

2012-07-13 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Store the Title and User objects passed RecentChange::notify*() .. Store the Title and User objects passed RecentChange::notify*() * Set RecentChange::$mTitle when

[MediaWiki-commits] [Gerrit] Follow-up Ifa9c55b7 (58852d8): Change one more item to getWa... - change (mediawiki/core[master])

2012-07-14 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Follow-up Ifa9c55b7 (58852d8): Change one more item to getWatchedItem() .. Follow-up Ifa9c55b7 (58852d8): Change one more item to getWatchedItem() Change-Id:

[MediaWiki-commits] [Gerrit] For consistency of the interface, don't do expensive checks ... - change (mediawiki/core[master])

2012-07-14 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: For consistency of the interface, don't do expensive checks on page view. .. For consistency of the interface, don't do expensive checks on page view. Also replaced

[MediaWiki-commits] [Gerrit] (bug 36524) Show options are now remembered between succes... - change (mediawiki/core[master])

2012-07-16 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: (bug 36524) Show options are now remembered between successive clicks. .. (bug 36524) Show options are now remembered between successive clicks. The problem is that

[MediaWiki-commits] [Gerrit] Pass the local User object to Revision::userCan() - change (mediawiki/core[master])

2012-07-16 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Pass the local User object to Revision::userCan() .. Pass the local User object to Revision::userCan() Change-Id: Iffd857a577593642464371a988b7b7829d246748 --- M

[MediaWiki-commits] [Gerrit] Improve documentation of maintenance scripts. - change (mediawiki/core[master])

2012-07-16 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Improve documentation of maintenance scripts. .. Improve documentation of maintenance scripts. Change-Id: If0af9922ede902c2c6f18b627d5810f3e888c944 --- M

[MediaWiki-commits] [Gerrit] (bug 38406) Properly quote table names in DatabaseBase::tabl... - change (mediawiki/core[master])

2012-07-18 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: (bug 38406) Properly quote table names in DatabaseBase::tableName() .. (bug 38406) Properly quote table names in DatabaseBase::tableName() Currently the logic is the

[MediaWiki-commits] [Gerrit] Use Linker::userToolLinksRedContribs() in LogFormatter. - change (mediawiki/core[master])

2012-07-18 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Use Linker::userToolLinksRedContribs() in LogFormatter. .. Use Linker::userToolLinksRedContribs() in LogFormatter. It is much more self-describing to use that method

[MediaWiki-commits] [Gerrit] No need to call parseTitle() directly in MediaWiki::__constr... - change (mediawiki/core[master])

2012-07-19 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: No need to call parseTitle() directly in MediaWiki::__construct(). .. No need to call parseTitle() directly in MediaWiki::__construct(). We have MediaWiki::getTitle()

[MediaWiki-commits] [Gerrit] Use the WebRequest object instead of $_REQUEST - change (mediawiki...Configure[master])

2012-07-19 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Use the WebRequest object instead of $_REQUEST .. Use the WebRequest object instead of $_REQUEST Change-Id: I573fa847e322daae437c5b144be953dcd9014f04 --- M

[MediaWiki-commits] [Gerrit] Use the WebRequest object instead of $_REQUEST - change (mediawiki...Configure[master])

2012-07-19 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Use the WebRequest object instead of $_REQUEST .. Use the WebRequest object instead of $_REQUEST Change-Id: I573fa847e322daae437c5b144be953dcd9014f04 --- M

[MediaWiki-commits] [Gerrit] Use WebRequest instead of $_SERVER in EditPage. - change (mediawiki/core[master])

2012-07-20 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Use WebRequest instead of $_SERVER in EditPage. .. Use WebRequest instead of $_SERVER in EditPage. Change-Id: I30cdcffe8c520f9a4031c31e3e08db9b699da597 --- M

[MediaWiki-commits] [Gerrit] Execute jobs on all index.php requests. - change (mediawiki/core[master])

2012-07-21 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Execute jobs on all index.php requests. .. Execute jobs on all index.php requests. The problem is that currently deferred updates are not executed after action=ajax

[MediaWiki-commits] [Gerrit] Fix missing occurence change in I6b69919a (747e89e). - change (mediawiki/core[master])

2012-07-22 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Fix missing occurence change in I6b69919a (747e89e). .. Fix missing occurence change in I6b69919a (747e89e). The line above changed in that revision, but not this one,

[MediaWiki-commits] [Gerrit] Update SkinLegacy to use newer methods to create the file li... - change (mediawiki/core[master])

2012-07-24 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Update SkinLegacy to use newer methods to create the file link. .. Update SkinLegacy to use newer methods to create the file link. Linker::getInternalLinkAttributes()

[MediaWiki-commits] [Gerrit] Do checks in the correct order in Linker::getLinkColour(). - change (mediawiki/core[master])

2012-07-25 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Do checks in the correct order in Linker::getLinkColour(). .. Do checks in the correct order in Linker::getLinkColour(). There's no point doing potentially expensive

[MediaWiki-commits] [Gerrit] Use WikiPage::loadPageData() to reload data from the master. - change (mediawiki/core[master])

2012-07-25 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Use WikiPage::loadPageData() to reload data from the master. .. Use WikiPage::loadPageData() to reload data from the master. There's no need to do this using custom

[MediaWiki-commits] [Gerrit] Improve documentation of maintenance scripts. - change (mediawiki/core[master])

2012-07-25 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Improve documentation of maintenance scripts. .. Improve documentation of maintenance scripts. Change-Id: I93e80edcfc3dc2d5630f7514808cafc22daf39f7 --- M

[MediaWiki-commits] [Gerrit] Per request on translatewiki, fix description of $wgResource... - change (mediawiki...Configure[master])

2012-07-27 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Per request on translatewiki, fix description of $wgResourceLoaderDebug. .. Per request on translatewiki, fix description of $wgResourceLoaderDebug.

[MediaWiki-commits] [Gerrit] Use Linker::linkKnown() instead of Linker::link() with optio... - change (mediawiki/core[master])

2012-07-29 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Use Linker::linkKnown() instead of Linker::link() with options in Article. .. Use Linker::linkKnown() instead of Linker::link() with options in Article. Change-Id:

[MediaWiki-commits] [Gerrit] Add @since to new subclasses of MWException - change (mediawiki/core[master])

2012-07-31 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Add @since to new subclasses of MWException .. Add @since to new subclasses of MWException Change-Id: I9f87ba2ab00e4a68313a19823a20b10d55073e84 --- M

[MediaWiki-commits] [Gerrit] Fix logic error from Ia74ac399 (2ee4653). - change (mediawiki/core[master])

2012-07-31 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Fix logic error from Ia74ac399 (2ee4653). .. Fix logic error from Ia74ac399 (2ee4653). The views part of the table should only be displayed if view counters are *not*

[MediaWiki-commits] [Gerrit] Mark the history link on page deletion as known. - change (mediawiki/core[master])

2012-08-02 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Mark the history link on page deletion as known. .. Mark the history link on page deletion as known. Two reasons: - the page must exists to reach this part of the code

[MediaWiki-commits] [Gerrit] Improve documentation of maintenance scripts. - change (mediawiki/core[master])

2012-08-02 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Improve documentation of maintenance scripts. .. Improve documentation of maintenance scripts. Change-Id: I52ebe4d741109aef19cd8fa252243e2b6440565f --- M

[MediaWiki-commits] [Gerrit] Fixes to Special:Mostlinkedtemplates. - change (mediawiki/core[master])

2012-08-03 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Fixes to Special:Mostlinkedtemplates. .. Fixes to Special:Mostlinkedtemplates. - Don't execute the LinkBatch if there are no rows. - Checks for invalid titles and

[MediaWiki-commits] [Gerrit] Change from wgMiserMode to isCached on Special:WithoutInterw... - change (mediawiki/core[master])

2012-08-03 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Change from wgMiserMode to isCached on Special:WithoutInterwikis .. Change from wgMiserMode to isCached on Special:WithoutInterwikis This makes it clearer why

[MediaWiki-commits] [Gerrit] Make rebuildLocalisationCache.php also obey --memory-limit i... - change (mediawiki/core[master])

2012-08-03 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Make rebuildLocalisationCache.php also obey --memory-limit if set. .. Make rebuildLocalisationCache.php also obey --memory-limit if set. Same as

[MediaWiki-commits] [Gerrit] Add a test for paragraphs with extra newline spacing - change (mediawiki/core[master])

2012-08-04 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Add a test for paragraphs with extra newline spacing .. Add a test for paragraphs with extra newline spacing This test simply documents the current PHP parser

[MediaWiki-commits] [Gerrit] Improve documentation of maintenance scripts. - change (mediawiki/core[master])

2012-08-04 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Improve documentation of maintenance scripts. .. Improve documentation of maintenance scripts. Change-Id: I557f85e8526a3e4b48107fbf299ff39f6af1ac12 --- M

[MediaWiki-commits] [Gerrit] Follow-up SVN r98012: pass Title objects to LogEventsList::s... - change (mediawiki/core[master])

2012-08-05 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Follow-up SVN r98012: pass Title objects to LogEventsList::showLogExtract(). .. Follow-up SVN r98012: pass Title objects to LogEventsList::showLogExtract(). It seems

[MediaWiki-commits] [Gerrit] Support GENDER in 'passwordreset-emailelement'. - change (mediawiki/core[master])

2012-08-05 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Support GENDER in 'passwordreset-emailelement'. .. Support GENDER in 'passwordreset-emailelement'. Change-Id: I1b14dbb8d1fb06c688064af4a6a02e03293dc5f0 --- M

[MediaWiki-commits] [Gerrit] Use a better message when a revision is not found. - change (mediawiki/core[master])

2012-08-05 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Use a better message when a revision is not found. .. Use a better message when a revision is not found. This comes from

[MediaWiki-commits] [Gerrit] In WebRequest, don't use isset() to check that a variable is... - change (mediawiki/core[master])

2012-08-06 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: In WebRequest, don't use isset() to check that a variable is null .. In WebRequest, don't use isset() to check that a variable is null Change-Id:

[MediaWiki-commits] [Gerrit] Move message importtext into the fieldset - change (mediawiki/core[master])

2012-08-06 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Move message importtext into the fieldset .. Move message importtext into the fieldset Than it is the same place as message import-interwiki-text Change-Id:

[MediaWiki-commits] [Gerrit] Allowing Message objects to be passed as error page title. - change (mediawiki/core[master])

2012-08-07 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Allowing Message objects to be passed as error page title. .. Allowing Message objects to be passed as error page title. Changed OutputPage::showErrorPage() so

[MediaWiki-commits] [Gerrit] Added WebRequest::getMethod() to get the HTTP method of the ... - change (mediawiki/core[master])

2012-08-07 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Added WebRequest::getMethod() to get the HTTP method of the request. .. Added WebRequest::getMethod() to get the HTTP method of the request. This is to replace the

[MediaWiki-commits] [Gerrit] .gitignore: Add .DS_Store for Mac OS X; Organize and a-Z sor... - change (mediawiki/core[master])

2012-08-07 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: .gitignore: Add .DS_Store for Mac OS X; Organize and a-Z sort. .. .gitignore: Add .DS_Store for Mac OS X; Organize and a-Z sort. Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused variables/function values returned - change (mediawiki/core[master])

2012-08-08 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Remove unused variables/function values returned .. Remove unused variables/function values returned Fix trailing whitespace Change-Id:

[MediaWiki-commits] [Gerrit] Fix checks to pass or display return to links in Special:U... - change (mediawiki/core[master])

2012-08-08 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Fix checks to pass or display return to links in Special:UserLogin. .. Fix checks to pass or display return to links in Special:UserLogin. Currently it is not

[MediaWiki-commits] [Gerrit] (bug 24521) Move hard coded code error! to messages - change (mediawiki/core[master])

2012-08-08 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: (bug 24521) Move hard coded code error! to messages .. (bug 24521) Move hard coded code error! to messages Change-Id: I43f064ce577da9918fea7430e5bda0853af236e3

[MediaWiki-commits] [Gerrit] Fix title inside form on Special:ListFiles - change (mediawiki/core[master])

2012-08-08 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Fix title inside form on Special:ListFiles .. Fix title inside form on Special:ListFiles The form reused the title from the query, but when calling the page

[MediaWiki-commits] [Gerrit] Improve documentation of maintenance scripts. - change (mediawiki/core[master])

2012-08-09 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Improve documentation of maintenance scripts. .. Improve documentation of maintenance scripts. Change-Id: I21b4fb873e88026108754eb7206e62c82648df0e --- M

[MediaWiki-commits] [Gerrit] Added @since tags - change (mediawiki/core[master])

2012-08-09 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Added @since tags .. Added @since tags Change-Id: I90717790ac159713e48de7eb89649c3bcbce1d87 --- M includes/Message.php 1 file changed, 2 insertions(+), 0

[MediaWiki-commits] [Gerrit] Fix documentation for hook AbortNewAccount. - change (mediawiki/core[master])

2012-08-09 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Fix documentation for hook AbortNewAccount. .. Fix documentation for hook AbortNewAccount. Change-Id: I8982f5f512eec0742fe5232c2e68396e9b1c95f4 --- M

[MediaWiki-commits] [Gerrit] Use Message class where possible. - change (mediawiki...ConfirmAccount[master])

2012-08-09 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Use Message class where possible. .. Use Message class where possible. Also used local context instead of global methods where possible, removed a paragraph of

[MediaWiki-commits] [Gerrit] Fix typo: occured - occurred. - change (mediawiki/core[master])

2012-08-10 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Fix typo: occured - occurred. .. Fix typo: occured - occurred. Change-Id: I5e66fdd52791487f81796ae1965ac31c94b36182 --- M includes/Exception.php M

[MediaWiki-commits] [Gerrit] Trim $dbSupport in WebInstallerPage.php - change (mediawiki/core[master])

2012-08-10 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Trim $dbSupport in WebInstallerPage.php .. Trim $dbSupport in WebInstallerPage.php This removes the trailing \n which introduces an extra new line. Change-Id:

[MediaWiki-commits] [Gerrit] Pass the parameters to the error message in UploadStash::sta... - change (mediawiki/core[master])

2012-08-10 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Pass the parameters to the error message in UploadStash::stashFile(). .. Pass the parameters to the error message in UploadStash::stashFile(). Currently it shows the

[MediaWiki-commits] [Gerrit] Use WikiPage::makeParserOptions() where possible. - change (mediawiki/core[master])

2012-08-11 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Use WikiPage::makeParserOptions() where possible. .. Use WikiPage::makeParserOptions() where possible. - This is needed to for I90965346 ((bug 37453) Move

[MediaWiki-commits] [Gerrit] Improve documentation of maintenance scripts. - change (mediawiki/core[master])

2012-08-11 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Improve documentation of maintenance scripts. .. Improve documentation of maintenance scripts. Change-Id: I29dd0d4d18ea3d1b9795fac2f0b74b04ef2d955a --- M

[MediaWiki-commits] [Gerrit] Improve handling of the required argument in HTMLForm field ... - change (mediawiki/core[master])

2012-08-12 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Improve handling of the required argument in HTMLForm field definitions .. Improve handling of the required argument in HTMLForm field definitions array(

[MediaWiki-commits] [Gerrit] Follow-up I1fc22b16 (06db921): Cast required parameter to ... - change (mediawiki/core[master])

2012-08-12 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Follow-up I1fc22b16 (06db921): Cast required parameter to boolean .. Follow-up I1fc22b16 (06db921): Cast required parameter to boolean Change-Id:

[MediaWiki-commits] [Gerrit] Added missing @since tags and fixed style - change (mediawiki/core[master])

2012-08-12 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Added missing @since tags and fixed style .. Added missing @since tags and fixed style Change-Id: I8941345be8f754bda40f4c36cf2082ca3d408c50 --- M

[MediaWiki-commits] [Gerrit] Localisation updates from http://translatewiki.net. - change (mediawiki/core[master])

2012-08-12 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Localisation updates from http://translatewiki.net. .. Localisation updates from http://translatewiki.net. Change-Id: I18d4e10c42bbda638eeb887a473e5ee2ee90909f

[MediaWiki-commits] [Gerrit] Remove workaround hack for php bug 46944 - change (mediawiki/core[master])

2012-08-12 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Remove workaround hack for php bug 46944 .. Remove workaround hack for php bug 46944 https://bugs.php.net/bug.php?id=46944 Fixed for 5.3.0, and as we require

[MediaWiki-commits] [Gerrit] Fix documentation of WikiPage::doDeleteArticle(Real)?() - change (mediawiki/core[master])

2012-08-13 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Fix documentation of WikiPage::doDeleteArticle(Real)?() .. Fix documentation of WikiPage::doDeleteArticle(Real)?() - The $suppress parameter is a boolean indicating

[MediaWiki-commits] [Gerrit] Localisation updates from http://translatewiki.net. - change (mediawiki/core[master])

2012-08-13 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Localisation updates from http://translatewiki.net. .. Localisation updates from http://translatewiki.net. Change-Id: I655913611a5ec051ee4c01d3c2e20245e2f647c0

[MediaWiki-commits] [Gerrit] Follow-up I47412b67 (dde8471): convert string query to array - change (mediawiki/core[master])

2012-08-14 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Follow-up I47412b67 (dde8471): convert string query to array .. Follow-up I47412b67 (dde8471): convert string query to array If we detect and warn that the $query

[MediaWiki-commits] [Gerrit] Follow-up I47412b67: pass an array of query parameters to Li... - change (mediawiki/core[master])

2012-08-14 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Follow-up I47412b67: pass an array of query parameters to Linker::link() .. Follow-up I47412b67: pass an array of query parameters to Linker::link() Change-Id:

[MediaWiki-commits] [Gerrit] PHP 5.4 has JSON_PRETTY_PRINT - change (mediawiki/core[master])

2012-08-14 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: PHP 5.4 has JSON_PRETTY_PRINT .. PHP 5.4 has JSON_PRETTY_PRINT Use this conditionally when $isHtml is true, and is also running on PHP = 5.4. Else return

[MediaWiki-commits] [Gerrit] Pass the 'returntoquery' parameter when clicking on a langua... - change (mediawiki/core[master])

2012-08-15 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Pass the 'returntoquery' parameter when clicking on a language selector link. .. Pass the 'returntoquery' parameter when clicking on a language selector link. Also

[MediaWiki-commits] [Gerrit] Follow-up I6b0c58fb (d50b416): add message to messages.inc - change (mediawiki/core[master])

2012-08-15 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Follow-up I6b0c58fb (d50b416): add message to messages.inc .. Follow-up I6b0c58fb (d50b416): add message to messages.inc Change-Id:

[MediaWiki-commits] [Gerrit] (bug 37638) Remove calls to deprecated LogPage::logName meth... - change (mediawiki/core[master])

2012-08-15 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: (bug 37638) Remove calls to deprecated LogPage::logName method. .. (bug 37638) Remove calls to deprecated LogPage::logName method. The LogPage::logName method

[MediaWiki-commits] [Gerrit] MessageCache::destroyInstance() is static. - change (mediawiki/core[master])

2012-08-16 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: MessageCache::destroyInstance() is static. .. MessageCache::destroyInstance() is static. So there is no point calling it using

[MediaWiki-commits] [Gerrit] ExpandTemplates extension maintenance. - change (mediawiki...ExpandTemplates[master])

2012-08-16 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: ExpandTemplates extension maintenance. .. ExpandTemplates extension maintenance. * Use Message class and local context where possible. * Update .gitignore. *

[MediaWiki-commits] [Gerrit] Display a return to Special:Watchlist instead of main page i... - change (mediawiki/core[master])

2012-08-16 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Display a return to Special:Watchlist instead of main page in Special:EditWatchlist. .. Display a return to Special:Watchlist instead of main page in

[MediaWiki-commits] [Gerrit] Some API errors didn't include the prefix of the module in p... - change (mediawiki/core[master])

2012-08-17 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Some API errors didn't include the prefix of the module in parameter related error messages .. Some API errors didn't include the prefix of the module in

[MediaWiki-commits] [Gerrit] Replace deprecated tt with code. - change (mediawiki/core[master])

2012-08-17 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Replace deprecated tt with code. .. Replace deprecated tt with code. Change-Id: I5e15628e34dd0473d2f6ce17509ed17e94257dfa --- M

[MediaWiki-commits] [Gerrit] Remove presentational HTML tags in favour of code, samp ... - change (mediawiki/core[master])

2012-08-17 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Remove presentational HTML tags in favour of code, samp and strong. .. Remove presentational HTML tags in favour of code, samp and strong. Change-Id:

[MediaWiki-commits] [Gerrit] Add missing unit of measure in inline CSS. - change (mediawiki/core[master])

2012-08-17 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Add missing unit of measure in inline CSS. .. Add missing unit of measure in inline CSS. Change-Id: I0baceb98302d1af58270d13713b4366eda7c6dc3 --- M

[MediaWiki-commits] [Gerrit] Add version of deprecation for wfAppendQuery() and suggest a... - change (mediawiki/core[master])

2012-08-17 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Add version of deprecation for wfAppendQuery() and suggest alternative. .. Add version of deprecation for wfAppendQuery() and suggest alternative. Change-Id:

[MediaWiki-commits] [Gerrit] Fix return to display on Special:UserLogin. - change (mediawiki/core[master])

2012-08-18 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Fix return to display on Special:UserLogin. .. Fix return to display on Special:UserLogin. - Do not use $wgRedirectOnLogin on permissions error message - Added

[MediaWiki-commits] [Gerrit] Use LogFormatter to format rights log. - change (mediawiki/core[master])

2012-08-18 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Use LogFormatter to format rights log. .. Use LogFormatter to format rights log. * Has to keep actual messages for IRC notification * Catch really old log entries with

[MediaWiki-commits] [Gerrit] Cannot make method visibility lower than super's. - change (mediawiki/core[master])

2012-08-18 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Cannot make method visibility lower than super's. .. Cannot make method visibility lower than super's. Change-Id: I8ed3f3bad954dd03bd80d23954e31ee5429c04fe ---

[MediaWiki-commits] [Gerrit] Make OrphanStats::getDB()'s signature compatible with parent... - change (mediawiki/core[master])

2012-08-18 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Make OrphanStats::getDB()'s signature compatible with parent. .. Make OrphanStats::getDB()'s signature compatible with parent. Was throwing Strict Standards:

[MediaWiki-commits] [Gerrit] Follow-up I774a89d6 (2fabea7): use $this-msg() in HistoryAc... - change (mediawiki/core[master])

2012-08-19 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Follow-up I774a89d6 (2fabea7): use $this-msg() in HistoryAction .. Follow-up I774a89d6 (2fabea7): use $this-msg() in HistoryAction Change-Id:

[MediaWiki-commits] [Gerrit] Use ErrorPageError extension in Special:Preferences. - change (mediawiki/core[master])

2012-08-19 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Use ErrorPageError extension in Special:Preferences. .. Use ErrorPageError extension in Special:Preferences. For consistency with other errors, use an exception when

[MediaWiki-commits] [Gerrit] Removing unused method Status::getXML. - change (mediawiki/core[master])

2012-08-19 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Removing unused method Status::getXML. .. Removing unused method Status::getXML. Removed Status::getXML and its single usage in one of the phpunit maintenance

[MediaWiki-commits] [Gerrit] Add 'list' to allowed input attributes in HTMLForm - change (mediawiki/core[master])

2012-08-19 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Add 'list' to allowed input attributes in HTMLForm .. Add 'list' to allowed input attributes in HTMLForm Add 'list' (new in HTML5 as part of datalist) to the

[MediaWiki-commits] [Gerrit] Add lang and hreflang attributes to the language links of th... - change (mediawiki/core[master])

2012-08-19 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Add lang and hreflang attributes to the language links of the login page. .. Add lang and hreflang attributes to the language links of the login page. -

[MediaWiki-commits] [Gerrit] (bug 22749) Create Special:MostInterwikis - change (mediawiki/core[master])

2012-08-19 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: (bug 22749) Create Special:MostInterwikis .. (bug 22749) Create Special:MostInterwikis This special pages counts all langlinks and shows the pages with the

[MediaWiki-commits] [Gerrit] Solve some i18n issues in Special:EmailUser. - change (mediawiki/core[master])

2012-08-19 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Solve some i18n issues in Special:EmailUser. .. Solve some i18n issues in Special:EmailUser. * Page title was also E-mail this user if no target was provided.

[MediaWiki-commits] [Gerrit] Some fixes for Ia1878588 (236307f) - change (mediawiki/core[master])

2012-08-19 Thread IAlex (Code Review)
IAlex has uploaded a new change for review. Change subject: Some fixes for Ia1878588 (236307f) .. Some fixes for Ia1878588 (236307f) - Fix special page case to not throw warning about case mismatch - Use $this-page instead of

[MediaWiki-commits] [Gerrit] Replace some deprecated method calls. - change (mediawiki/core[master])

2012-08-19 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Replace some deprecated method calls. .. Replace some deprecated method calls. Change-Id: Id4beca7b6821139fcc319c5694917e68668835ee --- M

[MediaWiki-commits] [Gerrit] Replace deprecated wfMsg* calls with Message class calls. - change (mediawiki/core[master])

2012-08-19 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Replace deprecated wfMsg* calls with Message class calls. .. Replace deprecated wfMsg* calls with Message class calls. Change-Id:

[MediaWiki-commits] [Gerrit] Numerous fixes for Ia1878588. Escaped output was most import... - change (mediawiki/core[master])

2012-08-20 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Numerous fixes for Ia1878588. Escaped output was most important. .. Numerous fixes for Ia1878588. Escaped output was most important. * Output was not escaped.

[MediaWiki-commits] [Gerrit] Bug 26069 title element is Error for all error pages add... - change (mediawiki/core[master])

2012-08-20 Thread IAlex (Code Review)
IAlex has submitted this change and it was merged. Change subject: Bug 26069 title element is Error for all error pages added more meaningful heading .. Bug 26069 title element is Error for all error pages added more

  1   2   3   4   5   6   7   8   >