[MediaWiki-commits] [Gerrit] Cleared ResourceLoader blob store after update.php finishes. - change (mediawiki/core)

2013-04-09 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/58462 Change subject: Cleared ResourceLoader blob store after update.php finishes. .. Cleared ResourceLoader blob store after update.php finishes.

[MediaWiki-commits] [Gerrit] startup: Lower blacklist for Firefox from 4 to 3. - change (mediawiki/core)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/58465 Change subject: startup: Lower blacklist for Firefox from 4 to 3. .. startup: Lower blacklist for Firefox from 4 to 3. Though Firefox is 3.6

[MediaWiki-commits] [Gerrit] startup: Lower blacklist for Firefox from 4 to 3. - change (mediawiki/core)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/58466 Change subject: startup: Lower blacklist for Firefox from 4 to 3. .. startup: Lower blacklist for Firefox from 4 to 3. Though Firefox is 3.6

[MediaWiki-commits] [Gerrit] phpcs: Clean up settings - change (mediawiki...codesniffer)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/58637 Change subject: phpcs: Clean up settings .. phpcs: Clean up settings A rough take on our coding style. Loosening it up a bit here, tightening

[MediaWiki-commits] [Gerrit] phpcs: Ignore *.i18n.php (installer) - change (integration/jenkins-job-builder-config)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/58638 Change subject: phpcs: Ignore *.i18n.php (installer) .. phpcs: Ignore *.i18n.php (installer) Change-Id: Ic0277f00aaeea077b6369364bee9a7fc41f6

[MediaWiki-commits] [Gerrit] phpcs: Ignore *.i18n.php (installer) - change (integration/jenkins-job-builder-config)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: phpcs: Ignore *.i18n.php (installer) .. phpcs: Ignore *.i18n.php (installer) Change-Id: Ic0277f00aaeea077b6369364bee9a7fc41f6abb5 --- M macro.yaml 1 file chan

[MediaWiki-commits] [Gerrit] phpcs: Clean up settings - change (mediawiki...codesniffer)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: phpcs: Clean up settings .. phpcs: Clean up settings A rough take on our coding style. Loosening it up a bit here, tightening it a bit there. I've commenting

[MediaWiki-commits] [Gerrit] Update mwcodesniffer submodule - change (integration/jenkins)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/58639 Change subject: Update mwcodesniffer submodule .. Update mwcodesniffer submodule Change-Id: I6b2b72b96df802137d9f80c63e22d40ceefbd377 --- M t

[MediaWiki-commits] [Gerrit] Update mwcodesniffer submodule - change (integration/jenkins)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Update mwcodesniffer submodule .. Update mwcodesniffer submodule Change-Id: I6b2b72b96df802137d9f80c63e22d40ceefbd377 --- M tools/mwcodesniffer 1 file changed

[MediaWiki-commits] [Gerrit] Gitignore: Add beta- and mediawiki-vagrant- workspace - change (integration/jenkins)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/58640 Change subject: Gitignore: Add beta- and mediawiki-vagrant- workspace .. Gitignore: Add beta- and mediawiki-vagrant- workspace Change-Id: Ia0

[MediaWiki-commits] [Gerrit] Gitignore: Add beta- and mediawiki-vagrant- workspace - change (integration/jenkins)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Gitignore: Add beta- and mediawiki-vagrant- workspace .. Gitignore: Add beta- and mediawiki-vagrant- workspace Change-Id: Ia076541cc631c2eb4156983ff31f9f60871

[MediaWiki-commits] [Gerrit] Add mwext-VisualEditor-doc-test to check pipeline - change (integration/zuul-config)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/58653 Change subject: Add mwext-VisualEditor-doc-test to check pipeline .. Add mwext-VisualEditor-doc-test to check pipeline Change-Id: If11b416298

[MediaWiki-commits] [Gerrit] Add mwext-VisualEditor-doc-test to check pipeline - change (integration/zuul-config)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Add mwext-VisualEditor-doc-test to check pipeline .. Add mwext-VisualEditor-doc-test to check pipeline Change-Id: If11b4162988f779f3391678dc26bcddb9d8ca072 --

[MediaWiki-commits] [Gerrit] Revert "Add mwext-VisualEditor-doc-test to check pipeline" - change (integration/zuul-config)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/58654 Change subject: Revert "Add mwext-VisualEditor-doc-test to check pipeline" .. Revert "Add mwext-VisualEditor-doc-test to check pipeline" This

[MediaWiki-commits] [Gerrit] Revert "Add mwext-VisualEditor-doc-test to check pipeline" - change (integration/zuul-config)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Revert "Add mwext-VisualEditor-doc-test to check pipeline" .. Revert "Add mwext-VisualEditor-doc-test to check pipeline" This reverts commit 1a4fd974a8028f2c5

[MediaWiki-commits] [Gerrit] phpcs: Fix Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore ... - change (mediawiki/core)

2013-04-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/58662 Change subject: phpcs: Fix Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore violations .. phpcs: Fix Squiz.WhiteSpace.ScopeClosingBrace.Conte

[MediaWiki-commits] [Gerrit] noc: Bring back langlist and wikiversions.dat as non-txt - change (operations/mediawiki-config)

2013-04-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59017 Change subject: noc: Bring back langlist and wikiversions.dat as non-txt .. noc: Bring back langlist and wikiversions.dat as non-txt Also fix

[MediaWiki-commits] [Gerrit] Set export TERM=xterm for bash macros that use tput. - change (integration/jenkins-job-builder-config)

2013-04-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59018 Change subject: Set export TERM=xterm for bash macros that use tput. .. Set export TERM=xterm for bash macros that use tput. Jenkins has TERM

[MediaWiki-commits] [Gerrit] Set export TERM=xterm for bash macros that use tput. - change (integration/jenkins-job-builder-config)

2013-04-12 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Set export TERM=xterm for bash macros that use tput. .. Set export TERM=xterm for bash macros that use tput. Jenkins has TERM=dumb as of recently (which was a

[MediaWiki-commits] [Gerrit] Restrict Verified to JenkinsBot - change (integration/jenkins-job-builder-config)

2013-04-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59020 Change subject: Restrict Verified to JenkinsBot .. Restrict Verified to JenkinsBot Change-Id: If87b9af6bcc8af6912c33010b84081d4267f5ba6 --- A

[MediaWiki-commits] [Gerrit] Restrict Verified to JenkinsBot - change (integration/jenkins-job-builder-config)

2013-04-12 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Restrict Verified to JenkinsBot .. Restrict Verified to JenkinsBot Change-Id: If87b9af6bcc8af6912c33010b84081d4267f5ba6 --- A groups M project.config 2 files

[MediaWiki-commits] [Gerrit] Adding empty jshint configuration - change (mediawiki...TemplateSandbox)

2013-04-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59022 Change subject: Adding empty jshint configuration .. Adding empty jshint configuration Change-Id: I7c990fed4c899440b43422861e10b275a3e97214 -

[MediaWiki-commits] [Gerrit] JSHint: Re-order jshintrc options to split common from proje... - change (mediawiki/core)

2013-04-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59026 Change subject: JSHint: Re-order jshintrc options to split common from project settings .. JSHint: Re-order jshintrc options to split common

[MediaWiki-commits] [Gerrit] JSHint: Re-order jshintrc options to split common from proje... - change (mediawiki...VisualEditor)

2013-04-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59027 Change subject: JSHint: Re-order jshintrc options to split common from project settings .. JSHint: Re-order jshintrc options to split common

[MediaWiki-commits] [Gerrit] Rename Args class to MwCodeUtilsArgs - change (mediawiki...code-utils)

2013-04-13 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59028 Change subject: Rename Args class to MwCodeUtilsArgs .. Rename Args class to MwCodeUtilsArgs To avoid conflicts in lint.php, since parsekit i

[MediaWiki-commits] [Gerrit] noc: Add missing entries to createTxtFileSymlinks.sh - change (operations/mediawiki-config)

2013-04-13 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59033 Change subject: noc: Add missing entries to createTxtFileSymlinks.sh .. noc: Add missing entries to createTxtFileSymlinks.sh The apache-confi

[MediaWiki-commits] [Gerrit] noc: Refactor highlight.php to be simpler and less mo... - change (operations/mediawiki-config)

2013-04-13 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59034 Change subject: noc: Refactor highlight.php to be simpler and less more secure .. noc: Refactor highlight.php to be simpler and less more sec

[MediaWiki-commits] [Gerrit] lint.php: Fix broken calls inside mwCodeUtils_lintDir - change (mediawiki...code-utils)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59088 Change subject: lint.php: Fix broken calls inside mwCodeUtils_lintDir .. lint.php: Fix broken calls inside mwCodeUtils_lintDir Change-Id: I29

[MediaWiki-commits] [Gerrit] lint.php: Fix broken calls inside mwCodeUtils_lintDir - change (mediawiki...code-utils)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: lint.php: Fix broken calls inside mwCodeUtils_lintDir .. lint.php: Fix broken calls inside mwCodeUtils_lintDir Change-Id: I29bb66da79bcad6039df51b587380ff649e

[MediaWiki-commits] [Gerrit] Add submodule for mediawiki/tools/code-utils.git - change (integration/jenkins)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59089 Change subject: Add submodule for mediawiki/tools/code-utils.git .. Add submodule for mediawiki/tools/code-utils.git Change-Id: I1a09e248ff45

[MediaWiki-commits] [Gerrit] mediawiki-core-lint: Use phplint macro instead of repeating ... - change (integration/jenkins-job-builder-config)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59090 Change subject: mediawiki-core-lint: Use phplint macro instead of repeating ant builder call .. mediawiki-core-lint: Use phplint macro instea

[MediaWiki-commits] [Gerrit] Add submodule for mediawiki/tools/code-utils.git - change (integration/jenkins)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Add submodule for mediawiki/tools/code-utils.git .. Add submodule for mediawiki/tools/code-utils.git Change-Id: I1a09e248ff458480f4ff3e62bb667479be0b66f6 ---

[MediaWiki-commits] [Gerrit] Sample commit for Jenkins - change (mediawiki...UploadWizard)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59104 Change subject: Sample commit for Jenkins .. Sample commit for Jenkins Change-Id: I061199241bb39ecf547a5ae19ee1dc3c5be2296d --- M UploadWizar

[MediaWiki-commits] [Gerrit] Ensure 'php5-parsekit' in contint - change (operations/puppet)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59105 Change subject: Ensure 'php5-parsekit' in contint .. Ensure 'php5-parsekit' in contint code-utils/lint.php in Jenkins is failing without it.

[MediaWiki-commits] [Gerrit] Add bin/lint.php symlink - change (integration/jenkins)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59107 Change subject: Add bin/lint.php symlink .. Add bin/lint.php symlink Change-Id: Ie0194efa06fc3ba3b9dd6f3f6c3c8c269a444de0 --- A bin/lint.php

[MediaWiki-commits] [Gerrit] Add bin/lint.php symlink - change (integration/jenkins)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Add bin/lint.php symlink .. Add bin/lint.php symlink Change-Id: Ie0194efa06fc3ba3b9dd6f3f6c3c8c269a444de0 --- A bin/lint.php 1 file changed, 1 insertion(+), 0

[MediaWiki-commits] [Gerrit] mwext-{ext-name}-lint: use-zuul instead of use-zuul-for-mwext - change (integration/jenkins-job-builder-config)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59109 Change subject: mwext-{ext-name}-lint: use-zuul instead of use-zuul-for-mwext .. mwext-{ext-name}-lint: use-zuul instead of use-zuul-for-mwext

[MediaWiki-commits] [Gerrit] phplint macro: Use lint.php instead of php -l - change (integration/jenkins-job-builder-config)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59110 Change subject: phplint macro: Use lint.php instead of php -l .. phplint macro: Use lint.php instead of php -l Also, as part of switching awa

[MediaWiki-commits] [Gerrit] mediawiki-core-lint: Use phplint macro instead of repeating ... - change (integration/jenkins-job-builder-config)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: mediawiki-core-lint: Use phplint macro instead of repeating ant builder call .. mediawiki-core-lint: Use phplint macro instead of repeating ant builder call

[MediaWiki-commits] [Gerrit] mwext-{ext-name}-lint: use-zuul instead of use-zuul-for-mwext - change (integration/jenkins-job-builder-config)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: mwext-{ext-name}-lint: use-zuul instead of use-zuul-for-mwext .. mwext-{ext-name}-lint: use-zuul instead of use-zuul-for-mwext No need to put it in extensions

[MediaWiki-commits] [Gerrit] phplint macro: Use lint.php instead of php -l - change (integration/jenkins-job-builder-config)

2013-04-14 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: phplint macro: Use lint.php instead of php -l .. phplint macro: Use lint.php instead of php -l Also, as part of switching away from Ant and php -l, fixed the

[MediaWiki-commits] [Gerrit] Apply fixes from 4796af1fa7 old php-lint Ant target - change (integration/jenkins)

2013-04-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59112 Change subject: Apply fixes from 4796af1fa7 old php-lint Ant target .. Apply fixes from 4796af1fa7 old php-lint Ant target parsekit has becom

[MediaWiki-commits] [Gerrit] Apply fixes from 4796af1fa7 to old php-lint Ant target - change (integration/jenkins)

2013-04-15 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Apply fixes from 4796af1fa7 to old php-lint Ant target .. Apply fixes from 4796af1fa7 to old php-lint Ant target parsekit has become (or always was) unreliabl

[MediaWiki-commits] [Gerrit] sync: Commit changes to config files not maintained by JJB - change (integration/jenkins)

2013-04-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59114 Change subject: sync: Commit changes to config files not maintained by JJB .. sync: Commit changes to config files not maintained by JJB Chan

[MediaWiki-commits] [Gerrit] sync: Commit changes to config files not maintained by JJB - change (integration/jenkins)

2013-04-15 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: sync: Commit changes to config files not maintained by JJB .. sync: Commit changes to config files not maintained by JJB Change-Id: Ia7307b8356cf3080fdb2b795f

[MediaWiki-commits] [Gerrit] phplint macro: Revert back to using php -l - change (integration/jenkins-job-builder-config)

2013-04-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59115 Change subject: phplint macro: Revert back to using php -l .. phplint macro: Revert back to using php -l Follows-up 4796af1. See also I8f8dfc

[MediaWiki-commits] [Gerrit] phplint macro: Revert back to using php -l - change (integration/jenkins-job-builder-config)

2013-04-15 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: phplint macro: Revert back to using php -l .. phplint macro: Revert back to using php -l Follows-up 4796af1. See also I8f8dfc2ca9 in integration/jenkins. Cha

[MediaWiki-commits] [Gerrit] docgen: Disable parallel processing - change (mediawiki...VisualEditor)

2013-04-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59337 Change subject: docgen: Disable parallel processing .. docgen: Disable parallel processing Change-Id: Icdf92b4c0aed27f7bfc5d37c6abeedf60a2b7f

[MediaWiki-commits] [Gerrit] QUnit macro: Include curl fetch for headers and html snippet - change (integration/jenkins-job-builder-config)

2013-04-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59358 Change subject: QUnit macro: Include curl fetch for headers and html snippet .. QUnit macro: Include curl fetch for headers and html snippet

[MediaWiki-commits] [Gerrit] jshint: Allow global mw to be set in mediawiki.js - change (mediawiki/core)

2013-04-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59360 Change subject: jshint: Allow global mw to be set in mediawiki.js .. jshint: Allow global mw to be set in mediawiki.js In master this has bee

[MediaWiki-commits] [Gerrit] jshint: Allow global mw to be set in mediawiki.js - change (mediawiki/core)

2013-04-16 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: jshint: Allow global mw to be set in mediawiki.js .. jshint: Allow global mw to be set in mediawiki.js In master this has been cleaned up, but in REL1_20 we s

[MediaWiki-commits] [Gerrit] QUnit macro: Include curl fetch for headers and html snippet - change (integration/jenkins-job-builder-config)

2013-04-16 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: QUnit macro: Include curl fetch for headers and html snippet .. QUnit macro: Include curl fetch for headers and html snippet Should help in trying to determin

[MediaWiki-commits] [Gerrit] (DRAFT) Add unit tests. - change (mediawiki...TemplateData)

2013-04-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59396 Change subject: (DRAFT) Add unit tests. .. (DRAFT) Add unit tests. Change-Id: I5a15080f1f924451a9dde8af96ea2922011981ec --- M TemplateData.ho

[MediaWiki-commits] [Gerrit] TemplateData: Add phpunit, remove jshint - change (integration/zuul-config)

2013-04-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59578 Change subject: TemplateData: Add phpunit, remove jshint .. TemplateData: Add phpunit, remove jshint Since all jobs start with a merge, -merg

[MediaWiki-commits] [Gerrit] TemplateData: Add phpunit, remove jshint - change (integration/zuul-config)

2013-04-16 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: TemplateData: Add phpunit, remove jshint .. TemplateData: Add phpunit, remove jshint Since all jobs start with a merge, -merge has become obsolete. Change-Id

[MediaWiki-commits] [Gerrit] TemplateData: Fix syntax error in If185f1079 - change (integration/zuul-config)

2013-04-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59594 Change subject: TemplateData: Fix syntax error in If185f1079 .. TemplateData: Fix syntax error in If185f1079 Looks like we need a better lint

[MediaWiki-commits] [Gerrit] TemplateData: Fix syntax error in If185f1079 - change (integration/zuul-config)

2013-04-16 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: TemplateData: Fix syntax error in If185f1079 .. TemplateData: Fix syntax error in If185f1079 Looks like we need a better linter! Change-Id: If812580af6037061

[MediaWiki-commits] [Gerrit] ExtraSettings.php: Some debugging for MediaWiki installs in ... - change (integration/jenkins)

2013-04-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59609 Change subject: ExtraSettings.php: Some debugging for MediaWiki installs in Jenkins .. ExtraSettings.php: Some debugging for MediaWiki instal

[MediaWiki-commits] [Gerrit] ExtraSettings.php: Some debugging for MediaWiki installs in ... - change (integration/jenkins)

2013-04-17 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: ExtraSettings.php: Some debugging for MediaWiki installs in Jenkins .. ExtraSettings.php: Some debugging for MediaWiki installs in Jenkins Change-Id: Idbfe21

[MediaWiki-commits] [Gerrit] Sync 1.21 release notes from master - change (mediawiki/core)

2013-04-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59623 Change subject: Sync 1.21 release notes from master .. Sync 1.21 release notes from master These were part of change I5e6f7d48 and were commi

[MediaWiki-commits] [Gerrit] Gitignore: Add /ssd, which has been mounted over here at gal... - change (integration/docroot)

2013-04-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59754 Change subject: Gitignore: Add /ssd, which has been mounted over here at gallium .. Gitignore: Add /ssd, which has been mounted over here at g

[MediaWiki-commits] [Gerrit] Gitignore: Add /ssd, which has been mounted over here at gal... - change (integration/docroot)

2013-04-17 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Gitignore: Add /ssd, which has been mounted over here at gallium .. Gitignore: Add /ssd, which has been mounted over here at gallium Change-Id: Ib91c189a7b5cd

[MediaWiki-commits] [Gerrit] JSHint: Vote in Echo, add job for UniversalLanguageSelector - change (integration/zuul-config)

2013-04-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59762 Change subject: JSHint: Vote in Echo, add job for UniversalLanguageSelector .. JSHint: Vote in Echo, add job for UniversalLanguageSelector Tr

[MediaWiki-commits] [Gerrit] JSHint: Vote in Echo, add job for UniversalLanguageSelector - change (integration/zuul-config)

2013-04-17 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: JSHint: Vote in Echo, add job for UniversalLanguageSelector .. JSHint: Vote in Echo, add job for UniversalLanguageSelector TranslationNotifications not yet, b

[MediaWiki-commits] [Gerrit] Update .jshintrc - change (mediawiki...UniversalLanguageSelector)

2013-04-17 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Update .jshintrc .. Update .jshintrc Change-Id: I9e2add1dac6bf76b4efc0bdf799b731333b28376 --- M .jshintrc 1 file changed, 24 insertions(+), 13 deletions(-) A

[MediaWiki-commits] [Gerrit] notifytranslators.js: Fix broken closure - change (mediawiki...TranslationNotifications)

2013-04-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59783 Change subject: notifytranslators.js: Fix broken closure .. notifytranslators.js: Fix broken closure This was doing the following: jQuer

[MediaWiki-commits] [Gerrit] ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs - change (integration/jenkins)

2013-04-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/59989 Change subject: ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs .. ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs Change-Id: Ib9

[MediaWiki-commits] [Gerrit] ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs - change (integration/jenkins)

2013-04-19 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs .. ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs Change-Id: Ib96fccf1ffb501466d592d5fb43f0e97d9b

[MediaWiki-commits] [Gerrit] ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs - change (integration/jenkins)

2013-04-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60015 Change subject: ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs .. ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs Follows-up Ib9

[MediaWiki-commits] [Gerrit] ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs - change (integration/jenkins)

2013-04-19 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs .. ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs Follows-up Ib96fccf1ffb50. Change-Id: I4c981cf

[MediaWiki-commits] [Gerrit] ViewPageTarget: Refactor 'replace' tabLayout - change (mediawiki...VisualEditor)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60241 Change subject: ViewPageTarget: Refactor 'replace' tabLayout .. ViewPageTarget: Refactor 'replace' tabLayout The 'add' tabLayout path is pret

[MediaWiki-commits] [Gerrit] mediawiki.util: Fix roundtripping of tooltip in portlet links - change (mediawiki/core)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60247 Change subject: mediawiki.util: Fix roundtripping of tooltip in portlet links .. mediawiki.util: Fix roundtripping of tooltip in portlet links

[MediaWiki-commits] [Gerrit] Monobook: Remove unused file FF2Fixes.css - change (mediawiki/core)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60254 Change subject: Monobook: Remove unused file FF2Fixes.css .. Monobook: Remove unused file FF2Fixes.css As of Id8214c6a5 and Ia54dd738b (per b

[MediaWiki-commits] [Gerrit] mediawiki.log: Add to jsduck index - change (mediawiki/core)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60264 Change subject: mediawiki.log: Add to jsduck index .. mediawiki.log: Add to jsduck index And fixing warnings as a result of it being in the i

[MediaWiki-commits] [Gerrit] Implement mw.log.warn and mw.log.deprecate - change (mediawiki/core)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60265 Change subject: Implement mw.log.warn and mw.log.deprecate .. Implement mw.log.warn and mw.log.deprecate Change-Id: I1eadd01d7086aecb1bdf7e95

[MediaWiki-commits] [Gerrit] wikibits: Deprecate useragent and tooltip/accesskey globals - change (mediawiki/core)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60266 Change subject: wikibits: Deprecate useragent and tooltip/accesskey globals .. wikibits: Deprecate useragent and tooltip/accesskey globals Ch

[MediaWiki-commits] [Gerrit] wikibits: Deprecate checkboxShiftClick globals - change (mediawiki/core)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60267 Change subject: wikibits: Deprecate checkboxShiftClick globals .. wikibits: Deprecate checkboxShiftClick globals Change-Id: I72aac6111b9be974

[MediaWiki-commits] [Gerrit] wikibits: Wrap jsMsg in mw.log.deprecate - change (mediawiki/core)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60268 Change subject: wikibits: Wrap jsMsg in mw.log.deprecate .. wikibits: Wrap jsMsg in mw.log.deprecate No release notes since it was already de

[MediaWiki-commits] [Gerrit] wikibits: Pass JSHint - change (mediawiki/core)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60269 Change subject: wikibits: Pass JSHint .. wikibits: Pass JSHint Change-Id: I95897e01b339c16abdd12190129d2b343be43d30 --- M .jshintignore M ski

[MediaWiki-commits] [Gerrit] mwext-TranslationNotifications: Voting for phpunit and jshint - change (integration/zuul-config)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60294 Change subject: mwext-TranslationNotifications: Voting for phpunit and jshint .. mwext-TranslationNotifications: Voting for phpunit and jshint

[MediaWiki-commits] [Gerrit] mwext-TranslationNotifications: Voting for phpunit and jshint - change (integration/zuul-config)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: mwext-TranslationNotifications: Voting for phpunit and jshint .. mwext-TranslationNotifications: Voting for phpunit and jshint These are now stable. Change-I

[MediaWiki-commits] [Gerrit] TemplateDataBlob: Fix getHtml exception - change (mediawiki...TemplateData)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60315 Change subject: TemplateDataBlob: Fix getHtml exception .. TemplateDataBlob: Fix getHtml exception getHtml failed with a PHP exception in Htm

[MediaWiki-commits] [Gerrit] TemplateDataBlob: Implement cache versioning - change (mediawiki...TemplateData)

2013-04-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/60316 Change subject: TemplateDataBlob: Implement cache versioning .. TemplateDataBlob: Implement cache versioning I ran into countless random exce

[MediaWiki-commits] [Gerrit] ViewPageTarget: Bind callback in onSerialize like in onShowC... - change (mediawiki...VisualEditor)

2013-05-08 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/62847 Change subject: ViewPageTarget: Bind callback in onSerialize like in onShowChanges .. ViewPageTarget: Bind callback in onSerialize like in on

[MediaWiki-commits] [Gerrit] Fix various path inflexibilities and inconsistencies - change (operations/mediawiki-config)

2013-05-08 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/62923 Change subject: Fix various path inflexibilities and inconsistencies .. Fix various path inflexibilities and inconsistencies - MWVersion.php#

[MediaWiki-commits] [Gerrit] populateWikiversions: Use MULTIVER_COMMON_HOME instead of /h... - change (operations/mediawiki-config)

2013-05-08 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/62926 Change subject: populateWikiversions: Use MULTIVER_COMMON_HOME instead of /h/w/common .. populateWikiversions: Use MULTIVER_COMMON_HOME inste

[MediaWiki-commits] [Gerrit] TemplateDataBlob: Implement 'type' and 'label' - change (mediawiki...TemplateData)

2013-05-08 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/62936 Change subject: TemplateDataBlob: Implement 'type' and 'label' .. TemplateDataBlob: Implement 'type' and 'label' InterfaceText now defaults t

[MediaWiki-commits] [Gerrit] TemplateDataBlob: Improve error handling - change (mediawiki...TemplateData)

2013-05-08 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/62937 Change subject: TemplateDataBlob: Improve error handling .. TemplateDataBlob: Improve error handling For invalid keys, pass property path, no

[MediaWiki-commits] [Gerrit] mwext-CentralAuth-jslint: Enable voting - change (integration/zuul-config)

2013-05-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/63379 Change subject: mwext-CentralAuth-jslint: Enable voting .. mwext-CentralAuth-jslint: Enable voting Change-Id: Ic22d7c6cb811fd7e303efbea2dde7f

[MediaWiki-commits] [Gerrit] mwext-CentralAuth-jslint: Enable voting - change (integration/zuul-config)

2013-05-12 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: mwext-CentralAuth-jslint: Enable voting .. mwext-CentralAuth-jslint: Enable voting Change-Id: Ic22d7c6cb811fd7e303efbea2dde7f8d71a0a551 --- M layout.yaml 1 fi

[MediaWiki-commits] [Gerrit] OutputPage: Guard jQuery.ready() against absence of jQuery - change (mediawiki/core)

2013-05-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/63740 Change subject: OutputPage: Guard jQuery.ready() against absence of jQuery .. OutputPage: Guard jQuery.ready() against absence of jQuery We a

[MediaWiki-commits] [Gerrit] docs: Consistency use "since" phrasing in @deprecated - change (mediawiki/core)

2013-05-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/63813 Change subject: docs: Consistency use "since" phrasing in @deprecated .. docs: Consistency use "since" phrasing in @deprecated Most are alrea

[MediaWiki-commits] [Gerrit] docs: Remove odd colons after @todo - change (mediawiki/core)

2013-05-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/63816 Change subject: docs: Remove odd colons after @todo .. docs: Remove odd colons after @todo Most were this way already: https://doc.wikimedia.

[MediaWiki-commits] [Gerrit] ve.ce.Surface: Append phantoms to overlay instead of surface - change (mediawiki...VisualEditor)

2013-05-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/63901 Change subject: ve.ce.Surface: Append phantoms to overlay instead of surface .. ve.ce.Surface: Append phantoms to overlay instead of surface

[MediaWiki-commits] [Gerrit] spec: Update specification for Set structure - change (mediawiki...TemplateData)

2013-05-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/63973 Change subject: spec: Update specification for Set structure .. spec: Update specification for Set structure * Inside a Set object, label is

[MediaWiki-commits] [Gerrit] spec: Update specification for InterfaceText structure - change (mediawiki...TemplateData)

2013-05-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/63974 Change subject: spec: Update specification for InterfaceText structure .. spec: Update specification for InterfaceText structure Since we now

[MediaWiki-commits] [Gerrit] tests: Reformat tests, evaluate status in addition to I/O - change (mediawiki...TemplateData)

2013-05-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/63992 Change subject: tests: Reformat tests, evaluate status in addition to I/O .. tests: Reformat tests, evaluate status in addition to I/O Previo

[MediaWiki-commits] [Gerrit] Implement Sets - change (mediawiki...TemplateData)

2013-05-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/63999 Change subject: Implement Sets .. Implement Sets Change-Id: I93a0ba7287fec6e5566994d03dff1d8eaeeb8430 --- M TemplateDataBlob.php M spec.templ

[MediaWiki-commits] [Gerrit] Enable mwext-TemplateData-phpcs-HEAD - change (integration/zuul-config)

2013-05-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/64056 Change subject: Enable mwext-TemplateData-phpcs-HEAD .. Enable mwext-TemplateData-phpcs-HEAD Change-Id: I0ea73ca1439c8aa6015d66a28828a47f984d

[MediaWiki-commits] [Gerrit] Enable mwext-TemplateData-phpcs-HEAD - change (integration/zuul-config)

2013-05-16 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Enable mwext-TemplateData-phpcs-HEAD .. Enable mwext-TemplateData-phpcs-HEAD Change-Id: I0ea73ca1439c8aa6015d66a28828a47f984d56ed --- M layout.yaml 1 file cha

<    4   5   6   7   8   9   10   11   12   13   >