Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58462
Change subject: Cleared ResourceLoader blob store after update.php finishes.
..
Cleared ResourceLoader blob store after update.php finishes.
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58465
Change subject: startup: Lower blacklist for Firefox from 4 to 3.
..
startup: Lower blacklist for Firefox from 4 to 3.
Though Firefox is 3.6
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58466
Change subject: startup: Lower blacklist for Firefox from 4 to 3.
..
startup: Lower blacklist for Firefox from 4 to 3.
Though Firefox is 3.6
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58637
Change subject: phpcs: Clean up settings
..
phpcs: Clean up settings
A rough take on our coding style. Loosening it up a bit here,
tightening
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58638
Change subject: phpcs: Ignore *.i18n.php (installer)
..
phpcs: Ignore *.i18n.php (installer)
Change-Id: Ic0277f00aaeea077b6369364bee9a7fc41f6
Krinkle has submitted this change and it was merged.
Change subject: phpcs: Ignore *.i18n.php (installer)
..
phpcs: Ignore *.i18n.php (installer)
Change-Id: Ic0277f00aaeea077b6369364bee9a7fc41f6abb5
---
M macro.yaml
1 file chan
Krinkle has submitted this change and it was merged.
Change subject: phpcs: Clean up settings
..
phpcs: Clean up settings
A rough take on our coding style. Loosening it up a bit here,
tightening it a bit there.
I've commenting
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58639
Change subject: Update mwcodesniffer submodule
..
Update mwcodesniffer submodule
Change-Id: I6b2b72b96df802137d9f80c63e22d40ceefbd377
---
M t
Krinkle has submitted this change and it was merged.
Change subject: Update mwcodesniffer submodule
..
Update mwcodesniffer submodule
Change-Id: I6b2b72b96df802137d9f80c63e22d40ceefbd377
---
M tools/mwcodesniffer
1 file changed
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58640
Change subject: Gitignore: Add beta- and mediawiki-vagrant- workspace
..
Gitignore: Add beta- and mediawiki-vagrant- workspace
Change-Id: Ia0
Krinkle has submitted this change and it was merged.
Change subject: Gitignore: Add beta- and mediawiki-vagrant- workspace
..
Gitignore: Add beta- and mediawiki-vagrant- workspace
Change-Id: Ia076541cc631c2eb4156983ff31f9f60871
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58653
Change subject: Add mwext-VisualEditor-doc-test to check pipeline
..
Add mwext-VisualEditor-doc-test to check pipeline
Change-Id: If11b416298
Krinkle has submitted this change and it was merged.
Change subject: Add mwext-VisualEditor-doc-test to check pipeline
..
Add mwext-VisualEditor-doc-test to check pipeline
Change-Id: If11b4162988f779f3391678dc26bcddb9d8ca072
--
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58654
Change subject: Revert "Add mwext-VisualEditor-doc-test to check pipeline"
..
Revert "Add mwext-VisualEditor-doc-test to check pipeline"
This
Krinkle has submitted this change and it was merged.
Change subject: Revert "Add mwext-VisualEditor-doc-test to check pipeline"
..
Revert "Add mwext-VisualEditor-doc-test to check pipeline"
This reverts commit 1a4fd974a8028f2c5
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58662
Change subject: phpcs: Fix Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore
violations
..
phpcs: Fix Squiz.WhiteSpace.ScopeClosingBrace.Conte
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59017
Change subject: noc: Bring back langlist and wikiversions.dat as non-txt
..
noc: Bring back langlist and wikiversions.dat as non-txt
Also fix
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59018
Change subject: Set export TERM=xterm for bash macros that use tput.
..
Set export TERM=xterm for bash macros that use tput.
Jenkins has TERM
Krinkle has submitted this change and it was merged.
Change subject: Set export TERM=xterm for bash macros that use tput.
..
Set export TERM=xterm for bash macros that use tput.
Jenkins has TERM=dumb as of recently (which was a
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59020
Change subject: Restrict Verified to JenkinsBot
..
Restrict Verified to JenkinsBot
Change-Id: If87b9af6bcc8af6912c33010b84081d4267f5ba6
---
A
Krinkle has submitted this change and it was merged.
Change subject: Restrict Verified to JenkinsBot
..
Restrict Verified to JenkinsBot
Change-Id: If87b9af6bcc8af6912c33010b84081d4267f5ba6
---
A groups
M project.config
2 files
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59022
Change subject: Adding empty jshint configuration
..
Adding empty jshint configuration
Change-Id: I7c990fed4c899440b43422861e10b275a3e97214
-
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59026
Change subject: JSHint: Re-order jshintrc options to split common from project
settings
..
JSHint: Re-order jshintrc options to split common
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59027
Change subject: JSHint: Re-order jshintrc options to split common from project
settings
..
JSHint: Re-order jshintrc options to split common
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59028
Change subject: Rename Args class to MwCodeUtilsArgs
..
Rename Args class to MwCodeUtilsArgs
To avoid conflicts in lint.php, since parsekit i
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59033
Change subject: noc: Add missing entries to createTxtFileSymlinks.sh
..
noc: Add missing entries to createTxtFileSymlinks.sh
The apache-confi
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59034
Change subject: noc: Refactor highlight.php to be simpler and less more
secure
..
noc: Refactor highlight.php to be simpler and less more sec
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59088
Change subject: lint.php: Fix broken calls inside mwCodeUtils_lintDir
..
lint.php: Fix broken calls inside mwCodeUtils_lintDir
Change-Id: I29
Krinkle has submitted this change and it was merged.
Change subject: lint.php: Fix broken calls inside mwCodeUtils_lintDir
..
lint.php: Fix broken calls inside mwCodeUtils_lintDir
Change-Id: I29bb66da79bcad6039df51b587380ff649e
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59089
Change subject: Add submodule for mediawiki/tools/code-utils.git
..
Add submodule for mediawiki/tools/code-utils.git
Change-Id: I1a09e248ff45
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59090
Change subject: mediawiki-core-lint: Use phplint macro instead of repeating ant
builder call
..
mediawiki-core-lint: Use phplint macro instea
Krinkle has submitted this change and it was merged.
Change subject: Add submodule for mediawiki/tools/code-utils.git
..
Add submodule for mediawiki/tools/code-utils.git
Change-Id: I1a09e248ff458480f4ff3e62bb667479be0b66f6
---
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59104
Change subject: Sample commit for Jenkins
..
Sample commit for Jenkins
Change-Id: I061199241bb39ecf547a5ae19ee1dc3c5be2296d
---
M UploadWizar
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59105
Change subject: Ensure 'php5-parsekit' in contint
..
Ensure 'php5-parsekit' in contint
code-utils/lint.php in Jenkins is failing without it.
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59107
Change subject: Add bin/lint.php symlink
..
Add bin/lint.php symlink
Change-Id: Ie0194efa06fc3ba3b9dd6f3f6c3c8c269a444de0
---
A bin/lint.php
Krinkle has submitted this change and it was merged.
Change subject: Add bin/lint.php symlink
..
Add bin/lint.php symlink
Change-Id: Ie0194efa06fc3ba3b9dd6f3f6c3c8c269a444de0
---
A bin/lint.php
1 file changed, 1 insertion(+), 0
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59109
Change subject: mwext-{ext-name}-lint: use-zuul instead of use-zuul-for-mwext
..
mwext-{ext-name}-lint: use-zuul instead of use-zuul-for-mwext
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59110
Change subject: phplint macro: Use lint.php instead of php -l
..
phplint macro: Use lint.php instead of php -l
Also, as part of switching awa
Krinkle has submitted this change and it was merged.
Change subject: mediawiki-core-lint: Use phplint macro instead of repeating ant
builder call
..
mediawiki-core-lint: Use phplint macro instead of repeating ant builder call
Krinkle has submitted this change and it was merged.
Change subject: mwext-{ext-name}-lint: use-zuul instead of use-zuul-for-mwext
..
mwext-{ext-name}-lint: use-zuul instead of use-zuul-for-mwext
No need to put it in extensions
Krinkle has submitted this change and it was merged.
Change subject: phplint macro: Use lint.php instead of php -l
..
phplint macro: Use lint.php instead of php -l
Also, as part of switching away from Ant and php -l, fixed the
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59112
Change subject: Apply fixes from 4796af1fa7 old php-lint Ant target
..
Apply fixes from 4796af1fa7 old php-lint Ant target
parsekit has becom
Krinkle has submitted this change and it was merged.
Change subject: Apply fixes from 4796af1fa7 to old php-lint Ant target
..
Apply fixes from 4796af1fa7 to old php-lint Ant target
parsekit has become (or always was) unreliabl
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59114
Change subject: sync: Commit changes to config files not maintained by JJB
..
sync: Commit changes to config files not maintained by JJB
Chan
Krinkle has submitted this change and it was merged.
Change subject: sync: Commit changes to config files not maintained by JJB
..
sync: Commit changes to config files not maintained by JJB
Change-Id: Ia7307b8356cf3080fdb2b795f
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59115
Change subject: phplint macro: Revert back to using php -l
..
phplint macro: Revert back to using php -l
Follows-up 4796af1. See also I8f8dfc
Krinkle has submitted this change and it was merged.
Change subject: phplint macro: Revert back to using php -l
..
phplint macro: Revert back to using php -l
Follows-up 4796af1. See also I8f8dfc2ca9 in integration/jenkins.
Cha
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59337
Change subject: docgen: Disable parallel processing
..
docgen: Disable parallel processing
Change-Id: Icdf92b4c0aed27f7bfc5d37c6abeedf60a2b7f
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59358
Change subject: QUnit macro: Include curl fetch for headers and html snippet
..
QUnit macro: Include curl fetch for headers and html snippet
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59360
Change subject: jshint: Allow global mw to be set in mediawiki.js
..
jshint: Allow global mw to be set in mediawiki.js
In master this has bee
Krinkle has submitted this change and it was merged.
Change subject: jshint: Allow global mw to be set in mediawiki.js
..
jshint: Allow global mw to be set in mediawiki.js
In master this has been cleaned up, but in REL1_20 we s
Krinkle has submitted this change and it was merged.
Change subject: QUnit macro: Include curl fetch for headers and html snippet
..
QUnit macro: Include curl fetch for headers and html snippet
Should help in trying to determin
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59396
Change subject: (DRAFT) Add unit tests.
..
(DRAFT) Add unit tests.
Change-Id: I5a15080f1f924451a9dde8af96ea2922011981ec
---
M TemplateData.ho
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59578
Change subject: TemplateData: Add phpunit, remove jshint
..
TemplateData: Add phpunit, remove jshint
Since all jobs start with a merge, -merg
Krinkle has submitted this change and it was merged.
Change subject: TemplateData: Add phpunit, remove jshint
..
TemplateData: Add phpunit, remove jshint
Since all jobs start with a merge, -merge has become obsolete.
Change-Id
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59594
Change subject: TemplateData: Fix syntax error in If185f1079
..
TemplateData: Fix syntax error in If185f1079
Looks like we need a better lint
Krinkle has submitted this change and it was merged.
Change subject: TemplateData: Fix syntax error in If185f1079
..
TemplateData: Fix syntax error in If185f1079
Looks like we need a better linter!
Change-Id: If812580af6037061
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59609
Change subject: ExtraSettings.php: Some debugging for MediaWiki installs in
Jenkins
..
ExtraSettings.php: Some debugging for MediaWiki instal
Krinkle has submitted this change and it was merged.
Change subject: ExtraSettings.php: Some debugging for MediaWiki installs in
Jenkins
..
ExtraSettings.php: Some debugging for MediaWiki installs in Jenkins
Change-Id: Idbfe21
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59623
Change subject: Sync 1.21 release notes from master
..
Sync 1.21 release notes from master
These were part of change I5e6f7d48 and were commi
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59754
Change subject: Gitignore: Add /ssd, which has been mounted over here at gallium
..
Gitignore: Add /ssd, which has been mounted over here at g
Krinkle has submitted this change and it was merged.
Change subject: Gitignore: Add /ssd, which has been mounted over here at gallium
..
Gitignore: Add /ssd, which has been mounted over here at gallium
Change-Id: Ib91c189a7b5cd
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59762
Change subject: JSHint: Vote in Echo, add job for UniversalLanguageSelector
..
JSHint: Vote in Echo, add job for UniversalLanguageSelector
Tr
Krinkle has submitted this change and it was merged.
Change subject: JSHint: Vote in Echo, add job for UniversalLanguageSelector
..
JSHint: Vote in Echo, add job for UniversalLanguageSelector
TranslationNotifications not yet, b
Krinkle has submitted this change and it was merged.
Change subject: Update .jshintrc
..
Update .jshintrc
Change-Id: I9e2add1dac6bf76b4efc0bdf799b731333b28376
---
M .jshintrc
1 file changed, 24 insertions(+), 13 deletions(-)
A
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59783
Change subject: notifytranslators.js: Fix broken closure
..
notifytranslators.js: Fix broken closure
This was doing the following:
jQuer
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59989
Change subject: ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs
..
ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs
Change-Id: Ib9
Krinkle has submitted this change and it was merged.
Change subject: ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs
..
ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs
Change-Id: Ib96fccf1ffb501466d592d5fb43f0e97d9b
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60015
Change subject: ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs
..
ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs
Follows-up Ib9
Krinkle has submitted this change and it was merged.
Change subject: ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs
..
ExtraSettings.php: Set wgTmpDirectory to dir in tmpfs
Follows-up Ib96fccf1ffb50.
Change-Id: I4c981cf
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60241
Change subject: ViewPageTarget: Refactor 'replace' tabLayout
..
ViewPageTarget: Refactor 'replace' tabLayout
The 'add' tabLayout path is pret
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60247
Change subject: mediawiki.util: Fix roundtripping of tooltip in portlet links
..
mediawiki.util: Fix roundtripping of tooltip in portlet links
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60254
Change subject: Monobook: Remove unused file FF2Fixes.css
..
Monobook: Remove unused file FF2Fixes.css
As of Id8214c6a5 and Ia54dd738b (per b
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60264
Change subject: mediawiki.log: Add to jsduck index
..
mediawiki.log: Add to jsduck index
And fixing warnings as a result of it being in the i
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60265
Change subject: Implement mw.log.warn and mw.log.deprecate
..
Implement mw.log.warn and mw.log.deprecate
Change-Id: I1eadd01d7086aecb1bdf7e95
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60266
Change subject: wikibits: Deprecate useragent and tooltip/accesskey globals
..
wikibits: Deprecate useragent and tooltip/accesskey globals
Ch
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60267
Change subject: wikibits: Deprecate checkboxShiftClick globals
..
wikibits: Deprecate checkboxShiftClick globals
Change-Id: I72aac6111b9be974
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60268
Change subject: wikibits: Wrap jsMsg in mw.log.deprecate
..
wikibits: Wrap jsMsg in mw.log.deprecate
No release notes since it was already de
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60269
Change subject: wikibits: Pass JSHint
..
wikibits: Pass JSHint
Change-Id: I95897e01b339c16abdd12190129d2b343be43d30
---
M .jshintignore
M ski
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60294
Change subject: mwext-TranslationNotifications: Voting for phpunit and jshint
..
mwext-TranslationNotifications: Voting for phpunit and jshint
Krinkle has submitted this change and it was merged.
Change subject: mwext-TranslationNotifications: Voting for phpunit and jshint
..
mwext-TranslationNotifications: Voting for phpunit and jshint
These are now stable.
Change-I
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60315
Change subject: TemplateDataBlob: Fix getHtml exception
..
TemplateDataBlob: Fix getHtml exception
getHtml failed with a PHP exception in Htm
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60316
Change subject: TemplateDataBlob: Implement cache versioning
..
TemplateDataBlob: Implement cache versioning
I ran into countless random exce
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62847
Change subject: ViewPageTarget: Bind callback in onSerialize like in
onShowChanges
..
ViewPageTarget: Bind callback in onSerialize like in on
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62923
Change subject: Fix various path inflexibilities and inconsistencies
..
Fix various path inflexibilities and inconsistencies
- MWVersion.php#
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62926
Change subject: populateWikiversions: Use MULTIVER_COMMON_HOME instead of
/h/w/common
..
populateWikiversions: Use MULTIVER_COMMON_HOME inste
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62936
Change subject: TemplateDataBlob: Implement 'type' and 'label'
..
TemplateDataBlob: Implement 'type' and 'label'
InterfaceText now defaults t
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62937
Change subject: TemplateDataBlob: Improve error handling
..
TemplateDataBlob: Improve error handling
For invalid keys, pass property path, no
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63379
Change subject: mwext-CentralAuth-jslint: Enable voting
..
mwext-CentralAuth-jslint: Enable voting
Change-Id: Ic22d7c6cb811fd7e303efbea2dde7f
Krinkle has submitted this change and it was merged.
Change subject: mwext-CentralAuth-jslint: Enable voting
..
mwext-CentralAuth-jslint: Enable voting
Change-Id: Ic22d7c6cb811fd7e303efbea2dde7f8d71a0a551
---
M layout.yaml
1 fi
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63740
Change subject: OutputPage: Guard jQuery.ready() against absence of jQuery
..
OutputPage: Guard jQuery.ready() against absence of jQuery
We a
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63813
Change subject: docs: Consistency use "since" phrasing in @deprecated
..
docs: Consistency use "since" phrasing in @deprecated
Most are alrea
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63816
Change subject: docs: Remove odd colons after @todo
..
docs: Remove odd colons after @todo
Most were this way already:
https://doc.wikimedia.
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63901
Change subject: ve.ce.Surface: Append phantoms to overlay instead of surface
..
ve.ce.Surface: Append phantoms to overlay instead of surface
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63973
Change subject: spec: Update specification for Set structure
..
spec: Update specification for Set structure
* Inside a Set object, label is
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63974
Change subject: spec: Update specification for InterfaceText structure
..
spec: Update specification for InterfaceText structure
Since we now
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63992
Change subject: tests: Reformat tests, evaluate status in addition to I/O
..
tests: Reformat tests, evaluate status in addition to I/O
Previo
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63999
Change subject: Implement Sets
..
Implement Sets
Change-Id: I93a0ba7287fec6e5566994d03dff1d8eaeeb8430
---
M TemplateDataBlob.php
M spec.templ
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/64056
Change subject: Enable mwext-TemplateData-phpcs-HEAD
..
Enable mwext-TemplateData-phpcs-HEAD
Change-Id: I0ea73ca1439c8aa6015d66a28828a47f984d
Krinkle has submitted this change and it was merged.
Change subject: Enable mwext-TemplateData-phpcs-HEAD
..
Enable mwext-TemplateData-phpcs-HEAD
Change-Id: I0ea73ca1439c8aa6015d66a28828a47f984d56ed
---
M layout.yaml
1 file cha
801 - 900 of 4836 matches
Mail list logo