[MediaWiki-commits] [Gerrit] mediawiki/core[master]: EmailNotification: Add newline before minor edit text

2018-01-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404161 ) Change subject: EmailNotification: Add newline before minor edit text .. EmailNotification: Add newline before minor edit text Otherwise

[MediaWiki-commits] [Gerrit] operations/puppet[production]: letsencrypt: Update LE subscriber agreement URL

2018-01-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403326 ) Change subject: letsencrypt: Update LE subscriber agreement URL .. letsencrypt: Update LE subscriber agreement URL Changes that I've

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Copy deployment-mx file to deployment-mx02

2018-01-08 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402899 ) Change subject: Copy deployment-mx file to deployment-mx02 .. Copy deployment-mx file to deployment-mx02 Bug: T184244 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: swift: Fix checks on drive/filesystem titles to allow for la...

2018-01-07 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402758 ) Change subject: swift: Fix checks on drive/filesystem titles to allow for labs ones .. swift: Fix checks on drive/filesystem titles to

[MediaWiki-commits] [Gerrit] operations/puppet[production]: [WIP] keystone: Create top-level domain for each new project

2017-08-31 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375089 ) Change subject: [WIP] keystone: Create top-level domain for each new project .. [WIP] keystone: Create top-level domain for each new

[MediaWiki-commits] [Gerrit] operations/puppet[production]: [WIP] shinkengen for all projects

2017-08-30 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374897 ) Change subject: [WIP] shinkengen for all projects .. [WIP] shinkengen for all projects Untested! Cleans up some now-unused config and

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add me back to deployment-prep shinken contacts

2017-08-30 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374866 ) Change subject: Add me back to deployment-prep shinken contacts .. Add me back to deployment-prep shinken contacts Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove allowances for IPs that are no longer in use

2017-08-29 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374665 ) Change subject: Remove allowances for IPs that are no longer in use .. Remove allowances for IPs that are no longer in use All from labs

[MediaWiki-commits] [Gerrit] mediawiki...ConfirmEdit[master]: reload JS: Get captcha ID using JSON

2017-08-29 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374537 ) Change subject: reload JS: Get captcha ID using JSON .. reload JS: Get captcha ID using JSON Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix mwrepl to require expanddblist dependency, from scap::sc...

2017-08-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372764 ) Change subject: Fix mwrepl to require expanddblist dependency, from scap::scripts .. Fix mwrepl to require expanddblist dependency, from

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Wikibase on deployment-prep: Exclude non-existent wikis from...

2017-08-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372761 ) Change subject: Wikibase on deployment-prep: Exclude non-existent wikis from clientDbList .. Wikibase on deployment-prep: Exclude

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Followup Ia5d07908: Fix sentry class's base::service_unit to...

2017-08-17 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372495 ) Change subject: Followup Ia5d07908: Fix sentry class's base::service_unit to require correct resource class .. Followup Ia5d07908: Fix

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use prop instead of removeAttr

2017-08-10 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371026 ) Change subject: Use prop instead of removeAttr .. Use prop instead of removeAttr Change-Id: I683ec23e12afaade0463c55657b0808c0968a1dd

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Use .length instead of .size() as it's getting removed in jQ...

2017-08-10 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371024 ) Change subject: Use .length instead of .size() as it's getting removed in jQuery 3.0 .. Use .length instead of .size() as it's getting

[MediaWiki-commits] [Gerrit] mediawiki...SVGEdit[master]: Use prop instead of removeAttr

2017-08-10 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371019 ) Change subject: Use prop instead of removeAttr .. Use prop instead of removeAttr Change-Id: Id9c8c62877477f35a858d742e9e80802e8f15ebf

[MediaWiki-commits] [Gerrit] mediawiki...MwEmbedSupport[master]: Use .length instead of .size() as it's getting removed in jQ...

2017-08-10 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371018 ) Change subject: Use .length instead of .size() as it's getting removed in jQuery 3.0 .. Use .length instead of .size() as it's getting

[MediaWiki-commits] [Gerrit] mediawiki...Collection[master]: Use prop instead of removeAttr

2017-08-10 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371017 ) Change subject: Use prop instead of removeAttr .. Use prop instead of removeAttr Change-Id: Ie272357a6ba7929ca4cfd410640bdc9adea18971

[MediaWiki-commits] [Gerrit] mediawiki...CodeReview[master]: Use .length instead of .size() as it's getting removed in jQ...

2017-08-10 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371016 ) Change subject: Use .length instead of .size() as it's getting removed in jQuery 3.0 .. Use .length instead of .size() as it's getting

[MediaWiki-commits] [Gerrit] mediawiki...wikihiero[master]: Use prop instead of removeAttr for submit button disabled st...

2017-08-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370860 ) Change subject: Use prop instead of removeAttr for submit button disabled status .. Use prop instead of removeAttr for submit button

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Use prop instead of removeAttr for syntax check disabled status

2017-08-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370845 ) Change subject: Use prop instead of removeAttr for syntax check disabled status .. Use prop instead of removeAttr for syntax check

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Interwiki map update

2017-01-25 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/334240 ) Change subject: Interwiki map update .. Interwiki map update Bug: T156334 Change-Id: Icfbb3264eddab7e4861fc40d44213bf2c137e205 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetdb: Allow tuning.conf to have a different shared_buffe...

2017-01-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333473 ) Change subject: puppetdb: Allow tuning.conf to have a different shared_buffers value .. puppetdb: Allow tuning.conf to have a different

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ssh: Don't add IPv6 address as an alias in exported resource...

2017-01-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333472 ) Change subject: ssh: Don't add IPv6 address as an alias in exported resource if it's undefined .. ssh: Don't add IPv6 address as an

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Allow use of PuppetDB in labs for sshknowngen

2017-01-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333471 ) Change subject: Allow use of PuppetDB in labs for sshknowngen .. Allow use of PuppetDB in labs for sshknowngen Where it is enabled.

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Move postgres tuning.conf into module

2017-01-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333470 ) Change subject: Move postgres tuning.conf into module .. Move postgres tuning.conf into module Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add account creation throttle exception for event before nex...

2017-01-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333468 ) Change subject: Add account creation throttle exception for event before next window .. Add account creation throttle exception for

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Follow-up I94eb86ba: Ignore projects where we can't list ins...

2017-01-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333289 ) Change subject: Follow-up I94eb86ba: Ignore projects where we can't list instances .. Follow-up I94eb86ba: Ignore projects where we

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Read closed-labs as closed tag on labs

2017-01-18 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/332940 ) Change subject: Read closed-labs as closed tag on labs .. Read closed-labs as closed tag on labs Bug: T115584 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Use LE for wikitech

2017-01-11 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331638 ) Change subject: Use LE for wikitech .. Use LE for wikitech Bug: T154913 Change-Id: I325ab9c1f2a56e42f1460435958d27445f5a1a6b --- D

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "Revert "labtest hiera: use labtestwikitech, not wiki...

2017-01-11 Thread Alex Monk (Code Review)
Hello Yuvipanda, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/331636 to review the following change. Change subject: Revert "Revert "labtest hiera: use labtestwikitech, not wikitech""

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add a test to prevent people from making new dblist files wi...

2017-01-09 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/331441 ) Change subject: Add a test to prevent people from making new dblist files without appropriate noc symlinks .. Add a test to prevent

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove me from researchers group

2017-01-05 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330714 ) Change subject: Remove me from researchers group .. Remove me from researchers group Bug: T154696 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Partial revert of I89bd171e (LE part)

2017-01-05 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330694 ) Change subject: Partial revert of I89bd171e (LE part) .. Partial revert of I89bd171e (LE part) Seems to create a dependency loop.

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: More error handling fixes

2017-01-04 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330419 ) Change subject: More error handling fixes .. More error handling fixes See T154565 Change-Id: I073aae149497342157503ad3f465b7d57aaad4fa

[MediaWiki-commits] [Gerrit] operations/puppet[production]: check_graphite: Fix some IndexError exceptions in Threshold....

2017-01-03 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330332 ) Change subject: check_graphite: Fix some IndexError exceptions in Threshold.parse_result .. check_graphite: Fix some IndexError

[MediaWiki-commits] [Gerrit] operations/puppet[production]: check_graphite: Fix some KeyError exceptions in SeriesThresh...

2017-01-03 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330329 ) Change subject: check_graphite: Fix some KeyError exceptions in SeriesThreshold.format_message .. check_graphite: Fix some KeyError

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: After saving a specific section, scroll to it

2016-12-24 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329119 ) Change subject: After saving a specific section, scroll to it .. After saving a specific section, scroll to it Bug: T153297 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix MWInternalLinkAnnotation.getTargetDataFromHref's behavio...

2016-12-24 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329061 ) Change subject: Fix MWInternalLinkAnnotation.getTargetDataFromHref's behaviour with URLs containing query parts .. Fix

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: rm stray fileRepoPromise property from media dialog

2016-12-24 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329057 ) Change subject: rm stray fileRepoPromise property from media dialog .. rm stray fileRepoPromise property from media dialog seems to have

[MediaWiki-commits] [Gerrit] operations/puppet[production]: toollabs: Don't use wikitech API to find labs instances in t...

2016-12-23 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329021 ) Change subject: toollabs: Don't use wikitech API to find labs instances in tools-clush-generator .. toollabs: Don't use wikitech API to

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Move shinkengen from using LDAP to the OpenStack APIs

2016-12-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328611 ) Change subject: Move shinkengen from using LDAP to the OpenStack APIs .. Move shinkengen from using LDAP to the OpenStack APIs Not

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labstore: Don't use wikitech API to find labs instances in n...

2016-12-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328609 ) Change subject: labstore: Don't use wikitech API to find labs instances in nfs-exportd .. labstore: Don't use wikitech API to find labs

[MediaWiki-commits] [Gerrit] operations/puppet[production]: graphite: Don't use wikitech API to find labs projects/insta...

2016-12-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328608 ) Change subject: graphite: Don't use wikitech API to find labs projects/instances .. graphite: Don't use wikitech API to find labs

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Don't try to JSON stringify load error messages that are alr...

2016-12-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328449 ) Change subject: Don't try to JSON stringify load error messages that are already strings .. Don't try to JSON stringify load error

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Also allow opening in source mode if VE is unavailable on ac...

2016-12-17 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328029 ) Change subject: Also allow opening in source mode if VE is unavailable on action=edit .. Also allow opening in source mode if VE is

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Don't break everything if we end up with strange accesskey m...

2016-12-16 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327892 ) Change subject: Don't break everything if we end up with strange accesskey messages .. Don't break everything if we end up with strange

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix check for HTTP error

2016-12-16 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327721 ) Change subject: Fix check for HTTP error .. Fix check for HTTP error For some reason these parameters are backwards in this particular

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Show HTTP status alongside 'Unknown error' when it's not 200

2016-12-16 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327719 ) Change subject: Show HTTP status alongside 'Unknown error' when it's not 200 .. Show HTTP status alongside 'Unknown error' when it's not

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix I0e802a47: Don't try to send dieWithError error codes as...

2016-12-16 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327718 ) Change subject: Fix I0e802a47: Don't try to send dieWithError error codes as integers .. Fix I0e802a47: Don't try to send dieWithError

[MediaWiki-commits] [Gerrit] mediawiki...OAuth[wmf/1.29.0-wmf.6]: Fix typo in function name

2016-12-16 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327714 ) Change subject: Fix typo in function name .. Fix typo in function name Bug: T153424 Change-Id: I8c93dab31b860c698f6a4592e8261e95947636db

[MediaWiki-commits] [Gerrit] mediawiki...OAuth[master]: Fix typo in function name

2016-12-16 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327713 ) Change subject: Fix typo in function name .. Fix typo in function name Bug: T153424 Change-Id: I8c93dab31b860c698f6a4592e8261e95947636db

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Wrap localStorage.getItem calls in try { ... } catch () {}

2016-12-15 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327663 ) Change subject: Wrap localStorage.getItem calls in try { ... } catch () {} .. Wrap localStorage.getItem calls in try { ... } catch () {}

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.29.0-wmf.6]: Revert "Add Terms of Use link on static and dynamic maps"

2016-12-14 Thread Alex Monk (Code Review)
Alex Monk has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/327422 ) Change subject: Revert "Add Terms of Use link on static and dynamic maps" .. Revert "Add Terms of Use link on static and dynamic

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.29.0-wmf.6]: Revert "Add Terms of Use link on static and dynamic maps"

2016-12-14 Thread Alex Monk (Code Review)
Hello JGirault, Yurik, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/327422 to review the following change. Change subject: Revert "Add Terms of Use link on static and dynamic maps"

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.29.0-wmf.5]: Update VisualEditor for I0dc6be0d, I0b43fd65, Ida6ffffa

2016-12-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327403 ) Change subject: Update VisualEditor for I0dc6be0d, I0b43fd65, Ida6a .. Update VisualEditor for I0dc6be0d, I0b43fd65, Ida6a

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.29.0-wmf.5]: Fix wikitext handling of DataTransferHandlers when IVStore i...

2016-12-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327395 ) Change subject: Fix wikitext handling of DataTransferHandlers when IVStore is used .. Fix wikitext handling of DataTransferHandlers when

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.29.0-wmf.6]: Fix wikitext handling of DataTransferHandlers when IVStore i...

2016-12-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327392 ) Change subject: Fix wikitext handling of DataTransferHandlers when IVStore is used .. Fix wikitext handling of DataTransferHandlers when

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Resolve URLs in preview elements

2016-12-10 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/326278 ) Change subject: Resolve URLs in preview elements .. Resolve URLs in preview elements Bug: T152645 Change-Id:

[MediaWiki-commits] [Gerrit] labs...grrrit[master]: Don't show approvals as 0 with new Gerrit version

2016-12-07 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/325839 ) Change subject: Don't show approvals as 0 with new Gerrit version .. Don't show approvals as 0 with new Gerrit version This is now live

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Send secondary DNS recursor IP from labs DHCP

2016-12-05 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/325278 Change subject: Send secondary DNS recursor IP from labs DHCP .. Send secondary DNS recursor IP from labs DHCP Bug: T137460 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Follow-up I863367b8, Ic9db0829: These two commits conflicted

2016-12-03 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/325122 Change subject: Follow-up I863367b8, Ic9db0829: These two commits conflicted .. Follow-up I863367b8, Ic9db0829: These two commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: deployment-prep: Follow-up Iaff51065: CONTENT_MODEL_FLOW_BOA...

2016-12-03 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/325119 Change subject: deployment-prep: Follow-up Iaff51065: CONTENT_MODEL_FLOW_BOARD is no longer set by Flow.php .. deployment-prep: Follow-up

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Follow-up I3b706396: no more wg = wmg for this variable

2016-12-03 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/325116 Change subject: Follow-up I3b706396: no more wg = wmg for this variable .. Follow-up I3b706396: no more wg = wmg for this variable

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use widget.getApi, not this.getApi

2016-12-01 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/324823 Change subject: Use widget.getApi, not this.getApi .. Use widget.getApi, not this.getApi Bug: T152154 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "Revert "RESTBase configuration for fi.wikivoyage.org""

2016-12-01 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/324766 Change subject: Revert "Revert "RESTBase configuration for fi.wikivoyage.org"" .. Revert "Revert "RESTBase configuration for

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "RESTBase configuration for fi.wikivoyage.org"

2016-11-30 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/324624 Change subject: Revert "RESTBase configuration for fi.wikivoyage.org" .. Revert "RESTBase configuration for fi.wikivoyage.org" This

[MediaWiki-commits] [Gerrit] analytics/refinery[master]: Whitelist fiwikivoyage

2016-11-30 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/324616 Change subject: Whitelist fiwikivoyage .. Whitelist fiwikivoyage Bug: T151570 Change-Id: I7465d4f9fd894b49e12346f63983f27b6f454144 --- M

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Update SiteMatrix data fork for last 3 wiki creations

2016-11-30 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/324614 Change subject: Update SiteMatrix data fork for last 3 wiki creations .. Update SiteMatrix data fork for last 3 wiki creations Bug:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Follow-up I3b706396 and Id8c53f8f: Fix -labs variations of w...

2016-11-29 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/324340 Change subject: Follow-up I3b706396 and Id8c53f8f: Fix -labs variations of wmgM(F|Mobile) variables .. Follow-up I3b706396 and Id8c53f8f:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: wikitech cloudadmin: remove right that no longer exists

2016-11-27 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/323708 Change subject: wikitech cloudadmin: remove right that no longer exists .. wikitech cloudadmin: remove right that no longer exists

[MediaWiki-commits] [Gerrit] mediawiki...EventBus[master]: Don't try to get revision ID for a link update if no revisio...

2016-11-26 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/323653 Change subject: Don't try to get revision ID for a link update if no revision triggered it .. Don't try to get revision ID for a link

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: [WIP] Undo support

2016-11-23 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/323357 Change subject: [WIP] Undo support .. [WIP] Undo support TODO: * Inline VE API TODOs * Check revision deletion? (see EditPage) - may

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Respect oldid parameter in NWE

2016-11-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/323097 Change subject: Respect oldid parameter in NWE .. Respect oldid parameter in NWE Change-Id: I5a6388f50cc432421343974eb9f721f5e5a94d93 ---

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Follow-up I63ab27cb: Get rid of notices tool when there are ...

2016-11-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/323091 Change subject: Follow-up I63ab27cb: Get rid of notices tool when there are no notices .. Follow-up I63ab27cb: Get rid of notices tool

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Move around code that sets up edit notices to ensure it runs...

2016-11-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322828 Change subject: Move around code that sets up edit notices to ensure it runs after we receive the notices to display .. Move around code

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Template out reference to deployment.eqiad.wmnet in inactive...

2016-11-21 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322825 Change subject: Template out reference to deployment.eqiad.wmnet in inactive.motd .. Template out reference to deployment.eqiad.wmnet in

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Use production apache config on beta

2016-11-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322603 Change subject: Use production apache config on beta .. Use production apache config on beta Bug: T1256 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Get rid of old beta_sites class now just containing a load o...

2016-11-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322604 Change subject: Get rid of old beta_sites class now just containing a load of ensure => absent .. Get rid of old beta_sites class now just

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Move production apache config files to templates

2016-11-20 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322602 Change subject: Move production apache config files to templates .. Move production apache config files to templates So we can add beta

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Consolidate all of the simple wikimedia.org VHosts into two

2016-11-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322425 Change subject: Consolidate all of the simple wikimedia.org VHosts into two .. Consolidate all of the simple wikimedia.org VHosts into two

[MediaWiki-commits] [Gerrit] operations/puppet[production]: beta: bring remnant.conf closer to prod version

2016-11-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322424 Change subject: beta: bring remnant.conf closer to prod version .. beta: bring remnant.conf closer to prod version By moving the commons

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove apache-level HTTPS redirects

2016-11-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322423 Change subject: Remove apache-level HTTPS redirects .. Remove apache-level HTTPS redirects Varnish does this everywhere these days. ...

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove bits.wikimedia.org apache config

2016-11-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322420 Change subject: Remove bits.wikimedia.org apache config .. Remove bits.wikimedia.org apache config Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: beta sites: copy zerowiki config from prod

2016-11-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322416 Change subject: beta sites: copy zerowiki config from prod .. beta sites: copy zerowiki config from prod Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: beta: copy metawiki config from prod instead of having our own

2016-11-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322419 Change subject: beta: copy metawiki config from prod instead of having our own .. beta: copy metawiki config from prod instead of having

[MediaWiki-commits] [Gerrit] operations/puppet[production]: beta: configure loginwiki the same as prod

2016-11-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322417 Change subject: beta: configure loginwiki the same as prod .. beta: configure loginwiki the same as prod Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: beta: Use wikimedia-common.incl for testwiki

2016-11-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322418 Change subject: beta: Use wikimedia-common.incl for testwiki .. beta: Use wikimedia-common.incl for testwiki Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mediawiki: move redirects site from prod_sites to sites

2016-11-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322413 Change subject: mediawiki: move redirects site from prod_sites to sites .. mediawiki: move redirects site from prod_sites to sites i.e.

[MediaWiki-commits] [Gerrit] operations/puppet[production]: beta::autoupdater: Stop wmf-beta-mwconfig-update being a tem...

2016-11-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322408 Change subject: beta::autoupdater: Stop wmf-beta-mwconfig-update being a template just to get the staging dir .. beta::autoupdater: Stop

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Kill role::beta::trebuchet_testing

2016-11-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322405 Change subject: Kill role::beta::trebuchet_testing .. Kill role::beta::trebuchet_testing Unused AFAICT Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Kill role::beta::uploadservice

2016-11-19 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322403 Change subject: Kill role::beta::uploadservice .. Kill role::beta::uploadservice This was replaced with Swift Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Interwiki map update

2016-11-17 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/322141 Change subject: Interwiki map update .. Interwiki map update Includes creation of projectcomwiki as well as several changes to HTTPS links

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Prevent endless error loop if falling back to wikitext (afte...

2016-11-16 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/321908 Change subject: Prevent endless error loop if falling back to wikitext (after a load failure) fails. .. Prevent endless error loop if

[MediaWiki-commits] [Gerrit] mediawiki...CodeEditor[master]: Follow-up I83714188: Don't turn every MW page into an exception

2016-11-14 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/321580 Change subject: Follow-up I83714188: Don't turn every MW page into an exception .. Follow-up I83714188: Don't turn every MW page into an

[MediaWiki-commits] [Gerrit] labs...grrrit[master]: Move around a load more logging, responses etc.

2016-11-13 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/321338 Change subject: Move around a load more logging, responses etc. .. Move around a load more logging, responses etc. Change-Id:

[MediaWiki-commits] [Gerrit] labs...grrrit[master]: Simplify command handling section

2016-11-13 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/321337 Change subject: Simplify command handling section .. Simplify command handling section Change-Id:

[MediaWiki-commits] [Gerrit] labs...grrrit[master]: Remove whitelist_nicks

2016-11-13 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/321335 Change subject: Remove whitelist_nicks .. Remove whitelist_nicks The users intended to be allowed by this list are all eligible for

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Move NWE URL changes into JS

2016-11-07 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/320318 Change subject: Move NWE URL changes into JS .. Move NWE URL changes into JS Bug: T148077 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Move save dialog checkbox code up from DAT into ArticleTarget

2016-11-05 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/319974 Change subject: Move save dialog checkbox code up from DAT into ArticleTarget .. Move save dialog checkbox code up from DAT into

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Hacks to get VE loading on mobile while user has NWE enabled

2016-11-04 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/319973 Change subject: Hacks to get VE loading on mobile while user has NWE enabled .. Hacks to get VE loading on mobile while user has NWE

  1   2   3   4   5   6   7   8   9   10   >