[MediaWiki-commits] [Gerrit] mediawiki...GlobalUsage[master]: Fix Special:GloballyWantedFiles on sqlite

2017-12-31 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401186 ) Change subject: Fix Special:GloballyWantedFiles on sqlite .. Fix Special:GloballyWantedFiles on sqlite sqlite requires specifying

[MediaWiki-commits] [Gerrit] mediawiki...GlobalUsage[master]: Fix class name for QueryPages (no behaviour change)

2017-12-26 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400235 ) Change subject: Fix class name for QueryPages (no behaviour change) .. Fix class name for QueryPages (no behaviour change) 347daf20252

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Appearently this doesn't work with php-ast 0.1.5

2017-12-22 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399873 ) Change subject: Appearently this doesn't work with php-ast 0.1.5 .. Appearently this doesn't work with php-ast 0.1.5 This is just a

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fill in $wgGNSMFallbackCategory based on wikidata

2017-12-20 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399433 ) Change subject: Fill in $wgGNSMFallbackCategory based on wikidata .. Fill in $wgGNSMFallbackCategory based on wikidata This option is

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[REL1_27]: SECURITY: Fix escaping of description field

2017-12-18 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398918 ) Change subject: SECURITY: Fix escaping of description field .. SECURITY: Fix escaping of description field Bug: T118682 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[REL1_29]: SECURITY: Fix escaping of description field

2017-12-18 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398916 ) Change subject: SECURITY: Fix escaping of description field .. SECURITY: Fix escaping of description field Bug: T118682 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[REL1_30]: SECURITY: Fix escaping of description field

2017-12-18 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398915 ) Change subject: SECURITY: Fix escaping of description field .. SECURITY: Fix escaping of description field Bug: T118682 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[master]: Bump version for security release of extension

2017-12-18 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398914 ) Change subject: Bump version for security release of extension .. Bump version for security release of extension Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[master]: SECURITY: Fix escaping of description field

2017-12-18 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398911 ) Change subject: SECURITY: Fix escaping of description field .. SECURITY: Fix escaping of description field Bug: T118682 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make Gender normalize usernames

2017-12-17 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398772 ) Change subject: Make Gender normalize usernames .. Make Gender normalize usernames This ensures that if GENDER is fed

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Html escaping functions shouldn't clear non-html taint

2017-12-11 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397587 ) Change subject: Html escaping functions shouldn't clear non-html taint .. Html escaping functions shouldn't clear non-html taint

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Finish rename to mediawiki/phan-taint-check-plugin

2017-12-11 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397574 ) Change subject: Finish rename to mediawiki/phan-taint-check-plugin .. Finish rename to mediawiki/phan-taint-check-plugin This also

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix some typos

2017-12-11 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/396564 ) Change subject: Fix some typos .. Fix some typos Change-Id: Ic69098f3ad46c47c538cf30cdba2c215e90b1511 --- M

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add .gitattributes file

2017-12-11 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397572 ) Change subject: Add .gitattributes file .. Add .gitattributes file Following guidelines at:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Replace SecurityCheckPlugin:: with self:: where possible

2017-12-11 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397561 ) Change subject: Replace SecurityCheckPlugin:: with self:: where possible .. Replace SecurityCheckPlugin:: with self:: where possible

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add a test script for people whose php bin is not 7

2017-12-11 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397559 ) Change subject: Add a test script for people whose php bin is not 7 .. Add a test script for people whose php bin is not 7 This is

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Disable progress bar in composer test, as ugly on jenkins

2017-12-11 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397558 ) Change subject: Disable progress bar in composer test, as ugly on jenkins .. Disable progress bar in composer test, as ugly on jenkins

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Rename plugin to mediawiki/phan-taint-check-plugin

2017-12-11 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397550 ) Change subject: Rename plugin to mediawiki/phan-taint-check-plugin .. Rename plugin to mediawiki/phan-taint-check-plugin [This shall

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add a note about how it can't validate certain types of SQL

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/396563 ) Change subject: Add a note about how it can't validate certain types of SQL .. Add a note about how it can't validate certain

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add a note about how it can't validate certain types of SQL

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396563 ) Change subject: Add a note about how it can't validate certain types of SQL .. Add a note about how it can't validate certain types of

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Version should be php 7.0 (7.1 not supported due to dependency)

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/396561 ) Change subject: Version should be php 7.0 (7.1 not supported due to dependency) .. Version should be php 7.0 (7.1 not supported

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Version should be php 7.0 (7.1 not supported due to dependency)

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396561 ) Change subject: Version should be php 7.0 (7.1 not supported due to dependency) .. Version should be php 7.0 (7.1 not supported due to

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Rename to "mediawiki/phan-security-plugin"

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/396557 ) Change subject: Rename to "mediawiki/phan-security-plugin" .. Rename to "mediawiki/phan-security-plugin" The mediawiki vendor

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix test that didn't pass lint

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/396559 ) Change subject: Fix test that didn't pass lint .. Fix test that didn't pass lint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix test that didn't pass lint

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396559 ) Change subject: Fix test that didn't pass lint .. Fix test that didn't pass lint Change-Id: I925a24ceac8b5105eefbe556fcafd9afc42bd87b

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Follow-up on Ie9106c80

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/396543 ) Change subject: Follow-up on Ie9106c80 .. Follow-up on Ie9106c80 Fix composer syntax error on L26 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: build: update composer.json

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/396455 ) Change subject: build: update composer.json .. build: update composer.json * Change empty whitespaces to tabs. * A Phabricator

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add .gitreview

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/396456 ) Change subject: Add .gitreview .. Add .gitreview For those using git-review tool. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.11]: Revert replacing textarea in Special:Undelete with OOUI

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396465 ) Change subject: Revert replacing textarea in Special:Undelete with OOUI .. Revert replacing textarea in Special:Undelete with OOUI

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add GPL license headers

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396442 ) Change subject: Add GPL license headers .. Add GPL license headers Change-Id: Ie9106c80b23f23a393912a12c9368078bcdb3557 --- M

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add GPL license headers

2017-12-08 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/396442 ) Change subject: Add GPL license headers .. Add GPL license headers Change-Id: Ie9106c80b23f23a393912a12c9368078bcdb3557 --- M

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Make README prettier

2017-12-07 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395925 ) Change subject: Make README prettier .. Make README prettier Make the README a bit nicer introduction to the functionality

[MediaWiki-commits] [Gerrit] mediawiki...MassAction[master]: Internationalize hardcoded strings from View Task

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395817 ) Change subject: Internationalize hardcoded strings from View Task .. Internationalize hardcoded strings from View Task Bug:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: placeholder-message for html form should be ->text() not ->p...

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395910 ) Change subject: placeholder-message for html form should be ->text() not ->parse() .. placeholder-message for html form should be

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Update composer.json

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395769 ) Change subject: Update composer.json .. Update composer.json Change-Id: Ie5a7c5169bb01057d112d1655d670a8abd6252b5 --- M composer.json

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Update composer.json

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395769 ) Change subject: Update composer.json .. Update composer.json Change-Id: Ie5a7c5169bb01057d112d1655d670a8abd6252b5 --- M

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Update README

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395764 ) Change subject: Update README .. Update README Change-Id: I43bb5e9617e94e7e249e9b78702cde708043b202 --- M README M

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Some debugging fixes

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395755 ) Change subject: Some debugging fixes .. Some debugging fixes For issues emitted due to a hook, include the line number of the

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Move plugin entry points to root directory

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395763 ) Change subject: Move plugin entry points to root directory .. Move plugin entry points to root directory The plugin entry points are

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Minor fixes to the eval case

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395756 ) Change subject: Minor fixes to the eval case .. Minor fixes to the eval case Include a doc comment about how setFuncTaint()

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add test for array addition with SQL_NUMKEY

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395759 ) Change subject: Add test for array addition with SQL_NUMKEY .. Add test for array addition with SQL_NUMKEY Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Support installing via composer.

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395765 ) Change subject: Support installing via composer. .. Support installing via composer. Add scripts for easy running of test.

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix some false positives discovered while testing with MW

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395762 ) Change subject: Fix some false positives discovered while testing with MW .. Fix some false positives discovered while testing

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Move plugin entry points to root directory

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395763 ) Change subject: Move plugin entry points to root directory .. Move plugin entry points to root directory The plugin entry

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Minor fixes discovered during testing

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395758 ) Change subject: Minor fixes discovered during testing .. Minor fixes discovered during testing Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Support installing via composer.

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395765 ) Change subject: Support installing via composer. .. Support installing via composer. Add scripts for easy running of test. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix some false positives discovered while testing with MW

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395762 ) Change subject: Fix some false positives discovered while testing with MW .. Fix some false positives discovered while testing with MW

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix various false positives found when testing with MW

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395761 ) Change subject: Fix various false positives found when testing with MW .. Fix various false positives found when testing with

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Update README

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395764 ) Change subject: Update README .. Update README Change-Id: I43bb5e9617e94e7e249e9b78702cde708043b202 --- M README M

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add a test for list() support

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395760 ) Change subject: Add a test for list() support .. Add a test for list() support Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add test for array addition with SQL_NUMKEY

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395759 ) Change subject: Add test for array addition with SQL_NUMKEY .. Add test for array addition with SQL_NUMKEY Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Some debugging fixes

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395755 ) Change subject: Some debugging fixes .. Some debugging fixes For issues emitted due to a hook, include the line number of the hook

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix handling of IN(...) lists in db select wrapper

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395753 ) Change subject: Fix handling of IN(...) lists in db select wrapper .. Fix handling of IN(...) lists in db select wrapper Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix various false positives found when testing with MW

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395761 ) Change subject: Fix various false positives found when testing with MW .. Fix various false positives found when testing with MW

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Support checking getQueryInfo() return; Process $options & $...

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395754 ) Change subject: Support checking getQueryInfo() return; Process $options & $join_conds .. Support checking getQueryInfo()

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add a test for list() support

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395760 ) Change subject: Add a test for list() support .. Add a test for list() support Change-Id: I24ecc104265fafe6179d8f3e42e16c2a2edfe059

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Ensure that errors related to function are per param

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395757 ) Change subject: Ensure that errors related to function are per param .. Ensure that errors related to function are per param

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Minor fixes discovered during testing

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395758 ) Change subject: Minor fixes discovered during testing .. Minor fixes discovered during testing Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Ensure that errors related to function are per param

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395757 ) Change subject: Ensure that errors related to function are per param .. Ensure that errors related to function are per param

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix handling of IN(...) lists in db select wrapper

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395753 ) Change subject: Fix handling of IN(...) lists in db select wrapper .. Fix handling of IN(...) lists in db select wrapper

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Support checking getQueryInfo() return; Process $options & $...

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395754 ) Change subject: Support checking getQueryInfo() return; Process $options & $join_conds .. Support checking getQueryInfo() return;

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Minor fixes to the eval case

2017-12-06 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395756 ) Change subject: Minor fixes to the eval case .. Minor fixes to the eval case Include a doc comment about how setFuncTaint() can lead

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add ARRAY_OK flag for functions that are safe with arrays

2017-12-03 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394868 ) Change subject: Add ARRAY_OK flag for functions that are safe with arrays .. Add ARRAY_OK flag for functions that are safe with

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Make unit tests for extension.json always work

2017-12-03 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394867 ) Change subject: Make unit tests for extension.json always work .. Make unit tests for extension.json always work previously it did not

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Make error messages from hooks be in extension instead of core

2017-12-03 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394866 ) Change subject: Make error messages from hooks be in extension instead of core .. Make error messages from hooks be in extension

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Avoid duplication in output

2017-12-03 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394865 ) Change subject: Avoid duplication in output .. Avoid duplication in output This also fixes the json test Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix bug where non-local variables are treated like local

2017-12-03 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394869 ) Change subject: Fix bug where non-local variables are treated like local .. Fix bug where non-local variables are treated like local

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix bug where non-local variables are treated like local

2017-12-03 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394869 ) Change subject: Fix bug where non-local variables are treated like local .. Fix bug where non-local variables are treated like

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add support for IDatabase::select style arguments

2017-12-03 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394870 ) Change subject: Add support for IDatabase::select style arguments .. Add support for IDatabase::select style arguments Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add ARRAY_OK flag for functions that are safe with arrays

2017-12-03 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394868 ) Change subject: Add ARRAY_OK flag for functions that are safe with arrays .. Add ARRAY_OK flag for functions that are safe with arrays

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Make unit tests for extension.json always work

2017-12-03 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394867 ) Change subject: Make unit tests for extension.json always work .. Make unit tests for extension.json always work previously it

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add support for IDatabase::select style arguments

2017-12-03 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394870 ) Change subject: Add support for IDatabase::select style arguments .. Add support for IDatabase::select style arguments

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Make error messages from hooks be in extension instead of core

2017-12-03 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394866 ) Change subject: Make error messages from hooks be in extension instead of core .. Make error messages from hooks be in

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Avoid duplication in output

2017-12-03 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394865 ) Change subject: Avoid duplication in output .. Avoid duplication in output This also fixes the json test Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Support loading hook information from extension.json

2017-11-29 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394092 ) Change subject: Support loading hook information from extension.json .. Support loading hook information from extension.json

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix some minor issues

2017-11-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394094 ) Change subject: Fix some minor issues .. Fix some minor issues Change-Id: I603b43de23e752915b1d56605050d5fc8962de60 --- M

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Handle dispatching of hooks on Hooks::run()

2017-11-29 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394093 ) Change subject: Handle dispatching of hooks on Hooks::run() .. Handle dispatching of hooks on Hooks::run() Slight negative to

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Handle dispatching of hooks on Hooks::run()

2017-11-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394093 ) Change subject: Handle dispatching of hooks on Hooks::run() .. Handle dispatching of hooks on Hooks::run() Slight negative to this is

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Support loading hook information from extension.json

2017-11-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394092 ) Change subject: Support loading hook information from extension.json .. Support loading hook information from extension.json As of

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix some minor issues

2017-11-29 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394094 ) Change subject: Fix some minor issues .. Fix some minor issues Change-Id: I603b43de23e752915b1d56605050d5fc8962de60 --- M

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Support recognizing $wgHooks/$_GLOBALS['wgHooks']

2017-11-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394090 ) Change subject: Support recognizing $wgHooks/$_GLOBALS['wgHooks'] .. Support recognizing $wgHooks/$_GLOBALS['wgHooks'] Still does not

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Support recognizing $wgHooks/$_GLOBALS['wgHooks']

2017-11-29 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394090 ) Change subject: Support recognizing $wgHooks/$_GLOBALS['wgHooks'] .. Support recognizing $wgHooks/$_GLOBALS['wgHooks'] Still

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Make more clear error messages, distinguishing different iss...

2017-11-29 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394091 ) Change subject: Make more clear error messages, distinguishing different issue types .. Make more clear error messages,

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Make more clear error messages, distinguishing different iss...

2017-11-29 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394091 ) Change subject: Make more clear error messages, distinguishing different issue types .. Make more clear error messages, distinguishing

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add support for parser tag hooks

2017-11-26 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/393541 ) Change subject: Add support for parser tag hooks .. Add support for parser tag hooks Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Keep track of hook registrations

2017-11-26 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/393542 ) Change subject: Keep track of hook registrations .. Keep track of hook registrations As of yet, it doesn't do anything with

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Support ParserFunctions, and start of work for hooks in general

2017-11-26 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/393540 ) Change subject: Support ParserFunctions, and start of work for hooks in general .. Support ParserFunctions, and start of work

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix remaining tests (mostly phpcs)

2017-11-26 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393537 ) Change subject: Fix remaining tests (mostly phpcs) .. Fix remaining tests (mostly phpcs) Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Mention phan version requirements

2017-11-26 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/393538 ) Change subject: Mention phan version requirements .. Mention phan version requirements Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Add taint for db related function. Fix handling of subclasses

2017-11-26 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/393539 ) Change subject: Add taint for db related function. Fix handling of subclasses .. Add taint for db related function. Fix

[MediaWiki-commits] [Gerrit] mediawiki...SecurityCheckPlugin[master]: Fix remaining tests (mostly phpcs)

2017-11-26 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/393537 ) Change subject: Fix remaining tests (mostly phpcs) .. Fix remaining tests (mostly phpcs) Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Contributors[REL1_27]: makeSpecialUrlSubpage() expects parameter to not be url encoded

2017-11-21 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/392760 ) Change subject: makeSpecialUrlSubpage() expects parameter to not be url encoded .. makeSpecialUrlSubpage() expects parameter to

[MediaWiki-commits] [Gerrit] mediawiki...Contributors[REL1_27]: makeSpecialUrlSubpage() expects parameter to not be url encoded

2017-11-21 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392760 ) Change subject: makeSpecialUrlSubpage() expects parameter to not be url encoded .. makeSpecialUrlSubpage() expects parameter to not be

[MediaWiki-commits] [Gerrit] mediawiki...Contributors[REL1_30]: makeSpecialUrlSubpage() expects parameter to not be url encoded

2017-11-21 Thread Brian Wolff (Code Review)
Brian Wolff has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/392759 ) Change subject: makeSpecialUrlSubpage() expects parameter to not be url encoded .. makeSpecialUrlSubpage() expects parameter to

[MediaWiki-commits] [Gerrit] mediawiki...Contributors[REL1_30]: makeSpecialUrlSubpage() expects parameter to not be url encoded

2017-11-21 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392759 ) Change subject: makeSpecialUrlSubpage() expects parameter to not be url encoded .. makeSpecialUrlSubpage() expects parameter to not be

[MediaWiki-commits] [Gerrit] mediawiki...Contributors[master]: Fix message missing parameter

2017-11-21 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392758 ) Change subject: Fix message missing parameter .. Fix message missing parameter Change-Id: Id844fe905de6e25e35c431a5715b4a91d496e123

[MediaWiki-commits] [Gerrit] mediawiki...InputBox[REL1_27]: Have inputbox langconvert certain attributes

2017-11-21 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392751 ) Change subject: Have inputbox langconvert certain attributes .. Have inputbox langconvert certain attributes This approximates the

[MediaWiki-commits] [Gerrit] mediawiki...InputBox[REL1_28]: Have inputbox langconvert certain attributes

2017-11-21 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392750 ) Change subject: Have inputbox langconvert certain attributes .. Have inputbox langconvert certain attributes This approximates the

[MediaWiki-commits] [Gerrit] mediawiki...InputBox[REL1_29]: Have inputbox langconvert certain attributes

2017-11-21 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392749 ) Change subject: Have inputbox langconvert certain attributes .. Have inputbox langconvert certain attributes This approximates the

[MediaWiki-commits] [Gerrit] mediawiki...InputBox[wmf/1.31.0-wmf.8]: Have inputbox langconvert certain attributes

2017-11-21 Thread Brian Wolff (Code Review)
Brian Wolff has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392745 ) Change subject: Have inputbox langconvert certain attributes .. Have inputbox langconvert certain attributes This approximates the

  1   2   3   4   5   6   7   8   9   >