[MediaWiki-commits] [Gerrit] Simplified and cleaned up code - change (mediawiki...SemanticMediaWiki)

2013-02-25 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. https://gerrit.wikimedia.org/r/50736 Change subject: Simplified and cleaned up code .. Simplified and cleaned up code This also prepares the removal of the deprecated

[MediaWiki-commits] [Gerrit] Add missing use statement and use one line for each - change (mediawiki...SemanticMediaWiki)

2013-02-25 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Add missing use statement and use one line for each .. Add missing use statement and use one line for each Change-Id:

[MediaWiki-commits] [Gerrit] Fix construction of SMWExpLiteral which requires first arg t... - change (mediawiki...SemanticMediaWiki)

2013-02-23 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix construction of SMWExpLiteral which requires first arg to be string .. Fix construction of SMWExpLiteral which requires first arg to be string

[MediaWiki-commits] [Gerrit] Remove line that disables DISTINCT with blobs - change (mediawiki...SemanticMediaWiki)

2013-02-22 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. https://gerrit.wikimedia.org/r/50381 Change subject: Remove line that disables DISTINCT with blobs .. Remove line that disables DISTINCT with blobs This fixes bug

[MediaWiki-commits] [Gerrit] Cleanup of SMW_setup.php, attempt to fix bug 42349 - change (mediawiki...SemanticMediaWiki[master])

2012-11-30 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Cleanup of SMW_setup.php, attempt to fix bug 42349 .. Cleanup of SMW_setup.php, attempt to fix bug 42349 Change-Id:

[MediaWiki-commits] [Gerrit] Fixed some interface issues in SMW_setup.php - change (mediawiki...SemanticMediaWiki[master])

2012-11-30 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed some interface issues in SMW_setup.php .. Fixed some interface issues in SMW_setup.php Changes: * Register --backend as an option *with parameters*;

[MediaWiki-commits] [Gerrit] Minor fix in URI decoding for SPARQL stores - change (mediawiki...SemanticMediaWiki[master])

2012-11-30 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Minor fix in URI decoding for SPARQL stores .. Minor fix in URI decoding for SPARQL stores Use rawurldecode instead of urldecode, as reported by Luka Frelih

[MediaWiki-commits] [Gerrit] Fixed some interface issues in SMW_setup.php - change (mediawiki...SemanticMediaWiki[master])

2012-11-30 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed some interface issues in SMW_setup.php .. Fixed some interface issues in SMW_setup.php Changes: * Register --backend as an option *with

[MediaWiki-commits] [Gerrit] Fix Bug 42361 - change (mediawiki...SemanticMediaWiki[master])

2012-11-23 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 42361 .. Fix Bug 42361 Reworked code for string datavalue to avoid double escaping of active markup that we introduce for display. The code should

[MediaWiki-commits] [Gerrit] Fix Bug 42361 - change (mediawiki...SemanticMediaWiki[master])

2012-11-23 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 42361 .. Fix Bug 42361 Reworked code for string datavalue to avoid double escaping of active markup that we introduce for display. The code

[MediaWiki-commits] [Gerrit] Store3 as default; updated documentation files - change (mediawiki...SemanticMediaWiki[master])

2012-11-21 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Store3 as default; updated documentation files .. Store3 as default; updated documentation files Getting ready for the release. * Reorganised RELEASE-NOTES

[MediaWiki-commits] [Gerrit] Fixed Bug 42032 - change (mediawiki...SemanticMediaWiki[master])

2012-11-20 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed Bug 42032 .. Fixed Bug 42032 The bug is caused by more than one entry referring to special properties in the SMW IDs table. There are

[MediaWiki-commits] [Gerrit] Fixed Bug 42032 - change (mediawiki...SemanticMediaWiki[master])

2012-11-19 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed Bug 42032 .. Fixed Bug 42032 The bug is caused by more than one entry referring to special properties in the SMW IDs table. There are multiple

[MediaWiki-commits] [Gerrit] Fix sortkey retrieval in Store3 (Bug 42033, ...) - change (mediawiki...SemanticMediaWiki[master])

2012-11-12 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix sortkey retrieval in Store3 (Bug 42033, ...) .. Fix sortkey retrieval in Store3 (Bug 42033, ...) Since sortkeys are not stored in a property table, but

[MediaWiki-commits] [Gerrit] Fix sortkey retrieval in Store3 (Bug 42033, ...) - change (mediawiki...SemanticMediaWiki[master])

2012-11-12 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix sortkey retrieval in Store3 (Bug 42033, ...) .. Fix sortkey retrieval in Store3 (Bug 42033, ...) Since sortkeys are not stored in a property

[MediaWiki-commits] [Gerrit] Support variable SQL backends in SPARQL Store - change (mediawiki...SemanticMediaWiki[master])

2012-11-11 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Support variable SQL backends in SPARQL Store .. Support variable SQL backends in SPARQL Store SMWSparlStore used to be a subclass of SMWSQLStore2, which

[MediaWiki-commits] [Gerrit] Support variable SQL backends in SPARQL Store - change (mediawiki...SemanticMediaWiki[master])

2012-11-11 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Support variable SQL backends in SPARQL Store .. Support variable SQL backends in SPARQL Store SMWSparlStore used to be a subclass of SMWSQLStore2,

[MediaWiki-commits] [Gerrit] Fixing Change I1b2b6617 - change (mediawiki...SemanticMediaWiki[master])

2012-11-10 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixing Change I1b2b6617 .. Fixing Change I1b2b6617 This fixes some further ways in which change I1b2b6617 breaks SMW. Anything else? Not sure ...

[MediaWiki-commits] [Gerrit] Fixing Change I1b2b6617 - change (mediawiki...SemanticMediaWiki[master])

2012-11-10 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixing Change I1b2b6617 .. Fixing Change I1b2b6617 This fixes some further ways in which change I1b2b6617 breaks SMW. Anything else? Not sure ...

[MediaWiki-commits] [Gerrit] Fixed Bug 33610 - change (mediawiki...SemanticMediaWiki[master])

2012-11-09 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed Bug 33610 .. Fixed Bug 33610 The special page code did not handle errors that can occur on property dataitem creation (e.g., if a special

[MediaWiki-commits] [Gerrit] Better fix for Bug 39392 - change (mediawiki...SemanticMediaWiki[master])

2012-11-09 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Better fix for Bug 39392 .. Better fix for Bug 39392 Changed the behaviour to be as follows: * if linking is enabled (link=all, default), URLs will be made

[MediaWiki-commits] [Gerrit] Store3: tablenames, usage count init, style - change (mediawiki...SemanticMediaWiki[master])

2012-11-09 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Store3: tablenames, usage count init, style .. Store3: tablenames, usage count init, style This complex change prepares SQLStore3 for release. After

[MediaWiki-commits] [Gerrit] Rewritten SQLStore3 writing methods - change (mediawiki...SemanticMediaWiki[master])

2012-11-08 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Rewritten SQLStore3 writing methods .. Rewritten SQLStore3 writing methods This is a rewrite of large parts of SMW_SQLStore3_Writers.php. The only methods

[MediaWiki-commits] [Gerrit] Fixed Bug 33610 - change (mediawiki...SemanticMediaWiki[master])

2012-11-07 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed Bug 33610 .. Fixed Bug 33610 The special page code did not handle errors that can occur on property dataitem creation (e.g., if a special property ID

[MediaWiki-commits] [Gerrit] Fix Bug 38811 - change (mediawiki...SemanticMediaWiki[master])

2012-11-07 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 38811 .. Fix Bug 38811 Special:UnusedProperties was not checking if a property is special (pre-defined in SMW). This is fixed now, and thus the

[MediaWiki-commits] [Gerrit] Trivial documentation change - change (mediawiki...SemanticMediaWiki[master])

2012-11-06 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Trivial documentation change .. Trivial documentation change The docs were misleading here. Change-Id: I9650e1d77fb3ccc877c08be2ac5e2b18d6bc1a8b --- M

[MediaWiki-commits] [Gerrit] Corrected getWikiValue() for Property DVs - change (mediawiki...SemanticMediaWiki[master])

2012-11-06 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Corrected getWikiValue() for Property DVs .. Corrected getWikiValue() for Property DVs Inverse properties now have a label with - on the DI level (this was

[MediaWiki-commits] [Gerrit] SMW DataValue check SMWDIBlob - change (mediawiki...SemanticMediaWiki[master])

2012-11-06 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: SMW DataValue check SMWDIBlob .. SMW DataValue check SMWDIBlob Change-Id: I93d2269e5cc22ee1579e3eb57ad63dc5772812ed --- M

[MediaWiki-commits] [Gerrit] Protect against unitialised/unrecognised dataitem - change (mediawiki...SemanticMediaWiki[master])

2012-11-05 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Protect against unitialised/unrecognised dataitem .. Protect against unitialised/unrecognised dataitem There are rare cases (I encountered one during

[MediaWiki-commits] [Gerrit] Protect StubSemanticData agains DI exceptions - change (mediawiki...SemanticMediaWiki[master])

2012-11-05 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Protect StubSemanticData agains DI exceptions .. Protect StubSemanticData agains DI exceptions If the database contained data about a property whose name is

[MediaWiki-commits] [Gerrit] Fixed concept cache creation for SQLStore3 - change (mediawiki...SemanticMediaWiki[master])

2012-11-05 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed concept cache creation for SQLStore3 .. Fixed concept cache creation for SQLStore3 Concept caching did not work with Store3 since it was disabled

[MediaWiki-commits] [Gerrit] Fixed broken Special:PageProperty - change (mediawiki...SemanticMediaWiki[master])

2012-11-05 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed broken Special:PageProperty .. Fixed broken Special:PageProperty This not-so-often used special page was severely broken, due to two problems: *

[MediaWiki-commits] [Gerrit] Fixed version in ask api, removed alpha notice and did some ... - change (mediawiki...SemanticMediaWiki[master])

2012-11-04 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed version in ask api, removed alpha notice and did some style fixes .. Fixed version in ask api, removed alpha notice and did some style fixes

[MediaWiki-commits] [Gerrit] Always returing Blob - change (mediawiki...SemanticMediaWiki[master])

2012-11-03 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Always returing Blob .. Always returing Blob Change-Id: I251f86a527f4945cba118338b4b314e5f762bcba --- M

[MediaWiki-commits] [Gerrit] Updated SMWQueryProcessor API - change (mediawiki...SemanticMediaWiki[master])

2012-11-02 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Updated SMWQueryProcessor API .. Updated SMWQueryProcessor API * Disentagled some code in print request parsing * Use array results instead of making part

[MediaWiki-commits] [Gerrit] Store data about inline queries - change (mediawiki...SemanticMediaWiki[master])

2012-11-02 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Store data about inline queries .. Store data about inline queries This change makes #ask and #show create new information that is stored for the page they

[MediaWiki-commits] [Gerrit] Escape [ and { in code displays - change (mediawiki...SemanticMediaWiki[master])

2012-11-02 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Escape [ and { in code displays .. Escape [ and { in code displays This avoids MediaWiki interpretation of text that should be displayed verbatim.

[MediaWiki-commits] [Gerrit] Fixed bug in inverse property handling - change (mediawiki...SemanticMediaWiki[master])

2012-11-01 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed bug in inverse property handling .. Fixed bug in inverse property handling Inverse properties would not reliably work (in queries etc.) when property

[MediaWiki-commits] [Gerrit] Fixed Bug 35962 - change (mediawiki...SemanticMediaWiki[master])

2012-11-01 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed Bug 35962 .. Fixed Bug 35962 Avoid a MediaWiki problem with latest revisions during refreshing, causing errors when the property _LEDT (last editor

[MediaWiki-commits] [Gerrit] Fix to bug 41269 - change (mediawiki...SemanticMediaWiki[master])

2012-10-27 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix to bug 41269 .. Fix to bug 41269 Now computing stats during setup, so the insert is anyway not needed. Patchset2: catching some exceptions,

[MediaWiki-commits] [Gerrit] Better indexes for Store3 - change (mediawiki...SemanticMediaWiki[master])

2012-10-27 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Better indexes for Store3 .. Better indexes for Store3 * Create different indexes than before; more useful for our queries * Most indexes now created

[MediaWiki-commits] [Gerrit] Improved debug output - change (mediawiki...SemanticMediaWiki[master])

2012-10-27 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Improved debug output .. Improved debug output Use wfDebug. The cache utilisation statistics are somewhat interesting and could remain in the code

[MediaWiki-commits] [Gerrit] Documentation/style improvements - change (mediawiki...SemanticMediaWiki[master])

2012-10-27 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Documentation/style improvements .. Documentation/style improvements Note that all files should have an @file comment to show up in the file index of

[MediaWiki-commits] [Gerrit] Improved debug output - change (mediawiki...SemanticMediaWiki[master])

2012-10-27 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Improved debug output .. Improved debug output Use wfDebug. The cache utilisation statistics are somewhat interesting and could remain in the code

[MediaWiki-commits] [Gerrit] Fixed I0c98593a that broke parsing with older MWs - change (mediawiki...SemanticMediaWiki[master])

2012-10-27 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed I0c98593a that broke parsing with older MWs .. Fixed I0c98593a that broke parsing with older MWs Change-Id: Icaa74c2b3be35b1a1fca9f620ae46c9ca8f692cd

[MediaWiki-commits] [Gerrit] Fixed I0c98593a that broke parsing with older MWs - change (mediawiki...SemanticMediaWiki[master])

2012-10-27 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed I0c98593a that broke parsing with older MWs .. Fixed I0c98593a that broke parsing with older MWs Change-Id:

[MediaWiki-commits] [Gerrit] Support Blob in all places where String works - change (mediawiki...SemanticMediaWiki[master])

2012-10-27 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Support Blob in all places where String works .. Support Blob in all places where String works This is essential for using SQLStore3 which always returns

[MediaWiki-commits] [Gerrit] Do not use DISTINCT in vain - change (mediawiki...SemanticMediaWiki[master])

2012-10-27 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Do not use DISTINCT in vain .. Do not use DISTINCT in vain Propery-value pairs of subjects are DISTINCT by default. Do not ask the DB to ensure this again

[MediaWiki-commits] [Gerrit] Control hash size for blob values - change (mediawiki...SemanticMediaWiki[master])

2012-10-27 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Control hash size for blob values .. Control hash size for blob values Instead of the max value of 255, only 72 chars are used now before resorting to

[MediaWiki-commits] [Gerrit] refactor store dependent stuff to be in the relevant store c... - change (mediawiki...SemanticMediaWiki[master])

2012-10-26 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: refactor store dependent stuff to be in the relevant store class .. refactor store dependent stuff to be in the relevant store class Change-Id:

[MediaWiki-commits] [Gerrit] Corrected table name after name change - change (mediawiki...SemanticMediaWiki[master])

2012-10-25 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Corrected table name after name change .. Corrected table name after name change This fixes a bug observed in the discussion of

[MediaWiki-commits] [Gerrit] Fixed reference to outdated table name - change (mediawiki...SemanticMediaWiki[master])

2012-10-24 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed reference to outdated table name .. Fixed reference to outdated table name Name no longer hardcoded now. Change-Id:

[MediaWiki-commits] [Gerrit] Fixed Bug 41344 - change (mediawiki...SemanticMediaWiki[master])

2012-10-24 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed Bug 41344 .. Fixed Bug 41344 Trivial fix to a typo in code introduced earlier. Not worth mentioning in release notes. Change-Id:

[MediaWiki-commits] [Gerrit] Fixed Bug 41344 - change (mediawiki...SemanticMediaWiki[master])

2012-10-24 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed Bug 41344 .. Fixed Bug 41344 Trivial fix to a typo in code introduced earlier. Not worth mentioning in release notes. Update: Fixed fix to

[MediaWiki-commits] [Gerrit] Fixed some queries that where not using mw db abstraction la... - change (mediawiki...SemanticMediaWiki[master])

2012-10-22 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed some queries that where not using mw db abstraction layer and failing on any setup with table prefix .. Fixed some queries that where not

[MediaWiki-commits] [Gerrit] Fixed reference to outdated table name - change (mediawiki...SemanticMediaWiki[master])

2012-10-22 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed reference to outdated table name .. Fixed reference to outdated table name Name no longer hardcoded now. Change-Id:

[MediaWiki-commits] [Gerrit] Simplify code in SQLStore3, unify table names - change (mediawiki...SemanticMediaWiki[master])

2012-10-21 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Simplify code in SQLStore3, unify table names .. Simplify code in SQLStore3, unify table names * Eliminated many methods related to finding table names *

[MediaWiki-commits] [Gerrit] Fewer database SELECTs for getting property values - change (mediawiki...SemanticMediaWiki[master])

2012-10-21 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fewer database SELECTs for getting property values .. Fewer database SELECTs for getting property values Retrieve data more selectively when looking for a

[MediaWiki-commits] [Gerrit] Fewer database SELECTs for getting property values - change (mediawiki...SemanticMediaWiki[master])

2012-10-21 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fewer database SELECTs for getting property values .. Fewer database SELECTs for getting property values Retrieve data more selectively when looking

[MediaWiki-commits] [Gerrit] Init self::$fixed_prop_tableid before using it - change (mediawiki...SemanticMediaWiki[master])

2012-10-21 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Init self::$fixed_prop_tableid before using it .. Init self::$fixed_prop_tableid before using it This caused an error in some tests. Change-Id:

[MediaWiki-commits] [Gerrit] Init self::$fixed_prop_tableid before using it - change (mediawiki...SemanticMediaWiki[master])

2012-10-21 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Init self::$fixed_prop_tableid before using it .. Init self::$fixed_prop_tableid before using it This caused an error in some tests. Change-Id:

[MediaWiki-commits] [Gerrit] Use stored hashes to avoid additional SELECTs - change (mediawiki...SemanticMediaWiki[master])

2012-10-21 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Use stored hashes to avoid additional SELECTs .. Use stored hashes to avoid additional SELECTs This change significantly reduces the number of SELECT

[MediaWiki-commits] [Gerrit] Added some @since and @param tags - change (mediawiki...SemanticMediaWiki[master])

2012-10-21 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Added some @since and @param tags .. Added some @since and @param tags Change-Id: I3b93a842b4969d0280d3dcb151087b780c6c6d1a --- M

[MediaWiki-commits] [Gerrit] Caching mechanism for property table hashes - change (mediawiki...SemanticMediaWiki[master])

2012-10-21 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Caching mechanism for property table hashes .. Caching mechanism for property table hashes Property hashes are optionally read and cached when reading the

[MediaWiki-commits] [Gerrit] Improvements for SQLStore3 - change (mediawiki...SemanticMediaWiki[master])

2012-10-20 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Improvements for SQLStore3 .. Improvements for SQLStore3 Partial refactoring (more to come): * Code cleanup and simplification, esp in

[MediaWiki-commits] [Gerrit] Improvements for SQLStore3 - change (mediawiki...SemanticMediaWiki[master])

2012-10-20 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Improvements for SQLStore3 .. Improvements for SQLStore3 Partial refactoring (more to come): * Code cleanup and simplification, esp in

[MediaWiki-commits] [Gerrit] Do not index serialisation strings for numbers - change (mediawiki...SemanticMediaWiki[master])

2012-10-20 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Do not index serialisation strings for numbers .. Do not index serialisation strings for numbers No string matching on numerals, one index less. Change-Id:

[MediaWiki-commits] [Gerrit] Do not index serialisation strings for numbers - change (mediawiki...SemanticMediaWiki[master])

2012-10-20 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Do not index serialisation strings for numbers .. Do not index serialisation strings for numbers No string matching on numerals, one index less.

[MediaWiki-commits] [Gerrit] Improved Time handling - change (mediawiki...SemanticMediaWiki[master])

2012-10-19 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Improved Time handling .. Improved Time handling * Fixed Bug 41126 by storing dates in full serialised format, including calendar model * New serialised

[MediaWiki-commits] [Gerrit] Improved Time handling - change (mediawiki...SemanticMediaWiki[master])

2012-10-19 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Improved Time handling .. Improved Time handling * Fixed Bug 41126 by storing dates in full serialised format, including calendar model * New

[MediaWiki-commits] [Gerrit] Implement consequences of new Container handling - change (mediawiki...SemanticMediaWiki[master])

2012-10-19 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Implement consequences of new Container handling .. Implement consequences of new Container handling Container DIs have recently become virtual -- they are

[MediaWiki-commits] [Gerrit] Implement consequences of new Container handling - change (mediawiki...SemanticMediaWiki[master])

2012-10-19 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Implement consequences of new Container handling .. Implement consequences of new Container handling Container DIs have recently become virtual --

[MediaWiki-commits] [Gerrit] Check validity before accessing member object - change (mediawiki...SemanticMediaWiki[master])

2012-10-19 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Check validity before accessing member object .. Check validity before accessing member object This fixes a rare error caused by accessing a null object.

[MediaWiki-commits] [Gerrit] Check validity before accessing member object - change (mediawiki...SemanticMediaWiki[master])

2012-10-19 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Check validity before accessing member object .. Check validity before accessing member object This fixes a rare error caused by accessing a null

[MediaWiki-commits] [Gerrit] Update Store3 layout for geo coordinates - change (mediawiki...SemanticMediaWiki[master])

2012-10-19 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Update Store3 layout for geo coordinates .. Update Store3 layout for geo coordinates No longer store altitude in float column (not used); store

[MediaWiki-commits] [Gerrit] Fix Bug 37575 - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 37575 .. Fix Bug 37575 Applied patch submitted by Francesco Panico and Andre Klapper: * Correct insert syntax for empty default graph. * Set mime

[MediaWiki-commits] [Gerrit] Fix Bug 37575 - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 37575 .. Fix Bug 37575 Applied patch submitted by Francesco Panico and Andre Klapper: * Correct insert syntax for empty default graph. * Set

[MediaWiki-commits] [Gerrit] Fix Bug 38136 - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 38136 .. Fix Bug 38136 If a delay is given, it is now applied after every page, not only after batches of 100. Change-Id:

[MediaWiki-commits] [Gerrit] Fix Bug 38136 - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 38136 .. Fix Bug 38136 If a delay is given, it is now applied after every page, not only after batches of 100. Change-Id:

[MediaWiki-commits] [Gerrit] Fix Bug 38489 - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 38489 .. Fix Bug 38489 Detect the specific problem reported for Bug 38489 and also check for similar exceptions that might happen due to problems

[MediaWiki-commits] [Gerrit] Fix Bug 38489 - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 38489 .. Fix Bug 38489 Detect the specific problem reported for Bug 38489 and also check for similar exceptions that might happen due to

[MediaWiki-commits] [Gerrit] Fix Bug 39392 - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 39392 .. Fix Bug 39392 When returning unlinked URLs in wikitext, additional escaping is needed to prevent MediaWiki from turning them into

[MediaWiki-commits] [Gerrit] Fix Bug 39392 - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 39392 .. Fix Bug 39392 When returning unlinked URLs in wikitext, additional escaping is needed to prevent MediaWiki from turning them into

[MediaWiki-commits] [Gerrit] Use md5() instead of hash_init() et al. - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Use md5() instead of hash_init() et al. .. Use md5() instead of hash_init() et al. This fixes Bug 38185. The hash function has also been changed to

[MediaWiki-commits] [Gerrit] Fix Bug 37065 - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 37065 .. Fix Bug 37065 Prepend : when serialising namespace queries for NS_CATEGORY. Without this, the serialised query cannot be parsed properly,

[MediaWiki-commits] [Gerrit] Fix Bug 37065 - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 37065 .. Fix Bug 37065 Prepend : when serialising namespace queries for NS_CATEGORY. Without this, the serialised query cannot be parsed

[MediaWiki-commits] [Gerrit] Fixed use of SQL2 constants in SQLStore3 - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed use of SQL2 constants in SQLStore3 .. Fixed use of SQL2 constants in SQLStore3 Most of the constants were just defined under the old name, which could

[MediaWiki-commits] [Gerrit] Fixed use of SQL2 constants in SQLStore3 - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed use of SQL2 constants in SQLStore3 .. Fixed use of SQL2 constants in SQLStore3 Most of the constants were just defined under the old name,

[MediaWiki-commits] [Gerrit] Fixed capitalisation in function call (minor) - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed capitalisation in function call (minor) .. Fixed capitalisation in function call (minor) Change-Id: If61d9272f522250d592f50022843fd6d36497fcc --- M

[MediaWiki-commits] [Gerrit] Fixed capitalisation in function call (minor) - change (mediawiki...SemanticMediaWiki[master])

2012-10-17 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed capitalisation in function call (minor) .. Fixed capitalisation in function call (minor) Change-Id: If61d9272f522250d592f50022843fd6d36497fcc

[MediaWiki-commits] [Gerrit] Small fix in debugging method. - change (mediawiki...SemanticMediaWiki[master])

2012-10-16 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Small fix in debugging method. .. Small fix in debugging method. Change-Id: I6c5904347ee6f81c6e425abd6272965fb16a94d9 --- M

[MediaWiki-commits] [Gerrit] Correctly handle nested subdata - change (mediawiki...SemanticMediaWiki[master])

2012-10-16 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Correctly handle nested subdata .. Correctly handle nested subdata The new implementation flattens all nested subdata as it gets added and ensures that no

[MediaWiki-commits] [Gerrit] Small fix in debugging method. - change (mediawiki...SemanticMediaWiki[master])

2012-10-16 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Small fix in debugging method. .. Small fix in debugging method. Change-Id: I6c5904347ee6f81c6e425abd6272965fb16a94d9 --- M

[MediaWiki-commits] [Gerrit] Correctly handle nested subdata - change (mediawiki...SemanticMediaWiki[master])

2012-10-16 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Correctly handle nested subdata .. Correctly handle nested subdata The new implementation flattens all nested subdata as it gets added and ensures

[MediaWiki-commits] [Gerrit] Tiny fix in debugging method - change (mediawiki...SemanticMediaWiki[master])

2012-10-16 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Tiny fix in debugging method .. Tiny fix in debugging method Change-Id: Ia6a9034bf97cca8c23769a14ed8bbc8075c761bd --- M

[MediaWiki-commits] [Gerrit] Tiny fix in debugging method - change (mediawiki...SemanticMediaWiki[master])

2012-10-16 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Tiny fix in debugging method .. Tiny fix in debugging method Change-Id: Ia6a9034bf97cca8c23769a14ed8bbc8075c761bd --- M

[MediaWiki-commits] [Gerrit] Limit support for outdated Type: namespace prefix - change (mediawiki...SemanticMediaWiki[master])

2012-10-15 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Limit support for outdated Type: namespace prefix .. Limit support for outdated Type: namespace prefix Types with prefix Type: (or equivalent in other

[MediaWiki-commits] [Gerrit] Rewritten access/caching layer for smw_ids - change (mediawiki...SemanticMediaWiki[master])

2012-10-15 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review. Change subject: Rewritten access/caching layer for smw_ids .. Rewritten access/caching layer for smw_ids The new implementation significantly reduces the amount of SQL

[MediaWiki-commits] [Gerrit] Limit support for outdated Type: namespace prefix - change (mediawiki...SemanticMediaWiki[master])

2012-10-15 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Limit support for outdated Type: namespace prefix .. Limit support for outdated Type: namespace prefix Types with prefix Type: (or equivalent in

[MediaWiki-commits] [Gerrit] Corrected handling of error DIs and DVs - change (mediawiki...SemanticMediaWiki[master])

2012-10-15 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Corrected handling of error DIs and DVs .. Corrected handling of error DIs and DVs Error were wrongly assigned the String DI type in some contexts,

  1   2   >