from:"Reedy $Code Review$"

[MediaWiki-commits] [Gerrit] mediawiki...TrustedXFF[master]: Update IPSet use statement

2018-01-20 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405568 )

Change subject: Update IPSet use statement
..

Update IPSet use statement

Bug: T182273
Change-Id: I090b3e49304d7c966e91b3e23381cd147732ffd9
---
M TrustedXFF.body.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TrustedXFF 
refs/changes/68/405568/1

diff --git a/TrustedXFF.body.php b/TrustedXFF.body.php
index 445316a..27e3f87 100644
--- a/TrustedXFF.body.php
+++ b/TrustedXFF.body.php
@@ -1,7 +1,7 @@
 https://gerrit.wikimedia.org/r/405568
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I090b3e49304d7c966e91b3e23381cd147732ffd9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TrustedXFF
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ParsoidBatchAPI[master]: Update IPSet use statement

2018-01-20 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405567 )

Change subject: Update IPSet use statement
..

Update IPSet use statement

Bug: T182273
Change-Id: I63db3f4e28435800d3f7deee7d81c889fd56b640
---
M includes/ApiParsoidBatch.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ParsoidBatchAPI 
refs/changes/67/405567/1

diff --git a/includes/ApiParsoidBatch.php b/includes/ApiParsoidBatch.php
index cc5b95b..3918ff5 100644
--- a/includes/ApiParsoidBatch.php
+++ b/includes/ApiParsoidBatch.php
@@ -1,6 +1,6 @@
 https://gerrit.wikimedia.org/r/405567
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63db3f4e28435800d3f7deee7d81c889fd56b640
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ParsoidBatchAPI
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Linter[master]: Update IPSet use statement

2018-01-20 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405566 )

Change subject: Update IPSet use statement
..

Update IPSet use statement

Bug: T182273
Change-Id: I4f04462d13a37efd10e1e530a9b79e45cfb90309
---
M includes/ApiRecordLint.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Linter 
refs/changes/66/405566/1

diff --git a/includes/ApiRecordLint.php b/includes/ApiRecordLint.php
index 26f2853..9a303e1 100644
--- a/includes/ApiRecordLint.php
+++ b/includes/ApiRecordLint.php
@@ -22,10 +22,10 @@
 
 use ApiBase;
 use FormatJson;
-use IPSet\IPSet;
 use JobQueueGroup;
 use MediaWiki\Logger\LoggerFactory;
 use Title;
+use Wikimedia\IPSet;
 
 /**
  * API module for an external service to record

-- 
To view, visit https://gerrit.wikimedia.org/r/405566
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f04462d13a37efd10e1e530a9b79e45cfb90309
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Linter
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Gadgets[master]: Update WrappedString use statement

2018-01-20 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405565 )

Change subject: Update WrappedString use statement
..

Update WrappedString use statement

Bug: T182273
Change-Id: I5910d0dad3b28e087548799f5aba0e8f7e74ae0d
---
M GadgetHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gadgets 
refs/changes/65/405565/1

diff --git a/GadgetHooks.php b/GadgetHooks.php
index b8fdf0d..312cb4f 100644
--- a/GadgetHooks.php
+++ b/GadgetHooks.php
@@ -20,7 +20,7 @@
  *
  * @file
  */
-use WrappedString\WrappedString;
+use Wikimedia\WrappedString;
 
 class GadgetHooks {
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/405565
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5910d0dad3b28e087548799f5aba0e8f7e74ae0d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[master]: Update RunningStat use statement

2018-01-20 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405564 )

Change subject: Update RunningStat use statement
..

Update RunningStat use statement

Bug: T182273
Change-Id: Ida16060a6f0f125a0f5dabdb446b94b93db80cd1
---
M common/Hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto 
refs/changes/64/405564/1

diff --git a/common/Hooks.php b/common/Hooks.php
index 69d8b42..9a5ffe7 100644
--- a/common/Hooks.php
+++ b/common/Hooks.php
@@ -21,7 +21,7 @@
  */
 
 use MediaWiki\MediaWikiServices;
-use RunningStat\PSquare;
+use Wikimedia\PSquare;
 
 /**
  * Hooks for the Scribunto extension.

-- 
To view, visit https://gerrit.wikimedia.org/r/405564
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida16060a6f0f125a0f5dabdb446b94b93db80cd1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update RunningStat use statement

2018-01-20 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405563 )

Change subject: Update RunningStat use statement
..

Update RunningStat use statement

Bug: T182273
Change-Id: If9e946e767ca8f4c1af9b1a4855bbbffb98deff5
---
M includes/libs/XhprofData.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/63/405563/1

diff --git a/includes/libs/XhprofData.php b/includes/libs/XhprofData.php
index 0be4ff6..8762446 100644
--- a/includes/libs/XhprofData.php
+++ b/includes/libs/XhprofData.php
@@ -18,7 +18,7 @@
  * @file
  */
 
-use RunningStat\RunningStat;
+use Wikimedia\RunningStat;
 
 /**
  * Convenience class for working with XHProf profiling data

-- 
To view, visit https://gerrit.wikimedia.org/r/405563
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9e946e767ca8f4c1af9b1a4855bbbffb98deff5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update WrappedString use statements

2018-01-20 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405562 )

Change subject: Update WrappedString use statements
..

Update WrappedString use statements

Bug: T182273
Change-Id: Ia9515863491fa9c8684698fa33612eec5eb6d937
---
M includes/OutputPage.php
M includes/resourceloader/ResourceLoader.php
M includes/resourceloader/ResourceLoaderClientHtml.php
3 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/62/405562/1

diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index c17d50f..fc7fbf7 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -24,8 +24,8 @@
 use MediaWiki\MediaWikiServices;
 use MediaWiki\Session\SessionManager;
 use Wikimedia\RelPath;
-use WrappedString\WrappedString;
-use WrappedString\WrappedStringList;
+use Wikimedia\WrappedString;
+use Wikimedia\WrappedStringList;
 
 /**
  * This class should be covered by a general architecture document which does
diff --git a/includes/resourceloader/ResourceLoader.php 
b/includes/resourceloader/ResourceLoader.php
index e1d4f26..36bf656 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -26,8 +26,8 @@
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
-use WrappedString\WrappedString;
 use Wikimedia\Rdbms\DBConnectionError;
+use Wikimedia\WrappedString;
 
 /**
  * Dynamic JavaScript and CSS resource loading system.
diff --git a/includes/resourceloader/ResourceLoaderClientHtml.php 
b/includes/resourceloader/ResourceLoaderClientHtml.php
index c76ed91f..fe9e56f 100644
--- a/includes/resourceloader/ResourceLoaderClientHtml.php
+++ b/includes/resourceloader/ResourceLoaderClientHtml.php
@@ -18,7 +18,7 @@
  * @file
  */
 
-use WrappedString\WrappedStringList;
+use Wikimedia\WrappedStringList;
 
 /**
  * Bootstrap a ResourceLoader client on an HTML page.

-- 
To view, visit https://gerrit.wikimedia.org/r/405562
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9515863491fa9c8684698fa33612eec5eb6d937
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update IPSet use statements

2018-01-20 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405561 )

Change subject: Update IPSet use statements
..

Update IPSet use statements

Bug: T182273
Change-Id: I73fb52678dc56a542eccd209441557610b562d4b
---
M includes/ProxyLookup.php
M includes/libs/IP.php
M includes/user/User.php
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/61/405561/1

diff --git a/includes/ProxyLookup.php b/includes/ProxyLookup.php
index 3a3243a..246ae95 100644
--- a/includes/ProxyLookup.php
+++ b/includes/ProxyLookup.php
@@ -19,7 +19,7 @@
  * @file
  */
 
-use IPSet\IPSet;
+use Wikimedia\IPSet;
 
 /**
  * @since 1.28
diff --git a/includes/libs/IP.php b/includes/libs/IP.php
index 1c48f49..f95bb1e 100644
--- a/includes/libs/IP.php
+++ b/includes/libs/IP.php
@@ -21,7 +21,7 @@
  * @author Antoine Musso ""
  */
 
-use IPSet\IPSet;
+use Wikimedia\IPSet;
 
 // Some regex definition to "play" with IP address and IP address ranges
 
diff --git a/includes/user/User.php b/includes/user/User.php
index 0b3f8fd..5bab876 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -20,7 +20,6 @@
  * @file
  */
 
-use IPSet\IPSet;
 use MediaWiki\MediaWikiServices;
 use MediaWiki\Session\SessionManager;
 use MediaWiki\Session\Token;
@@ -28,6 +27,7 @@
 use MediaWiki\Auth\AuthenticationResponse;
 use MediaWiki\Auth\AuthenticationRequest;
 use MediaWiki\User\UserIdentity;
+use Wikimedia\IPSet;
 use Wikimedia\ScopedCallback;
 use Wikimedia\Rdbms\Database;
 use Wikimedia\Rdbms\DBExpectedError;

-- 
To view, visit https://gerrit.wikimedia.org/r/405561
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I73fb52678dc56a542eccd209441557610b562d4b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update RelPath calls

2018-01-20 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405560 )

Change subject: Update RelPath calls
..

Update RelPath calls

Bug: T182273
Change-Id: Ifd04e3b3ab72cc56bef48a1fc18fccb34b0af618
---
M includes/OutputPage.php
M includes/resourceloader/ResourceLoaderModule.php
2 files changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/60/405560/1

diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index e8b000e..c17d50f 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -23,6 +23,7 @@
 use MediaWiki\Logger\LoggerFactory;
 use MediaWiki\MediaWikiServices;
 use MediaWiki\Session\SessionManager;
+use Wikimedia\RelPath;
 use WrappedString\WrappedString;
 use WrappedString\WrappedStringList;
 
@@ -3818,7 +3819,7 @@
$remotePathPrefix = $remotePath = $uploadPath;
}
 
-   $path = RelPath\getRelativePath( $path, $remotePath );
+   $path = RelPath::getRelativePath( $path, $remotePath );
return self::transformFilePath( $remotePathPrefix, $localDir, 
$path );
}
 
diff --git a/includes/resourceloader/ResourceLoaderModule.php 
b/includes/resourceloader/ResourceLoaderModule.php
index 4deb7fa..a6ec72a 100644
--- a/includes/resourceloader/ResourceLoaderModule.php
+++ b/includes/resourceloader/ResourceLoaderModule.php
@@ -26,6 +26,7 @@
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
+use Wikimedia\RelPath;
 use Wikimedia\ScopedCallback;
 
 /**
@@ -527,7 +528,7 @@
public static function getRelativePaths( array $filePaths ) {
global $IP;
return array_map( function ( $path ) use ( $IP ) {
-   return RelPath\getRelativePath( $path, $IP );
+   return RelPath::getRelativePath( $path, $IP );
}, $filePaths );
}
 
@@ -541,7 +542,7 @@
public static function expandRelativePaths( array $filePaths ) {
global $IP;
return array_map( function ( $path ) use ( $IP ) {
-   return RelPath\joinPath( $IP, $path );
+   return RelPath::joinPath( $IP, $path );
}, $filePaths );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/405560
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd04e3b3ab72cc56bef48a1fc18fccb34b0af618
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMessages[master]: Add tag-AWB and tag-AWB-descrption

2018-01-20 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405531 )

Change subject: Add tag-AWB and tag-AWB-descrption
..

Add tag-AWB and tag-AWB-descrption

Bug: T111663
Bug: T185382
Change-Id: I8b510a20c516baa83908c8d10cf200480b192610
---
M i18n/wikimedia/en.json
M i18n/wikimedia/qqq.json
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaMessages 
refs/changes/31/405531/1

diff --git a/i18n/wikimedia/en.json b/i18n/wikimedia/en.json
index a323f3f..2ac7b45 100644
--- a/i18n/wikimedia/en.json
+++ b/i18n/wikimedia/en.json
@@ -198,6 +198,8 @@
"grouppage-wmf-supportsafety": "{{ns:project}}:WMF Support and Safety",
"tag-emoji": "Emoji",
"tag-emoji-description": "Used by global abuse filter 110.",
+   "tag-AWB": "[[Wikipedia:AutoWikiBrowser|AWB]]",
+   "tag-AWB-description": "Edits made with 
[[Wikipedia:AutoWikiBrowser|AWB]]",
"search-interwiki-custom": "wikt:From Wiktionary\nb:From 
Wikibooks\nn:From Wikinews\nq:From Wikiquote\ns:From Wikisource\nv:From 
Wikiversity\nvoy:From Wikivoyage",
"shared-repo-name-shared": "Wikimedia Commons",
"wikimedia-copyright": "Text is available under the https://creativecommons.org/licenses/by-sa/3.0/\;>Creative Commons 
Attribution-ShareAlike License;\nadditional terms may apply.\nSee https://wikimediafoundation.org/wiki/Terms_of_Use\;>Terms of Use for 
details.",
diff --git a/i18n/wikimedia/qqq.json b/i18n/wikimedia/qqq.json
index 1e95968..e07115e 100644
--- a/i18n/wikimedia/qqq.json
+++ b/i18n/wikimedia/qqq.json
@@ -227,6 +227,8 @@
"grouppage-wmf-supportsafety": 
"{{optional}}\n{{doc-group|wmf-supportsafety|page}}\n{{Global grouppage}}",
"tag-emoji": "Name for a change tag. Shown in diffs and revision lists 
next to edits which have been tagged by an abuse filter, and on 
[[Special:Tags]].",
"tag-emoji-description": "Long description for a change tag. Shown on 
[[Special:Tags]].",
+   "tag-AWB": "Name for a change tag. Shown in diffs and revision lists 
next to edits which have been tagged as being made by AutoWikiBrowser, and on 
[[Special:Tags]].",
+   "tag-AWB-description":, "Long description for a change tag. Shown on 
[[Special:Tags]]."
"search-interwiki-custom": "{{doc-important|Please do not translate 
this only within a single line, even if you're translating this to East Asian 
languages (i.e. Chinese, Japanese, Korean and their dialects).}}\n\nFriendly 
sister project site names in search results, one project name per line, in an 
: format. For example, possible settings 
for the English Wikipedia are:\n\nwikt:Word definitions from Wiktionary\nb:In Wikibooks\nn:In Wikinews\nq:Quotes from Wikiquote\ns:From Wikisource\nv:From Wikiversity\nvoy:In Wikivoyage",
"shared-repo-name-shared": "{{optional}}\n\nA specific version of 
{{msg-mw|shared-repo}}; see [[MediaWiki:Shared-repo/qqq]] for more 
information.\n\n{{Identical|Wikimedia Commons}}",
"wikimedia-copyright": "{{Identical/Wikimedia-licensing}}\nThis message 
is displayed in the site footer. It is the default licensing policy for most 
Wikimedia sites. Replace Terms_of_Use in the URL with 
Special:MyLanguage/Terms_of_Use/, for example, 
Special:MyLanguage/Terms_of_Use/fr for French.",

-- 
To view, visit https://gerrit.wikimedia.org/r/405531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b510a20c516baa83908c8d10cf200480b192610
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMessages
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Set default when changing afl_namespace on pg

2018-01-19 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405360 )

Change subject: Set default when changing afl_namespace on pg
..

Set default when changing afl_namespace on pg

Bug: T185335
Change-Id: I91fa0bf316a920b21b541eed1d2a837d34ad5683
---
M includes/AbuseFilter.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter 
refs/changes/60/405360/2

diff --git a/includes/AbuseFilter.hooks.php b/includes/AbuseFilter.hooks.php
index 3175e02..6b5d533 100644
--- a/includes/AbuseFilter.hooks.php
+++ b/includes/AbuseFilter.hooks.php
@@ -602,7 +602,7 @@
$updater->addExtensionUpdate( [
'addPgExtIndex', 'abuse_filter_log', 
'abuse_filter_log_wiki', "(afl_wiki)" ] );
$updater->addExtensionUpdate( [
-   'changeField', 'abuse_filter_log', 
'afl_namespace', "INTEGER" ] );
+   'changeField', 'abuse_filter_log', 
'afl_namespace', "INTEGER", '' ] );
}
 
$updater->addExtensionUpdate( [ [ __CLASS__, 
'createAbuseFilterUser' ] ] );

-- 
To view, visit https://gerrit.wikimedia.org/r/405360
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I91fa0bf316a920b21b541eed1d2a837d34ad5683
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Add `alt` attribute to footer image

2018-01-19 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/405249 )

Change subject: Add `alt` attribute to footer image
..


Add `alt` attribute to footer image

Bug: T185288
Change-Id: I275cfb3e94ab1dec2ca1942f2b801b7c408ff69f
---
M 2017/community.html
M 2017/donors.html
M 2017/financials.html
M 2017/index.html
M 2017/leadership.html
M 2017/stories.html
6 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved



diff --git a/2017/community.html b/2017/community.html
index d3af20e..a890988 100644
--- a/2017/community.html
+++ b/2017/community.html
@@ -179,7 +179,7 @@
   The https://wikimediafoundation.org/wiki/File:Wikipedia-puzzleglobe-V2.svg; 
target="_blank">Wikipedia puzzle globe logo, by https://wikimediafoundation.org/wiki/Wikimedia_official_marks/About_the_official_Marks#Wikipedia_puzzle_globe;
 target="_blank">several authors, is licensed under CC BY-SA 3.0.
   https://wikimediafoundation.org/; target="_blank">Visit 
the Wikimedia Foundation.
   Created in collaboration with http://www.publicdesign.com/; target="_blank">Public, SF and https://mangrove-web.com/; target="_blank">Mangrove Web 
Development.
-https://www.charitynavigator.org/index.cfm?bay=search.summaryorgid=11212;
 target="_blank">
+https://www.charitynavigator.org/index.cfm?bay=search.summaryorgid=11212;
 target="_blank">
   
 
 
diff --git a/2017/donors.html b/2017/donors.html
index f7178e1..a73dd0e 100644
--- a/2017/donors.html
+++ b/2017/donors.html
@@ -769,7 +769,7 @@
   The https://wikimediafoundation.org/wiki/File:Wikipedia-puzzleglobe-V2.svg; 
target="_blank">Wikipedia puzzle globe logo, by https://wikimediafoundation.org/wiki/Wikimedia_official_marks/About_the_official_Marks#Wikipedia_puzzle_globe;
 target="_blank">several authors, is licensed under CC BY-SA 3.0.
   https://wikimediafoundation.org/; target="_blank">Visit 
the Wikimedia Foundation.
   Created in collaboration with http://www.publicdesign.com/; target="_blank">Public, SF and https://mangrove-web.com/; target="_blank">Mangrove Web 
Development.
-https://www.charitynavigator.org/index.cfm?bay=search.summaryorgid=11212;
 target="_blank">
+https://www.charitynavigator.org/index.cfm?bay=search.summaryorgid=11212;
 target="_blank">
   
 
 
diff --git a/2017/financials.html b/2017/financials.html
index 5f47773..8a12be1 100644
--- a/2017/financials.html
+++ b/2017/financials.html
@@ -489,7 +489,7 @@
   The https://wikimediafoundation.org/wiki/File:Wikipedia-puzzleglobe-V2.svg; 
target="_blank">Wikipedia puzzle globe logo, by https://wikimediafoundation.org/wiki/Wikimedia_official_marks/About_the_official_Marks#Wikipedia_puzzle_globe;
 target="_blank">several authors, is licensed under CC BY-SA 3.0.
   https://wikimediafoundation.org/; target="_blank">Visit 
the Wikimedia Foundation.
   Created in collaboration with http://www.publicdesign.com/; target="_blank">Public, SF and https://mangrove-web.com/; target="_blank">Mangrove Web 
Development.
-https://www.charitynavigator.org/index.cfm?bay=search.summaryorgid=11212;
 target="_blank">
+https://www.charitynavigator.org/index.cfm?bay=search.summaryorgid=11212;
 target="_blank">
   
 
 
diff --git a/2017/index.html b/2017/index.html
index f3fc85d..7b94088 100755
--- a/2017/index.html
+++ b/2017/index.html
@@ -4588,7 +4588,7 @@
   The https://wikimediafoundation.org/wiki/File:Wikipedia-puzzleglobe-V2.svg; 
target="_blank">Wikipedia puzzle globe logo, by https://wikimediafoundation.org/wiki/Wikimedia_official_marks/About_the_official_Marks#Wikipedia_puzzle_globe;
 target="_blank">several authors, is licensed under CC BY-SA 3.0.
   https://wikimediafoundation.org/; target="_blank">Visit 
the Wikimedia Foundation.
   Created in collaboration with http://www.publicdesign.com/; target="_blank">Public, SF and https://mangrove-web.com/; target="_blank">Mangrove Web 
Development.
-https://www.charitynavigator.org/index.cfm?bay=search.summaryorgid=11212;
 target="_blank">
+https://www.charitynavigator.org/index.cfm?bay=search.summaryorgid=11212;
 target="_blank">
   
 
 
diff --git a/2017/leadership.html b/2017/leadership.html
index da0ddcc..9e1fbd3 100644
--- a/2017/leadership.html
+++ b/2017/leadership.html
@@ -193,7 +193,7 @@
   The https://wikimediafoundation.org/wiki/File:Wikipedia-puzzleglobe-V2.svg; 
target="_blank">Wikipedia puzzle globe logo, by https://wikimediafoundation.org/wiki/Wikimedia_official_marks/About_the_official_Marks#Wikipedia_puzzle_globe;
 target="_blank">several authors, is licensed under CC BY-SA 3.0.
   https://wikimediafoundation.org/; target="_blank">Visit 
the Wikimedia Foundation.
   Created in collaboration with

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: PHP 5.5 is no longer supported as of mid 2016

2018-01-18 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405217 )

Change subject: PHP 5.5 is no longer supported as of mid 2016
..

PHP 5.5 is no longer supported as of mid 2016

5.6 is supported for security updates till December 2018

http://php.net/supported-versions.php

Change-Id: I5776d422ea12329293fda69cb707599f62ec5191
---
M includes/PHPVersionCheck.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/17/405217/1

diff --git a/includes/PHPVersionCheck.php b/includes/PHPVersionCheck.php
index da428dd..056c41a 100644
--- a/includes/PHPVersionCheck.php
+++ b/includes/PHPVersionCheck.php
@@ -94,7 +94,7 @@
'implementation' => 'PHP',
'version' => PHP_VERSION,
'vendor' => 'the PHP Group',
-   'upstreamSupported' => '5.5.0',
+   'upstreamSupported' => '5.6.0',
'minSupported' => '5.5.9',
'upgradeURL' => 'https://secure.php.net/downloads.php',
);

-- 
To view, visit https://gerrit.wikimedia.org/r/405217
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5776d422ea12329293fda69cb707599f62ec5191
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] RunningStat[master]: Swap GPL-2.0+ for GPL-2.0-or-later

2018-01-18 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405212 )

Change subject: Swap GPL-2.0+ for GPL-2.0-or-later
..

Swap GPL-2.0+ for GPL-2.0-or-later

Change-Id: I8261ad6665fb97d230058da14629e65a2ac971cf
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/RunningStat refs/changes/12/405212/1

diff --git a/composer.json b/composer.json
index 7d261bb..f2eddab 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"name": "wikimedia/running-stat",
"description": "PHP implementations of online statistical algorithms",
-   "license": "GPL-2.0+",
+   "license": "GPL-2.0-or-later",
"homepage": "https://www.mediawiki.org/wiki/RunningStat;,
"authors": [
{

-- 
To view, visit https://gerrit.wikimedia.org/r/405212
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8261ad6665fb97d230058da14629e65a2ac971cf
Gerrit-PatchSet: 1
Gerrit-Project: RunningStat
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] RunningStat[master]: Fix RelPath\RelPath to extend Wikimedia\RelPath not PSquare

2018-01-18 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405207 )

Change subject: Fix RelPath\RelPath to extend Wikimedia\RelPath not PSquare
..

Fix RelPath\RelPath to extend Wikimedia\RelPath not PSquare

Change-Id: Icb2a7966480953cbc92f4c31d67f187c9141d0d9
Follows-up: I65a8d36a5e74b9614c1109c19b66f99c66c8809c
---
M src/RunningStat/RunningStat.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/RunningStat refs/changes/07/405207/1

diff --git a/src/RunningStat/RunningStat.php b/src/RunningStat/RunningStat.php
index 0f39c9f..c27d24c 100644
--- a/src/RunningStat/RunningStat.php
+++ b/src/RunningStat/RunningStat.php
@@ -1,5 +1,5 @@
 https://gerrit.wikimedia.org/r/405207
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb2a7966480953cbc92f4c31d67f187c9141d0d9
Gerrit-PatchSet: 1
Gerrit-Project: RunningStat
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] RelPath[master]: Fix oinPath -> joinPath

2018-01-18 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405072 )

Change subject: Fix oinPath -> joinPath
..

Fix oinPath -> joinPath

Change-Id: Ibcfd6842d89461d9e6724ad7cb8ed0d16956294f
Follows-up: I65a8d36a5e74b9614c1109c19b66f99c66c8809c
---
M src/RelPath/RelPath.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/RelPath refs/changes/72/405072/1

diff --git a/src/RelPath/RelPath.php b/src/RelPath/RelPath.php
index a09e9ca..7c8d8a9 100644
--- a/src/RelPath/RelPath.php
+++ b/src/RelPath/RelPath.php
@@ -60,5 +60,5 @@
  * @return string
  */
 function joinPath( $base, $path ) {
-   return RelPath::oinPath( $base, $path );
+   return RelPath::joinPath( $base, $path );
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/405072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcfd6842d89461d9e6724ad7cb8ed0d16956294f
Gerrit-PatchSet: 1
Gerrit-Project: RelPath
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update wikimedia dependancies

2018-01-18 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405070 )

Change subject: Update wikimedia dependancies
..

Update wikimedia dependancies

Updated:
* wikimedia/relpath 2.0.0 -> 2.1.0
* wikimedia/running-stat 1.1.0 -> 1.2.0
* wikimedia/wrappedstring 2.2.0 -> 2.3.0

https://github.com/wikimedia/relpath/compare/2.0.0...2.1.0
https://github.com/wikimedia/runningstat/compare/v1.1.0...v1.2.0
https://github.com/wikimedia/WrappedString/compare/v2.2.0...v2.3.0

Bug: T182273
Change-Id: I23a734e7a5b9a7ff4d46901a9c5b3b51402687d5
Depends-On: Ib2402f41262549207c8386d74855240ca0d4a54b
---
M RELEASE-NOTES-1.31
M composer.json
2 files changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/70/405070/1

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index a50159c..042983e 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -48,6 +48,9 @@
   1.2.0 (development dependency).
 * Updated nikic/php-parser from 2.1.0 to 3.1.3
   (development dependency).
+* Updated wikimedia/relpath from 2.0.0 to 2.1.0.
+* Updated wikimedia/running-stat from 1.1.0 to 1.2.0.
+* Updated wikimedia/wrappedstring from 2.2.0 to 2.3.0.
 * …
 
  New external libraries 
diff --git a/composer.json b/composer.json
index 4ae1f00..0a541d0 100644
--- a/composer.json
+++ b/composer.json
@@ -38,14 +38,14 @@
"wikimedia/ip-set": "1.1.0",
"wikimedia/php-session-serializer": "1.0.4",
"wikimedia/purtle": "1.0.6",
-   "wikimedia/relpath": "2.0.0",
+   "wikimedia/relpath": "2.1.0",
"wikimedia/remex-html": "1.0.2",
-   "wikimedia/running-stat": "1.1.0",
+   "wikimedia/running-stat": "1.2.0",
"wikimedia/scoped-callback": "1.0.0",
"wikimedia/utfnormal": "1.1.0",
"wikimedia/timestamp": "1.0.0",
"wikimedia/wait-condition-loop": "1.0.1",
-   "wikimedia/wrappedstring": "2.2.0",
+   "wikimedia/wrappedstring": "2.3.0",
"zordius/lightncandy": "0.23"
},
"require-dev": {

-- 
To view, visit https://gerrit.wikimedia.org/r/405070
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I23a734e7a5b9a7ff4d46901a9c5b3b51402687d5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update wikimedia dependancies

2018-01-18 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405068 )

Change subject: Update wikimedia dependancies
..

Update wikimedia dependancies

Updated:
* wikimedia/relpath 2.0.0 -> 2.1.0,
* wikimedia/running-stat 1.1.0 -> 1.2.0
* wikimedia/wrappedstring 2.2.0 -> 2.3.0

https://github.com/wikimedia/relpath/compare/2.0.0...2.1.0
https://github.com/wikimedia/runningstat/compare/v1.1.0...v1.2.0
https://github.com/wikimedia/WrappedString/compare/v2.2.0...v2.3.0

Change-Id: Ib2402f41262549207c8386d74855240ca0d4a54b
---
M composer.json
M composer.lock
M composer/autoload_classmap.php
M composer/autoload_files.php
M composer/autoload_psr4.php
M composer/autoload_static.php
M composer/installed.json
A wikimedia/relpath/.phpcs.xml
M wikimedia/relpath/README.md
D wikimedia/relpath/src/RelPath.php
A wikimedia/relpath/src/RelPath/RelPath.php
A wikimedia/relpath/src/Wikimedia/RelPath.php
A wikimedia/running-stat/.phpcs.xml
M wikimedia/running-stat/COPYING
M wikimedia/running-stat/README.md
A wikimedia/running-stat/src/RunningStat/PSquare.php
A wikimedia/running-stat/src/RunningStat/RunningStat.php
R wikimedia/running-stat/src/Wikimedia/PSquare.php
R wikimedia/running-stat/src/Wikimedia/RunningStat.php
A wikimedia/wrappedstring/.phpcs.xml
M wikimedia/wrappedstring/README.md
R wikimedia/wrappedstring/src/Wikimedia/WrappedString.php
R wikimedia/wrappedstring/src/Wikimedia/WrappedStringList.php
A wikimedia/wrappedstring/src/WrappedString/WrappedString.php
A wikimedia/wrappedstring/src/WrappedString/WrappedStringList.php
25 files changed, 587 insertions(+), 440 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/68/405068/1

diff --git a/composer.json b/composer.json
index 23c9403..37fe2e4 100644
--- a/composer.json
+++ b/composer.json
@@ -120,16 +120,16 @@
"wikimedia/lucene-explain-parser": "1.0.0",
"wikimedia/php-session-serializer": "1.0.4",
"wikimedia/purtle": "1.0.6",
-   "wikimedia/relpath": "2.0.0",
+   "wikimedia/relpath": "2.1.0",
"wikimedia/remex-html": "1.0.2",
-   "wikimedia/running-stat": "1.1.0",
+   "wikimedia/running-stat": "1.2.0",
"wikimedia/scoped-callback": "1.0.0",
"wikimedia/testing-access-wrapper": "1.0.0",
"wikimedia/textcat": "1.2.0",
"wikimedia/timestamp": "1.0.0",
"wikimedia/utfnormal": "1.1.0",
"wikimedia/wait-condition-loop": "1.0.1",
-   "wikimedia/wrappedstring": "2.2.0",
+   "wikimedia/wrappedstring": "2.3.0",
"zordius/lightncandy": "0.23"
},
"require-dev": {
diff --git a/composer.lock b/composer.lock
index 79b8e27..99f02f9 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"content-hash": "837c313a820d305f7d8972f339ad3f58",
+"content-hash": "c91429ebdf5be04b0ba2fa96b7e840f0",
 "packages": [
 {
 "name": "composer/semver",
@@ -3163,16 +3163,16 @@
 },
 {
 "name": "wikimedia/relpath",
-"version": "2.0.0",
+"version": "2.1.0",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/RelPath.git;,
-"reference": "b0eeb17d31e4cde22dea0932dfb920a71a167c33"
+"reference": "e911fc0178e02fb52df5b46c86da051226845590"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/RelPath/zipball/b0eeb17d31e4cde22dea0932dfb920a71a167c33;,
-"reference": "b0eeb17d31e4cde22dea0932dfb920a71a167c33",
+"url": 
"https://api.github.com/repos/wikimedia/RelPath/zipball/e911fc0178e02fb52df5b46c86da051226845590;,
+"reference": "e911fc0178e02fb52df5b46c86da051226845590",
 "shasum": ""
 },
 "require": {
@@ -3180,13 +3180,14 @@
 },
 "require-dev": {
 "jakub-onderka/php-parallel-lint": "^0.9.0.0",
-"mediawiki/mediawiki-codesniffer": "^0.4.0.0",
+"mediawiki/mediawiki-codesniffer": "15.0.0",
 "phpunit/phpunit": "^4.8.9.0"
 },
 "type": "library",
 "autoload": {
 "files": [
-"src/RelPath.php"
+"src/RelPath/RelPath.php",
+"src/Wikimedia/RelPath.php"
 ]
 },
 "notification-url": "https://packagist.org/downloads/;,
@@ -3201,7 +3202,7 @@
 ],
 "description": "Compute a relative

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Remove mediawiki/at-ease dependancy

2018-01-18 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405064 )

Change subject: Remove mediawiki/at-ease dependancy
..

Remove mediawiki/at-ease dependancy

Code isn't used...

Bug: T185258
Change-Id: Ib45fdde00fda4e6ca6c8bbfb3f8cd68ec3b9d5ad
---
M composer.json
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/64/405064/1

diff --git a/composer.json b/composer.json
index 4e65b46..e950ccb 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,6 @@
"homepage": "https://www.mediawiki.org/wiki/OOUI;,
"license": "MIT",
"require": {
-   "mediawiki/at-ease": "1.1.0",
"php": ">=5.5.9"
},
"authors": [

-- 
To view, visit https://gerrit.wikimedia.org/r/405064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib45fdde00fda4e6ca6c8bbfb3f8cd68ec3b9d5ad
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] IPSet[master]: Swap GPL-2.0+ for GPL-2.0-or-later

2018-01-18 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405038 )

Change subject: Swap GPL-2.0+ for GPL-2.0-or-later
..

Swap GPL-2.0+ for GPL-2.0-or-later

Change-Id: Ie8959e4950a41886e044f5b8b0dc8f8f0d87982b
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/IPSet refs/changes/38/405038/1

diff --git a/composer.json b/composer.json
index 6744f4c..f37eb3c 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"name": "wikimedia/ip-set",
"description": "Efficiently match IP addresses against a set of CIDR 
specifications.",
-   "license": "GPL-2.0+",
+   "license": "GPL-2.0-or-later",
"homepage": "https://github.com/wikimedia/IPSet;,
"authors": [
{

-- 
To view, visit https://gerrit.wikimedia.org/r/405038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8959e4950a41886e044f5b8b0dc8f8f0d87982b
Gerrit-PatchSet: 1
Gerrit-Project: IPSet
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Update og:image and og:description on all 2017 pages

2018-01-17 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404901 )

Change subject: Update og:image and og:description on all 2017 pages
..


Update og:image and og:description on all 2017 pages

Change-Id: Ic9ed18fe8c7887321d31f038181397d83355cdec
---
M 2017/community.html
M 2017/donors.html
M 2017/financials.html
D 2017/images/wiki-og.png
M 2017/index.html
M 2017/leadership.html
M 2017/stories.html
7 files changed, 12 insertions(+), 12 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved



diff --git a/2017/community.html b/2017/community.html
index 767468f..d3af20e 100644
--- a/2017/community.html
+++ b/2017/community.html
@@ -10,8 +10,8 @@
 https://annual.wikimedia.org/2017/;>
 
 
-https://annual.wikimedia.org/2017/images/wiki-og.png;>
-
+https://annual.wikimedia.org/2017/images/image-imagine.jpg;>
+
 
 
 
diff --git a/2017/donors.html b/2017/donors.html
index 65259aa..f7178e1 100644
--- a/2017/donors.html
+++ b/2017/donors.html
@@ -10,8 +10,8 @@
 https://annual.wikimedia.org/2017/;>
 
 
-https://annual.wikimedia.org/2017/images/wiki-og.png;>
-
+https://annual.wikimedia.org/2017/images/image-imagine.jpg;>
+
 
 
 
diff --git a/2017/financials.html b/2017/financials.html
index 85427a0..5f47773 100644
--- a/2017/financials.html
+++ b/2017/financials.html
@@ -10,8 +10,8 @@
 https://annual.wikimedia.org/2017/;>
 
 
-https://annual.wikimedia.org/2017/images/wiki-og.png;>
-
+https://annual.wikimedia.org/2017/images/image-imagine.jpg;>
+
 
 
 
diff --git a/2017/images/wiki-og.png b/2017/images/wiki-og.png
deleted file mode 100644
index babf884..000
--- a/2017/images/wiki-og.png
+++ /dev/null
Binary files differ
diff --git a/2017/index.html b/2017/index.html
index 62b7055..f3fc85d 100755
--- a/2017/index.html
+++ b/2017/index.html
@@ -10,8 +10,8 @@
 https://annual.wikimedia.org/2017/;>
 
 
-https://annual.wikimedia.org/2017/images/wiki-og.png;>
-
+https://annual.wikimedia.org/2017/images/image-imagine.jpg;>
+
 
 
 
diff --git a/2017/leadership.html b/2017/leadership.html
index ed41663..da0ddcc 100644
--- a/2017/leadership.html
+++ b/2017/leadership.html
@@ -10,8 +10,8 @@
 https://annual.wikimedia.org/2017/;>
 
 
-https://annual.wikimedia.org/2017/images/wiki-og.png;>
-
+https://annual.wikimedia.org/2017/images/image-imagine.jpg;>
+
 
 
 
diff --git a/2017/stories.html b/2017/stories.html
index d083ce7..6734dcb 100644
--- a/2017/stories.html
+++ b/2017/stories.html
@@ -10,8 +10,8 @@
 https://annual.wikimedia.org/2017/;>
 
 
-https://annual.wikimedia.org/2017/images/wiki-og.png;>
-
+https://annual.wikimedia.org/2017/images/image-imagine.jpg;>
+
 
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/404901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9ed18fe8c7887321d31f038181397d83355cdec
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/annualreport
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] research/landing-page[refs/meta/config]: Modify access rules

2018-01-17 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404900 )

Change subject: Modify access rules
..

Modify access rules

Change-Id: Ib46f114dc1f5139452661ef095251c23b1c5cce1
---
M project.config
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/research/landing-page 
refs/changes/00/404900/1

diff --git a/project.config b/project.config
index dda1000..0a4aa8c 100644
--- a/project.config
+++ b/project.config
@@ -7,3 +7,4 @@
 [access "refs/*"]
owner = group research-landing-page
submit = group research-landing-page
+   push = group research-landing-page

-- 
To view, visit https://gerrit.wikimedia.org/r/404900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib46f114dc1f5139452661ef095251c23b1c5cce1
Gerrit-PatchSet: 1
Gerrit-Project: research/landing-page
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Add Piwik analytics to 2017 report (was already on 2016 and ...

2018-01-17 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404899 )

Change subject: Add Piwik analytics to 2017 report (was already on 2016 and 
2015 reports)
..


Add Piwik analytics to 2017 report (was already on 2016 and 2015 reports)

Change-Id: I486c2a7159920e3d6bc1df364b2d51fd516383f7
---
M 2017/community.html
M 2017/donors.html
M 2017/financials.html
M 2017/index.html
M 2017/leadership.html
M 2017/stories.html
6 files changed, 111 insertions(+), 3 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved



diff --git a/2017/community.html b/2017/community.html
index 5649103..767468f 100644
--- a/2017/community.html
+++ b/2017/community.html
@@ -21,6 +21,24 @@
 
 
 
+
+
+
+var _paq = _paq || [];
+_paq.push(["setDomains", 
["*.annual.wikimedia.org","*.annual.wikimedia.org"]]);
+_paq.push(['trackPageView']);
+_paq.push(['enableLinkTracking']);
+(function() {
+  var u="//piwik.wikimedia.org/";
+  _paq.push(['setTrackerUrl', u+'piwik.php']);
+  _paq.push(['setSiteId', 11]);
+  var d=document, g=d.createElement('script'), 
s=d.getElementsByTagName('script')[0];
+  g.type='text/javascript'; g.async=true; g.defer=true; 
g.src=u+'piwik.js'; s.parentNode.insertBefore(g,s);
+})();
+
+
+
+
   
   
 
diff --git a/2017/donors.html b/2017/donors.html
index d3c7ea8..65259aa 100644
--- a/2017/donors.html
+++ b/2017/donors.html
@@ -21,6 +21,24 @@
 
 
 
+
+
+
+var _paq = _paq || [];
+_paq.push(["setDomains", 
["*.annual.wikimedia.org","*.annual.wikimedia.org"]]);
+_paq.push(['trackPageView']);
+_paq.push(['enableLinkTracking']);
+(function() {
+  var u="//piwik.wikimedia.org/";
+  _paq.push(['setTrackerUrl', u+'piwik.php']);
+  _paq.push(['setSiteId', 11]);
+  var d=document, g=d.createElement('script'), 
s=d.getElementsByTagName('script')[0];
+  g.type='text/javascript'; g.async=true; g.defer=true; 
g.src=u+'piwik.js'; s.parentNode.insertBefore(g,s);
+})();
+
+
+
+
   
   
 
@@ -757,4 +775,4 @@
 
 
   
-
\ No newline at end of file
+
diff --git a/2017/financials.html b/2017/financials.html
index 64df5cf..85427a0 100644
--- a/2017/financials.html
+++ b/2017/financials.html
@@ -21,6 +21,24 @@
 
 
 
+
+
+
+var _paq = _paq || [];
+_paq.push(["setDomains", 
["*.annual.wikimedia.org","*.annual.wikimedia.org"]]);
+_paq.push(['trackPageView']);
+_paq.push(['enableLinkTracking']);
+(function() {
+  var u="//piwik.wikimedia.org/";
+  _paq.push(['setTrackerUrl', u+'piwik.php']);
+  _paq.push(['setSiteId', 11]);
+  var d=document, g=d.createElement('script'), 
s=d.getElementsByTagName('script')[0];
+  g.type='text/javascript'; g.async=true; g.defer=true; 
g.src=u+'piwik.js'; s.parentNode.insertBefore(g,s);
+})();
+
+
+
+
   
   
 
@@ -477,4 +495,4 @@
 
 
   
-
\ No newline at end of file
+
diff --git a/2017/index.html b/2017/index.html
index b227276..62b7055 100755
--- a/2017/index.html
+++ b/2017/index.html
@@ -21,6 +21,24 @@
 
 
 
+
+
+
+var _paq = _paq || [];
+_paq.push(["setDomains", 
["*.annual.wikimedia.org","*.annual.wikimedia.org"]]);
+_paq.push(['trackPageView']);
+_paq.push(['enableLinkTracking']);
+(function() {
+  var u="//piwik.wikimedia.org/";
+  _paq.push(['setTrackerUrl', u+'piwik.php']);
+  _paq.push(['setSiteId', 11]);
+  var d=document, g=d.createElement('script'), 
s=d.getElementsByTagName('script')[0];
+  g.type='text/javascript'; g.async=true; g.defer=true; 
g.src=u+'piwik.js'; s.parentNode.insertBefore(g,s);
+})();
+
+
+
+
   
   
 
@@ -4576,4 +4594,4 @@
 
 
   
-
\ No newline at end of file
+
diff --git a/2017/leadership.html b/2017/leadership.html
index 5df3929..ed41663 100644
--- a/2017/leadership.html
+++ b/2017/leadership.html
@@ -21,6 +21,24 @@
 
 
 
+
+
+
+var _paq = _paq || [];
+_paq.push(["setDomains", 
["*.annual.wikimedia.org","*.annual.wikimedia.org"]]);
+_paq.push(['trackPageView']);
+_paq.push(['enableLinkTracking']);
+(function() {
+  var u="//piwik.wikimedia.org/";
+  _paq.push(['setTrackerUrl', u+'piwik.php']);
+  _paq.push(['setSiteId', 11]);
+  var d=document, g=d.createElement('script'), 
s=d.getElementsByTagName('script')[0];
+  g.type='text/javascript'; g.async=true; g.defer=true; 
g.src=u+'piwik.js'; s.parentNode.insertBefore(g,s);
+})();
+
+
+
+
   
   
 
diff --git a/2017/stories.html b/2017/stories.html
index 568195b..d083ce7 100644
---

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Copy changes for 2017 annual report from Zack

2018-01-17 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404896 )

Change subject: Copy changes for 2017 annual report from Zack
..


Copy changes for 2017 annual report from Zack

Change-Id: I546377c88667e3933c7807cad8c3ea107ebccbb1
---
M 2017/community.html
M 2017/leadership.html
M 2017/stories.html
3 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved



diff --git a/2017/community.html b/2017/community.html
index 9e27e49..5649103 100644
--- a/2017/community.html
+++ b/2017/community.html
@@ -82,13 +82,13 @@
 Supporting our communities
   
   
-The Wikimedia Foundation provides strategic grants to support 
people and organizations around the world. Our aim is to increase the quantity, 
quality, diversity, and reach of free knowledge. This past fiscal year, https://meta.wikimedia.org/wiki/Community_Resources/Grants_spending_analysis#Grants_funded_July_2016-June_2017;
 target="_blank" rel="noopener">we awarded 397 grants totalling $7,089,729 
to communities in more than 80 countries worldwide.
+The Wikimedia Foundation provides strategic grants to support 
people and organizations around the world. Our aim is to increase the quantity, 
quality, diversity, and reach of free knowledge. This past fiscal year, https://meta.wikimedia.org/wiki/Community_Resources/Grants_spending_analysis#Grants_funded_July_2016-June_2017;
 target="_blank" rel="noopener">we awarded 392 grants totalling $7,089,729 
to communities in 80 countries worldwide.
 More than half of our grants in 2017 went to support volunteer 
communities in countries dramatically increasing their use of Wikipedia. This 
includes Armenia, Bangladesh, Nigeria, and Venezuela. We also awarded more than 
$700,000 in grants to support projects that focus on increasing the visibility 
and participation of women on Wikipedia.
   
   
 
   We made
-  397 
grants
+  392 
grants
 
 
   To support free knowledge in
diff --git a/2017/leadership.html b/2017/leadership.html
index 93f465f..5df3929 100644
--- a/2017/leadership.html
+++ b/2017/leadership.html
@@ -114,7 +114,7 @@
   Maggie Dennis Interim 
Chief of Community Engagement
   Lisa Seitz-Gruwell Chief Advancement Officer
   Eileen Hershenov General Counsel
-  Heather Walls Interim 
Chief of Communications
+  Heather Walls Chief 
Creative Officer
   Jaime Villagomez Chief 
Financial Officer
   Joady Lohr Chief 
Talent & Culture Officer
 
@@ -181,4 +181,4 @@
 
 
   
-
\ No newline at end of file
+
diff --git a/2017/stories.html b/2017/stories.html
index 253ef45..568195b 100644
--- a/2017/stories.html
+++ b/2017/stories.html
@@ -176,11 +176,11 @@
 
 
   
-https://stats.wikimedia.org/EN/TablesWikipediaZZ.htm; target="_blank" 
rel="noopener">More than 200,000 contributors worldwide volunteer their 
time each month to make Wikipedia better. Felix Nartey is one of them. He’s 
also our 2017 https://blog.wikimedia.org/2017/08/16/felix-nartey-wikimedian-of-the-year/;
 target="_blank" rel="noopener">Wikimedian of the Year. Felix volunteers 
his time to address systemic bias on Wikipedia by adding content about his home 
country of Ghana and researching why fewer people from the African continent 
tend to edit the site.
+https://stats.wikimedia.org/v2/#/all-projects; 
target="_blank" rel="noopener">More than 200,000 contributors worldwide 
volunteer their time each month to make Wikipedia better. Felix Nartey is one 
of them. He’s also our 2017 https://blog.wikimedia.org/2017/08/16/felix-nartey-wikimedian-of-the-year/;
 target="_blank" rel="noopener">Wikimedian of the Year. Felix volunteers 
his time to address systemic bias on Wikipedia by adding content about his home 
country of Ghana and researching why fewer people from the African continent 
tend to edit the site.
 Felix believes that knowledge sharing activities like 
editing Wikipedia have a positive effect on people’s lives, but at the present 
time there are https://en.wikipedia.org/wiki/Wikipedia:Systemic_bias; 
target="_blank" rel="noopener">significant content gaps on the site. For 
example, there are fewer articles about topics on the African continent than 
there are about Europe or North America, and those that do exist tend to be 
shorter and less detailed.
 Increasing the diversity of contributions on Wikipedia 
helps achieve higher-quality content and combat systemic bias, and that’s why 
many people—including Felix—are trying to identify the reasons behind these 
gaps and bridge them.
 As Felix

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Follow-up 79e29a401b: remove stray pipe

2018-01-17 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404895 )

Change subject: Follow-up 79e29a401b: remove stray pipe
..


Follow-up 79e29a401b: remove stray pipe

Change-Id: I7a7d38ecea1430cd7d8f58061a6de5f614095f6d
---
M 2017/community.html
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved



diff --git a/2017/community.html b/2017/community.html
index 8b84082..9e27e49 100644
--- a/2017/community.html
+++ b/2017/community.html
@@ -1,4 +1,4 @@
-|
+
 
   
 

-- 
To view, visit https://gerrit.wikimedia.org/r/404895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a7d38ecea1430cd7d8f58061a6de5f614095f6d
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/annualreport
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Make images relative not absolute

2018-01-17 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404891 )

Change subject: Make images relative not absolute
..

Make images relative not absolute

Bug: T185168
Change-Id: I3841c2384ee23f6a67c13201a8539a991ab1b002
---
M 2017/community.html
M 2017/donors.html
M 2017/financials.html
M 2017/index.html
M 2017/leadership.html
M 2017/stories.html
6 files changed, 44 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/annualreport 
refs/changes/91/404891/1

diff --git a/2017/community.html b/2017/community.html
index 76f32b2..8b84082 100644
--- a/2017/community.html
+++ b/2017/community.html
@@ -1,4 +1,4 @@
-
+|
 
   
 
@@ -13,13 +13,13 @@
 https://annual.wikimedia.org/2017/images/wiki-og.png;>
 
 
-
-
-
-
-
-
-
+
+
+
+
+
+
+
 
   
   
@@ -167,4 +167,4 @@
 
 
   
-
\ No newline at end of file
+
diff --git a/2017/donors.html b/2017/donors.html
index e5ef0d8..d3c7ea8 100644
--- a/2017/donors.html
+++ b/2017/donors.html
@@ -13,13 +13,13 @@
 https://annual.wikimedia.org/2017/images/wiki-og.png;>
 
 
-
-
-
-
-
-
-
+
+
+
+
+
+
+
 
   
   
diff --git a/2017/financials.html b/2017/financials.html
index f32e2d7..64df5cf 100644
--- a/2017/financials.html
+++ b/2017/financials.html
@@ -13,13 +13,13 @@
 https://annual.wikimedia.org/2017/images/wiki-og.png;>
 
 
-
-
-
-
-
-
-
+
+
+
+
+
+
+
 
   
   
diff --git a/2017/index.html b/2017/index.html
index 990f4d2..b227276 100755
--- a/2017/index.html
+++ b/2017/index.html
@@ -13,13 +13,13 @@
 https://annual.wikimedia.org/2017/images/wiki-og.png;>
 
 
-
-
-
-
-
-
-
+
+
+
+
+
+
+
 
   
   
diff --git a/2017/leadership.html b/2017/leadership.html
index c35f5a2..93f465f 100644
--- a/2017/leadership.html
+++ b/2017/leadership.html
@@ -13,13 +13,13 @@
 https://annual.wikimedia.org/2017/images/wiki-og.png;>
 
 
-
-
-
-
-
-
-
+
+
+
+
+
+
+
 
   
   
diff --git a/2017/stories.html b/2017/stories.html
index d0aed9b..253ef45 100644
--- a/2017/stories.html
+++ b/2017/stories.html
@@ -13,13 +13,13 @@
 https://annual.wikimedia.org/2017/images/wiki-og.png;>
 
 
-
-
-
-
-
-
-
+
+
+
+
+
+
+
 
   
   

-- 
To view, visit https://gerrit.wikimedia.org/r/404891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3841c2384ee23f6a67c13201a8539a991ab1b002
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/annualreport
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Update Heathers title

2018-01-17 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404890 )

Change subject: Update Heathers title
..

Update Heathers title

Bug: T185164
Change-Id: Ibe39c7a0dbb2433fbf4567c0aa2313b4875f31e4
---
M 2017/leadership.html
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/annualreport 
refs/changes/90/404890/1

diff --git a/2017/leadership.html b/2017/leadership.html
index c35f5a2..75ffd7d 100644
--- a/2017/leadership.html
+++ b/2017/leadership.html
@@ -114,7 +114,7 @@
   Maggie Dennis Interim 
Chief of Community Engagement
   Lisa Seitz-Gruwell Chief Advancement Officer
   Eileen Hershenov General Counsel
-  Heather Walls Interim 
Chief of Communications
+  Heather Walls Chief 
Creative Officer
   Jaime Villagomez Chief 
Financial Officer
   Joady Lohr Chief 
Talent & Culture Officer
 
@@ -181,4 +181,4 @@
 
 
   
-
\ No newline at end of file
+

-- 
To view, visit https://gerrit.wikimedia.org/r/404890
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe39c7a0dbb2433fbf4567c0aa2313b4875f31e4
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/annualreport
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia/annualreport[master]: Remove font demo.html files

2018-01-17 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404889 )

Change subject: Remove font demo.html files
..

Remove font demo.html files

Bug: T185169
Change-Id: I6c8b2ade0e66e9b47a61324454c9da9249916519
---
D 2016/fonts/droidsans-bold-demo.html
D 2016/fonts/droidsans-demo.html
D 2016/fonts/lora-bold-demo.html
D 2016/fonts/lora-bolditalic-demo.html
D 2016/fonts/lora-italic-demo.html
D 2016/fonts/lora-regular-demo.html
D 2016/fonts/montserrat-bold-demo.html
D 2016/fonts/montserrat-regular-demo.html
8 files changed, 0 insertions(+), 4,876 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/annualreport 
refs/changes/89/404889/1


-- 
To view, visit https://gerrit.wikimedia.org/r/404889
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c8b2ade0e66e9b47a61324454c9da9249916519
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/annualreport
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] WrappedString[master]: Remove back compat layer

2018-01-17 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404788 )

Change subject: Remove back compat layer
..

Remove back compat layer

Change-Id: I33c44e3ee0b8389e926a736bfa81a064a980f434
---
M composer.json
D src/WrappedString/WrappedString.php
D src/WrappedString/WrappedStringList.php
3 files changed, 1 insertion(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/WrappedString 
refs/changes/88/404788/1

diff --git a/composer.json b/composer.json
index e94eb50..fefe789 100644
--- a/composer.json
+++ b/composer.json
@@ -11,8 +11,7 @@
],
"autoload": {
"psr-4": {
-   "Wikimedia\\": "src/Wikimedia",
-   "WrappedString\\": "src/WrappedString"
+   "Wikimedia\\": "src/Wikimedia"
}
},
"autoload-dev": {
diff --git a/src/WrappedString/WrappedString.php 
b/src/WrappedString/WrappedString.php
deleted file mode 100644
index 5186b1c..000
--- a/src/WrappedString/WrappedString.php
+++ /dev/null
@@ -1,6 +0,0 @@
-https://gerrit.wikimedia.org/r/404788
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33c44e3ee0b8389e926a736bfa81a064a980f434
Gerrit-PatchSet: 1
Gerrit-Project: WrappedString
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] RelPath[master]: Remove back compat layer

2018-01-17 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404786 )

Change subject: Remove back compat layer
..

Remove back compat layer

Change-Id: Iad4a0fb11daf8c2f76e7dc1b2f2c5af74169d65b
---
M composer.json
D src/RelPath/RelPath.php
2 files changed, 0 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/RelPath refs/changes/86/404786/1

diff --git a/composer.json b/composer.json
index 041a8c0..d11744a 100644
--- a/composer.json
+++ b/composer.json
@@ -11,7 +11,6 @@
],
"autoload": {
"files": [
-   "src/RelPath/RelPath.php",
"src/Wikimedia/RelPath.php"
]
},
diff --git a/src/RelPath/RelPath.php b/src/RelPath/RelPath.php
deleted file mode 100644
index a09e9ca..000
--- a/src/RelPath/RelPath.php
+++ /dev/null
@@ -1,64 +0,0 @@
-
- *
- * Permission is hereby granted, free of charge, to any person obtaining
- * a copy of this software and associated documentation files (the
- * "Software"), to deal in the Software without restriction, including
- * without limitation the rights to use, copy, modify, merge, publish,
- * distribute, sublicense, and/or sell copies of the Software, and to
- * permit persons to whom the Software is furnished to do so, subject to
- * the following conditions:
- *
- * The above copyright notice and this permission notice shall be
- * included in all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
- * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
- * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
- * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
- * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
- * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
- *
- * @file
- * @author Ori Livneh 
- */
-
-namespace RelPath;
-
-use Wikimedia\RelPath;
-
-/**
- * Split a path into path components.
- *
- * @param string $path File path.
- * @return array Array of path components.
- */
-function splitPath( $path ) {
-   return RelPath::splitPath( $path );
-}
-
-/**
- * Return a relative filepath to path either from the current directory or from
- * an optional start directory. Both paths must be absolute.
- *
- * @param string $path File path.
- * @param string $start Start directory. Optional; if not specified, the 
current
- *  working directory will be used.
- * @return string|bool Relative path, or false if input was invalid.
- */
-function getRelativePath( $path, $start = null ) {
-   return RelPath::getRelativePath( $path, $start );
-}
-
-/**
- * Join path components.
- *
- * @param string $base Base path.
- * @param string $path File path to join to base path.
- * @return string
- */
-function joinPath( $base, $path ) {
-   return RelPath::oinPath( $base, $path );
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/404786
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad4a0fb11daf8c2f76e7dc1b2f2c5af74169d65b
Gerrit-PatchSet: 1
Gerrit-Project: RelPath
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] IPSet[master]: Remove back compat layer

2018-01-17 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404785 )

Change subject: Remove back compat layer
..

Remove back compat layer

Change-Id: If217b5514752dba71f3c97e33d8632bcf2dcc4bd
---
D src/IPSet/IPSet.php
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/IPSet refs/changes/85/404785/1

diff --git a/src/IPSet/IPSet.php b/src/IPSet/IPSet.php
deleted file mode 100644
index 31264cb..000
--- a/src/IPSet/IPSet.php
+++ /dev/null
@@ -1,6 +0,0 @@
-https://gerrit.wikimedia.org/r/404785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If217b5514752dba71f3c97e33d8632bcf2dcc4bd
Gerrit-PatchSet: 1
Gerrit-Project: IPSet
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] RunningStat[master]: Remove back compat layer

2018-01-17 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404784 )

Change subject: Remove back compat layer
..

Remove back compat layer

Change-Id: Ice31ace4cc1986792bf846e38c56cdda7d7a61c3
---
D src/RunningStat/PSquare.php
D src/RunningStat/RunningStat.php
2 files changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/RunningStat refs/changes/84/404784/1

diff --git a/src/RunningStat/PSquare.php b/src/RunningStat/PSquare.php
deleted file mode 100644
index 5ab2ef9..000
--- a/src/RunningStat/PSquare.php
+++ /dev/null
@@ -1,5 +0,0 @@
-https://gerrit.wikimedia.org/r/404784
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice31ace4cc1986792bf846e38c56cdda7d7a61c3
Gerrit-PatchSet: 1
Gerrit-Project: RunningStat
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] at-ease[master]: Remove back compat layer

2018-01-17 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404783 )

Change subject: Remove back compat layer
..

Remove back compat layer

Change-Id: I86ac9a82c7675e62a59a8279597d739204a04ab0
---
M composer.json
D src/MediaWiki/Functions.php
2 files changed, 0 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/at-ease refs/changes/83/404783/1

diff --git a/composer.json b/composer.json
index 8397ae2..941ac90 100644
--- a/composer.json
+++ b/composer.json
@@ -15,7 +15,6 @@
],
"autoload": {
"files": [
-   "src/MediaWiki/Functions.php",
"src/Wikimedia/Functions.php"
]
},
diff --git a/src/MediaWiki/Functions.php b/src/MediaWiki/Functions.php
deleted file mode 100644
index e54e056..000
--- a/src/MediaWiki/Functions.php
+++ /dev/null
@@ -1,51 +0,0 @@
-http://www.gnu.org/copyleft/gpl.html
- *
- * @file
- */
-
-namespace MediaWiki;
-
-/**
- * Reference-counted warning suppression
- *
- * @param bool $end Whether to restore warnings
- */
-function suppressWarnings( $end = false ) {
-   \Wikimedia\suppressWarnings( $end );
-}
-
-/**
- * Restore error level to previous value
- */
-function restoreWarnings() {
-   \Wikimedia\suppressWarnings( true );
-}
-
-/**
- * Call the callback given by the first parameter, suppressing any warnings.
- *
- * @param callable $callback Function to call
- * @return mixed
- */
-function quietCall( callable $callback /*, parameters... */ ) {
-   $args = array_slice( func_get_args(), 1 );
-   suppressWarnings();
-   $rv = call_user_func_array( $callback, $args );
-   restoreWarnings();
-   return $rv;
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/404783
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I86ac9a82c7675e62a59a8279597d739204a04ab0
Gerrit-PatchSet: 1
Gerrit-Project: at-ease
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] css-sanitizer[master]: Bump mediawiki/at-ease to 1.2.0

2018-01-17 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404749 )

Change subject: Bump mediawiki/at-ease to 1.2.0
..

Bump mediawiki/at-ease to 1.2.0

Bump PHPUnit to 4.8.36

Change-Id: I191302588efd4717ab82777ff7bf4c356f9503b7
---
M composer.json
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/css-sanitizer 
refs/changes/49/404749/1

diff --git a/composer.json b/composer.json
index c57eb94..32a6916 100644
--- a/composer.json
+++ b/composer.json
@@ -23,13 +23,13 @@
"php": ">=5.5.9",
"ext-mbstring": "*",
"ext-iconv": "*",
-   "mediawiki/at-ease": "1.1.0",
+   "mediawiki/at-ease": "1.2.0",
"wikimedia/utfnormal": "1.1.0"
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"mediawiki/mediawiki-codesniffer": "15.0.0",
-   "phpunit/phpunit": "4.8.31",
+   "phpunit/phpunit": "4.8.36",
"wikimedia/testing-access-wrapper": "1.0.0"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/404749
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I191302588efd4717ab82777ff7bf4c356f9503b7
Gerrit-PatchSet: 1
Gerrit-Project: css-sanitizer
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] at-ease[refs/meta/config]: Allow mediawiki group to push signed tags

2018-01-17 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404745 )

Change subject: Allow mediawiki group to push signed tags
..

Allow mediawiki group to push signed tags

Change-Id: I9f97024d5ecdbed1073e90c5131ce382fa01d215
---
M groups
M project.config
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/at-ease refs/changes/45/404745/1

diff --git a/groups b/groups
index b44c1b2..85413aa 100644
--- a/groups
+++ b/groups
@@ -1,5 +1,6 @@
 # UUID Group Name
 #
 2bc47fcadf4e44ec9a1a73bcfa06232554f47ce2   JenkinsBot
+4cdcb3a1ef2e19d73bc9a97f1d0f109d2e0209cd   mediawiki
 a667323336b66ba1423b73fa979948a8165074d5   at-ease
 global:Registered-UsersRegistered Users
diff --git a/project.config b/project.config
index 7b2b715..5d2b1a2 100644
--- a/project.config
+++ b/project.config
@@ -5,6 +5,7 @@
 [access "refs/*"]
owner = group at-ease
pushSignedTag = group at-ease
+   pushSignedTag = group mediawiki
 [project]
description = wfSuppressWarnings/wfRestoreWarnings library
 [access "refs/heads/*"]

-- 
To view, visit https://gerrit.wikimedia.org/r/404745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f97024d5ecdbed1073e90c5131ce382fa01d215
Gerrit-PatchSet: 1
Gerrit-Project: at-ease
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Move packages onto individual lines in require_package() for...

2018-01-11 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403623 )

Change subject: Move packages onto individual lines in require_package() for OS 
versions
..

Move packages onto individual lines in require_package() for OS versions

Change-Id: I2436a732eabaf4111514ba59da5e4655dadb53cb
---
M modules/mediawiki/manifests/packages/fonts.pp
1 file changed, 29 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/23/403623/1

diff --git a/modules/mediawiki/manifests/packages/fonts.pp 
b/modules/mediawiki/manifests/packages/fonts.pp
index 06b4b46..9377d94 100644
--- a/modules/mediawiki/manifests/packages/fonts.pp
+++ b/modules/mediawiki/manifests/packages/fonts.pp
@@ -52,11 +52,38 @@
 }
 
 if os_version('ubuntu >= trusty') {
-require_package('ttf-bengali-fonts', 'ttf-devanagari-fonts', 
'ttf-gujarati-fonts', 'ttf-kannada-fonts', 'ttf-oriya-fonts', 
'ttf-punjabi-fonts', 'ttf-tamil-fonts', 'ttf-telugu-fonts', 'ttf-kochi-gothic', 
'ttf-kochi-mincho', 'fonts-mgopen')
+require_package(
+'ttf-bengali-fonts',
+'ttf-devanagari-fonts',
+'ttf-gujarati-fonts',
+'ttf-kannada-fonts',
+'ttf-oriya-fonts',
+'ttf-punjabi-fonts',
+'ttf-tamil-fonts',
+'ttf-telugu-fonts',
+'ttf-kochi-gothic',
+'ttf-kochi-mincho',
+'fonts-mgopen'
+)
 }
 
 if os_version('debian >= jessie') {
-require_package('fonts-beng', 'fonts-deva', 'fonts-gujr', 
'fonts-knda', 'fonts-mlym', 'fonts-orya', 'fonts-guru', 'fonts-taml', 
'fonts-telu', 'fonts-gujr-extra', 'fonts-noto-cjk', 'fonts-sil-lateef', 
'fonts-ipafont-gothic', 'fonts-ipafont-mincho')
+require_package(
+'fonts-beng',
+'fonts-deva',
+'fonts-gujr',
+'fonts-knda',
+'fonts-mlym',
+'fonts-orya',
+'fonts-guru',
+'fonts-taml',
+'fonts-telu',
+'fonts-gujr-extra',
+'fonts-noto-cjk',
+'fonts-sil-lateef',
+'fonts-ipafont-gothic',
+'fonts-ipafont-mincho'
+)
 }
 
 # In older releases (up to the version present in trusty), 
fontconfig-config provided

-- 
To view, visit https://gerrit.wikimedia.org/r/403623
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2436a732eabaf4111514ba59da5e4655dadb53cb
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add fonts-nono to mediawiki::packages::fonts

2018-01-11 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403605 )

Change subject: Add fonts-nono to mediawiki::packages::fonts
..

Add fonts-nono to mediawiki::packages::fonts

Bug: T184664
Change-Id: I64d1d86972d1d17e7f468341b407f14ccbdbe577
---
M modules/cdh
M modules/mediawiki/manifests/packages/fonts.pp
M modules/varnishkafka
3 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/05/403605/1

diff --git a/modules/cdh b/modules/cdh
index 0f137db..b8806c0 16
--- a/modules/cdh
+++ b/modules/cdh
@@ -1 +1 @@
-Subproject commit 0f137dbf35996fd1a48a4984345f21398e869c4e
+Subproject commit b8806c0fe7e1f8f07313a27ae5ce5ca8c8689e66
diff --git a/modules/mediawiki/manifests/packages/fonts.pp 
b/modules/mediawiki/manifests/packages/fonts.pp
index 06b4b46..3af549e 100644
--- a/modules/mediawiki/manifests/packages/fonts.pp
+++ b/modules/mediawiki/manifests/packages/fonts.pp
@@ -47,6 +47,7 @@
 'fonts-smc', # T33950
 'fonts-hosny-amiri', # T135347
 'fonts-taml-tscu',   # T117919
+'fonts-nono',# T184664
 ]:
 ensure => present,
 }
diff --git a/modules/varnishkafka b/modules/varnishkafka
index 573a656..36fafe3 16
--- a/modules/varnishkafka
+++ b/modules/varnishkafka
@@ -1 +1 @@
-Subproject commit 573a65641dc226104aa272bd8a76dd8e92fec81f
+Subproject commit 36fafe3832330623d4bef1d9cef517bf7c407e0f

-- 
To view, visit https://gerrit.wikimedia.org/r/403605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I64d1d86972d1d17e7f468341b407f14ccbdbe577
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Downgrade "Missing parameter comment" to warning

2018-01-10 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403483 )

Change subject: Downgrade "Missing parameter comment" to warning
..

Downgrade "Missing parameter comment" to warning

Bug: T184650
Change-Id: Ic2aa6c8f005d635d23a5c324cca48ab8fb4ad594
---
M MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/83/403483/1

diff --git a/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php 
b/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
index 40cd69b..450ef30 100644
--- a/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
+++ b/MediaWiki/Sniffs/Commenting/FunctionCommentSniff.php
@@ -521,7 +521,7 @@
}
} else {
$error = 'Missing parameter 
comment';
-   $phpcsFile->addError( $error, 
$tag, 'MissingParamComment' );
+   $phpcsFile->addWarning( $error, 
$tag, 'MissingParamComment' );
}
} else {
$error = 'Missing parameter name';

-- 
To view, visit https://gerrit.wikimedia.org/r/403483
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2aa6c8f005d635d23a5c324cca48ab8fb4ad594
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_30]: Make FormatMetadata::flattenArrayReal() work for an associat...

2018-01-05 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402408 )

Change subject: Make FormatMetadata::flattenArrayReal() work for an associative 
array
..

Make FormatMetadata::flattenArrayReal() work for an associative array

Bug: T87572
Change-Id: I19490ebbbdc3613ae2116c6890ca470bb9f332db
(cherry picked from commit 47a7977b150910562588de89d4c0b684fb25b091)
---
M includes/media/FormatMetadata.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/08/402408/1

diff --git a/includes/media/FormatMetadata.php 
b/includes/media/FormatMetadata.php
index 6cac126..7903223 100644
--- a/includes/media/FormatMetadata.php
+++ b/includes/media/FormatMetadata.php
@@ -1042,7 +1042,7 @@
 
if ( !is_array( $vals ) ) {
return $vals; // do nothing if not an array;
-   } elseif ( count( $vals ) === 1 && $type !== 'lang' ) {
+   } elseif ( count( $vals ) === 1 && $type !== 'lang' && isset( 
$vals[0] ) ) {
return $vals[0];
} elseif ( count( $vals ) === 0 ) {
wfDebug( __METHOD__ . " metadata array with 0 
elements!\n" );

-- 
To view, visit https://gerrit.wikimedia.org/r/402408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I19490ebbbdc3613ae2116c6890ca470bb9f332db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_30
Gerrit-Owner: Reedy 
Gerrit-Reviewer: MarkAHershberger 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_29]: Make FormatMetadata::flattenArrayReal() work for an associat...

2018-01-05 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402407 )

Change subject: Make FormatMetadata::flattenArrayReal() work for an associative 
array
..

Make FormatMetadata::flattenArrayReal() work for an associative array

Bug: T87572
Change-Id: I19490ebbbdc3613ae2116c6890ca470bb9f332db
(cherry picked from commit 47a7977b150910562588de89d4c0b684fb25b091)
---
M includes/media/FormatMetadata.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/07/402407/1

diff --git a/includes/media/FormatMetadata.php 
b/includes/media/FormatMetadata.php
index f237287..3afce63 100644
--- a/includes/media/FormatMetadata.php
+++ b/includes/media/FormatMetadata.php
@@ -1041,7 +1041,7 @@
 
if ( !is_array( $vals ) ) {
return $vals; // do nothing if not an array;
-   } elseif ( count( $vals ) === 1 && $type !== 'lang' ) {
+   } elseif ( count( $vals ) === 1 && $type !== 'lang' && isset( 
$vals[0] ) ) {
return $vals[0];
} elseif ( count( $vals ) === 0 ) {
wfDebug( __METHOD__ . " metadata array with 0 
elements!\n" );

-- 
To view, visit https://gerrit.wikimedia.org/r/402407
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I19490ebbbdc3613ae2116c6890ca470bb9f332db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_29
Gerrit-Owner: Reedy 
Gerrit-Reviewer: MarkAHershberger 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Make FormatMetadata::flattenArrayReal() work for an associat...

2018-01-05 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402406 )

Change subject: Make FormatMetadata::flattenArrayReal() work for an associative 
array
..

Make FormatMetadata::flattenArrayReal() work for an associative array

Bug: T87572
Change-Id: I19490ebbbdc3613ae2116c6890ca470bb9f332db
(cherry picked from commit 47a7977b150910562588de89d4c0b684fb25b091)
---
M includes/media/FormatMetadata.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/06/402406/1

diff --git a/includes/media/FormatMetadata.php 
b/includes/media/FormatMetadata.php
index f392bd1..f734386 100644
--- a/includes/media/FormatMetadata.php
+++ b/includes/media/FormatMetadata.php
@@ -1041,7 +1041,7 @@
 
if ( !is_array( $vals ) ) {
return $vals; // do nothing if not an array;
-   } elseif ( count( $vals ) === 1 && $type !== 'lang' ) {
+   } elseif ( count( $vals ) === 1 && $type !== 'lang' && isset( 
$vals[0] ) ) {
return $vals[0];
} elseif ( count( $vals ) === 0 ) {
wfDebug( __METHOD__ . " metadata array with 0 
elements!\n" );

-- 
To view, visit https://gerrit.wikimedia.org/r/402406
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I19490ebbbdc3613ae2116c6890ca470bb9f332db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_27
Gerrit-Owner: Reedy 
Gerrit-Reviewer: MarkAHershberger 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia/wikimania-scholarships[master]: Fix FAQ link

2018-01-03 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401743 )

Change subject: Fix FAQ link
..

Fix FAQ link

Change-Id: I15689b323413d1c6e6a7f474b98608d91806456c
---
M data/templates/base.html
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/wikimania-scholarships 
refs/changes/43/401743/2

diff --git a/data/templates/base.html b/data/templates/base.html
index fbbd291..b0740f4 100644
--- a/data/templates/base.html
+++ b/data/templates/base.html
@@ -78,7 +78,7 @@
   
   
 
-  http://wikimania2017.wikimedia.org/wiki/Scholarships/FAQ;>{{ 
'footer-faq'|message }}
+  http://wikimania2018.wikimedia.org/wiki/Scholarships/FAQ;>{{ 
'footer-faq'|message }}
   {{ 'footer-credits'|message 
}}
   {{ 'footer-privacy'|message 
}}
   {{ 
'footer-contact'|message }}

-- 
To view, visit https://gerrit.wikimedia.org/r/401743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I15689b323413d1c6e6a7f474b98608d91806456c
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/wikimania-scholarships
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Append leading \ to BlobStoreFactoryTest covers

2017-12-29 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401005 )

Change subject: Append leading \ to BlobStoreFactoryTest covers
..

Append leading \ to BlobStoreFactoryTest covers

Change-Id: I9b85aa9808c40aa728c6ef186c50bc8cdda08bc6
---
M tests/phpunit/includes/Storage/BlobStoreFactoryTest.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/05/401005/1

diff --git a/tests/phpunit/includes/Storage/BlobStoreFactoryTest.php 
b/tests/phpunit/includes/Storage/BlobStoreFactoryTest.php
index 46ba7a5..5db1634 100644
--- a/tests/phpunit/includes/Storage/BlobStoreFactoryTest.php
+++ b/tests/phpunit/includes/Storage/BlobStoreFactoryTest.php
@@ -9,7 +9,7 @@
 use Wikimedia\TestingAccessWrapper;
 
 /**
- * @covers MediaWiki\Storage\BlobStore
+ * @covers \MediaWiki\Storage\BlobStore
  */
 class BlobStoreFactoryTest extends MediaWikiTestCase {
 

-- 
To view, visit https://gerrit.wikimedia.org/r/401005
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b85aa9808c40aa728c6ef186c50bc8cdda08bc6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Decapitalise includes/Storage

2017-12-29 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401001 )

Change subject: Decapitalise includes/Storage
..

Decapitalise includes/Storage

Change-Id: I0aa94aad5b4f3daa21d2fe177d53d8b6742a7c3c
---
M autoload.php
R includes/storage/BlobAccessException.php
R includes/storage/BlobStore.php
R includes/storage/BlobStoreFactory.php
R includes/storage/IncompleteRevisionException.php
R includes/storage/MutableRevisionRecord.php
R includes/storage/MutableRevisionSlots.php
R includes/storage/RevisionAccessException.php
R includes/storage/RevisionArchiveRecord.php
R includes/storage/RevisionFactory.php
R includes/storage/RevisionLookup.php
R includes/storage/RevisionRecord.php
R includes/storage/RevisionSlots.php
R includes/storage/RevisionStore.php
R includes/storage/RevisionStoreRecord.php
R includes/storage/SlotRecord.php
R includes/storage/SqlBlobStore.php
R includes/storage/SuppressedDataException.php
18 files changed, 17 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/01/401001/1

diff --git a/autoload.php b/autoload.php
index c37d9f7..a2660ed 100644
--- a/autoload.php
+++ b/autoload.php
@@ -942,23 +942,23 @@
'MediaWiki\\Shell\\Result' => __DIR__ . '/includes/shell/Result.php',
'MediaWiki\\Shell\\Shell' => __DIR__ . '/includes/shell/Shell.php',
'MediaWiki\\Site\\MediaWikiPageNameNormalizer' => __DIR__ . 
'/includes/site/MediaWikiPageNameNormalizer.php',
-   'MediaWiki\\Storage\\BlobAccessException' => __DIR__ . 
'/includes/Storage/BlobAccessException.php',
-   'MediaWiki\\Storage\\BlobStore' => __DIR__ . 
'/includes/Storage/BlobStore.php',
-   'MediaWiki\\Storage\\BlobStoreFactory' => __DIR__ . 
'/includes/Storage/BlobStoreFactory.php',
-   'MediaWiki\\Storage\\IncompleteRevisionException' => __DIR__ . 
'/includes/Storage/IncompleteRevisionException.php',
-   'MediaWiki\\Storage\\MutableRevisionRecord' => __DIR__ . 
'/includes/Storage/MutableRevisionRecord.php',
-   'MediaWiki\\Storage\\MutableRevisionSlots' => __DIR__ . 
'/includes/Storage/MutableRevisionSlots.php',
-   'MediaWiki\\Storage\\RevisionAccessException' => __DIR__ . 
'/includes/Storage/RevisionAccessException.php',
-   'MediaWiki\\Storage\\RevisionArchiveRecord' => __DIR__ . 
'/includes/Storage/RevisionArchiveRecord.php',
-   'MediaWiki\\Storage\\RevisionFactory' => __DIR__ . 
'/includes/Storage/RevisionFactory.php',
-   'MediaWiki\\Storage\\RevisionLookup' => __DIR__ . 
'/includes/Storage/RevisionLookup.php',
-   'MediaWiki\\Storage\\RevisionRecord' => __DIR__ . 
'/includes/Storage/RevisionRecord.php',
-   'MediaWiki\\Storage\\RevisionSlots' => __DIR__ . 
'/includes/Storage/RevisionSlots.php',
-   'MediaWiki\\Storage\\RevisionStore' => __DIR__ . 
'/includes/Storage/RevisionStore.php',
-   'MediaWiki\\Storage\\RevisionStoreRecord' => __DIR__ . 
'/includes/Storage/RevisionStoreRecord.php',
-   'MediaWiki\\Storage\\SlotRecord' => __DIR__ . 
'/includes/Storage/SlotRecord.php',
-   'MediaWiki\\Storage\\SqlBlobStore' => __DIR__ . 
'/includes/Storage/SqlBlobStore.php',
-   'MediaWiki\\Storage\\SuppressedDataException' => __DIR__ . 
'/includes/Storage/SuppressedDataException.php',
+   'MediaWiki\\Storage\\BlobAccessException' => __DIR__ . 
'/includes/storage/BlobAccessException.php',
+   'MediaWiki\\Storage\\BlobStore' => __DIR__ . 
'/includes/storage/BlobStore.php',
+   'MediaWiki\\Storage\\BlobStoreFactory' => __DIR__ . 
'/includes/storage/BlobStoreFactory.php',
+   'MediaWiki\\Storage\\IncompleteRevisionException' => __DIR__ . 
'/includes/storage/IncompleteRevisionException.php',
+   'MediaWiki\\Storage\\MutableRevisionRecord' => __DIR__ . 
'/includes/storage/MutableRevisionRecord.php',
+   'MediaWiki\\Storage\\MutableRevisionSlots' => __DIR__ . 
'/includes/storage/MutableRevisionSlots.php',
+   'MediaWiki\\Storage\\RevisionAccessException' => __DIR__ . 
'/includes/storage/RevisionAccessException.php',
+   'MediaWiki\\Storage\\RevisionArchiveRecord' => __DIR__ . 
'/includes/storage/RevisionArchiveRecord.php',
+   'MediaWiki\\Storage\\RevisionFactory' => __DIR__ . 
'/includes/storage/RevisionFactory.php',
+   'MediaWiki\\Storage\\RevisionLookup' => __DIR__ . 
'/includes/storage/RevisionLookup.php',
+   'MediaWiki\\Storage\\RevisionRecord' => __DIR__ . 
'/includes/storage/RevisionRecord.php',
+   'MediaWiki\\Storage\\RevisionSlots' => __DIR__ . 
'/includes/storage/RevisionSlots.php',
+   'MediaWiki\\Storage\\RevisionStore' => __DIR__ . 
'/includes/storage/RevisionStore.php',
+   'MediaWiki\\Storage\\RevisionStoreRecord' => __DIR__ . 
'/includes/storage/RevisionStoreRecord.php',
+   'MediaWiki\\Storage\\SlotRecord' => __DIR__ . 
'/includes/storage/SlotRecord.php',
+   'MediaWiki\\Storage\\SqlBlobStore' => __DIR__ .

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Only lowercase storage tests...

2017-12-29 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401000 )

Change subject: Only lowercase storage tests...
..

Only lowercase storage tests...

Change-Id: Ib9b8bdd40ed2f4e07a3029a61ea0962fd5598f11
---
R tests/phpunit/includes/storage/BlobStoreFactoryTest.php
R tests/phpunit/includes/storage/MutableRevisionRecordTest.php
R tests/phpunit/includes/storage/MutableRevisionSlotsTest.php
R tests/phpunit/includes/storage/RevisionSlotsTest.php
R tests/phpunit/includes/storage/RevisionStoreDbTest.php
R tests/phpunit/includes/storage/RevisionStoreRecordTest.php
R tests/phpunit/includes/storage/RevisionStoreTest.php
R tests/phpunit/includes/storage/SlotRecordTest.php
R tests/phpunit/includes/storage/SqlBlobStoreTest.php
9 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/00/401000/1

diff --git a/tests/phpunit/includes/Storage/BlobStoreFactoryTest.php 
b/tests/phpunit/includes/storage/BlobStoreFactoryTest.php
similarity index 100%
rename from tests/phpunit/includes/Storage/BlobStoreFactoryTest.php
rename to tests/phpunit/includes/storage/BlobStoreFactoryTest.php
diff --git a/tests/phpunit/includes/Storage/MutableRevisionRecordTest.php 
b/tests/phpunit/includes/storage/MutableRevisionRecordTest.php
similarity index 100%
rename from tests/phpunit/includes/Storage/MutableRevisionRecordTest.php
rename to tests/phpunit/includes/storage/MutableRevisionRecordTest.php
diff --git a/tests/phpunit/includes/Storage/MutableRevisionSlotsTest.php 
b/tests/phpunit/includes/storage/MutableRevisionSlotsTest.php
similarity index 100%
rename from tests/phpunit/includes/Storage/MutableRevisionSlotsTest.php
rename to tests/phpunit/includes/storage/MutableRevisionSlotsTest.php
diff --git a/tests/phpunit/includes/Storage/RevisionSlotsTest.php 
b/tests/phpunit/includes/storage/RevisionSlotsTest.php
similarity index 100%
rename from tests/phpunit/includes/Storage/RevisionSlotsTest.php
rename to tests/phpunit/includes/storage/RevisionSlotsTest.php
diff --git a/tests/phpunit/includes/Storage/RevisionStoreDbTest.php 
b/tests/phpunit/includes/storage/RevisionStoreDbTest.php
similarity index 100%
rename from tests/phpunit/includes/Storage/RevisionStoreDbTest.php
rename to tests/phpunit/includes/storage/RevisionStoreDbTest.php
diff --git a/tests/phpunit/includes/Storage/RevisionStoreRecordTest.php 
b/tests/phpunit/includes/storage/RevisionStoreRecordTest.php
similarity index 100%
rename from tests/phpunit/includes/Storage/RevisionStoreRecordTest.php
rename to tests/phpunit/includes/storage/RevisionStoreRecordTest.php
diff --git a/tests/phpunit/includes/Storage/RevisionStoreTest.php 
b/tests/phpunit/includes/storage/RevisionStoreTest.php
similarity index 100%
rename from tests/phpunit/includes/Storage/RevisionStoreTest.php
rename to tests/phpunit/includes/storage/RevisionStoreTest.php
diff --git a/tests/phpunit/includes/Storage/SlotRecordTest.php 
b/tests/phpunit/includes/storage/SlotRecordTest.php
similarity index 100%
rename from tests/phpunit/includes/Storage/SlotRecordTest.php
rename to tests/phpunit/includes/storage/SlotRecordTest.php
diff --git a/tests/phpunit/includes/Storage/SqlBlobStoreTest.php 
b/tests/phpunit/includes/storage/SqlBlobStoreTest.php
similarity index 100%
rename from tests/phpunit/includes/Storage/SqlBlobStoreTest.php
rename to tests/phpunit/includes/storage/SqlBlobStoreTest.php

-- 
To view, visit https://gerrit.wikimedia.org/r/401000
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9b8bdd40ed2f4e07a3029a61ea0962fd5598f11
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Decapitalise storage folder in includes and tests/phpunit

2017-12-29 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400998 )

Change subject: Decapitalise storage folder in includes and tests/phpunit
..

Decapitalise storage folder in includes and tests/phpunit

Change-Id: If6ac57808ae2ad50e00f8efd25dfc102beb87a67
---
M autoload.php
R includes/storage/BlobAccessException.php
R includes/storage/BlobStore.php
R includes/storage/BlobStoreFactory.php
R includes/storage/IncompleteRevisionException.php
R includes/storage/MutableRevisionRecord.php
R includes/storage/MutableRevisionSlots.php
R includes/storage/RevisionAccessException.php
R includes/storage/RevisionArchiveRecord.php
R includes/storage/RevisionFactory.php
R includes/storage/RevisionLookup.php
R includes/storage/RevisionRecord.php
R includes/storage/RevisionSlots.php
R includes/storage/RevisionStore.php
R includes/storage/RevisionStoreRecord.php
R includes/storage/SlotRecord.php
R includes/storage/SqlBlobStore.php
R includes/storage/SuppressedDataException.php
R tests/phpunit/includes/storage/BlobStoreFactoryTest.php
R tests/phpunit/includes/storage/MutableRevisionRecordTest.php
R tests/phpunit/includes/storage/MutableRevisionSlotsTest.php
R tests/phpunit/includes/storage/RevisionSlotsTest.php
R tests/phpunit/includes/storage/RevisionStoreDbTest.php
R tests/phpunit/includes/storage/RevisionStoreRecordTest.php
R tests/phpunit/includes/storage/RevisionStoreTest.php
R tests/phpunit/includes/storage/SlotRecordTest.php
R tests/phpunit/includes/storage/SqlBlobStoreTest.php
27 files changed, 17 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/98/400998/1

diff --git a/autoload.php b/autoload.php
index c37d9f7..a2660ed 100644
--- a/autoload.php
+++ b/autoload.php
@@ -942,23 +942,23 @@
'MediaWiki\\Shell\\Result' => __DIR__ . '/includes/shell/Result.php',
'MediaWiki\\Shell\\Shell' => __DIR__ . '/includes/shell/Shell.php',
'MediaWiki\\Site\\MediaWikiPageNameNormalizer' => __DIR__ . 
'/includes/site/MediaWikiPageNameNormalizer.php',
-   'MediaWiki\\Storage\\BlobAccessException' => __DIR__ . 
'/includes/Storage/BlobAccessException.php',
-   'MediaWiki\\Storage\\BlobStore' => __DIR__ . 
'/includes/Storage/BlobStore.php',
-   'MediaWiki\\Storage\\BlobStoreFactory' => __DIR__ . 
'/includes/Storage/BlobStoreFactory.php',
-   'MediaWiki\\Storage\\IncompleteRevisionException' => __DIR__ . 
'/includes/Storage/IncompleteRevisionException.php',
-   'MediaWiki\\Storage\\MutableRevisionRecord' => __DIR__ . 
'/includes/Storage/MutableRevisionRecord.php',
-   'MediaWiki\\Storage\\MutableRevisionSlots' => __DIR__ . 
'/includes/Storage/MutableRevisionSlots.php',
-   'MediaWiki\\Storage\\RevisionAccessException' => __DIR__ . 
'/includes/Storage/RevisionAccessException.php',
-   'MediaWiki\\Storage\\RevisionArchiveRecord' => __DIR__ . 
'/includes/Storage/RevisionArchiveRecord.php',
-   'MediaWiki\\Storage\\RevisionFactory' => __DIR__ . 
'/includes/Storage/RevisionFactory.php',
-   'MediaWiki\\Storage\\RevisionLookup' => __DIR__ . 
'/includes/Storage/RevisionLookup.php',
-   'MediaWiki\\Storage\\RevisionRecord' => __DIR__ . 
'/includes/Storage/RevisionRecord.php',
-   'MediaWiki\\Storage\\RevisionSlots' => __DIR__ . 
'/includes/Storage/RevisionSlots.php',
-   'MediaWiki\\Storage\\RevisionStore' => __DIR__ . 
'/includes/Storage/RevisionStore.php',
-   'MediaWiki\\Storage\\RevisionStoreRecord' => __DIR__ . 
'/includes/Storage/RevisionStoreRecord.php',
-   'MediaWiki\\Storage\\SlotRecord' => __DIR__ . 
'/includes/Storage/SlotRecord.php',
-   'MediaWiki\\Storage\\SqlBlobStore' => __DIR__ . 
'/includes/Storage/SqlBlobStore.php',
-   'MediaWiki\\Storage\\SuppressedDataException' => __DIR__ . 
'/includes/Storage/SuppressedDataException.php',
+   'MediaWiki\\Storage\\BlobAccessException' => __DIR__ . 
'/includes/storage/BlobAccessException.php',
+   'MediaWiki\\Storage\\BlobStore' => __DIR__ . 
'/includes/storage/BlobStore.php',
+   'MediaWiki\\Storage\\BlobStoreFactory' => __DIR__ . 
'/includes/storage/BlobStoreFactory.php',
+   'MediaWiki\\Storage\\IncompleteRevisionException' => __DIR__ . 
'/includes/storage/IncompleteRevisionException.php',
+   'MediaWiki\\Storage\\MutableRevisionRecord' => __DIR__ . 
'/includes/storage/MutableRevisionRecord.php',
+   'MediaWiki\\Storage\\MutableRevisionSlots' => __DIR__ . 
'/includes/storage/MutableRevisionSlots.php',
+   'MediaWiki\\Storage\\RevisionAccessException' => __DIR__ . 
'/includes/storage/RevisionAccessException.php',
+   'MediaWiki\\Storage\\RevisionArchiveRecord' => __DIR__ . 
'/includes/storage/RevisionArchiveRecord.php',
+   'MediaWiki\\Storage\\RevisionFactory' => __DIR__ . 
'/includes/storage/RevisionFactory.php',
+   'MediaWiki\\Storage\\RevisionLookup' => __DIR__ . 
'/includes/storage/RevisionLookup.php',
+

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Decapitalise services folder in tests/phpunit

2017-12-29 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400997 )

Change subject: Decapitalise services folder in tests/phpunit
..

Decapitalise services folder in tests/phpunit

Change-Id: If3bf8fd704eccdde435cb3bfd99ba1c1d3caee1f
---
R tests/phpunit/includes/services/ServiceContainerTest.php
R tests/phpunit/includes/services/TestWiring1.php
R tests/phpunit/includes/services/TestWiring2.php
3 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/97/400997/1

diff --git a/tests/phpunit/includes/Services/ServiceContainerTest.php 
b/tests/phpunit/includes/services/ServiceContainerTest.php
similarity index 100%
rename from tests/phpunit/includes/Services/ServiceContainerTest.php
rename to tests/phpunit/includes/services/ServiceContainerTest.php
diff --git a/tests/phpunit/includes/Services/TestWiring1.php 
b/tests/phpunit/includes/services/TestWiring1.php
similarity index 100%
rename from tests/phpunit/includes/Services/TestWiring1.php
rename to tests/phpunit/includes/services/TestWiring1.php
diff --git a/tests/phpunit/includes/Services/TestWiring2.php 
b/tests/phpunit/includes/services/TestWiring2.php
similarity index 100%
rename from tests/phpunit/includes/Services/TestWiring2.php
rename to tests/phpunit/includes/services/TestWiring2.php

-- 
To view, visit https://gerrit.wikimedia.org/r/400997
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If3bf8fd704eccdde435cb3bfd99ba1c1d3caee1f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [DNM] Test tests...

2017-12-29 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400983 )

Change subject: [DNM] Test tests...
..

[DNM] Test tests...

Change-Id: Ib36d9ee702c5b850305f25f16beb936e7879262c
---
M RELEASE-NOTES-1.31
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/83/400983/1

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index a496b02..53dbd47 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -1,4 +1,4 @@
-== MediaWiki 1.31 ==
+LOL== MediaWiki 1.31 ==
 
 THIS IS NOT A RELEASE YET
 

-- 
To view, visit https://gerrit.wikimedia.org/r/400983
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib36d9ee702c5b850305f25f16beb936e7879262c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: De-capitalise includes/storage

2017-12-29 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400959 )

Change subject: De-capitalise includes/storage
..

De-capitalise includes/storage

Also do tests/phpunit/includes/(Storage|Services)

Change-Id: I41ec5b8d8325ab47625a01c75f96899bc38ef943
---
M autoload.php
R includes/storage/BlobAccessException.php
R includes/storage/BlobStore.php
R includes/storage/BlobStoreFactory.php
R includes/storage/IncompleteRevisionException.php
R includes/storage/MutableRevisionRecord.php
R includes/storage/MutableRevisionSlots.php
R includes/storage/RevisionAccessException.php
R includes/storage/RevisionArchiveRecord.php
R includes/storage/RevisionFactory.php
R includes/storage/RevisionLookup.php
R includes/storage/RevisionRecord.php
R includes/storage/RevisionSlots.php
R includes/storage/RevisionStore.php
R includes/storage/RevisionStoreRecord.php
R includes/storage/SlotRecord.php
R includes/storage/SqlBlobStore.php
R includes/storage/SuppressedDataException.php
R tests/phpunit/includes/services/ServiceContainerTest.php
R tests/phpunit/includes/services/TestWiring1.php
R tests/phpunit/includes/services/TestWiring2.php
R tests/phpunit/includes/storage/BlobStoreFactoryTest.php
R tests/phpunit/includes/storage/MutableRevisionRecordTest.php
R tests/phpunit/includes/storage/MutableRevisionSlotsTest.php
R tests/phpunit/includes/storage/RevisionSlotsTest.php
R tests/phpunit/includes/storage/RevisionStoreDbTest.php
R tests/phpunit/includes/storage/RevisionStoreRecordTest.php
R tests/phpunit/includes/storage/RevisionStoreTest.php
R tests/phpunit/includes/storage/SlotRecordTest.php
R tests/phpunit/includes/storage/SqlBlobStoreTest.php
30 files changed, 17 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/59/400959/1

diff --git a/autoload.php b/autoload.php
index c37d9f7..a2660ed 100644
--- a/autoload.php
+++ b/autoload.php
@@ -942,23 +942,23 @@
'MediaWiki\\Shell\\Result' => __DIR__ . '/includes/shell/Result.php',
'MediaWiki\\Shell\\Shell' => __DIR__ . '/includes/shell/Shell.php',
'MediaWiki\\Site\\MediaWikiPageNameNormalizer' => __DIR__ . 
'/includes/site/MediaWikiPageNameNormalizer.php',
-   'MediaWiki\\Storage\\BlobAccessException' => __DIR__ . 
'/includes/Storage/BlobAccessException.php',
-   'MediaWiki\\Storage\\BlobStore' => __DIR__ . 
'/includes/Storage/BlobStore.php',
-   'MediaWiki\\Storage\\BlobStoreFactory' => __DIR__ . 
'/includes/Storage/BlobStoreFactory.php',
-   'MediaWiki\\Storage\\IncompleteRevisionException' => __DIR__ . 
'/includes/Storage/IncompleteRevisionException.php',
-   'MediaWiki\\Storage\\MutableRevisionRecord' => __DIR__ . 
'/includes/Storage/MutableRevisionRecord.php',
-   'MediaWiki\\Storage\\MutableRevisionSlots' => __DIR__ . 
'/includes/Storage/MutableRevisionSlots.php',
-   'MediaWiki\\Storage\\RevisionAccessException' => __DIR__ . 
'/includes/Storage/RevisionAccessException.php',
-   'MediaWiki\\Storage\\RevisionArchiveRecord' => __DIR__ . 
'/includes/Storage/RevisionArchiveRecord.php',
-   'MediaWiki\\Storage\\RevisionFactory' => __DIR__ . 
'/includes/Storage/RevisionFactory.php',
-   'MediaWiki\\Storage\\RevisionLookup' => __DIR__ . 
'/includes/Storage/RevisionLookup.php',
-   'MediaWiki\\Storage\\RevisionRecord' => __DIR__ . 
'/includes/Storage/RevisionRecord.php',
-   'MediaWiki\\Storage\\RevisionSlots' => __DIR__ . 
'/includes/Storage/RevisionSlots.php',
-   'MediaWiki\\Storage\\RevisionStore' => __DIR__ . 
'/includes/Storage/RevisionStore.php',
-   'MediaWiki\\Storage\\RevisionStoreRecord' => __DIR__ . 
'/includes/Storage/RevisionStoreRecord.php',
-   'MediaWiki\\Storage\\SlotRecord' => __DIR__ . 
'/includes/Storage/SlotRecord.php',
-   'MediaWiki\\Storage\\SqlBlobStore' => __DIR__ . 
'/includes/Storage/SqlBlobStore.php',
-   'MediaWiki\\Storage\\SuppressedDataException' => __DIR__ . 
'/includes/Storage/SuppressedDataException.php',
+   'MediaWiki\\Storage\\BlobAccessException' => __DIR__ . 
'/includes/storage/BlobAccessException.php',
+   'MediaWiki\\Storage\\BlobStore' => __DIR__ . 
'/includes/storage/BlobStore.php',
+   'MediaWiki\\Storage\\BlobStoreFactory' => __DIR__ . 
'/includes/storage/BlobStoreFactory.php',
+   'MediaWiki\\Storage\\IncompleteRevisionException' => __DIR__ . 
'/includes/storage/IncompleteRevisionException.php',
+   'MediaWiki\\Storage\\MutableRevisionRecord' => __DIR__ . 
'/includes/storage/MutableRevisionRecord.php',
+   'MediaWiki\\Storage\\MutableRevisionSlots' => __DIR__ . 
'/includes/storage/MutableRevisionSlots.php',
+   'MediaWiki\\Storage\\RevisionAccessException' => __DIR__ . 
'/includes/storage/RevisionAccessException.php',
+   'MediaWiki\\Storage\\RevisionArchiveRecord' => __DIR__ . 
'/includes/storage/RevisionArchiveRecord.php',
+   'MediaWiki\\Storage\\RevisionFactory' =>

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Test HHVM LTS versions 3.21 and 3.23 on travis

2017-12-29 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400942 )

Change subject: Test HHVM LTS versions 3.21 and 3.23 on travis
..

Test HHVM LTS versions 3.21 and 3.23 on travis

Change-Id: I7f772443808f936c0d75910fd18bf8cbd0204088
---
M .travis.yml
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/42/400942/1

diff --git a/.travis.yml b/.travis.yml
index 32763b5..c03c60c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -30,6 +30,10 @@
 - env: dbtype=mysql dbuser=root
   php: hhvm-3.18
 - env: dbtype=mysql dbuser=root
+  php: hhvm-3.21
+- env: dbtype=mysql dbuser=root
+  php: hhvm-3.23
+- env: dbtype=mysql dbuser=root
   php: 7
 - env: dbtype=mysql dbuser=root
   php: 7.1

-- 
To view, visit https://gerrit.wikimedia.org/r/400942
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f772443808f936c0d75910fd18bf8cbd0204088
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Bump min supported HHVM version to 3.18.5

2017-12-29 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400936 )

Change subject: Bump min supported HHVM version to 3.18.5
..

Bump min supported HHVM version to 3.18.5

Change-Id: I0a22c638bf6bbd6c8b93e50c23f8e455e36acd7c
---
M RELEASE-NOTES-1.31
M includes/PHPVersionCheck.php
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/36/400936/1

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index a496b02..47ff209 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -162,7 +162,7 @@
 
 == Compatibility ==
 MediaWiki 1.31 requires PHP 5.5.9 or later. There is experimental support for
-HHVM 3.6.5 or later.
+HHVM 3.18.5 or later.
 
 MySQL/MariaDB is the recommended DBMS. PostgreSQL or SQLite can also be used,
 but support for them is somewhat less mature. There is experimental support for
diff --git a/includes/PHPVersionCheck.php b/includes/PHPVersionCheck.php
index a862903..69bd24f 100644
--- a/includes/PHPVersionCheck.php
+++ b/includes/PHPVersionCheck.php
@@ -87,8 +87,8 @@
'implementation' => 'HHVM',
'version' => defined( 'HHVM_VERSION' ) ? 
HHVM_VERSION : 'undefined',
'vendor' => 'Facebook',
-   'upstreamSupported' => '3.6.5',
-   'minSupported' => '3.6.5',
+   'upstreamSupported' => '3.18.5',
+   'minSupported' => '3.18.5',
'upgradeURL' => 
'https://docs.hhvm.com/hhvm/installation/introduction',
);
}

-- 
To view, visit https://gerrit.wikimedia.org/r/400936
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a22c638bf6bbd6c8b93e50c23f8e455e36acd7c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Only run count() on array()

2017-12-29 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400916 )

Change subject: Only run count() on array()
..

Only run count() on array()

Bug: T182377
Change-Id: I9c8aca35bf8610316ec7e1757395e9bd56a531ad
---
M includes/media/Exif.php
1 file changed, 14 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/16/400916/1

diff --git a/includes/media/Exif.php b/includes/media/Exif.php
index cd457f0..0d901b8b 100644
--- a/includes/media/Exif.php
+++ b/includes/media/Exif.php
@@ -742,21 +742,24 @@
$ecount = 1; // checking individual elements
}
}
-   $count = count( $val );
-   if ( $ecount != $count ) {
-   $this->debug( $val, __FUNCTION__, "Expected $ecount 
elements for $tag but got $count" );
+   if ( is_array( $val ) ) {
+   $count = count( $val );
+   if ( $ecount != $count ) {
+   $this->debug( $val, __FUNCTION__, "Expected 
$ecount elements for $tag but got $count" );
 
-   return false;
-   }
-   if ( $count > 1 ) {
-   foreach ( $val as $v ) {
-   if ( !$this->validate( $section, $tag, $v, true 
) ) {
-   return false;
-   }
+   return false;
}
+   if ( $count > 1 ) {
+   foreach ( $val as $v ) {
+   if ( !$this->validate( $section, $tag, 
$v, true ) ) {
+   return false;
+   }
+   }
 
-   return true;
+   return true;
+   }
}
+
// Does not work if not typecast
switch ( (string)$etype ) {
case (string)self::BYTE:

-- 
To view, visit https://gerrit.wikimedia.org/r/400916
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c8aca35bf8610316ec7e1757395e9bd56a531ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Stop testing hhvm 3.12 on travis

2017-12-29 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400884 )

Change subject: Stop testing hhvm 3.12 on travis
..

Stop testing hhvm 3.12 on travis

WMF is using 3.18, which we're testing

Change-Id: I7749d4fe81433a1fd2e07447af1912c30d7c9330
---
M .travis.yml
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/84/400884/1

diff --git a/.travis.yml b/.travis.yml
index 64414b5..32763b5 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -28,8 +28,6 @@
   php: 5.5
 # https://docs.travis-ci.com/user/languages/php#HHVM-versions
 - env: dbtype=mysql dbuser=root
-  php: hhvm-3.12
-- env: dbtype=mysql dbuser=root
   php: hhvm-3.18
 - env: dbtype=mysql dbuser=root
   php: 7

-- 
To view, visit https://gerrit.wikimedia.org/r/400884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7749d4fe81433a1fd2e07447af1912c30d7c9330
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add language-pack-eu to toollabs exec

2017-12-22 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399885 )

Change subject: Add language-pack-eu to toollabs exec
..

Add language-pack-eu to toollabs exec

Bug: T183591
Change-Id: I2cd500f9da20e67ec2988ec99f6e56b6765aa0c5
---
M modules/toollabs/manifests/exec_environ.pp
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/85/399885/1

diff --git a/modules/toollabs/manifests/exec_environ.pp 
b/modules/toollabs/manifests/exec_environ.pp
index 9f6590c..7339e78 100644
--- a/modules/toollabs/manifests/exec_environ.pp
+++ b/modules/toollabs/manifests/exec_environ.pp
@@ -25,6 +25,7 @@
 'language-pack-de',
 'language-pack-en',
 'language-pack-es',
+'language-pack-eu',# T183591
 'language-pack-fr',
 'language-pack-he',
 'language-pack-hi',

-- 
To view, visit https://gerrit.wikimedia.org/r/399885
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cd500f9da20e67ec2988ec99f6e56b6765aa0c5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PasswordBlacklist[master]: Initial implementation of the PasswordBlacklist

2017-12-20 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399548 )

Change subject: Initial implementation of the PasswordBlacklist
..

Initial implementation of the PasswordBlacklist

Implemented using a Bloom Filter from pleonasm/bloom-filter [1]

Password list source came from GitHub [2]

[1] https://github.com/pleonasm/bloom-filter
[2] 
https://github.com/danielmiessler/SecLists/blob/aad07ff/Passwords/10_million_password_list_top_10.txt

Change-Id: I2a8f8bd4fd73982e7ef6921ac93ae6e3e87bcfa1
---
M README.md
M composer.json
A scripts/data/10_million_password_list_top_10.txt
A scripts/generate.php
M src/PasswordBlacklist.php
A src/blacklist.json
M tests/PasswordBlacklistTest.php
7 files changed, 100,118 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/libs/PasswordBlacklist 
refs/changes/48/399548/1


-- 
To view, visit https://gerrit.wikimedia.org/r/399548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a8f8bd4fd73982e7ef6921ac93ae6e3e87bcfa1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/libs/PasswordBlacklist
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update path to loadExitNodes.php

2017-12-20 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399434 )

Change subject: Update path to loadExitNodes.php
..

Update path to loadExitNodes.php

Follows up Ibd6ee1dcbd387d5a208896b9f0059ad0c03e9eba

Change-Id: I68f7e02ac9c038961c8e36a81fc8a1142eaed653
---
M modules/mediawiki/manifests/maintenance/tor_exit_node.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/34/399434/1

diff --git a/modules/mediawiki/manifests/maintenance/tor_exit_node.pp 
b/modules/mediawiki/manifests/maintenance/tor_exit_node.pp
index e8e6570..38dd984 100644
--- a/modules/mediawiki/manifests/maintenance/tor_exit_node.pp
+++ b/modules/mediawiki/manifests/maintenance/tor_exit_node.pp
@@ -1,7 +1,7 @@
 class mediawiki::maintenance::tor_exit_node( $ensure = present ) {
 cron { 'tor_exit_node_update':
 ensure  => $ensure,
-command => '/usr/local/bin/mwscript 
extensions/TorBlock/loadExitNodes.php --wiki=aawiki --force > /dev/null',
+command => '/usr/local/bin/mwscript 
extensions/TorBlock/maintenance/loadExitNodes.php --wiki=aawiki --force > 
/dev/null',
 user=> $::mediawiki::users::web,
 minute  => '*/20',
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/399434
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68f7e02ac9c038961c8e36a81fc8a1142eaed653
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LifeWebCore[master]: Remove unused jquery-1.10.2.js

2017-12-14 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398410 )

Change subject: Remove unused jquery-1.10.2.js
..

Remove unused jquery-1.10.2.js

Remove svg.min.js, just use the unminified version, RL does the rest

Change-Id: I6c5decffb191b27c6103c032065baca0f1f00bf3
---
M LifeWebCore.php
D resources/script/jquery-1.10.2.js
D resources/script/svg.min.js
3 files changed, 1 insertion(+), 9,792 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LifeWebCore 
refs/changes/10/398410/1


-- 
To view, visit https://gerrit.wikimedia.org/r/398410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c5decffb191b27c6103c032065baca0f1f00bf3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LifeWebCore
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Dashiki[master]: Switch to PSR-4 autoloader

2017-12-14 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398407 )

Change subject: Switch to PSR-4 autoloader
..

Switch to PSR-4 autoloader

Change-Id: Id0b6a9f9a9096672e607cc99c37aaa85d9de77b3
---
M extension.json
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Dashiki 
refs/changes/07/398407/1

diff --git a/extension.json b/extension.json
index 1a2c4d8..9a9f4a6 100644
--- a/extension.json
+++ b/extension.json
@@ -8,13 +8,16 @@
"descriptionmsg": "dashiki-desc",
"type": "other",
"license-name": "GPL-2.0+",
+   "requires": {
+   "MediaWiki": ">= 1.31.0"
+   },
"MessagesDirs": {
"Dashiki": [
"i18n"
]
},
-   "AutoloadClasses": {
-   "Dashiki\\DashikiView": "includes/DashikiView.php"
+   "AutoloadNamespaces": {
+   "Dashiki\\": "includes/"
},
"JsonConfigModels": {
"JsonConfig.Dashiki": {

-- 
To view, visit https://gerrit.wikimedia.org/r/398407
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0b6a9f9a9096672e607cc99c37aaa85d9de77b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Dashiki
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CommonsMetadata[master]: Switch to PSR-4 autoloader

2017-12-14 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398406 )

Change subject: Switch to PSR-4 autoloader
..

Switch to PSR-4 autoloader

Change-Id: I591c9f242bfb760aa70098e11cce92273c572f07
---
D CommonsMetadata.php
M extension.json
R src/DataCollector.php
R src/DomNavigator.php
R src/HookHandler.php
R src/LicenseParser.php
R src/TemplateParser.php
7 files changed, 5 insertions(+), 20 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CommonsMetadata 
refs/changes/06/398406/1

diff --git a/CommonsMetadata.php b/CommonsMetadata.php
deleted file mode 100644
index f4b0729..000
--- a/CommonsMetadata.php
+++ /dev/null
@@ -1,14 +0,0 @@
-https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   );
-   return;
-} else {
-   die( 'This version of the CommonsMetadata extension requires MediaWiki 
1.25+' );
-}
diff --git a/extension.json b/extension.json
index 0018358..a787e06 100644
--- a/extension.json
+++ b/extension.json
@@ -5,6 +5,9 @@
"descriptionmsg": "commonsmetadata-desc",
"license-name": "GPL-2.0+",
"type": "other",
+   "requires": {
+   "MediaWiki": ">= 1.31.0"
+   },
"Hooks": {
"GetExtendedMetadata": [
"CommonsMetadata\\HookHandler::onGetExtendedMetadata"
@@ -25,12 +28,8 @@
"CommonsMetadataForceRecalculate": false,
"CommonsMetadataSetTrackingCategories": false
},
-   "AutoloadClasses": {
-   "CommonsMetadata\\HookHandler": "HookHandler.php",
-   "CommonsMetadata\\DataCollector": "DataCollector.php",
-   "CommonsMetadata\\DomNavigator": "DomNavigator.php",
-   "CommonsMetadata\\TemplateParser": "TemplateParser.php",
-   "CommonsMetadata\\LicenseParser": "LicenseParser.php"
+   "AutoloadNamespaces": {
+   "CommonsMetadata\\": "src/"
},
"TrackingCategories": [
"commonsmetadata-trackingcategory-no-license",
diff --git a/DataCollector.php b/src/DataCollector.php
similarity index 100%
rename from DataCollector.php
rename to src/DataCollector.php
diff --git a/DomNavigator.php b/src/DomNavigator.php
similarity index 100%
rename from DomNavigator.php
rename to src/DomNavigator.php
diff --git a/HookHandler.php b/src/HookHandler.php
similarity index 100%
rename from HookHandler.php
rename to src/HookHandler.php
diff --git a/LicenseParser.php b/src/LicenseParser.php
similarity index 100%
rename from LicenseParser.php
rename to src/LicenseParser.php
diff --git a/TemplateParser.php b/src/TemplateParser.php
similarity index 100%
rename from TemplateParser.php
rename to src/TemplateParser.php

-- 
To view, visit https://gerrit.wikimedia.org/r/398406
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I591c9f242bfb760aa70098e11cce92273c572f07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CommonsMetadata
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ArticlePlaceholder[master]: Switch to PSR-4 autoloader

2017-12-14 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398405 )

Change subject: Switch to PSR-4 autoloader
..

Switch to PSR-4 autoloader

Change-Id: Ie41c699f5362837dfcfe96f4957633b246fbfacc
---
D ArticlePlaceholder.php
M extension.json
2 files changed, 5 insertions(+), 36 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder 
refs/changes/05/398405/1

diff --git a/ArticlePlaceholder.php b/ArticlePlaceholder.php
deleted file mode 100644
index 4bb83a2..000
--- a/ArticlePlaceholder.php
+++ /dev/null
@@ -1,27 +0,0 @@
-https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   ); */
-   return true;
-} else {
-   die( 'This version of the ArticlePlaceholder extension requires 
MediaWiki 1.25+' );
-}
diff --git a/extension.json b/extension.json
index 44f79b4..fee1f7f 100644
--- a/extension.json
+++ b/extension.json
@@ -7,6 +7,9 @@
"descriptionmsg": "articleplaceholder-desc",
"type": "other",
"license-name": "GPL-2.0+",
+   "requires": {
+   "MediaWiki": ">= 1.31.0"
+   },
"SpecialPages": {
"AboutTopic": 
"ArticlePlaceholder\\Specials\\SpecialAboutTopic::newFromGlobalState",
"CreateTopicPage": 
"ArticlePlaceholder\\Specials\\SpecialCreateTopicPage"
@@ -16,15 +19,8 @@
"i18n"
]
},
-   "AutoloadClasses": {
-   "ArticlePlaceholder\\AboutTopicRenderer": 
"includes/AboutTopicRenderer.php",
-   "ArticlePlaceholder\\BaseTemplateToolboxHookHandler": 
"includes/BaseTemplateToolboxHookHandler.php",
-   "ArticlePlaceholder\\Hooks": "includes/Hooks.php",
-   "ArticlePlaceholder\\ItemNotabilityFilter": 
"includes/ItemNotabilityFilter.php",
-   
"ArticlePlaceholder\\Lua\\Scribunto_LuaArticlePlaceholderLibrary": 
"includes/Lua/Scribunto_LuaArticlePlaceholderLibrary.php",
-   "ArticlePlaceholder\\SearchHookHandler": 
"includes/SearchHookHandler.php",
-   "ArticlePlaceholder\\Specials\\SpecialAboutTopic": 
"includes/specials/SpecialAboutTopic.php",
-   "ArticlePlaceholder\\Specials\\SpecialCreateTopicPage": 
"includes/specials/SpecialCreateTopicPage.php"
+   "AutoloadNamespaces": {
+   "ArticlePlaceholder\\": "includes/"
},
"ExtensionMessagesFiles": {
"ArticlePlaceholderAliases": "ArticlePlaceholder.alias.php"

-- 
To view, visit https://gerrit.wikimedia.org/r/398405
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie41c699f5362837dfcfe96f4957633b246fbfacc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ArticleCreationWorkflow[master]: Switch to PSR-4 autoloader

2017-12-14 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398404 )

Change subject: Switch to PSR-4 autoloader
..

Switch to PSR-4 autoloader

Change-Id: I02412cb865f87491d6ac3163c5def447dcf866df
---
M extension.json
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleCreationWorkflow 
refs/changes/04/398404/1

diff --git a/extension.json b/extension.json
index 3448f74..4c3b73f 100644
--- a/extension.json
+++ b/extension.json
@@ -7,7 +7,7 @@
"descriptionmsg": "acw-desc",
"license-name": "MIT",
"requires": {
-   "MediaWiki": ">= 1.30.0-alpha"
+   "MediaWiki": ">= 1.31.0"
},
"Hooks": {
"CustomEditor": 
"ArticleCreationWorkflow\\Hooks::onCustomEditor",
@@ -15,9 +15,8 @@
"BeforePageDisplay": 
"ArticleCreationWorkflow\\Hooks::onBeforePageDisplay",
"EventLoggingRegisterSchemas": 
"ArticleCreationWorkflow\\Hooks::onEventLoggingRegisterSchemas"
},
-   "AutoloadClasses": {
-   "ArticleCreationWorkflow\\Hooks": "includes/Hooks.php",
-   "ArticleCreationWorkflow\\Workflow": "includes/Workflow.php"
+   "AutoloadNamespaces": {
+   "ArticleCreationWorkflow\\": "includes/"
},
"MessagesDirs": {
"ArticleCreationWorkflow": [

-- 
To view, visit https://gerrit.wikimedia.org/r/398404
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I02412cb865f87491d6ac3163c5def447dcf866df
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleCreationWorkflow
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...3D[master]: Switch to PSR-4 autoloader

2017-12-14 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398403 )

Change subject: Switch to PSR-4 autoloader
..

Switch to PSR-4 autoloader

Change-Id: I4622020eb5c7a9fc3633b8eab8b8ff70f67d26b1
---
D Hooks.php
D ThreeDHandler.php
M extension.json
3 files changed, 3 insertions(+), 191 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/3D 
refs/changes/03/398403/1

diff --git a/Hooks.php b/Hooks.php
deleted file mode 100644
index a317e78..000
--- a/Hooks.php
+++ /dev/null
@@ -1,42 +0,0 @@
-http://www.gnu.org/copyleft/gpl.html
- */
-
-namespace MediaWiki\Extensions\ThreeD;
-
-class Hooks {
-   /**
-* @param \OutputPage &$out
-* @param \Skin &$skin
-* @return bool
-*/
-   public static function onBeforePageDisplay( &$out, &$skin ) {
-   $out->addModules( [ 'ext.3d' ] );
-
-   $article = new \ImagePage( $out->getTitle() );
-   if (
-   class_exists( 'MultimediaViewerHooks' ) &&
-   $out->getTitle()->inNamespace( NS_FILE ) &&
-   $article->getFile()->getExtension() === 'stl'
-   ) {
-   $out->addModules( [ 'mmv.3d.head' ] );
-   }
-
-   return true;
-   }
-}
diff --git a/ThreeDHandler.php b/ThreeDHandler.php
deleted file mode 100644
index 47cbdee..000
--- a/ThreeDHandler.php
+++ /dev/null
@@ -1,145 +0,0 @@
-http://www.gnu.org/copyleft/gpl.html
- */
-
-class ThreeDHandler extends \ImageHandler {
-   /**
-* @param \File $file
-* @return bool
-*/
-   public function mustRender( $file ) {
-   return true;
-   }
-
-   /**
-* @param \File $file
-* @return bool
-*/
-   public function isVectorized( $file ) {
-   return true;
-   }
-
-   /**
-* @param \File $image
-* @param array &$params
-* @return bool
-*/
-   public function normaliseParams( $image, &$params ) {
-   global $wgSVGMaxSize;
-   if ( !parent::normaliseParams( $image, $params ) ) {
-   return false;
-   }
-
-   // Don't make an image bigger than wgMaxSVGSize on the smaller 
side
-   if ( $params['physicalWidth'] <= $params['physicalHeight'] ) {
-   if ( $params['physicalWidth'] > $wgSVGMaxSize ) {
-   $srcWidth = $image->getWidth();
-   $srcHeight = $image->getHeight();
-   $params['physicalWidth'] = $wgSVGMaxSize;
-   $params['physicalHeight'] = \File::scaleHeight( 
$srcWidth, $srcHeight, $wgSVGMaxSize );
-   }
-   } else {
-   if ( $params['physicalHeight'] > $wgSVGMaxSize ) {
-   $srcWidth = $image->getWidth();
-   $srcHeight = $image->getHeight();
-   $params['physicalWidth'] = \File::scaleHeight( 
$srcHeight, $srcWidth, $wgSVGMaxSize );
-   $params['physicalHeight'] = $wgSVGMaxSize;
-   }
-   }
-
-   return true;
-   }
-
-   /**
-* @param \File $image
-* @param string $dstPath
-* @param string $dstUrl
-* @param array $params
-* @param int $flags
-* @return 
\MediaTransformError|\MediaTransformOutput|\ThumbnailImage|\TransformParameterError
-*/
-   public function doTransform( $image, $dstPath, $dstUrl, $params, $flags 
= 0 ) {
-   // @codingStandardsIgnoreStart
-   global $wg3dProcessor, $wg3dProcessEnviron, $wgMax3d2pngMemory;
-   // @codingStandardsIgnoreEnd
-
-   // Impose an aspect ratio
-   $params['height'] = round( $params['width'] / ( 640 / 480 ) );
-
-   if ( $flags & self::TRANSFORM_LATER ) {
-   return new \ThumbnailImage( $image, $dstUrl, $dstPath, 
$params );
-   }
-
-   $width = $params['width'];
-   $height = $params['height'];
-
-   if ( !wfMkdirParents( dirname( $dstPath ), null, __METHOD__ ) ) 
{
-   return $this->doThumbError( $width, $height, 
'thumbnail_dest_directory' );
-   }
-
-   $srcPath = $image->getLocalRefPath();
-
-   // $wg3dProcessor can be string (e.g. '/path/to/3d2png.js') or 
array
-   // (e.g. ['xvfb-run', '-a', '-s', '-ac -screen 0 1280x1024x24', 
'/path/to/3d2png.js'])
-   $cmd = wfEscapeShellArg( array_merge( (array)$wg3dProcessor, [
-   $srcPath,
-   sprintf( '%dx%d', $width, $height ),
-   $dstPath
-

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Switch to PSR-4 autoloader

2017-12-14 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398402 )

Change subject: Switch to PSR-4 autoloader
..

Switch to PSR-4 autoloader

Change-Id: I6b7a4c48c0aae58f5bc201d2e40b4696e87f5658
---
M extension.json
R includes/AdvancedSearch.hooks.php
2 files changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AdvancedSearch 
refs/changes/02/398402/1

diff --git a/extension.json b/extension.json
index cb8d090..a4e2841 100644
--- a/extension.json
+++ b/extension.json
@@ -9,10 +9,11 @@
"descriptionmsg": "advancedsearch-desc",
"license-name": "GPL-2.0+",
"type": "other",
-   "AutoloadClasses": {
-   "AdvancedSearch\\Hooks": "AdvancedSearch.hooks.php",
-   "AdvancedSearch\\MimeTypeConfigurator": 
"includes/MimeTypeConfigurator.php",
-   "AdvancedSearch\\TooltipGenerator": 
"includes/TooltipGenerator.php"
+   "requires": {
+   "MediaWiki": ">= 1.31.0"
+   },
+   "AutoloadNamespaces": {
+   "AdvancedSearch\\": "includes/"
},
"config": {
"@AdvancedSearchBetaFeature": "Make the AdvancedSearch feature 
a BetaFeature. Setting this requires the BetaFeature extension and requires 
each user to enable the BetaFeature.",
diff --git a/AdvancedSearch.hooks.php b/includes/AdvancedSearch.hooks.php
similarity index 100%
rename from AdvancedSearch.hooks.php
rename to includes/AdvancedSearch.hooks.php

-- 
To view, visit https://gerrit.wikimedia.org/r/398402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b7a4c48c0aae58f5bc201d2e40b4696e87f5658
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AdvancedSearch
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Flow[wmf/1.31.0-wmf.12]: Fix CheckUser type check thingy

2017-12-13 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398179 )

Change subject: Fix CheckUser type check thingy
..

Fix CheckUser type check thingy

CheckUser changed in I39c60b2d059d1cb2c1c0d3a4206232d961536697

Bug: T182834
Change-Id: Id2634a5789c0fcb15bc551a08613a5d681d0ad85
---
M Hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/79/398179/1

diff --git a/Hooks.php b/Hooks.php
index 0034c0b..7d22c40 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -556,7 +556,7 @@
}
}
 
-   public static function onSpecialCheckUserGetLinksFromRow( CheckUser 
$checkUser, $row, &$links ) {
+   public static function onSpecialCheckUserGetLinksFromRow( 
SpecialCheckUser $checkUser, $row, &$links ) {
if ( !$row->cuc_type == RC_FLOW ) {
return true;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/398179
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2634a5789c0fcb15bc551a08613a5d681d0ad85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: wmf/1.31.0-wmf.12
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Fix CheckUser type check thingy

2017-12-13 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398178 )

Change subject: Fix CheckUser type check thingy
..

Fix CheckUser type check thingy

CheckUser changed in I39c60b2d059d1cb2c1c0d3a4206232d961536697

Bug: T182834
Change-Id: Id2634a5789c0fcb15bc551a08613a5d681d0ad85
---
M Hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/78/398178/1

diff --git a/Hooks.php b/Hooks.php
index 0034c0b..7d22c40 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -556,7 +556,7 @@
}
}
 
-   public static function onSpecialCheckUserGetLinksFromRow( CheckUser 
$checkUser, $row, &$links ) {
+   public static function onSpecialCheckUserGetLinksFromRow( 
SpecialCheckUser $checkUser, $row, &$links ) {
if ( !$row->cuc_type == RC_FLOW ) {
return true;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/398178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2634a5789c0fcb15bc551a08613a5d681d0ad85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CheckUser[master]: Revert "Rename classes to match file names"

2017-12-13 Thread Reedy (Code Review)

Hello Umherirrender, Huji, jenkins-bot, Thiemo Mättig (WMDE),

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/398177

to review the following change.


Change subject: Revert "Rename classes to match file names"
..

Revert "Rename classes to match file names"

This reverts commit 6ab26d6e47f7526708c4a9da52f6ff79373be328.

Bug: T182834
Change-Id: Ifaca2fed59c578e937212ad91c0c7622fd8b0918
---
M .phpcs.xml
R CheckUser.hooks.php
M api/ApiQueryCheckUser.php
M extension.json
M maintenance/purgeOldData.php
M specials/SpecialCheckUser.php
R tests/phpunit/CheckUserTest.php
7 files changed, 19 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CheckUser 
refs/changes/77/398177/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 124ea83..68a2c86 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -7,9 +7,8 @@



-   
-   
-   */maintenance/*
+   
+   


CheckUser\.alias\.php
diff --git a/CheckUserHooks.php b/CheckUser.hooks.php
similarity index 100%
rename from CheckUserHooks.php
rename to CheckUser.hooks.php
diff --git a/api/ApiQueryCheckUser.php b/api/ApiQueryCheckUser.php
index 8d3e0e7..de9d53f 100644
--- a/api/ApiQueryCheckUser.php
+++ b/api/ApiQueryCheckUser.php
@@ -90,7 +90,7 @@
$resultIPs[] = $data;
}
 
-   SpecialCheckUser::addLogEntry( 'userips', 
'user', $target, $reason, $user_id );
+   CheckUser::addLogEntry( 'userips', 'user', 
$target, $reason, $user_id );
$result->addValue( [
'query', $this->getModuleName() ], 
'userips', $resultIPs );
$result->addIndexedTagName( [
@@ -99,7 +99,7 @@
 
case 'edits':
if ( IP::isIPAddress( $target ) ) {
-   $cond = SpecialCheckUser::getIpConds( 
$db, $target, isset( $xff ) );
+   $cond = CheckUser::getIpConds( $db, 
$target, isset( $xff ) );
if ( !$cond ) {
if ( is_callable( [ $this, 
'dieWithError' ] ) ) {
$this->dieWithError( 
'apierror-badip', 'invalidip' );
@@ -162,7 +162,7 @@
$edits[] = $edit;
}
 
-   SpecialCheckUser::addLogEntry( $log_type[0], 
$log_type[1],
+   CheckUser::addLogEntry( $log_type[0], 
$log_type[1],
$target, $reason, isset( $user_id ) ? 
$user_id : '0' );
$result->addValue( [
'query', $this->getModuleName() ], 
'edits', $edits );
@@ -172,7 +172,7 @@
 
case 'ipusers':
if ( IP::isIPAddress( $target ) ) {
-   $cond = SpecialCheckUser::getIpConds( 
$db, $target, isset( $xff ) );
+   $cond = CheckUser::getIpConds( $db, 
$target, isset( $xff ) );
$this->addWhere( $cond );
$log_type = 'ipusers';
if ( isset( $xff ) ) {
@@ -224,7 +224,7 @@
$resultUsers[] = $userData;
}
 
-   SpecialCheckUser::addLogEntry( $log_type, 'ip', 
$target, $reason );
+   CheckUser::addLogEntry( $log_type, 'ip', 
$target, $reason );
$result->addValue( [
'query', $this->getModuleName() ], 
'ipusers', $resultUsers );
$result->addIndexedTagName( [
diff --git a/extension.json b/extension.json
index efc162a..4ecf9ce 100644
--- a/extension.json
+++ b/extension.json
@@ -105,13 +105,13 @@
"checkuser-log"
],
"SpecialPages": {
-   "CheckUser": "SpecialCheckUser",
+   "CheckUser": "CheckUser",
"CheckUserLog": "SpecialCheckUserLog"
},
"AutoloadClasses": {
-   "CheckUserHooks": "CheckUserHooks.php",
+   "CheckUser": "specials/SpecialCheckUser.php",
+   "CheckUserHooks": "CheckUser.hooks.php",
"CheckUserLogPager": "CheckUserLogPager.php",
-   "SpecialCheckUser": "specials/SpecialCheckUser.php",
"SpecialCheckUserLog": "specials/SpecialCheckUserLog.php",

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Update interwiki.php

2017-12-09 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396714 )

Change subject: Update interwiki.php
..

Update interwiki.php

Bug: T182506
Change-Id: If1911479aec87db0fe3b48b87af766489cf41463
---
M wmf-config/interwiki.php
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/14/396714/1

diff --git a/wmf-config/interwiki.php b/wmf-config/interwiki.php
index d5f1e14..f437998 100644
--- a/wmf-config/interwiki.php
+++ b/wmf-config/interwiki.php
@@ -1,5 +1,5 @@
  '0 https://www.acronymfinder.com/$1.html',
'__global:advisory' => '1 https://advisory.wikimedia.org/wiki/$1',
@@ -121,6 +121,7 @@
'__global:h2wiki' => '0 http://halowiki.net/p/$1',
'__global:hammondwiki' => '0 
http://www.dairiki.org/HammondWiki/index.php3?$1',
'__global:hdl' => '0 http://hdl.handle.net/$1',
+   '__global:heraldik' => '0 https://heraldik-wiki.de/wiki/$1',
'__global:heroeswiki' => '0 http://heroeswiki.com/$1',
'__global:horizonlabs' => '1 https://horizon.wikimedia.org/$1',
'__global:hrwiki' => '0 http://www.hrwiki.org/index.php/$1',
@@ -11615,7 +11616,7 @@
'__global:meta' => '1 https://meta.wikimedia.org/wiki/$1',
'__global:sep11' => '1 https://sep11.wikipedia.org/wiki/$1',
'__global:d' => '1 https://www.wikidata.org/wiki/$1',
-   '__list:__global' => 'acronym advisory advogato aew appropedia 
aquariumwiki arborwiki arxiv atmwiki baden battlestarwiki bcnbio beacha 
betawiki bibcode bibliowiki bluwiki blw botwiki boxrec brickwiki bugzilla bulba 
c c2 c2find cache ĉej cellwiki centralwikia chej choralwiki citizendium ckwiss 
comixpedia commons communityscheme communitywiki comune creativecommons 
creativecommonswiki cxej dcc dcdatabase dcma delicious devmo dictionary dict 
disinfopedia distributedproofreaders distributedproofreadersca dmoz dmozs doi 
donate doom_wiki download dbdump dpd drae dreamhost drumcorpswiki dwjwiki eĉei 
ecoreality ecxei elibre emacswiki encyc energiewiki englyphwiki enkol 
eokulturcentro esolang etherpad ethnologue ethnologuefamily evowiki exotica 
fanimutationwiki fedora finalfantasy finnix flickruser flickrphoto floralwiki 
foldoc forthfreak foundation foxwiki freebio freebsdman freeculturewiki 
freedomdefined freefeel freekiwiki freenode freesoft ganfyd gardenology 
gausswiki gentoo genwiki gerrit git globalvoices glossarwiki glossarywiki 
google googledefine googlegroups guildwarswiki guildwiki gutenberg 
gutenbergwiki hackerspaces h2wiki hammondwiki hdl heroeswiki horizonlabs hrwiki 
hrfwiki hupwiki iarchive imdbname imdbtitle imdbcompany imdbcharacter incubator 
infosecpedia infosphere irc ircrc rcirc iso639-3 issn iuridictum jaglyphwiki 
javanet javapedia jefo jerseydatabase jira jspwiki jstor kamelo karlsruhe 
kinowiki kmwiki komicawiki kontuwiki koslarwiki wikitech libreplanet 
linguistlist linuxwiki linuxwikide liswiki literateprograms livepedia localwiki 
lojban lostpedia lqwiki luxo mail mailarchive mariowiki marveldatabase meatball 
mw mediazilla memoryalpha metawiki metawikimedia metawikipedia metawikisearch 
mineralienatlas moinmoin monstropedia mosapedia mozcom mozillawiki 
mozillazinekb musicbrainz mediawikiwiki mwod mwot nkcells nara nosmoke nost 
nostalgia oeis oldwikisource olpc onelook openlibrary openstreetmap openwetware 
opera7wiki organicdesign orthodoxwiki osmwiki otrs otrswiki ourmedia outreach 
outreachwiki owasp panawiki patwiki personaltelco petscan phab phabricator 
phwiki phpwiki planetmath pmeg pmid pokewiki pokéwiki policy proofwiki pyrev 
pythoninfo pythonwiki pywiki psycle quality quarry rev revo rfc rheinneckar 
robowiki rodovid reuterswiki rowiki rt rtfm s23wiki scholar schoolswp scores 
scoutwiki scramble seapig seattlewiki slwiki semantic-mw senseislibrary 
sharemap silcode slashdot sourceforge spcom species squeak stats stewardry 
strategy strategywiki sulutil swtrain svn swinbrain tabwiki tclerswiki 
technorati tenwiki testwiki testwikidata test2wiki tfwiki thelemapedia 
theopedia thinkwiki ticket tmbw tmnet tmwiki toolforge toollabs tools tswiki 
translatewiki tviv tvtropes twiki tyvawiki uncyclopedia unihan unreal urbandict 
usej usemod usability utrs vikidia vlos vkol voipinfo votewiki werelate wg 
wikia wikiasite wikiapiary wikibooks wikichristian wikicities wikicity 
wikiconference wikidata wikif1 wikifur wikihow wikiindex wikilemon wikilivres 
wikilivresru wikimac-de wikimedia wikinews wikinfo wikinvest wikiotics 
wikipapers wikipedia wikipediawikipedia wikiquote wikisophia wikisource 
wikispecies wikispot wikiskripta labsconsole wikiti wikitree wikiversity 
wikivoyage betawikiversity wikiwikiweb wiktionary wipipedia wlug wmam wmar wmat 
wmau wmbd wmbe wmbr wmca wmch wmcl wmcn wmco wmcz wmdc securewikidc wmde wmdk 
wmee wmec wmes wmet wmfi wmfr wmhk wmhu wmid wmil wmin wmit wmke wmmk wmmx wmnl 
wmnyc wmno

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Copy in Field changes from Id8963924f036e9ed3fcdde3a8e54b712...

2017-12-08 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396551 )

Change subject: Copy in Field changes from 
Id8963924f036e9ed3fcdde3a8e54b7126b72356e
..

Copy in Field changes from Id8963924f036e9ed3fcdde3a8e54b7126b72356e

Bug: T160298
Change-Id: Ifaf4f9147def0fdb31287a5b894a1d11cbcbdf70
---
M includes/specials/pagers/ActiveUsersPager.php
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/51/396551/1

diff --git a/includes/specials/pagers/ActiveUsersPager.php 
b/includes/specials/pagers/ActiveUsersPager.php
index 72635fe..977f450 100644
--- a/includes/specials/pagers/ActiveUsersPager.php
+++ b/includes/specials/pagers/ActiveUsersPager.php
@@ -117,7 +117,12 @@
 
return [
'tables' => [ 'querycachetwo', 'user', 'recentchanges' 
],
-   'fields' => [ 'user_name', 'user_id', 'recentedits' => 
'COUNT(*)', 'qcc_title' ],
+   'fields' => [
+   'qcc_title',
+   'user_name' => 'qcc_title',
+   'user_id' => 'MAX(user_id)',
+   'recentedits' => 'COUNT(*)'
+   ],
'options' => [ 'GROUP BY' => [ 'qcc_title' ] ],
'conds' => $conds
];

-- 
To view, visit https://gerrit.wikimedia.org/r/396551
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifaf4f9147def0fdb31287a5b894a1d11cbcbdf70
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_27
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove old commented out $wgCollectionFormats

2017-12-08 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396536 )

Change subject: Remove old commented out $wgCollectionFormats
..

Remove old commented out $wgCollectionFormats

Change-Id: If59c78fb9c64af7b9131e877efe52ac35037411f
---
M wmf-config/CommonSettings.php
1 file changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/36/396536/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index f22043a..0441535 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -1864,14 +1864,6 @@
$wgCollectionFormats = [
'rdf2latex' => 'PDF',
'rdf2text' => 'TXT',
-   // The following formats used the old mwlib renderer
-   // which was shut down Oct 3, 2014.
-   // They may eventually be reinstated when new OCG backends
-   // are written for them.
-   // 'epub' => 'EPUB',
-   // 'odf' => 'ODT',
-   // 'zim' => 'openZIM',
-   // 'rl' => 'mwlib PDF', // replaced by [[:mw:OCG]] 29 Sep 2014
];
 
$wgLicenseURL = "https://creativecommons.org/licenses/by-sa/3.0/;;

-- 
To view, visit https://gerrit.wikimedia.org/r/396536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If59c78fb9c64af7b9131e877efe52ac35037411f
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fix LandingCheck indenting

2017-12-08 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396535 )

Change subject: Fix LandingCheck indenting
..

Fix LandingCheck indenting

Remove ld comments

Change-Id: I0f70fb3cbe8847a949094eb861829a0960b2b193
---
M wmf-config/CommonSettings.php
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/35/396535/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index f22043a..23f0ddb 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -1967,14 +1967,8 @@
// === Fundraising Chapers
'DE', 'CH',
 
-   // --- France and it's territories (per WMFr email 2012-06-13)
-   // Not a fundraising chapter in 2013+ due to FR regulations
-   // 'FR',
-   // 'GP', 'MQ', 'GF', 'RE', 'YT', 'PM',
-   // 'NC', 'PF', 'WF', 'BL', 'MF', 'TF',
-
// === Blacklisted countries
-   'BY', 'CD', 'CI', 'CU', 'IQ', 'IR', 'KP', 'LB', 
'LY', 'MM', 'SD', 'SO', 'SY', 'YE', 'ZW',
+   'BY', 'CD', 'CI', 'CU', 'IQ', 'IR', 'KP', 'LB', 'LY', 'MM', 
'SD', 'SO', 'SY', 'YE', 'ZW',
];
$wgLandingCheckPriorityURLBase = 
"//wikimediafoundation.org/wiki/Special:LandingCheck";
$wgLandingCheckNormalURLBase = 
"//donate.wikimedia.org/wiki/Special:LandingCheck";

-- 
To view, visit https://gerrit.wikimedia.org/r/396535
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f70fb3cbe8847a949094eb861829a0960b2b193
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move RELEASE-NOTES-1.30 into HISTORY

2017-12-08 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396534 )

Change subject: Move RELEASE-NOTES-1.30 into HISTORY
..

Move RELEASE-NOTES-1.30 into HISTORY

Change-Id: I77e26c8e2b2bbb6a07b355c20af764de4e005dd1
---
M HISTORY
D RELEASE-NOTES-1.30
2 files changed, 264 insertions(+), 305 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/34/396534/1

diff --git a/HISTORY b/HISTORY
index 1f30b70..244d681 100644
--- a/HISTORY
+++ b/HISTORY
@@ -1,4 +1,267 @@
-Change notes from older releases. For current info see RELEASE-NOTES-1.30.
+Change notes from older releases. For current info see RELEASE-NOTES-1.31.
+
+= MediaWiki 1.30 =
+
+== MediaWiki 1.30.0 ==
+
+=== Changes since MediaWiki 1.30.0-rc.0 ===
+* Upgraded Moment.js from v2.15.0 to v2.19.3.
+* Add ip_changes to postgres/tables.sql.
+* Skip null shell parameters.
+* Add wfWaitForSlaves() to maintenance/migrateComments.php.
+* (T182245) Fix join conditions in ImageListPager.
+* (T178626) Revert #contentSub and #jump-to-nav margin changes.
+
+=== MySQL version requirement in 1.30 ===
+As of 1.30, MediaWiki now requires MySQL 5.5.8 or higher (see Compatibility
+section).
+
+=== Configuration changes in 1.30 ===
+* The "C.UTF-8" locale should be used for $wgShellLocale, if available, to 
avoid
+  unexpected behavior when code uses locale-sensitive string comparisons. For
+  example, the Scribunto extension considers "bar" < "Foo" in most locales
+  since it ignores case.
+* $wgShellLocale now affects LC_ALL rather than only LC_CTYPE. See
+  documentation of $wgShellLocale for details.
+* $wgShellLocale is now applied for all requests. wfInitShellLocale() is
+  deprecated and a no-op, as it is no longer needed.
+* $wgJobClasses may now specify callback functions as an alternative to plain
+  class names. This is intended for extensions that want control over the
+  instantiation of their jobs, to allow for proper dependency injection.
+* $wgResourceModules may now specify callback functions as an alternative
+  to plain class names, using the 'factory' key in the module description
+  array. This allows dependency injection to be used for ResourceLoader 
modules.
+* $wgExceptionHooks has been removed.
+* (T163562) $wgRangeContributionsCIDRLimit was introduced to control the size
+  of IP ranges that can be queried at Special:Contributions.
+* (T45547) $wgUsePigLatinVariant added (off by default).
+* (T152540) MediaWiki now supports a section ID escaping style that allows to 
display
+  non-Latin characters verbatim on many modern browsers. This is controlled by 
the
+  new configuration setting, $wgFragmentMode.
+* $wgExperimentalHtmlIds is now deprecated and will be removed in a future 
version,
+  use $wgFragmentMode to migrate off it to a modern alternative.
+* $wgExternalInterwikiFragmentMode was introduced to control how fragments in
+  sinterwikis going outside of current wiki farm are encoded.
+* (T120333) Soft-deprecated the use of PHP extension 'mysql' in favor of 
'mysqli'.
+  This PHP extension was deprecated in PHP 5.5 and removed in PHP 7.0. 
MediaWiki
+  auto-selects the 'mysqli' driver since MediaWiki 1.22, except if explicitly
+  requested through the configuration parameter $wgDBservers.
+* $wgOOUIEditPage was removed, as it is now the default. This was documented 
as a
+  temporary variable during the migration period.
+
+=== New features in 1.30 ===
+* (T37247) Output from Parser::parse() will now be wrapped in a div with
+  class="mw-parser-output" by default. This may be changed or disabled using
+  ParserOptions::setWrapOutputClass().
+* (T163562) Added ability to search for contributions within an IP ranges
+  at Special:Contributions.
+* Added 'ChangeTagsAllowedAdd' hook, enabling extensions to allow software-
+  specific tags to be added by users.
+* Added a 'ParserOptionsRegister' hook to allow extensions to register
+  additional parser options.
+* (T45547) Included Pig Latin, a language game in English, as a
+  LanguageConverter variant.  This allows English-speaking developers
+  to develop and test LanguageConverter more easily.  Pig Latin can be
+  enabled by setting $wgUsePigLatinVariant to true.
+* Added RecentChangesPurgeRows hook to allow extensions to purge data that
+  depends on the recentchanges table.
+* Added JS config values wgDiffOldId/wgDiffNewId to the output of diff pages.
+* (T2424) Added direct unwatch links to entries in Special:Watchlist (if the
+  'watchlistunwatchlinks' preference option is enabled). With JavaScript
+  enabled, these links toggle so the user can also re-watch pages that have
+  just been unwatched.
+* Added $wgParserTestMediaHandlers, where mock media handlers can be passed to
+  MediaHandlerFactory for parser tests.
+* Edit summaries, block reasons, and other "comments" are now stored in a
+  separate database table. Use the CommentFormatter class to access them.

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_30]: Bump $wgVersion

2017-12-08 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396532 )

Change subject: Bump $wgVersion
..

Bump $wgVersion

Remove "alpha quality" stuff from RELEASE-NOTES-1.30

Change-Id: Ia5c5d539d204abedbf8a47c18ed0c6757d6274da
---
M RELEASE-NOTES-1.30
M includes/DefaultSettings.php
2 files changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/32/396532/1

diff --git a/RELEASE-NOTES-1.30 b/RELEASE-NOTES-1.30
index 31090fa..6823e7b 100644
--- a/RELEASE-NOTES-1.30
+++ b/RELEASE-NOTES-1.30
@@ -1,10 +1,5 @@
 == MediaWiki 1.30 ==
 
-THIS IS NOT A RELEASE YET
-
-MediaWiki 1.30 is an alpha-quality branch and is not recommended for use in
-production.
-
 === Changes since MediaWiki 1.30.0-rc.0 ===
 * Upgraded Moment.js from v2.15.0 to v2.19.3.
 * Add ip_changes to postgres/tables.sql.
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 5ec61d7..8cdd192 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -75,7 +75,7 @@
  * MediaWiki version number
  * @since 1.2
  */
-$wgVersion = '1.30.0-rc.0';
+$wgVersion = '1.30.0';
 
 /**
  * Name of the site. It must be changed in LocalSettings.php

-- 
To view, visit https://gerrit.wikimedia.org/r/396532
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5c5d539d204abedbf8a47c18ed0c6757d6274da
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_30
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_30]: Update RELEASE-NOTES-1.30 for backports

2017-12-08 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396531 )

Change subject: Update RELEASE-NOTES-1.30 for backports
..

Update RELEASE-NOTES-1.30 for backports

Change-Id: I9c30fbf49af77d58eb91f2bee307206bc5cae9b8
---
M RELEASE-NOTES-1.30
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/31/396531/1

diff --git a/RELEASE-NOTES-1.30 b/RELEASE-NOTES-1.30
index 06eb798..31090fa 100644
--- a/RELEASE-NOTES-1.30
+++ b/RELEASE-NOTES-1.30
@@ -8,6 +8,10 @@
 === Changes since MediaWiki 1.30.0-rc.0 ===
 * Upgraded Moment.js from v2.15.0 to v2.19.3.
 * Add ip_changes to postgres/tables.sql.
+* Skip null shell parameters.
+* Add wfWaitForSlaves() to maintenance/migrateComments.php.
+* (T182245) Fix join conditions in ImageListPager.
+* (T178626) Revert #contentSub and #jump-to-nav margin changes.
 
 === MySQL version requirement in 1.30 ===
 As of 1.30, MediaWiki now requires MySQL 5.5.8 or higher (see Compatibility

-- 
To view, visit https://gerrit.wikimedia.org/r/396531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c30fbf49af77d58eb91f2bee307206bc5cae9b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_30
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.11]: Revert "objectcache: Make WANObjectCache interim caching not...

2017-12-08 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396445 )

Change subject: Revert "objectcache: Make WANObjectCache interim caching not 
interfere with ChronologyProtector"
..

Revert "objectcache: Make WANObjectCache interim caching not interfere with 
ChronologyProtector"

This reverts commit e90eafdf6107d4e49c9c20f6310d1d6ee5f5c47f.

Bug: T182322
Change-Id: Ifaf5623c21e22822fba14156ff2490d066dba726
---
M includes/Setup.php
M includes/libs/objectcache/WANObjectCache.php
M tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php
3 files changed, 11 insertions(+), 94 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/45/396445/1

diff --git a/includes/Setup.php b/includes/Setup.php
index d6f4b2f..081ea68 100644
--- a/includes/Setup.php
+++ b/includes/Setup.php
@@ -736,20 +736,17 @@
 
 // Initialize the request object in $wgRequest
 $wgRequest = RequestContext::getMain()->getRequest(); // BackCompat
-// Set user IP/agent information for causal consistency purposes.
-// The cpPosTime cookie has no prefix and is set by 
MediaWiki::preOutputCommit().
-$cpPosTime = $wgRequest->getFloat( 'cpPosTime', $wgRequest->getCookie( 
'cpPosTime', '' ) );
+// Set user IP/agent information for causal consistency purposes
 MediaWikiServices::getInstance()->getDBLoadBalancerFactory()->setRequestInfo( [
'IPAddress' => $wgRequest->getIP(),
'UserAgent' => $wgRequest->getHeader( 'User-Agent' ),
'ChronologyProtection' => $wgRequest->getHeader( 'ChronologyProtection' 
),
-   'ChronologyPositionTime' => $cpPosTime
+   // The cpPosTime cookie has no prefix and is set by 
MediaWiki::preOutputCommit()
+   'ChronologyPositionTime' => $wgRequest->getFloat(
+   'cpPosTime',
+   $wgRequest->getCookie( 'cpPosTime', '' )
+   )
 ] );
-// Make sure that caching does not compromise the consistency improvements
-if ( $cpPosTime ) {
-   
MediaWikiServices::getInstance()->getMainWANObjectCache()->useInterimHoldOffCaching(
 false );
-}
-unset( $cpPosTime );
 
 // Useful debug output
 if ( $wgCommandLineMode ) {
diff --git a/includes/libs/objectcache/WANObjectCache.php 
b/includes/libs/objectcache/WANObjectCache.php
index 8f2c72a..6451443 100644
--- a/includes/libs/objectcache/WANObjectCache.php
+++ b/includes/libs/objectcache/WANObjectCache.php
@@ -91,8 +91,6 @@
protected $logger;
/** @var StatsdDataFactoryInterface */
protected $stats;
-   /** @var bool Whether to use "interim" caching while keys are 
tombstoned */
-   protected $useInterimHoldOffCaching = true;
/** @var callable|null Function that takes a WAN cache callback and 
runs it later */
protected $asyncHandler;
 
@@ -1209,10 +1207,6 @@
 * @return mixed
 */
protected function getInterimValue( $key, $versioned, $minTime, &$asOf 
) {
-   if ( !$this->useInterimHoldOffCaching ) {
-   return false; // disabled
-   }
-
$wrapped = $this->cache->get( self::INTERIM_KEY_PREFIX . $key );
list( $value ) = $this->unwrap( $wrapped, 
$this->getCurrentTime() );
if ( $value !== false && $this->isValid( $value, $versioned, 
$asOf, $minTime ) ) {
@@ -1602,30 +1596,6 @@
 */
public function clearProcessCache() {
$this->processCaches = [];
-   }
-
-   /**
-* Enable or disable the use of brief caching for tombstoned keys
-*
-* When a key is purged via delete(), there normally is a period where 
caching
-* is hold-off limited to an extremely short time. This method will 
disable that
-* caching, forcing the callback to run for any of:
-*   - WANObjectCache::getWithSetCallback()
-*   - WANObjectCache::getMultiWithSetCallback()
-*   - WANObjectCache::getMultiWithUnionSetCallback()
-*
-* This is useful when both:
-*   - a) the database used by the callback is known to be up-to-date 
enough
-*for some particular purpose (e.g. replica DB has applied 
transaction X)
-*   - b) the caller needs to exploit that fact, and therefore needs to 
avoid the
-*use of inherently volatile and possibly stale interim keys
-*
-* @see WANObjectCache::delete()
-* @param bool $enabled Whether to enable interim caching
-* @since 1.31
-*/
-   final public function useInterimHoldOffCaching( $enabled ) {
-   $this->useInterimHoldOffCaching = $enabled;
}
 
/**
diff --git a/tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php 
b/tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php
index e534f92..59b739d 100644
--- a/tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php
+++

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.31.0-wmf.11]: Revert "Make ChronologyProtector actually use cpPosTime cook...

2017-12-08 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396446 )

Change subject: Revert "Make ChronologyProtector actually use cpPosTime cookies"
..

Revert "Make ChronologyProtector actually use cpPosTime cookies"

This reverts commit c46fa4c474035779cd8b4a961f0f6941ef102a1c.

Bug: T182322
Change-Id: If997b02916dbc513843871ed108a88d8362f8bfb
---
M includes/Setup.php
M includes/libs/rdbms/lbfactory/ILBFactory.php
M includes/libs/rdbms/lbfactory/LBFactory.php
3 files changed, 4 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/46/396446/1

diff --git a/includes/Setup.php b/includes/Setup.php
index 081ea68..4c281b1 100644
--- a/includes/Setup.php
+++ b/includes/Setup.php
@@ -734,18 +734,13 @@
$wgDBerrorLogTZ = $wgLocaltimezone;
 }
 
-// Initialize the request object in $wgRequest
+// initialize the request object in $wgRequest
 $wgRequest = RequestContext::getMain()->getRequest(); // BackCompat
 // Set user IP/agent information for causal consistency purposes
 MediaWikiServices::getInstance()->getDBLoadBalancerFactory()->setRequestInfo( [
'IPAddress' => $wgRequest->getIP(),
'UserAgent' => $wgRequest->getHeader( 'User-Agent' ),
-   'ChronologyProtection' => $wgRequest->getHeader( 'ChronologyProtection' 
),
-   // The cpPosTime cookie has no prefix and is set by 
MediaWiki::preOutputCommit()
-   'ChronologyPositionTime' => $wgRequest->getFloat(
-   'cpPosTime',
-   $wgRequest->getCookie( 'cpPosTime', '' )
-   )
+   'ChronologyProtection' => $wgRequest->getHeader( 'ChronologyProtection' 
)
 ] );
 
 // Useful debug output
diff --git a/includes/libs/rdbms/lbfactory/ILBFactory.php 
b/includes/libs/rdbms/lbfactory/ILBFactory.php
index 697af0e..f6d080e 100644
--- a/includes/libs/rdbms/lbfactory/ILBFactory.php
+++ b/includes/libs/rdbms/lbfactory/ILBFactory.php
@@ -319,7 +319,6 @@
 *   - IPAddress : IP address
 *   - UserAgent : User-Agent HTTP header
 *   - ChronologyProtection : cookie/header value specifying 
ChronologyProtector usage
-*   - ChronologyPositionTime: timestamp used to get up-to-date DB 
positions for the agent
 */
public function setRequestInfo( array $info );
 }
diff --git a/includes/libs/rdbms/lbfactory/LBFactory.php 
b/includes/libs/rdbms/lbfactory/LBFactory.php
index ef716b6..c891fb6 100644
--- a/includes/libs/rdbms/lbfactory/LBFactory.php
+++ b/includes/libs/rdbms/lbfactory/LBFactory.php
@@ -115,8 +115,7 @@
$this->requestInfo = [
'IPAddress' => isset( $_SERVER[ 'REMOTE_ADDR' ] ) ? 
$_SERVER[ 'REMOTE_ADDR' ] : '',
'UserAgent' => isset( $_SERVER['HTTP_USER_AGENT'] ) ? 
$_SERVER['HTTP_USER_AGENT'] : '',
-   'ChronologyProtection' => 'true',
-   'ChronologyPositionTime' => isset( $_GET['cpPosTime'] ) 
? $_GET['cpPosTime'] : null
+   'ChronologyProtection' => 'true'
];
 
$this->cliMode = isset( $conf['cliMode'] ) ? $conf['cliMode'] : 
PHP_SAPI === 'cli';
@@ -441,7 +440,7 @@
'ip' => $this->requestInfo['IPAddress'],
'agent' => $this->requestInfo['UserAgent'],
],
-   $this->requestInfo['ChronologyPositionTime']
+   isset( $_GET['cpPosTime'] ) ? $_GET['cpPosTime'] : null
);
$this->chronProt->setLogger( $this->replLogger );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/396446
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If997b02916dbc513843871ed108a88d8362f8bfb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.31.0-wmf.11
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "objectcache: Make WANObjectCache interim caching not...

2017-12-08 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396443 )

Change subject: Revert "objectcache: Make WANObjectCache interim caching not 
interfere with ChronologyProtector"
..

Revert "objectcache: Make WANObjectCache interim caching not interfere with 
ChronologyProtector"

This reverts commit e90eafdf6107d4e49c9c20f6310d1d6ee5f5c47f.

Bug: T182322
Change-Id: Ifaf5623c21e22822fba14156ff2490d066dba726
---
M includes/Setup.php
M includes/libs/objectcache/WANObjectCache.php
M tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php
3 files changed, 11 insertions(+), 94 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/43/396443/1

diff --git a/includes/Setup.php b/includes/Setup.php
index d6f4b2f..081ea68 100644
--- a/includes/Setup.php
+++ b/includes/Setup.php
@@ -736,20 +736,17 @@
 
 // Initialize the request object in $wgRequest
 $wgRequest = RequestContext::getMain()->getRequest(); // BackCompat
-// Set user IP/agent information for causal consistency purposes.
-// The cpPosTime cookie has no prefix and is set by 
MediaWiki::preOutputCommit().
-$cpPosTime = $wgRequest->getFloat( 'cpPosTime', $wgRequest->getCookie( 
'cpPosTime', '' ) );
+// Set user IP/agent information for causal consistency purposes
 MediaWikiServices::getInstance()->getDBLoadBalancerFactory()->setRequestInfo( [
'IPAddress' => $wgRequest->getIP(),
'UserAgent' => $wgRequest->getHeader( 'User-Agent' ),
'ChronologyProtection' => $wgRequest->getHeader( 'ChronologyProtection' 
),
-   'ChronologyPositionTime' => $cpPosTime
+   // The cpPosTime cookie has no prefix and is set by 
MediaWiki::preOutputCommit()
+   'ChronologyPositionTime' => $wgRequest->getFloat(
+   'cpPosTime',
+   $wgRequest->getCookie( 'cpPosTime', '' )
+   )
 ] );
-// Make sure that caching does not compromise the consistency improvements
-if ( $cpPosTime ) {
-   
MediaWikiServices::getInstance()->getMainWANObjectCache()->useInterimHoldOffCaching(
 false );
-}
-unset( $cpPosTime );
 
 // Useful debug output
 if ( $wgCommandLineMode ) {
diff --git a/includes/libs/objectcache/WANObjectCache.php 
b/includes/libs/objectcache/WANObjectCache.php
index 8f2c72a..6451443 100644
--- a/includes/libs/objectcache/WANObjectCache.php
+++ b/includes/libs/objectcache/WANObjectCache.php
@@ -91,8 +91,6 @@
protected $logger;
/** @var StatsdDataFactoryInterface */
protected $stats;
-   /** @var bool Whether to use "interim" caching while keys are 
tombstoned */
-   protected $useInterimHoldOffCaching = true;
/** @var callable|null Function that takes a WAN cache callback and 
runs it later */
protected $asyncHandler;
 
@@ -1209,10 +1207,6 @@
 * @return mixed
 */
protected function getInterimValue( $key, $versioned, $minTime, &$asOf 
) {
-   if ( !$this->useInterimHoldOffCaching ) {
-   return false; // disabled
-   }
-
$wrapped = $this->cache->get( self::INTERIM_KEY_PREFIX . $key );
list( $value ) = $this->unwrap( $wrapped, 
$this->getCurrentTime() );
if ( $value !== false && $this->isValid( $value, $versioned, 
$asOf, $minTime ) ) {
@@ -1602,30 +1596,6 @@
 */
public function clearProcessCache() {
$this->processCaches = [];
-   }
-
-   /**
-* Enable or disable the use of brief caching for tombstoned keys
-*
-* When a key is purged via delete(), there normally is a period where 
caching
-* is hold-off limited to an extremely short time. This method will 
disable that
-* caching, forcing the callback to run for any of:
-*   - WANObjectCache::getWithSetCallback()
-*   - WANObjectCache::getMultiWithSetCallback()
-*   - WANObjectCache::getMultiWithUnionSetCallback()
-*
-* This is useful when both:
-*   - a) the database used by the callback is known to be up-to-date 
enough
-*for some particular purpose (e.g. replica DB has applied 
transaction X)
-*   - b) the caller needs to exploit that fact, and therefore needs to 
avoid the
-*use of inherently volatile and possibly stale interim keys
-*
-* @see WANObjectCache::delete()
-* @param bool $enabled Whether to enable interim caching
-* @since 1.31
-*/
-   final public function useInterimHoldOffCaching( $enabled ) {
-   $this->useInterimHoldOffCaching = $enabled;
}
 
/**
diff --git a/tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php 
b/tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php
index e534f92..59b739d 100644
--- a/tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php
+++

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "Make ChronologyProtector actually use cpPosTime cook...

2017-12-08 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396444 )

Change subject: Revert "Make ChronologyProtector actually use cpPosTime cookies"
..

Revert "Make ChronologyProtector actually use cpPosTime cookies"

This reverts commit c46fa4c474035779cd8b4a961f0f6941ef102a1c.

Bug: T182322
Change-Id: If997b02916dbc513843871ed108a88d8362f8bfb
---
M includes/Setup.php
M includes/libs/rdbms/lbfactory/ILBFactory.php
M includes/libs/rdbms/lbfactory/LBFactory.php
3 files changed, 4 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/44/396444/1

diff --git a/includes/Setup.php b/includes/Setup.php
index 081ea68..4c281b1 100644
--- a/includes/Setup.php
+++ b/includes/Setup.php
@@ -734,18 +734,13 @@
$wgDBerrorLogTZ = $wgLocaltimezone;
 }
 
-// Initialize the request object in $wgRequest
+// initialize the request object in $wgRequest
 $wgRequest = RequestContext::getMain()->getRequest(); // BackCompat
 // Set user IP/agent information for causal consistency purposes
 MediaWikiServices::getInstance()->getDBLoadBalancerFactory()->setRequestInfo( [
'IPAddress' => $wgRequest->getIP(),
'UserAgent' => $wgRequest->getHeader( 'User-Agent' ),
-   'ChronologyProtection' => $wgRequest->getHeader( 'ChronologyProtection' 
),
-   // The cpPosTime cookie has no prefix and is set by 
MediaWiki::preOutputCommit()
-   'ChronologyPositionTime' => $wgRequest->getFloat(
-   'cpPosTime',
-   $wgRequest->getCookie( 'cpPosTime', '' )
-   )
+   'ChronologyProtection' => $wgRequest->getHeader( 'ChronologyProtection' 
)
 ] );
 
 // Useful debug output
diff --git a/includes/libs/rdbms/lbfactory/ILBFactory.php 
b/includes/libs/rdbms/lbfactory/ILBFactory.php
index 697af0e..f6d080e 100644
--- a/includes/libs/rdbms/lbfactory/ILBFactory.php
+++ b/includes/libs/rdbms/lbfactory/ILBFactory.php
@@ -319,7 +319,6 @@
 *   - IPAddress : IP address
 *   - UserAgent : User-Agent HTTP header
 *   - ChronologyProtection : cookie/header value specifying 
ChronologyProtector usage
-*   - ChronologyPositionTime: timestamp used to get up-to-date DB 
positions for the agent
 */
public function setRequestInfo( array $info );
 }
diff --git a/includes/libs/rdbms/lbfactory/LBFactory.php 
b/includes/libs/rdbms/lbfactory/LBFactory.php
index ef716b6..c891fb6 100644
--- a/includes/libs/rdbms/lbfactory/LBFactory.php
+++ b/includes/libs/rdbms/lbfactory/LBFactory.php
@@ -115,8 +115,7 @@
$this->requestInfo = [
'IPAddress' => isset( $_SERVER[ 'REMOTE_ADDR' ] ) ? 
$_SERVER[ 'REMOTE_ADDR' ] : '',
'UserAgent' => isset( $_SERVER['HTTP_USER_AGENT'] ) ? 
$_SERVER['HTTP_USER_AGENT'] : '',
-   'ChronologyProtection' => 'true',
-   'ChronologyPositionTime' => isset( $_GET['cpPosTime'] ) 
? $_GET['cpPosTime'] : null
+   'ChronologyProtection' => 'true'
];
 
$this->cliMode = isset( $conf['cliMode'] ) ? $conf['cliMode'] : 
PHP_SAPI === 'cli';
@@ -441,7 +440,7 @@
'ip' => $this->requestInfo['IPAddress'],
'agent' => $this->requestInfo['UserAgent'],
],
-   $this->requestInfo['ChronologyPositionTime']
+   isset( $_GET['cpPosTime'] ) ? $_GET['cpPosTime'] : null
);
$this->chronProt->setLogger( $this->replLogger );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/396444
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If997b02916dbc513843871ed108a88d8362f8bfb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Disable GlobalBlocking on fishbowl wikis

2017-12-08 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396437 )

Change subject: Disable GlobalBlocking on fishbowl wikis
..

Disable GlobalBlocking on fishbowl wikis

Change-Id: Id69a4f482a12ee6a6b85e7b2af1825e504307a05
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/37/396437/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 9f58fbe..fdb4d07 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -18902,6 +18902,7 @@
 'wmgUseGlobalBlocking' => [
'default' => true,
'wikitech' => false,
+   'fishbowl' => false,
'private' => false,
 ],
 

-- 
To view, visit https://gerrit.wikimedia.org/r/396437
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id69a4f482a12ee6a6b85e7b2af1825e504307a05
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove WatchedItem deprecated methods

2017-12-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396299 )

Change subject: Remove WatchedItem deprecated methods
..

Remove WatchedItem deprecated methods

Remove tests that test them

Bug: T182381
Change-Id: I0214250a7cb81518074a14e35590370b13d4ba64
---
M includes/watcheditem/WatchedItem.php
D tests/phpunit/includes/watcheditem/WatchedItemIntegrationTest.php
D tests/phpunit/includes/watcheditem/WatchedItemUnitTest.php
3 files changed, 0 insertions(+), 374 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/99/396299/1

diff --git a/includes/watcheditem/WatchedItem.php 
b/includes/watcheditem/WatchedItem.php
index bfd1d61..a813f58 100644
--- a/includes/watcheditem/WatchedItem.php
+++ b/includes/watcheditem/WatchedItem.php
@@ -30,17 +30,6 @@
  * @ingroup Watchlist
  */
 class WatchedItem {
-
-   /**
-* @deprecated since 1.27, see User::IGNORE_USER_RIGHTS
-*/
-   const IGNORE_USER_RIGHTS = User::IGNORE_USER_RIGHTS;
-
-   /**
-* @deprecated since 1.27, see User::CHECK_USER_RIGHTS
-*/
-   const CHECK_USER_RIGHTS = User::CHECK_USER_RIGHTS;
-
/**
 * @deprecated Internal class use only
 */
@@ -129,72 +118,4 @@
}
return $this->notificationTimestamp;
}
-
-   /**
-* Back compat pre 1.27 with the WatchedItemStore introduction
-* @todo remove in 1.28/9
-* -
-*/
-
-   /**
-* @return Title
-* @deprecated Internal class use only
-*/
-   public function getTitle() {
-   if ( !$this->title ) {
-   $this->title = Title::newFromLinkTarget( 
$this->linkTarget );
-   }
-   return $this->title;
-   }
-
-   /**
-* @deprecated since 1.27 Use the constructor, 
WatchedItemStore::getWatchedItem()
-* or WatchedItemStore::loadWatchedItem()
-*/
-   public static function fromUserTitle( $user, $title, $checkRights = 
User::CHECK_USER_RIGHTS ) {
-   wfDeprecated( __METHOD__, '1.27' );
-   return new self( $user, $title, 
self::DEPRECATED_USAGE_TIMESTAMP, (bool)$checkRights );
-   }
-
-   /**
-* @deprecated since 1.27 Use User::addWatch()
-* @return bool
-*/
-   public function addWatch() {
-   wfDeprecated( __METHOD__, '1.27' );
-   $this->user->addWatch( $this->getTitle(), $this->checkRights );
-   return true;
-   }
-
-   /**
-* @deprecated since 1.27 Use User::removeWatch()
-* @return bool
-*/
-   public function removeWatch() {
-   wfDeprecated( __METHOD__, '1.27' );
-   if ( $this->checkRights && !$this->user->isAllowed( 
'editmywatchlist' ) ) {
-   return false;
-   }
-   $this->user->removeWatch( $this->getTitle(), $this->checkRights 
);
-   return true;
-   }
-
-   /**
-* @deprecated since 1.27 Use User::isWatched()
-* @return bool
-*/
-   public function isWatched() {
-   wfDeprecated( __METHOD__, '1.27' );
-   return $this->user->isWatched( $this->getTitle(), 
$this->checkRights );
-   }
-
-   /**
-* @deprecated since 1.27 Use 
WatchedItemStore::duplicateAllAssociatedEntries()
-*/
-   public static function duplicateEntries( Title $oldTitle, Title 
$newTitle ) {
-   wfDeprecated( __METHOD__, '1.27' );
-   $store = 
MediaWikiServices::getInstance()->getWatchedItemStore();
-   $store->duplicateAllAssociatedEntries( $oldTitle, $newTitle );
-   }
-
 }
diff --git a/tests/phpunit/includes/watcheditem/WatchedItemIntegrationTest.php 
b/tests/phpunit/includes/watcheditem/WatchedItemIntegrationTest.php
deleted file mode 100644
index 01e7ecb..000
--- a/tests/phpunit/includes/watcheditem/WatchedItemIntegrationTest.php
+++ /dev/null
@@ -1,145 +0,0 @@
-hideDeprecated( 'WatchedItem::fromUserTitle' );
-   $this->hideDeprecated( 'WatchedItem::addWatch' );
-   $this->hideDeprecated( 'WatchedItem::removeWatch' );
-   $this->hideDeprecated( 'WatchedItem::isWatched' );
-   $this->hideDeprecated( 'WatchedItem::duplicateEntries' );
-   $this->hideDeprecated( 'WatchedItem::batchAddWatch' );
-   }
-
-   private function getUser() {
-   return 
self::$users['WatchedItemIntegrationTestUser']->getUser();
-   }
-
-   public function testWatchAndUnWatchItem() {
-   $user = $this->getUser();
-   $title = Title::newFromText( 'WatchedItemIntegrationTestPage' );
-   // Cleanup after previous tests
-   WatchedItem::fromUserTitle(

[MediaWiki-commits] [Gerrit] mediawiki...OAuthAuthentication[master]: Stop using Deprecated WatchedItem::IGNORE_USER_RIGHTS

2017-12-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396298 )

Change subject: Stop using Deprecated WatchedItem::IGNORE_USER_RIGHTS
..

Stop using Deprecated WatchedItem::IGNORE_USER_RIGHTS

Change-Id: I7418e0bce728dda6198d7ae6e225f2151ff29542
---
M handlers/AuthenticationHandler.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuthAuthentication 
refs/changes/98/396298/1

diff --git a/handlers/AuthenticationHandler.php 
b/handlers/AuthenticationHandler.php
index 78a5470..a27ad16 100644
--- a/handlers/AuthenticationHandler.php
+++ b/handlers/AuthenticationHandler.php
@@ -77,7 +77,7 @@
 
$u->setToken();
\DeferredUpdates::addUpdate( new \SiteStatsUpdate( 0, 
0, 0, 0, 1 ) );
-   $u->addWatch( $u->getUserPage(), 
\WatchedItem::IGNORE_USER_RIGHTS );
+   $u->addWatch( $u->getUserPage(), 
\User::IGNORE_USER_RIGHTS );
$u->saveSettings();
 
Hooks::run( 'AddNewAccount', [ $u, false ] );

-- 
To view, visit https://gerrit.wikimedia.org/r/396298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7418e0bce728dda6198d7ae6e225f2151ff29542
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuthAuthentication
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix missing if from $wgDBssl comment

2017-12-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396295 )

Change subject: Fix missing if from $wgDBssl comment
..

Fix missing if from $wgDBssl comment

Change-Id: I46d1a87c990198090fd322da3193014487e871e6
---
M includes/DefaultSettings.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/95/396295/1

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index c17bf7e..6fe74fa 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -1806,7 +1806,7 @@
 /**
  * Whether to use SSL in DB connection.
  *
- * This setting is only used $wgLBFactoryConf['class'] is set to
+ * This setting is only used if $wgLBFactoryConf['class'] is set to
  * 'LBFactorySimple' and $wgDBservers is an empty array; otherwise
  * the DBO_SSL flag must be set in the 'flags' option of the database
  * connection to achieve the same functionality.

-- 
To view, visit https://gerrit.wikimedia.org/r/396295
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46d1a87c990198090fd322da3193014487e871e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make travis test against PHP 7.2

2017-12-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396288 )

Change subject: Make travis test against PHP 7.2
..

Make travis test against PHP 7.2

Change-Id: I3e77c383486550e116b4630b56d255ec6c043e2d
---
M .travis.yml
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/88/396288/1

diff --git a/.travis.yml b/.travis.yml
index 78a2b7d..64414b5 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -35,6 +35,8 @@
   php: 7
 - env: dbtype=mysql dbuser=root
   php: 7.1
+- env: dbtype=mysql dbuser=root
+  php: 7.2
 
 services:
   - mysql

-- 
To view, visit https://gerrit.wikimedia.org/r/396288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e77c383486550e116b4630b56d255ec6c043e2d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GraphViz[REL1_27]: Fix undefined $out

2017-12-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396094 )

Change subject: Fix undefined $out
..

Fix undefined $out

Change-Id: Iddf9179fae8b3562991219a52d3d4cb10e514dac
---
M GraphViz_body.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GraphViz 
refs/changes/94/396094/2

diff --git a/GraphViz_body.php b/GraphViz_body.php
index c27134c..3e31d94 100644
--- a/GraphViz_body.php
+++ b/GraphViz_body.php
@@ -442,7 +442,7 @@
 
$title = $out->getTitle();
 
-   self::uploadImagesForTitle( $title, $wgUser );
+   self::uploadImagesForTitle( $title, $wgUser, $out );
 
return true;
}
@@ -453,7 +453,7 @@
 * @return int number of uploaded images
 * @author Keith Welter
 */
-   public static function uploadImagesForTitle( $title, $user ) {
+   public static function uploadImagesForTitle( $title, $user, $out ) {
// find any stored images for the page
$graphName = self::getGraphFileBaseNameFromTitle( $title );
$imageDir = self::getImageDir();

-- 
To view, visit https://gerrit.wikimedia.org/r/396094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddf9179fae8b3562991219a52d3d4cb10e514dac
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/GraphViz
Gerrit-Branch: REL1_27
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Make GraphViz depend on ImageMap

2017-12-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396093 )

Change subject: Make GraphViz depend on ImageMap
..

Make GraphViz depend on ImageMap

Change-Id: I5cc0563ff3c6223c88d6f246576f57f51710ae00
---
M zuul/parameter_functions.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/93/396093/1

diff --git a/zuul/parameter_functions.py b/zuul/parameter_functions.py
index a7f1be3..4313269 100644
--- a/zuul/parameter_functions.py
+++ b/zuul/parameter_functions.py
@@ -185,6 +185,7 @@
 'FlaggedRevs': ['Scribunto'],
 'GettingStarted': ['CentralAuth', 'EventLogging', 'GuidedTour'],
 'Graph': ['CodeEditor', 'JsonConfig', 'VisualEditor'],
+'GraphViz': ['ImageMap'],
 'GuidedTour': ['EventLogging'],
 'GWToolset': ['SyntaxHighlight_GeSHi', 'Scribunto', 'TemplateData'],
 'ImageMetrics': ['EventLogging'],

-- 
To view, visit https://gerrit.wikimedia.org/r/396093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5cc0563ff3c6223c88d6f246576f57f51710ae00
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GraphViz[master]: GraphViz depends on ImageMap

2017-12-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396092 )

Change subject: GraphViz depends on ImageMap
..

GraphViz depends on ImageMap

Change-Id: If76f5457de6563b2193f8a2275bd77ce528571fd
---
M extension.json
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GraphViz 
refs/changes/92/396092/1

diff --git a/extension.json b/extension.json
index 7e01f70..eae57e4 100644
--- a/extension.json
+++ b/extension.json
@@ -13,7 +13,10 @@
"descriptionmsg": "graphviz-desc",
"license-name": "GPL-2.0+",
"requires": {
-   "MediaWiki": ">= 1.29.0"
+   "MediaWiki": ">= 1.29.0",
+   "extensions": {
+   "ImageMap": "*"
+   },
},
"AutoloadClasses": {
"MediaWiki\\Extension\\GraphViz\\GraphViz": 
"includes/GraphViz.php",

-- 
To view, visit https://gerrit.wikimedia.org/r/396092
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If76f5457de6563b2193f8a2275bd77ce528571fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GraphViz
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] RunningStat[master]: Use short array syntax in README.md

2017-12-06 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395914 )

Change subject: Use short array syntax in README.md
..

Use short array syntax in README.md

Requires PHP >= 5.5.9

Change-Id: I33a543b30480f9417b462d0c37d5430903b8e197
---
M README.md
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/RunningStat refs/changes/14/395914/1

diff --git a/README.md b/README.md
index 082b6d2..93927e1 100644
--- a/README.md
+++ b/README.md
@@ -29,12 +29,12 @@
 use Wikimedia\RunningStat;
 
 $rstat = new RunningStat();
-foreach ( array(
+foreach ( [
   49.7168, 74.3804,  7.0115, 96.5769, 34.9458,
   36.9947, 33.8926, 89.0774, 23.7745, 73.5154,
   86.1322, 53.2124, 16.2046, 73.5130, 10.4209,
   42.7299, 49.3330, 47.0215, 34.9950, 18.2914,
-) as $sample ) {
+] as $sample ) {
   $rstat->addObservation( $sample );
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/395914
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33a543b30480f9417b462d0c37d5430903b8e197
Gerrit-PatchSet: 1
Gerrit-Project: RunningStat
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] WrappedString[master]: Use short array syntax in README.md

2017-12-06 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395912 )

Change subject: Use short array syntax in README.md
..

Use short array syntax in README.md

Requires PHP >= 5.5.9

Change-Id: I3f83b42eecda44b90de70b8e62a5cd12ca20cf67
---
M README.md
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/WrappedString 
refs/changes/12/395912/1

diff --git a/README.md b/README.md
index b3c2f0e..b828e6f 100644
--- a/README.md
+++ b/README.md
@@ -10,10 +10,10 @@
 
 use Wikimedia\WrappedString;
 
-$buffer = array(
+$buffer = [
new WrappedString( '[foo]', '[', ']' ),
new WrappedString( '[bar]', '[', ']' ),
-);
+];
 $output = WrappedString::join( "\n", $buffer );
 // Result: '[foobar]'
 

-- 
To view, visit https://gerrit.wikimedia.org/r/395912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f83b42eecda44b90de70b8e62a5cd12ca20cf67
Gerrit-PatchSet: 1
Gerrit-Project: WrappedString
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ThrottleOverride[master]: Fix undefined $db

2017-12-03 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394912 )

Change subject: Fix undefined $db
..

Fix undefined $db

Noticed while testing Flow locally...

Change-Id: I0ca42bbad79c9968cb8a2629eca5207ef18d18b5
---
M includes/ThrottleOverrideHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ThrottleOverride 
refs/changes/12/394912/1

diff --git a/includes/ThrottleOverrideHooks.php 
b/includes/ThrottleOverrideHooks.php
index 25f67f2..43bb38b 100644
--- a/includes/ThrottleOverrideHooks.php
+++ b/includes/ThrottleOverrideHooks.php
@@ -71,7 +71,7 @@
$dbr = ThrottleOverrideUtils::getCentralDB( 
DB_REPLICA );
$setOpts += Database::getCacheSetOptions( $dbr 
);
 
-   $quotedIp = $db->addQuotes( $hexIp );
+   $quotedIp = $dbr->addQuotes( $hexIp );
$expiry = $dbr->selectField(
'throttle_override',
'thr_expiry',

-- 
To view, visit https://gerrit.wikimedia.org/r/394912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ca42bbad79c9968cb8a2629eca5207ef18d18b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ThrottleOverride
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Update zordius/lightncandy v0.23 to v1.1.0

2017-12-03 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394911 )

Change subject: Update zordius/lightncandy v0.23 to v1.1.0
..

Update zordius/lightncandy v0.23 to v1.1.0

Change-Id: I607aee7469c3d39da02d324083a6e8f8468c1c27
Depends-On: Ida9e12e759cdc4508238c3215354485a6561
Depends-On: I734ee96b6b020f22a9743e1905b147a7d5e05123
---
M includes/TemplateHelper.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/11/394911/1

diff --git a/includes/TemplateHelper.php b/includes/TemplateHelper.php
index 069c7bd..22a8058 100644
--- a/includes/TemplateHelper.php
+++ b/includes/TemplateHelper.php
@@ -8,7 +8,7 @@
 use Closure;
 use HTML;
 use OOUI\IconWidget;
-use LightnCandy;
+use LightnCandy\LightnCandy;
 use MWTimestamp;
 use RequestContext;
 use Title;

-- 
To view, visit https://gerrit.wikimedia.org/r/394911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I607aee7469c3d39da02d324083a6e8f8468c1c27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/jenkins[master]: Remove `composer dump-autoload --optimize`

2017-12-03 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394907 )

Change subject: Remove `composer dump-autoload --optimize`
..

Remove `composer dump-autoload --optimize`

Change-Id: I45329e95f69d66c05230ca39cc28d32cf218b2b3
---
M bin/mw-fetch-composer-dev.sh
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins 
refs/changes/07/394907/2

diff --git a/bin/mw-fetch-composer-dev.sh b/bin/mw-fetch-composer-dev.sh
index 01ed093..09f1d36 100755
--- a/bin/mw-fetch-composer-dev.sh
+++ b/bin/mw-fetch-composer-dev.sh
@@ -16,11 +16,6 @@
composer config extra.merge-plugin.include 
"$MW_INSTALL_PATH/composer.json"
 fi
 
-# FIXME: integration/composer is outdated and breaks autoloader
-# Once we're on composer 1.0.0-alpha11 or higher this might not
-# be needed anymore
-composer dump-autoload --optimize
-
 mkdir -p "$LOG_DIR"
 [ -f "$MW_INSTALL_PATH/composer.json" ] && cp -vf 
"$MW_INSTALL_PATH/composer.json" "$LOG_DIR/composer.core.json.txt" || :
 [ -f "$MW_INSTALL_PATH/vendor/composer.json" ] && cp -vf 
"$MW_INSTALL_PATH/vendor/composer.json" "$LOG_DIR/composer.vendor.json.txt" || :

-- 
To view, visit https://gerrit.wikimedia.org/r/394907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45329e95f69d66c05230ca39cc28d32cf218b2b3
Gerrit-PatchSet: 2
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: RepoGroup::findFile() can and will return false

2017-12-03 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394861 )

Change subject: RepoGroup::findFile() can and will return false
..

RepoGroup::findFile() can and will return false

Bug: T181944
Change-Id: I978ed2f9f3005210f6713a7f3ecde1fe0501a5ff
---
M includes/page/DatabaseIndexForPageLookup.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/61/394861/1

diff --git a/includes/page/DatabaseIndexForPageLookup.php 
b/includes/page/DatabaseIndexForPageLookup.php
index e71a3c2..3e0125b 100644
--- a/includes/page/DatabaseIndexForPageLookup.php
+++ b/includes/page/DatabaseIndexForPageLookup.php
@@ -75,7 +75,7 @@
if ( $imageTitle !== null ) {
$image = $this->repoGroup->findFile( 
$imageTitle );
// if it is multipage, we use the page order of 
the file
-   if ( $image->exists() && $image->isMultipage() 
) {
+   if ( $image && $image->exists() && 
$image->isMultipage() ) {
return Title::makeTitle(
$this->indexNamespaceId, 
$image->getTitle()->getText()
);

-- 
To view, visit https://gerrit.wikimedia.org/r/394861
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I978ed2f9f3005210f6713a7f3ecde1fe0501a5ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/composer[master]: Minor README.md updates

2017-12-03 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394858 )

Change subject: Minor README.md updates
..

Minor README.md updates

Change-Id: I9ee71785117ff6443f7b6759ac91e97e16ac0f1e
---
M README.md
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/composer 
refs/changes/58/394858/1

diff --git a/README.md b/README.md
index 174d261..93f3e96 100644
--- a/README.md
+++ b/README.md
@@ -4,7 +4,7 @@
 deploy Composer on the Wikimedia cluster since:
 
 1) we can NOT download from third parties
-2) there isno Debian package for Composer
+2) there is no Debian package for Composer (until Debian Stretch, which has 
1.2.2)
 
 ## How to update
 
@@ -30,5 +30,5 @@
 
 Then ask for review.
 
-The composer executable will be available on the Wikimedia Jenkins slave as
-/srv/deployment/integration/composer/vendor/bin/composer
+The composer executable will be available on the Wikimedia Jenkins slaves at
+`/srv/deployment/integration/composer/vendor/bin/composer`

-- 
To view, visit https://gerrit.wikimedia.org/r/394858
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ee71785117ff6443f7b6759ac91e97e16ac0f1e
Gerrit-PatchSet: 1
Gerrit-Project: integration/composer
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/jenkins[master]: Swap node for jq

2017-12-03 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394856 )

Change subject: Swap node for jq
..

Swap node for jq

Bug: T181938
Change-Id: Ifc2c2484fbfc617134da70abf027755b72ac41bd
---
M bin/mw-fetch-composer-dev.sh
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins 
refs/changes/56/394856/2

diff --git a/bin/mw-fetch-composer-dev.sh b/bin/mw-fetch-composer-dev.sh
index 01ed093..b359fdc 100755
--- a/bin/mw-fetch-composer-dev.sh
+++ b/bin/mw-fetch-composer-dev.sh
@@ -5,10 +5,8 @@
 cd "$MW_INSTALL_PATH/vendor"
 
 # Load require-dev packages on top of mediawiki/vendor (T112895)
-# Once jq 1.4 is available, the following may be used instead:
-# > jq -r '.["require-dev"]|to_entries|map([.key,.value])[]|join("=")' 
../composer.json
 set -o pipefail
-node $(dirname $0)/../tools/composer-dev-args.js 
"$MW_INSTALL_PATH/composer.json" | xargs --verbose composer require --dev 
--ansi --no-progress --prefer-dist -v
+jq -r '.["require-dev"]|to_entries|map([.key,.value])[]|join("=")' 
"$MW_INSTALL_PATH/composer.json" | xargs --verbose composer require --dev 
--ansi --no-progress --prefer-dist -v
 
 # Point composer-merge-plugin to mediawiki/core to have it to merge
 # autoload-dev. T158674

-- 
To view, visit https://gerrit.wikimedia.org/r/394856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc2c2484fbfc617134da70abf027755b72ac41bd
Gerrit-PatchSet: 2
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/jenkins[master]: Wrap values in composer-dev-args.js

2017-12-03 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394855 )

Change subject: Wrap values in composer-dev-args.js
..

Wrap values in composer-dev-args.js

Bug: T181937
Change-Id: I121488eb179d35f540e77a354c9a62832e57ac4a
---
M tools/composer-dev-args.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins 
refs/changes/55/394855/2

diff --git a/tools/composer-dev-args.js b/tools/composer-dev-args.js
index 5026807..f317162 100755
--- a/tools/composer-dev-args.js
+++ b/tools/composer-dev-args.js
@@ -3,5 +3,5 @@
 
 devPackages = require( process.argv[ 2 ] )[ 'require-dev' ];
 for ( package in devPackages ) {
-   console.log( package + '=' + devPackages[ package ] );
+   console.log( package + '="' + devPackages[ package ] + '"' );
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/394855
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I121488eb179d35f540e77a354c9a62832e57ac4a
Gerrit-PatchSet: 2
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Allow PHPUnit 5 and 6 versions optionally in require-dev

2017-12-03 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394851 )

Change subject: Allow PHPUnit 5 and 6 versions optionally in require-dev
..

Allow PHPUnit 5 and 6 versions optionally in require-dev

Bug: T181931
Change-Id: I497712c7693d137be197a69873baa58383ce9646
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/51/394851/1

diff --git a/composer.json b/composer.json
index 35783f2..bf8cb6f 100644
--- a/composer.json
+++ b/composer.json
@@ -58,7 +58,7 @@
"monolog/monolog": "~1.22.1",
"nikic/php-parser": "2.1.0",
"nmred/kafka-php": "0.1.5",
-   "phpunit/phpunit": "4.8.36",
+   "phpunit/phpunit": "4.8.36 || 5.7.25 || 6.5.2",
"psy/psysh": "0.8.11",
"wikimedia/avro": "1.7.7",
"wikimedia/testing-access-wrapper": "~1.0",

-- 
To view, visit https://gerrit.wikimedia.org/r/394851
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I497712c7693d137be197a69873baa58383ce9646
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Add local groups to meta=globaluserinfo output

2017-12-02 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394817 )

Change subject: Add local groups to meta=globaluserinfo output
..

Add local groups to meta=globaluserinfo output

Bug: T181905
Change-Id: I9e19e7f3d4fcd65777d630628506c195c2f23f84
---
M includes/api/ApiQueryGlobalUserInfo.php
1 file changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/17/394817/1

diff --git a/includes/api/ApiQueryGlobalUserInfo.php 
b/includes/api/ApiQueryGlobalUserInfo.php
index aa3a7c5..35194eb 100644
--- a/includes/api/ApiQueryGlobalUserInfo.php
+++ b/includes/api/ApiQueryGlobalUserInfo.php
@@ -108,6 +108,11 @@
'editcount' => intval( 
$account['editCount'] ),
'registration' => wfTimestamp( 
TS_ISO_8601, $account['registration'] ),
];
+   if ( $account['groupMemberships'] ) {
+   $a['groups'] = array_keys( 
$account['groupMemberships'] );
+   $result->setIndexedTagName( 
$a['groups'], 'group' );
+   }
+
if ( $account['blocked'] ) {
$a['blocked'] = [
'expiry' => 
$this->getLanguage()->formatExpiry(
@@ -134,6 +139,12 @@
'editcount' => $account['editCount'],
'registration' => wfTimestamp( 
TS_ISO_8601, $account['registration'] ),
];
+
+   if ( $account['groupMemberships'] ) {
+   $a['groups'] = array_keys( 
$account['groupMemberships'] );
+   $result->setIndexedTagName( 
$a['groups'], 'group' );
+   }
+
if ( $account['blocked'] ) {
$a['blocked'] = [
'expiry' => 
$this->getLanguage()->formatExpiry(

-- 
To view, visit https://gerrit.wikimedia.org/r/394817
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e19e7f3d4fcd65777d630628506c195c2f23f84
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add abstract functions to abstract class..

2017-12-01 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394643 )

Change subject: Add abstract functions to abstract class..
..

Add abstract functions to abstract class..

Rather than just expecting the child class to have them

Change-Id: Ib145d333e3b8908a8535e974ec8f1f69b2b10e3a
---
M tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/43/394643/1

diff --git 
a/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php 
b/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
index 04b12e6..e0b7818 100644
--- 
a/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
+++ 
b/tests/phpunit/includes/specialpage/AbstractChangesListSpecialPageTestCase.php
@@ -47,6 +47,8 @@
$this->changesListSpecialPage->registerFilters();
}
 
+   protected abstract function getPage();
+
protected function tearDown() {
global $wgGroupPermissions;
 
@@ -57,6 +59,8 @@
}
}
 
+   public abstract function provideParseParameters();
+
/**
 * @dataProvider provideParseParameters
 */

-- 
To view, visit https://gerrit.wikimedia.org/r/394643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib145d333e3b8908a8535e974ec8f1f69b2b10e3a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Don't call EditPage::isOouiEnabled() on MW 1.30 or newer

2017-12-01 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394626 )

Change subject: Don't call EditPage::isOouiEnabled() on MW 1.30 or newer
..

Don't call EditPage::isOouiEnabled() on MW 1.30 or newer

Bug: T181828
Change-Id: I91a248e9b679e3363c760415896d0100d9a5c584
---
M TranslateEditAddons.php
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/26/394626/1

diff --git a/TranslateEditAddons.php b/TranslateEditAddons.php
index a194b85..f56cf85 100644
--- a/TranslateEditAddons.php
+++ b/TranslateEditAddons.php
@@ -114,7 +114,9 @@
}
 
$context = $editpage->getArticle()->getContext();
-   $useOoui = method_exists( $editpage, 'isOouiEnabled' ) && 
$editpage->isOouiEnabled();
+   global $wgVersion;
+   $useOoui = version_compare( $wgVersion, '1.30c', '>=' )
+   || method_exists( $editpage, 'isOouiEnabled' ) && 
$editpage->isOouiEnabled();
 
if ( $handle->isDoc() ) {
$langCode = $context->getLanguage()->getCode();

-- 
To view, visit https://gerrit.wikimedia.org/r/394626
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I91a248e9b679e3363c760415896d0100d9a5c584
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Set required MW to 1.25.0 in extension.json

2017-11-30 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394516 )

Change subject: Set required MW to 1.25.0 in extension.json
..

Set required MW to 1.25.0 in extension.json

Change-Id: I7e76cfca9a476be7dd766d14231d0a2ee67cb942
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeMirror 
refs/changes/16/394516/1

diff --git a/extension.json b/extension.json
index 3f259bb..3456b07 100644
--- a/extension.json
+++ b/extension.json
@@ -10,7 +10,7 @@
"type": "parserhook",
"license-name": "GPL-2.0+",
"requires": {
-   "MediaWiki": ">= 1.23.0"
+   "MediaWiki": ">= 1.25.0"
},
"MessagesDirs": {
"CodeMirror": [

-- 
To view, visit https://gerrit.wikimedia.org/r/394516
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e76cfca9a476be7dd766d14231d0a2ee67cb942
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CodeMirror[master]: Remove php entry point

2017-11-30 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394517 )

Change subject: Remove php entry point
..

Remove php entry point

Change-Id: I22859bcd54f41cb17f4470d12321ad7991958b70
---
D CodeMirror.php
1 file changed, 0 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeMirror 
refs/changes/17/394517/1

diff --git a/CodeMirror.php b/CodeMirror.php
deleted file mode 100644
index 568907d..000
--- a/CodeMirror.php
+++ /dev/null
@@ -1,13 +0,0 @@
-https://www.mediawiki.org/wiki/Extension_registration for 
more details.'
-   ); */
-   return true;
-} else {
-   die( 'This version of the CodeMirror extension requires MediaWiki 
1.25+' );
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/394517
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I22859bcd54f41cb17f4470d12321ad7991958b70
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

1 2 3 4 5 6 7 8 9 10 >

1 - 100 of 8199 matches

Mail list logo