[MediaWiki-commits] [Gerrit] mediawiki...VoteNY[master]: Optimize amount of SQL queries for Special:TopRatings

2016-11-14 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/321385 Change subject: Optimize amount of SQL queries for Special:TopRatings .. Optimize amount of SQL queries for Special:TopRatings Put the

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Fix array to string conversion when in CLI mode $value is an...

2016-11-11 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/320996 Change subject: Fix array to string conversion when in CLI mode $value is an array here. .. Fix array to string conversion when in CLI

[MediaWiki-commits] [Gerrit] Remove DNS entries of db1058 - change (operations/dns)

2016-05-05 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/287145 Change subject: Remove DNS entries of db1058 .. Remove DNS entries of db1058 I don't understand the role/manifests/coredb.pp Puppet

[MediaWiki-commits] [Gerrit] checkLocalUser: Fix --delete option - change (mediawiki...CentralAuth)

2016-03-26 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/279720 Change subject: checkLocalUser: Fix --delete option .. checkLocalUser: Fix --delete option getOption() isn't going to return a boolean

[MediaWiki-commits] [Gerrit] Fix --delete option in checkLocalNames.php - change (mediawiki...CentralAuth)

2016-03-26 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/279719 Change subject: Fix --delete option in checkLocalNames.php .. Fix --delete option in checkLocalNames.php Legoktm commited a similar

[MediaWiki-commits] [Gerrit] Fix wrong thead tag - change (operations...wikistats)

2016-02-26 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/273505 Change subject: Fix wrong thead tag .. Fix wrong thead tag I make mistakes too :-) Change-Id:

[MediaWiki-commits] [Gerrit] Clean up display.php table - change (operations...wikistats)

2016-02-26 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/273500 Change subject: Clean up display.php table .. Clean up display.php table * Removed the sort arrows (replaced by JavaScript

[MediaWiki-commits] [Gerrit] Set td font-size to 90% - change (operations...wikistats)

2016-02-24 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/273151 Change subject: Set td font-size to 90% .. Set td font-size to 90% Now the table should fit onto your screen. Change-Id:

[MediaWiki-commits] [Gerrit] Import Bootstrap files to avoid external CDN usage - change (operations...wikistats)

2016-02-24 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/273145 Change subject: Import Bootstrap files to avoid external CDN usage .. Import Bootstrap files to avoid external CDN usage We value user

[MediaWiki-commits] [Gerrit] Fix cannot access private property OutputPage::$mHTMLtitle I... - change (mediawiki...AddHTMLMetaAndTitle)

2016-02-05 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/268693 Change subject: Fix cannot access private property OutputPage::$mHTMLtitle It doesn't seem to be used anyway, so I did not even bother to use getHTMLTitle(). This issue doesn't exist in master.

[MediaWiki-commits] [Gerrit] DumpUploads: output local path instead of mwstore path - change (mediawiki/core)

2016-02-04 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/268417 Change subject: DumpUploads: output local path instead of mwstore path .. DumpUploads: output local path instead of mwstore path Since

[MediaWiki-commits] [Gerrit] XMPValidate: fix undefined variable for logger - change (mediawiki/core)

2016-02-01 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/267667 Change subject: XMPValidate: fix undefined variable for logger .. XMPValidate: fix undefined variable for logger Change-Id:

[MediaWiki-commits] [Gerrit] Move TimedText NS id defines back into ParserAfterCache - change (mediawiki...TimedMediaHandler)

2016-01-23 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/265923 Change subject: Move TimedText NS id defines back into ParserAfterCache .. Move TimedText NS id defines back into ParserAfterCache

[MediaWiki-commits] [Gerrit] Add a .gitreview file - change (mediawiki...Tabs)

2015-12-29 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/261573 Change subject: Add a .gitreview file .. Add a .gitreview file Change-Id: Ic6234e2d153b89a966e61a52b99de23d9f0cea16 --- A .gitreview 1

[MediaWiki-commits] [Gerrit] Add a position to the ext.tabs module - change (mediawiki...Tabs)

2015-12-29 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/261574 Change subject: Add a position to the ext.tabs module .. Add a position to the ext.tabs module Fixes a lot of "style module should

[MediaWiki-commits] [Gerrit] Correctly order MediaWiki servers in site.pp - change (operations/puppet)

2015-12-20 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/260232 Change subject: Correctly order MediaWiki servers in site.pp .. Correctly order MediaWiki servers in site.pp Change-Id:

[MediaWiki-commits] [Gerrit] Major overhaul of Main Page - change (operations...wikistats)

2015-11-10 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/252249 Change subject: Major overhaul of Main Page .. Major overhaul of Main Page Things I've done: * The index page is now fully using

[MediaWiki-commits] [Gerrit] ReCaptchaNoCaptcha: Fix function call on a non-object - change (mediawiki...ConfirmEdit)

2015-10-19 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/247254 Change subject: ReCaptchaNoCaptcha: Fix function call on a non-object .. ReCaptchaNoCaptcha: Fix function call on a non-object $info is

[MediaWiki-commits] [Gerrit] ReCaptchaNoCaptcha: Fix undefined function call to logStatus... - change (mediawiki...ConfirmEdit)

2015-10-14 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/246209 Change subject: ReCaptchaNoCaptcha: Fix undefined function call to logStatusError() .. ReCaptchaNoCaptcha: Fix undefined function call

[MediaWiki-commits] [Gerrit] Fix file permissions - change (mediawiki...chameleon)

2015-09-11 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/237716 Change subject: Fix file permissions .. Fix file permissions Bug: T103799 Change-Id: Ifda1a3c37fcf7c56004ea922c64645fbf18b5a90 --- M

[MediaWiki-commits] [Gerrit] chmod 644 for css files - change (mediawiki...Mask)

2015-09-11 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/237714 Change subject: chmod 644 for css files .. chmod 644 for css files Bug: T103792 Change-Id: Idd5737a1a964e3e07140212386d9068f6ec30462

[MediaWiki-commits] [Gerrit] Fix file permissions - change (mediawiki...mediawiki-strapping)

2015-09-11 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/237718 Change subject: Fix file permissions .. Fix file permissions Bug: T103793 Change-Id: Ie4f68f05aa6b21a1b2b83d38ef1df2a20a00fdd5 --- M

[MediaWiki-commits] [Gerrit] Escape all shell arguments & sanitize filenames - change (mediawiki...Git2Pages)

2015-09-10 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/237399 Change subject: Escape all shell arguments & sanitize filenames .. Escape all shell arguments & sanitize filenames Code for the

[MediaWiki-commits] [Gerrit] Escape all shell arguments & sanitize filenames - change (mediawiki...Git2Pages)

2015-09-10 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/237406 Change subject: Escape all shell arguments & sanitize filenames .. Escape all shell arguments & sanitize filenames Code for the

[MediaWiki-commits] [Gerrit] Escape all shell arguments & sanitize filenames - change (mediawiki...Git2Pages)

2015-09-10 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/237404 Change subject: Escape all shell arguments & sanitize filenames .. Escape all shell arguments & sanitize filenames Code for the

[MediaWiki-commits] [Gerrit] Escape all shell arguments & sanitize filenames - change (mediawiki...Git2Pages)

2015-09-10 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/237407 Change subject: Escape all shell arguments & sanitize filenames .. Escape all shell arguments & sanitize filenames Code for the

[MediaWiki-commits] [Gerrit] Escape all shell arguments & sanitize filenames - change (mediawiki...Git2Pages)

2015-09-09 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/237253 Change subject: Escape all shell arguments & sanitize filenames .. Escape all shell arguments & sanitize filenames Code for the

[MediaWiki-commits] [Gerrit] Escape all shell arguments & sanitize filenames - change (mediawiki...Git2Pages)

2015-09-09 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/237250 Change subject: Escape all shell arguments & sanitize filenames .. Escape all shell arguments & sanitize filenames Code for the

[MediaWiki-commits] [Gerrit] Escape all shell arguments & sanitize filenames - change (mediawiki...Git2Pages)

2015-09-09 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/237252 Change subject: Escape all shell arguments & sanitize filenames .. Escape all shell arguments & sanitize filenames Code for the

[MediaWiki-commits] [Gerrit] Fix some extension breaking regression - change (mediawiki...Git2Pages)

2015-09-09 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/237260 Change subject: Fix some extension breaking regression .. Fix some extension breaking regression An earlier changeset by me

[MediaWiki-commits] [Gerrit] chmod 644 for php and json files - change (mediawiki...Gadgets)

2015-09-08 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/236817 Change subject: chmod 644 for php and json files .. chmod 644 for php and json files Bug: T111743 Change-Id:

[MediaWiki-commits] [Gerrit] chmod 644 WebVideoTranscodeJob.php - change (mediawiki...TimedMediaHandler)

2015-09-08 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/236809 Change subject: chmod 644 WebVideoTranscodeJob.php .. chmod 644 WebVideoTranscodeJob.php This was fixed in

[MediaWiki-commits] [Gerrit] chmod 644 for php files - change (mediawiki...Echo)

2015-09-08 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/236820 Change subject: chmod 644 for php files .. chmod 644 for php files Bug: T111740 Change-Id: I244b2e08e413602da305b4995189f5755ec6eee2

[MediaWiki-commits] [Gerrit] chmod 644 for php files - change (mediawiki...Flow)

2015-09-08 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/236818 Change subject: chmod 644 for php files .. chmod 644 for php files Bug: T111742 Change-Id: I304ba35ca0e26bf79ccad6fbeb9ff0c25adb5771

[MediaWiki-commits] [Gerrit] Enable autocompletion for Special:ListUsers - change (mediawiki/core)

2015-09-08 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/236839 Change subject: Enable autocompletion for Special:ListUsers .. Enable autocompletion for Special:ListUsers The "display users starting

[MediaWiki-commits] [Gerrit] Enable autocompletion for Special:ComparePages - change (mediawiki/core)

2015-08-27 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/234306 Change subject: Enable autocompletion for Special:ComparePages .. Enable autocompletion for Special:ComparePages Bug: T26235 Change-Id:

[MediaWiki-commits] [Gerrit] Fix file permissions - change (oojs/ui)

2015-08-25 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/233721 Change subject: Fix file permissions .. Fix file permissions .gif and .svg files are non-executable files - so they should have chmod

[MediaWiki-commits] [Gerrit] Fix minor spelling mistake - change (operations/puppet)

2015-08-22 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/233118 Change subject: Fix minor spelling mistake .. Fix minor spelling mistake Change-Id: I1cb4a8836a6eeca3f6b6d064e077e56fd59d88bc --- M

[MediaWiki-commits] [Gerrit] web: require_once instead of include - change (labs...WMT)

2015-08-07 Thread Southparkfan (Code Review)
Southparkfan has submitted this change and it was merged. Change subject: web: require_once instead of include .. web: require_once instead of include Change-Id: Iac41853d091a6b3c271b2ab02ecd61ddec47b7a9 --- M web/index.php 1

[MediaWiki-commits] [Gerrit] web: require_once instead of include - change (labs...WMT)

2015-08-04 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/229142 Change subject: web: require_once instead of include .. web: require_once instead of include Change-Id:

[MediaWiki-commits] [Gerrit] Revert Add executable rights for executable (bash) files - change (mediawiki/core)

2015-08-03 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/228834 Change subject: Revert Add executable rights for executable (bash) files .. Revert Add executable rights for executable (bash) files

[MediaWiki-commits] [Gerrit] Apache (wikitech): use /w/404.php as 404 errorpage - change (operations/puppet)

2015-07-08 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/223694 Change subject: Apache (wikitech): use /w/404.php as 404 errorpage .. Apache (wikitech): use /w/404.php as 404 errorpage Bug: T102147

[MediaWiki-commits] [Gerrit] Minor improvements for web pages - change (labs...WMT)

2015-04-08 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/202773 Change subject: Minor improvements for web pages .. Minor improvements for web pages Change-Id:

[MediaWiki-commits] [Gerrit] Minor improvements for web pages - change (labs...WMT)

2015-04-08 Thread Southparkfan (Code Review)
Southparkfan has submitted this change and it was merged. Change subject: Minor improvements for web pages .. Minor improvements for web pages Change-Id: Ia246ae0cea035b5f3ab65d668ef8d33f45e478d2 --- M web/index.php M

[MediaWiki-commits] [Gerrit] Direct labsconsole.wm.o through Apache cluster - change (operations/puppet)

2015-04-08 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/202788 Change subject: Direct labsconsole.wm.o through Apache cluster .. Direct labsconsole.wm.o through Apache cluster Change-Id:

[MediaWiki-commits] [Gerrit] Direct labsconsole.wm.o through Apache cluster - change (operations/dns)

2015-04-08 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/202791 Change subject: Direct labsconsole.wm.o through Apache cluster .. Direct labsconsole.wm.o through Apache cluster Apache:

[MediaWiki-commits] [Gerrit] nginx: don't add duplicate slash - change (operations/puppet)

2015-04-06 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/202074 Change subject: nginx: don't add duplicate slash .. nginx: don't add duplicate slash Bug: T73152 Change-Id:

[MediaWiki-commits] [Gerrit] Use always metawiki.labsdb server - change (labs...WMT)

2015-03-26 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/199947 Change subject: Use always metawiki.labsdb server .. Use always metawiki.labsdb server Change-Id:

[MediaWiki-commits] [Gerrit] Replace absolute paths with relative paths - change (labs...WMT)

2015-03-24 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/199281 Change subject: Replace absolute paths with relative paths .. Replace absolute paths with relative paths Change-Id:

[MediaWiki-commits] [Gerrit] Use new double-hashed channel namespace - change (labs...WMT)

2015-03-24 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/199325 Change subject: Use new double-hashed channel namespace .. Use new double-hashed channel namespace Change-Id:

[MediaWiki-commits] [Gerrit] Use elseif instead of else if - change (operations/mediawiki-config)

2015-02-25 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/192894 Change subject: Use elseif instead of else if .. Use elseif instead of else if Change-Id: I728eb9048e3ddee7d63cccfae933eae53f9933c5 ---

[MediaWiki-commits] [Gerrit] Escape all shell arguments sanitize filenames - change (mediawiki...Git2Pages)

2015-02-23 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/192373 Change subject: Escape all shell arguments sanitize filenames .. Escape all shell arguments sanitize filenames Code for the filename

[MediaWiki-commits] [Gerrit] Fix PHP Syntax Error in SpecialFarmer.php - change (mediawiki...Farmer)

2015-01-28 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/187120 Change subject: Fix PHP Syntax Error in SpecialFarmer.php .. Fix PHP Syntax Error in SpecialFarmer.php Added a semicolon after the end

[MediaWiki-commits] [Gerrit] Use __DIR__ instead of dirname( __FILE__ ) in generateJsonI1... - change (mediawiki/core)

2014-11-13 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/173068 Change subject: Use __DIR__ instead of dirname( __FILE__ ) in generateJsonI18n.php .. Use __DIR__ instead of dirname( __FILE__ ) in

[MediaWiki-commits] [Gerrit] Use __DIR__ instead of dirname( __FILE__ ) - change (mediawiki...Nuke)

2014-11-08 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/172029 Change subject: Use __DIR__ instead of dirname( __FILE__ ) .. Use __DIR__ instead of dirname( __FILE__ ) Change-Id:

[MediaWiki-commits] [Gerrit] Add executable rights for executable (bash) files - change (mediawiki/core)

2014-10-30 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/170120 Change subject: Add executable rights for executable (bash) files .. Add executable rights for executable (bash) files I hope this is

[MediaWiki-commits] [Gerrit] Fix spelling mistake: s/databses/database - change (mediawiki/core)

2014-10-29 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/169747 Change subject: Fix spelling mistake: s/databses/database .. Fix spelling mistake: s/databses/database Change-Id:

[MediaWiki-commits] [Gerrit] Add address to IP (s/IP/IP address) - change (apps...wikipedia)

2014-10-28 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/169588 Change subject: Add address to IP (s/IP/IP address) .. Add address to IP (s/IP/IP address) Thanks to Siebrand for reporting this,

[MediaWiki-commits] [Gerrit] Fix file permissions - change (mediawiki...Wikibase)

2014-10-24 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/168568 Change subject: Fix file permissions .. Fix file permissions The Travis build files are now executable. Bug: 71928 Change-Id:

[MediaWiki-commits] [Gerrit] chmod 755 bash Perl files, chmod 644 .css file - change (mediawiki/core)

2014-10-24 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/168627 Change subject: chmod 755 bash Perl files, chmod 644 .css file .. chmod 755 bash Perl files, chmod 644 .css file Bug: 71972

[MediaWiki-commits] [Gerrit] Fix file permissions - change (mediawiki...Wikidata)

2014-10-23 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/168399 Change subject: Fix file permissions .. Fix file permissions Bug: 71928 Change-Id: I82e579cda3268592d172c1dfe9cffc7b99749a57 --- M

[MediaWiki-commits] [Gerrit] Clean up SQL files, made compatible for sqlite - change (mediawiki...BayesianFilter)

2014-10-09 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/165754 Change subject: Clean up SQL files, made compatible for sqlite .. Clean up SQL files, made compatible for sqlite Removed the mysqldump

[MediaWiki-commits] [Gerrit] Removed a comma at the end of a CREATE TABLE statement. - change (mediawiki...BayesianFilter)

2014-08-01 Thread Southparkfan (Code Review)
Southparkfan has uploaded a new change for review. https://gerrit.wikimedia.org/r/151065 Change subject: Removed a comma at the end of a CREATE TABLE statement. .. Removed a comma at the end of a CREATE TABLE statement. Bug: