from:"Zfilipin $Code Review$"

[MediaWiki-commits] [Gerrit] integration/config[master]: Revert "AdvancedSearch needs CirrusSearch"

2018-01-19 Thread Zfilipin (Code Review)

Hello Paladox, Pablo Grass (WMDE), Gabriel Birke, Hashar, Tonina Zhelyazkova, 
Addshore, Tobias Gritschacher, jenkins-bot, WMDE-Fisch, Andrew-WMDE,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/405326

to review the following change.


Change subject: Revert "AdvancedSearch needs CirrusSearch"
..

Revert "AdvancedSearch needs CirrusSearch"

This reverts commit f6bd829131deeffa1025f9aadc0f81fe904e936e.

Bug: T184608
Change-Id: I84845dae88ccb7458654961891a111b61e857949
---
M zuul/parameter_functions.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/26/405326/1

diff --git a/zuul/parameter_functions.py b/zuul/parameter_functions.py
index 9361263..9f4d823 100644
--- a/zuul/parameter_functions.py
+++ b/zuul/parameter_functions.py
@@ -140,7 +140,6 @@
 # One can add a skin by using: 'skin/X'
 '3D': ['MultimediaViewer'],
 'AbuseFilter': ['AntiSpoof'],
-'AdvancedSearch': ['CirrusSearch'],
 'ApiFeatureUsage': ['Elastica'],
 'Arrays': ['Loops', 'ParserFunctions', 'Variables'],
 'ArticlePlaceholder': ['Wikibase', 'Scribunto'],

-- 
To view, visit https://gerrit.wikimedia.org/r/405326
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I84845dae88ccb7458654961891a111b61e857949
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Andrew-WMDE 
Gerrit-Reviewer: Gabriel Birke 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Pablo Grass (WMDE) 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: Tonina Zhelyazkova 
Gerrit-Reviewer: WMDE-Fisch 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run qunit-selenium for AdvancedSearch

2018-01-19 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405321 )

Change subject: Run qunit-selenium for AdvancedSearch
..

Run qunit-selenium for AdvancedSearch

Remove the job from experimental pipeline and add it to test and 
gate-and-submit pipelines.

Bug: T184608
Change-Id: Ieb7c12a1393b34451b79cf938902c67c2b2dac52
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/21/405321/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 19a3779..b8c47f0 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -2830,9 +2830,8 @@
 template:
   - name: extension-qunit-generic
   - name: extension-unittests-generic
+  - name: mediawiki-core-qunit-selenium-jessie
   - name: mwgate-npm
-experimental:
-  - mediawiki-core-qunit-selenium-jessie
 
   - name: mediawiki/extensions/AdminLinks
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/405321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb7c12a1393b34451b79cf938902c67c2b2dac52
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: WIP AdvancedSearch needs CirrusSearch

2018-01-18 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404970 )

Change subject: WIP AdvancedSearch needs CirrusSearch
..

WIP AdvancedSearch needs CirrusSearch

Change-Id: Id875d14bfbbee5479861d52e8ea4c2eee0691530
---
M zuul/parameter_functions.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/70/404970/1

diff --git a/zuul/parameter_functions.py b/zuul/parameter_functions.py
index 9f4d823..9361263 100644
--- a/zuul/parameter_functions.py
+++ b/zuul/parameter_functions.py
@@ -140,6 +140,7 @@
 # One can add a skin by using: 'skin/X'
 '3D': ['MultimediaViewer'],
 'AbuseFilter': ['AntiSpoof'],
+'AdvancedSearch': ['CirrusSearch'],
 'ApiFeatureUsage': ['Elastica'],
 'Arrays': ['Loops', 'ParserFunctions', 'Variables'],
 'ArticlePlaceholder': ['Wikibase', 'Scribunto'],

-- 
To view, visit https://gerrit.wikimedia.org/r/404970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id875d14bfbbee5479861d52e8ea4c2eee0691530
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Page title is not used in Selenium tests

2018-01-17 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404657 )

Change subject: Page title is not used in Selenium tests
..

Page title is not used in Selenium tests

Bug: T182421
Change-Id: I0de9bf27f1227e7b29c5aaa28451823e80fa8ff1
---
M tests/selenium/pageobjects/page.js
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/57/404657/1

diff --git a/tests/selenium/pageobjects/page.js 
b/tests/selenium/pageobjects/page.js
index 864bdae..ed1f1bc 100644
--- a/tests/selenium/pageobjects/page.js
+++ b/tests/selenium/pageobjects/page.js
@@ -1,9 +1,6 @@
 // From http://webdriver.io/guide/testrunner/pageobjects.html
 'use strict';
 class Page {
-   constructor() {
-   this.title = 'My Page';
-   }
open( path ) {
browser.url( '/index.php?title=' + path );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/404657
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0de9bf27f1227e7b29c5aaa28451823e80fa8ff1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: When running Selenium tests, use `wd/hub`

2018-01-16 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404507 )

Change subject: When running Selenium tests, use `wd/hub`
..

When running Selenium tests, use `wd/hub`

It works both on Mac and Windows. I am assuming it works on Linux too.

Bug: T182421
Change-Id: I85a9e7dbd9a66418c85585969adb5ac1548f5ef6
---
M tests/selenium/README.md
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/07/404507/1

diff --git a/tests/selenium/README.md b/tests/selenium/README.md
index 6fad6fe..1628377 100644
--- a/tests/selenium/README.md
+++ b/tests/selenium/README.md
@@ -23,9 +23,7 @@
 
 To run only one file (for example page.js), you first need to spawn the 
chromedriver:
 
-chromedriver --url-base=/wd/hub --port=
-
-Note: On Windows you may need to use "--url-base=wd/hub"
+chromedriver --url-base=wd/hub --port=
 
 Then in another terminal:
 

-- 
To view, visit https://gerrit.wikimedia.org/r/404507
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I85a9e7dbd9a66418c85585969adb5ac1548f5ef6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ESLint parserOptions is reduntant when env is set to es6

2018-01-12 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403937 )

Change subject: ESLint parserOptions is reduntant when env is set to es6
..

ESLint parserOptions is reduntant when env is set to es6

Bug: T184724
Change-Id: If39d3efc6476a94aaeb5956f142d2b12bd9be9bb
---
M build/.eslintrc.json
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/37/403937/1

diff --git a/build/.eslintrc.json b/build/.eslintrc.json
index 8643c5c..b40a61d 100644
--- a/build/.eslintrc.json
+++ b/build/.eslintrc.json
@@ -3,8 +3,5 @@
"env": {
"es6": true,
"node": true
-   },
-   "parserOptions": {
-   "ecmaVersion": 6
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/403937
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If39d3efc6476a94aaeb5956f142d2b12bd9be9bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run qunit-selenium Jenkins job for ORES

2018-01-11 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403688 )

Change subject: Run qunit-selenium Jenkins job for ORES
..

Run qunit-selenium Jenkins job for ORES

Only in experimental pipeline for now.

Bug: T184451
Change-Id: I0b5fc781dadbb33d61739e017a47045383151b7b
---
M zuul/layout.yaml
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/88/403688/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index aaa8926..c4ec4ec 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -4127,6 +4127,8 @@
   - name: mwgate-npm
 postmerge:
   - mwext-phpunit-coverage-publish
+experimental:
+  - mediawiki-core-qunit-selenium-jessie
 
   - name: mediawiki/extensions/PageAssessments
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/403688
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b5fc781dadbb33d61739e017a47045383151b7b
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run qunit-selenium job for Echo

2018-01-11 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403646 )

Change subject: Run qunit-selenium job for Echo
..

Run qunit-selenium job for Echo

The job runs in test, gate-and-submit and gate-and-submit-swat pipelines. It is 
removed from experimental pipeline.

Bug: T171848
Change-Id: I143a91a3938db00e35866ab3446974a35af285d5
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/46/403646/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 2aa6957..75ff49d 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -3360,10 +3360,9 @@
   - name: extension-gate
   - name: extension-unittests-generic
   - name: extension-qunit-generic
+  - name: mediawiki-core-qunit-selenium-jessie
   - name: mwext-ruby-jessie
   - name: mwgate-npm
-experimental:
-  - mediawiki-core-qunit-selenium-jessie
 
   - name: mediawiki/extensions/EditAccount
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/403646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I143a91a3938db00e35866ab3446974a35af285d5
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: ESLint parserOptions is reduntand when es6 env is used

2018-01-11 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403640 )

Change subject: ESLint parserOptions is reduntand when es6 env is used
..

ESLint parserOptions is reduntand when es6 env is used

Bug: T171848
Change-Id: I27ad1fc514d7420f18601990beaf1411cd6d8687
---
M tests/selenium/.eslintrc.json
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/40/403640/1

diff --git a/tests/selenium/.eslintrc.json b/tests/selenium/.eslintrc.json
index d64ada9..b2d0bdd 100644
--- a/tests/selenium/.eslintrc.json
+++ b/tests/selenium/.eslintrc.json
@@ -5,9 +5,6 @@
"mocha": true,
"node": true
},
-   "parserOptions": {
-   "ecmaVersion": 6
-   },
"globals": {
"browser": false
}

-- 
To view, visit https://gerrit.wikimedia.org/r/403640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27ad1fc514d7420f18601990beaf1411cd6d8687
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Switch Wikipedias from $wgLogoHD to direct using of ...

2018-01-02 Thread Zfilipin (Code Review)

Hello Urbanecm, jenkins-bot, Zoranzoki21,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/401509

to review the following change.


Change subject: Revert "Switch Wikipedias from $wgLogoHD to direct using of a 
SVG"
..

Revert "Switch Wikipedias from $wgLogoHD to direct using of a SVG"

This reverts commit 7c899ca08268565648c06d19acc9e26d4154b527.

Change-Id: Idae03c80afcf026463643c0489d57b3665cb6bb6
---
D static/images/project-logos/abwiki.svg
D static/images/project-logos/acewiki.svg
D static/images/project-logos/adywiki.svg
D static/images/project-logos/afwiki.svg
D static/images/project-logos/akwiki.svg
D static/images/project-logos/alswiki.svg
D static/images/project-logos/amwiki.svg
D static/images/project-logos/angwiki.svg
D static/images/project-logos/anwiki.svg
D static/images/project-logos/arcwiki.svg
D static/images/project-logos/arwiki.svg
D static/images/project-logos/arzwiki.svg
D static/images/project-logos/astwiki.svg
D static/images/project-logos/aswiki.svg
D static/images/project-logos/atjwiki.svg
D static/images/project-logos/avwiki.svg
D static/images/project-logos/aywiki.svg
D static/images/project-logos/azbwiki.svg
D static/images/project-logos/azwiki.svg
D static/images/project-logos/barwiki.svg
D static/images/project-logos/bawiki.svg
D static/images/project-logos/bclwiki.svg
D static/images/project-logos/bewiki.svg
D static/images/project-logos/bgwiki.svg
D static/images/project-logos/bhwiki.svg
D static/images/project-logos/biwiki.svg
D static/images/project-logos/bjnwiki.svg
D static/images/project-logos/bmwiki.svg
D static/images/project-logos/bnwiki.svg
D static/images/project-logos/bowiki.svg
D static/images/project-logos/bpywiki.svg
D static/images/project-logos/brwiki.svg
D static/images/project-logos/bswiki.svg
D static/images/project-logos/bugwiki.svg
D static/images/project-logos/bxrwiki.svg
D static/images/project-logos/cawiki.svg
D static/images/project-logos/cdowiki.svg
D static/images/project-logos/cebwiki.svg
D static/images/project-logos/cewiki.svg
D static/images/project-logos/chrwiki.svg
D static/images/project-logos/chwiki.svg
D static/images/project-logos/chywiki.svg
D static/images/project-logos/ckbwiki.svg
D static/images/project-logos/cowiki.svg
D static/images/project-logos/crhwiki.svg
D static/images/project-logos/crwiki.svg
D static/images/project-logos/csbwiki.svg
D static/images/project-logos/cswiki.svg
D static/images/project-logos/cuwiki.svg
D static/images/project-logos/cvwiki.svg
D static/images/project-logos/cywiki.svg
D static/images/project-logos/dawiki.svg
D static/images/project-logos/dewiki.svg
D static/images/project-logos/dinwiki.svg
D static/images/project-logos/diqwiki.svg
D static/images/project-logos/dsbwiki.svg
D static/images/project-logos/dtywiki.svg
D static/images/project-logos/dvwiki.svg
D static/images/project-logos/dzwiki.svg
D static/images/project-logos/eewiki.svg
D static/images/project-logos/elwiki.svg
D static/images/project-logos/emlwiki.svg
D static/images/project-logos/enwiki.svg
D static/images/project-logos/eowiki.svg
D static/images/project-logos/eswiki.svg
D static/images/project-logos/etwiki.svg
D static/images/project-logos/euwiki.svg
D static/images/project-logos/extwiki.svg
D static/images/project-logos/fawiki.svg
D static/images/project-logos/ffwiki.svg
D static/images/project-logos/fiwiki.svg
D static/images/project-logos/fjwiki.svg
D static/images/project-logos/fowiki.svg
D static/images/project-logos/frpwiki.svg
D static/images/project-logos/frrwiki.svg
D static/images/project-logos/frwiki.svg
D static/images/project-logos/furwiki.svg
D static/images/project-logos/fywiki.svg
D static/images/project-logos/gagwiki.svg
D static/images/project-logos/ganwiki.svg
D static/images/project-logos/gawiki.svg
D static/images/project-logos/gdwiki.svg
D static/images/project-logos/glkwiki.svg
D static/images/project-logos/glwiki.svg
D static/images/project-logos/gnwiki.svg
D static/images/project-logos/gomwiki.svg
D static/images/project-logos/guwiki.svg
D static/images/project-logos/gvwiki.svg
D static/images/project-logos/hakwiki.svg
D static/images/project-logos/hawiki.svg
D static/images/project-logos/hawwiki.svg
D static/images/project-logos/hewiki.svg
D static/images/project-logos/hifwiki.svg
D static/images/project-logos/hiwiki.svg
D static/images/project-logos/hrwiki.svg
D static/images/project-logos/hsbwiki.svg
D static/images/project-logos/htwiki.svg
D static/images/project-logos/huwiki.svg
D static/images/project-logos/hywiki.svg
D static/images/project-logos/iawiki.svg
D static/images/project-logos/idwiki.svg
D static/images/project-logos/iewiki.svg
D static/images/project-logos/igwiki.svg
D static/images/project-logos/ikwiki.svg
D static/images/project-logos/ilowiki.svg
D static/images/project-logos/iowiki.svg
D static/images/project-logos/iswiki.svg
D static/images/project-logos/itwiki.svg
D

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP Run selenium-EXTENSION-jessie Jenkins job for CirrusSearch

2017-12-22 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399833 )

Change subject: WIP Run selenium-EXTENSION-jessie Jenkins job for CirrusSearch
..

WIP Run selenium-EXTENSION-jessie Jenkins job for CirrusSearch

Bug: T175179
Change-Id: I4f685213b64eb47a6ecc9dd3cfb1bd381a8f54ed
---
M Gruntfile.js
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/33/399833/1

diff --git a/Gruntfile.js b/Gruntfile.js
index d1ef72f..ffc48e6 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -23,6 +23,8 @@
 
if ( process.env.JENKINS_HOME ) {
WebdriverIOconfigFile = './tests/selenium/wdio.conf.jenkins.js';
+   } else if ( process.env.CIRRUSSEARCH ) {
+   WebdriverIOconfigFile = 
'./extensions/CirrusSearch/tests/integration/config/wdio.conf.js';
} else {
WebdriverIOconfigFile = './tests/selenium/wdio.conf.js';
}

-- 
To view, visit https://gerrit.wikimedia.org/r/399833
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f685213b64eb47a6ecc9dd3cfb1bd381a8f54ed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Clean up ESLint configuration

2017-12-22 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399823 )

Change subject: Clean up ESLint configuration
..

Clean up ESLint configuration

parserOptions is redundant sice env is already set to es6.

Bug: T164024
Change-Id: Iec58f229352446d95fef111b659d5e32b9bdb523
---
M tests/selenium/.eslintrc.json
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RelatedArticles 
refs/changes/23/399823/1

diff --git a/tests/selenium/.eslintrc.json b/tests/selenium/.eslintrc.json
index d64ada9..b2d0bdd 100644
--- a/tests/selenium/.eslintrc.json
+++ b/tests/selenium/.eslintrc.json
@@ -5,9 +5,6 @@
"mocha": true,
"node": true
},
-   "parserOptions": {
-   "ecmaVersion": 6
-   },
"globals": {
"browser": false
}

-- 
To view, visit https://gerrit.wikimedia.org/r/399823
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec58f229352446d95fef111b659d5e32b9bdb523
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Clean up ESLint configuration

2017-12-22 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399822 )

Change subject: Clean up ESLint configuration
..

Clean up ESLint configuration

parserOptions is redundant sice env is already set to es6.

Bug: T177262
Change-Id: If478a0aaeb7fef184be965645fbd2cb276b630c8
---
M tests/selenium/.eslintrc.json
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/22/399822/1

diff --git a/tests/selenium/.eslintrc.json b/tests/selenium/.eslintrc.json
index 360bc72..69df5e3 100644
--- a/tests/selenium/.eslintrc.json
+++ b/tests/selenium/.eslintrc.json
@@ -5,9 +5,6 @@
"mocha": true,
"node": true
},
-   "parserOptions": {
-   "ecmaVersion": 6
-   },
"globals": {
"browser": false
},

-- 
To view, visit https://gerrit.wikimedia.org/r/399822
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If478a0aaeb7fef184be965645fbd2cb276b630c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Update YARD Ruby gem

2017-12-22 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399803 )

Change subject: Update YARD Ruby gem
..

Update YARD Ruby gem

Bug: T183440
Change-Id: I0501ca8ca4a6b4053b01c1132e6377f37794f5c1
---
M Gemfile.lock
1 file changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/03/399803/1

diff --git a/Gemfile.lock b/Gemfile.lock
index f9b66af..94d49a2 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -177,7 +177,7 @@
   logging (~> 1.6, >= 1.6.1)
   rubyzip (~> 1.1)
   winrm (~> 1.3.0)
-yard (0.9.5)
+yard (0.9.12)
 
 PLATFORMS
   ruby
@@ -197,6 +197,3 @@
   safe_yaml (~> 1.0.4)
   vagrant!
   yard (~> 0.8, >= 0.8.7.6)
-
-BUNDLED WITH
-   1.10.6

-- 
To view, visit https://gerrit.wikimedia.org/r/399803
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0501ca8ca4a6b4053b01c1132e6377f37794f5c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove ESLint inline comments in WebdriverIO configuration f...

2017-12-21 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399656 )

Change subject: Remove ESLint inline comments in WebdriverIO configuration files
..

Remove ESLint inline comments in WebdriverIO configuration files

Bug: T175179
Change-Id: Ieafd7b5666faaccb73b8ef7daa7aef3ed4114662
---
M tests/selenium/wdio.conf.jenkins.js
M tests/selenium/wdio.conf.js
2 files changed, 2 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/56/399656/1

diff --git a/tests/selenium/wdio.conf.jenkins.js 
b/tests/selenium/wdio.conf.jenkins.js
index 59e1878..26881eb 100644
--- a/tests/selenium/wdio.conf.jenkins.js
+++ b/tests/selenium/wdio.conf.jenkins.js
@@ -1,5 +1,3 @@
-/* eslint no-undef: "error" */
-/* eslint-env node */
 'use strict';
 const merge = require( 'deepmerge' ),
password = 'testpass',
diff --git a/tests/selenium/wdio.conf.js b/tests/selenium/wdio.conf.js
index cf9da0c..5eba0e0 100644
--- a/tests/selenium/wdio.conf.js
+++ b/tests/selenium/wdio.conf.js
@@ -1,6 +1,3 @@
-/* eslint-env node */
-/* eslint no-undef: "error" */
-/* eslint-disable no-console, comma-dangle */
 'use strict';
 
 const password = 'vagrant',
@@ -51,7 +48,7 @@
relPath( './tests/selenium/specs/**/*.js' ),
relPath( './extensions/*/tests/selenium/specs/**/*.js' ),
relPath( 
'./extensions/VisualEditor/modules/ve-mw/tests/selenium/specs/**/*.js' ),
-   relPath( './skins/*/tests/selenium/specs/**/*.js' ),
+   relPath( './skins/*/tests/selenium/specs/**/*.js' )
],
// Patterns to exclude.
exclude: [
@@ -233,7 +230,7 @@
// save screenshot
browser.saveScreenshot( filePath );
console.log( '\n\tScreenshot location:', filePath, '\n' );
-   },
+   }
//
// Hook that gets executed after the suite has ended
// afterSuite: function (suite) {

-- 
To view, visit https://gerrit.wikimedia.org/r/399656
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieafd7b5666faaccb73b8ef7daa7aef3ed4114662
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Add ansicolor, timeout and timestamps to selenium-{name}-jessie

2017-12-20 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399431 )

Change subject: Add ansicolor, timeout and timestamps to selenium-{name}-jessie
..

Add ansicolor, timeout and timestamps to selenium-{name}-jessie

ansicolor, timeout and timestamps wrappers are really useful. They are used in 
selenium-{name} template, and there is no reason not to use them in 
selenium-{name}-jessie template.

Bug: T175179
Change-Id: I897f9ff9b5e4a150e29adfaf70aaacfcc1c2257e
---
M jjb/mediawiki-extensions.yaml
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/31/399431/1

diff --git a/jjb/mediawiki-extensions.yaml b/jjb/mediawiki-extensions.yaml
index 7f3d34c..9f0e497 100644
--- a/jjb/mediawiki-extensions.yaml
+++ b/jjb/mediawiki-extensions.yaml
@@ -421,6 +421,10 @@
  name: ZUUL_BRANCH
  default: master
 wrappers:
+  - ansicolor
+  - timeout:
+  timeout: 180
+  - timestamps
   # Wiki usernames and passwords are hold in Jenkins credentials store
   # 
https://integration.wikimedia.org/ci/credentials/store/system/domain/selenium/
   - credentials-binding:

-- 
To view, visit https://gerrit.wikimedia.org/r/399431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I897f9ff9b5e4a150e29adfaf70aaacfcc1c2257e
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Do not run selenium-Echo Jenkins job daily

2017-12-19 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399209 )

Change subject: Do not run selenium-Echo Jenkins job daily
..

Do not run selenium-Echo Jenkins job daily

Tests are deleted.

Bug: T171848
Change-Id: I0f0e60604e6b7a72f9a8d2d8ef6b3ca5c9bc1086
---
M jjb/selenium.yaml
1 file changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/09/399209/1

diff --git a/jjb/selenium.yaml b/jjb/selenium.yaml
index c0e4d91..2b2584d 100644
--- a/jjb/selenium.yaml
+++ b/jjb/selenium.yaml
@@ -18,14 +18,6 @@
  - 'selenium-{name}'
 
 - project:
-name: Echo
-recipients: qa-ale...@lists.wikimedia.org sbis...@wikimedia.org # @SBisson
-repository: mediawiki/extensions/Echo
-
-jobs:
- - 'selenium-{name}'
-
-- project:
 name: GettingStarted
 recipients: mflasc...@wikimedia.org qa-ale...@lists.wikimedia.org 
samsm...@wikimedia.org # @Mattflaschen-WMF @phuedx
 repository: mediawiki/extensions/GettingStarted

-- 
To view, visit https://gerrit.wikimedia.org/r/399209
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f0e60604e6b7a72f9a8d2d8ef6b3ca5c9bc1086
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Do not run Ruby Jenkins jobs for PageTriage

2017-12-19 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399201 )

Change subject: Do not run Ruby Jenkins jobs for PageTriage
..

Do not run Ruby Jenkins jobs for PageTriage

All Ruby code has been removed from the extension.

Bug: T174593
Change-Id: Ia448829f1c8a1e1d5dfde7148b7599640e1ac9c2
---
M jjb/selenium.yaml
M zuul/layout.yaml
2 files changed, 0 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/01/399201/1

diff --git a/jjb/selenium.yaml b/jjb/selenium.yaml
index d3fdcf8..c0e4d91 100644
--- a/jjb/selenium.yaml
+++ b/jjb/selenium.yaml
@@ -85,11 +85,3 @@
 
 jobs:
  - 'selenium-{name}-chrome'
-
-- project:
-name: WikiLove
-recipients: qa-ale...@lists.wikimedia.org sbis...@wikimedia.org # @SBisson
-repository: mediawiki/extensions/WikiLove
-
-jobs:
- - 'selenium-{name}'
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 828e546..43513d4 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -7220,12 +7220,9 @@
   - name: mediawiki/extensions/WikiLove
 template:
   - name: extension-unittests-generic
-  - name: mwgate-rake
   - name: mwgate-npm
 experimental:
   - mediawiki-core-qunit-selenium-jessie
-  - mwext-mw-selenium-jessie
-  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/wikihiero
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/399201
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia448829f1c8a1e1d5dfde7148b7599640e1ac9c2
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Do not run Ruby Jenkins jobs for PageTriage

2017-12-19 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399196 )

Change subject: Do not run Ruby Jenkins jobs for PageTriage
..

Do not run Ruby Jenkins jobs for PageTriage

All Ruby code has been removed from the extension.

Bug: T174589
Change-Id: Ie1280b28f899a9ea40661d30a3ff00a98d0c6e17
---
M jjb/selenium.yaml
M zuul/layout.yaml
2 files changed, 0 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/96/399196/1

diff --git a/jjb/selenium.yaml b/jjb/selenium.yaml
index 2e3f6b2..78cf423 100644
--- a/jjb/selenium.yaml
+++ b/jjb/selenium.yaml
@@ -70,14 +70,6 @@
  - 'selenium-{name}'
 
 - project:
-name: PageTriage
-recipients: qa-ale...@lists.wikimedia.org sbis...@wikimedia.org # @SBisson
-repository: mediawiki/extensions/PageTriage
-
-jobs:
- - 'selenium-{name}'
-
-- project:
 name: QuickSurveys
 recipients: jrob...@wikimedia.org qa-ale...@lists.wikimedia.org # 
@jdlrobson
 repository: mediawiki/extensions/QuickSurveys
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index ef8ce06..9d0aa84 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -4117,12 +4117,9 @@
   - name: mediawiki/extensions/PageTriage
 template:
   - name: extension-unittests-generic
-  - name: mwgate-rake
   - name: mwgate-npm
 experimental:
   - mediawiki-core-qunit-selenium-jessie
-  - mwext-mw-selenium-jessie
-  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/ParentPage
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/399196
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1280b28f899a9ea40661d30a3ff00a98d0c6e17
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Do not run Ruby Jenkins jobs for CirrusSearch

2017-12-19 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399184 )

Change subject: Do not run Ruby Jenkins jobs for CirrusSearch
..

Do not run Ruby Jenkins jobs for CirrusSearch

All Ruby code has been removed from the extension.

Bug: T174103
Change-Id: Ic73f5da8181340407fa1d702919d13ec756a4ea3
---
M jjb/selenium.yaml
M zuul/layout.yaml
2 files changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/84/399184/1

diff --git a/jjb/selenium.yaml b/jjb/selenium.yaml
index 0dba34d..2e3f6b2 100644
--- a/jjb/selenium.yaml
+++ b/jjb/selenium.yaml
@@ -18,14 +18,6 @@
  - 'selenium-{name}'
 
 - project:
-name: CirrusSearch
-recipients: dcau...@wikimedia.org qa-ale...@lists.wikimedia.org # @dcausse
-repository: mediawiki/extensions/CirrusSearch
-
-jobs:
- - 'selenium-{name}'
-
-- project:
 name: Echo
 recipients: qa-ale...@lists.wikimedia.org sbis...@wikimedia.org # @SBisson
 repository: mediawiki/extensions/Echo
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 92d5952..b89643d 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -3020,14 +3020,12 @@
   - name: mediawiki/extensions/CirrusSearch
 template:
   - name: extension-gate
-  - name: mwgate-rake
   - name: mwgate-npm
   - name: extension-phan-generic
 test:
   - mwext-CirrusSearch-whitespaces
 experimental:
   - mediawiki-core-qunit-selenium-jessie
-  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/CleanChanges
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/399184
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic73f5da8181340407fa1d702919d13ec756a4ea3
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Fix location of LocalSettings.php

2017-12-19 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399170 )

Change subject: Fix location of LocalSettings.php
..

Fix location of LocalSettings.php

It used to be in tests/browser, now it's in tests/selenium.

Bug: T164024
Change-Id: Ie05744fa18c983458f7f50a42d2f120e84b99c54
---
M tests/selenium/README.md
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RelatedArticles 
refs/changes/70/399170/1

diff --git a/tests/selenium/README.md b/tests/selenium/README.md
index a874c89..37a9e74 100644
--- a/tests/selenium/README.md
+++ b/tests/selenium/README.md
@@ -13,7 +13,7 @@
 
 From mediawiki/core folder:
 
-echo 'include_once 
"$IP/extensions/RelatedArticles/tests/browser/LocalSettings.php";' >> 
LocalSettings.php
+echo 'include_once 
"$IP/extensions/RelatedArticles/tests/selenium/LocalSettings.php";' >> 
LocalSettings.php
 
 Run both mediawiki/core and RelatedArticles tests from mediawiki/core folder:
 

-- 
To view, visit https://gerrit.wikimedia.org/r/399170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie05744fa18c983458f7f50a42d2f120e84b99c54
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Fix location of LocalSettings.php

2017-12-19 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399168 )

Change subject: Fix location of LocalSettings.php
..

Fix location of LocalSettings.php

It used to be in tests/browser, now it's in tests/selenium.

Bug: T177262
Change-Id: I102c77834f4c63da06fcc6140a28de9dba231ae6
---
M tests/selenium/README.md
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/68/399168/1

diff --git a/tests/selenium/README.md b/tests/selenium/README.md
index b32bb89..76a7175 100644
--- a/tests/selenium/README.md
+++ b/tests/selenium/README.md
@@ -13,7 +13,7 @@
 
 From mediawiki/core folder:
 
-echo 'include_once 
"$IP/extensions/Popups/tests/browser/LocalSettings.php";' >> LocalSettings.php
+echo 'include_once 
"$IP/extensions/Popups/tests/selenium/LocalSettings.php";' >> LocalSettings.php
 
 Run both mediawiki/core and Popups tests from mediawiki/core folder:
 

-- 
To view, visit https://gerrit.wikimedia.org/r/399168
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I102c77834f4c63da06fcc6140a28de9dba231ae6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: WIP Create selenium-CirrusSearch-jessie Jenkins job

2017-12-13 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398030 )

Change subject: WIP Create selenium-CirrusSearch-jessie Jenkins job
..

WIP Create selenium-CirrusSearch-jessie Jenkins job

Bug: T175179
Change-Id: I6caf75f095e82a5046c59d5b7f9f20e5c4b97733
---
M jjb/mediawiki-extensions.yaml
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/30/398030/1

diff --git a/jjb/mediawiki-extensions.yaml b/jjb/mediawiki-extensions.yaml
index 7f3d34c..dcfb06c 100644
--- a/jjb/mediawiki-extensions.yaml
+++ b/jjb/mediawiki-extensions.yaml
@@ -449,6 +449,14 @@
 allow-empty-results: true
 
 - project:
+name: CirrusSearch
+repository: mediawiki/extensions/CirrusSearch
+
+jobs:
+ - 'selenium-{name}-jessie'
+
+
+- project:
 name: RelatedArticles
 repository: mediawiki/extensions/RelatedArticles
 

-- 
To view, visit https://gerrit.wikimedia.org/r/398030
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6caf75f095e82a5046c59d5b7f9f20e5c4b97733
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Ignore Gemfile.lock

2017-12-12 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397832 )

Change subject: Ignore Gemfile.lock
..

Ignore Gemfile.lock

Both Gemfile and Gemfile.lock are needed to install Ruby dependencies using 
Bundler. Since Gemfile is already ignored, Gemfile.lock should also be ingnored.

Bug: T182401
Change-Id: I7885f65aab0f0f5e00dde47619d34fbf444e7254
---
M make-release/make-release.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release 
refs/changes/32/397832/1

diff --git a/make-release/make-release.yaml b/make-release/make-release.yaml
index c11c240..3bccaef 100644
--- a/make-release/make-release.yaml
+++ b/make-release/make-release.yaml
@@ -34,6 +34,7 @@
 - package.json
 - messages
 - Gemfile
+- Gemfile.lock
 - ".mailmap"
 - "*.png"
 - "*.jpg"

-- 
To view, visit https://gerrit.wikimedia.org/r/397832
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7885f65aab0f0f5e00dde47619d34fbf444e7254
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run mwgate-rake-jessie job for MinervaNeue

2017-12-08 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396315 )

Change subject: Run mwgate-rake-jessie job for MinervaNeue
..

Run mwgate-rake-jessie job for MinervaNeue

MinervaNeue has Ruby code but RuboCop never runs since the job is not set up 
for the repository.

Bug: T180878
Change-Id: I97f4bc452e20138cf0fa4e58fcedde57f878ab48
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/15/396315/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 399ee27..f487f90 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -1982,6 +1982,7 @@
 template:
  - name: mwgate-composer
  - name: mwgate-npm
+ - name: mwgate-rake
  - name: skin-tests
  - name: skin-selenium
  - name: mediawiki-core-qunit-selenium-jessie

-- 
To view, visit https://gerrit.wikimedia.org/r/396315
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I97f4bc452e20138cf0fa4e58fcedde57f878ab48
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...WikiEduDashboard[master]: WIP Update RuboCop Ruby gem

2017-12-07 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396056 )

Change subject: WIP Update RuboCop Ruby gem
..

WIP Update RuboCop Ruby gem

Bug: T180878
Change-Id: Ib3cb6d2407f4d7e74df76b7e24e5d2e00626fffb
---
M Gemfile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/wikimedia/education/WikiEduDashboard 
refs/changes/56/396056/1

diff --git a/Gemfile b/Gemfile
index 96b29e8..527faf8 100644
--- a/Gemfile
+++ b/Gemfile
@@ -35,7 +35,7 @@
   gem 'factory_girl_rails'
   gem 'faker'
   gem 'rspec-rails'
-  gem 'rubocop'
+  gem 'rubocop', '~> 0.51.0', require: false
   gem 'zeus'
   gem 'sqlite3'
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/396056
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3cb6d2407f4d7e74df76b7e24e5d2e00626fffb
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/education/WikiEduDashboard
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update RuboCop Ruby gem in oojs-ui

2017-12-07 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396047 )

Change subject: Update RuboCop Ruby gem in oojs-ui
..

Update RuboCop Ruby gem in oojs-ui

Bug: T180878
Change-Id: I94442259f688c2fb730740396c33ecce1a8d3893
---
M oojs/oojs-ui/Gemfile
M oojs/oojs-ui/Gemfile.lock
2 files changed, 16 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/47/396047/1

diff --git a/oojs/oojs-ui/Gemfile b/oojs/oojs-ui/Gemfile
index f601a7c..4c0663a 100644
--- a/oojs/oojs-ui/Gemfile
+++ b/oojs/oojs-ui/Gemfile
@@ -1,3 +1,3 @@
 source "https://rubygems.org;
 
-gem "rubocop", require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/oojs/oojs-ui/Gemfile.lock b/oojs/oojs-ui/Gemfile.lock
index edc16d5..0175105 100644
--- a/oojs/oojs-ui/Gemfile.lock
+++ b/oojs/oojs-ui/Gemfile.lock
@@ -1,25 +1,29 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.2.0)
-parser (2.3.0.6)
-  ast (~> 2.2)
+ast (2.3.0)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.1.0)
-rubocop (0.38.0)
-  parser (>= 2.3.0.6, < 3.0)
+rainbow (2.2.2)
+  rake
+rake (12.3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
+  rainbow (>= 2.2.2, < 3.0)
   ruby-progressbar (~> 1.7)
   unicode-display_width (~> 1.0, >= 1.0.1)
-ruby-progressbar (1.7.5)
-unicode-display_width (1.0.2)
+ruby-progressbar (1.9.0)
+unicode-display_width (1.3.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  rubocop
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
-   1.11.2
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/396047
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94442259f688c2fb730740396c33ecce1a8d3893
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vendor
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: WIP Upgrade Rubyzip Ruby gem

2017-12-07 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396033 )

Change subject: WIP Upgrade Rubyzip Ruby gem
..

WIP Upgrade Rubyzip Ruby gem

$ bundle update rubyzip
Fetching gem metadata from https://rubygems.org/.
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "rubyzip":
  In Gemfile:
rubyzip (>= 1.2.1, ~> 1.2)

fastlane (~> 1.3.1) was resolved to 1.3.1, which depends on
  deliver (>= 0.11.0) was resolved to 0.12.0, which depends on
rubyzip (~> 1.1.6)

Bug: T180878
Change-Id: Ie2928f3d6ae2286770963599395648081dfd66f9
---
M Gemfile
M Gemfile.lock
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/33/396033/1

diff --git a/Gemfile b/Gemfile
index b5ff0b2..dba5902 100644
--- a/Gemfile
+++ b/Gemfile
@@ -3,3 +3,4 @@
 gem 'cocoapods', '~> 0.36.1'
 gem 'fastlane', '~> 1.3.1'
 gem 'git', '~> 1.2'
+gem 'rubyzip', '~> 1.2', '>= 1.2.1'
diff --git a/Gemfile.lock b/Gemfile.lock
index e5480e0..60b4f56 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -216,3 +216,6 @@
   cocoapods (~> 0.36.1)
   fastlane (~> 1.3.1)
   git (~> 1.2)
+
+BUNDLED WITH
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/396033
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2928f3d6ae2286770963599395648081dfd66f9
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Add category collation for sewiki"

2017-12-05 Thread Zfilipin (Code Review)

Hello Urbanecm, Jon Harald Søby, jenkins-bot, Zoranzoki21,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/395540

to review the following change.


Change subject: Revert "Add category collation for sewiki"
..

Revert "Add category collation for sewiki"

This reverts commit 715886c11140222b063e4a0a3969435236f86e14.

Change-Id: I9b15efc99cd358439db14292cf25fa1715173c7b
---
M wmf-config/InitialiseSettings.php
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/40/395540/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 60b0903..a6b1634 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15257,7 +15257,6 @@
'ruwikiversity' => 'uca-ru', // T54997
'ruwikivoyage' => 'uca-ru', // T54997
'ruwiktionary' => 'uca-ru', // T54997
-   'sewiki' => 'uca-se-u-kn', // T181503
'shwiki' => 'uca-hr-u-kn', // T69287, T149002
'srwiki' => 'uca-sr-u-kn', // T115806, T149002
'srwikibooks' => 'uca-sr', // T115806

-- 
To view, visit https://gerrit.wikimedia.org/r/395540
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b15efc99cd358439db14292cf25fa1715173c7b
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 
Gerrit-Reviewer: Jon Harald Søby 
Gerrit-Reviewer: Urbanecm 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395524 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: If5cff4da8e10271089a3766abb478cccb1b4b2d1
---
M .rubocop_todo.yml
M Gemfile
M Gemfile.lock
3 files changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/24/395524/1

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 4e1ebb2..3445b29 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-11-28 12:11:12 -0800 using RuboCop version 0.51.0.
+# on 2017-12-05 13:57:26 +0100 using RuboCop version 0.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -41,12 +41,14 @@
   Exclude:
 - '.jsduck/CustomTags.rb'
 
-# Offense count: 4
+# Offense count: 6
 # Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles, UseHashRocketsWithSymbolValues, 
PreferHashRocketsForNonAlnumEndingSymbols.
+# Configuration parameters: EnforcedStyle, SupportedStyles, 
UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
 # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
 Style/HashSyntax:
-  EnforcedStyle: hash_rockets
+  Exclude:
+- '.jsduck/CustomTags.rb'
+- 'Rakefile'
 
 # Offense count: 4
 # Cop supports --auto-correct.
diff --git a/Gemfile b/Gemfile
index 449daca..916bec0 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,3 +1,3 @@
 source 'https://rubygems.org'
 
-gem 'rubocop', :require => false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 3e7127c..0175105 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -23,7 +23,7 @@
   ruby
 
 DEPENDENCIES
-  rubocop
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395524
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5cff4da8e10271089a3766abb478cccb1b4b2d1
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395523 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: Ic69b9c079a7ecbdb8cdcae26799bbe6dd8388f49
---
M .rubocop.yml
A .rubocop_todo.yml
M Gemfile
M Gemfile.lock
4 files changed, 83 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/23/395523/1

diff --git a/.rubocop.yml b/.rubocop.yml
index 2befb1d..7360287 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
 AllCops:
   Include:
 - 'bin/*.rb'
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
new file mode 100644
index 000..a452529
--- /dev/null
+++ b/.rubocop_todo.yml
@@ -0,0 +1,67 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-12-05 13:52:49 +0100 using RuboCop version 0.51.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+- 'bin/testsuitegenerator.rb'
+
+# Offense count: 1
+Lint/EmptyWhen:
+  Exclude:
+- 'bin/docparser.rb'
+
+# Offense count: 4
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 188
+
+# Offense count: 2
+# Configuration parameters: ExpectMatchingDefinition, Regex, 
IgnoreExecutableScripts, AllowedAcronyms.
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, 
HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, 
TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Naming/FileName:
+  Exclude:
+- 'Gemfile'
+- 'Rakefile'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: InverseMethods, InverseBlocks.
+Style/InverseMethods:
+  Exclude:
+- 'bin/dependencytree.rb'
+- 'bin/doccomparer.rb'
+
+# Offense count: 2
+Style/MultipleComparison:
+  Exclude:
+- 'bin/docparser.rb'
+
+# Offense count: 11
+# Cop supports --auto-correct.
+Style/StderrPuts:
+  Exclude:
+- 'bin/doccomparer.rb'
+- 'bin/docparser.rb'
+- 'bin/testsuitegenerator.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, 
ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+- 'Gemfile'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: all_comparison_operators, equality_operators_only
+Style/YodaCondition:
+  Exclude:
+- 'bin/docparser.rb'
diff --git a/Gemfile b/Gemfile
index d4f581b..7e5d6b5 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,4 +1,4 @@
 source "https://rubygems.org;
 
-gem "rubocop", require: false
 gem "rake", require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index cb7dd80..7613e50 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,27 +1,30 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.2.0)
-parser (2.3.0.6)
-  ast (~> 2.2)
+ast (2.3.0)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.1.0)
+rainbow (2.2.2)
+  rake
 rake (12.3.0)
-rubocop (0.38.0)
-  parser (>= 2.3.0.6, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
+  rainbow (>= 2.2.2, < 3.0)
   ruby-progressbar (~> 1.7)
   unicode-display_width (~> 1.0, >= 1.0.1)
-ruby-progressbar (1.7.5)
-unicode-display_width (1.0.2)
+ruby-progressbar (1.9.0)
+unicode-display_width (1.3.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   rake
-  rubocop
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395523
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic69b9c079a7ecbdb8cdcae26799bbe6dd8388f49
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: WIP Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395522 )

Change subject: WIP Update RuboCop Ruby gem
..

WIP Update RuboCop Ruby gem

Bug: T180878
Change-Id: I05e1803ece1930df0f670d2a0031d325f2d1d1be
---
M Gemfile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/22/395522/1

diff --git a/Gemfile b/Gemfile
index 01f6cfc..686a04b 100644
--- a/Gemfile
+++ b/Gemfile
@@ -11,5 +11,5 @@
 gem 'rake', '~> 12.0.0'
 gem 'git', '1.3.0'
 gem 'puppet-lint', '2.0.2'
-gem 'rubocop', '~> 0.49.1', require: false
+gem 'rubocop', '~> 0.51.0', require: false
 gem 'puppet-lint-wmf_styleguide-check', '1.0.0'

-- 
To view, visit https://gerrit.wikimedia.org/r/395522
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05e1803ece1930df0f670d2a0031d325f2d1d1be
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: WIP Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395521 )

Change subject: WIP Update RuboCop Ruby gem
..

WIP Update RuboCop Ruby gem

Bug: T180878
Change-Id: Iffb06338da8ee58b835b19c66cc60e0053e842b0
---
M Gemfile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/21/395521/1

diff --git a/Gemfile b/Gemfile
index ac5462f..79ffe75 100644
--- a/Gemfile
+++ b/Gemfile
@@ -5,7 +5,7 @@
   # https://github.com/mitchellh/vagrant/issues/5546
   gem 'vagrant', git: 'https://github.com/mitchellh/vagrant.git', tag: 'v1.8.1'
 
-  gem 'rubocop', '~> 0.35.1', require: false
+  gem 'rubocop', '~> 0.51.0', require: false
   gem 'puppet', '~> 3.7.0'
   gem 'puppet-lint', '1.1.0'
   gem 'puppetlabs_spec_helper', '< 2.0.0', require: false

-- 
To view, visit https://gerrit.wikimedia.org/r/395521
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffb06338da8ee58b835b19c66cc60e0053e842b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: WIP Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395514 )

Change subject: WIP Update RuboCop Ruby gem
..

WIP Update RuboCop Ruby gem

Bug: T180878
Change-Id: I904e947d7044b259f29f584b568ab2cb689bd5a4
---
M Gemfile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/14/395514/1

diff --git a/Gemfile b/Gemfile
index 144b926..18753bc 100644
--- a/Gemfile
+++ b/Gemfile
@@ -4,4 +4,4 @@
 gem 'mediawiki_selenium', '~> 1.7', '>= 1.7.3'
 gem 'page-object', '1.1.0'
 gem 'rake', '~> 10.4', '>= 10.4.2'
-gem 'rubocop', '~> 0.29.1', require: false
+gem 'rubocop', '~> 0.51.0', require: false

-- 
To view, visit https://gerrit.wikimedia.org/r/395514
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I904e947d7044b259f29f584b568ab2cb689bd5a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/selenium[master]: Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395513 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: I470fdf4b24d42bac3852f3d8d03ea06d0e01462d
---
M .rubocop.yml
A .rubocop_todo.yml
M mediawiki_selenium.gemspec
3 files changed, 70 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium 
refs/changes/13/395513/1

diff --git a/.rubocop.yml b/.rubocop.yml
index 60ae00f..7d388db 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
 AllCops:
   DisplayCopNames: true
   StyleGuideCopsOnly: true
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
new file mode 100644
index 000..d8f4947
--- /dev/null
+++ b/.rubocop_todo.yml
@@ -0,0 +1,67 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-12-05 13:20:08 +0100 using RuboCop version 0.51.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterMagicComment:
+  Exclude:
+- 'mediawiki_selenium.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/EmptyLines:
+  Exclude:
+- 'lib/mediawiki_selenium/step_definitions/upload_file_steps.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Layout/EmptyLinesAroundBlockBody:
+  Exclude:
+- 'spec/environment_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: auto_detection, squiggly, active_support, powerpack, 
unindent
+Layout/IndentHeredoc:
+  Exclude:
+- 'lib/mediawiki_selenium/step_definitions/resource_loader_steps.rb'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: lowercase, uppercase
+Naming/HeredocDelimiterCase:
+  Exclude:
+- 'lib/mediawiki_selenium/step_definitions/resource_loader_steps.rb'
+- 'mediawiki_selenium.gemspec'
+
+# Offense count: 5
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+- 'lib/mediawiki_selenium/cucumber/sauce.rb'
+- 'spec/browser_factory/base_spec.rb'
+- 'spec/browser_factory/chrome_spec.rb'
+- 'spec/browser_factory/firefox_spec.rb'
+- 'spec/browser_factory/phantomjs_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/Encoding:
+  Exclude:
+- 'mediawiki_selenium.gemspec'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: MinSize, SupportedStyles.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets
diff --git a/mediawiki_selenium.gemspec b/mediawiki_selenium.gemspec
index bc46831..b3a3559 100644
--- a/mediawiki_selenium.gemspec
+++ b/mediawiki_selenium.gemspec
@@ -45,6 +45,6 @@
   spec.add_development_dependency 'bundler', '~> 1.6', '>= 1.6.3'
   spec.add_development_dependency 'yard', '~> 0.8', '>= 0.8.7.4'
   spec.add_development_dependency 'redcarpet', '~> 3.2', '>= 3.2.0'
-  spec.add_development_dependency 'rubocop', '~> 0.46.0'
+  spec.add_development_dependency 'rubocop', '~> 0.51.0'
   spec.add_development_dependency 'rspec-mocks', '~> 2.14', '>= 2.14.4'
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/395513
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I470fdf4b24d42bac3852f3d8d03ea06d0e01462d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...api[master]: Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395511 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: Ic1bc1d9628440411e0a8496a9da3e08482b580fc
---
M mediawiki_api.gemspec
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/ruby/api 
refs/changes/11/395511/1

diff --git a/mediawiki_api.gemspec b/mediawiki_api.gemspec
index cd378c8..f7d48ec 100644
--- a/mediawiki_api.gemspec
+++ b/mediawiki_api.gemspec
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'mediawiki_api/version'
@@ -32,7 +30,7 @@
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake', '~> 0'
   spec.add_development_dependency 'rspec', '~> 3.0', '>= 3.0.0'
-  spec.add_development_dependency 'rubocop', '~> 0.49.1'
+  spec.add_development_dependency 'rubocop', '~> 0.51.0'
   spec.add_development_dependency 'webmock', '~> 1.17', '>= 1.17.2'
   spec.add_development_dependency 'redcarpet'
   spec.add_development_dependency 'yard'

-- 
To view, visit https://gerrit.wikimedia.org/r/395511
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1bc1d9628440411e0a8496a9da3e08482b580fc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/ruby/api
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikiLove[master]: Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395509 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: I7e791d2d74f6ec731bde2a7f258ec64bc37dd0b4
---
M Gemfile
M Gemfile.lock
2 files changed, 17 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiLove 
refs/changes/09/395509/1

diff --git a/Gemfile b/Gemfile
index d9068b3..7ee5bc6 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,4 +2,4 @@
 
 gem 'mediawiki_selenium', '~> 1.8'
 gem 'rake', '~> 10.4', '>= 10.4.2'
-gem 'rubocop', '0.33.0', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 4e64097..48f308d 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
+ast (2.3.0)
 builder (3.2.3)
 childprocess (0.6.2)
   ffi (~> 1.0, >= 1.0.11)
@@ -65,10 +63,12 @@
   watir (~> 6.0)
 page_navigation (0.10)
   data_magic (>= 0.22)
-parser (2.2.2.6)
-  ast (>= 1.1, < 3.0)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.0.0)
+rainbow (2.2.2)
+  rake
 rake (10.4.2)
 rest-client (1.8.0)
   http-cookie (>= 1.0.2, < 2.0)
@@ -77,13 +77,14 @@
 rspec-core (2.99.2)
 rspec-expectations (2.99.2)
   diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.33.0)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.2.5, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
-  ruby-progressbar (~> 1.4)
-ruby-progressbar (1.7.5)
+  rainbow (>= 2.2.2, < 3.0)
+  ruby-progressbar (~> 1.7)
+  unicode-display_width (~> 1.0, >= 1.0.1)
+ruby-progressbar (1.9.0)
 rubyzip (1.2.1)
 selenium-webdriver (3.1.0)
   childprocess (~> 0.5)
@@ -94,6 +95,7 @@
 unf (0.1.4)
   unf_ext
 unf_ext (0.0.7.2)
+unicode-display_width (1.3.0)
 watir (6.2.0)
   selenium-webdriver (~> 3.0)
 websocket (1.2.4)
@@ -105,7 +107,7 @@
 DEPENDENCIES
   mediawiki_selenium (~> 1.8)
   rake (~> 10.4, >= 10.4.2)
-  rubocop (= 0.33.0)
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
-   1.14.5
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395509
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e791d2d74f6ec731bde2a7f258ec64bc37dd0b4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiLove
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: WIP Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395508 )

Change subject: WIP Update RuboCop Ruby gem
..

WIP Update RuboCop Ruby gem

Bug: T180878
Change-Id: I238b3a1892ceb0a51515e3744f8f87dcb58e01b5
---
M tests/browser/Gemfile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme 
refs/changes/08/395508/1

diff --git a/tests/browser/Gemfile b/tests/browser/Gemfile
index 2e901ff..099ddea 100644
--- a/tests/browser/Gemfile
+++ b/tests/browser/Gemfile
@@ -6,4 +6,4 @@
 gem 'parallel_tests', '~> 2.5'
 gem 'rake', '~> 11.1', '>= 11.1.2'
 gem 'require_all', '~> 1.3', '>= 1.3.3'
-gem 'rubocop', '~> 0.40.0', require: false
\ No newline at end of file
+gem 'rubocop', '~> 0.51.0', require: false

-- 
To view, visit https://gerrit.wikimedia.org/r/395508
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I238b3a1892ceb0a51515e3744f8f87dcb58e01b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395506 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: I093e232d7af1f22d9d7da5ef1f0201e842ac0d3d
---
M .rubocop_todo.yml
M tests/browser/Gemfile
M tests/browser/Gemfile.lock
3 files changed, 89 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/06/395506/1

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 2f8db48..7e5a3e3 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,26 +1,52 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2014-11-13 12:15:50 +0100 using RuboCop version 0.27.1.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-12-05 13:00:54 +0100 using RuboCop version 0.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 164
-# Configuration parameters: AllowURI, URISchemes.
+# Offense count: 48
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterMagicComment:
+  Enabled: false
+
+# Offense count: 241
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, 
IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
 Metrics/LineLength:
-  Max: 465
+  Max: 464
+
+# Offense count: 48
+# Cop supports --auto-correct.
+Style/Encoding:
+  Enabled: false
 
 # Offense count: 2
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
-  Enabled: false
+  Exclude:
+- 'tests/browser/features/support/modules/uls_module.rb'
+- 'tests/browser/features/support/pages/login_page.rb'
 
-# Offense count: 9
+# Offense count: 7
+# Cop supports --auto-correct.
 # Configuration parameters: MaxLineLength.
 Style/IfUnlessModifier:
-  Enabled: false
+  Exclude:
+- 'tests/browser/features/support/env.rb'
+- 'tests/browser/features/support/modules/alias_module.rb'
+- 'tests/browser/features/support/modules/entity_module.rb'
+- 'tests/browser/features/support/modules/reference_module.rb'
+- 'tests/browser/features/support/modules/sitelink_module.rb'
+- 'tests/browser/features/support/pages/login_page.rb'
 
-# Offense count: 1
-# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
-Style/Next:
-  Enabled: false
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+- 'spec/**/*'
+- 'tests/browser/features/step_definitions/aliases_steps.rb'
+- 'tests/browser/features/support/modules/entity_module.rb'
diff --git a/tests/browser/Gemfile b/tests/browser/Gemfile
index 37f232a..e8cf6eb 100644
--- a/tests/browser/Gemfile
+++ b/tests/browser/Gemfile
@@ -6,4 +6,4 @@
 gem 'parallel_tests', '~> 2.5'
 gem 'rake', '~> 11.1', '>= 11.1.2'
 gem 'require_all', '~> 1.3', '>= 1.3.3'
-gem 'rubocop', '~> 0.40.0', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/tests/browser/Gemfile.lock b/tests/browser/Gemfile.lock
index 3ac408b..6674c9b 100644
--- a/tests/browser/Gemfile.lock
+++ b/tests/browser/Gemfile.lock
@@ -1,43 +1,44 @@
 GEM
   remote: https://rubygems.org/
   specs:
-activesupport (4.2.6)
+activesupport (4.2.10)
   i18n (~> 0.7)
-  json (~> 1.7, >= 1.7.7)
   minitest (~> 5.1)
   thread_safe (~> 0.3, >= 0.3.4)
   tzinfo (~> 1.1)
-ast (2.2.0)
-builder (3.2.2)
-childprocess (0.5.9)
+ast (2.3.0)
+builder (3.2.3)
+childprocess (0.8.0)
   ffi (~> 1.0, >= 1.0.11)
+concurrent-ruby (1.0.5)
 cucumber (1.3.20)
   builder (>= 2.1.2)
   diff-lcs (>= 1.1.3)
   gherkin (~> 2.12)
   multi_json (>= 1.7.5, < 2.0)
   multi_test (>= 0.1.2)
-data_magic (0.22)
+data_magic (1.2)
   faker (>= 1.1.2)
   yml_reader (>= 0.6)
-diff-lcs (1.2.5)
-domain_name (0.5.20160310)
+diff-lcs (1.3)
+domain_name (0.5.20170404)
   unf (>= 0.0.5, < 1.0.0)
-faker (1.6.3)
+faker (1.8.4)
   i18n (~> 0.5)
-faraday (0.9.2)
+faraday (0.13.1)
   multipart-post (>= 1.2, < 3)
 faraday-cookie_jar (0.0.6)
   faraday (>= 0.7.4)
   http-cookie (~> 1.0.0)
-ffi (1.9.10)
+ffi (1.9.18)
 gherkin (2.12.2)
   multi_json (~> 1.3)
-headless (2.2.3)
-http-cookie (1.0.2)
+headless (2.3.1)
+http-cookie (1.0.3)
   domain_name (~> 0.5)
-i18n (0.7.0)
-json (1.8.3)
+i18n (0.9.1)
+  concurrent-ruby (~> 1.0)
+json (1.8.6)
 mediawiki_api (0.6.0)
   faraday (~> 0.9, >= 0.9.0)
   faraday-cookie_jar (~> 0.0, >= 0.0.6)
@@ -54,27 +55,30 @@
   rspec-expectations (~>

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395501 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: If4057044b9bf1cfdb7c04d6ebf309f9b44868f49
---
M Gemfile
M Gemfile.lock
2 files changed, 15 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TwoColConflict 
refs/changes/01/395501/1

diff --git a/Gemfile b/Gemfile
index 03879ba..87485eb 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,4 +2,4 @@
 
 gem 'mediawiki_selenium', '~> 1.8.0'
 gem 'require_all', '~> 1.3', '>= 1.3.3'
-gem 'rubocop', '~> 0.41.0', require: false
\ No newline at end of file
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index d1ab658..b0c6cc5 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -63,10 +63,13 @@
   watir (~> 6.0)
 page_navigation (0.10)
   data_magic (>= 0.22)
-parser (2.4.0.0)
-  ast (~> 2.2)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.2.1)
+rainbow (2.2.2)
+  rake
+rake (12.3.0)
 require_all (1.4.0)
 rest-client (1.8.0)
   http-cookie (>= 1.0.2, < 2.0)
@@ -75,13 +78,14 @@
 rspec-core (2.99.2)
 rspec-expectations (2.99.2)
   diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.41.2)
-  parser (>= 2.3.1.1, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
+  rainbow (>= 2.2.2, < 3.0)
   ruby-progressbar (~> 1.7)
   unicode-display_width (~> 1.0, >= 1.0.1)
-ruby-progressbar (1.8.1)
+ruby-progressbar (1.9.0)
 rubyzip (1.2.1)
 selenium-webdriver (3.1.0)
   childprocess (~> 0.5)
@@ -92,7 +96,7 @@
 unf (0.1.4)
   unf_ext
 unf_ext (0.0.7.2)
-unicode-display_width (1.1.3)
+unicode-display_width (1.3.0)
 watir (6.2.0)
   selenium-webdriver (~> 3.0)
 websocket (1.2.4)
@@ -104,7 +108,7 @@
 DEPENDENCIES
   mediawiki_selenium (~> 1.8.0)
   require_all (~> 1.3, >= 1.3.3)
-  rubocop (~> 0.41.0)
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
-   1.14.5
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If4057044b9bf1cfdb7c04d6ebf309f9b44868f49
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TwoColConflict
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395500 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: Iedc40fa530db5337512a14fd878e397af47cadb8
---
M Gemfile
M Gemfile.lock
2 files changed, 15 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider 
refs/changes/00/395500/1

diff --git a/Gemfile b/Gemfile
index 522e791..2859b87 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,4 +1,4 @@
 source 'https://rubygems.org'
 
 gem 'mediawiki_selenium', '~> 1.8.0'
-gem 'rubocop', '~> 0.41.0', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 0f16db9..0331c6f 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -63,10 +63,13 @@
   watir (~> 6.0)
 page_navigation (0.10)
   data_magic (>= 0.22)
-parser (2.4.0.0)
-  ast (~> 2.2)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.2.1)
+rainbow (2.2.2)
+  rake
+rake (12.3.0)
 rest-client (1.8.0)
   http-cookie (>= 1.0.2, < 2.0)
   mime-types (>= 1.16, < 3.0)
@@ -74,13 +77,14 @@
 rspec-core (2.99.2)
 rspec-expectations (2.99.2)
   diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.41.2)
-  parser (>= 2.3.1.1, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
+  rainbow (>= 2.2.2, < 3.0)
   ruby-progressbar (~> 1.7)
   unicode-display_width (~> 1.0, >= 1.0.1)
-ruby-progressbar (1.8.1)
+ruby-progressbar (1.9.0)
 rubyzip (1.2.1)
 selenium-webdriver (3.1.0)
   childprocess (~> 0.5)
@@ -91,7 +95,7 @@
 unf (0.1.4)
   unf_ext
 unf_ext (0.0.7.2)
-unicode-display_width (1.1.3)
+unicode-display_width (1.3.0)
 watir (6.2.0)
   selenium-webdriver (~> 3.0)
 websocket (1.2.4)
@@ -102,7 +106,7 @@
 
 DEPENDENCIES
   mediawiki_selenium (~> 1.8.0)
-  rubocop (~> 0.41.0)
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
-   1.14.5
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395500
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iedc40fa530db5337512a14fd878e397af47cadb8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[master]: Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395497 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: Ie87b10f4f2659bb85772d5dcd0e08f9d5e31c4ee
---
M .rubocop.yml
A .rubocop_todo.yml
M Gemfile
M Gemfile.lock
4 files changed, 32 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickSurveys 
refs/changes/97/395497/1

diff --git a/.rubocop.yml b/.rubocop.yml
index 84567a5..3c8a650 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
 AllCops:
   StyleGuideCopsOnly: true
 
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
new file mode 100644
index 000..9bc51b5
--- /dev/null
+++ b/.rubocop_todo.yml
@@ -0,0 +1,13 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-12-05 12:14:06 +0100 using RuboCop version 0.51.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Layout/EmptyLines:
+  Exclude:
+- 'tests/browser/features/support/step_definitions/common_steps.rb'
diff --git a/Gemfile b/Gemfile
index 35c7f03..7ee5bc6 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,4 +2,4 @@
 
 gem 'mediawiki_selenium', '~> 1.8'
 gem 'rake', '~> 10.4', '>= 10.4.2'
-gem 'rubocop', '~> 0.34.1', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 7809458..48f308d 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
+ast (2.3.0)
 builder (3.2.3)
 childprocess (0.6.2)
   ffi (~> 1.0, >= 1.0.11)
@@ -65,10 +63,12 @@
   watir (~> 6.0)
 page_navigation (0.10)
   data_magic (>= 0.22)
-parser (2.2.2.6)
-  ast (>= 1.1, < 3.0)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.0.0)
+rainbow (2.2.2)
+  rake
 rake (10.4.2)
 rest-client (1.8.0)
   http-cookie (>= 1.0.2, < 2.0)
@@ -77,13 +77,14 @@
 rspec-core (2.99.2)
 rspec-expectations (2.99.2)
   diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.34.1)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.2.5, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
-  ruby-progressbar (~> 1.4)
-ruby-progressbar (1.7.5)
+  rainbow (>= 2.2.2, < 3.0)
+  ruby-progressbar (~> 1.7)
+  unicode-display_width (~> 1.0, >= 1.0.1)
+ruby-progressbar (1.9.0)
 rubyzip (1.2.1)
 selenium-webdriver (3.1.0)
   childprocess (~> 0.5)
@@ -94,6 +95,7 @@
 unf (0.1.4)
   unf_ext
 unf_ext (0.0.7.2)
+unicode-display_width (1.3.0)
 watir (6.2.0)
   selenium-webdriver (~> 3.0)
 websocket (1.2.4)
@@ -105,7 +107,7 @@
 DEPENDENCIES
   mediawiki_selenium (~> 1.8)
   rake (~> 10.4, >= 10.4.2)
-  rubocop (~> 0.34.1)
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
-   1.14.5
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395497
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie87b10f4f2659bb85772d5dcd0e08f9d5e31c4ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuickSurveys
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PoolCounter[master]: Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395496 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Also updated parallel_tests.

Bug: T180878
Change-Id: Ic2600306231c0e0aed100388f5e6a68955288759
---
M .rubocop.yml
A .rubocop_todo.yml
M Gemfile
M Gemfile.lock
4 files changed, 65 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PoolCounter 
refs/changes/96/395496/1

diff --git a/.rubocop.yml b/.rubocop.yml
index 98ce794..dc9ef01 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
 Metrics/AbcSize:
   Enabled: false
 
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
new file mode 100644
index 000..d0fcc84
--- /dev/null
+++ b/.rubocop_todo.yml
@@ -0,0 +1,38 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-12-05 12:05:04 +0100 using RuboCop version 0.51.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/MultilineBlockLayout:
+  Exclude:
+- 'daemon/tests/features/step_definitions/sim_steps.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, 
SingleLineConditionsOnly, IncludeTernaryExpressions.
+# SupportedStyles: assign_to_condition, assign_inside_condition
+Style/ConditionalAssignment:
+  Exclude:
+- 'daemon/tests/features/support/search_sim.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+- 'spec/**/*'
+- 'daemon/tests/features/support/client.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+- 'daemon/tests/features/support/reader_sim.rb'
+- 'daemon/tests/features/support/search_sim.rb'
diff --git a/Gemfile b/Gemfile
index 7326655..22a9530 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,6 +1,6 @@
 source 'https://rubygems.org'
 
 gem 'cucumber'
-gem 'parallel_tests'
+gem 'parallel_tests', '~> 2.19'
 gem 'rspec-expectations'
-gem 'rubocop', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index ec57fe8..cd3440f 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.0.0)
-astrolabe (1.3.0)
-  parser (>= 2.2.0.pre.3, < 3.0)
+ast (2.3.0)
 builder (3.2.2)
 cucumber (1.3.17)
   builder (>= 2.1.2)
@@ -16,32 +14,37 @@
   multi_json (~> 1.3)
 multi_json (1.10.1)
 multi_test (0.1.1)
-parallel (1.3.3)
-parallel_tests (1.0.7)
+parallel (1.12.0)
+parallel_tests (2.19.0)
   parallel
-parser (2.2.0.pre.8)
-  ast (>= 1.1, < 3.0)
-  slop (~> 3.4, >= 3.4.5)
-powerpack (0.0.9)
-rainbow (2.0.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
+powerpack (0.1.1)
+rainbow (2.2.2)
+  rake
+rake (12.3.0)
 rspec-expectations (3.1.2)
   diff-lcs (>= 1.2.0, < 2.0)
   rspec-support (~> 3.1.0)
 rspec-support (3.1.2)
-rubocop (0.27.1)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.0.pre.7, < 3.0)
-  powerpack (~> 0.0.6)
-  rainbow (>= 1.99.1, < 3.0)
-  ruby-progressbar (~> 1.4)
-ruby-progressbar (1.7.0)
-slop (3.6.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
+  powerpack (~> 0.1)
+  rainbow (>= 2.2.2, < 3.0)
+  ruby-progressbar (~> 1.7)
+  unicode-display_width (~> 1.0, >= 1.0.1)
+ruby-progressbar (1.9.0)
+unicode-display_width (1.3.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   cucumber
-  parallel_tests
+  parallel_tests (~> 2.19)
   rspec-expectations
-  rubocop
+  rubocop (~> 0.51.0)
+
+BUNDLED WITH
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395496
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2600306231c0e0aed100388f5e6a68955288759
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PoolCounter
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: WIP Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395493 )

Change subject: WIP Update RuboCop Ruby gem
..

WIP Update RuboCop Ruby gem

Bug: T180878
Change-Id: If3d846ba41c5c5e23519c464adfcc2ba14a747e1
---
M Gemfile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/93/395493/1

diff --git a/Gemfile b/Gemfile
index 144b926..18753bc 100644
--- a/Gemfile
+++ b/Gemfile
@@ -4,4 +4,4 @@
 gem 'mediawiki_selenium', '~> 1.7', '>= 1.7.3'
 gem 'page-object', '1.1.0'
 gem 'rake', '~> 10.4', '>= 10.4.2'
-gem 'rubocop', '~> 0.29.1', require: false
+gem 'rubocop', '~> 0.51.0', require: false

-- 
To view, visit https://gerrit.wikimedia.org/r/395493
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If3d846ba41c5c5e23519c464adfcc2ba14a747e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: WIP Update RuboCop Ruby gem

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395491 )

Change subject: WIP Update RuboCop Ruby gem
..

WIP Update RuboCop Ruby gem

Bug: T180878
Change-Id: I809a836bc92ca062ed263bf0a251e23e8aac2db7
---
M Gemfile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ElectronPdfService 
refs/changes/91/395491/1

diff --git a/Gemfile b/Gemfile
index e40965a..904f670 100644
--- a/Gemfile
+++ b/Gemfile
@@ -4,4 +4,4 @@
 gem 'jsduck', '~> 5.3.4'
 gem 'mediawiki_selenium', '~> 1.7.0'
 gem 'rake', '~> 10.4', '>= 10.4.2'
-gem 'rubocop', '~> 0.41.0', require: false
\ No newline at end of file
+gem 'rubocop', '~> 0.51.0', require: false

-- 
To view, visit https://gerrit.wikimedia.org/r/395491
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I809a836bc92ca062ed263bf0a251e23e8aac2db7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ElectronPdfService
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP Upgrade WebdriverIO to 4.9

2017-12-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395490 )

Change subject: WIP Upgrade WebdriverIO to 4.9
..

WIP Upgrade WebdriverIO to 4.9

Bug: T180144
Change-Id: Iea8780c4e5956b433478735554301aaf16a49cc4
---
M package.json
M tests/selenium/wdio.conf.js
2 files changed, 2 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/90/395490/1

diff --git a/package.json b/package.json
index 2878eca..5d046bf 100644
--- a/package.json
+++ b/package.json
@@ -32,7 +32,6 @@
 "wdio-junit-reporter": "0.2.0",
 "wdio-mocha-framework": "0.5.8",
 "wdio-sauce-service": "^0.3.1",
-"wdio-spec-reporter": "0.0.5",
-"webdriverio": "4.6.2"
+"wdio-spec-reporter": "0.0.5"
   }
 }
diff --git a/tests/selenium/wdio.conf.js b/tests/selenium/wdio.conf.js
index cf9da0c..50f6f45 100644
--- a/tests/selenium/wdio.conf.js
+++ b/tests/selenium/wdio.conf.js
@@ -31,14 +31,6 @@
password :
process.env.MEDIAWIKI_PASSWORD,
//
-   // ==
-   // Sauce Labs
-   // ==
-   //
-   services: [ 'sauce' ],
-   user: process.env.SAUCE_USERNAME,
-   key: process.env.SAUCE_ACCESS_KEY,
-   //
// ==
// Specify Test Files
// ==
@@ -168,7 +160,7 @@
// Test reporter for stdout.
// The only one supported by default is 'dot'
// see also: http://webdriver.io/guide/testrunner/reporters.html
-   reporters: [ 'spec' ],
+   reporters: [ 'dot' ],
//
// Options to be passed to Mocha.
// See the full list at http://mochajs.org/

-- 
To view, visit https://gerrit.wikimedia.org/r/395490
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea8780c4e5956b433478735554301aaf16a49cc4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageTriage[master]: Update RuboCop Ruby gem

2017-12-04 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395026 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: I76b38e94aacb891fb4a621151fa9a1256c5a70e8
---
M .rubocop.yml
A .rubocop_todo.yml
M Gemfile
M Gemfile.lock
4 files changed, 45 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage 
refs/changes/26/395026/1

diff --git a/.rubocop.yml b/.rubocop.yml
index 84567a5..3c8a650 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
 AllCops:
   StyleGuideCopsOnly: true
 
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
new file mode 100644
index 000..3372cd1
--- /dev/null
+++ b/.rubocop_todo.yml
@@ -0,0 +1,27 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-12-04 16:54:44 +0100 using RuboCop version 0.51.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Configuration parameters: Blacklist.
+# Blacklist: END, (?-mix:EO[A-Z]{1})
+Naming/HeredocDelimiterNaming:
+  Exclude:
+- 'jsduck_custom_tags.rb'
+
+# Offense count: 1
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+- 'jsduck_custom_tags.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+- 'jsduck_custom_tags.rb'
diff --git a/Gemfile b/Gemfile
index 0f4ba53..591fd6b 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,4 +2,4 @@
 
 gem 'mediawiki_selenium', '~> 1.8'
 gem 'rake', '~> 11.1', '>= 11.1.1'
-gem 'rubocop', '~> 0.35.1', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 6d89e7c..1b16d93 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
+ast (2.3.0)
 builder (3.2.3)
 childprocess (0.6.2)
   ffi (~> 1.0, >= 1.0.11)
@@ -65,10 +63,12 @@
   watir (~> 6.0)
 page_navigation (0.10)
   data_magic (>= 0.22)
-parser (2.2.3.0)
-  ast (>= 1.1, < 3.0)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.0.0)
+rainbow (2.2.2)
+  rake
 rake (11.1.1)
 rest-client (1.8.0)
   http-cookie (>= 1.0.2, < 2.0)
@@ -77,14 +77,14 @@
 rspec-core (2.99.2)
 rspec-expectations (2.99.2)
   diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.35.1)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.3.0, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
+  rainbow (>= 2.2.2, < 3.0)
   ruby-progressbar (~> 1.7)
-  tins (<= 1.6.0)
-ruby-progressbar (1.7.5)
+  unicode-display_width (~> 1.0, >= 1.0.1)
+ruby-progressbar (1.9.0)
 rubyzip (1.2.1)
 selenium-webdriver (3.1.0)
   childprocess (~> 0.5)
@@ -92,10 +92,10 @@
   websocket (~> 1.0)
 syntax (1.2.1)
 thor (0.19.4)
-tins (1.6.0)
 unf (0.1.4)
   unf_ext
 unf_ext (0.0.7.2)
+unicode-display_width (1.3.0)
 watir (6.2.0)
   selenium-webdriver (~> 3.0)
 websocket (1.2.4)
@@ -107,7 +107,7 @@
 DEPENDENCIES
   mediawiki_selenium (~> 1.8)
   rake (~> 11.1, >= 11.1.1)
-  rubocop (~> 0.35.1)
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
-   1.14.5
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395026
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I76b38e94aacb891fb4a621151fa9a1256c5a70e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: Update RuboCop Ruby gem

2017-12-04 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395025 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: I2f559ded2f029bda8ba8bc2d87054330643bac09
---
M .rubocop_todo.yml
M Gemfile
M Gemfile.lock
3 files changed, 42 insertions(+), 20 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer 
refs/changes/25/395025/1

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 3e40090..f90453c 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,15 +1,37 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2015-12-09 17:16:31 +0100 using RuboCop version 0.35.1.
+# on 2017-12-04 16:52:05 +0100 using RuboCop version 0.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 76
-# Configuration parameters: AllowURI, URISchemes.
+# Offense count: 1
+Lint/RescueWithoutErrorClass:
+  Exclude:
+- 'tests/browser/features/step_definitions/mmv_steps.rb'
+
+# Offense count: 71
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, 
IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
 Metrics/LineLength:
-  Max: 254
+  Max: 249
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: lowercase, uppercase
+Naming/HeredocDelimiterCase:
+  Exclude:
+- 'tests/browser/features/support/pages/commons_page.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/Encoding:
+  Exclude:
+- 'tests/browser/features/step_definitions/mmv_download_steps.rb'
+- 'tests/browser/features/step_definitions/mmv_navigation_steps.rb'
+- 'tests/browser/features/step_definitions/mmv_options_steps.rb'
+- 'tests/browser/features/step_definitions/mmv_steps.rb'
 
 # Offense count: 3
 # Configuration parameters: AllowedVariables.
diff --git a/Gemfile b/Gemfile
index 0f4ba53..591fd6b 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,4 +2,4 @@
 
 gem 'mediawiki_selenium', '~> 1.8'
 gem 'rake', '~> 11.1', '>= 11.1.1'
-gem 'rubocop', '~> 0.35.1', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 6d89e7c..1b16d93 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
+ast (2.3.0)
 builder (3.2.3)
 childprocess (0.6.2)
   ffi (~> 1.0, >= 1.0.11)
@@ -65,10 +63,12 @@
   watir (~> 6.0)
 page_navigation (0.10)
   data_magic (>= 0.22)
-parser (2.2.3.0)
-  ast (>= 1.1, < 3.0)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.0.0)
+rainbow (2.2.2)
+  rake
 rake (11.1.1)
 rest-client (1.8.0)
   http-cookie (>= 1.0.2, < 2.0)
@@ -77,14 +77,14 @@
 rspec-core (2.99.2)
 rspec-expectations (2.99.2)
   diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.35.1)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.3.0, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
+  rainbow (>= 2.2.2, < 3.0)
   ruby-progressbar (~> 1.7)
-  tins (<= 1.6.0)
-ruby-progressbar (1.7.5)
+  unicode-display_width (~> 1.0, >= 1.0.1)
+ruby-progressbar (1.9.0)
 rubyzip (1.2.1)
 selenium-webdriver (3.1.0)
   childprocess (~> 0.5)
@@ -92,10 +92,10 @@
   websocket (~> 1.0)
 syntax (1.2.1)
 thor (0.19.4)
-tins (1.6.0)
 unf (0.1.4)
   unf_ext
 unf_ext (0.0.7.2)
+unicode-display_width (1.3.0)
 watir (6.2.0)
   selenium-webdriver (~> 3.0)
 websocket (1.2.4)
@@ -107,7 +107,7 @@
 DEPENDENCIES
   mediawiki_selenium (~> 1.8)
   rake (~> 11.1, >= 11.1.1)
-  rubocop (~> 0.35.1)
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
-   1.14.5
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395025
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f559ded2f029bda8ba8bc2d87054330643bac09
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Math[master]: Update RuboCop Ruby gem

2017-12-04 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395024 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: I37f1efb41684dc02aa06e17510099bcfa545f4a5
---
M Gemfile
M Gemfile.lock
2 files changed, 17 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Math 
refs/changes/24/395024/1

diff --git a/Gemfile b/Gemfile
index a815a01..576e971 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,4 +2,4 @@
 
 gem 'mediawiki_selenium', '~> 1.8'
 gem 'rake', '~> 10.5'
-gem 'rubocop', '~> 0.33.0', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 6d959ac..b15606a 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
+ast (2.3.0)
 builder (3.2.3)
 childprocess (0.6.2)
   ffi (~> 1.0, >= 1.0.11)
@@ -65,10 +63,12 @@
   watir (~> 6.0)
 page_navigation (0.10)
   data_magic (>= 0.22)
-parser (2.2.2.6)
-  ast (>= 1.1, < 3.0)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.0.0)
+rainbow (2.2.2)
+  rake
 rake (10.5.0)
 rest-client (1.8.0)
   http-cookie (>= 1.0.2, < 2.0)
@@ -77,13 +77,14 @@
 rspec-core (2.99.2)
 rspec-expectations (2.99.2)
   diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.33.0)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.2.5, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
-  ruby-progressbar (~> 1.4)
-ruby-progressbar (1.7.5)
+  rainbow (>= 2.2.2, < 3.0)
+  ruby-progressbar (~> 1.7)
+  unicode-display_width (~> 1.0, >= 1.0.1)
+ruby-progressbar (1.9.0)
 rubyzip (1.2.1)
 selenium-webdriver (3.1.0)
   childprocess (~> 0.5)
@@ -94,6 +95,7 @@
 unf (0.1.4)
   unf_ext
 unf_ext (0.0.7.2)
+unicode-display_width (1.3.0)
 watir (6.2.0)
   selenium-webdriver (~> 3.0)
 websocket (1.2.4)
@@ -105,7 +107,7 @@
 DEPENDENCIES
   mediawiki_selenium (~> 1.8)
   rake (~> 10.5)
-  rubocop (~> 0.33.0)
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
-   1.14.5
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I37f1efb41684dc02aa06e17510099bcfa545f4a5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Math
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GettingStarted[master]: Update RuboCop Ruby gem

2017-12-04 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395022 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: Ifd2b37d7136e7e3f5ff414b6a1c8964f48ce3d07
---
M .rubocop.yml
A .rubocop_todo.yml
M Gemfile
M Gemfile.lock
4 files changed, 33 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted 
refs/changes/22/395022/1

diff --git a/.rubocop.yml b/.rubocop.yml
index 84567a5..3c8a650 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
 AllCops:
   StyleGuideCopsOnly: true
 
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
new file mode 100644
index 000..3ff5102
--- /dev/null
+++ b/.rubocop_todo.yml
@@ -0,0 +1,14 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-12-04 16:43:08 +0100 using RuboCop version 0.51.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: Blacklist.
+# Blacklist: END, (?-mix:EO[A-Z]{1})
+Naming/HeredocDelimiterNaming:
+  Exclude:
+- 'tests/browser/features/support/pages/registration_page.rb'
diff --git a/Gemfile b/Gemfile
index f3acc08..591fd6b 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,4 +2,4 @@
 
 gem 'mediawiki_selenium', '~> 1.8'
 gem 'rake', '~> 11.1', '>= 11.1.1'
-gem 'rubocop', '~> 0.34.2', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 8fcd52c..1b16d93 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
+ast (2.3.0)
 builder (3.2.3)
 childprocess (0.6.2)
   ffi (~> 1.0, >= 1.0.11)
@@ -65,10 +63,12 @@
   watir (~> 6.0)
 page_navigation (0.10)
   data_magic (>= 0.22)
-parser (2.2.2.6)
-  ast (>= 1.1, < 3.0)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.0.0)
+rainbow (2.2.2)
+  rake
 rake (11.1.1)
 rest-client (1.8.0)
   http-cookie (>= 1.0.2, < 2.0)
@@ -77,13 +77,14 @@
 rspec-core (2.99.2)
 rspec-expectations (2.99.2)
   diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.34.2)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.2.5, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
-  ruby-progressbar (~> 1.4)
-ruby-progressbar (1.7.5)
+  rainbow (>= 2.2.2, < 3.0)
+  ruby-progressbar (~> 1.7)
+  unicode-display_width (~> 1.0, >= 1.0.1)
+ruby-progressbar (1.9.0)
 rubyzip (1.2.1)
 selenium-webdriver (3.1.0)
   childprocess (~> 0.5)
@@ -94,6 +95,7 @@
 unf (0.1.4)
   unf_ext
 unf_ext (0.0.7.2)
+unicode-display_width (1.3.0)
 watir (6.2.0)
   selenium-webdriver (~> 3.0)
 websocket (1.2.4)
@@ -105,7 +107,7 @@
 DEPENDENCIES
   mediawiki_selenium (~> 1.8)
   rake (~> 11.1, >= 11.1.1)
-  rubocop (~> 0.34.2)
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
-   1.14.5
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395022
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd2b37d7136e7e3f5ff414b6a1c8964f48ce3d07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Update RuboCop Ruby gem

2017-12-04 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395019 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: Ie12965e4ca22731f84e9f22a4d96bf90cf63063a
---
M .rubocop.yml
A .rubocop_todo.yml
M Gemfile
M Gemfile.lock
4 files changed, 68 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/19/395019/1

diff --git a/.rubocop.yml b/.rubocop.yml
index 84567a5..3c8a650 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
 AllCops:
   StyleGuideCopsOnly: true
 
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
new file mode 100644
index 000..5680096
--- /dev/null
+++ b/.rubocop_todo.yml
@@ -0,0 +1,49 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-12-04 16:37:27 +0100 using RuboCop version 0.51.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Layout/EmptyLinesAroundBlockBody:
+  Exclude:
+- 'tests/rspec/notification_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: Blacklist.
+# Blacklist: END, (?-mix:EO[A-Z]{1})
+Naming/HeredocDelimiterNaming:
+  Exclude:
+- 'jsduck_custom_tags.rb'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
+Naming/VariableName:
+  Exclude:
+- 'tests/browser/features/support/echo_api_helper.rb'
+
+# Offense count: 1
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+- 'jsduck_custom_tags.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+- 'jsduck_custom_tags.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: MinSize, SupportedStyles.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets
diff --git a/Gemfile b/Gemfile
index 70c1a10..a886a2d 100644
--- a/Gemfile
+++ b/Gemfile
@@ -4,4 +4,4 @@
 gem 'mediawiki_selenium', '~> 1.8'
 gem 'rake', '~> 11.1', '>= 11.1.1'
 gem 'rspec-mocks', '~> 2.99', '>= 2.99.4'
-gem 'rubocop', '~> 0.34.2', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 7a8d813..64a70a7 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
+ast (2.3.0)
 blankslate (3.1.3)
 builder (3.2.3)
 childprocess (0.6.2)
@@ -70,12 +68,14 @@
   watir (~> 6.0)
 page_navigation (0.10)
   data_magic (>= 0.22)
-parser (2.2.2.6)
-  ast (>= 1.1, < 3.0)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 parslet (1.7.1)
   blankslate (>= 2.0, <= 4.0)
 powerpack (0.1.1)
-rainbow (2.0.0)
+rainbow (2.2.2)
+  rake
 rake (11.1.1)
 rest-client (1.8.0)
   http-cookie (>= 1.0.2, < 2.0)
@@ -85,13 +85,14 @@
 rspec-expectations (2.99.2)
   diff-lcs (>= 1.1.3, < 2.0)
 rspec-mocks (2.99.4)
-rubocop (0.34.2)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.2.5, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
-  ruby-progressbar (~> 1.4)
-ruby-progressbar (1.7.5)
+  rainbow (>= 2.2.2, < 3.0)
+  ruby-progressbar (~> 1.7)
+  unicode-display_width (~> 1.0, >= 1.0.1)
+ruby-progressbar (1.9.0)
 rubyzip (1.2.1)
 selenium-webdriver (3.1.0)
   childprocess (~> 0.5)
@@ -102,6 +103,7 @@
 unf (0.1.4)
   unf_ext
 unf_ext (0.0.7.2)
+unicode-display_width (1.3.0)
 watir (6.2.0)
   selenium-webdriver (~> 3.0)
 websocket (1.2.4)
@@ -115,7 +117,7 @@
   mediawiki_selenium (~> 1.8)
   rake (~> 11.1, >= 11.1.1)
   rspec-mocks (~> 2.99, >= 2.99.4)
-  rubocop (~> 0.34.2)
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
-   1.14.6
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395019
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie12965e4ca22731f84e9f22a4d96bf90cf63063a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: Update RuboCop Ruby gem

2017-12-04 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395017 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Had to also update parallel_tests gem.

Bug: T180878
Change-Id: I526da0ad840e3226155c5b7fce0ccdbdd7636aae
---
M .rubocop_todo.yml
M Gemfile
M Gemfile.lock
3 files changed, 78 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/17/395017/1

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index eb43c09..e88082c 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,17 +1,72 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2015-12-18 16:23:11 +0100 using RuboCop version 0.35.1.
+# on 2017-12-04 16:34:17 +0100 using RuboCop version 0.51.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 223
-# Configuration parameters: AllowURI, URISchemes.
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/EmptyLines:
+  Exclude:
+- 'tests/browser/features/support/hooks.rb'
+
+# Offense count: 1
+Lint/RescueWithoutErrorClass:
+  Exclude:
+- 'tests/browser/features/support/hooks.rb'
+
+# Offense count: 258
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, 
IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
 Metrics/LineLength:
-  Max: 252
+  Max: 250
 
 # Offense count: 1
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 6
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/Encoding:
+  Exclude:
+- 'tests/browser/features/support/hooks.rb'
+
+# Offense count: 1
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+- 'tests/browser/features/support/pages/search_results_page.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+- 'spec/**/*'
+- 'tests/browser/features/step_definitions/search_steps.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/OrAssignment:
+  Exclude:
+- 'tests/browser/features/step_definitions/page_steps.rb'
+- 'tests/browser/features/step_definitions/search_steps.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+- 'tests/browser/features/step_definitions/search_steps.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, 
ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+- 'Gemfile'
diff --git a/Gemfile b/Gemfile
index abd796a..b387f90 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,6 +2,6 @@
 
 gem "mediawiki_selenium", "~> 1.8"
 gem "mimemagic", "~> 0.3.0"
-gem "parallel_tests", "~> 1.7.0"
+gem 'parallel_tests', '~> 2.19'
 gem "rake", "~> 10.4", ">= 10.4.2"
-gem "rubocop", "~> 0.35.1", require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 191b71d..82c3463 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.2.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
+ast (2.3.0)
 builder (3.2.3)
 childprocess (0.6.2)
   ffi (~> 1.0, >= 1.0.11)
@@ -66,13 +64,14 @@
   watir (~> 6.0)
 page_navigation (0.10)
   data_magic (>= 0.22)
-parallel (1.8.0)
-parallel_tests (1.7.1)
+parallel (1.12.0)
+parallel_tests (2.19.0)
   parallel
-parser (2.3.0.7)
-  ast (~> 2.2)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.1.0)
+rainbow (2.2.2)
+  rake
 rake (10.5.0)
 rest-client (1.8.0)
   http-cookie (>= 1.0.2, < 2.0)
@@ -81,14 +80,14 @@
 rspec-core (2.99.2)
 rspec-expectations (2.99.2)
   diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.35.1)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.3.0, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
+  rainbow (>= 2.2.2, < 3.0)
   ruby-progressbar (~> 1.7)
-  tins (<= 1.6.0)
-ruby-progressbar (1.8.0)
+  unicode-display_width (~> 1.0, >= 1.0.1)
+ruby-progressbar (1.9.0)
 rubyzip (1.2.1)
 selenium-webdriver (3.1.0)
   childprocess (~> 0.5)
@@ -96,10 +95,10 @@
   websocket (~> 1.0)
 syntax (1.2.1)
 thor (0.19.4)
-tins (1.6.0)
 unf (0.1.4)
   unf_ext
 unf_ext (0.0.7.2)
+unicode-display_width (1.3.0)

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: Update RuboCop Ruby gem

2017-12-04 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395015 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: Ib3abbe97206e960c5c2e310a17f67586ca9e79c0
---
M Gemfile
M Gemfile.lock
2 files changed, 17 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/15/395015/1

diff --git a/Gemfile b/Gemfile
index 35c7f03..7ee5bc6 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,4 +2,4 @@
 
 gem 'mediawiki_selenium', '~> 1.8'
 gem 'rake', '~> 10.4', '>= 10.4.2'
-gem 'rubocop', '~> 0.34.1', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 7809458..48f308d 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
+ast (2.3.0)
 builder (3.2.3)
 childprocess (0.6.2)
   ffi (~> 1.0, >= 1.0.11)
@@ -65,10 +63,12 @@
   watir (~> 6.0)
 page_navigation (0.10)
   data_magic (>= 0.22)
-parser (2.2.2.6)
-  ast (>= 1.1, < 3.0)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.0.0)
+rainbow (2.2.2)
+  rake
 rake (10.4.2)
 rest-client (1.8.0)
   http-cookie (>= 1.0.2, < 2.0)
@@ -77,13 +77,14 @@
 rspec-core (2.99.2)
 rspec-expectations (2.99.2)
   diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.34.1)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.2.5, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
-  ruby-progressbar (~> 1.4)
-ruby-progressbar (1.7.5)
+  rainbow (>= 2.2.2, < 3.0)
+  ruby-progressbar (~> 1.7)
+  unicode-display_width (~> 1.0, >= 1.0.1)
+ruby-progressbar (1.9.0)
 rubyzip (1.2.1)
 selenium-webdriver (3.1.0)
   childprocess (~> 0.5)
@@ -94,6 +95,7 @@
 unf (0.1.4)
   unf_ext
 unf_ext (0.0.7.2)
+unicode-display_width (1.3.0)
 watir (6.2.0)
   selenium-webdriver (~> 3.0)
 websocket (1.2.4)
@@ -105,7 +107,7 @@
 DEPENDENCIES
   mediawiki_selenium (~> 1.8)
   rake (~> 10.4, >= 10.4.2)
-  rubocop (~> 0.34.1)
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
-   1.14.5
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395015
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3abbe97206e960c5c2e310a17f67586ca9e79c0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Update RuboCop Ruby gem

2017-12-04 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395012 )

Change subject: Update RuboCop Ruby gem
..

Update RuboCop Ruby gem

Bug: T180878
Change-Id: If9103caa9e7f7ba35b7db6a1d38b1a6d3fc7e844
---
M Gemfile
M Gemfile.lock
2 files changed, 17 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/12/395012/1

diff --git a/Gemfile b/Gemfile
index 612e0b1..591fd6b 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,4 +2,4 @@
 
 gem 'mediawiki_selenium', '~> 1.8'
 gem 'rake', '~> 11.1', '>= 11.1.1'
-gem 'rubocop', '~> 0.34.1', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 241df73..1b16d93 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
+ast (2.3.0)
 builder (3.2.3)
 childprocess (0.6.2)
   ffi (~> 1.0, >= 1.0.11)
@@ -65,10 +63,12 @@
   watir (~> 6.0)
 page_navigation (0.10)
   data_magic (>= 0.22)
-parser (2.2.2.6)
-  ast (>= 1.1, < 3.0)
+parallel (1.12.0)
+parser (2.4.0.2)
+  ast (~> 2.3)
 powerpack (0.1.1)
-rainbow (2.0.0)
+rainbow (2.2.2)
+  rake
 rake (11.1.1)
 rest-client (1.8.0)
   http-cookie (>= 1.0.2, < 2.0)
@@ -77,13 +77,14 @@
 rspec-core (2.99.2)
 rspec-expectations (2.99.2)
   diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.34.1)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.2.5, < 3.0)
+rubocop (0.51.0)
+  parallel (~> 1.10)
+  parser (>= 2.3.3.1, < 3.0)
   powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
-  ruby-progressbar (~> 1.4)
-ruby-progressbar (1.7.5)
+  rainbow (>= 2.2.2, < 3.0)
+  ruby-progressbar (~> 1.7)
+  unicode-display_width (~> 1.0, >= 1.0.1)
+ruby-progressbar (1.9.0)
 rubyzip (1.2.1)
 selenium-webdriver (3.1.0)
   childprocess (~> 0.5)
@@ -94,6 +95,7 @@
 unf (0.1.4)
   unf_ext
 unf_ext (0.0.7.2)
+unicode-display_width (1.3.0)
 watir (6.2.0)
   selenium-webdriver (~> 3.0)
 websocket (1.2.4)
@@ -105,7 +107,7 @@
 DEPENDENCIES
   mediawiki_selenium (~> 1.8)
   rake (~> 11.1, >= 11.1.1)
-  rubocop (~> 0.34.1)
+  rubocop (~> 0.51.0)
 
 BUNDLED WITH
-   1.14.5
+   1.16.0

-- 
To view, visit https://gerrit.wikimedia.org/r/395012
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9103caa9e7f7ba35b7db6a1d38b1a6d3fc7e844
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Do not run Ruby Selenium jobs for Flow

2017-11-29 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394111 )

Change subject: Do not run Ruby Selenium jobs for Flow
..

Do not run Ruby Selenium jobs for Flow

Bug: T174591
Depends-On: I236fc83557290323c5168ec1292084624be64f56
Change-Id: Ib65c1438b55e44e67ff6b656134e0ee18faf22ab
---
M jjb/selenium.yaml
M zuul/layout.yaml
2 files changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/11/394111/1

diff --git a/jjb/selenium.yaml b/jjb/selenium.yaml
index 852cd9c..0dba34d 100644
--- a/jjb/selenium.yaml
+++ b/jjb/selenium.yaml
@@ -34,14 +34,6 @@
  - 'selenium-{name}'
 
 - project:
-name: Flow
-recipients: qa-ale...@lists.wikimedia.org sbis...@wikimedia.org # @SBisson
-repository: mediawiki/extensions/Flow
-
-jobs:
- - 'selenium-{name}'
-
-- project:
 name: GettingStarted
 recipients: mflasc...@wikimedia.org qa-ale...@lists.wikimedia.org 
samsm...@wikimedia.org # @Mattflaschen-WMF @phuedx
 repository: mediawiki/extensions/GettingStarted
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 4fd6354..73f0475 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -3454,8 +3454,6 @@
  - name: mwgate-npm
 experimental:
  - mediawiki-core-qunit-selenium-jessie
- - mwext-mw-selenium-jessie
- - mwext-ruby-jessie
 postmerge:
  - mwext-jsduck-publish
 

-- 
To view, visit https://gerrit.wikimedia.org/r/394111
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib65c1438b55e44e67ff6b656134e0ee18faf22ab
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Document how to run just one Selenium test

2017-11-28 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393760 )

Change subject: Document how to run just one Selenium test
..

Document how to run just one Selenium test

Bug: T139740
Change-Id: Ieb5f27285046c33d77b615159dc2000d80ef644a
---
M tests/selenium/README.md
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/60/393760/1

diff --git a/tests/selenium/README.md b/tests/selenium/README.md
index a14cccb..c895a42 100644
--- a/tests/selenium/README.md
+++ b/tests/selenium/README.md
@@ -30,6 +30,10 @@
 cd tests/selenium
 ../../node_modules/.bin/wdio --spec specs/page.js
 
+To run only one test (name contains string 'preferences'):
+
+../../node_modules/.bin/wdio --spec specs/user.js --mochaOpts.grep 
preferences
+
 The runner reads the config file `wdio.conf.js` and runs the spec listed in
 `page.js`.
 

-- 
To view, visit https://gerrit.wikimedia.org/r/393760
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb5f27285046c33d77b615159dc2000d80ef644a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: WIP Run Cucumber+Selenium+Node.js in CI

2017-11-15 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391567 )

Change subject: WIP Run Cucumber+Selenium+Node.js in CI
..

WIP Run Cucumber+Selenium+Node.js in CI

Bug: T179190

Depends-On: I787464acc571bd35ee667cb348d6a8047c0243d1
Change-Id: Ib74af603a8bfa9f2309a388de30a4bd8b7be0ed5
---
A tests/integration/README.md
1 file changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/67/391567/1

diff --git a/tests/integration/README.md b/tests/integration/README.md
new file mode 100644
index 000..c866e91
--- /dev/null
+++ b/tests/integration/README.md
@@ -0,0 +1,16 @@
+# Selenium tests
+
+Please see tests/selenium/README.md file in mediawiki/core repository.
+
+## Usage
+
+Set up MediaWiki-Vagrant:
+
+cd mediawiki/vagrant
+vagrant up
+vagrant roles enable cirrussearch
+vagrant provision
+
+Run tests from mediawiki/core folder:
+
+npm run selenium

-- 
To view, visit https://gerrit.wikimedia.org/r/391567
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib74af603a8bfa9f2309a388de30a4bd8b7be0ed5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP Run Cucumber+Selenium+Node.js in CI

2017-11-15 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391566 )

Change subject: WIP Run Cucumber+Selenium+Node.js in CI
..

WIP Run Cucumber+Selenium+Node.js in CI

Bug: T179190
Change-Id: I787464acc571bd35ee667cb348d6a8047c0243d1
---
M Gruntfile.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/66/391566/1

diff --git a/Gruntfile.js b/Gruntfile.js
index d1ef72f..042d3cf 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -22,9 +22,9 @@
};
 
if ( process.env.JENKINS_HOME ) {
-   WebdriverIOconfigFile = './tests/selenium/wdio.conf.jenkins.js';
+   WebdriverIOconfigFile = 
'./extensions/CirrusSearch/tests/integration/config/wdio.conf.jenkins.js';
} else {
-   WebdriverIOconfigFile = './tests/selenium/wdio.conf.js';
+   WebdriverIOconfigFile = 
'./extensions/CirrusSearch/tests/integration/config/wdio.conf.js';
}
 
grunt.initConfig( {

-- 
To view, visit https://gerrit.wikimedia.org/r/391566
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I787464acc571bd35ee667cb348d6a8047c0243d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: ESLint ecmaVersion setting is not needed if env is es6

2017-11-15 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391548 )

Change subject: ESLint ecmaVersion setting is not needed if env is es6
..

ESLint ecmaVersion setting is not needed if env is es6

From ESLint documentation:

"Specifying Environments:
es6 - enable all ECMAScript 6 features except for modules
(this automatically sets the ecmaVersion parser option to 6)."

https://eslint.org/docs/user-guide/configuring#specifying-environments

Bug: T139740
Change-Id: Ie675a8a75c09857003d100d7ff92922deebe753e
---
M tests/selenium/.eslintrc.json
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/48/391548/1

diff --git a/tests/selenium/.eslintrc.json b/tests/selenium/.eslintrc.json
index db736b7..85fc310 100644
--- a/tests/selenium/.eslintrc.json
+++ b/tests/selenium/.eslintrc.json
@@ -5,9 +5,6 @@
"mocha": true,
"node": true
},
-   "parserOptions": {
-   "ecmaVersion": 6
-   },
"globals": {
"browser": false
},

-- 
To view, visit https://gerrit.wikimedia.org/r/391548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie675a8a75c09857003d100d7ff92922deebe753e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: WIP Run Cucumber+Selenium+Node.js in CI

2017-11-15 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391547 )

Change subject: WIP Run Cucumber+Selenium+Node.js in CI
..

WIP Run Cucumber+Selenium+Node.js in CI

Bug: T179190
Depends-On: I6585bc074ed954f065291f3d5b3da3e13c92caf9
Change-Id: Icdbe6a28e72d7340c519f167b5741fc8d88371ff
---
M Gruntfile.js
M package.json
D tests/integration/config/wdio.conf.jenkins.js
D tests/integration/config/wdio.conf.js
4 files changed, 2 insertions(+), 358 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/47/391547/1

diff --git a/Gruntfile.js b/Gruntfile.js
index b3841f7..7e69972 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -5,23 +5,12 @@
  * @package CirrusSearch
  */
 
-const path = require( 'path' );
-
 /*jshint node:true */
 module.exports = function ( grunt ) {
grunt.loadNpmTasks( 'grunt-contrib-jshint' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
grunt.loadNpmTasks( 'grunt-banana-checker' );
grunt.loadNpmTasks( 'grunt-stylelint' );
-   grunt.loadNpmTasks( 'grunt-webdriver' );
-
-   var WebdriverIOconfigFile;
-
-   if ( process.env.JENKINS_HOME ) {
-   WebdriverIOconfigFile = 
'./tests/integration/config/wdio.conf.jenkins.js';
-   } else {
-   WebdriverIOconfigFile = 
'./tests/integration/config/wdio.conf.js';
-   }
 
grunt.initConfig( {
jshint: {
@@ -55,22 +44,6 @@
'!vendor/**'
]
},
-   // Configure WebdriverIO Node task
-   webdriver: {
-   test: {
-   configFile: WebdriverIOconfigFile,
-   spec: ( () => {
-   let spec = grunt.option( 'spec' );
-   if ( !spec ) {
-   return undefined;
-   }
-   if ( spec[0] === '/' ) {
-   return spec;
-   }
-   return path.join(__dirname, 
'tests/integration/features', spec);
-   } )()
-   }
-   }
} );
 
grunt.registerTask( 'test', [ 'jshint', 'jsonlint', 'banana', 
'stylelint' ] );
diff --git a/package.json b/package.json
index aabf898..2c7a0e1 100644
--- a/package.json
+++ b/package.json
@@ -4,22 +4,15 @@
   "private": true,
   "description": "Build tools for the CirrusSearch extension.",
   "scripts": {
-"test": "grunt test",
-"selenium": "killall -0 chromedriver 2>/dev/null || chromedriver 
--url-base=/wd/hub --port= & grunt webdriver:test; killall chromedriver"
+"test": "grunt test"
   },
   "devDependencies": {
-"chai": "^4.1.2",
-"cucumber": "^3.0.1",
 "grunt": "1.0.1",
 "grunt-banana-checker": "0.5.0",
 "grunt-contrib-jshint": "1.0.0",
 "grunt-jsonlint": "1.0.7",
 "grunt-stylelint": "0.6.0",
-"grunt-webdriver": "^2.0.3",
-"mwbot": "^1.0.9",
 "stylelint": "7.8.0",
-"stylelint-config-wikimedia": "0.4.1",
-"wdio-cucumber-framework": "^1.0.1",
-"webdriverio": "^4.8.0"
+"stylelint-config-wikimedia": "0.4.1"
   }
 }
diff --git a/tests/integration/config/wdio.conf.jenkins.js 
b/tests/integration/config/wdio.conf.jenkins.js
deleted file mode 100644
index 451b1c0..000
--- a/tests/integration/config/wdio.conf.jenkins.js
+++ /dev/null
@@ -1,22 +0,0 @@
-/*jshint esversion: 6,  node:true */
-
-/* eslint no-undef: "error" */
-/* eslint-env node */
-'use strict';
-var merge = require( 'deepmerge' ),
-   wdioConf = require( './wdio.conf.js' );
-
-// Overwrite default settings
-exports.config = merge( wdioConf.config, {
-   username: 'WikiAdmin',
-   password: 'testpass',
-   screenshotPath: '../log/',
-   baseUrl: process.env.MW_SERVER + process.env.MW_SCRIPT_PATH,
-
-   reporters: [ 'spec', 'junit' ],
-   reporterOptions: {
-   junit: {
-   outputDir: '../log/'
-   }
-   }
-} );
diff --git a/tests/integration/config/wdio.conf.js 
b/tests/integration/config/wdio.conf.js
deleted file mode 100644
index 179e302..000
--- a/tests/integration/config/wdio.conf.js
+++ /dev/null
@@ -1,300 +0,0 @@
-/*jshint esversion: 6,  node:true */
-/*global browser, console */
-
-/* eslint-env node */
-/* eslint no-undef: "error" */
-/* eslint-disable no-console, comma-dangle */
-'use strict';
-
-const child_process = require( 'child_process' ),
-   path = require( 'path' );
-
-function relPath( foo ) {
-   return path.resolve( __dirname, '../..', foo );
-}
-
-var forkedTracker;
-
-exports.config = {
-
-   //
-   // ==
-   //
-   // ==

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP Run Cucumber+Selenium+Node.js in CI

2017-11-15 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391546 )

Change subject: WIP Run Cucumber+Selenium+Node.js in CI
..

WIP Run Cucumber+Selenium+Node.js in CI

Bug: T179190
Change-Id: I6585bc074ed954f065291f3d5b3da3e13c92caf9
---
M Gruntfile.js
M package.json
M tests/selenium/wdio.conf.jenkins.js
M tests/selenium/wdio.conf.js
4 files changed, 90 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/46/391546/1

diff --git a/Gruntfile.js b/Gruntfile.js
index d1ef72f..e868a4e 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,4 +1,6 @@
-/* eslint-env node */
+/* eslint-env node, es6 */
+
+const path = require( 'path' );
 
 module.exports = function ( grunt ) {
 
@@ -22,9 +24,9 @@
};
 
if ( process.env.JENKINS_HOME ) {
-   WebdriverIOconfigFile = './tests/selenium/wdio.conf.jenkins.js';
+   WebdriverIOconfigFile = 
'./tests/integration/config/wdio.conf.jenkins.js';
} else {
-   WebdriverIOconfigFile = './tests/selenium/wdio.conf.js';
+   WebdriverIOconfigFile = 
'./tests/integration/config/wdio.conf.js';
}
 
grunt.initConfig( {
@@ -113,10 +115,20 @@
}
},
 
-   // Configure WebdriverIO task
+   // Configure WebdriverIO Node task
webdriver: {
test: {
-   configFile: WebdriverIOconfigFile
+   configFile: WebdriverIOconfigFile,
+   spec: ( () => {
+   let spec = grunt.option( 'spec' );
+   if ( !spec ) {
+   return undefined;
+   }
+   if ( spec[ 0 ] === '/' ) {
+   return spec;
+   }
+   return path.join( __dirname, 
'tests/integration/features', spec );
+   } )()
}
}
 
diff --git a/package.json b/package.json
index faca87d..8363e5b 100644
--- a/package.json
+++ b/package.json
@@ -7,6 +7,8 @@
 "selenium": "killall -0 chromedriver 2>/dev/null || chromedriver 
--url-base=/wd/hub --port= & grunt webdriver:test; killall chromedriver"
   },
   "devDependencies": {
+"chai": "^4.1.2",
+"cucumber": "^3.0.1",
 "deepmerge": "1.3.2",
 "eslint": "4.9.0",
 "eslint-config-wikimedia": "0.5.0",
@@ -18,20 +20,20 @@
 "grunt-jsonlint": "1.1.0",
 "grunt-karma": "2.0.0",
 "grunt-stylelint": "0.9.0",
-"grunt-webdriver": "2.0.3",
+"grunt-webdriver": "^2.0.3",
 "karma": "1.7.1",
 "karma-chrome-launcher": "2.2.0",
 "karma-firefox-launcher": "1.0.1",
 "karma-mocha-reporter": "2.2.5",
 "karma-qunit": "1.2.1",
-"nodemw": "0.11.0",
+"mwbot": "^1.0.9",
 "qunitjs": "2.4.1",
 "stylelint": "8.2.0",
 "stylelint-config-wikimedia": "0.4.2",
+"wdio-cucumber-framework": "^1.0.1",
 "wdio-junit-reporter": "0.2.0",
-"wdio-mocha-framework": "0.5.8",
 "wdio-sauce-service": "^0.3.1",
 "wdio-spec-reporter": "0.0.5",
-"webdriverio": "4.6.2"
+"webdriverio": "^4.8.0"
   }
 }
diff --git a/tests/selenium/wdio.conf.jenkins.js 
b/tests/selenium/wdio.conf.jenkins.js
index 59e1878..6049eb2 100644
--- a/tests/selenium/wdio.conf.jenkins.js
+++ b/tests/selenium/wdio.conf.jenkins.js
@@ -1,19 +1,13 @@
 /* eslint no-undef: "error" */
 /* eslint-env node */
 'use strict';
-const merge = require( 'deepmerge' ),
-   password = 'testpass',
-   username = 'WikiAdmin',
+var merge = require( 'deepmerge' ),
wdioConf = require( './wdio.conf.js' );
 
 // Overwrite default settings
 exports.config = merge( wdioConf.config, {
-   username: process.env.MEDIAWIKI_USER === undefined ?
-   username :
-   process.env.MEDIAWIKI_USER,
-   password: process.env.MEDIAWIKI_PASSWORD === undefined ?
-   password :
-   process.env.MEDIAWIKI_PASSWORD,
+   username: 'WikiAdmin',
+   password: 'testpass',
screenshotPath: '../log/',
baseUrl: process.env.MW_SERVER + process.env.MW_SCRIPT_PATH,
 
diff --git a/tests/selenium/wdio.conf.js b/tests/selenium/wdio.conf.js
index cf9da0c..10aa5b8 100644
--- a/tests/selenium/wdio.conf.js
+++ b/tests/selenium/wdio.conf.js
@@ -3,9 +3,10 @@
 /* eslint-disable no-console, comma-dangle */
 'use strict';
 
-const password = 'vagrant',
-   path = require( 'path' ),
-   username = 'Admin';
+const childProcess = require( 'child_process' ),
+   path = require( 'path' );
+
+var forkedTracker;
 
 function relPath( foo ) {
return path.resolve( __dirname,

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP MediaWiki core Selenium tests fail when targeting Vagrant

2017-11-14 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391260 )

Change subject: WIP MediaWiki core Selenium tests fail when targeting Vagrant
..

WIP MediaWiki core Selenium tests fail when targeting Vagrant

Bug: T180035
Change-Id: I5920e3525ec7e3cfc94410c9797b53e0576a5058
---
M tests/selenium/specs/user.js
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/60/391260/1

diff --git a/tests/selenium/specs/user.js b/tests/selenium/specs/user.js
index 3f3872d..af08f3a 100644
--- a/tests/selenium/specs/user.js
+++ b/tests/selenium/specs/user.js
@@ -62,6 +62,7 @@
PreferencesPage.changeRealName( realName );
 
// check
+   browser.refresh(); // T180035
assert.equal( PreferencesPage.realName.getValue(), realName );
 
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/391260
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5920e3525ec7e3cfc94410c9797b53e0576a5058
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run qunit-selenium for Echo

2017-11-14 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391249 )

Change subject: Run qunit-selenium for Echo
..

Run qunit-selenium for Echo

Run the job in test, gate-and-submit and gate-and-submit-swat pipelines, 
instead of experimental pipeline.

Bug: T171848
Change-Id: If17fd48bfa318c38bd895491a608db4441f12836
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/49/391249/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index f547e5f..c5a0540 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -3287,10 +3287,9 @@
   - name: extension-gate
   - name: extension-unittests-generic
   - name: extension-qunit-generic
+  - name: mediawiki-core-qunit-selenium-jessie
   - name: mwext-ruby-jessie
   - name: mwgate-npm
-experimental:
-  - mediawiki-core-qunit-selenium-jessie
 
   - name: mediawiki/extensions/EditAccount
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/391249
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If17fd48bfa318c38bd895491a608db4441f12836
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run qunit-selenium job for all repositories that have Seleni...

2017-11-10 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/390447 )

Change subject: Run qunit-selenium job for all repositories that have Selenium 
tests
..

Run qunit-selenium job for all repositories that have Selenium tests

mediawiki-core-qunit-selenium-jessie should run in experimental pipeline
for all repositories that have Selenium tests written in Ruby.

Bug: T139740
Change-Id: I5c4a8c5707f1feb44c132e1bca55dc59614e1e0e
---
M zuul/layout.yaml
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/47/390447/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 0b077b5..efc7f7e 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -3274,6 +3274,8 @@
   - name: mwgate-npm
   - name: extension-selenium
   - name: extension-phan-generic
+experimental:
+  - mediawiki-core-qunit-selenium-jessie
 
   - name: mediawiki/extensions/EmailAuth
 template:
@@ -5418,6 +5420,8 @@
   - name: mwgate-npm
   - name: extension-selenium
   - name: extension-phan-generic
+experimental:
+  - mediawiki-core-qunit-selenium-jessie
 
   - name: mediawiki/extensions/RightFunctions
 template:
@@ -5826,6 +5830,8 @@
   - name: mwgate-npm
   - name: extension-selenium
   - name: extension-phan-generic
+experimental:
+  - mediawiki-core-qunit-selenium-jessie
 
   - name: mediawiki/extensions/TwoFactorAuthentication
 template:
@@ -6018,6 +6024,8 @@
   - mwext-mw-selenium-composer-jessie
 gate-and-submit:
   - mwext-mw-selenium-composer-jessie
+experimental:
+  - mediawiki-core-qunit-selenium-jessie
 
   - name: mediawiki/extensions/WikibaseQuality
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/390447
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c4a8c5707f1feb44c132e1bca55dc59614e1e0e
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: WIP Wikibase daily browser test does not use Sauce Labs

2017-11-10 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/390394 )

Change subject: WIP Wikibase daily browser test does not use Sauce Labs
..

WIP Wikibase daily browser test does not use Sauce Labs

Deleted: selenium-Wikibase
Created: selenium-Wikibase-chrome

Bug: T167432
Change-Id: I1bf203f4028dbff1f539056217ae7801ea48d8d0
---
M jjb/job-templates-selenium.yaml
M jjb/selenium.yaml
2 files changed, 152 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/94/390394/1

diff --git a/jjb/job-templates-selenium.yaml b/jjb/job-templates-selenium.yaml
index 39c1526..0bd2cb0 100644
--- a/jjb/job-templates-selenium.yaml
+++ b/jjb/job-templates-selenium.yaml
@@ -148,3 +148,154 @@
   - text:
   credential-id: sauce-ondemand-access-key
   variable: SAUCE_ONDEMAND_ACCESS_KEY
+
+- job-template:
+name: 'selenium-{name}-chrome'
+project-type: matrix
+path_to_ci_yml: tests/browser/ci.yml
+yaml-strategy:
+  exclude-key: 'exclude'
+  filename: '{path_to_ci_yml}'
+axes:
+  - axis:
+  type: label-expression
+  name: label
+  values:
+- BrowserTests
+  - axis:
+  name: BROWSER
+  type: yaml
+  filename: '{path_to_ci_yml}'
+  - axis:
+  name: MEDIAWIKI_ENVIRONMENT
+  type: yaml
+  filename: '{path_to_ci_yml}'
+  - axis:
+  name: PLATFORM
+  type: yaml
+  filename: '{path_to_ci_yml}'
+
+# Label for the parent job
+node: BrowserTests
+
+repository_host: 'gerrit.wikimedia.org/r'
+
+properties:
+ - build-discarder:
+ days-to-keep: 31  # ~ 2 * 2 weeks sprints
+
+scm:
+  - git:
+  url: https://{repository_host}/{repository}
+  branches:
+- master
+  wipe-workspace: false  # keep the workspace...
+  clean:
+  after: true# ... and use git clean instead
+  prune: true# prune remote obsoletes branches
+  submodule:
+  recursive: true
+
+triggers:
+  - timed: "@daily"
+
+builders:
+  - shell: |
+  rm -fR log
+  mkdir -p "$WORKSPACE/log/junit"
+  - shell: |
+  # Attempt to figure out MediaWiki branch being used and fetch it out
+  # if the extension has the same branch
+  if [[ "$MEDIAWIKI_ENVIRONMENT" == "beta"* ]]; then
+export 
MEDIAWIKI_API_URL="https://en.wikipedia.beta.wmflabs.org/w/api.php;
+  elif [ "$MEDIAWIKI_ENVIRONMENT" = "mediawiki" ]; then
+export MEDIAWIKI_API_URL="https://www.mediawiki.org/w/api.php;
+  elif [ "$MEDIAWIKI_ENVIRONMENT" = "test" ]; then
+export MEDIAWIKI_API_URL="https://test.wikipedia.org/w/api.php;
+  else
+echo "MEDIAWIKI_ENVIRONMENT $MEDIAWIKI_ENVIRONMENT not supported!"
+exit 1
+  fi
+  
MEDIAWIKI_GIT_BRANCH=$(/srv/deployment/integration/slave-scripts/bin/mw-api-siteinfo.py
 "$MEDIAWIKI_API_URL" git_branch)
+
+  git checkout -f "origin/$MEDIAWIKI_GIT_BRANCH" || {{
+  echo "origin/$MEDIAWIKI_GIT_BRANCH branch does not exist."
+  echo "Fallbacking to master branch..."
+  MEDIAWIKI_GIT_BRANCH='master'
+  git checkout -f origin/$MEDIAWIKI_GIT_BRANCH
+  }}
+  git reset --hard "origin/$MEDIAWIKI_GIT_BRANCH"
+  git clean -x -q -d -f
+  - shell: |
+  RUBY_VERSION=$(ruby -e 'print RbConfig::CONFIG["ruby_version"]')
+  export GEM_HOME="$HOME/.gem/$RUBY_VERSION"
+  bundle install --verbose
+
+  # credentials
+  export SAUCE_ONDEMAND_USERNAME=wikimedia-jenkins
+  if [[ "$MEDIAWIKI_ENVIRONMENT" == "beta"* ]]; then
+echo MEDIAWIKI_PASSWORD="\$selenium_user_beta"
+set +x
+export MEDIAWIKI_PASSWORD="$selenium_user_beta"
+set -x
+  elif [ "$MEDIAWIKI_ENVIRONMENT" = "mediawiki" ] || [ 
"$MEDIAWIKI_ENVIRONMENT" = "test" ]; then
+echo MEDIAWIKI_PASSWORD="\$selenium_user_production"
+set +x
+export MEDIAWIKI_PASSWORD="$selenium_user_production"
+set -x
+  else
+echo "MEDIAWIKI_ENVIRONMENT $MEDIAWIKI_ENVIRONMENT not supported!"
+exit 1
+  fi
+
+  # run the tests
+  bundle exec rake selenium
+
+publishers:
+  - xunit:
+  thresholdsmode: 'number'
+  thresholds:
+  - failed:
+  unstable: 0
+  failurenew: 0
+  types:
+  - junit:
+  pattern: 'log/junit/*.xml'
+
+  - email-ext:
+  recipients: '{recipients}'
+  body: '${{SCRIPT, template="wikimedia.template"}}'
+  failure: true
+

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP Run WebdriverIO tests using Firefox

2017-11-09 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/390268 )

Change subject: WIP Run WebdriverIO tests using Firefox
..

WIP Run WebdriverIO tests using Firefox

Bug: T161697
Change-Id: I2b64646e7c89f52b1971835e510d28d8cacdea79
---
M package.json
M tests/selenium/pageobjects/page.js
M tests/selenium/specs/page.js
M tests/selenium/specs/user.js
M tests/selenium/wdio.conf.js
5 files changed, 6 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/68/390268/1

diff --git a/package.json b/package.json
index faca87d..31a3f81 100644
--- a/package.json
+++ b/package.json
@@ -4,7 +4,7 @@
 "test": "grunt test",
 "doc": "jsduck",
 "postdoc": "grunt copy:jsduck",
-"selenium": "killall -0 chromedriver 2>/dev/null || chromedriver 
--url-base=/wd/hub --port= & grunt webdriver:test; killall chromedriver"
+"selenium": "killall -0 geckodriver 2>/dev/null || geckodriver & grunt 
webdriver:test; killall geckodriver"
   },
   "devDependencies": {
 "deepmerge": "1.3.2",
@@ -32,6 +32,6 @@
 "wdio-mocha-framework": "0.5.8",
 "wdio-sauce-service": "^0.3.1",
 "wdio-spec-reporter": "0.0.5",
-"webdriverio": "4.6.2"
+"webdriverio": "4.9.4"
   }
 }
diff --git a/tests/selenium/pageobjects/page.js 
b/tests/selenium/pageobjects/page.js
index 864bdae..9d6988a 100644
--- a/tests/selenium/pageobjects/page.js
+++ b/tests/selenium/pageobjects/page.js
@@ -5,7 +5,7 @@
this.title = 'My Page';
}
open( path ) {
-   browser.url( '/index.php?title=' + path );
+   browser.url( 'w/index.php?title=' + path );
}
 }
 module.exports = Page;
diff --git a/tests/selenium/specs/page.js b/tests/selenium/specs/page.js
index 06d3d60..1feba11 100644
--- a/tests/selenium/specs/page.js
+++ b/tests/selenium/specs/page.js
@@ -12,7 +12,6 @@
before( function () {
// disable VisualEditor welcome dialog
UserLoginPage.open();
-   browser.localStorage( 'POST', { key: 've-beta-welcome-dialog', 
value: '1' } );
} );
 
beforeEach( function () {
diff --git a/tests/selenium/specs/user.js b/tests/selenium/specs/user.js
index 3f3872d..1442ed1 100644
--- a/tests/selenium/specs/user.js
+++ b/tests/selenium/specs/user.js
@@ -12,7 +12,6 @@
before( function () {
// disable VisualEditor welcome dialog
UserLoginPage.open();
-   browser.localStorage( 'POST', { key: 've-beta-welcome-dialog', 
value: '1' } );
} );
 
beforeEach( function () {
diff --git a/tests/selenium/wdio.conf.js b/tests/selenium/wdio.conf.js
index cf9da0c..5559dad 100644
--- a/tests/selenium/wdio.conf.js
+++ b/tests/selenium/wdio.conf.js
@@ -49,9 +49,6 @@
//
specs: [
relPath( './tests/selenium/specs/**/*.js' ),
-   relPath( './extensions/*/tests/selenium/specs/**/*.js' ),
-   relPath( 
'./extensions/VisualEditor/modules/ve-mw/tests/selenium/specs/**/*.js' ),
-   relPath( './skins/*/tests/selenium/specs/**/*.js' ),
],
// Patterns to exclude.
exclude: [
@@ -86,12 +83,10 @@
// 5 instances get started at a time.
maxInstances: 1,
//
-   browserName: 'chrome',
-   // Since Chrome v57 
https://bugs.chromium.org/p/chromedriver/issues/detail?id=1625
-   chromeOptions: {
-   args: [ '--enable-automation' ]
-   }
+   browserName: 'firefox',
} ],
+   // Path to chromedriver or geckodriver
+   path: '/',
//
// ===
// Test Configurations

-- 
To view, visit https://gerrit.wikimedia.org/r/390268
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b64646e7c89f52b1971835e510d28d8cacdea79
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP Upgrade WebdriverIO to 4.9.2

2017-11-09 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/390233 )

Change subject: WIP Upgrade WebdriverIO to 4.9.2
..

WIP Upgrade WebdriverIO to 4.9.2

Bug: T161697
Change-Id: I9b41b89f0a2f657c871419cd04c43a5f98c297d6
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/33/390233/1

diff --git a/package.json b/package.json
index faca87d..9110c2f 100644
--- a/package.json
+++ b/package.json
@@ -32,6 +32,6 @@
 "wdio-mocha-framework": "0.5.8",
 "wdio-sauce-service": "^0.3.1",
 "wdio-spec-reporter": "0.0.5",
-"webdriverio": "4.6.2"
+"webdriverio": "4.9.2"
   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/390233
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b41b89f0a2f657c871419cd04c43a5f98c297d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run mediawiki-core-qunit-selenium-jessie for all repos that ...

2017-11-09 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/390232 )

Change subject: Run mediawiki-core-qunit-selenium-jessie for all repos that 
have Selenium tests
..

Run mediawiki-core-qunit-selenium-jessie for all repos that have Selenium tests

The job should run in experimental pipeline for all repositories that have 
Selenium tests written in Ruby.

Bug: T139740
Change-Id: I95669b125ef5fb443c0f29bb856bd790252799c4
---
M zuul/layout.yaml
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/32/390232/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index a47d997..3278709 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -2893,6 +2893,7 @@
   - name: mwgate-rake
   - name: mwgate-npm
 experimental:
+  - mediawiki-core-qunit-selenium-jessie
   - mwext-mw-selenium-jessie
   - mwext-ruby-jessie
 
@@ -3345,6 +3346,7 @@
  - name: extension-jsduck
  - name: mwgate-npm
 experimental:
+ - mediawiki-core-qunit-selenium-jessie
  - mwext-mw-selenium-jessie
  - mwext-ruby-jessie
 postmerge:
@@ -3380,6 +3382,7 @@
   - name: mwgate-rake
   - name: mwgate-npm
 experimental:
+  - mediawiki-core-qunit-selenium-jessie
   - mwext-ruby-jessie
 
   - name: mediawiki/extensions/Genealogy
@@ -3843,6 +3846,7 @@
 postmerge:
   - mwext-jsduck-publish
 experimental:
+  - mediawiki-core-qunit-selenium-jessie
   - mwext-ruby-jessie
 
   - name: mediawiki/extensions/MwEmbedSupport
@@ -4005,6 +4009,7 @@
   - name: mwgate-rake
   - name: mwgate-npm
 experimental:
+  - mediawiki-core-qunit-selenium-jessie
   - mwext-mw-selenium-jessie
   - mwext-ruby-jessie
 
@@ -7083,6 +7088,7 @@
   - mwext-Wikibase-client-tests-mysql-hhvm-jessie
 gate-and-submit-swat: *mediawiki-extensions-wikibase-gate-and-submit
 experimental:
+  - mediawiki-core-qunit-selenium-jessie
   - mwext-ruby-jessie
 postmerge:
   - mwext-doxygen-publish
@@ -7127,6 +7133,7 @@
   - name: mwgate-rake
   - name: mwgate-npm
 experimental:
+  - mediawiki-core-qunit-selenium-jessie
   - mwext-mw-selenium-jessie
   - mwext-ruby-jessie
 

-- 
To view, visit https://gerrit.wikimedia.org/r/390232
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I95669b125ef5fb443c0f29bb856bd790252799c4
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Refactor selenium-RelatedArticles-jessie job selenium-{name}...

2017-11-02 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/388081 )

Change subject: Refactor selenium-RelatedArticles-jessie job 
selenium-{name}-jessie job template
..

Refactor selenium-RelatedArticles-jessie job selenium-{name}-jessie job template

Bug: T179546
Change-Id: I16358bb7a00b4cb23f4f0c732e5de49e443250f3
---
M jjb/mediawiki-extensions.yaml
1 file changed, 9 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/81/388081/1

diff --git a/jjb/mediawiki-extensions.yaml b/jjb/mediawiki-extensions.yaml
index 849bfcb..50f2d0b 100644
--- a/jjb/mediawiki-extensions.yaml
+++ b/jjb/mediawiki-extensions.yaml
@@ -432,10 +432,10 @@
  - '{name}-jsduck'
  - 'mwext-VisualEditor-npm-node-6-jessie'
 
-# Run RelatedArticles Selenium tests daily targeting beta cluster
+# Run Selenium tests daily targeting beta cluster
 # similar to mediawiki-core-qunit-selenium-jessie
-- job:
-name: 'selenium-RelatedArticles-jessie'
+- job-template:
+name: 'selenium-{name}-jessie'
 node: ci-jessie-wikimedia
 concurrent: true
 triggers:
@@ -478,3 +478,9 @@
 # Qunit does not generate Junit file and we might skip selenium
 allow-empty-results: true
 
+- project:
+name: RelatedArticles
+repository: mediawiki/extensions/RelatedArticles
+
+jobs:
+ - 'selenium-{name}-jessie'

-- 
To view, visit https://gerrit.wikimedia.org/r/388081
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I16358bb7a00b4cb23f4f0c732e5de49e443250f3
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP Mocha tests for Echo notifications

2017-10-19 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385191 )

Change subject: WIP Mocha tests for Echo notifications
..

WIP Mocha tests for Echo notifications

Bug: T177412
Change-Id: I20685abf6eac9132df2c8033ee40f9f82c05051c
---
M Gruntfile.js
M package.json
2 files changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/91/385191/1

diff --git a/Gruntfile.js b/Gruntfile.js
index dbbfcb81..34d31f8 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -13,6 +13,7 @@
grunt.loadNpmTasks( 'grunt-eslint' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
grunt.loadNpmTasks( 'grunt-karma' );
+   grunt.loadNpmTasks( 'grunt-simple-mocha' );
grunt.loadNpmTasks( 'grunt-stylelint' );
grunt.loadNpmTasks( 'grunt-webdriver' );
 
@@ -121,6 +122,18 @@
test: {
configFile: WebdriverIOconfigFile
}
+   },
+
+   simplemocha: {
+   options: {
+   timeout: 2
+   },
+   all: {
+   src: [
+   'tests/mocha/**/*.js',
+   './extensions/*/tests/mocha/**/*.js'
+   ]
+   }
}
 
} );
diff --git a/package.json b/package.json
index 96a425f..84fcef1 100644
--- a/package.json
+++ b/package.json
@@ -3,6 +3,7 @@
   "scripts": {
 "test": "grunt test",
 "doc": "jsduck",
+"mocha": "grunt simplemocha",
 "postdoc": "grunt copy:jsduck",
 "selenium": "killall -0 chromedriver 2>/dev/null || chromedriver 
--url-base=/wd/hub --port= & grunt webdriver:test; killall chromedriver"
   },
@@ -17,6 +18,7 @@
 "grunt-eslint": "20.0.0",
 "grunt-jsonlint": "1.1.0",
 "grunt-karma": "2.0.0",
+"grunt-simple-mocha": "0.4.1",
 "grunt-stylelint": "0.8.0",
 "grunt-webdriver": "2.0.3",
 "karma": "1.5.0",
@@ -24,6 +26,7 @@
 "karma-firefox-launcher": "1.0.1",
 "karma-mocha-reporter": "2.2.3",
 "karma-qunit": "1.0.0",
+"mocha": "4.0.1",
 "nodemw": "0.10.1",
 "qunitjs": "1.23.1",
 "stylelint": "7.8.0",

-- 
To view, visit https://gerrit.wikimedia.org/r/385191
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I20685abf6eac9132df2c8033ee40f9f82c05051c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: WIP Running mediawiki-core-qunit-selenium-jessie for Popups

2017-10-19 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385172 )

Change subject: WIP Running mediawiki-core-qunit-selenium-jessie for Popups
..

WIP Running mediawiki-core-qunit-selenium-jessie for Popups

The smallest possible commit.

The next commit should do some cleanup, like in 384965:

- delete unused extension-selenium-gate template
- remove unneeded Ruby jobs from experimental pipeline

Bug: T177262
Change-Id: I35b834ad39ccd2e001afd1020e204ae2bff36364
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/72/385172/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 06f3744..cb609e9 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -6537,7 +6537,7 @@
 template:
   - name: extension-unittests-generic
   - name: extension-qunit-generic
-  - name: extension-selenium-gate
+  - name: mediawiki-core-qunit-selenium-jessie
   - name: mwgate-npm
 experimental:
   - mediawiki-core-qunit-selenium-jessie

-- 
To view, visit https://gerrit.wikimedia.org/r/385172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I35b834ad39ccd2e001afd1020e204ae2bff36364
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run mediawiki-core-qunit-selenium-jessie for Popups

2017-10-18 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384968 )

Change subject: Run mediawiki-core-qunit-selenium-jessie for Popups
..

Run mediawiki-core-qunit-selenium-jessie for Popups

Instead of mwext-mw-selenium-jessie and mwext-ruby-jessie.

Bug: T177262
Change-Id: I39c3bcc3642d5b943340058ac8da84743c4d6ecc
---
M zuul/layout.yaml
1 file changed, 5 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/68/384968/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index a6f6ca3..1a6d96a 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -1072,13 +1072,6 @@
 postmerge:
   - mwext-mw-selenium-jessie
 
-  - name: extension-selenium-gate
-test:
-  - mwext-mw-selenium-jessie
-gate-and-submit: 
-  - mwext-mw-selenium-jessie
-gate-and-submit-swat: *extension-selenium-gate-gate-and-submit
-
   - name: extension-gate
 check:
   - mwgate-php55lint
@@ -6525,8 +6518,12 @@
 template:
   - name: extension-unittests-generic
   - name: extension-qunit-generic
-  - name: extension-selenium-gate
   - name: mwgate-npm
+test:
+  - mwext-mw-selenium-jessie
+gate-and-submit: 
+  - mwext-mw-selenium-jessie
+gate-and-submit-swat: *extension-selenium-gate-gate-and-submit
 experimental:
   - mediawiki-core-qunit-selenium-jessie
   - mwext-ruby-jessie

-- 
To view, visit https://gerrit.wikimedia.org/r/384968
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39c3bcc3642d5b943340058ac8da84743c4d6ecc
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Running mediawiki-core-qunit-selenium-jessie for Popups

2017-10-18 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384965 )

Change subject: Running mediawiki-core-qunit-selenium-jessie for Popups
..

Running mediawiki-core-qunit-selenium-jessie for Popups

In test and gate-and-submit pipelines. Popups has Selenium tests in Node.js 
now, instead of Ruby.

Bug: T177262
Change-Id: Ia09b98f921279e29e2891d0c102032e49c159c91
---
M zuul/layout.yaml
1 file changed, 7 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/65/384965/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index a6f6ca3..313a919 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -1072,13 +1072,6 @@
 postmerge:
   - mwext-mw-selenium-jessie
 
-  - name: extension-selenium-gate
-test:
-  - mwext-mw-selenium-jessie
-gate-and-submit: 
-  - mwext-mw-selenium-jessie
-gate-and-submit-swat: *extension-selenium-gate-gate-and-submit
-
   - name: extension-gate
 check:
   - mwgate-php55lint
@@ -1247,6 +1240,12 @@
   - mwext-ruby-jessie
 gate-and-submit:
   - mwext-ruby-jessie
+
+  - name: mediawiki-core-qunit-selenium-jessie
+test:
+  - mediawiki-core-qunit-selenium-jessie
+gate-and-submit:
+  - mediawiki-core-qunit-selenium-jessie
 
   - name: puppet-module
 test:
@@ -6525,11 +6524,8 @@
 template:
   - name: extension-unittests-generic
   - name: extension-qunit-generic
-  - name: extension-selenium-gate
+  - name: mediawiki-core-qunit-selenium-jessie
   - name: mwgate-npm
-experimental:
-  - mediawiki-core-qunit-selenium-jessie
-  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/PostEdit
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/384965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia09b98f921279e29e2891d0c102032e49c159c91
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Created mediawiki-core-qunit-selenium-jessie template

2017-10-18 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384961 )

Change subject: Created mediawiki-core-qunit-selenium-jessie template
..

Created mediawiki-core-qunit-selenium-jessie template

Also using the template in repositories instead of individual jobs.

Bug: T177262
Change-Id: I6e582b305d687b0d59cd09b74cc58c626ab21404
---
M zuul/layout.yaml
1 file changed, 10 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/61/384961/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index a6f6ca3..23bbd98 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -1248,6 +1248,12 @@
 gate-and-submit:
   - mwext-ruby-jessie
 
+  - name: mediawiki-core-qunit-selenium-jessie
+test:
+  - mediawiki-core-qunit-selenium-jessie
+gate-and-submit:
+  - mediawiki-core-qunit-selenium-jessie
+
   - name: puppet-module
 test:
   - puppet-{name}-rake-jessie
@@ -1402,6 +1408,7 @@
   - name: mediawiki/core
 template:
   - name: extension-gate
+  - name: mediawiki-core-qunit-selenium-jessie
 check:
   - mediawiki-core-php55lint
   - composer-package-validate
@@ -1411,7 +1418,6 @@
   - mediawiki-core-npm-node-6-jessie
   - mediawiki-core-php55lint
   - mediawiki-phpunit-hhvm-jessie
-  - mediawiki-core-qunit-selenium-jessie
   - composer-package-validate
   - mediawiki-core-php70-phan-docker
 php5:
@@ -1425,7 +1431,6 @@
   - mediawiki-phpunit-hhvm-jessie
   - mediawiki-phpunit-hhvm-composer-jessie
   - mediawiki-phpunit-php55-jessie
-  - mediawiki-core-qunit-selenium-jessie
   - composer-package-validate
   - mediawiki-core-php70-phan-docker
 gate-and-submit-swat: *mediawiki-core-gate-and-submit
@@ -1451,13 +1456,13 @@
   - name: mediawiki/vendor
 template:
   - name: extension-gate
+  - name: mediawiki-core-qunit-selenium-jessie
 check:
   - mwgate-php55lint
   - mwgate-composer-validate
 test:
   - mwgate-composer-hhvm-jessie
   - mwgate-composer-php55-jessie
-  - mediawiki-core-qunit-selenium-jessie
   - mediawiki-phpunit-hhvm-jessie
 php5:
   - mediawiki-phpunit-php55-jessie
@@ -1466,7 +1471,6 @@
   - mwgate-composer-php55-jessie
   - mediawiki-phpunit-hhvm-jessie
   - mediawiki-phpunit-php55-jessie
-  - mediawiki-core-qunit-selenium-jessie
 gate-and-submit-swat: *mediawiki-vendor-gate-and-submit
 experimental:
   - mwgate-composer-php70-jessie
@@ -1990,13 +1994,10 @@
 
   - name: mediawiki/skins/Vector
 template:
+ - name: mediawiki-core-qunit-selenium-jessie
  - name: mwgate-composer
  - name: mwgate-npm
  - name: skin-tests
-test:
- - mediawiki-core-qunit-selenium-jessie
-gate-and-submit: 
- - mediawiki-core-qunit-selenium-jessie
 gate-and-submit-swat: *mediawiki-skins-vector-gate-and-submit
 
   - name: mediawiki/skins/VectorV2
@@ -6557,11 +6558,8 @@
   - name: mediawiki/extensions/RelatedArticles
 template:
   - name: extension-unittests-generic
+  - name: mediawiki-core-qunit-selenium-jessie
   - name: mwgate-npm
-test:
-  - mediawiki-core-qunit-selenium-jessie
-gate-and-submit:
-  - mediawiki-core-qunit-selenium-jessie
 
   - name: mediawiki/extensions/RelatedSites
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/384961
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e582b305d687b0d59cd09b74cc58c626ab21404
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: WIP Run Wikibase daily browser tests on Jenkins

2017-10-16 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384500 )

Change subject: WIP Run Wikibase daily browser tests on Jenkins
..

WIP Run Wikibase daily browser tests on Jenkins

BUG: T167432
Change-Id: I7f9b0bab5b4ea4c9f96031cf4b65ed5b51698db3
---
M tests/browser/environments.yml
M tests/browser/features/step_definitions/entity_steps.rb
M tests/browser/features/support/pages/item_page.rb
3 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/00/384500/1

diff --git a/tests/browser/environments.yml b/tests/browser/environments.yml
index 50e0d21..61c8b52 100644
--- a/tests/browser/environments.yml
+++ b/tests/browser/environments.yml
@@ -33,7 +33,7 @@
   browser: firefox
   mediawiki_url: https://wikidata.beta.wmflabs.org/wiki/
   mediawiki_user: Selenium_user
-  user_factory: true
+  user_factory: false
   # mediawiki_password: SET THIS IN THE ENVIRONMENT!
 
 test:
diff --git a/tests/browser/features/step_definitions/entity_steps.rb 
b/tests/browser/features/step_definitions/entity_steps.rb
index 80ebf6a..8602e7c 100644
--- a/tests/browser/features/step_definitions/entity_steps.rb
+++ b/tests/browser/features/step_definitions/entity_steps.rb
@@ -41,7 +41,7 @@
 
 Given(/^I have an item with label "(.*)" and description "(.*)"$/) do |label, 
description|
   item_data = '{"labels":{"en":{"language":"en","value":"' + label + 
'"}},"descriptions":{"en":{"language":"en","value":"' + description + '"}}}'
-  @item_under_test = visit(ItemPage).create_item(item_data)
+  @item_under_test = visit(ItemPage).create_item(item_data, user, password)
 end
 
 Given(/^I am on the page of the item to test$/) do
diff --git a/tests/browser/features/support/pages/item_page.rb 
b/tests/browser/features/support/pages/item_page.rb
index 4dc63e2..78398c4 100644
--- a/tests/browser/features/support/pages/item_page.rb
+++ b/tests/browser/features/support/pages/item_page.rb
@@ -24,8 +24,9 @@
 item_data
   end
 
-  def create_item(data)
+  def create_item(data, user = nil, password = nil)
 wb_api = MediawikiApi::Wikidata::WikidataClient.new URL.repo_api
+wb_api.log_in(user, password) if (user and password)
 resp = wb_api.create_item(data)
 
 id = resp['entity']['id']

-- 
To view, visit https://gerrit.wikimedia.org/r/384500
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f9b0bab5b4ea4c9f96031cf4b65ed5b51698db3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run Selenium tests for Reading Web extension

2017-10-13 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384041 )

Change subject: Run Selenium tests for Reading Web extension
..

Run Selenium tests for Reading Web extension

QuickSurveys, Popups and MobileFrontend should run the
Node.js Selenium tests in experimental pipeline.

Bug: T162256
Change-Id: Ic5759e512d63b5f75c247ccbb2128e1b855c2067
---
M zuul/layout.yaml
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/41/384041/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 91380c7..eea5437 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -3712,6 +3712,7 @@
   - mwext-doxygen-publish
 experimental:
   - mwext-ruby-jessie
+  - mediawiki-core-qunit-selenium-jessie
 
   - name: mediawiki/extensions/MobileApp
 template:
@@ -5201,6 +5202,7 @@
   - name: extension-selenium
 experimental:
   - mwext-ruby-jessie
+  - mediawiki-core-qunit-selenium-jessie
 
   - name: mediawiki/extensions/QuickSearchLookup
 template:
@@ -6522,6 +6524,7 @@
   - name: extension-selenium-gate
   - name: mwgate-npm
 experimental:
+  - mediawiki-core-qunit-selenium-jessie
   - mwext-ruby-jessie
 
   - name: mediawiki/extensions/PostEdit

-- 
To view, visit https://gerrit.wikimedia.org/r/384041
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5759e512d63b5f75c247ccbb2128e1b855c2067
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 
Gerrit-Reviewer: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Popups Selenium tests should run daily targeting beta cluster

2017-10-13 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384030 )

Change subject: Popups Selenium tests should run daily targeting beta cluster
..

Popups Selenium tests should run daily targeting beta cluster

Bug: T177924
Change-Id: I807f184c37c00987098a5aa0bd96dad478894008
---
M jjb/selenium.yaml
M zuul/layout.yaml
2 files changed, 14 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/30/384030/1

diff --git a/jjb/selenium.yaml b/jjb/selenium.yaml
index 852cd9c..da96a67 100644
--- a/jjb/selenium.yaml
+++ b/jjb/selenium.yaml
@@ -94,6 +94,14 @@
  - 'selenium-{name}'
 
 - project:
+name: Popups
+recipients: qa-ale...@lists.wikimedia.org # @jdlrobson
+repository: mediawiki/extensions/Popups
+
+jobs:
+ - 'selenium-{name}'
+
+- project:
 name: QuickSurveys
 recipients: jrob...@wikimedia.org qa-ale...@lists.wikimedia.org # 
@jdlrobson
 repository: mediawiki/extensions/QuickSurveys
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 7e4ab34..91380c7 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -1451,22 +1451,20 @@
   - mwgate-php55lint
   - mwgate-composer-validate
 test:
-  - mwgate-php55lint
-  - mwgate-composer-validate
+  - mwgate-composer-hhvm-jessie
+  - mwgate-composer-php55-jessie
   - mediawiki-core-qunit-selenium-jessie
   - mediawiki-phpunit-hhvm-jessie
 php5:
   - mediawiki-phpunit-php55-jessie
 gate-and-submit: 
-  - mwgate-php55lint
+  - mwgate-composer-hhvm-jessie
+  - mwgate-composer-php55-jessie
   - mediawiki-phpunit-hhvm-jessie
   - mediawiki-phpunit-php55-jessie
   - mediawiki-core-qunit-selenium-jessie
-  - mwgate-composer-validate
 gate-and-submit-swat: *mediawiki-vendor-gate-and-submit
 experimental:
-  - mwgate-composer-hhvm-jessie
-  - mwgate-composer-php55-jessie
   - mwgate-composer-php70-jessie
 
   - name: analytics/aggregator
@@ -6523,6 +6521,8 @@
   - name: extension-qunit-generic
   - name: extension-selenium-gate
   - name: mwgate-npm
+experimental:
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/PostEdit
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/384030
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I807f184c37c00987098a5aa0bd96dad478894008
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 
Gerrit-Reviewer: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run mwext-ruby-jessie job for Popups

2017-10-13 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384014 )

Change subject: Run mwext-ruby-jessie job for Popups
..

Run mwext-ruby-jessie job for Popups

In test and gate-and-submit pipelines.

Bug: T164479
Bug: T177924
Change-Id: If45546c15bd7f8bde615c7904b487e0e33d29bd8
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/14/384014/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 91380c7..19e0e59 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -6520,9 +6520,8 @@
   - name: extension-unittests-generic
   - name: extension-qunit-generic
   - name: extension-selenium-gate
+  - name: mwext-ruby-jessie
   - name: mwgate-npm
-experimental:
-  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/PostEdit
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/384014
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If45546c15bd7f8bde615c7904b487e0e33d29bd8
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run mwext-ruby-jessie Popups

2017-10-13 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/384005 )

Change subject: Run mwext-ruby-jessie Popups
..

Run mwext-ruby-jessie Popups

In experimental pipeline for now.

Bug: T177924
Bug: T164479
Change-Id: Iec5e48bcdf68ec568c8f01fe6d848948e2b9ecd4
---
M zuul/layout.yaml
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/05/384005/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 1c3703c..91380c7 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -6521,6 +6521,8 @@
   - name: extension-qunit-generic
   - name: extension-selenium-gate
   - name: mwgate-npm
+experimental:
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/PostEdit
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/384005
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec5e48bcdf68ec568c8f01fe6d848948e2b9ecd4
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: WIP selenium-RelatedArticles-jessie needs passwords

2017-10-12 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383887 )

Change subject: WIP selenium-RelatedArticles-jessie needs passwords
..

WIP selenium-RelatedArticles-jessie needs passwords

Bug: T176315
Change-Id: I7e88fa291b2f5b334ed36371ae9a770d19d961da
---
M jjb/mediawiki-extensions.yaml
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/87/383887/1

diff --git a/jjb/mediawiki-extensions.yaml b/jjb/mediawiki-extensions.yaml
index 5fb7645..21ec2ab 100644
--- a/jjb/mediawiki-extensions.yaml
+++ b/jjb/mediawiki-extensions.yaml
@@ -494,6 +494,9 @@
  . /srv/deployment/integration/slave-scripts/bin/mw-set-env.sh
  chromedriver --url-base=/wd/hub --port= &
  cd $MW_INSTALL_PATH
+ set +x
+ export MEDIAWIKI_PASSWORD="$selenium_user_beta"
+ set -x
  MEDIAWIKI_USER='Selenium user' 
MW_SERVER=https://en.wikipedia.beta.wmflabs.org:443 MW_SCRIPT_PATH=/w 
./node_modules/.bin/wdio tests/selenium/wdio.conf.jenkins.js --spec 
extensions/RelatedArticles/tests/selenium/specs/*.js
  - assert-no-mediawiki-errors
 publishers:

-- 
To view, visit https://gerrit.wikimedia.org/r/383887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e88fa291b2f5b334ed36371ae9a770d19d961da
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: WIP Logging in failed: Failed

2017-10-05 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/382459 )

Change subject: WIP Logging in failed: Failed
..

WIP Logging in failed: Failed

Bug: T176315
Change-Id: I61b0c476604fa6f7df7d906d6f10bc9710c72421
---
M tests/selenium/pageobjects/edit.page.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/59/382459/1

diff --git a/tests/selenium/pageobjects/edit.page.js 
b/tests/selenium/pageobjects/edit.page.js
index 34f4263..de6511f 100644
--- a/tests/selenium/pageobjects/edit.page.js
+++ b/tests/selenium/pageobjects/edit.page.js
@@ -29,7 +29,7 @@
path: baseUrl.path,
username: browser.options.username,
password: browser.options.password,
-   debug: false
+   debug: true
} );
 
return new Promise( ( resolve, reject ) => {

-- 
To view, visit https://gerrit.wikimedia.org/r/382459
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61b0c476604fa6f7df7d906d6f10bc9710c72421
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: WIP Mocha tests for Echo notifications

2017-10-04 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/382183 )

Change subject: WIP Mocha tests for Echo notifications
..

WIP Mocha tests for Echo notifications

Bug: T177412
Change-Id: Ia68c2a26240cc5a07f2122a5f3a6caa0f199a313
---
M Gruntfile.js
M package.json
A tests/mocha/.eslintrc.json
A tests/mocha/README.md
A tests/mocha/notifications.js
5 files changed, 94 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/83/382183/1

diff --git a/Gruntfile.js b/Gruntfile.js
index c389ce1..8660b07 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -49,4 +49,5 @@
grunt.registerTask( 'lint', [ 'eslint', 'stylelint', 'jsonlint', 
'banana' ] );
grunt.registerTask( 'test', 'lint' );
grunt.registerTask( 'default', 'test' );
+   // TODO: grunt.registerTask( 'mocha', 'mocha' );
 };
diff --git a/package.json b/package.json
index bd5d5e9..52f7c80 100644
--- a/package.json
+++ b/package.json
@@ -5,7 +5,8 @@
"description": "Build tools for Echo.",
"scripts": {
"test": "grunt test",
-   "doc": "jsduck"
+   "doc": "jsduck",
+   "mocha": "grunt mocha"
},
"devDependencies": {
"eslint-config-wikimedia": "0.4.0",
@@ -15,6 +16,8 @@
"grunt-eslint": "19.0.0",
"grunt-jsonlint": "1.0.8",
"grunt-stylelint": "0.7.0",
+   "mocha": "4.0.0",
+   "nodemw": "0.11.0",
"stylelint": "7.8.0",
"stylelint-config-wikimedia": "0.4.1"
}
diff --git a/tests/mocha/.eslintrc.json b/tests/mocha/.eslintrc.json
new file mode 100644
index 000..db736b7
--- /dev/null
+++ b/tests/mocha/.eslintrc.json
@@ -0,0 +1,17 @@
+{
+   "extends": "../../.eslintrc.json",
+   "env": {
+   "es6": true,
+   "mocha": true,
+   "node": true
+   },
+   "parserOptions": {
+   "ecmaVersion": 6
+   },
+   "globals": {
+   "browser": false
+   },
+   "rules":{
+   "no-console":0
+   }
+}
diff --git a/tests/mocha/README.md b/tests/mocha/README.md
new file mode 100644
index 000..5ae0cd8
--- /dev/null
+++ b/tests/mocha/README.md
@@ -0,0 +1,10 @@
+# Usage
+
+cd mediawiki/vagrant
+vagrant up
+vagrant roles enable echo flow wikimediaflow
+vagrant provision
+
+cd mediawiki/extensions/Echo
+npm install
+npm run mocha
diff --git a/tests/mocha/notifications.js b/tests/mocha/notifications.js
new file mode 100644
index 000..e25194e
--- /dev/null
+++ b/tests/mocha/notifications.js
@@ -0,0 +1,62 @@
+'use strict';
+const assert = require( 'assert' );
+
+describe( 'Echo', function () {
+
+   it( 'should notify a new user with welcome message', function () {
+
+   function apiCreateAccount( username, password ) {
+   const url = require( 'url' ), // 
https://nodejs.org/docs/latest/api/url.html
+   baseUrl = url.parse( browser.options.baseUrl ), 
// http://webdriver.io/guide/testrunner/browserobject.html
+   Bot = require( 'nodemw' ), // 
https://github.com/macbre/nodemw
+   client = new Bot( {
+   protocol: baseUrl.protocol,
+   server: baseUrl.hostname,
+   port: baseUrl.port,
+   path: baseUrl.path,
+   debug: false
+   } );
+
+   return new Promise( ( resolve, reject ) => {
+   client.api.call(
+   {
+   action: 'query',
+   meta: 'tokens',
+   type: 'createaccount'
+   },
+   /**
+* @param {Error|null} err
+* @param {Object} info Processed query 
result
+* @param {Object} next More results?
+* @param {Object} data Raw data
+*/
+   function ( err, info, next, data ) {
+   if ( err ) {
+   reject( err );
+   return;
+   }
+   client.api.call( {
+

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Selenium tests should log in before creating pages

2017-10-03 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381948 )

Change subject: Selenium tests should log in before creating pages
..

Selenium tests should log in before creating pages

MediaWiki Vagrant by default allows creating pages to anonymous users, but 
other environments, like Beta Cluster, require user to log in before creating 
pages.

Bug: T176315
Change-Id: I34eeaf3cc22a64be6580aa483b28885137ba60b6
---
M tests/selenium/pageobjects/edit.page.js
M tests/selenium/wdio.conf.jenkins.js
2 files changed, 17 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/48/381948/1

diff --git a/tests/selenium/pageobjects/edit.page.js 
b/tests/selenium/pageobjects/edit.page.js
index 25da8cb..1b86926 100644
--- a/tests/selenium/pageobjects/edit.page.js
+++ b/tests/selenium/pageobjects/edit.page.js
@@ -27,15 +27,23 @@
server: baseUrl.hostname,
port: baseUrl.port,
path: baseUrl.path,
+   username: browser.options.username,
+   password: browser.options.password,
debug: false
} );
 
return new Promise( ( resolve, reject ) => {
-   client.edit( name, content, `Created page with 
"${content}"`, function ( err ) {
+   client.logIn( function ( err ) {
if ( err ) {
-   return reject( err );
+   console.log( err );
+   return;
}
-   resolve();
+   client.edit( name, content, `Created page with 
"${content}"`, function ( err ) {
+   if ( err ) {
+   return reject( err );
+   }
+   resolve();
+   } );
} );
} );
}
diff --git a/tests/selenium/wdio.conf.jenkins.js 
b/tests/selenium/wdio.conf.jenkins.js
index 6049eb2..cbec7a4 100644
--- a/tests/selenium/wdio.conf.jenkins.js
+++ b/tests/selenium/wdio.conf.jenkins.js
@@ -6,8 +6,12 @@
 
 // Overwrite default settings
 exports.config = merge( wdioConf.config, {
-   username: 'WikiAdmin',
-   password: 'testpass',
+   username: process.env.MEDIAWIKI_USER === undefined ?
+   'WikiAdmin' :
+   process.env.MEDIAWIKI_USER,
+   password: process.env.MEDIAWIKI_PASSWORD === undefined ?
+   'testpass' :
+   process.env.MEDIAWIKI_PASSWORD,
screenshotPath: '../log/',
baseUrl: process.env.MW_SERVER + process.env.MW_SCRIPT_PATH,
 

-- 
To view, visit https://gerrit.wikimedia.org/r/381948
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I34eeaf3cc22a64be6580aa483b28885137ba60b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run mediawiki-core-qunit-selenium-jessie for CirrusSearch

2017-10-02 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381791 )

Change subject: Run mediawiki-core-qunit-selenium-jessie for CirrusSearch
..

Run mediawiki-core-qunit-selenium-jessie for CirrusSearch

Only in experimental pipeline for now.

Bug: T174103
Change-Id: Ib0bf64ace4d8916efdc998d7f58a0b23bf06d460
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/91/381791/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 3c9d524..f37c889 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -2809,6 +2809,7 @@
 test:
   - mwext-CirrusSearch-whitespaces
 experimental:
+  - mediawiki-core-qunit-selenium-jessie
   - mwext-ruby-jessie
 
   - name: mediawiki/extensions/CleanChanges

-- 
To view, visit https://gerrit.wikimedia.org/r/381791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0bf64ace4d8916efdc998d7f58a0b23bf06d460
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: WIP The first Selenium test in Node.js

2017-10-02 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381785 )

Change subject: WIP The first Selenium test in Node.js
..

WIP The first Selenium test in Node.js

Bug: T174103
Change-Id: Ide184939aa95f42cfc65a2ec80f1ae5e3ad899be
---
A tests/selenium/pageobjects/main.page.js
A tests/selenium/specs/search.js
2 files changed, 36 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/85/381785/1

diff --git a/tests/selenium/pageobjects/main.page.js 
b/tests/selenium/pageobjects/main.page.js
new file mode 100644
index 000..da38576
--- /dev/null
+++ b/tests/selenium/pageobjects/main.page.js
@@ -0,0 +1,20 @@
+'use strict';
+const Page = require( '../../../../../tests/selenium/pageobjects/page' );
+
+class MainPage extends Page {
+
+   get heading() { return browser.element( '#firstHeading' ); }
+   get searchButton() { return browser.element( '#searchButton' ); }
+   get searchInput() { return browser.element( '#searchInput' ); }
+
+   open() {
+   super.open( 'Main_Page' );
+   }
+
+   search( string ) {
+   this.searchInput.setValue( string );
+   this.searchButton.click;
+   }
+
+}
+module.exports = new MainPage();
diff --git a/tests/selenium/specs/search.js b/tests/selenium/specs/search.js
new file mode 100644
index 000..42e8962
--- /dev/null
+++ b/tests/selenium/specs/search.js
@@ -0,0 +1,16 @@
+'use strict';
+var assert = require( 'assert' ),
+   MainPage = require( '../pageobjects/main.page' );
+
+describe( 'Search', function () {
+
+   it( 'should find Main page', function () {
+
+   let string = 'Main Page';
+   MainPage.open();
+   MainPage.search( string );
+   assert.equal( MainPage.heading.getText(), string );
+
+   } );
+
+} );

-- 
To view, visit https://gerrit.wikimedia.org/r/381785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide184939aa95f42cfc65a2ec80f1ae5e3ad899be
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ZeroPortal[master]: Deleted all Ruby code

2017-10-02 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381774 )

Change subject: Deleted all Ruby code
..

Deleted all Ruby code

The only Ruby code were broken Selenium tests.

Bug: T164479
Change-Id: I6ca8146b285fc14e2579682707722fb739b6ac80
---
D .rubocop.yml
D .rubocop_todo.yml
D Gemfile
D Gemfile.lock
D Rakefile
D tests/browser/README
D tests/browser/cucumber_anon_prod.bash
D tests/browser/cucumber_partner_prod.bash
D tests/browser/environments.yml
D tests/browser/features/header.feature
D tests/browser/features/home.feature
D tests/browser/features/step_definitions/common_steps.rb
D tests/browser/features/step_definitions/header_steps.rb
D tests/browser/features/step_definitions/home_steps.rb
D tests/browser/features/support/env.rb
D tests/browser/features/support/pages/dashboard_page.rb
D tests/browser/features/support/pages/faq_page.rb
D tests/browser/features/support/pages/home_page.rb
D tests/browser/features/support/pages/logout_page.rb
D tests/browser/features/support/pages/news_page.rb
D tests/browser/features/support/pages/register_page.rb
D tests/browser/features/support/pages/studies_page.rb
22 files changed, 0 insertions(+), 565 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroPortal 
refs/changes/74/381774/1

diff --git a/.rubocop.yml b/.rubocop.yml
deleted file mode 100644
index cc32da4..000
--- a/.rubocop.yml
+++ /dev/null
@@ -1 +0,0 @@
-inherit_from: .rubocop_todo.yml
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
deleted file mode 100644
index 5b55f00..000
--- a/.rubocop_todo.yml
+++ /dev/null
@@ -1,47 +0,0 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2014-10-21 17:47:58 +0200 using RuboCop version 0.26.1.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 13
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
-
-# Offense count: 1
-# Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
-  Max: 93
-
-# Offense count: 8
-Style/Documentation:
-  Enabled: false
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/HashSyntax:
-  Enabled: false
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/LeadingCommentSpace:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/RedundantSelf:
-  Enabled: false
-
-# Offense count: 27
-# Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles.
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/TrailingBlankLines:
-  Enabled: false
diff --git a/Gemfile b/Gemfile
deleted file mode 100644
index 09940bc..000
--- a/Gemfile
+++ /dev/null
@@ -1,5 +0,0 @@
-source "https://rubygems.org;
-
-gem "mediawiki_selenium", "~> 1.7", ">= 1.7.1"
-gem "rake", "~> 10.4", ">= 10.4.2"
-gem "rubocop", "~> 0.28.0", require: false
diff --git a/Gemfile.lock b/Gemfile.lock
deleted file mode 100644
index 43df34c..000
--- a/Gemfile.lock
+++ /dev/null
@@ -1,102 +0,0 @@
-GEM
-  remote: https://rubygems.org/
-  specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
-builder (3.2.2)
-childprocess (0.5.9)
-  ffi (~> 1.0, >= 1.0.11)
-cucumber (1.3.20)
-  builder (>= 2.1.2)
-  diff-lcs (>= 1.1.3)
-  gherkin (~> 2.12)
-  multi_json (>= 1.7.5, < 2.0)
-  multi_test (>= 0.1.2)
-data_magic (0.22)
-  faker (>= 1.1.2)
-  yml_reader (>= 0.6)
-diff-lcs (1.2.5)
-domain_name (0.5.20160310)
-  unf (>= 0.0.5, < 1.0.0)
-faker (1.6.3)
-  i18n (~> 0.5)
-faraday (0.9.2)
-  multipart-post (>= 1.2, < 3)
-faraday-cookie_jar (0.0.6)
-  faraday (>= 0.7.4)
-  http-cookie (~> 1.0.0)
-ffi (1.9.10)
-gherkin (2.12.2)
-  multi_json (~> 1.3)
-headless (2.2.3)
-http-cookie (1.0.2)
-  domain_name (~> 0.5)
-i18n (0.7.0)
-json (1.8.3)
-mediawiki_api (0.6.0)
-  faraday (~> 0.9, >= 0.9.0)
-  faraday-cookie_jar (~> 0.0, >= 0.0.6)
-mediawiki_selenium (1.7.1)
-  cucumber (~> 1.3, >= 1.3.20)
-  headless (~> 2.0, >= 2.1.0)
-  json (~> 1.8, >= 1.8.1)
-  mediawiki_api (~> 0.6, >= 0.6.0)
-  page-object (~> 1.0)
-  rest-client (~> 1.6, >= 1.6.7)
-  rspec-core (~> 2.14, >= 2.14.4)
-  rspec-expectations (~> 2.14, >= 2.14.4)
-  syntax (~> 1.2, >= 1.2.0)
-  thor (~> 0.19, >= 0.19.1)
-mime-types (2.99.2)
-multi_json (1.12.1)
-multi_test (0.1.2)
-multipart-post (2.0.0)
-netrc (0.11.0)
-page-object (1.1.1)
-  page_navigation (>= 0.9)
-  selenium-webdriver

[MediaWiki-commits] [Gerrit] integration/config[master]: Deleted Ruby jobs for ZeroPortal

2017-10-02 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381773 )

Change subject: Deleted Ruby jobs for ZeroPortal
..

Deleted Ruby jobs for ZeroPortal

Bug: T164479
Change-Id: I69954d69fa6a135c01ec77014d75777677944ca4
---
M zuul/layout.yaml
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/73/381773/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 5bb5b99..3c9d524 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -7064,10 +7064,7 @@
   - name: mediawiki/extensions/ZeroPortal
 template:
   - name: extension-gate
-  - name: mwgate-rake
   - name: mwgate-npm
-experimental:
-  - mwext-ruby-jessie
 
  PHP Extensions ###
 

-- 
To view, visit https://gerrit.wikimedia.org/r/381773
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69954d69fa6a135c01ec77014d75777677944ca4
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: Deleted all Ruby code

2017-09-29 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381481 )

Change subject: Deleted all Ruby code
..

Deleted all Ruby code

The only Ruby code were broken Selenium tests.

Bug: T164479
Depends-On: Ic14b86a5006da360d022af875b4aa8c119a3678a
Change-Id: I15f641cd08ec3ba483c11764a89c9ed493a570a8
---
M .gitignore
D .rubocop.yml
D .rubocop_todo.yml
D Gemfile
D Gemfile.lock
D Rakefile
D tests/browser/README.md
D tests/browser/environments.yml
D tests/browser/features/accept_language.feature
D tests/browser/features/autonym.feature
D tests/browser/features/font_selection_default_disabled.feature
D tests/browser/features/font_selection_default_enabled.feature
D tests/browser/features/ime.feature
D tests/browser/features/live_preview_of_display_language.feature
D tests/browser/features/persistent_settings.feature
D tests/browser/features/settings_panel.feature
D tests/browser/features/step_definitions/accept_language_steps.rb
D tests/browser/features/step_definitions/autonym_steps.rb
D tests/browser/features/step_definitions/cog_sidebar_user_steps.rb
D tests/browser/features/step_definitions/common_steps.rb
D tests/browser/features/step_definitions/font_selection_steps.rb
D tests/browser/features/step_definitions/ime_steps.rb
D 
tests/browser/features/step_definitions/live_preview_of_display_language_steps.rb
D tests/browser/features/step_definitions/panel_steps.rb
D tests/browser/features/step_definitions/persistent_settings_steps.rb
D tests/browser/features/step_definitions/textarea_font_steps.rb
D tests/browser/features/step_definitions/triggers_steps.rb
D tests/browser/features/support/env.rb
D tests/browser/features/support/hooks.rb
D tests/browser/features/support/modules/interlanguage_module.rb
D tests/browser/features/support/modules/language_module.rb
D tests/browser/features/support/pages/edit_page.rb
D tests/browser/features/support/pages/ime_page.rb
D tests/browser/features/support/pages/interlanguage_page.rb
D tests/browser/features/support/pages/main_page.rb
D tests/browser/features/support/pages/no_interlanguage_page.rb
D tests/browser/features/support/pages/panel_page.rb
D tests/browser/features/support/pages/preferences_page.rb
D tests/browser/features/textarea_font.feature
D tests/browser/features/triggers.feature
D tests/browser/tags.txt
41 files changed, 0 insertions(+), 1,442 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/81/381481/1

diff --git a/.gitignore b/.gitignore
index aa10366..0a78e72 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,7 +3,6 @@
 *.kate-swp
 .*.swp
 .idea
-.bundle/
 node_modules/
 composer.lock
 vendor/
diff --git a/.rubocop.yml b/.rubocop.yml
deleted file mode 100644
index dba873d..000
--- a/.rubocop.yml
+++ /dev/null
@@ -1,23 +0,0 @@
-inherit_from: .rubocop_todo.yml
-
-AllCops:
-  StyleGuideCopsOnly: true
-
-# Uncomment when the repository is cleaned up
-# Metrics/LineLength:
-#   Max: 100
-
-Metrics/MethodLength:
-  Enabled: false
-
-Style/Alias:
-  Enabled: false
-
-Style/SignalException:
-  Enabled: false
-
-Style/StringLiterals:
-  EnforcedStyle: single_quotes
-
-Style/TrivialAccessors:
-  ExactNameMatch: true
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
deleted file mode 100644
index 3c6d952..000
--- a/.rubocop_todo.yml
+++ /dev/null
@@ -1,18 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2015-11-18 11:57:22 +0100 using RuboCop version 0.35.1.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 18
-# Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
-  Max: 168
-
-# Offense count: 1
-# Configuration parameters: AllowedVariables.
-Style/GlobalVars:
-  Exclude:
-- 'tests/browser/features/step_definitions/accept_language_steps.rb'
diff --git a/Gemfile b/Gemfile
deleted file mode 100644
index 265852f..000
--- a/Gemfile
+++ /dev/null
@@ -1,4 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'mediawiki_selenium', '~> 1.7', '>= 1.7.1'
-gem 'rubocop', '~> 0.35.1', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
deleted file mode 100644
index 1c8d793..000
--- a/Gemfile.lock
+++ /dev/null
@@ -1,102 +0,0 @@
-GEM
-  remote: https://rubygems.org/
-  specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
-builder (3.2.2)
-childprocess (0.5.9)
-  ffi (~> 1.0, >= 1.0.11)
-cucumber (1.3.20)
-  builder (>= 2.1.2)
-  diff-lcs (>= 1.1.3)
-  gherkin (~> 2.12)
-  multi_json (>= 1.7.5, < 2.0)
-  multi_test (>= 0.1.2)
-data_magic (0.22)
-  faker (>= 1.1.2)
-  yml_reader (>= 0.6)
-diff-lcs (1.2.5)
-domain_name (0.5.20160310)
-  unf (>=

[MediaWiki-commits] [Gerrit] integration/config[master]: Deleted Ruby jobs for UniversalLanguageSelector

2017-09-29 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381480 )

Change subject: Deleted Ruby jobs for UniversalLanguageSelector
..

Deleted Ruby jobs for UniversalLanguageSelector

Bug: T164479
Change-Id: Ic14b86a5006da360d022af875b4aa8c119a3678a
---
M zuul/layout.yaml
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/80/381480/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index af75e90..c04ebeb 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -6850,11 +6850,8 @@
   - name: mediawiki/extensions/UniversalLanguageSelector
 template:
   - name: extension-gate
-  - name: mwgate-rake
   - name: extension-unittests-generic
   - name: mwgate-npm
-experimental:
-  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/UploadBlacklist
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/381480
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic14b86a5006da360d022af875b4aa8c119a3678a
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TwnMainPage[master]: Deleted all Ruby code

2017-09-29 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381478 )

Change subject: Deleted all Ruby code
..

Deleted all Ruby code

The only Ruby code were broken Selenium tests.

Bug: T164479
Depends-On: Iec1100b8c3911254542264b89f6e4a0a8b87c4c8
Change-Id: Ibcb7fdd21a6f23476303a1b463ae368767127ffb
---
D .rubocop.yml
D Gemfile
D Gemfile.lock
D Rakefile
D tests/browser/README.md
D tests/browser/environments.yml
D tests/browser/features/signed_in_and_approved_users.feature
D tests/browser/features/signed_in_source_language.feature
D tests/browser/features/signup.feature
D tests/browser/features/step_definitions/common_steps.rb
D tests/browser/features/step_definitions/signed_in_and_approved_user_steps.rb
D tests/browser/features/step_definitions/signed_in_source_language_steps.rb
D tests/browser/features/step_definitions/signup_steps.rb
D tests/browser/features/support/env.rb
D tests/browser/features/support/pages/main_page.rb
D tests/browser/features/support/pages/preferences_page.rb
D tests/browser/features/support/pages/search_page.rb
D tests/browser/features/support/pages/signup_page.rb
D tests/browser/features/support/pages/translate_page.rb
D tests/browser/features/user_not_signed_in.feature
D tests/browser/features/user_signed_in_not_approved.feature
D tests/browser/tags.txt
22 files changed, 0 insertions(+), 628 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TwnMainPage 
refs/changes/78/381478/1

diff --git a/.rubocop.yml b/.rubocop.yml
deleted file mode 100644
index 84567a5..000
--- a/.rubocop.yml
+++ /dev/null
@@ -1,20 +0,0 @@
-AllCops:
-  StyleGuideCopsOnly: true
-
-Metrics/LineLength:
-  Max: 100
-
-Metrics/MethodLength:
-  Enabled: false
-
-Style/Alias:
-  Enabled: false
-
-Style/SignalException:
-  Enabled: false
-
-Style/StringLiterals:
-  EnforcedStyle: single_quotes
-
-Style/TrivialAccessors:
-  ExactNameMatch: true
diff --git a/Gemfile b/Gemfile
deleted file mode 100755
index 265852f..000
--- a/Gemfile
+++ /dev/null
@@ -1,4 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'mediawiki_selenium', '~> 1.7', '>= 1.7.1'
-gem 'rubocop', '~> 0.35.1', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
deleted file mode 100644
index 1c8d793..000
--- a/Gemfile.lock
+++ /dev/null
@@ -1,102 +0,0 @@
-GEM
-  remote: https://rubygems.org/
-  specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
-builder (3.2.2)
-childprocess (0.5.9)
-  ffi (~> 1.0, >= 1.0.11)
-cucumber (1.3.20)
-  builder (>= 2.1.2)
-  diff-lcs (>= 1.1.3)
-  gherkin (~> 2.12)
-  multi_json (>= 1.7.5, < 2.0)
-  multi_test (>= 0.1.2)
-data_magic (0.22)
-  faker (>= 1.1.2)
-  yml_reader (>= 0.6)
-diff-lcs (1.2.5)
-domain_name (0.5.20160310)
-  unf (>= 0.0.5, < 1.0.0)
-faker (1.6.3)
-  i18n (~> 0.5)
-faraday (0.9.2)
-  multipart-post (>= 1.2, < 3)
-faraday-cookie_jar (0.0.6)
-  faraday (>= 0.7.4)
-  http-cookie (~> 1.0.0)
-ffi (1.9.10)
-gherkin (2.12.2)
-  multi_json (~> 1.3)
-headless (2.2.3)
-http-cookie (1.0.2)
-  domain_name (~> 0.5)
-i18n (0.7.0)
-json (1.8.3)
-mediawiki_api (0.6.0)
-  faraday (~> 0.9, >= 0.9.0)
-  faraday-cookie_jar (~> 0.0, >= 0.0.6)
-mediawiki_selenium (1.7.1)
-  cucumber (~> 1.3, >= 1.3.20)
-  headless (~> 2.0, >= 2.1.0)
-  json (~> 1.8, >= 1.8.1)
-  mediawiki_api (~> 0.6, >= 0.6.0)
-  page-object (~> 1.0)
-  rest-client (~> 1.6, >= 1.6.7)
-  rspec-core (~> 2.14, >= 2.14.4)
-  rspec-expectations (~> 2.14, >= 2.14.4)
-  syntax (~> 1.2, >= 1.2.0)
-  thor (~> 0.19, >= 0.19.1)
-mime-types (2.99.2)
-multi_json (1.12.1)
-multi_test (0.1.2)
-multipart-post (2.0.0)
-netrc (0.11.0)
-page-object (1.1.1)
-  page_navigation (>= 0.9)
-  selenium-webdriver (>= 2.44.0)
-  watir-webdriver (>= 0.6.11)
-page_navigation (0.9)
-  data_magic (>= 0.14)
-parser (2.2.3.0)
-  ast (>= 1.1, < 3.0)
-powerpack (0.1.1)
-rainbow (2.0.0)
-rest-client (1.8.0)
-  http-cookie (>= 1.0.2, < 2.0)
-  mime-types (>= 1.16, < 3.0)
-  netrc (~> 0.7)
-rspec-core (2.99.2)
-rspec-expectations (2.99.2)
-  diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.35.1)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.3.0, < 3.0)
-  powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
-  ruby-progressbar (~> 1.7)
-  tins (<= 1.6.0)
-ruby-progressbar (1.7.5)
-rubyzip (1.2.0)
-selenium-webdriver (2.53.0)
-  childprocess (~> 0.5)
-  rubyzip (~> 1.0)
-  websocket (~> 1.0)
-syntax (1.2.0)
-thor (0.19.1)
-tins (1.6.0)
-unf (0.1.4)
-  unf_ext
-unf_ext (0.0.7.2)
-watir-webdriver (0.9.1)
-  selenium-webdriver (>= 2.46.2)
-websocket (1.2.3)
-yml_reader (0.7)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-

[MediaWiki-commits] [Gerrit] integration/config[master]: Deleted Ruby jobs for TwnMainPage

2017-09-29 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381471 )

Change subject: Deleted Ruby jobs for TwnMainPage
..

Deleted Ruby jobs for TwnMainPage

Bug: T164479
Change-Id: Iec1100b8c3911254542264b89f6e4a0a8b87c4c8
---
M zuul/layout.yaml
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/71/381471/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 5282cfa..270b98b 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -6826,11 +6826,8 @@
 
   - name: mediawiki/extensions/TwnMainPage
 template:
-  - name: mwgate-rake
   - name: extension-unittests-generic
   - name: mwgate-npm
-experimental:
-  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/OpenBadges
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/381471
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec1100b8c3911254542264b89f6e4a0a8b87c4c8
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Deleted Ruby jobs for Translate

2017-09-29 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381468 )

Change subject: Deleted Ruby jobs for Translate
..

Deleted Ruby jobs for Translate

Bug: T164479
Change-Id: I3d830320891d400fb78ff5f4c97859443983d257
---
M zuul/layout.yaml
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/68/381468/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 5282cfa..bf9f9d9 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -6804,10 +6804,7 @@
   - name: mediawiki/extensions/Translate
 template:
   - name: extension-gate
-  - name: mwgate-rake
   - name: mwgate-npm
-experimental:
-  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/TranslationNotifications
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/381468
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d830320891d400fb78ff5f4c97859443983d257
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Deleted all Ruby code

2017-09-29 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381467 )

Change subject: Deleted all Ruby code
..

Deleted all Ruby code

The only Ruby code were broken Selenium tests.

Bug: T164479
Change-Id: I7506dfb6250237f45dcea5c4dc64a864fa321732
---
D .rubocop.yml
D .rubocop_todo.yml
D Gemfile
D Gemfile.lock
D Rakefile
D tests/browser/README.md
D tests/browser/environments.yml
D tests/browser/features/manage_translator_sandbox.feature
D tests/browser/features/special_translate.feature
D tests/browser/features/step_definitions/manage_translator_sandbox_steps.rb
D tests/browser/features/step_definitions/special_translate_steps.rb
D tests/browser/features/step_definitions/translation_stash_steps.rb
D tests/browser/features/support/env.rb
D tests/browser/features/support/hooks.rb
D tests/browser/features/support/pages/manage_translator_sandbox_page.rb
D tests/browser/features/support/pages/stash_page.rb
D tests/browser/features/support/pages/translate_page.rb
D tests/browser/features/support/pages/user_page.rb
D tests/browser/features/translation_stash.feature
19 files changed, 0 insertions(+), 1,062 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/67/381467/1

diff --git a/.rubocop.yml b/.rubocop.yml
deleted file mode 100644
index 9f1c7c0..000
--- a/.rubocop.yml
+++ /dev/null
@@ -1,28 +0,0 @@
-inherit_from: .rubocop_todo.yml
-
-AllCops:
-  Exclude:
-- 'extensions/**/*'
-- 'vendor/**/*'
-
-AllCops:
-  StyleGuideCopsOnly: true
-
-# Uncomment when lines are under 100 lenghth
-# Metrics/LineLength:
-#   Max: 100
-
-Metrics/MethodLength:
-  Enabled: false
-
-Style/Alias:
-  Enabled: false
-
-Style/SignalException:
-  Enabled: false
-
-Style/StringLiterals:
-  EnforcedStyle: single_quotes
-
-Style/TrivialAccessors:
-  ExactNameMatch: true
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
deleted file mode 100644
index 821f13b..000
--- a/.rubocop_todo.yml
+++ /dev/null
@@ -1,12 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2015-11-09 14:28:59 +0100 using RuboCop version 0.34.2.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 48
-# Configuration parameters: AllowURI, URISchemes.
-Metrics/LineLength:
-  Max: 127
diff --git a/Gemfile b/Gemfile
deleted file mode 100644
index ae4f910..000
--- a/Gemfile
+++ /dev/null
@@ -1,4 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'mediawiki_selenium', '~> 1.7', '>= 1.7.1'
-gem 'rubocop', '~> 0.34.2', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
deleted file mode 100644
index 28af83f..000
--- a/Gemfile.lock
+++ /dev/null
@@ -1,100 +0,0 @@
-GEM
-  remote: https://rubygems.org/
-  specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
-builder (3.2.2)
-childprocess (0.5.9)
-  ffi (~> 1.0, >= 1.0.11)
-cucumber (1.3.20)
-  builder (>= 2.1.2)
-  diff-lcs (>= 1.1.3)
-  gherkin (~> 2.12)
-  multi_json (>= 1.7.5, < 2.0)
-  multi_test (>= 0.1.2)
-data_magic (0.22)
-  faker (>= 1.1.2)
-  yml_reader (>= 0.6)
-diff-lcs (1.2.5)
-domain_name (0.5.20160310)
-  unf (>= 0.0.5, < 1.0.0)
-faker (1.6.3)
-  i18n (~> 0.5)
-faraday (0.9.2)
-  multipart-post (>= 1.2, < 3)
-faraday-cookie_jar (0.0.6)
-  faraday (>= 0.7.4)
-  http-cookie (~> 1.0.0)
-ffi (1.9.10)
-gherkin (2.12.2)
-  multi_json (~> 1.3)
-headless (2.2.3)
-http-cookie (1.0.2)
-  domain_name (~> 0.5)
-i18n (0.7.0)
-json (1.8.3)
-mediawiki_api (0.6.0)
-  faraday (~> 0.9, >= 0.9.0)
-  faraday-cookie_jar (~> 0.0, >= 0.0.6)
-mediawiki_selenium (1.7.1)
-  cucumber (~> 1.3, >= 1.3.20)
-  headless (~> 2.0, >= 2.1.0)
-  json (~> 1.8, >= 1.8.1)
-  mediawiki_api (~> 0.6, >= 0.6.0)
-  page-object (~> 1.0)
-  rest-client (~> 1.6, >= 1.6.7)
-  rspec-core (~> 2.14, >= 2.14.4)
-  rspec-expectations (~> 2.14, >= 2.14.4)
-  syntax (~> 1.2, >= 1.2.0)
-  thor (~> 0.19, >= 0.19.1)
-mime-types (2.99.2)
-multi_json (1.12.1)
-multi_test (0.1.2)
-multipart-post (2.0.0)
-netrc (0.11.0)
-page-object (1.1.1)
-  page_navigation (>= 0.9)
-  selenium-webdriver (>= 2.44.0)
-  watir-webdriver (>= 0.6.11)
-page_navigation (0.9)
-  data_magic (>= 0.14)
-parser (2.2.3.0)
-  ast (>= 1.1, < 3.0)
-powerpack (0.1.1)
-rainbow (2.0.0)
-rest-client (1.8.0)
-  http-cookie (>= 1.0.2, < 2.0)
-  mime-types (>= 1.16, < 3.0)
-  netrc (~> 0.7)
-rspec-core (2.99.2)
-rspec-expectations (2.99.2)
-  diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.34.2)
-  astrolabe (~> 1.3)

[MediaWiki-commits] [Gerrit] integration/config[master]: Deleted Ruby jobs for PdfHandler

2017-09-29 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381466 )

Change subject: Deleted Ruby jobs for PdfHandler
..

Deleted Ruby jobs for PdfHandler

Bug: T164479
Change-Id: Iad63ea7eba88e9eb2925f43b2cb00a00c791c28a
---
M zuul/layout.yaml
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/66/381466/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 5282cfa..50e27f1 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -6430,10 +6430,7 @@
   - name: mediawiki/extensions/PdfHandler
 template:
   - name: extension-gate
-  - name: mwgate-rake
   - name: mwgate-npm
-experimental:
-  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/PerformanceInspector
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/381466
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad63ea7eba88e9eb2925f43b2cb00a00c791c28a
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PdfHandler[master]: Deleted all Ruby code

2017-09-29 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381465 )

Change subject: Deleted all Ruby code
..

Deleted all Ruby code

The only Ruby code were broken Selenium tests.

Bug: T164479
Change-Id: Ieb08e038eebb695783c5b1a28b3459aecd340017
---
D .rubocop.yml
D Gemfile
D Gemfile.lock
D Rakefile
D tests/browser/ci.yml
D tests/browser/environments.yml
D tests/browser/features/pdf.feature
D tests/browser/features/step_definitions/pdf_steps.rb
D tests/browser/features/support/env.rb
D tests/browser/features/support/pages/random_page.rb
10 files changed, 0 insertions(+), 222 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PdfHandler 
refs/changes/65/381465/1

diff --git a/.rubocop.yml b/.rubocop.yml
deleted file mode 100644
index 84567a5..000
--- a/.rubocop.yml
+++ /dev/null
@@ -1,20 +0,0 @@
-AllCops:
-  StyleGuideCopsOnly: true
-
-Metrics/LineLength:
-  Max: 100
-
-Metrics/MethodLength:
-  Enabled: false
-
-Style/Alias:
-  Enabled: false
-
-Style/SignalException:
-  Enabled: false
-
-Style/StringLiterals:
-  EnforcedStyle: single_quotes
-
-Style/TrivialAccessors:
-  ExactNameMatch: true
diff --git a/Gemfile b/Gemfile
deleted file mode 100644
index b599272..000
--- a/Gemfile
+++ /dev/null
@@ -1,5 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'mediawiki_selenium', '~> 1.7', '>= 1.7.1'
-gem 'rake', '~> 11.1', '>= 11.1.1'
-gem 'rubocop', '~> 0.35.1', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
deleted file mode 100644
index 322bb61..000
--- a/Gemfile.lock
+++ /dev/null
@@ -1,104 +0,0 @@
-GEM
-  remote: https://rubygems.org/
-  specs:
-ast (2.1.0)
-astrolabe (1.3.1)
-  parser (~> 2.2)
-builder (3.2.2)
-childprocess (0.5.9)
-  ffi (~> 1.0, >= 1.0.11)
-cucumber (1.3.20)
-  builder (>= 2.1.2)
-  diff-lcs (>= 1.1.3)
-  gherkin (~> 2.12)
-  multi_json (>= 1.7.5, < 2.0)
-  multi_test (>= 0.1.2)
-data_magic (0.22)
-  faker (>= 1.1.2)
-  yml_reader (>= 0.6)
-diff-lcs (1.2.5)
-domain_name (0.5.20160310)
-  unf (>= 0.0.5, < 1.0.0)
-faker (1.6.3)
-  i18n (~> 0.5)
-faraday (0.9.2)
-  multipart-post (>= 1.2, < 3)
-faraday-cookie_jar (0.0.6)
-  faraday (>= 0.7.4)
-  http-cookie (~> 1.0.0)
-ffi (1.9.10)
-gherkin (2.12.2)
-  multi_json (~> 1.3)
-headless (2.2.3)
-http-cookie (1.0.2)
-  domain_name (~> 0.5)
-i18n (0.7.0)
-json (1.8.3)
-mediawiki_api (0.6.0)
-  faraday (~> 0.9, >= 0.9.0)
-  faraday-cookie_jar (~> 0.0, >= 0.0.6)
-mediawiki_selenium (1.7.1)
-  cucumber (~> 1.3, >= 1.3.20)
-  headless (~> 2.0, >= 2.1.0)
-  json (~> 1.8, >= 1.8.1)
-  mediawiki_api (~> 0.6, >= 0.6.0)
-  page-object (~> 1.0)
-  rest-client (~> 1.6, >= 1.6.7)
-  rspec-core (~> 2.14, >= 2.14.4)
-  rspec-expectations (~> 2.14, >= 2.14.4)
-  syntax (~> 1.2, >= 1.2.0)
-  thor (~> 0.19, >= 0.19.1)
-mime-types (2.99.2)
-multi_json (1.12.1)
-multi_test (0.1.2)
-multipart-post (2.0.0)
-netrc (0.11.0)
-page-object (1.1.1)
-  page_navigation (>= 0.9)
-  selenium-webdriver (>= 2.44.0)
-  watir-webdriver (>= 0.6.11)
-page_navigation (0.9)
-  data_magic (>= 0.14)
-parser (2.2.3.0)
-  ast (>= 1.1, < 3.0)
-powerpack (0.1.1)
-rainbow (2.0.0)
-rake (11.1.1)
-rest-client (1.8.0)
-  http-cookie (>= 1.0.2, < 2.0)
-  mime-types (>= 1.16, < 3.0)
-  netrc (~> 0.7)
-rspec-core (2.99.2)
-rspec-expectations (2.99.2)
-  diff-lcs (>= 1.1.3, < 2.0)
-rubocop (0.35.1)
-  astrolabe (~> 1.3)
-  parser (>= 2.2.3.0, < 3.0)
-  powerpack (~> 0.1)
-  rainbow (>= 1.99.1, < 3.0)
-  ruby-progressbar (~> 1.7)
-  tins (<= 1.6.0)
-ruby-progressbar (1.7.5)
-rubyzip (1.2.0)
-selenium-webdriver (2.53.0)
-  childprocess (~> 0.5)
-  rubyzip (~> 1.0)
-  websocket (~> 1.0)
-syntax (1.2.0)
-thor (0.19.1)
-tins (1.6.0)
-unf (0.1.4)
-  unf_ext
-unf_ext (0.0.7.2)
-watir-webdriver (0.9.1)
-  selenium-webdriver (>= 2.46.2)
-websocket (1.2.3)
-yml_reader (0.7)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  mediawiki_selenium (~> 1.7, >= 1.7.1)
-  rake (~> 11.1, >= 11.1.1)
-  rubocop (~> 0.35.1)
diff --git a/Rakefile b/Rakefile
deleted file mode 100644
index 87831ab..000
--- a/Rakefile
+++ /dev/null
@@ -1,17 +0,0 @@
-require 'bundler/setup'
-
-require 'rubocop/rake_task'
-RuboCop::RakeTask.new(:rubocop) do |task|
-  # If you use mediawiki-vagrant, rubocop will by default use it's .rubocop.yml
-  # The next line makes it explicit that you want .rubocop.yml from the
-  # directory where `bundle exec rake` is executed:
-  task.options = ['-c', '.rubocop.yml']
-end
-
-require 'mediawiki_selenium/rake_task'
-MediawikiSelenium::RakeTask.new
-
-task default: [:test]
-
-desc 'Run all build/tests commands (CI

[MediaWiki-commits] [Gerrit] integration/config[master]: Update Ruby jobs for VisualEditor

2017-09-29 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381460 )

Change subject: Update Ruby jobs for VisualEditor
..

Update Ruby jobs for VisualEditor

mwgate-rake is replaced with mwext-ruby-jessie. selenium-VisualEditor is 
deleted since it is broken most of the time.

Bug: T164479
Change-Id: I08a97e64bfc5c82bc59714b6cc8c48cbe522435d
---
M jjb/selenium.yaml
M zuul/layout.yaml
2 files changed, 1 insertion(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/60/381460/1

diff --git a/jjb/selenium.yaml b/jjb/selenium.yaml
index 3539f4e..852cd9c 100644
--- a/jjb/selenium.yaml
+++ b/jjb/selenium.yaml
@@ -102,15 +102,6 @@
  - 'selenium-{name}'
 
 - project:
-name: VisualEditor
-path_to_ci_yml: modules/ve-mw/tests/browser/ci.yml
-recipients: jforres...@wikimedia.org qa-ale...@lists.wikimedia.org # 
@Jdforrester-WMF
-repository: mediawiki/extensions/VisualEditor
-
-jobs:
- - 'selenium-{name}'
-
-- project:
 name: Wikibase
 # recipients: @Tobi_WMDE_SW, @hoo, @aude, @Lydia_Pintscher, @Addshore, 
@daniel, @thiemowmde, @jonas
 recipients: qa-ale...@lists.wikimedia.org wikidata-ci-sta...@wikimedia.de 
# wikidata
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 5282cfa..af75e90 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -6914,8 +6914,8 @@
   - name: mediawiki/extensions/VisualEditor
 template:
   - name: extension-gate
-  - name: mwgate-rake
   - name: commit-message-validator
+  - name: mwext-ruby-jessie
 test:
   - mwext-VisualEditor-npm-node-6-jessie
   - mwext-VisualEditor-jsduck
@@ -6927,7 +6927,6 @@
   - mwext-VisualEditor-publish
 experimental:
   - mediawiki-core-qunit-selenium-jessie
-  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/WebChat
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/381460
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08a97e64bfc5c82bc59714b6cc8c48cbe522435d
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: mwext-ruby-jessie job should run all Ruby tasks for extensions

2017-09-29 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381453 )

Change subject: mwext-ruby-jessie job should run all Ruby tasks for extensions
..

mwext-ruby-jessie job should run all Ruby tasks for extensions

For now, only in experimental pipeline.

Bug: T164479
Change-Id: If98b66945b980dc46409161c3d41ab33d4276892
---
M zuul/layout.yaml
1 file changed, 28 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/53/381453/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 3baeca4..5282cfa 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -2788,6 +2788,7 @@
 experimental:
   - mediawiki-core-qunit-selenium-jessie
   - mwext-mw-selenium-jessie
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/CentralNotice
 template:
@@ -2797,6 +2798,7 @@
   - name: mwgate-npm
 experimental:
   - mwext-mw-selenium-jessie
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/CirrusSearch
 template:
@@ -2806,6 +2808,8 @@
   - name: extension-phan-generic
 test:
   - mwext-CirrusSearch-whitespaces
+experimental:
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/CleanChanges
 template:
@@ -3246,6 +3250,7 @@
  - name: mwgate-npm
 experimental:
  - mwext-mw-selenium-jessie
+ - mwext-ruby-jessie
 postmerge:
  - mwext-jsduck-publish
 
@@ -3278,6 +3283,8 @@
   - name: extension-qunit-generic
   - name: mwgate-rake
   - name: mwgate-npm
+experimental:
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/Genealogy
 template:
@@ -3606,6 +3613,7 @@
 experimental:
   - mediawiki-core-qunit-selenium-jessie
   - mwext-mw-selenium-jessie
+  - mwext-ruby-jessie
 
   # Non-voting due to T87390
   - name: mediawiki/extensions/MathSearch
@@ -3671,6 +3679,8 @@
 postmerge:
   - mwext-jsduck-publish
   - mwext-doxygen-publish
+experimental:
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/MobileApp
 template:
@@ -3723,6 +3733,8 @@
   - name: extension-selenium
 postmerge:
   - mwext-jsduck-publish
+experimental:
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/MwEmbedSupport
 template:
@@ -3885,6 +3897,7 @@
   - name: mwgate-npm
 experimental:
   - mwext-mw-selenium-jessie
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/ParentPage
 template:
@@ -5155,6 +5168,8 @@
   - name: extension-unittests-generic
   - name: mwgate-npm
   - name: extension-selenium
+experimental:
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/QuickSearchLookup
 template:
@@ -6417,6 +6432,8 @@
   - name: extension-gate
   - name: mwgate-rake
   - name: mwgate-npm
+experimental:
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/PerformanceInspector
 template:
@@ -6789,6 +6806,8 @@
   - name: extension-gate
   - name: mwgate-rake
   - name: mwgate-npm
+experimental:
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/TranslationNotifications
 template:
@@ -6810,6 +6829,8 @@
   - name: mwgate-rake
   - name: extension-unittests-generic
   - name: mwgate-npm
+experimental:
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/OpenBadges
 template:
@@ -6832,6 +6853,8 @@
   - name: mwgate-rake
   - name: extension-unittests-generic
   - name: mwgate-npm
+experimental:
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/UploadBlacklist
 template:
@@ -6904,6 +6927,7 @@
   - mwext-VisualEditor-publish
 experimental:
   - mediawiki-core-qunit-selenium-jessie
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/WebChat
 template:
@@ -6943,6 +6967,7 @@
 gate-and-submit-swat: *mediawiki-extensions-wikibase-gate-and-submit
 experimental:
   - mwext-php70-phan-jessie
+  - mwext-ruby-jessie
 postmerge:
   - mwext-doxygen-publish
   - mwext-jsduck-publish
@@ -6989,6 +7014,7 @@
   - name: mwgate-npm
 experimental:
   - mwext-mw-selenium-jessie
+  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/wikihiero
 template:
@@ -7053,6 +7079,8 @@
   - name: extension-gate
   - name: mwgate-rake
   - name: mwgate-npm
+experimental:
+  - mwext-ruby-jessie
 
  PHP Extensions ###
 

-- 
To view, visit https://gerrit.wikimedia.org/r/381453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If98b66945b980dc46409161c3d41ab33d4276892
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Delete Ruby Selenium tests

2017-09-29 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381448 )

Change subject: Delete Ruby Selenium tests
..

Delete Ruby Selenium tests

Tests are broken most of the time. Ruby framework will be deprecated next 
month. Selenium tests that are needed should be implemented in Node.js.

Bug: T164479
Change-Id: I8ec1d9b19b9538936c508daf2b50249a705b3170
---
M Gemfile
M Gemfile.lock
M Rakefile
D modules/ve-mw/tests/browser/.gitignore
D modules/ve-mw/tests/browser/README.md
D modules/ve-mw/tests/browser/ci.yml
D modules/ve-mw/tests/browser/environments.yml
D modules/ve-mw/tests/browser/features/anon.feature
D modules/ve-mw/tests/browser/features/bullets.feature
D modules/ve-mw/tests/browser/features/cite.feature
D modules/ve-mw/tests/browser/features/edit_utf8_logged_in.feature
D modules/ve-mw/tests/browser/features/general_markup.feature
D modules/ve-mw/tests/browser/features/headings.feature
D modules/ve-mw/tests/browser/features/indent_outdent.feature
D modules/ve-mw/tests/browser/features/links.feature
D modules/ve-mw/tests/browser/features/media_general_settings.feature
D modules/ve-mw/tests/browser/features/media_interface.feature
D modules/ve-mw/tests/browser/features/multiedit_workflow.feature
D modules/ve-mw/tests/browser/features/options.feature
D modules/ve-mw/tests/browser/features/references.feature
D modules/ve-mw/tests/browser/features/step_definitions/bullets_steps.rb
D modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
D modules/ve-mw/tests/browser/features/step_definitions/general_markup_steps.rb
D modules/ve-mw/tests/browser/features/step_definitions/headings_steps.rb
D modules/ve-mw/tests/browser/features/step_definitions/links_steps.rb
D 
modules/ve-mw/tests/browser/features/step_definitions/media_general_settings_steps.rb
D modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb
D 
modules/ve-mw/tests/browser/features/step_definitions/multiedit_workflow_steps.rb
D modules/ve-mw/tests/browser/features/step_definitions/options_steps.rb
D modules/ve-mw/tests/browser/features/step_definitions/references_steps.rb
D modules/ve-mw/tests/browser/features/step_definitions/shared_steps.rb
D 
modules/ve-mw/tests/browser/features/step_definitions/switch_editing_mode_steps.rb
D modules/ve-mw/tests/browser/features/step_definitions/table_steps.rb
D modules/ve-mw/tests/browser/features/step_definitions/transclusion_steps.rb
D 
modules/ve-mw/tests/browser/features/step_definitions/verify_production_wikis_steps.rb
D modules/ve-mw/tests/browser/features/support/env.rb
D modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb
D modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
D modules/ve-mw/tests/browser/features/support/pages/zarticlepage.rb
D modules/ve-mw/tests/browser/features/switch_editing_mode.feature
D modules/ve-mw/tests/browser/features/table.feature
D modules/ve-mw/tests/browser/features/transclusion.feature
D modules/ve-mw/tests/browser/features/verify_production_wikis.feature
43 files changed, 1 insertion(+), 2,026 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/48/381448/1

diff --git a/Gemfile b/Gemfile
index 3f10f1d..2c79842 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,6 +1,5 @@
 source 'https://rubygems.org'
 
 gem 'commons_upload', '~> 1.0', '>= 1.0.1'
-gem 'mediawiki_selenium', '~> 1.8'
 gem 'rake', '~> 10.4', '>= 10.4.2'
 gem 'rubocop', '~> 0.32.1', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index e67ecc9..0fa0954 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -4,25 +4,10 @@
 ast (2.3.0)
 astrolabe (1.3.1)
   parser (~> 2.2)
-builder (3.2.3)
-childprocess (0.6.2)
-  ffi (~> 1.0, >= 1.0.11)
 commons_upload (1.0.1)
   mediawiki_api (~> 0.7.0)
-cucumber (1.3.20)
-  builder (>= 2.1.2)
-  diff-lcs (>= 1.1.3)
-  gherkin (~> 2.12)
-  multi_json (>= 1.7.5, < 2.0)
-  multi_test (>= 0.1.2)
-data_magic (1.0)
-  faker (>= 1.1.2)
-  yml_reader (>= 0.6)
-diff-lcs (1.3)
 domain_name (0.5.20160615)
   unf (>= 0.0.5, < 1.0.0)
-faker (1.7.3)
-  i18n (~> 0.5)
 faraday (0.9.2)
   multipart-post (>= 1.2, < 3)
 faraday-cookie_jar (0.0.6)
@@ -30,55 +15,18 @@
   http-cookie (~> 1.0.0)
 faraday_middleware (0.10.0)
   faraday (>= 0.7.4, < 0.10)
-ffi (1.9.17)
-gherkin (2.12.2)
-  multi_json (~> 1.3)
-headless (2.3.1)
 http-cookie (1.0.2)
   domain_name (~> 0.5)
-i18n (0.8.1)
-json (2.0.3)
 mediawiki_api (0.7.0)
   faraday (~> 0.9, >= 0.9.0)
   faraday-cookie_jar (~> 0.0, >= 0.0.6)
   faraday_middleware (~> 0.10, >= 0.10.0)
-mediawiki_selenium (1.8.0)
-  cucumber (~> 1.3, >= 1.3.20)
-  headless (~> 2.0, >= 2.1.0)
-  json (~> 2.0, >= 2.0.2)
-  mediawiki_api (~> 0.7, >= 0.7.0)
-  page-object (~> 2.0)
-

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Run Selenium+Ruby tests daily targeting Beta cluster

2017-09-28 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/381212 )

Change subject: Run Selenium+Ruby tests daily targeting Beta cluster
..

Run Selenium+Ruby tests daily targeting Beta cluster

ci.yml file si required for daily Jenkins job to run properly.

Bug: T174786
Change-Id: Id650d557d45a8dd977b25fbc64652ef9c73b8efc
---
A tests/browser/ci.yml
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/12/381212/1

diff --git a/tests/browser/ci.yml b/tests/browser/ci.yml
new file mode 100644
index 000..c2eca93
--- /dev/null
+++ b/tests/browser/ci.yml
@@ -0,0 +1,9 @@
+BROWSER:
+  - chrome
+  - firefox
+
+MEDIAWIKI_ENVIRONMENT:
+  - beta
+
+PLATFORM:
+  - Linux

-- 
To view, visit https://gerrit.wikimedia.org/r/381212
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id650d557d45a8dd977b25fbc64652ef9c73b8efc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Run mwext-ruby-jessie template for Echo

2017-09-04 Thread Zfilipin (Code Review)

Zfilipin has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/375824 )

Change subject: Run mwext-ruby-jessie template for Echo
..

Run mwext-ruby-jessie template for Echo

Instead of mwgate-rake and extension-selenium templates.

Bug: T164479
Change-Id: Iba575eef75cc679eb68d8eebe57326236e72cf29
---
M zuul/layout.yaml
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/24/375824/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 9ffb293..651cedf 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -1212,6 +1212,12 @@
 gate-and-submit:
   - mwgate-rake-jessie
 
+  - name: mwext-ruby-jessie
+test:
+  - mwext-ruby-jessie
+gate-and-submit:
+  - mwext-ruby-jessie
+
   - name: puppet-module
 test:
   - puppet-{name}-rake-jessie
@@ -3070,12 +3076,10 @@
   - name: extension-gate
   - name: extension-unittests-generic
   - name: extension-qunit-generic
-  - name: mwgate-rake
+  - name: mwext-ruby-jessie
   - name: mwgate-npm
-  - name: extension-selenium
 experimental:
   - mediawiki-core-qunit-selenium-jessie
-  - mwext-ruby-jessie
 
   - name: mediawiki/extensions/EditAccount
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/375824
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba575eef75cc679eb68d8eebe57326236e72cf29
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Zfilipin 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

1 2 3 4 5 6 7 8 9 10 >

1 - 100 of 1945 matches

Mail list logo