[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[REL1_27]: Remove erroneous break

2016-10-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove erroneous break
..


Remove erroneous break

Bug: T148284
Change-Id: Ie081ac9f7d96dd58c399f3f73febe456353cca45
---
M libs/getid3/getid3.lib.php
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  TheDJ: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/libs/getid3/getid3.lib.php b/libs/getid3/getid3.lib.php
index 16d5318..9410509 100644
--- a/libs/getid3/getid3.lib.php
+++ b/libs/getid3/getid3.lib.php
@@ -282,7 +282,6 @@
}
} else {
throw new Exception('ERROR: Cannot have signed 
integers larger than '.(8 * PHP_INT_SIZE).'-bits ('.strlen($byteword).') in 
self::BigEndian2Int()');
-   break;
}
}
return self::CastAsInt($intvalue);

-- 
To view, visit https://gerrit.wikimedia.org/r/316070
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie081ac9f7d96dd58c399f3f73febe456353cca45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: REL1_27
Gerrit-Owner: Reedy 
Gerrit-Reviewer: TheDJ 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[REL1_27]: Remove erroneous break

2016-10-15 Thread Reedy (Code Review) 
Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316070

Change subject: Remove erroneous break
..

Remove erroneous break

Bug: T148284
Change-Id: Ie081ac9f7d96dd58c399f3f73febe456353cca45
---
M libs/getid3/getid3.lib.php
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/70/316070/1

diff --git a/libs/getid3/getid3.lib.php b/libs/getid3/getid3.lib.php
index 16d5318..9410509 100644
--- a/libs/getid3/getid3.lib.php
+++ b/libs/getid3/getid3.lib.php
@@ -282,7 +282,6 @@
}
} else {
throw new Exception('ERROR: Cannot have signed 
integers larger than '.(8 * PHP_INT_SIZE).'-bits ('.strlen($byteword).') in 
self::BigEndian2Int()');
-   break;
}
}
return self::CastAsInt($intvalue);

-- 
To view, visit https://gerrit.wikimedia.org/r/316070
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie081ac9f7d96dd58c399f3f73febe456353cca45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: REL1_27
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits