[MediaWiki-commits] [Gerrit] Add daily stats funnel - change (apps...wikipedia)
jenkins-bot has submitted this change and it was merged. Change subject: Add daily stats funnel .. Add daily stats funnel - Add event logging up to once a day on page load complete to report the app install lifetime in days. - Add LongPreference and supporting code and refactor IntPreference. - Fix default IntPreference max digit length for default radix. - Reorder methods in RecurringTask and refactor to use Prefs. It is valuable to know the distribution curve of the app installation retention. A new funnel is made available to report this information up to once a day. The funnel may later encompass additional reports at the same frequency. Bug: T103188 Change-Id: I9dcce02fe19954381521d81cc8ec4378af51bf86 --- M wikipedia/res/values/attrs.xml M wikipedia/res/values/preference_keys.xml M wikipedia/res/values/styles.xml M wikipedia/res/xml/developer_preferences.xml M wikipedia/src/main/java/org/wikipedia/RemoteConfigRefreshTask.java M wikipedia/src/main/java/org/wikipedia/alphaupdater/AlphaUpdateChecker.java A wikipedia/src/main/java/org/wikipedia/analytics/DailyStatsFunnel.java M wikipedia/src/main/java/org/wikipedia/page/PageActivity.java M wikipedia/src/main/java/org/wikipedia/page/snippet/SharedImageCleanupTask.java A wikipedia/src/main/java/org/wikipedia/recurring/DailyEventTask.java M wikipedia/src/main/java/org/wikipedia/recurring/RecurringTask.java M wikipedia/src/main/java/org/wikipedia/recurring/RecurringTasksExecutor.java M wikipedia/src/main/java/org/wikipedia/settings/IntPreference.java A wikipedia/src/main/java/org/wikipedia/settings/LongPreference.java M wikipedia/src/main/java/org/wikipedia/settings/Prefs.java M wikipedia/src/main/java/org/wikipedia/settings/PrefsIoUtil.java 16 files changed, 332 insertions(+), 117 deletions(-) Approvals: BearND: Looks good to me, approved jenkins-bot: Verified diff --git a/wikipedia/res/values/attrs.xml b/wikipedia/res/values/attrs.xml index d42922e..ec594d1 100644 --- a/wikipedia/res/values/attrs.xml +++ b/wikipedia/res/values/attrs.xml @@ -28,10 +28,14 @@ attr name=autoSummarize format=boolean / /declare-styleable -declare-styleable name=IntPreference -attr name=intPreferenceStyle format=reference / +declare-styleable name=LongPreference +attr name=longPreferenceStyle format=reference / attr name=radix format=integer / attr name=summaryFormat format=string / /declare-styleable +declare-styleable name=IntPreference +attr name=intPreferenceStyle format=reference / +/declare-styleable + /resources diff --git a/wikipedia/res/values/preference_keys.xml b/wikipedia/res/values/preference_keys.xml index 27f0eff..9eef114 100644 --- a/wikipedia/res/values/preference_keys.xml +++ b/wikipedia/res/values/preference_keys.xml @@ -22,10 +22,12 @@ string name=preference_key_toc_tutorial_enabledtocTutorialEnabled/string string name=preference_key_show_imagesshowImages/string string name=preference_key_exp_page_loadexpPageLoad/string +string name=preference_key_daily_event_time_task_namedailyEventTask/string string name=preference_key_login_usernameusername/string string name=preference_key_login_passwordpassword/string string name=preference_key_login_user_iduserID/string string name=preference_key_link_preview_versionlinkPreviewVersion/string string name=preference_key_more_like_search_enabledmoreLikeSearchEnabled/string string name=preference_key_show_developer_settingsshowDeveloperSettings/string +string name=preference_key_last_run_time_format%s-lastrun/string /resources diff --git a/wikipedia/res/values/styles.xml b/wikipedia/res/values/styles.xml index 0846b77..b97bc2b 100644 --- a/wikipedia/res/values/styles.xml +++ b/wikipedia/res/values/styles.xml @@ -3,6 +3,7 @@ style name=AppTheme parent=Theme.WikiLight item name=editTextAutoSummarizePreferenceStyle@style/EditTextAutoSummarizePreference/item +item name=longPreferenceStyle@style/LongPreference/item item name=intPreferenceStyle@style/IntPreference/item /style @@ -125,10 +126,6 @@ item name=android:windowAnimationStyle@style/DialogAnimation/item /style -style name=EditTextAutoSummarizePreference -!-- parent=@android:style/Preference.DialogPreference.EditTextPreference is not exposed. -- -/style - !-- Default style for floating action buttons -- style name=FloatingActionButton item name=android:layout_marginLeft@dimen/floating_action_button_margin_left/item @@ -137,10 +134,20 @@ item name=android:layout_marginBottom@dimen/floating_action_button_margin_bottom/item /style -style name=IntPreference parent=EditTextAutoSummarizePreference +!-- Preferences -- + +style name=EditTextAutoSummarizePreference +!--
[MediaWiki-commits] [Gerrit] Add daily stats funnel - change (apps...wikipedia)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/223976 Change subject: Add daily stats funnel .. Add daily stats funnel - Add event logging up to once a day on page load complete to report the app install lifetime in days. - Add daily event callback method to PageViewFragmentInternal. - Add LongPreference and supporting code and refactor IntPreference. - Fix default IntPreference max digit length for default radix. It is valuable to know the distribution curve of the app installation retention. A new funnel is made available to report this information up to once a day. The funnel may later encompass additional reports at the same frequency. Bug: T103188 Change-Id: I9dcce02fe19954381521d81cc8ec4378af51bf86 --- M wikipedia/res/values/attrs.xml M wikipedia/res/values/preference_keys.xml M wikipedia/res/values/styles.xml M wikipedia/res/xml/developer_preferences.xml A wikipedia/src/main/java/org/wikipedia/analytics/DailyStatsFunnel.java M wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java M wikipedia/src/main/java/org/wikipedia/settings/IntPreference.java A wikipedia/src/main/java/org/wikipedia/settings/LongPreference.java M wikipedia/src/main/java/org/wikipedia/settings/Prefs.java M wikipedia/src/main/java/org/wikipedia/settings/PrefsIoUtil.java 10 files changed, 254 insertions(+), 66 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/76/223976/1 diff --git a/wikipedia/res/values/attrs.xml b/wikipedia/res/values/attrs.xml index d42922e..ec594d1 100644 --- a/wikipedia/res/values/attrs.xml +++ b/wikipedia/res/values/attrs.xml @@ -28,10 +28,14 @@ attr name=autoSummarize format=boolean / /declare-styleable -declare-styleable name=IntPreference -attr name=intPreferenceStyle format=reference / +declare-styleable name=LongPreference +attr name=longPreferenceStyle format=reference / attr name=radix format=integer / attr name=summaryFormat format=string / /declare-styleable +declare-styleable name=IntPreference +attr name=intPreferenceStyle format=reference / +/declare-styleable + /resources diff --git a/wikipedia/res/values/preference_keys.xml b/wikipedia/res/values/preference_keys.xml index 5b1c36b..0647ef9 100644 --- a/wikipedia/res/values/preference_keys.xml +++ b/wikipedia/res/values/preference_keys.xml @@ -22,6 +22,7 @@ string name=preference_key_know_toc_drawerknowToC/string string name=preference_key_show_imagesshowImages/string string name=preference_key_exp_page_loadexpPageLoad/string +string name=preference_key_last_daily_event_timelastDailyEventTime/string string name=preference_key_login_usernameusername/string string name=preference_key_login_passwordpassword/string string name=preference_key_login_user_iduserID/string diff --git a/wikipedia/res/values/styles.xml b/wikipedia/res/values/styles.xml index d21f3d4..e7a5ded 100644 --- a/wikipedia/res/values/styles.xml +++ b/wikipedia/res/values/styles.xml @@ -1,6 +1,7 @@ resources style name=AppTheme parent=Theme.WikiLight item name=editTextAutoSummarizePreferenceStyle@style/EditTextAutoSummarizePreference/item +item name=longPreferenceStyle@style/LongPreference/item item name=intPreferenceStyle@style/IntPreference/item /style @@ -121,10 +122,14 @@ !-- parent=@android:style/Preference.DialogPreference.EditTextPreference is not exposed. -- /style -style name=IntPreference parent=EditTextAutoSummarizePreference +style name=LongPreference parent=EditTextAutoSummarizePreference item name=android:inputTypenumber/item -item name=android:maxLength8/item +item name=android:maxLength20/item item name=android:gravityright|end/item +/style + +style name=IntPreference parent=LongPreference +item name=android:maxLength11/item /style style name=HexIntPreference parent=IntPreference @@ -132,6 +137,7 @@ item name=android:digits0123456789abcdef/item item name=radix16/item item name=summaryFormat%08x/item +item name=android:maxLength8/item /style /resources diff --git a/wikipedia/res/xml/developer_preferences.xml b/wikipedia/res/xml/developer_preferences.xml index 209bc5f..7b017bc 100644 --- a/wikipedia/res/xml/developer_preferences.xml +++ b/wikipedia/res/xml/developer_preferences.xml @@ -59,6 +59,11 @@ android:key=@string/preference_key_exp_page_load android:title=@string/preference_key_exp_page_load / +org.wikipedia.settings.LongPreference +style=@style/LongPreference +android:key=@string/preference_key_last_daily_event_time +android:title=@string/preference_key_last_daily_event_time / +
