[MediaWiki-commits] [Gerrit] Replace php_sapi_name() with PHP_SAPI - change (mediawiki...wikidiff)

2014-01-21 Thread Reedy (Code Review) 
Reedy has submitted this change and it was merged.

Change subject: Replace php_sapi_name() with PHP_SAPI
..


Replace php_sapi_name() with PHP_SAPI

Change-Id: Icc227d0fb317d54b4bb3918b797154988e5d70d7
---
M memleak.php
1 file changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved



diff --git a/memleak.php b/memleak.php
index d0df104..8dbea15 100644
--- a/memleak.php
+++ b/memleak.php
@@ -3,11 +3,11 @@
 # Quickie memory leak checker.
 # 2004-11-14 -- br...@pobox.com
 
-if( php_sapi_name() != 'cli' ) {
+if( PHP_SAPI != 'cli' ) {
die( Run me from the command line please.\n );
 }
 
-echo 
+echo
 Memory leak test!
 
 Watch PHP's memory usage in top; a leak in the extension will not
@@ -23,8 +23,9 @@
 
 function randomString( $length, $nullOk = false, $ascii = false ) {
$out = '';
-   for( $i = 0; $i  $length; $i++ )
+   for( $i = 0; $i  $length; $i++ ) {
$out .= chr( mt_rand( $nullOk ? 0 : 1, $ascii ? 127 : 255 ) );
+   }
return $out;
 }
 
@@ -34,15 +35,15 @@
 for( $i = 0; $i = $maxruns; $i++ ) {
$x = memory_get_usage() - $membase;
printf( %5d: up %d bytes\n, $i, $x );
-   
+
$a = randomString( $size );
$b = randomString( $size );
$c = wikidiff_do_diff( $a, $b, 1 );
-   
+
$a = '';
$b = '';
$c = '';
 }
 
-echo ( . (memory_get_usage() - $membase) .  used)\n;
+echo ( . ( memory_get_usage() - $membase ) .  used)\n;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/91856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc227d0fb317d54b4bb3918b797154988e5d70d7
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/php/wikidiff
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Replace php_sapi_name() with PHP_SAPI - change (mediawiki...wikidiff)

2013-10-25 Thread Reedy (Code Review) 
Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/91856


Change subject: Replace php_sapi_name() with PHP_SAPI
..

Replace php_sapi_name() with PHP_SAPI

Change-Id: Icc227d0fb317d54b4bb3918b797154988e5d70d7
---
M memleak.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/php/wikidiff 
refs/changes/56/91856/1

diff --git a/memleak.php b/memleak.php
index d0df104..5f5f091 100644
--- a/memleak.php
+++ b/memleak.php
@@ -3,11 +3,11 @@
 # Quickie memory leak checker.
 # 2004-11-14 -- br...@pobox.com
 
-if( php_sapi_name() != 'cli' ) {
+if( PHP_SAPI != 'cli' ) {
die( Run me from the command line please.\n );
 }
 
-echo 
+echo
 Memory leak test!
 
 Watch PHP's memory usage in top; a leak in the extension will not
@@ -34,7 +34,7 @@
 for( $i = 0; $i = $maxruns; $i++ ) {
$x = memory_get_usage() - $membase;
printf( %5d: up %d bytes\n, $i, $x );
-   
+
$a = randomString( $size );
$b = randomString( $size );
$c = wikidiff_do_diff( $a, $b, 1 );

-- 
To view, visit https://gerrit.wikimedia.org/r/91856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc227d0fb317d54b4bb3918b797154988e5d70d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/php/wikidiff
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits