[MediaWiki-commits] [Gerrit] Show main page tapping featured page widget - change (apps...wikipedia)

2015-07-30 Thread Niedzielski (Code Review) 
Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/228149

Change subject: Show main page tapping featured page widget
..

Show main page tapping featured page widget

Fix regression wherein tapping the featured article widget would not
spawn a new tab.

Change-Id: I1b55ae269befffc84e8d15b8abc9cc1f76509091
---
M wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/49/228149/1

diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java 
b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
index 47d83e4..b43f603 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
@@ -415,6 +415,7 @@
 // Log that the user tapped on the featured article widget
 // Instantiate the funnel anonymously to save on memory overhead
 new WidgetsFunnel(app).logFeaturedArticleWidgetTap();
+displayMainPageInForegroundTab();
 } else {
 displayMainPageIfNoTabs();
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/228149
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b55ae269befffc84e8d15b8abc9cc1f76509091
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski sniedziel...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Show main page tapping featured page widget - change (apps...wikipedia)

2015-07-30 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Show main page tapping featured page widget
..


Show main page tapping featured page widget

Fix regression wherein tapping the featured article widget would not
spawn a new tab.

Change-Id: I1b55ae269befffc84e8d15b8abc9cc1f76509091
---
M wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  BearND: Looks good to me, but someone else must approve
  Mholloway: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java 
b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
index 97c0764..3274816 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
@@ -442,6 +442,7 @@
 // Log that the user tapped on the featured article widget
 // Instantiate the funnel anonymously to save on memory overhead
 new WidgetsFunnel(app).logFeaturedArticleWidgetTap();
+displayMainPageInForegroundTab();
 } else {
 displayMainPageIfNoTabs();
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/228149
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b55ae269befffc84e8d15b8abc9cc1f76509091
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski sniedziel...@wikimedia.org
Gerrit-Reviewer: BearND bsitzm...@wikimedia.org
Gerrit-Reviewer: Brion VIBBER br...@wikimedia.org
Gerrit-Reviewer: Dbrant dbr...@wikimedia.org
Gerrit-Reviewer: Mholloway mhollo...@wikimedia.org
Gerrit-Reviewer: Niedzielski sniedziel...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits