[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix article description subtitle capitalization

2016-12-05 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix article description subtitle capitalization
..


Fix article description subtitle capitalization

Looks like this got knocked out in a recent commit.  This fixes it.

Change-Id: Id416ffc29007e915900dbdbdec5963a9b7d33637
---
M app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Niedzielski: Looks good to me, approved



diff --git 
a/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java 
b/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
index cf36120..d4be8ca 100755
--- a/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
+++ b/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
@@ -11,6 +11,7 @@
 import android.view.animation.Animation;
 import android.view.animation.AnimationUtils;
 
+import org.apache.commons.lang3.StringUtils;
 import org.json.JSONException;
 import org.json.JSONObject;
 import org.wikipedia.Constants;
@@ -191,7 +192,7 @@
  * @param description WikiData description to be shown.
  */
 private void layoutWikiDataDescription(@Nullable final String description) 
{
-articleHeaderView.setSubtitle(description);
+articleHeaderView.setSubtitle(StringUtils.capitalize(description));
 }
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/324806
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id416ffc29007e915900dbdbdec5963a9b7d33637
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix article description subtitle capitalization

2016-12-01 Thread Mholloway (Code Review) 
Mholloway has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/324806

Change subject: Fix article description subtitle capitalization
..

Fix article description subtitle capitalization

Looks like this got knocked out in a recent commit.  This fixes it.

Change-Id: Id416ffc29007e915900dbdbdec5963a9b7d33637
---
M app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/06/324806/1

diff --git 
a/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java 
b/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
index cf36120..d4be8ca 100755
--- a/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
+++ b/app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
@@ -11,6 +11,7 @@
 import android.view.animation.Animation;
 import android.view.animation.AnimationUtils;
 
+import org.apache.commons.lang3.StringUtils;
 import org.json.JSONException;
 import org.json.JSONObject;
 import org.wikipedia.Constants;
@@ -191,7 +192,7 @@
  * @param description WikiData description to be shown.
  */
 private void layoutWikiDataDescription(@Nullable final String description) 
{
-articleHeaderView.setSubtitle(description);
+articleHeaderView.setSubtitle(StringUtils.capitalize(description));
 }
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/324806
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id416ffc29007e915900dbdbdec5963a9b7d33637
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits