[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix "MWExceptionRenderer::getText() should not be called sta...

2016-09-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix "MWExceptionRenderer::getText() should not be called 
statically" errors
..


Fix "MWExceptionRenderer::getText() should not be called statically" errors

Change-Id: Icfb65795b1455217ca9bc2c1f7cd453144ad5106
---
M includes/exception/MWExceptionRenderer.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Anomie: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/exception/MWExceptionRenderer.php 
b/includes/exception/MWExceptionRenderer.php
index 6fed7af..e242da3 100644
--- a/includes/exception/MWExceptionRenderer.php
+++ b/includes/exception/MWExceptionRenderer.php
@@ -257,7 +257,7 @@
 * @param Exception|Throwable $e
 * @return string
 */
-   private function getText( $e ) {
+   private static function getText( $e ) {
if ( self::showBackTrace( $e ) ) {
return MWExceptionHandler::getLogMessage( $e ) .
"\nBacktrace:\n" .

-- 
To view, visit https://gerrit.wikimedia.org/r/311474
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icfb65795b1455217ca9bc2c1f7cd453144ad5106
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix "MWExceptionRenderer::getText() should not be called sta...

2016-09-19 Thread Aaron Schulz (Code Review) 
Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311474

Change subject: Fix "MWExceptionRenderer::getText() should not be called 
statically" errors
..

Fix "MWExceptionRenderer::getText() should not be called statically" errors

Change-Id: Icfb65795b1455217ca9bc2c1f7cd453144ad5106
---
M includes/exception/MWExceptionRenderer.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/74/311474/1

diff --git a/includes/exception/MWExceptionRenderer.php 
b/includes/exception/MWExceptionRenderer.php
index 6fed7af..e242da3 100644
--- a/includes/exception/MWExceptionRenderer.php
+++ b/includes/exception/MWExceptionRenderer.php
@@ -257,7 +257,7 @@
 * @param Exception|Throwable $e
 * @return string
 */
-   private function getText( $e ) {
+   private static function getText( $e ) {
if ( self::showBackTrace( $e ) ) {
return MWExceptionHandler::getLogMessage( $e ) .
"\nBacktrace:\n" .

-- 
To view, visit https://gerrit.wikimedia.org/r/311474
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfb65795b1455217ca9bc2c1f7cd453144ad5106
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits