[MediaWiki-commits] [Gerrit] mediawiki...FeaturedFeeds[master]: Remove pre-1.25 API compatibility code
jenkins-bot has submitted this change and it was merged. Change subject: Remove pre-1.25 API compatibility code .. Remove pre-1.25 API compatibility code Since this extension uses extension.json, it already requires 1.25+ so no need to keep the old code around. Change-Id: I2591c017927867c14eed5cb0a275459b3ed60a7e --- M ApiFeaturedFeeds.php 1 file changed, 0 insertions(+), 35 deletions(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/ApiFeaturedFeeds.php b/ApiFeaturedFeeds.php index 710ddde..d2c6d0b 100644 --- a/ApiFeaturedFeeds.php +++ b/ApiFeaturedFeeds.php @@ -63,41 +63,6 @@ } /** -* @deprecated since MediaWiki core 1.25 -*/ - public function getParamDescription() { - return array( - 'feedformat' => 'The format of the feed', - 'feed' => 'Feed name', - 'language' => 'Feed language code. Ignored by some feeds.', - ); - } - - /** -* @deprecated since MediaWiki core 1.25 -*/ - public function getDescription() { - return 'Returns a featured content feed'; - } - - /** -* @deprecated since MediaWiki core 1.25 -*/ - public function getExamples() { - // attempt to find a valid feed name - // if none available, just use an example value - $availableFeeds = array_keys( FeaturedFeeds::getFeeds( false ) ); - $feed = reset( $availableFeeds ); - if ( !$feed ) { - $feed = 'featured'; - } - - return array( - "api.php?action=featuredfeed=$feed" => "Retrieve feed ``$feed'", - ); - } - - /** * @see ApiBase::getExamplesMessages() */ protected function getExamplesMessages() { -- To view, visit https://gerrit.wikimedia.org/r/311782 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2591c017927867c14eed5cb0a275459b3ed60a7e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FeaturedFeeds Gerrit-Branch: master Gerrit-Owner: AnomieGerrit-Reviewer: Jforrester Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...FeaturedFeeds[master]: Remove pre-1.25 API compatibility code
Anomie has uploaded a new change for review. https://gerrit.wikimedia.org/r/311782 Change subject: Remove pre-1.25 API compatibility code .. Remove pre-1.25 API compatibility code Since this extension uses extension.json, it already requires 1.25+ so no need to keep the old code around. Change-Id: I2591c017927867c14eed5cb0a275459b3ed60a7e --- M ApiFeaturedFeeds.php 1 file changed, 0 insertions(+), 35 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FeaturedFeeds refs/changes/82/311782/1 diff --git a/ApiFeaturedFeeds.php b/ApiFeaturedFeeds.php index 710ddde..d2c6d0b 100644 --- a/ApiFeaturedFeeds.php +++ b/ApiFeaturedFeeds.php @@ -63,41 +63,6 @@ } /** -* @deprecated since MediaWiki core 1.25 -*/ - public function getParamDescription() { - return array( - 'feedformat' => 'The format of the feed', - 'feed' => 'Feed name', - 'language' => 'Feed language code. Ignored by some feeds.', - ); - } - - /** -* @deprecated since MediaWiki core 1.25 -*/ - public function getDescription() { - return 'Returns a featured content feed'; - } - - /** -* @deprecated since MediaWiki core 1.25 -*/ - public function getExamples() { - // attempt to find a valid feed name - // if none available, just use an example value - $availableFeeds = array_keys( FeaturedFeeds::getFeeds( false ) ); - $feed = reset( $availableFeeds ); - if ( !$feed ) { - $feed = 'featured'; - } - - return array( - "api.php?action=featuredfeed=$feed" => "Retrieve feed ``$feed'", - ); - } - - /** * @see ApiBase::getExamplesMessages() */ protected function getExamplesMessages() { -- To view, visit https://gerrit.wikimedia.org/r/311782 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2591c017927867c14eed5cb0a275459b3ed60a7e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FeaturedFeeds Gerrit-Branch: master Gerrit-Owner: Anomie___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits