[MediaWiki-commits] [Gerrit] mediawiki...FileAnnotations[master]: Make namespace names lowercase, except for first-letter

2016-09-19 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Make namespace names lowercase, except for first-letter
..


Make namespace names lowercase, except for first-letter

This seems to be more common. Namespace names are case-insensitive,
so this is backwards-compatible.

Change-Id: I466ac02c424f3274196717537be6a99fb5169823
---
M extension.json
M resources/src/fileannotations.js
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index c194117..b480a98 100644
--- a/extension.json
+++ b/extension.json
@@ -10,13 +10,13 @@
"type": "other",
"namespaces": [
{
-   "name": "File_Annotations",
+   "name": "File_annotations",
"id": 492,
"constant": "NS_FILE_ANNOTATIONS",
"defaultcontentmodel": "FileAnnotations"
},
{
-   "name": "File_Annotations_Talk",
+   "name": "File_annotations_talk",
"id": 493,
"constant": "NS_FILE_ANNOTATIONS_TALK"
}
diff --git a/resources/src/fileannotations.js b/resources/src/fileannotations.js
index 6ea1664..00950c2 100644
--- a/resources/src/fileannotations.js
+++ b/resources/src/fileannotations.js
@@ -46,7 +46,7 @@
 
config.$container.append( this.$container );
 
-   this.annotationsTitle = mw.Title.newFromText( 'File 
Annotations:' + this.fileTitle.getMain() );
+   this.annotationsTitle = mw.Title.newFromText( 'File 
annotations:' + this.fileTitle.getMain() );
 
this.getAndRenderAnnotations().then( function () {
var $body = $( 'body' );

-- 
To view, visit https://gerrit.wikimedia.org/r/310080
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I466ac02c424f3274196717537be6a99fb5169823
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/FileAnnotations
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: MarkTraceur 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...FileAnnotations[master]: Make namespace names lowercase, except for first-letter

2016-09-12 Thread Code Review
Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/310080

Change subject: Make namespace names lowercase, except for first-letter
..

Make namespace names lowercase, except for first-letter

This seems to be more common. Namespace names are case-insensitive,
so this is backwards-compatible.

Change-Id: I466ac02c424f3274196717537be6a99fb5169823
---
M extension.json
M resources/src/fileannotations.js
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FileAnnotations 
refs/changes/80/310080/1

diff --git a/extension.json b/extension.json
index 7701046..b7596e8 100644
--- a/extension.json
+++ b/extension.json
@@ -10,13 +10,13 @@
"type": "other",
"namespaces": [
{
-   "name": "File_Annotations",
+   "name": "File_annotations",
"id": 492,
"constant": "NS_FILE_ANNOTATIONS",
"defaultcontentmodel": "FileAnnotations"
},
{
-   "name": "File_Annotations_Talk",
+   "name": "File_annotations_talk",
"id": 493,
"constant": "NS_FILE_ANNOTATIONS_TALK"
}
diff --git a/resources/src/fileannotations.js b/resources/src/fileannotations.js
index c7aa0c9..666d4e6 100644
--- a/resources/src/fileannotations.js
+++ b/resources/src/fileannotations.js
@@ -44,7 +44,7 @@
 
$( 'body' ).append( this.$container );
 
-   this.annotationsTitle = mw.Title.newFromText( 'File 
Annotations:' + this.fileTitle.getMain() );
+   this.annotationsTitle = mw.Title.newFromText( 'File 
annotations:' + this.fileTitle.getMain() );
 
this.getAndRenderAnnotations().then( function () {
var $body = $( 'body' );

-- 
To view, visit https://gerrit.wikimedia.org/r/310080
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I466ac02c424f3274196717537be6a99fb5169823
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FileAnnotations
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits