[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: Fix displaying images with uppercase extension.
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/333998 ) Change subject: Fix displaying images with uppercase extension. .. Fix displaying images with uppercase extension. Bug: T154862 Change-Id: Ib74066340a869a49036215a6ea1df39daa17890c --- M resources/mmv/mmv.js 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Divadsn: Looks good to me, but someone else must approve jenkins-bot: Verified Jdlrobson: Looks good to me, approved diff --git a/resources/mmv/mmv.js b/resources/mmv/mmv.js index 9fcef6d..f7b2eee 100644 --- a/resources/mmv/mmv.js +++ b/resources/mmv/mmv.js @@ -178,7 +178,7 @@ var imageWidths, canvasDimensions, viewer = this, image = this.thumbs[ this.currentIndex ].image, - ext = this.thumbs[ this.currentIndex ].title.ext; + ext = this.thumbs[ this.currentIndex ].title.ext.toLowerCase(); this.preloadThumbnails(); @@ -242,7 +242,7 @@ $initialImage = $( initialImage ), extraStatsDeferred = $.Deferred(); - pluginsPromise = this.loadExtensionPlugins( image.filePageTitle.ext ); + pluginsPromise = this.loadExtensionPlugins( image.filePageTitle.ext.toLowerCase() ); this.currentIndex = image.index; @@ -262,7 +262,7 @@ // the aspect ratio $initialImage.hide(); $initialImage.addClass( 'mw-mmv-placeholder-image' ); - $initialImage.addClass( image.filePageTitle.ext ); + $initialImage.addClass( image.filePageTitle.ext.toLowerCase() ); this.ui.canvas.set( image, $initialImage ); @@ -307,7 +307,7 @@ } ); } - imageElement.className = 'mw-mmv-final-image ' + image.filePageTitle.ext; + imageElement.className = 'mw-mmv-final-image ' + image.filePageTitle.ext.toLowerCase(); imageElement.alt = image.alt; $.when( metadataPromise, pluginsPromise ).done( function ( metadata ) { -- To view, visit https://gerrit.wikimedia.org/r/333998 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib74066340a869a49036215a6ea1df39daa17890c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Phantom42Gerrit-Reviewer: Divadsn Gerrit-Reviewer: Jdlrobson Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: Fix displaying images with uppercase extension.
Phantom42 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333998 ) Change subject: Fix displaying images with uppercase extension. .. Fix displaying images with uppercase extension. Bug: T154862 Change-Id: Ib74066340a869a49036215a6ea1df39daa17890c --- M resources/mmv/mmv.js 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/98/333998/1 diff --git a/resources/mmv/mmv.js b/resources/mmv/mmv.js index 9fcef6d..f7b2eee 100644 --- a/resources/mmv/mmv.js +++ b/resources/mmv/mmv.js @@ -178,7 +178,7 @@ var imageWidths, canvasDimensions, viewer = this, image = this.thumbs[ this.currentIndex ].image, - ext = this.thumbs[ this.currentIndex ].title.ext; + ext = this.thumbs[ this.currentIndex ].title.ext.toLowerCase(); this.preloadThumbnails(); @@ -242,7 +242,7 @@ $initialImage = $( initialImage ), extraStatsDeferred = $.Deferred(); - pluginsPromise = this.loadExtensionPlugins( image.filePageTitle.ext ); + pluginsPromise = this.loadExtensionPlugins( image.filePageTitle.ext.toLowerCase() ); this.currentIndex = image.index; @@ -262,7 +262,7 @@ // the aspect ratio $initialImage.hide(); $initialImage.addClass( 'mw-mmv-placeholder-image' ); - $initialImage.addClass( image.filePageTitle.ext ); + $initialImage.addClass( image.filePageTitle.ext.toLowerCase() ); this.ui.canvas.set( image, $initialImage ); @@ -307,7 +307,7 @@ } ); } - imageElement.className = 'mw-mmv-final-image ' + image.filePageTitle.ext; + imageElement.className = 'mw-mmv-final-image ' + image.filePageTitle.ext.toLowerCase(); imageElement.alt = image.alt; $.when( metadataPromise, pluginsPromise ).done( function ( metadata ) { -- To view, visit https://gerrit.wikimedia.org/r/333998 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib74066340a869a49036215a6ea1df39daa17890c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Phantom42___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits