[MediaWiki-commits] [Gerrit] registration: Add test to check extension.json globals are d... - change (mediawiki/core)

2016-07-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: registration: Add test to check extension.json globals are 
documented
..


registration: Add test to check extension.json globals are documented

Verify that all the global settings listed in
ExtensionProcessor::$globalSettings are documented in the extension.json
schema.

Change-Id: If0ed09ed19b92934e869bbd40d8716a83e4b0a30
---
M tests/phpunit/includes/registration/ExtensionProcessorTest.php
1 file changed, 20 insertions(+), 0 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/phpunit/includes/registration/ExtensionProcessorTest.php 
b/tests/phpunit/includes/registration/ExtensionProcessorTest.php
index 0120d79..ea86535 100644
--- a/tests/phpunit/includes/registration/ExtensionProcessorTest.php
+++ b/tests/phpunit/includes/registration/ExtensionProcessorTest.php
@@ -414,6 +414,26 @@
]
];
}
+
+   public function testGlobalSettingsDocumentedInSchema() {
+   global $IP;
+   $globalSettings = TestingAccessWrapper::newFromClass(
+   ExtensionProcessor::class )->globalSettings;
+
+   $schema = FormatJson::decode(
+   file_get_contents( "$IP/docs/extension.schema.json" ),
+   true
+   );
+   $missing = [];
+   foreach ( $globalSettings as $global ) {
+   if ( !isset( $schema['properties'][$global] ) ) {
+   $missing[] = $global;
+   }
+   }
+
+   $this->assertEquals( [], $missing,
+   "The following global settings are not documented in 
docs/extension.schema.json" );
+   }
 }
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/293811
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0ed09ed19b92934e869bbd40d8716a83e4b0a30
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] registration: Add test to check extension.json globals are d... - change (mediawiki/core)

2016-06-10 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/293811

Change subject: registration: Add test to check extension.json globals are 
documented
..

registration: Add test to check extension.json globals are documented

Verify that all the global settings listed in
ExtensionProcessor::$globalSettings are documented in the extension.json
schema.

Change-Id: If0ed09ed19b92934e869bbd40d8716a83e4b0a30
---
M tests/phpunit/includes/registration/ExtensionProcessorTest.php
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/11/293811/1

diff --git a/tests/phpunit/includes/registration/ExtensionProcessorTest.php 
b/tests/phpunit/includes/registration/ExtensionProcessorTest.php
index 0120d79..96fd0d3 100644
--- a/tests/phpunit/includes/registration/ExtensionProcessorTest.php
+++ b/tests/phpunit/includes/registration/ExtensionProcessorTest.php
@@ -414,6 +414,27 @@
]
];
}
+
+   public function testGlobalSettingsDocumentedInSchema() {
+   global $IP;
+   $processor = new ReflectionClass( 'ExtensionProcessor' );
+   $settings = $processor->getProperty( 'globalSettings' );
+   $settings->setAccessible( true );
+   $globalSettings = $settings->getValue();
+
+   $schema = FormatJson::decode(
+   file_get_contents( "$IP/docs/extension.schema.json" ),
+   true
+   );
+   $missing = [];
+   foreach ( $globalSettings as $global ) {
+   if ( !isset( $schema['properties'][$global] ) ) {
+   $missing[] = $global;
+   }
+   }
+
+   $this->assertEquals( [], $missing, "The following global 
settings are not documented in docs/extension.schema.json" );
+   }
 }
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/293811
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If0ed09ed19b92934e869bbd40d8716a83e4b0a30
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits