[MediaWiki-commits] [Gerrit] wikipedia...ProveIt[master]: Add reference count

2016-10-17 Thread Sophivorus (Code Review)
Sophivorus has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316365

Change subject: Add reference count
..

Add reference count

Also an exception for the way quotes are displayed

Change-Id: I5230ef9846035b4ff73a0eeffb148124d7b57ac8
---
M proveit.css
M proveit.js
2 files changed, 16 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikipedia/gadgets/ProveIt 
refs/changes/65/316365/1

diff --git a/proveit.css b/proveit.css
index e809606..8d006bf 100755
--- a/proveit.css
+++ b/proveit.css
@@ -60,10 +60,6 @@
padding: 10px;
 }
 
-#proveit-reference-list .proveit-reference-item:nth-child(odd) {
-   background: #f4f4f4;
-}
-
 #proveit-reference-list .proveit-reference-item:nth-child(even) {
background: #fff;
 }
@@ -117,7 +113,7 @@
display: table-cell;
padding: 5px;
vertical-align: top;
-   width: 200px;
+   width: 180px;
 }
 
 #proveit-reference-form .proveit-required label {
diff --git a/proveit.js b/proveit.js
index 7392b14..b3bedbb 100755
--- a/proveit.js
+++ b/proveit.js
@@ -25,7 +25,7 @@
 */
messages: {
'en': {
-   'proveit-list-tab': 'List',
+   'proveit-list-tab': 'List ($1)',
'proveit-add-tab': 'Add',
'proveit-reference-name-label': 'Reference name',
'proveit-reference-content-label': 'Reference content',
@@ -40,7 +40,7 @@
'proveit-no-references': 'No references found'
},
'es': {
-   'proveit-list-tab': 'Lista',
+   'proveit-list-tab': 'Lista ($1)',
'proveit-add-tab': 'Agregar',
'proveit-reference-name-label': 'Nombre de la 
referencia',
'proveit-reference-content-label': 'Contenido de la 
referencia',
@@ -55,7 +55,7 @@
'proveit-no-references': 'No se han encontrado 
referencias'
},
'fr': {
-   'proveit-list-tab': 'Lister',
+   'proveit-list-tab': 'Lister ($1)',
'proveit-add-tab': 'Ajouter',
'proveit-reference-name-label': 'Nom de la référence',
'proveit-reference-content-label': 'Contenu de la 
référence',
@@ -70,7 +70,7 @@
'proveit-no-references': 'Aucune référence trouvée'
},
'ru': {
-   'proveit-list-tab': 'Список',
+   'proveit-list-tab': 'Список ($1)',
'proveit-add-tab': 'Добавить',
'proveit-reference-name-label': 'Имя сноски',
'proveit-reference-content-label': 'Содержание сноски',
@@ -121,10 +121,11 @@
 * Convenience method to get a ProveIt message
 *
 * @param {string} message key without the "proveit-" prefix
+* @param {int} number of references
 * @return {string} message value
 */
-   getMessage: function ( key ) {
-   return mw.message( 'proveit-' + key ).text();
+   getMessage: function ( key, param ) {
+   return mw.message( 'proveit-' + key, param );
},
 
/**
@@ -212,7 +213,7 @@
logo = $( '' ).attr( 'id', 'proveit-logo' ).text( 
'ProveIt' ),
leftBracket = $( '' ).attr( 'id', 
'proveit-left-bracket' ).text( '[' ),
rightBracket = $( '' ).attr( 'id', 
'proveit-right-bracket' ).text( ']' ),
-   listTab = $( '' ).attr( 'id', 'proveit-list-tab' 
).addClass( 'active' ).text( proveit.getMessage( 'list-tab' ) ),
+   listTab = $( '' ).attr( 'id', 'proveit-list-tab' 
).addClass( 'active' ).text( proveit.getMessage( 'list-tab', 0 ) ),
addTab = $( '' ).attr( 'id', 'proveit-add-tab' 
).text( proveit.getMessage( 'add-tab' ) ),
content = $( '' ).attr( 'id', 'proveit-content' );
 
@@ -335,9 +336,10 @@
// Add the item to the list
referenceList.append( referenceItem );
}
-
+   $( '#proveit-list-tab' ).text( proveit.getMessage( 
'list-tab', i ) );
$( '#proveit-content' ).html( referenceList );
} else {
+   $( '#proveit-list-tab' ).text( proveit.getMessage( 
'list-tab', 0 ) );
$( '#proveit-content' ).html( $( '' ).attr( 'id', 
'proveit-no-references-message' ).text( proveit.getMessage( 'no-references' ) ) 
);
}
},
@@ -996,6 +998,11 @@
paramNameInput = $( '' ).attr( 'type', 
'hidden' ).addClass( 

[MediaWiki-commits] [Gerrit] wikipedia...ProveIt[master]: Add reference count

2016-10-17 Thread Sophivorus (Code Review)
Sophivorus has submitted this change and it was merged.

Change subject: Add reference count
..


Add reference count

Also an exception for the way quotes are displayed

Change-Id: I5230ef9846035b4ff73a0eeffb148124d7b57ac8
---
M proveit.css
M proveit.js
2 files changed, 16 insertions(+), 13 deletions(-)

Approvals:
  Sophivorus: Verified; Looks good to me, approved



diff --git a/proveit.css b/proveit.css
index e809606..8d006bf 100755
--- a/proveit.css
+++ b/proveit.css
@@ -60,10 +60,6 @@
padding: 10px;
 }
 
-#proveit-reference-list .proveit-reference-item:nth-child(odd) {
-   background: #f4f4f4;
-}
-
 #proveit-reference-list .proveit-reference-item:nth-child(even) {
background: #fff;
 }
@@ -117,7 +113,7 @@
display: table-cell;
padding: 5px;
vertical-align: top;
-   width: 200px;
+   width: 180px;
 }
 
 #proveit-reference-form .proveit-required label {
diff --git a/proveit.js b/proveit.js
index 7392b14..b3bedbb 100755
--- a/proveit.js
+++ b/proveit.js
@@ -25,7 +25,7 @@
 */
messages: {
'en': {
-   'proveit-list-tab': 'List',
+   'proveit-list-tab': 'List ($1)',
'proveit-add-tab': 'Add',
'proveit-reference-name-label': 'Reference name',
'proveit-reference-content-label': 'Reference content',
@@ -40,7 +40,7 @@
'proveit-no-references': 'No references found'
},
'es': {
-   'proveit-list-tab': 'Lista',
+   'proveit-list-tab': 'Lista ($1)',
'proveit-add-tab': 'Agregar',
'proveit-reference-name-label': 'Nombre de la 
referencia',
'proveit-reference-content-label': 'Contenido de la 
referencia',
@@ -55,7 +55,7 @@
'proveit-no-references': 'No se han encontrado 
referencias'
},
'fr': {
-   'proveit-list-tab': 'Lister',
+   'proveit-list-tab': 'Lister ($1)',
'proveit-add-tab': 'Ajouter',
'proveit-reference-name-label': 'Nom de la référence',
'proveit-reference-content-label': 'Contenu de la 
référence',
@@ -70,7 +70,7 @@
'proveit-no-references': 'Aucune référence trouvée'
},
'ru': {
-   'proveit-list-tab': 'Список',
+   'proveit-list-tab': 'Список ($1)',
'proveit-add-tab': 'Добавить',
'proveit-reference-name-label': 'Имя сноски',
'proveit-reference-content-label': 'Содержание сноски',
@@ -121,10 +121,11 @@
 * Convenience method to get a ProveIt message
 *
 * @param {string} message key without the "proveit-" prefix
+* @param {int} number of references
 * @return {string} message value
 */
-   getMessage: function ( key ) {
-   return mw.message( 'proveit-' + key ).text();
+   getMessage: function ( key, param ) {
+   return mw.message( 'proveit-' + key, param );
},
 
/**
@@ -212,7 +213,7 @@
logo = $( '' ).attr( 'id', 'proveit-logo' ).text( 
'ProveIt' ),
leftBracket = $( '' ).attr( 'id', 
'proveit-left-bracket' ).text( '[' ),
rightBracket = $( '' ).attr( 'id', 
'proveit-right-bracket' ).text( ']' ),
-   listTab = $( '' ).attr( 'id', 'proveit-list-tab' 
).addClass( 'active' ).text( proveit.getMessage( 'list-tab' ) ),
+   listTab = $( '' ).attr( 'id', 'proveit-list-tab' 
).addClass( 'active' ).text( proveit.getMessage( 'list-tab', 0 ) ),
addTab = $( '' ).attr( 'id', 'proveit-add-tab' 
).text( proveit.getMessage( 'add-tab' ) ),
content = $( '' ).attr( 'id', 'proveit-content' );
 
@@ -335,9 +336,10 @@
// Add the item to the list
referenceList.append( referenceItem );
}
-
+   $( '#proveit-list-tab' ).text( proveit.getMessage( 
'list-tab', i ) );
$( '#proveit-content' ).html( referenceList );
} else {
+   $( '#proveit-list-tab' ).text( proveit.getMessage( 
'list-tab', 0 ) );
$( '#proveit-content' ).html( $( '' ).attr( 'id', 
'proveit-no-references-message' ).text( proveit.getMessage( 'no-references' ) ) 
);
}
},
@@ -996,6 +998,11 @@
paramNameInput = $( '' ).attr( 'type', 
'hidden' ).addClass( 'proveit-param-name' ).val( paramName );