Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/247565
Change subject: [RFC] allow paragraphed singled lines comments ...................................................................... [RFC] allow paragraphed singled lines comments I tend to like comments such as: function do() { // Some topic // // Paragraph 1 // // Paragraph 2 Introduce two test cases exercising this style. But maybe instead I should use: function do() { /** * Some topic * * Paragraph 1 * * Paragraph 2 */ But that is a bit cumbersome for comments inside a functions. Change-Id: I57869bd6c26a1e4973861c2b7731e74ea493d6ee --- M MediaWiki/Tests/files/WhiteSpace/space_after_delim_singleline_comment_fail.php M MediaWiki/Tests/files/WhiteSpace/space_after_delim_singleline_comment_pass.php 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer refs/changes/65/247565/1 diff --git a/MediaWiki/Tests/files/WhiteSpace/space_after_delim_singleline_comment_fail.php b/MediaWiki/Tests/files/WhiteSpace/space_after_delim_singleline_comment_fail.php index c5016dc..04f17f6 100644 --- a/MediaWiki/Tests/files/WhiteSpace/space_after_delim_singleline_comment_fail.php +++ b/MediaWiki/Tests/files/WhiteSpace/space_after_delim_singleline_comment_fail.php @@ -6,3 +6,5 @@ //A comment without a space #Yup, no spaces. +// Multline comments with empty last line +// diff --git a/MediaWiki/Tests/files/WhiteSpace/space_after_delim_singleline_comment_pass.php b/MediaWiki/Tests/files/WhiteSpace/space_after_delim_singleline_comment_pass.php index 3d4e9b8..5cb8f48 100644 --- a/MediaWiki/Tests/files/WhiteSpace/space_after_delim_singleline_comment_pass.php +++ b/MediaWiki/Tests/files/WhiteSpace/space_after_delim_singleline_comment_pass.php @@ -2,3 +2,7 @@ // a valid comment. # another valid comment. /* a comment no warnings would be raised on */ + +// Multiline comment +// +// With multiple paragraphs -- To view, visit https://gerrit.wikimedia.org/r/247565 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I57869bd6c26a1e4973861c2b7731e74ea493d6ee Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/codesniffer Gerrit-Branch: master Gerrit-Owner: Hashar <has...@free.fr> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits