Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224216
Change subject: [WIP] TargetLoader: Use an OOUI MessageDialog, not
window.alert()
......................................................................
[WIP] TargetLoader: Use an OOUI MessageDialog, not window.alert()
Needs OOUI to be loaded by default on all page views so that adding a
dependency isn't be too expensive.
Change-Id: Ib6a217c988322ad17bc7e649c3281eb053b54bbc
---
M modules/ve-mw/init/ve.init.mw.TargetLoader.js
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/16/224216/1
diff --git a/modules/ve-mw/init/ve.init.mw.TargetLoader.js
b/modules/ve-mw/init/ve.init.mw.TargetLoader.js
index 10149d0..9b40767 100644
--- a/modules/ve-mw/init/ve.init.mw.TargetLoader.js
+++ b/modules/ve-mw/init/ve.init.mw.TargetLoader.js
@@ -144,7 +144,15 @@
// Page does not exist,
so let the user start with a blank document.
return
$.Deferred().resolve( '' ).promise();
} else {
- window.alert( mw.msg(
'visualeditor-loaderror-message', 'HTTP ' + response.status ) );
+ var messageDialog = new
OO.ui.MessageDialog(),
+ windowManager =
new OO.ui.WindowManager();
+
+ $( 'body' ).append(
windowManager.$element );
+
windowManager.addWindows( [ messageDialog ] );
+
windowManager.openWindow( messageDialog, {
+ title: mw.msg(
'visualeditor-loaderror-title' ),
+ message:
mw.msg( 'visualeditor-loaderror-message', 'HTTP ' + response.status )
+ } );
mw.log.warn( 'RESTBase
load failed: ' + response.statusText );
}
--
To view, visit https://gerrit.wikimedia.org/r/224216
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6a217c988322ad17bc7e649c3281eb053b54bbc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
