[MediaWiki-commits] [Gerrit] Add default properties for the password reset form skip button - change (mediawiki/core)

2016-06-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Add default properties for the password reset form skip button
..


Add default properties for the password reset form skip button

Make "skip" the last option (so it's not the default action when
the user presses enter in a text field) and do not mark it as
primary/constructive as there shouldn't be multiple such buttons.

Bug: T136894
Change-Id: I2a8cd4850f740240520732b1b54d7876f25a00b8
(cherry picked from commit e7945edb0f07c7ce38d3e092615d5c093fd740e9)
---
M includes/specialpage/LoginSignupSpecialPage.php
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Gergő Tisza: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specialpage/LoginSignupSpecialPage.php 
b/includes/specialpage/LoginSignupSpecialPage.php
index 8dff163..d8f5e66 100644
--- a/includes/specialpage/LoginSignupSpecialPage.php
+++ b/includes/specialpage/LoginSignupSpecialPage.php
@@ -1050,6 +1050,11 @@
], $this->msg( 'userlogin-helplink2' 
)->text() ),
'weight' => 200,
],
+   // button for 
ResetPasswordSecondaryAuthenticationProvider
+   'skipReset' => [
+   'weight' => 110,
+   'flags' => [],
+   ],
];
}
$fieldDefinitions['username'] += [

-- 
To view, visit https://gerrit.wikimedia.org/r/293636
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a8cd4850f740240520732b1b54d7876f25a00b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.28.0-wmf.5
Gerrit-Owner: Gergő Tisza 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add default properties for the password reset form skip button - change (mediawiki/core)

2016-06-09 Thread Code Review 
Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/293636

Change subject: Add default properties for the password reset form skip button
..

Add default properties for the password reset form skip button

Make "skip" the last option (so it's not the default action when
the user presses enter in a text field) and do not mark it as
primary/constructive as there shouldn't be multiple such buttons.

Bug: T136894
Change-Id: I2a8cd4850f740240520732b1b54d7876f25a00b8
(cherry picked from commit e7945edb0f07c7ce38d3e092615d5c093fd740e9)
---
M includes/specialpage/LoginSignupSpecialPage.php
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/36/293636/1

diff --git a/includes/specialpage/LoginSignupSpecialPage.php 
b/includes/specialpage/LoginSignupSpecialPage.php
index 8dff163..d8f5e66 100644
--- a/includes/specialpage/LoginSignupSpecialPage.php
+++ b/includes/specialpage/LoginSignupSpecialPage.php
@@ -1050,6 +1050,11 @@
], $this->msg( 'userlogin-helplink2' 
)->text() ),
'weight' => 200,
],
+   // button for 
ResetPasswordSecondaryAuthenticationProvider
+   'skipReset' => [
+   'weight' => 110,
+   'flags' => [],
+   ],
];
}
$fieldDefinitions['username'] += [

-- 
To view, visit https://gerrit.wikimedia.org/r/293636
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a8cd4850f740240520732b1b54d7876f25a00b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.28.0-wmf.5
Gerrit-Owner: Gergő Tisza 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add default properties for the password reset form skip button - change (mediawiki/core)

2016-06-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Add default properties for the password reset form skip button
..


Add default properties for the password reset form skip button

Make "skip" the last option (so it's not the default action when
the user presses enter in a text field) and do not mark it as
primary/constructive as there shouldn't be multiple such buttons.

Bug: T136894
Change-Id: I2a8cd4850f740240520732b1b54d7876f25a00b8
(cherry picked from commit e7945edb0f07c7ce38d3e092615d5c093fd740e9)
---
M includes/specialpage/LoginSignupSpecialPage.php
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Gergő Tisza: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specialpage/LoginSignupSpecialPage.php 
b/includes/specialpage/LoginSignupSpecialPage.php
index 5fe8d7c..c7aed77 100644
--- a/includes/specialpage/LoginSignupSpecialPage.php
+++ b/includes/specialpage/LoginSignupSpecialPage.php
@@ -1061,6 +1061,11 @@
], $this->msg( 'userlogin-helplink2' 
)->text() ),
'weight' => 200,
],
+   // button for 
ResetPasswordSecondaryAuthenticationProvider
+   'skipReset' => [
+   'weight' => 110,
+   'flags' => [],
+   ],
];
}
$fieldDefinitions['username'] += [

-- 
To view, visit https://gerrit.wikimedia.org/r/293542
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a8cd4850f740240520732b1b54d7876f25a00b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_27
Gerrit-Owner: Gergő Tisza 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add default properties for the password reset form skip button - change (mediawiki/core)

2016-06-09 Thread Code Review 
Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/293542

Change subject: Add default properties for the password reset form skip button
..

Add default properties for the password reset form skip button

Make "skip" the last option (so it's not the default action when
the user presses enter in a text field) and do not mark it as
primary/constructive as there shouldn't be multiple such buttons.

Bug: T136894
Change-Id: I2a8cd4850f740240520732b1b54d7876f25a00b8
(cherry picked from commit e7945edb0f07c7ce38d3e092615d5c093fd740e9)
---
M includes/specialpage/LoginSignupSpecialPage.php
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/42/293542/1

diff --git a/includes/specialpage/LoginSignupSpecialPage.php 
b/includes/specialpage/LoginSignupSpecialPage.php
index 5fe8d7c..c7aed77 100644
--- a/includes/specialpage/LoginSignupSpecialPage.php
+++ b/includes/specialpage/LoginSignupSpecialPage.php
@@ -1061,6 +1061,11 @@
], $this->msg( 'userlogin-helplink2' 
)->text() ),
'weight' => 200,
],
+   // button for 
ResetPasswordSecondaryAuthenticationProvider
+   'skipReset' => [
+   'weight' => 110,
+   'flags' => [],
+   ],
];
}
$fieldDefinitions['username'] += [

-- 
To view, visit https://gerrit.wikimedia.org/r/293542
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a8cd4850f740240520732b1b54d7876f25a00b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_27
Gerrit-Owner: Gergő Tisza 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add default properties for the password reset form skip button - change (mediawiki/core)

2016-06-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Add default properties for the password reset form skip button
..


Add default properties for the password reset form skip button

Make "skip" the last option (so it's not the default action when
the user presses enter in a text field) and do not mark it as
primary/constructive as there shouldn't be multiple such buttons.

Bug: T136894
Change-Id: I2a8cd4850f740240520732b1b54d7876f25a00b8
---
M includes/specialpage/LoginSignupSpecialPage.php
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Anomie: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specialpage/LoginSignupSpecialPage.php 
b/includes/specialpage/LoginSignupSpecialPage.php
index 8dff163..d8f5e66 100644
--- a/includes/specialpage/LoginSignupSpecialPage.php
+++ b/includes/specialpage/LoginSignupSpecialPage.php
@@ -1050,6 +1050,11 @@
], $this->msg( 'userlogin-helplink2' 
)->text() ),
'weight' => 200,
],
+   // button for 
ResetPasswordSecondaryAuthenticationProvider
+   'skipReset' => [
+   'weight' => 110,
+   'flags' => [],
+   ],
];
}
$fieldDefinitions['username'] += [

-- 
To view, visit https://gerrit.wikimedia.org/r/293536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a8cd4850f740240520732b1b54d7876f25a00b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add default properties for the password reset form skip button - change (mediawiki/core)

2016-06-09 Thread Code Review 
Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/293536

Change subject: Add default properties for the password reset form skip button
..

Add default properties for the password reset form skip button

Make "skip" the last option (so it's not the default action when
the user presses enter in a text field) and do not mark it as
primary/constructive as there shouldn't be multiple such buttons.

Bug: T136894
Change-Id: I2a8cd4850f740240520732b1b54d7876f25a00b8
---
M includes/specialpage/LoginSignupSpecialPage.php
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/36/293536/1

diff --git a/includes/specialpage/LoginSignupSpecialPage.php 
b/includes/specialpage/LoginSignupSpecialPage.php
index 8dff163..d8f5e66 100644
--- a/includes/specialpage/LoginSignupSpecialPage.php
+++ b/includes/specialpage/LoginSignupSpecialPage.php
@@ -1050,6 +1050,11 @@
], $this->msg( 'userlogin-helplink2' 
)->text() ),
'weight' => 200,
],
+   // button for 
ResetPasswordSecondaryAuthenticationProvider
+   'skipReset' => [
+   'weight' => 110,
+   'flags' => [],
+   ],
];
}
$fieldDefinitions['username'] += [

-- 
To view, visit https://gerrit.wikimedia.org/r/293536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a8cd4850f740240520732b1b54d7876f25a00b8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits