[MediaWiki-commits] [Gerrit] Add method to toggle the AceEditorWidget print margin - change (mediawiki...VisualEditor)

2015-11-18 Thread Tchanders (Code Review) 
Tchanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/254034

Change subject: Add method to toggle the AceEditorWidget print margin
..

Add method to toggle the AceEditorWidget print margin

Change-Id: I758f90abb92a91491237150f607e7b0f93bf8f85
---
M modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
1 file changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/34/254034/1

diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js 
b/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
index 83449ca..1ff6513 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
@@ -253,6 +253,20 @@
 };
 
 /**
+ * Toggle the visibility of the print margin
+ *
+ * @param {boolean} visible Visible
+ * @chainable
+ */
+ve.ui.MWAceEditorWidget.prototype.togglePrintMargin = function ( visible ) {
+   var widget = this;
+   this.loadingPromise.done( function () {
+   widget.editor.renderer.setShowPrintMargin( visible );
+   } );
+   return this;
+};
+
+/**
  * Set the language mode of the editor (programming language)
  *
  * @param {string} lang Language

-- 
To view, visit https://gerrit.wikimedia.org/r/254034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I758f90abb92a91491237150f607e7b0f93bf8f85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Tchanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add method to toggle the AceEditorWidget print margin - change (mediawiki...VisualEditor)

2015-11-18 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Add method to toggle the AceEditorWidget print margin
..


Add method to toggle the AceEditorWidget print margin

Change-Id: I758f90abb92a91491237150f607e7b0f93bf8f85
---
M modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  Esanders: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js 
b/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
index 83449ca..1ff6513 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
@@ -253,6 +253,20 @@
 };
 
 /**
+ * Toggle the visibility of the print margin
+ *
+ * @param {boolean} visible Visible
+ * @chainable
+ */
+ve.ui.MWAceEditorWidget.prototype.togglePrintMargin = function ( visible ) {
+   var widget = this;
+   this.loadingPromise.done( function () {
+   widget.editor.renderer.setShowPrintMargin( visible );
+   } );
+   return this;
+};
+
+/**
  * Set the language mode of the editor (programming language)
  *
  * @param {string} lang Language

-- 
To view, visit https://gerrit.wikimedia.org/r/254034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I758f90abb92a91491237150f607e7b0f93bf8f85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Tchanders 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits