[MediaWiki-commits] [Gerrit] Change-Prop: White-list user-agent header header in http filter - change (operations/puppet)

2016-05-31 Thread Jcrespo (Code Review) 
Jcrespo has submitted this change and it was merged.

Change subject: Change-Prop: White-list user-agent header header in http filter
..


Change-Prop: White-list user-agent header header in http filter

After https://github.com/wikimedia/hyperswitch/pull/41 we're
white-listing all the headers passed to backend services to avoid
distributing personal indentifyable information to untrusted
desctinations. But in change-prop we need to explicitly allow
user-agent header to be sent to the services.

Change-Id: I6d0c51ae5394eb7419fce0f11e07d87fbd1e4eb3
---
M modules/changeprop/templates/config.yaml.erb
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jcrespo: Looks good to me, approved
  Mobrovac: Looks good to me, but someone else must approve
  Alexandros Kosiaris: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/modules/changeprop/templates/config.yaml.erb 
b/modules/changeprop/templates/config.yaml.erb
index 436a0f6..842d41c 100644
--- a/modules/changeprop/templates/config.yaml.erb
+++ b/modules/changeprop/templates/config.yaml.erb
@@ -6,6 +6,8 @@
   options:
 allow:
   - pattern: /^https?:\/\//
+forward_headers:
+  user-agent: true
   title: The Change Propagation root
   paths:
 /{api:sys}/purge:

-- 
To view, visit https://gerrit.wikimedia.org/r/291784
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6d0c51ae5394eb7419fce0f11e07d87fbd1e4eb3
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ppchelko 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Change-Prop: White-list user-agent header header in http filter - change (operations/puppet)

2016-05-30 Thread Ppchelko (Code Review) 
Ppchelko has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291784

Change subject: Change-Prop: White-list user-agent header header in http filter
..

Change-Prop: White-list user-agent header header in http filter

After https://github.com/wikimedia/hyperswitch/pull/41 we're
white-listing all the headers passed to backend services to avoid
distributing personal indentifyable information to untrusted
desctinations. But in change-prop we need to explicitly allow
user-agent header to be sent to the services.

Change-Id: I6d0c51ae5394eb7419fce0f11e07d87fbd1e4eb3
---
M modules/changeprop/templates/config.yaml.erb
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/84/291784/1

diff --git a/modules/changeprop/templates/config.yaml.erb 
b/modules/changeprop/templates/config.yaml.erb
index 436a0f6..842d41c 100644
--- a/modules/changeprop/templates/config.yaml.erb
+++ b/modules/changeprop/templates/config.yaml.erb
@@ -6,6 +6,8 @@
   options:
 allow:
   - pattern: /^https?:\/\//
+forward_headers:
+  user-agent: true
   title: The Change Propagation root
   paths:
 /{api:sys}/purge:

-- 
To view, visit https://gerrit.wikimedia.org/r/291784
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d0c51ae5394eb7419fce0f11e07d87fbd1e4eb3
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits