[MediaWiki-commits] [Gerrit] Clear out expensive js landmine - change (mediawiki...DonationInterface)

2016-06-03 Thread Ejegg (Code Review) 
Ejegg has submitted this change and it was merged.

Change subject: Clear out expensive js landmine
..


Clear out expensive js landmine

Wowow, this one sucked.

Change-Id: I9d8b88c95193260962e22544d1f929257347e507
---
M adyen_gateway/forms/js/adyen.js
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Ejegg: Verified; Looks good to me, approved



diff --git a/adyen_gateway/forms/js/adyen.js b/adyen_gateway/forms/js/adyen.js
index dee5736..d223505 100644
--- a/adyen_gateway/forms/js/adyen.js
+++ b/adyen_gateway/forms/js/adyen.js
@@ -7,13 +7,12 @@
 
var sendData,
$payment,
-   $pForm,
-   currency_code = 'USD';
+   $pForm;
 
sendData = {
action: 'donate',
gateway: 'adyen',
-   currency_code: currency_code,
+   currency_code: $( '#currency_code' ).val(),
amount: $( '#amount' ).val(),
fname: $( '#fname' ).val(),
lname: $( '#lname' ).val(),

-- 
To view, visit https://gerrit.wikimedia.org/r/292629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d8b88c95193260962e22544d1f929257347e507
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: deployment
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: Ejegg 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Clear out expensive js landmine - change (mediawiki...DonationInterface)

2016-06-03 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/292629

Change subject: Clear out expensive js landmine
..

Clear out expensive js landmine

Wowow, this one sucked.

Change-Id: I9d8b88c95193260962e22544d1f929257347e507
---
M adyen_gateway/forms/js/adyen.js
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/29/292629/1

diff --git a/adyen_gateway/forms/js/adyen.js b/adyen_gateway/forms/js/adyen.js
index dee5736..d223505 100644
--- a/adyen_gateway/forms/js/adyen.js
+++ b/adyen_gateway/forms/js/adyen.js
@@ -7,13 +7,12 @@
 
var sendData,
$payment,
-   $pForm,
-   currency_code = 'USD';
+   $pForm;
 
sendData = {
action: 'donate',
gateway: 'adyen',
-   currency_code: currency_code,
+   currency_code: $( '#currency_code' ).val(),
amount: $( '#amount' ).val(),
fname: $( '#fname' ).val(),
lname: $( '#lname' ).val(),

-- 
To view, visit https://gerrit.wikimedia.org/r/292629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d8b88c95193260962e22544d1f929257347e507
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: deployment
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Clear out expensive js landmine - change (mediawiki...DonationInterface)

2016-06-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Clear out expensive js landmine
..


Clear out expensive js landmine

Wowow, this one sucked.

Change-Id: I9d8b88c95193260962e22544d1f929257347e507
---
M adyen_gateway/forms/js/adyen.js
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Awight: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/adyen_gateway/forms/js/adyen.js b/adyen_gateway/forms/js/adyen.js
index dee5736..d223505 100644
--- a/adyen_gateway/forms/js/adyen.js
+++ b/adyen_gateway/forms/js/adyen.js
@@ -7,13 +7,12 @@
 
var sendData,
$payment,
-   $pForm,
-   currency_code = 'USD';
+   $pForm;
 
sendData = {
action: 'donate',
gateway: 'adyen',
-   currency_code: currency_code,
+   currency_code: $( '#currency_code' ).val(),
amount: $( '#amount' ).val(),
fname: $( '#fname' ).val(),
lname: $( '#lname' ).val(),

-- 
To view, visit https://gerrit.wikimedia.org/r/292628
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d8b88c95193260962e22544d1f929257347e507
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: AndyRussG 
Gerrit-Reviewer: Awight 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: Ssmith 
Gerrit-Reviewer: XenoRyet 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Clear out expensive js landmine - change (mediawiki...DonationInterface)

2016-06-03 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/292628

Change subject: Clear out expensive js landmine
..

Clear out expensive js landmine

Wowow, this one sucked.

Change-Id: I9d8b88c95193260962e22544d1f929257347e507
---
M adyen_gateway/forms/js/adyen.js
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/28/292628/1

diff --git a/adyen_gateway/forms/js/adyen.js b/adyen_gateway/forms/js/adyen.js
index dee5736..d223505 100644
--- a/adyen_gateway/forms/js/adyen.js
+++ b/adyen_gateway/forms/js/adyen.js
@@ -7,13 +7,12 @@
 
var sendData,
$payment,
-   $pForm,
-   currency_code = 'USD';
+   $pForm;
 
sendData = {
action: 'donate',
gateway: 'adyen',
-   currency_code: currency_code,
+   currency_code: $( '#currency_code' ).val(),
amount: $( '#amount' ).val(),
fname: $( '#fname' ).val(),
lname: $( '#lname' ).val(),

-- 
To view, visit https://gerrit.wikimedia.org/r/292628
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d8b88c95193260962e22544d1f929257347e507
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits