Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179417
Change subject: Correct the range overlap checking algorithm
......................................................................
Correct the range overlap checking algorithm
Test case: Editor-in-chief page from en to ca, see the first paragraph
Change-Id: I3c5d756cfc4bc44d0d9a1d43442ef9019330ae8f
---
M mt/MTClient.js
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/cxserver
refs/changes/17/179417/1
diff --git a/mt/MTClient.js b/mt/MTClient.js
index 0ad344b..129b2a5 100644
--- a/mt/MTClient.js
+++ b/mt/MTClient.js
@@ -227,12 +227,13 @@
* range array
*/
function isOverlappingRange( range, rangeArray ) {
- var i;
+ var i, rangeEnd, start, end;
+ rangeEnd = range.start + range.length;
for ( i = 0; i < rangeArray.length; i++ ) {
- if ( rangeArray[ i ].start <= range.start &&
- rangeArray[ i ].start + rangeArray[ i ].length >=
range.start + range.length
- ) {
+ start = rangeArray[ i ].start;
+ end = start + rangeArray[ i ].length;
+ if ( start <= range.start && end >= rangeEnd || end < rangeEnd
) {
return true;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/179417
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c5d756cfc4bc44d0d9a1d43442ef9019330ae8f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
