Markus Kroetzsch has submitted this change and it was merged. Change subject: Corrected handling of error DIs and DVs ......................................................................
Corrected handling of error DIs and DVs Error were wrongly assigned the String DI type in some contexts, although they only generate DIs of type error. Reporting error as a type should lead to earlier failures in case any code tries to use an error like a value somewhere. Change-Id: Ic78a9f86a9dc9a4fb27e10e537d9890cf00133f8 --- M includes/SMW_DataValueFactory.php M includes/datavalues/SMW_DV_Error.php 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28056 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic78a9f86a9dc9a4fb27e10e537d9890cf00133f8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch <mar...@semantic-mediawiki.org> Gerrit-Reviewer: Markus Kroetzsch <mar...@semantic-mediawiki.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
