Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174679
Change subject: Do not call click on undefined
......................................................................
Do not call click on undefined
Not all pages in a MediaWiki installation do have an edit link. For
example the pages in Wikidata do not have it.
Bug: 57713
Change-Id: I842c1224d15887d59eab73f2b222c232a05c0bd9
---
M resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/79/174679/1
diff --git
a/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
b/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
index 3c22851..6ef5d32 100644
--- a/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
+++ b/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js
@@ -8,7 +8,8 @@
if ( parseInt( mw.user.options.get( 'editondblclick' ),
10 ) ) {
e.preventDefault();
// Trigger native HTMLElement click instead of
opening URL (bug 43052)
- $( '#ca-edit a' ).get( 0 ).click();
+ var $a = $( '#ca-edit a' ).get( 0 );
+ $a && $a.click();
}
} );
} );
--
To view, visit https://gerrit.wikimedia.org/r/174679
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I842c1224d15887d59eab73f2b222c232a05c0bd9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
