jenkins-bot has submitted this change and it was merged.
Change subject: Don't try to use isAnon on non-object
......................................................................
Don't try to use isAnon on non-object
User::newFromName() can return a boolean instead of an user object, too.
Change-Id: Ia1b9028f59f678d6acf4ca82e7a8fca09d02bb54
---
M includes/specials/SpecialManageGoogleLogin.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialManageGoogleLogin.php
b/includes/specials/SpecialManageGoogleLogin.php
index bab2a92..134be45 100644
--- a/includes/specials/SpecialManageGoogleLogin.php
+++ b/includes/specials/SpecialManageGoogleLogin.php
@@ -68,7 +68,7 @@
return false;
}
$checkUser = User::newFromName( $data['username'] );
- if ( $checkUser->isAnon() ) {
+ if ( !$checkUser || $checkUser->isAnon() ) {
return wfMessage(
'googlelogin-manage-notexist', $data['username'] );
}
self::$manageableUser = $checkUser;
--
To view, visit https://gerrit.wikimedia.org/r/225603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1b9028f59f678d6acf4ca82e7a8fca09d02bb54
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/GoogleLogin
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
