Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/234424
Change subject: Don't use remote srcsets for locally saved images
......................................................................
Don't use remote srcsets for locally saved images
The image srcsets attribute should only be specified for images
downloaded from the network. For saved pages, only one image is kept
locally and that should be the only image considered. For this reason,
srcsets are now removed when remapping the remote image URLs to local
files.
Bug: T110487
Change-Id: If2b4642d7507a57085ed0a2185df0d04c1d8432e
---
M app/src/main/assets/bundle-test.js
M app/src/main/assets/bundle.js
M www/js/main.js
3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/24/234424/1
diff --git a/app/src/main/assets/bundle-test.js
b/app/src/main/assets/bundle-test.js
index e7569ba..9344b9c 100644
--- a/app/src/main/assets/bundle-test.js
+++ b/app/src/main/assets/bundle-test.js
@@ -80,6 +80,7 @@
var img = images[i];
img.setAttribute( "src", payload.newURL );
img.setAttribute( "data-old-src", payload.originalURL );
+ img.removeAttribute( "srcset" );
}
}
bridge.registerListener( "replaceImageSrc", replaceImageSrc );
diff --git a/app/src/main/assets/bundle.js b/app/src/main/assets/bundle.js
index 25404a2..8781aff 100644
--- a/app/src/main/assets/bundle.js
+++ b/app/src/main/assets/bundle.js
@@ -259,6 +259,7 @@
var img = images[i];
img.setAttribute( "src", payload.newURL );
img.setAttribute( "data-old-src", payload.originalURL );
+ img.removeAttribute( "srcset" );
}
}
bridge.registerListener( "replaceImageSrc", replaceImageSrc );
diff --git a/www/js/main.js b/www/js/main.js
index 4d5f75b..9730eb9 100644
--- a/www/js/main.js
+++ b/www/js/main.js
@@ -19,6 +19,7 @@
var img = images[i];
img.setAttribute( "src", payload.newURL );
img.setAttribute( "data-old-src", payload.originalURL );
+ img.removeAttribute( "srcset" );
}
}
bridge.registerListener( "replaceImageSrc", replaceImageSrc );
--
To view, visit https://gerrit.wikimedia.org/r/234424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2b4642d7507a57085ed0a2185df0d04c1d8432e
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
