Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/271734
Change subject: Fix PHP warning so XDebug doesn't complain
......................................................................
Fix PHP warning so XDebug doesn't complain
Change-Id: Id8f8113bcdc454d5df09a20175c7698791b71fba
---
M includes/formatters/SpecialNotificationsFormatter.php
1 file changed, 10 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/34/271734/1
diff --git a/includes/formatters/SpecialNotificationsFormatter.php
b/includes/formatters/SpecialNotificationsFormatter.php
index b318f15..fdb1329 100644
--- a/includes/formatters/SpecialNotificationsFormatter.php
+++ b/includes/formatters/SpecialNotificationsFormatter.php
@@ -44,13 +44,18 @@
}
$links = array_merge( $links, array_filter(
$model->getSecondaryLinks() ) );
foreach ( $links as $link ) {
+ $footerAttributes = array(
+ 'href' => $link['url'],
+ 'class' =>
'mw-echo-notification-footer-element',
+ );
+
+ if ( isset( $link['tooltip'] ) ) {
+ $footerAttributes['title'] = $link['tooltip'];
+ }
+
$footerItems[] = Html::element(
'a',
- array(
- 'href' => $link['url'],
- 'title' => $link['tooltip'],
- 'class' =>
'mw-echo-notification-footer-element',
- ),
+ $footerAttributes,
$link['label']
);
}
--
To view, visit https://gerrit.wikimedia.org/r/271734
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8f8113bcdc454d5df09a20175c7698791b71fba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
