jenkins-bot has submitted this change and it was merged.
Change subject: Fix V8 deopt for ve.ce.BranchNode#onSplice
......................................................................
Fix V8 deopt for ve.ce.BranchNode#onSplice
Fix "Not optimized: Bad value context for arguments value".
Change-Id: I8030d824a3274368b5fbfebf188556e14bd46076
---
M src/ce/ve.ce.BranchNode.js
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, but someone else must approve
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.BranchNode.js b/src/ce/ve.ce.BranchNode.js
index cbb4011..5ef8919 100644
--- a/src/ce/ve.ce.BranchNode.js
+++ b/src/ce/ve.ce.BranchNode.js
@@ -180,12 +180,16 @@
ve.ce.BranchNode.prototype.onSplice = function ( index ) {
var i, j,
length,
- args = Array.prototype.slice.call( arguments ),
+ args = [],
$anchor,
afterAnchor,
node,
parentNode,
removals;
+
+ for ( i = 0, length = arguments.length; i < length; i++ ) {
+ args.push( arguments[i] );
+ }
// Convert models to views and attach them to this node
if ( args.length >= 3 ) {
for ( i = 2, length = args.length; i < length; i++ ) {
--
To view, visit https://gerrit.wikimedia.org/r/189683
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8030d824a3274368b5fbfebf188556e14bd46076
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
