Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/250653
Change subject: Make HashBagOStuff LRU instead of least-recently-set
......................................................................
Make HashBagOStuff LRU instead of least-recently-set
Change-Id: I7985b98b6a346eaed8bf0a7349b95fabea8e8614
---
M includes/libs/objectcache/HashBagOStuff.php
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/53/250653/1
diff --git a/includes/libs/objectcache/HashBagOStuff.php
b/includes/libs/objectcache/HashBagOStuff.php
index 432d040..4b02499 100644
--- a/includes/libs/objectcache/HashBagOStuff.php
+++ b/includes/libs/objectcache/HashBagOStuff.php
@@ -62,12 +62,15 @@
protected function doGet( $key, $flags = 0 ) {
if ( !isset( $this->bag[$key] ) ) {
return false;
- }
-
- if ( $this->expire( $key ) ) {
+ } elseif ( $this->expire( $key ) ) {
return false;
}
+ // Refresh key position for maxCacheKeys eviction
+ $temp = $this->bag[$key];
+ unset( $this->bag[$key] );
+ $this->bag[$key] = $temp;
+
return $this->bag[$key][self::KEY_VAL];
}
--
To view, visit https://gerrit.wikimedia.org/r/250653
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7985b98b6a346eaed8bf0a7349b95fabea8e8614
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
