[MediaWiki-commits] [Gerrit] Prevent NPE - change (apps...wikipedia)

2016-06-20 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Prevent NPE
..


Prevent NPE

FeedFragment unbinds (nulls) its Views in onDestroyView(). Check the
Fragment state before interacting with the Views in an asynchronous
callback.

Change-Id: I2a0507f4da82e76886589cbe490575c421182865
---
M app/src/main/java/org/wikipedia/feed/FeedFragment.java
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Mholloway: Looks good to me, but someone else must approve
  Dbrant: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/java/org/wikipedia/feed/FeedFragment.java 
b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
index 1d84d45..9fa61f2 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
@@ -50,17 +50,15 @@
 coordinator.setFeedUpdateListener(new 
FeedCoordinator.FeedUpdateListener() {
 @Override
 public void update(List cards) {
-feedView.update();
+if (isAdded()) {
+feedView.update();
+}
 }
 });
 
 coordinator.more(app.getSite());
 
 return view;
-}
-
-@Override public void onResume() {
-super.onResume();
 }
 
 @Override public void onDestroyView() {

-- 
To view, visit https://gerrit.wikimedia.org/r/294377
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a0507f4da82e76886589cbe490575c421182865
Gerrit-PatchSet: 4
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Prevent NPE - change (apps...wikipedia)

2016-06-14 Thread Niedzielski (Code Review) 
Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/294377

Change subject: Prevent NPE
..

Prevent NPE

FeedFragment unbinds (nulls) its Views in onDestroyView(). Check the
Fragment state before interacting with the Views in an asynchronous
callback.

Change-Id: I2a0507f4da82e76886589cbe490575c421182865
---
M app/src/main/java/org/wikipedia/feed/FeedFragment.java
1 file changed, 3 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/77/294377/1

diff --git a/app/src/main/java/org/wikipedia/feed/FeedFragment.java 
b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
index 1d84d45..9fa61f2 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
@@ -50,17 +50,15 @@
 coordinator.setFeedUpdateListener(new 
FeedCoordinator.FeedUpdateListener() {
 @Override
 public void update(List cards) {
-feedView.update();
+if (isAdded()) {
+feedView.update();
+}
 }
 });
 
 coordinator.more(app.getSite());
 
 return view;
-}
-
-@Override public void onResume() {
-super.onResume();
 }
 
 @Override public void onDestroyView() {

-- 
To view, visit https://gerrit.wikimedia.org/r/294377
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a0507f4da82e76886589cbe490575c421182865
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits