Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/246801
Change subject: QA: Don't ask. Just merge.
......................................................................
QA: Don't ask. Just merge.
So after managing to replicate browser test failures locally
when running them against beta labs I managed to get them consistently
passing with this minimal change.
Dont' ask me why. I'm guessing it takes longer on beta labs to load
things... Race conditions etc. Just trust me on this.
Bug: T113534
Change-Id: Iffbdd4926cb9041b0c42280e5acd020ddabb952a
---
M tests/browser/features/external_survey.feature
M tests/browser/features/support/step_definitions/common_steps.rb
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickSurveys
refs/changes/01/246801/1
diff --git a/tests/browser/features/external_survey.feature
b/tests/browser/features/external_survey.feature
index ef8f529..0a99c00 100644
--- a/tests/browser/features/external_survey.feature
+++ b/tests/browser/features/external_survey.feature
@@ -6,6 +6,7 @@
Scenario: External survey is visible with flag
And I am on the "Quick survey test page stub" page with the external quick
survey flag enabled
+ And the page has fully loaded
Then I should see the survey
Scenario: External survey is not present without flag when not bucketed
diff --git a/tests/browser/features/support/step_definitions/common_steps.rb
b/tests/browser/features/support/step_definitions/common_steps.rb
index ed630e3..ddbeed5 100644
--- a/tests/browser/features/support/step_definitions/common_steps.rb
+++ b/tests/browser/features/support/step_definitions/common_steps.rb
@@ -78,6 +78,7 @@
page.execute_script(script)
end
end
+ sleep 2
end
Then(/^I should not see the survey$/) do
--
To view, visit https://gerrit.wikimedia.org/r/246801
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffbdd4926cb9041b0c42280e5acd020ddabb952a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuickSurveys
Gerrit-Branch: dev
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
