[MediaWiki-commits] [Gerrit] Remove unused toolbar destroying code - change (mediawiki...Wikibase)

2015-11-13 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove unused toolbar destroying code
..


Remove unused toolbar destroying code

At that point, the snakviews are gone already.

Change-Id: I568382d51f5f8c0a24074ca6d830ea67dc52d68a
---
M 
view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview-snakview.js
1 file changed, 0 insertions(+), 18 deletions(-)

Approvals:
  Thiemo Mättig (WMDE): Looks good to me, approved
  Jeroen De Dauw: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git 
a/view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview-snakview.js
 
b/view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview-snakview.js
index 4eb3960..467926b 100644
--- 
a/view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview-snakview.js
+++ 
b/view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview-snakview.js
@@ -37,24 +37,6 @@
toolbarcontroller.registerEventHandler(
event.data.toolbar.type,
event.data.toolbar.id,
-   'referenceviewafterstopediting',
-   function( event, toolbarcontroller ) {
-   // Destroy the snakview 
toolbars:
-   var $referenceviewNode = $( 
event.target );
-   $.each(
-   
$referenceviewNode.find( '.wikibase-snakview' ),
-   function( i, 
snakviewNode ) {
-   
toolbarcontroller.destroyToolbar(
-   $( 
snakviewNode ).data( 'removetoolbar' )
-   );
-   }
-   );
-   }
-   );
-
-   toolbarcontroller.registerEventHandler(
-   event.data.toolbar.type,
-   event.data.toolbar.id,
'referenceviewdisable 
listviewitemremoved',
function( event ) {
var $referenceview = 
event.type.indexOf( 'referenceview' ) !== -1

-- 
To view, visit https://gerrit.wikimedia.org/r/248831
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I568382d51f5f8c0a24074ca6d830ea67dc52d68a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove unused toolbar destroying code - change (mediawiki...Wikibase)

2015-10-26 Thread Adrian Lang (Code Review) 
Adrian Lang has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/248831

Change subject: Remove unused toolbar destroying code
..

Remove unused toolbar destroying code

At that point, the snakviews are gone already.

Change-Id: I568382d51f5f8c0a24074ca6d830ea67dc52d68a
---
M 
view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview-snakview.js
1 file changed, 0 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/31/248831/1

diff --git 
a/view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview-snakview.js
 
b/view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview-snakview.js
index 4eb3960..467926b 100644
--- 
a/view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview-snakview.js
+++ 
b/view/resources/jquery/wikibase/toolbar/controller/definitions/removetoolbar/referenceview-snakview.js
@@ -37,24 +37,6 @@
toolbarcontroller.registerEventHandler(
event.data.toolbar.type,
event.data.toolbar.id,
-   'referenceviewafterstopediting',
-   function( event, toolbarcontroller ) {
-   // Destroy the snakview 
toolbars:
-   var $referenceviewNode = $( 
event.target );
-   $.each(
-   
$referenceviewNode.find( '.wikibase-snakview' ),
-   function( i, 
snakviewNode ) {
-   
toolbarcontroller.destroyToolbar(
-   $( 
snakviewNode ).data( 'removetoolbar' )
-   );
-   }
-   );
-   }
-   );
-
-   toolbarcontroller.registerEventHandler(
-   event.data.toolbar.type,
-   event.data.toolbar.id,
'referenceviewdisable 
listviewitemremoved',
function( event ) {
var $referenceview = 
event.type.indexOf( 'referenceview' ) !== -1

-- 
To view, visit https://gerrit.wikimedia.org/r/248831
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I568382d51f5f8c0a24074ca6d830ea67dc52d68a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits