Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/235023
Change subject: Reuse test view in paste tests
......................................................................
Reuse test view in paste tests
Saves about 200ms locally.
Change-Id: I6f3bb8dbc90d77b1d7ecd597214025a360daf5b2
---
M tests/ce/ve.ce.Surface.test.js
1 file changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/23/235023/1
diff --git a/tests/ce/ve.ce.Surface.test.js b/tests/ce/ve.ce.Surface.test.js
index a49474e..1ee4b70 100644
--- a/tests/ce/ve.ce.Surface.test.js
+++ b/tests/ce/ve.ce.Surface.test.js
@@ -706,6 +706,7 @@
var i,
expected = 0,
exampleDoc = '<p id="foo"></p><p>Foo</p><h2> Baz
</h2><table><tbody><tr><td></td></tbody></table>',
+ exampleSurface = ve.test.utils.createSurfaceViewFromHtml(
exampleDoc ),
docLen = 24,
TestEvent = function ( data ) {
this.originalEvent = {
@@ -1118,7 +1119,7 @@
function testRunner( documentHtml, pasteHtml, fromVe, useClipboardData,
pasteTargetHtml, range, pasteSpecial, expectedOps, expectedRange, expectedHtml,
msg ) {
var i, j, txs, ops, txops, htmlDoc,
e = {},
- view = ve.test.utils.createSurfaceViewFromHtml(
documentHtml || exampleDoc ),
+ view = documentHtml ?
ve.test.utils.createSurfaceViewFromHtml( documentHtml ) : exampleSurface,
model = view.getModel(),
doc = model.getDocument();
@@ -1168,7 +1169,13 @@
htmlDoc = ve.dm.converter.getDomFromModel( doc );
assert.strictEqual( htmlDoc.body.innerHTML,
expectedHtml, msg + ': HTML' );
}
- view.destroy();
+ if ( view === exampleSurface ) {
+ while( model.hasBeenModified() ) {
+ model.undo();
+ }
+ } else {
+ view.destroy();
+ }
}
for ( i = 0; i < cases.length; i++ ) {
@@ -1180,6 +1187,8 @@
);
}
+ exampleSurface.destroy();
+
} );
QUnit.test( 'handleTableArrowKey', function ( assert ) {
--
To view, visit https://gerrit.wikimedia.org/r/235023
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f3bb8dbc90d77b1d7ecd597214025a360daf5b2
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
