Sbisson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/203462
Change subject: Set right position of fixed nav header.
......................................................................
Set right position of fixed nav header.
When scrolling down, the navigation header becomes fixed
to the top of the page. Its left property was set correctly
but the right property was not set. It was not aligned
correctly on right-to-left languages.
Bug: T93497
Change-Id: I2890cb094c6ab84f4215d3309da678229e69400f
---
M modules/engine/components/board/features/flow-board-navigation.js
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/62/203462/1
diff --git a/modules/engine/components/board/features/flow-board-navigation.js
b/modules/engine/components/board/features/flow-board-navigation.js
index 7b82230..870897e 100644
--- a/modules/engine/components/board/features/flow-board-navigation.js
+++ b/modules/engine/components/board/features/flow-board-navigation.js
@@ -177,7 +177,8 @@
// Un-affix this
$boardNavigation
.removeClass(
'flow-board-navigation-affixed' )
- .css( 'left', '' );
+ .css( 'left', '' )
+ .css( 'right', '' );
// Remove the old clone if it exists
this.$boardNavigationClone.remove();
delete this.$boardNavigationClone;
@@ -216,8 +217,11 @@
// The only thing that needs calculating is its left offset
if ( parseInt( $boardNavigation.css( 'left' ) ) !==
boardNavigationPosition.left ) {
+ var navBarRect =
this.$boardNavigationClone[0].getBoundingClientRect();
+ var right = document.documentElement.clientWidth -
navBarRect.right;
$boardNavigation.css( {
- left: boardNavigationPosition.left
+ left: boardNavigationPosition.left,
+ right: right
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/203462
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2890cb094c6ab84f4215d3309da678229e69400f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Sbisson <sbis...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
